oxlint-plugin-react-doctor 0.7.9-dev.d8a20e0 → 0.7.9-dev.e86bc57

package/dist/index.js

@@ -28469,7 +28469,11 @@ const isProvenNativeReadMethod = (ref, methodName) => Boolean(ref.resolved?.defs
 }));
 //#endregion
 //#region src/plugin/rules/state-and-effects/utils/effect/react.ts
-const KNOWN_PURE_HOC_NAMES = new Set(["memo", "forwardRef"]);
+const KNOWN_COMPONENT_WRAPPER_NAMES = new Set([
+	"memo",
+	"forwardRef",
+	"observer"
+]);
 const startsWithUppercase = (name) => Boolean(name && name.length > 0 && name[0] >= "A" && name[0] <= "Z");
 const isReactFunctionalComponent = (node) => {
 	if (!node) return false;
@@ -28491,7 +28495,7 @@ const isReactFunctionalHOC = (analysis, node) => {
 	const isWrappedInline = () => {
 		if (!isNodeOfType(init, "CallExpression")) return false;
 		if (!isNodeOfType(init.callee, "Identifier")) return false;
-		if (KNOWN_PURE_HOC_NAMES.has(init.callee.name)) return false;
+		if (KNOWN_COMPONENT_WRAPPER_NAMES.has(init.callee.name)) return false;
 		const firstArg = init.arguments?.[0];
 		if (!firstArg) return false;
 		return isNodeOfType(firstArg, "ArrowFunctionExpression") || isNodeOfType(firstArg, "FunctionExpression");
@@ -28511,7 +28515,7 @@ const isReactFunctionalHOC = (analysis, node) => {
 			if (!args.includes(refId)) continue;
 			const callee = parent.callee;
 			const calleeName = isNodeOfType(callee, "Identifier") ? callee.name : isNodeOfType(callee, "CallExpression") && isNodeOfType(callee.callee, "Identifier") ? callee.callee.name : null;
-			if (calleeName != null && !KNOWN_PURE_HOC_NAMES.has(calleeName)) return true;
+			if (calleeName != null && !KNOWN_COMPONENT_WRAPPER_NAMES.has(calleeName)) return true;
 		}
 		return false;
 	};
@@ -35902,15 +35906,167 @@ const visitSynchronousFunctionBodies = (analysisFunctions, visitor) => {
 		walkInsideStatementBlocks(analysisFunction.body, visitor);
 	}
 };
-const collectWrittenStateNamesInEffect = (analysisFunctions, setterToStateName) => {
-	const writtenStateNames = /* @__PURE__ */ new Set();
+const readStaticEffectValue = (expression, scopes, stateSymbolId, stateValue, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
+	const unwrappedExpression = stripParenExpression(expression);
+	if (isNodeOfType(unwrappedExpression, "Literal")) {
+		const literalValue = unwrappedExpression.value;
+		if (literalValue === null || typeof literalValue === "boolean" || typeof literalValue === "number" || typeof literalValue === "string") return { value: literalValue };
+		return null;
+	}
+	if (isNodeOfType(unwrappedExpression, "Identifier")) {
+		if (scopes.symbolFor(unwrappedExpression)?.id === stateSymbolId) return stateValue;
+		if (unwrappedExpression.name === "undefined" && scopes.isGlobalReference(unwrappedExpression)) return { value: void 0 };
+		const immutableSymbol = scopes.symbolFor(unwrappedExpression);
+		if (immutableSymbol?.kind !== "const" || !immutableSymbol.initializer || !isNodeOfType(immutableSymbol.declarationNode, "VariableDeclarator") || immutableSymbol.declarationNode.id !== immutableSymbol.bindingIdentifier || immutableSymbol.declarationNode.init !== immutableSymbol.initializer || immutableSymbol.references.some((reference) => reference.flag !== "read") || visitedSymbolIds.has(immutableSymbol.id)) return null;
+		return readStaticEffectValue(immutableSymbol.initializer, scopes, stateSymbolId, stateValue, new Set(visitedSymbolIds).add(immutableSymbol.id));
+	}
+	if (isNodeOfType(unwrappedExpression, "UnaryExpression")) {
+		if (unwrappedExpression.operator === "void") return { value: void 0 };
+		if (unwrappedExpression.operator !== "!") return null;
+		const argumentValue = readStaticEffectValue(unwrappedExpression.argument, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+		return argumentValue ? { value: !argumentValue.value } : null;
+	}
+	if (isNodeOfType(unwrappedExpression, "CallExpression")) {
+		if (isNodeOfType(unwrappedExpression.callee, "Identifier") && unwrappedExpression.callee.name === "Boolean" && scopes.isGlobalReference(unwrappedExpression.callee) && unwrappedExpression.arguments.length === 1 && unwrappedExpression.arguments[0] && !isNodeOfType(unwrappedExpression.arguments[0], "SpreadElement")) {
+			const argumentValue = readStaticEffectValue(unwrappedExpression.arguments[0], scopes, stateSymbolId, stateValue, visitedSymbolIds);
+			return argumentValue ? { value: Boolean(argumentValue.value) } : null;
+		}
+		return null;
+	}
+	if (isNodeOfType(unwrappedExpression, "LogicalExpression")) {
+		const leftValue = readStaticEffectValue(unwrappedExpression.left, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+		if (!leftValue) return null;
+		if (unwrappedExpression.operator === "&&" && !leftValue.value) return leftValue;
+		if (unwrappedExpression.operator === "||" && leftValue.value) return leftValue;
+		if (unwrappedExpression.operator === "??" && leftValue.value !== null && leftValue.value !== void 0) return leftValue;
+		return readStaticEffectValue(unwrappedExpression.right, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+	}
+	if (isNodeOfType(unwrappedExpression, "ConditionalExpression")) {
+		const testValue = readStaticEffectValue(unwrappedExpression.test, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+		if (!testValue) return null;
+		return readStaticEffectValue(testValue.value ? unwrappedExpression.consequent : unwrappedExpression.alternate, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+	}
+	if (isNodeOfType(unwrappedExpression, "MemberExpression") && unwrappedExpression.optional) {
+		const objectValue = readStaticEffectValue(unwrappedExpression.object, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+		if (objectValue?.value === null || objectValue?.value === void 0) return { value: void 0 };
+		return null;
+	}
+	if (isNodeOfType(unwrappedExpression, "BinaryExpression")) {
+		const leftValue = readStaticEffectValue(unwrappedExpression.left, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+		const rightValue = readStaticEffectValue(unwrappedExpression.right, scopes, stateSymbolId, stateValue, visitedSymbolIds);
+		if (!leftValue || !rightValue) return null;
+		if (unwrappedExpression.operator === "===" || unwrappedExpression.operator === "!==") {
+			const areEqual = leftValue.value === rightValue.value;
+			return { value: unwrappedExpression.operator === "===" ? areEqual : !areEqual };
+		}
+		if (unwrappedExpression.operator === "==" || unwrappedExpression.operator === "!=") {
+			const isLeftNullish = leftValue.value === null || leftValue.value === void 0;
+			const isRightNullish = rightValue.value === null || rightValue.value === void 0;
+			if (!isLeftNullish && !isRightNullish && typeof leftValue.value !== typeof rightValue.value) return null;
+			const areEqual = isLeftNullish || isRightNullish ? isLeftNullish && isRightNullish : leftValue.value === rightValue.value;
+			return { value: unwrappedExpression.operator === "==" ? areEqual : !areEqual };
+		}
+	}
+	return null;
+};
+const readStaticUpdaterReturnValue = (updater, scopes) => {
+	if (!isFunctionLike$1(updater) || updater.async || updater.generator) return null;
+	if (!isNodeOfType(updater.body, "BlockStatement")) return readStaticEffectValue(updater.body, scopes, null, null);
+	if (updater.body.body.length === 0) return { value: void 0 };
+	if (updater.body.body.length !== 1) return null;
+	const returnStatement = updater.body.body[0];
+	if (!isNodeOfType(returnStatement, "ReturnStatement")) return null;
+	if (!returnStatement.argument) return { value: void 0 };
+	return readStaticEffectValue(returnStatement.argument, scopes, null, null);
+};
+const readStaticSetterValue = (setterCall, scopes) => {
+	const argument = setterCall.arguments[0];
+	if (!argument) return { value: void 0 };
+	if (isNodeOfType(argument, "SpreadElement")) return null;
+	const updater = resolveExactLocalFunction(argument, scopes);
+	if (updater) return readStaticUpdaterReturnValue(updater, scopes);
+	return readStaticEffectValue(argument, scopes, null, null);
+};
+const collectStateWritesInEffect = (analysisFunctions, setterToStateName, scopes) => {
+	const stateWrites = /* @__PURE__ */ new Map();
 	visitSynchronousFunctionBodies(analysisFunctions, (child) => {
 		if (!isNodeOfType(child, "CallExpression")) return;
 		if (!isNodeOfType(child.callee, "Identifier")) return;
 		const stateName = setterToStateName.get(child.callee.name);
-		if (stateName) writtenStateNames.add(stateName);
+		if (!stateName) return;
+		const writeInfo = stateWrites.get(stateName) ?? {
+			values: /* @__PURE__ */ new Set(),
+			hasUnknownValue: false
+		};
+		const staticValue = readStaticSetterValue(child, scopes);
+		if (staticValue) writeInfo.values.add(staticValue.value);
+		else writeInfo.hasUnknownValue = true;
+		stateWrites.set(stateName, writeInfo);
 	});
-	return writtenStateNames;
+	return stateWrites;
+};
+const isGlobalBooleanCall = (node, scopes) => {
+	return isNodeOfType(node, "CallExpression") && isNodeOfType(node.callee, "Identifier") && node.callee.name === "Boolean" && scopes.isGlobalReference(node.callee);
+};
+const isWorkNodeReachableForStateValue = (workNode, stateSymbolId, stateValue, scopes) => {
+	let currentNode = workNode;
+	while (currentNode.parent) {
+		const parentNode = currentNode.parent;
+		if (isFunctionLike$1(parentNode)) break;
+		if (isNodeOfType(parentNode, "IfStatement")) {
+			const testValue = readStaticEffectValue(parentNode.test, scopes, stateSymbolId, stateValue);
+			if (testValue) {
+				if (currentNode === parentNode.consequent && !testValue.value) return false;
+				if (currentNode === parentNode.alternate && testValue.value) return false;
+			}
+		}
+		if (isNodeOfType(parentNode, "ConditionalExpression")) {
+			const testValue = readStaticEffectValue(parentNode.test, scopes, stateSymbolId, stateValue);
+			if (testValue) {
+				if (currentNode === parentNode.consequent && !testValue.value) return false;
+				if (currentNode === parentNode.alternate && testValue.value) return false;
+			}
+		}
+		if (isNodeOfType(parentNode, "LogicalExpression") && currentNode === parentNode.right) {
+			const leftValue = readStaticEffectValue(parentNode.left, scopes, stateSymbolId, stateValue);
+			if (leftValue) {
+				if (parentNode.operator === "&&" && !leftValue.value) return false;
+				if (parentNode.operator === "||" && leftValue.value) return false;
+				if (parentNode.operator === "??" && leftValue.value !== null && leftValue.value !== void 0) return false;
+			}
+		}
+		if (isNodeOfType(parentNode, "BlockStatement")) {
+			const statementIndex = parentNode.body.findIndex((statement) => statement === currentNode);
+			if (statementIndex >= 0) for (let index = 0; index < statementIndex; index += 1) {
+				const earlierStatement = parentNode.body[index];
+				if (!isNodeOfType(earlierStatement, "IfStatement") || earlierStatement.alternate || !statementAlwaysExits(earlierStatement.consequent)) continue;
+				if (readStaticEffectValue(earlierStatement.test, scopes, stateSymbolId, stateValue)?.value) return false;
+			}
+		}
+		currentNode = parentNode;
+	}
+	return true;
+};
+const isReaderWorkNode = (node, analysisFunctions, scopes) => {
+	if (isNodeOfType(node, "CallExpression")) {
+		if (isGlobalBooleanCall(node, scopes)) return false;
+		const invokedFunction = resolveExactLocalFunction(node.callee, scopes);
+		return !invokedFunction || !analysisFunctions.has(invokedFunction);
+	}
+	return isNodeOfType(node, "AssignmentExpression") || isNodeOfType(node, "UpdateExpression") || isNodeOfType(node, "NewExpression") || isNodeOfType(node, "TaggedTemplateExpression") || isNodeOfType(node, "ThrowStatement") || isNodeOfType(node, "UnaryExpression") && node.operator === "delete";
+};
+const canStateWriteReachReaderWork = (writeInfo, readerEffect, stateSymbolId, scopes) => {
+	if (writeInfo.hasUnknownValue || stateSymbolId === null) return true;
+	for (const writtenValue of writeInfo.values) {
+		const stateValue = { value: writtenValue };
+		let didFindReachableWork = false;
+		visitSynchronousFunctionBodies(readerEffect.analysisFunctions, (child) => {
+			if (didFindReachableWork || !isReaderWorkNode(child, readerEffect.analysisFunctions, scopes)) return;
+			if (isWorkNodeReachableForStateValue(child, stateSymbolId, stateValue, scopes)) didFindReachableWork = true;
+		});
+		if (didFindReachableWork) return true;
+	}
+	return false;
 };
 const EMPTY_CLEANUP_NAME_SET = /* @__PURE__ */ new Set();
 const isFunctionShapedReturn = (returnedValue, setterToStateName, isExplicitReturnStatement) => {
@@ -35999,18 +36155,29 @@ const noEffectChain = defineRule({
 			const useStateBindings = collectUseStateBindings(componentBody);
 			if (useStateBindings.length === 0) return;
 			const setterToStateName = /* @__PURE__ */ new Map();
-			for (const binding of useStateBindings) setterToStateName.set(binding.setterName, binding.valueName);
+			const stateSymbolIds = /* @__PURE__ */ new Map();
+			for (const binding of useStateBindings) {
+				setterToStateName.set(binding.setterName, binding.valueName);
+				if (!isNodeOfType(binding.declarator.id, "ArrayPattern")) continue;
+				const stateIdentifier = binding.declarator.id.elements[0];
+				if (isNodeOfType(stateIdentifier, "Identifier")) {
+					const stateSymbol = context.scopes.symbolFor(stateIdentifier);
+					if (stateSymbol) stateSymbolIds.set(binding.valueName, stateSymbol.id);
+				}
+			}
 			const storageSetterNames = collectStorageHookSetterNames(componentBody);
 			const effectInfos = [];
 			for (const effectCall of findTopLevelEffectCalls(componentBody)) {
 				const callback = getEffectCallback(effectCall, context.scopes);
 				if (!callback || !isFunctionLike$1(callback) || callback.async) continue;
 				const analysisFunctions = collectSynchronouslyInvokedFunctions(callback, context.scopes);
-				const writtenStateNames = collectWrittenStateNamesInEffect(analysisFunctions, setterToStateName);
+				const stateWrites = collectStateWritesInEffect(analysisFunctions, setterToStateName, context.scopes);
+				const writtenStateNames = new Set(stateWrites.keys());
 				effectInfos.push({
 					node: effectCall,
 					depNames: collectDepIdentifierNames(effectCall),
-					writtenStateNames,
+					stateWrites,
+					analysisFunctions,
 					isExternalSync: isExternalSyncEffect(callback, analysisFunctions, setterToStateName) || callsStorageHookSetter(analysisFunctions, storageSetterNames) || writtenStateNames.size === 0 && callsOpaqueExternalSetter(analysisFunctions, setterToStateName)
 				});
 			}
@@ -36018,13 +36185,15 @@ const noEffectChain = defineRule({
 			const reportedNodes = /* @__PURE__ */ new Set();
 			for (const writerEffect of effectInfos) {
 				if (writerEffect.isExternalSync) continue;
-				if (writerEffect.writtenStateNames.size === 0) continue;
+				if (writerEffect.stateWrites.size === 0) continue;
 				for (const readerEffect of effectInfos) {
 					if (readerEffect === writerEffect) continue;
 					if (readerEffect.isExternalSync) continue;
 					if (readerEffect.depNames.size === 0) continue;
 					let chainedStateName = null;
-					for (const writtenName of writerEffect.writtenStateNames) if (readerEffect.depNames.has(writtenName)) {
+					for (const [writtenName, writeInfo] of writerEffect.stateWrites) {
+						if (!readerEffect.depNames.has(writtenName)) continue;
+						if (!canStateWriteReachReaderWork(writeInfo, readerEffect, stateSymbolIds.get(writtenName) ?? null, context.scopes)) continue;
 						chainedStateName = writtenName;
 						break;
 					}
@@ -39691,6 +39860,18 @@ const functionContainsProvenReactHookCall = (functionNode, scopes) => {
 	return containsReactHookCall;
 };
 //#endregion
+//#region src/plugin/utils/function-returns-only-null.ts
+const isNullExpression = (expression) => {
+	const candidate = stripParenExpression(expression);
+	return isNodeOfType(candidate, "Literal") && candidate.value === null;
+};
+const functionReturnsOnlyNull = (functionNode) => {
+	if (!isFunctionLike$1(functionNode)) return false;
+	if (!isNodeOfType(functionNode.body, "BlockStatement")) return isNullExpression(functionNode.body);
+	const returnStatements = collectFunctionReturnStatements(functionNode);
+	return returnStatements.length > 0 && returnStatements.every((returnStatement) => Boolean(returnStatement.argument && isNullExpression(returnStatement.argument)));
+};
+//#endregion
 //#region src/plugin/utils/function-returns-props-children.ts
 const functionReturnsPropsChildren = (functionNode, scopes, controlFlow) => {
 	if (!isFunctionLike$1(functionNode) || functionNode.params.length === 0) return false;
@@ -39723,17 +39904,8 @@ const functionReturnsPropsChildren = (functionNode, scopes, controlFlow) => {
 	}, controlFlow);
 };
 //#endregion
-//#region src/plugin/utils/function-returns-only-null.ts
-const isNullExpression = (expression) => {
-	const candidate = stripParenExpression(expression);
-	return isNodeOfType(candidate, "Literal") && candidate.value === null;
-};
-const functionReturnsOnlyNull = (functionNode) => {
-	if (!isFunctionLike$1(functionNode)) return false;
-	if (!isNodeOfType(functionNode.body, "BlockStatement")) return isNullExpression(functionNode.body);
-	const returnStatements = collectFunctionReturnStatements(functionNode);
-	return returnStatements.length > 0 && returnStatements.every((returnStatement) => Boolean(returnStatement.argument && isNullExpression(returnStatement.argument)));
-};
+//#region src/plugin/utils/function-has-react-component-evidence.ts
+const functionHasReactComponentEvidence = (functionNode, scopes, controlFlow) => functionContainsReactRenderOutput(functionNode, scopes, controlFlow) || functionReturnsPropsChildren(functionNode, scopes, controlFlow) || functionContainsProvenReactHookCall(functionNode, scopes) && functionReturnsOnlyNull(functionNode);
 //#endregion
 //#region src/plugin/utils/is-proven-styled-component-expression.ts
 const findFactoryRoot = (node) => {
@@ -39766,17 +39938,16 @@ const isProvenStyledComponentExpression = (expression, scopes) => {
 //#region src/plugin/utils/is-proven-react-component-symbol.ts
 const REACT_COMPONENT_HOC_NAMES = new Set(["memo", "forwardRef"]);
 const LEGACY_REACT_COMPONENT_FACTORY_NAMES = new Set(["createClass", "createReactClass"]);
-const functionHasComponentEvidence = (functionNode, scopes, controlFlow) => functionContainsReactRenderOutput(functionNode, scopes, controlFlow) || functionReturnsPropsChildren(functionNode, scopes, controlFlow) || functionContainsProvenReactHookCall(functionNode, scopes) && functionReturnsOnlyNull(functionNode);
 const isProvenReactComponentExpression = (expression, scopes, controlFlow, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
 	const candidate = stripParenExpression(expression);
-	if (isInlineFunctionExpression(candidate)) return functionHasComponentEvidence(candidate, scopes, controlFlow);
+	if (isInlineFunctionExpression(candidate)) return functionHasReactComponentEvidence(candidate, scopes, controlFlow);
 	if (isNodeOfType(candidate, "ClassExpression")) return isProvenReactClassComponent(candidate, scopes);
 	if (isProvenStyledComponentExpression(candidate, scopes)) return true;
 	if (isNodeOfType(candidate, "Identifier")) {
 		const symbol = scopes.symbolFor(candidate);
 		if (!symbol || visitedSymbolIds.has(symbol.id) || hasSymbolWriteBefore(symbol, candidate, scopes)) return false;
 		visitedSymbolIds.add(symbol.id);
-		if (isNodeOfType(symbol.declarationNode, "FunctionDeclaration")) return functionHasComponentEvidence(symbol.declarationNode, scopes, controlFlow);
+		if (isNodeOfType(symbol.declarationNode, "FunctionDeclaration")) return functionHasReactComponentEvidence(symbol.declarationNode, scopes, controlFlow);
 		if (isNodeOfType(symbol.declarationNode, "ClassDeclaration") || isNodeOfType(symbol.declarationNode, "ClassExpression")) return isProvenReactClassComponent(symbol.declarationNode, scopes);
 		return Boolean(symbol.initializer && isProvenReactComponentExpression(symbol.initializer, scopes, controlFlow, visitedSymbolIds));
 	}
@@ -39803,7 +39974,7 @@ const isProvenReactComponentSymbol = (symbol, scopes, controlFlow, componentRefe
 	for (const candidateSymbol of candidateSymbols) {
 		if (hasSymbolWriteBefore(candidateSymbol, componentReference, scopes)) continue;
 		if (isComponentDeclaration(candidateSymbol.declarationNode)) {
-			if (functionHasComponentEvidence(candidateSymbol.declarationNode, scopes, controlFlow)) return true;
+			if (functionHasReactComponentEvidence(candidateSymbol.declarationNode, scopes, controlFlow)) return true;
 			continue;
 		}
 		const initializer = candidateSymbol.initializer ? stripParenExpression(candidateSymbol.initializer) : null;
@@ -43589,6 +43760,53 @@ const noPropCallbackInEffect = defineRule({
 });
 //#endregion
 //#region src/plugin/rules/state-and-effects/no-prop-callback-in-render.ts
+const functionBindingSymbols = (functionNode, scopes) => {
+	let bindingIdentifier = null;
+	if (isNodeOfType(functionNode, "FunctionDeclaration") && functionNode.id) bindingIdentifier = functionNode.id;
+	else {
+		let bindingExpression = findTransparentExpressionRoot(functionNode);
+		let parent = bindingExpression.parent;
+		while (isNodeOfType(parent, "CallExpression") && parent.arguments[0] === bindingExpression) {
+			const callee = parent.callee;
+			const wrapperName = isNodeOfType(callee, "Identifier") ? callee.name : isNodeOfType(callee, "MemberExpression") && isNodeOfType(callee.property, "Identifier") ? callee.property.name : null;
+			if (!isReactApiCall(parent, REACT_HOC_NAMES, scopes, {
+				allowGlobalReactNamespace: true,
+				resolveNamedAliases: true
+			}) && (!wrapperName || REACT_HOC_NAMES.has(wrapperName) || !COMPONENT_HOC_WRAPPER_NAMES.has(wrapperName))) break;
+			bindingExpression = findTransparentExpressionRoot(parent);
+			parent = bindingExpression.parent;
+		}
+		if (isNodeOfType(parent, "VariableDeclarator") && parent.init === bindingExpression && isNodeOfType(parent.id, "Identifier")) bindingIdentifier = parent.id;
+	}
+	if (!bindingIdentifier) return [];
+	let scope = scopes.scopeFor(functionNode);
+	while (scope) {
+		const symbols = scope.symbols.filter((symbol) => symbol.bindingIdentifier === bindingIdentifier);
+		if (symbols.length > 0) return symbols;
+		scope = scope.parent;
+	}
+	return [];
+};
+const symbolHasReactComponentUse = (symbol, scopes, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
+	if (visitedSymbolIds.has(symbol.id)) return false;
+	visitedSymbolIds.add(symbol.id);
+	for (const reference of symbol.references) {
+		const identifier = reference.identifier;
+		if (hasSymbolWriteBefore(symbol, identifier, scopes)) continue;
+		const parent = identifier.parent;
+		if (isNodeOfType(parent, "JSXOpeningElement") && isNodeOfType(parent.name, "JSXIdentifier") && parent.name === identifier) return true;
+		const expression = findTransparentExpressionRoot(identifier);
+		const expressionParent = expression.parent;
+		if (isNodeOfType(expressionParent, "CallExpression") && expressionParent.arguments[0] === expression && isReactApiCall(expressionParent, "createElement", scopes, { resolveNamedAliases: true })) return true;
+		if (!isNodeOfType(expressionParent, "VariableDeclarator") || expressionParent.init !== expression || !isNodeOfType(expressionParent.id, "Identifier") || !isNodeOfType(expressionParent.parent, "VariableDeclaration") || expressionParent.parent.kind !== "const") continue;
+		const aliasSymbol = scopes.symbolFor(expressionParent.id);
+		if (aliasSymbol && symbolHasReactComponentUse(aliasSymbol, scopes, visitedSymbolIds)) return true;
+	}
+	return false;
+};
+const functionHasReactComponentUse = (functionNode, scopes) => {
+	return functionBindingSymbols(functionNode, scopes).some((symbol) => symbolHasReactComponentUse(symbol, scopes));
+};
 const isPreservedThroughConciseArrow = (callExpression, scopes) => {
 	let node = callExpression;
 	let parent = node.parent;
@@ -43635,7 +43853,10 @@ const noPropCallbackInRender = defineRule({
 	create: (context) => ({ CallExpression(node) {
 		if (!isResultDiscardedCall(node)) return;
 		if (isPreservedThroughConciseArrow(node, context.scopes)) return;
-		if (!findRenderPhaseComponentOrHook(node, context.scopes)) return;
+		const renderPhaseOwner = findRenderPhaseComponentOrHook(node, context.scopes);
+		if (!renderPhaseOwner) return;
+		const renderPhaseOwnerName = componentOrHookDisplayNameForFunction(renderPhaseOwner);
+		if (!renderPhaseOwnerName || !isReactHookName(renderPhaseOwnerName) && !functionHasReactComponentEvidence(renderPhaseOwner, context.scopes, context.cfg) && !functionHasReactComponentUse(renderPhaseOwner, context.scopes)) return;
 		const analysis = getProgramAnalysis(node);
 		if (!analysis) return;
 		const callee = stripParenExpression(node.callee);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.9-dev.d8a20e0",
+  "version": "0.7.9-dev.e86bc57",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",