oxlint-plugin-react-doctor 0.7.9-dev.d8a20e0 → 0.7.9-dev.e5d5753

package/dist/index.js

@@ -44371,110 +44371,11 @@ const isSameRefCurrentMember = (node, refSymbol, scopes) => {
 	return isNodeOfType(receiver, "Identifier") && resolveConstIdentifierAlias(receiver, scopes)?.id === refSymbol.id;
 };
 const isSameRefCurrentAlias = (node, refSymbol, scopes) => {
-	const expression = stripParenExpression(node);
-	if (isSameRefCurrentMember(expression, refSymbol, scopes)) return true;
-	if (!isNodeOfType(expression, "Identifier")) return false;
-	const aliasSymbol = scopes.symbolFor(expression);
+	if (isSameRefCurrentMember(node, refSymbol, scopes)) return true;
+	if (!isNodeOfType(node, "Identifier")) return false;
+	const aliasSymbol = scopes.symbolFor(node);
 	return aliasSymbol?.kind === "const" && aliasSymbol.initializer !== null && isSameRefCurrentMember(stripParenExpression(aliasSymbol.initializer), refSymbol, scopes);
 };
-const resolveImmutableInitializationValue = (node, scopes, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
-	const expression = stripParenExpression(node);
-	if (!isNodeOfType(expression, "Identifier")) return expression;
-	const symbol = scopes.symbolFor(expression);
-	if (!symbol || symbol.kind !== "const" || !symbol.initializer || symbol.references.some((reference) => reference.flag !== "read") || visitedSymbolIds.has(symbol.id)) return null;
-	visitedSymbolIds.add(symbol.id);
-	return resolveImmutableInitializationValue(symbol.initializer, scopes, visitedSymbolIds);
-};
-const isProvablyTruthyInitializationValue = (node, scopes) => {
-	const expression = resolveImmutableInitializationValue(node, scopes);
-	return Boolean(expression && (isNodeOfType(expression, "NewExpression") || isNodeOfType(expression, "ObjectExpression") || isNodeOfType(expression, "ArrayExpression") || isNodeOfType(expression, "ArrowFunctionExpression") || isNodeOfType(expression, "FunctionExpression") || isNodeOfType(expression, "ClassExpression")));
-};
-const getInitializationConstructorName = (node, scopes) => {
-	const expression = resolveImmutableInitializationValue(node, scopes);
-	if (!expression) return null;
-	if (isNodeOfType(expression, "NewExpression")) {
-		const callee = stripParenExpression(expression.callee);
-		return isNodeOfType(callee, "Identifier") ? callee.name : null;
-	}
-	return null;
-};
-const isClosedTruthyTypeDomain = (typeNode, initializationValue, scopes) => {
-	const initializationExpression = stripParenExpression(initializationValue);
-	if (isNodeOfType(typeNode, "TSTypeLiteral")) return isNodeOfType(initializationExpression, "ObjectExpression");
-	if (isNodeOfType(typeNode, "TSArrayType") || isNodeOfType(typeNode, "TSTupleType")) return isNodeOfType(initializationExpression, "ArrayExpression");
-	if (isNodeOfType(typeNode, "TSFunctionType") || isNodeOfType(typeNode, "TSConstructorType")) return isNodeOfType(initializationExpression, "ArrowFunctionExpression") || isNodeOfType(initializationExpression, "FunctionExpression") || isNodeOfType(initializationExpression, "ClassExpression");
-	if (isNodeOfType(typeNode, "TSObjectKeyword")) return true;
-	if (!isNodeOfType(typeNode, "TSTypeReference")) return false;
-	const typeName = typeNode.typeName;
-	return isNodeOfType(typeName, "Identifier") && typeName.name === getInitializationConstructorName(initializationExpression, scopes);
-};
-const refHasClosedFalsySentinelDomain = (refSymbol, initializationValue, scopes) => {
-	const initializer = refSymbol.initializer ? stripParenExpression(refSymbol.initializer) : null;
-	if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
-	const [initialValue] = initializer.arguments ?? [];
-	if (!initialValue || isNodeOfType(initialValue, "SpreadElement") || !isEmptySentinel(initialValue, scopes)) return false;
-	const [declaredType] = initializer.typeArguments?.params ?? [];
-	if (!declaredType || !isNodeOfType(declaredType, "TSUnionType")) return false;
-	let hasEmptySentinel = false;
-	let hasTruthyDomain = false;
-	for (const memberType of declaredType.types ?? []) {
-		if (isNodeOfType(memberType, "TSNullKeyword") || isNodeOfType(memberType, "TSUndefinedKeyword")) {
-			hasEmptySentinel = true;
-			continue;
-		}
-		if (!isClosedTruthyTypeDomain(memberType, initializationValue, scopes)) return false;
-		hasTruthyDomain = true;
-	}
-	return hasEmptySentinel && hasTruthyDomain;
-};
-const isSafeRefIdentifierUse = (identifier) => {
-	const expressionRoot = findTransparentExpressionRoot(identifier);
-	const parent = expressionRoot.parent;
-	if (parent && isNodeOfType(parent, "VariableDeclarator") && parent.id === expressionRoot && parent.parent !== null && isNodeOfType(parent.parent, "VariableDeclaration") && parent.parent.kind === "const") return true;
-	if (parent && isNodeOfType(parent, "MemberExpression") && parent.object === expressionRoot && getStaticPropertyName(parent) === "current") return true;
-	if (!parent || !isNodeOfType(parent, "VariableDeclarator") || parent.init !== expressionRoot) return false;
-	return isNodeOfType(parent.id, "Identifier") && parent.parent !== null && isNodeOfType(parent.parent, "VariableDeclaration") && parent.parent.kind === "const";
-};
-const refDoesNotEscape = (branchRoot, refSymbol, scopes) => {
-	let didEscape = false;
-	walkAst(branchRoot, (child) => {
-		if (didEscape) return false;
-		if (!isNodeOfType(child, "Identifier")) return;
-		if (resolveConstIdentifierAlias(child, scopes)?.id !== refSymbol.id) return;
-		if (child === refSymbol.bindingIdentifier || isSafeRefIdentifierUse(child)) return;
-		didEscape = true;
-		return false;
-	});
-	return !didEscape;
-};
-const expressionContainsRefCurrent = (expression, refSymbol, scopes) => {
-	let didFindRefCurrent = false;
-	walkAst(expression, (child) => {
-		if (didFindRefCurrent) return false;
-		if (resolveReactRefSymbol(child, scopes)?.id !== refSymbol.id) return;
-		didFindRefCurrent = true;
-		return false;
-	});
-	return didFindRefCurrent;
-};
-const hasNoCompetingRefCurrentWrite = (branchRoot, assignmentExpression, refSymbol, scopes) => {
-	let writeCount = 0;
-	walkAst(branchRoot, (child) => {
-		if (writeCount > 1) return false;
-		if (isNodeOfType(child, "AssignmentExpression")) {
-			if (expressionContainsRefCurrent(child.left, refSymbol, scopes)) writeCount++;
-			return;
-		}
-		if (isNodeOfType(child, "UpdateExpression") || isNodeOfType(child, "UnaryExpression") && child.operator === "delete") {
-			if (expressionContainsRefCurrent(child.argument, refSymbol, scopes)) writeCount++;
-			return;
-		}
-		if (isNodeOfType(child, "ForInStatement") || isNodeOfType(child, "ForOfStatement")) {
-			if (expressionContainsRefCurrent(child.left, refSymbol, scopes)) writeCount++;
-		}
-	});
-	return writeCount === 1 && expressionContainsRefCurrent(assignmentExpression.left, refSymbol, scopes);
-};
 const isEmptySentinel = (node, scopes) => isNodeOfType(node, "Literal") && node.value === null || isNodeOfType(node, "Identifier") && node.name === "undefined" && scopes.isGlobalReference(node);
 const hasRepeatedExecutionAncestor = (node, stop) => {
 	let ancestor = node.parent;
@@ -44523,22 +44424,18 @@ const hasNoPriorCoExecutableWrite = (assignmentExpression, branchRoot, refSymbol
 const isDocumentedLazyInitialization = (assignmentExpression, refSymbol, scopes) => {
 	if (assignmentExpression.operator === "??=" || assignmentExpression.operator === "||=") return true;
 	if (assignmentExpression.operator !== "=") return false;
-	const renderOwner = findRenderPhaseComponentOrHook(assignmentExpression, scopes);
-	if (!renderOwner) return false;
 	let descendant = assignmentExpression;
 	let ancestor = descendant.parent;
 	while (ancestor) {
-		const test = isNodeOfType(ancestor, "IfStatement") ? stripParenExpression(ancestor.test) : null;
-		if (isNodeOfType(ancestor, "IfStatement") && test && isNodeOfType(test, "UnaryExpression") && test.operator === "!" && isSameRefCurrentAlias(test.argument, refSymbol, scopes) && ancestor.consequent === descendant && isProvablyTruthyInitializationValue(assignmentExpression.right, scopes) && refHasClosedFalsySentinelDomain(refSymbol, assignmentExpression.right, scopes) && !hasRepeatedExecutionAncestor(assignmentExpression, ancestor.consequent) && !hasRepeatedExecutionAncestor(ancestor, renderOwner) && hasNoPriorCoExecutableWrite(assignmentExpression, ancestor.consequent, refSymbol, scopes) && hasNoCompetingRefCurrentWrite(renderOwner, assignmentExpression, refSymbol, scopes) && refDoesNotEscape(renderOwner, refSymbol, scopes)) return true;
-		if (isNodeOfType(ancestor, "IfStatement") && isNodeOfType(test, "BinaryExpression") && [
+		if (isNodeOfType(ancestor, "IfStatement") && isNodeOfType(ancestor.test, "BinaryExpression") && [
 			"===",
 			"==",
 			"!==",
 			"!="
-		].includes(test.operator)) {
-			const { left, right } = test;
+		].includes(ancestor.test.operator)) {
+			const { left, right } = ancestor.test;
 			const comparesEmptySentinel = isSameRefCurrentAlias(left, refSymbol, scopes) && isEmptySentinel(right, scopes) || isSameRefCurrentAlias(right, refSymbol, scopes) && isEmptySentinel(left, scopes);
-			const guardedBranch = test.operator === "===" || test.operator === "==" ? ancestor.consequent : ancestor.alternate;
+			const guardedBranch = ancestor.test.operator === "===" || ancestor.test.operator === "==" ? ancestor.consequent : ancestor.alternate;
 			if (comparesEmptySentinel && guardedBranch === descendant && guardedBranch && !hasRepeatedExecutionAncestor(assignmentExpression, guardedBranch) && hasNoPriorCoExecutableWrite(assignmentExpression, guardedBranch, refSymbol, scopes)) return true;
 		}
 		descendant = ancestor;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.9-dev.d8a20e0",
+  "version": "0.7.9-dev.e5d5753",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",