oxlint-plugin-react-doctor 0.7.9-dev.c88a39a → 0.7.9-dev.d8a20e0

package/dist/index.js

@@ -35902,167 +35902,15 @@ const visitSynchronousFunctionBodies = (analysisFunctions, visitor) => {
 		walkInsideStatementBlocks(analysisFunction.body, visitor);
 	}
 };
-const readStaticEffectValue = (expression, scopes, stateSymbolId, stateValue, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
-	const unwrappedExpression = stripParenExpression(expression);
-	if (isNodeOfType(unwrappedExpression, "Literal")) {
-		const literalValue = unwrappedExpression.value;
-		if (literalValue === null || typeof literalValue === "boolean" || typeof literalValue === "number" || typeof literalValue === "string") return { value: literalValue };
-		return null;
-	}
-	if (isNodeOfType(unwrappedExpression, "Identifier")) {
-		if (scopes.symbolFor(unwrappedExpression)?.id === stateSymbolId) return stateValue;
-		if (unwrappedExpression.name === "undefined" && scopes.isGlobalReference(unwrappedExpression)) return { value: void 0 };
-		const immutableSymbol = scopes.symbolFor(unwrappedExpression);
-		if (immutableSymbol?.kind !== "const" || !immutableSymbol.initializer || !isNodeOfType(immutableSymbol.declarationNode, "VariableDeclarator") || immutableSymbol.declarationNode.id !== immutableSymbol.bindingIdentifier || immutableSymbol.declarationNode.init !== immutableSymbol.initializer || immutableSymbol.references.some((reference) => reference.flag !== "read") || visitedSymbolIds.has(immutableSymbol.id)) return null;
-		return readStaticEffectValue(immutableSymbol.initializer, scopes, stateSymbolId, stateValue, new Set(visitedSymbolIds).add(immutableSymbol.id));
-	}
-	if (isNodeOfType(unwrappedExpression, "UnaryExpression")) {
-		if (unwrappedExpression.operator === "void") return { value: void 0 };
-		if (unwrappedExpression.operator !== "!") return null;
-		const argumentValue = readStaticEffectValue(unwrappedExpression.argument, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-		return argumentValue ? { value: !argumentValue.value } : null;
-	}
-	if (isNodeOfType(unwrappedExpression, "CallExpression")) {
-		if (isNodeOfType(unwrappedExpression.callee, "Identifier") && unwrappedExpression.callee.name === "Boolean" && scopes.isGlobalReference(unwrappedExpression.callee) && unwrappedExpression.arguments.length === 1 && unwrappedExpression.arguments[0] && !isNodeOfType(unwrappedExpression.arguments[0], "SpreadElement")) {
-			const argumentValue = readStaticEffectValue(unwrappedExpression.arguments[0], scopes, stateSymbolId, stateValue, visitedSymbolIds);
-			return argumentValue ? { value: Boolean(argumentValue.value) } : null;
-		}
-		return null;
-	}
-	if (isNodeOfType(unwrappedExpression, "LogicalExpression")) {
-		const leftValue = readStaticEffectValue(unwrappedExpression.left, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-		if (!leftValue) return null;
-		if (unwrappedExpression.operator === "&&" && !leftValue.value) return leftValue;
-		if (unwrappedExpression.operator === "||" && leftValue.value) return leftValue;
-		if (unwrappedExpression.operator === "??" && leftValue.value !== null && leftValue.value !== void 0) return leftValue;
-		return readStaticEffectValue(unwrappedExpression.right, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-	}
-	if (isNodeOfType(unwrappedExpression, "ConditionalExpression")) {
-		const testValue = readStaticEffectValue(unwrappedExpression.test, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-		if (!testValue) return null;
-		return readStaticEffectValue(testValue.value ? unwrappedExpression.consequent : unwrappedExpression.alternate, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-	}
-	if (isNodeOfType(unwrappedExpression, "MemberExpression") && unwrappedExpression.optional) {
-		const objectValue = readStaticEffectValue(unwrappedExpression.object, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-		if (objectValue?.value === null || objectValue?.value === void 0) return { value: void 0 };
-		return null;
-	}
-	if (isNodeOfType(unwrappedExpression, "BinaryExpression")) {
-		const leftValue = readStaticEffectValue(unwrappedExpression.left, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-		const rightValue = readStaticEffectValue(unwrappedExpression.right, scopes, stateSymbolId, stateValue, visitedSymbolIds);
-		if (!leftValue || !rightValue) return null;
-		if (unwrappedExpression.operator === "===" || unwrappedExpression.operator === "!==") {
-			const areEqual = leftValue.value === rightValue.value;
-			return { value: unwrappedExpression.operator === "===" ? areEqual : !areEqual };
-		}
-		if (unwrappedExpression.operator === "==" || unwrappedExpression.operator === "!=") {
-			const isLeftNullish = leftValue.value === null || leftValue.value === void 0;
-			const isRightNullish = rightValue.value === null || rightValue.value === void 0;
-			if (!isLeftNullish && !isRightNullish && typeof leftValue.value !== typeof rightValue.value) return null;
-			const areEqual = isLeftNullish || isRightNullish ? isLeftNullish && isRightNullish : leftValue.value === rightValue.value;
-			return { value: unwrappedExpression.operator === "==" ? areEqual : !areEqual };
-		}
-	}
-	return null;
-};
-const readStaticUpdaterReturnValue = (updater, scopes) => {
-	if (!isFunctionLike$1(updater) || updater.async || updater.generator) return null;
-	if (!isNodeOfType(updater.body, "BlockStatement")) return readStaticEffectValue(updater.body, scopes, null, null);
-	if (updater.body.body.length === 0) return { value: void 0 };
-	if (updater.body.body.length !== 1) return null;
-	const returnStatement = updater.body.body[0];
-	if (!isNodeOfType(returnStatement, "ReturnStatement")) return null;
-	if (!returnStatement.argument) return { value: void 0 };
-	return readStaticEffectValue(returnStatement.argument, scopes, null, null);
-};
-const readStaticSetterValue = (setterCall, scopes) => {
-	const argument = setterCall.arguments[0];
-	if (!argument) return { value: void 0 };
-	if (isNodeOfType(argument, "SpreadElement")) return null;
-	const updater = resolveExactLocalFunction(argument, scopes);
-	if (updater) return readStaticUpdaterReturnValue(updater, scopes);
-	return readStaticEffectValue(argument, scopes, null, null);
-};
-const collectStateWritesInEffect = (analysisFunctions, setterToStateName, scopes) => {
-	const stateWrites = /* @__PURE__ */ new Map();
+const collectWrittenStateNamesInEffect = (analysisFunctions, setterToStateName) => {
+	const writtenStateNames = /* @__PURE__ */ new Set();
 	visitSynchronousFunctionBodies(analysisFunctions, (child) => {
 		if (!isNodeOfType(child, "CallExpression")) return;
 		if (!isNodeOfType(child.callee, "Identifier")) return;
 		const stateName = setterToStateName.get(child.callee.name);
-		if (!stateName) return;
-		const writeInfo = stateWrites.get(stateName) ?? {
-			values: /* @__PURE__ */ new Set(),
-			hasUnknownValue: false
-		};
-		const staticValue = readStaticSetterValue(child, scopes);
-		if (staticValue) writeInfo.values.add(staticValue.value);
-		else writeInfo.hasUnknownValue = true;
-		stateWrites.set(stateName, writeInfo);
+		if (stateName) writtenStateNames.add(stateName);
 	});
-	return stateWrites;
-};
-const isGlobalBooleanCall = (node, scopes) => {
-	return isNodeOfType(node, "CallExpression") && isNodeOfType(node.callee, "Identifier") && node.callee.name === "Boolean" && scopes.isGlobalReference(node.callee);
-};
-const isWorkNodeReachableForStateValue = (workNode, stateSymbolId, stateValue, scopes) => {
-	let currentNode = workNode;
-	while (currentNode.parent) {
-		const parentNode = currentNode.parent;
-		if (isFunctionLike$1(parentNode)) break;
-		if (isNodeOfType(parentNode, "IfStatement")) {
-			const testValue = readStaticEffectValue(parentNode.test, scopes, stateSymbolId, stateValue);
-			if (testValue) {
-				if (currentNode === parentNode.consequent && !testValue.value) return false;
-				if (currentNode === parentNode.alternate && testValue.value) return false;
-			}
-		}
-		if (isNodeOfType(parentNode, "ConditionalExpression")) {
-			const testValue = readStaticEffectValue(parentNode.test, scopes, stateSymbolId, stateValue);
-			if (testValue) {
-				if (currentNode === parentNode.consequent && !testValue.value) return false;
-				if (currentNode === parentNode.alternate && testValue.value) return false;
-			}
-		}
-		if (isNodeOfType(parentNode, "LogicalExpression") && currentNode === parentNode.right) {
-			const leftValue = readStaticEffectValue(parentNode.left, scopes, stateSymbolId, stateValue);
-			if (leftValue) {
-				if (parentNode.operator === "&&" && !leftValue.value) return false;
-				if (parentNode.operator === "||" && leftValue.value) return false;
-				if (parentNode.operator === "??" && leftValue.value !== null && leftValue.value !== void 0) return false;
-			}
-		}
-		if (isNodeOfType(parentNode, "BlockStatement")) {
-			const statementIndex = parentNode.body.findIndex((statement) => statement === currentNode);
-			if (statementIndex >= 0) for (let index = 0; index < statementIndex; index += 1) {
-				const earlierStatement = parentNode.body[index];
-				if (!isNodeOfType(earlierStatement, "IfStatement") || earlierStatement.alternate || !statementAlwaysExits(earlierStatement.consequent)) continue;
-				if (readStaticEffectValue(earlierStatement.test, scopes, stateSymbolId, stateValue)?.value) return false;
-			}
-		}
-		currentNode = parentNode;
-	}
-	return true;
-};
-const isReaderWorkNode = (node, analysisFunctions, scopes) => {
-	if (isNodeOfType(node, "CallExpression")) {
-		if (isGlobalBooleanCall(node, scopes)) return false;
-		const invokedFunction = resolveExactLocalFunction(node.callee, scopes);
-		return !invokedFunction || !analysisFunctions.has(invokedFunction);
-	}
-	return isNodeOfType(node, "AssignmentExpression") || isNodeOfType(node, "UpdateExpression") || isNodeOfType(node, "NewExpression") || isNodeOfType(node, "TaggedTemplateExpression") || isNodeOfType(node, "ThrowStatement") || isNodeOfType(node, "UnaryExpression") && node.operator === "delete";
-};
-const canStateWriteReachReaderWork = (writeInfo, readerEffect, stateSymbolId, scopes) => {
-	if (writeInfo.hasUnknownValue || stateSymbolId === null) return true;
-	for (const writtenValue of writeInfo.values) {
-		const stateValue = { value: writtenValue };
-		let didFindReachableWork = false;
-		visitSynchronousFunctionBodies(readerEffect.analysisFunctions, (child) => {
-			if (didFindReachableWork || !isReaderWorkNode(child, readerEffect.analysisFunctions, scopes)) return;
-			if (isWorkNodeReachableForStateValue(child, stateSymbolId, stateValue, scopes)) didFindReachableWork = true;
-		});
-		if (didFindReachableWork) return true;
-	}
-	return false;
+	return writtenStateNames;
 };
 const EMPTY_CLEANUP_NAME_SET = /* @__PURE__ */ new Set();
 const isFunctionShapedReturn = (returnedValue, setterToStateName, isExplicitReturnStatement) => {
@@ -36151,29 +35999,18 @@ const noEffectChain = defineRule({
 			const useStateBindings = collectUseStateBindings(componentBody);
 			if (useStateBindings.length === 0) return;
 			const setterToStateName = /* @__PURE__ */ new Map();
-			const stateSymbolIds = /* @__PURE__ */ new Map();
-			for (const binding of useStateBindings) {
-				setterToStateName.set(binding.setterName, binding.valueName);
-				if (!isNodeOfType(binding.declarator.id, "ArrayPattern")) continue;
-				const stateIdentifier = binding.declarator.id.elements[0];
-				if (isNodeOfType(stateIdentifier, "Identifier")) {
-					const stateSymbol = context.scopes.symbolFor(stateIdentifier);
-					if (stateSymbol) stateSymbolIds.set(binding.valueName, stateSymbol.id);
-				}
-			}
+			for (const binding of useStateBindings) setterToStateName.set(binding.setterName, binding.valueName);
 			const storageSetterNames = collectStorageHookSetterNames(componentBody);
 			const effectInfos = [];
 			for (const effectCall of findTopLevelEffectCalls(componentBody)) {
 				const callback = getEffectCallback(effectCall, context.scopes);
 				if (!callback || !isFunctionLike$1(callback) || callback.async) continue;
 				const analysisFunctions = collectSynchronouslyInvokedFunctions(callback, context.scopes);
-				const stateWrites = collectStateWritesInEffect(analysisFunctions, setterToStateName, context.scopes);
-				const writtenStateNames = new Set(stateWrites.keys());
+				const writtenStateNames = collectWrittenStateNamesInEffect(analysisFunctions, setterToStateName);
 				effectInfos.push({
 					node: effectCall,
 					depNames: collectDepIdentifierNames(effectCall),
-					stateWrites,
-					analysisFunctions,
+					writtenStateNames,
 					isExternalSync: isExternalSyncEffect(callback, analysisFunctions, setterToStateName) || callsStorageHookSetter(analysisFunctions, storageSetterNames) || writtenStateNames.size === 0 && callsOpaqueExternalSetter(analysisFunctions, setterToStateName)
 				});
 			}
@@ -36181,15 +36018,13 @@ const noEffectChain = defineRule({
 			const reportedNodes = /* @__PURE__ */ new Set();
 			for (const writerEffect of effectInfos) {
 				if (writerEffect.isExternalSync) continue;
-				if (writerEffect.stateWrites.size === 0) continue;
+				if (writerEffect.writtenStateNames.size === 0) continue;
 				for (const readerEffect of effectInfos) {
 					if (readerEffect === writerEffect) continue;
 					if (readerEffect.isExternalSync) continue;
 					if (readerEffect.depNames.size === 0) continue;
 					let chainedStateName = null;
-					for (const [writtenName, writeInfo] of writerEffect.stateWrites) {
-						if (!readerEffect.depNames.has(writtenName)) continue;
-						if (!canStateWriteReachReaderWork(writeInfo, readerEffect, stateSymbolIds.get(writtenName) ?? null, context.scopes)) continue;
+					for (const writtenName of writerEffect.writtenStateNames) if (readerEffect.depNames.has(writtenName)) {
 						chainedStateName = writtenName;
 						break;
 					}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.9-dev.c88a39a",
+  "version": "0.7.9-dev.d8a20e0",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",