oxlint-plugin-react-doctor 0.7.9-dev.21043e0 → 0.7.9-dev.2979a9b

package/dist/index.d.ts

@@ -5503,29 +5503,6 @@ declare const REACT_DOCTOR_RULES: readonly [{
     readonly recommendationFor?: (hasCapability: CapabilityQuery) => string | undefined;
     readonly create: (context: RuleContext) => RuleVisitors;
   };
-}, {
-  readonly key: "react-doctor/no-ref-callback-cleanup-before-react-19";
-  readonly id: "no-ref-callback-cleanup-before-react-19";
-  readonly source: "react-doctor";
-  readonly originallyExternal: false;
-  readonly rule: {
-    readonly framework: "global";
-    readonly category: "Bugs";
-    readonly id: string;
-    readonly title?: string;
-    readonly severity: RuleSeverity;
-    readonly requires?: ReadonlyArray<Capability>;
-    readonly disabledWhen?: ReadonlyArray<Capability>;
-    readonly tags?: ReadonlyArray<string>;
-    readonly matchByOccurrence?: boolean;
-    readonly defaultEnabled?: boolean;
-    readonly lifecycle?: "retired";
-    readonly scan?: FileScan;
-    readonly committedFilesOnly?: boolean;
-    readonly recommendation?: string;
-    readonly recommendationFor?: (hasCapability: CapabilityQuery) => string | undefined;
-    readonly create: (context: RuleContext) => RuleVisitors;
-  };
 }, {
   readonly key: "react-doctor/no-ref-current-in-render";
   readonly id: "no-ref-current-in-render";
@@ -14815,29 +14792,6 @@ declare const RULES: readonly [{
     readonly recommendationFor?: (hasCapability: CapabilityQuery) => string | undefined;
     readonly create: (context: RuleContext) => RuleVisitors;
   };
-}, {
-  readonly key: "react-doctor/no-ref-callback-cleanup-before-react-19";
-  readonly id: "no-ref-callback-cleanup-before-react-19";
-  readonly source: "react-doctor";
-  readonly originallyExternal: false;
-  readonly rule: {
-    readonly framework: "global";
-    readonly category: "Bugs";
-    readonly id: string;
-    readonly title?: string;
-    readonly severity: RuleSeverity;
-    readonly requires?: ReadonlyArray<Capability>;
-    readonly disabledWhen?: ReadonlyArray<Capability>;
-    readonly tags?: ReadonlyArray<string>;
-    readonly matchByOccurrence?: boolean;
-    readonly defaultEnabled?: boolean;
-    readonly lifecycle?: "retired";
-    readonly scan?: FileScan;
-    readonly committedFilesOnly?: boolean;
-    readonly recommendation?: string;
-    readonly recommendationFor?: (hasCapability: CapabilityQuery) => string | undefined;
-    readonly create: (context: RuleContext) => RuleVisitors;
-  };
 }, {
   readonly key: "react-doctor/no-ref-current-in-render";
   readonly id: "no-ref-current-in-render";

package/dist/index.js

@@ -14947,8 +14947,7 @@ const doesReleaseCallMatchUsage = (node, usage, context) => {
 		const releaseHandler = usesUnaryListenerSignature ? callNode.arguments?.[0] : callNode.arguments?.[1];
 		if (!releaseHandler) return releaseVerbName === "off";
 		const expectedHandlerKey = usesUnaryListenerSignature ? usage.eventKey : usage.handlerKey;
-		const registrationHandler = isNodeOfType(usage.node, "CallExpression") ? usage.node.arguments?.[usesUnaryListenerSignature ? 0 : 1] : null;
-		return expectedHandlerKey !== null && resolveExpressionKey(releaseHandler, context) === expectedHandlerKey || registrationHandler !== null && resolveStableValue(releaseHandler, context) === resolveStableValue(registrationHandler, context);
+		return expectedHandlerKey !== null && resolveExpressionKey(releaseHandler, context) === expectedHandlerKey;
 	}
 	if (releaseVerbName === "unobserve" && usage.eventKey !== null) return releaseEventKey === usage.eventKey;
 	return true;
@@ -14973,25 +14972,6 @@ const isPotentiallyReachableFunction = (functionNode, context) => {
 	if (!symbol) return false;
 	return symbol.references.some((reference) => findEnclosingFunction$1(reference.identifier) !== functionNode);
 };
-const isSelfReleasingListenerRelease = (releaseNode, releaseFunction, usage, context) => {
-	if (usage.kind !== "subscribe" || usage.registrationVerbName !== "addEventListener" || usage.receiverKey === null || usage.eventKey === null || !isNodeOfType(usage.node, "CallExpression") || !isFunctionLike$1(releaseFunction) || releaseFunction.async || releaseFunction.generator || !isNodeOfType(releaseFunction.body, "BlockStatement") || !doMatchingNodesCoverEveryPathFromFunctionEntry(releaseFunction, [releaseNode], context)) return false;
-	const registrationCapture = resolveEventListenerCapture(usage.node.arguments?.[2], { allowIndeterminateEntries: true });
-	const releaseCall = isNodeOfType(releaseNode, "ChainExpression") ? releaseNode.expression : releaseNode;
-	if (!isNodeOfType(releaseCall, "CallExpression")) return false;
-	const releaseCapture = resolveEventListenerCapture(releaseCall.arguments?.[2], { allowIndeterminateEntries: true });
-	if (registrationCapture === null || releaseCapture === null || registrationCapture !== releaseCapture) return false;
-	const ownerFunction = findEnclosingFunction$1(releaseFunction);
-	if (!ownerFunction || !isFunctionLike$1(ownerFunction)) return false;
-	const triggerRegistrations = [];
-	walkAst(ownerFunction.body, (child) => {
-		if (child !== ownerFunction.body && isFunctionLike$1(child)) return false;
-		if (!isNodeOfType(child, "CallExpression")) return;
-		const registrationDetails = getCallRegistrationDetails(child, context);
-		if (registrationDetails.registrationVerbName === "addEventListener" && registrationDetails.receiverKey === usage.receiverKey && resolveStableValue(child.arguments?.[1], context) === releaseFunction) triggerRegistrations.push(child);
-	});
-	if (triggerRegistrations.some((triggerRegistration) => triggerRegistration === usage.node)) return true;
-	return doMatchingNodesCoverEveryPathAfterUsage(usage.node, triggerRegistrations, context) || doMatchingNodesCoverEveryPathBeforeUsage(usage.node, triggerRegistrations, ownerFunction, context);
-};
 const isReleaseReachableForUsage = (releaseNode, usage, context) => {
 	if (!isNodeReachableWithinFunction(releaseNode, context)) return false;
 	const releaseFunction = findEnclosingFunction$1(releaseNode);
@@ -14999,7 +14979,6 @@ const isReleaseReachableForUsage = (releaseNode, usage, context) => {
 	if (releaseFunction === findEnclosingFunction$1(usage.node)) return true;
 	const usageFunction = findEnclosingFunction$1(usage.node);
 	if (usageFunction && isFunctionLike$1(usageFunction) && getAssignedReactRefSymbol(usageFunction, context) && isCleanupFunctionReferencedByReturn(usageFunction, releaseFunction, context)) return isReactRefCallbackCleanupOwnedByEffect(usageFunction, releaseFunction, usage, context);
-	if (isSelfReleasingListenerRelease(releaseNode, releaseFunction, usage, context)) return true;
 	return isPotentiallyReachableFunction(releaseFunction, context);
 };
 const fileContainsReleaseForUsage = (usage, context) => {
@@ -17133,7 +17112,7 @@ const collectCaptureDepKeys = (callback, scopes, declaredExactBindingKeys, allow
 				keys.add(depKey);
 				continue;
 			}
-			const identitySourceKeys = resolvePureCalledFunctionSourceKeys(reference, symbol, scopes) ?? resolveRenderDerivedMutableSourceKeys(reference, symbol, scopes) ?? resolveReactiveIdentitySourceKeys(symbol, scopes);
+			const identitySourceKeys = resolveReactiveIdentitySourceKeys(symbol, scopes);
 			if (identitySourceKeys) {
 				if (identitySourceKeys.size === 0) stableCapturedNames.add(depKey);
 				for (const identitySourceKey of identitySourceKeys) keys.add(identitySourceKey);
@@ -17216,161 +17195,6 @@ const resolveReactiveIdentitySourceKeys = (symbol, scopes) => {
 	if (symbol.kind !== "const" || !symbol.initializer || !isNodeOfType(symbol.declarationNode, "VariableDeclarator") || symbol.declarationNode.id !== symbol.bindingIdentifier || symbol.references.some((reference) => reference.flag !== "read")) return null;
 	return resolveIdentitySourceKeysFromExpression(symbol.initializer, scopes, new Set([symbol.id]));
 };
-const isPureDerivedExpression = (expression) => {
-	const candidate = unwrapExpression$3(expression);
-	if (isNodeOfType(candidate, "Literal") || isNodeOfType(candidate, "Identifier")) return true;
-	if (isNodeOfType(candidate, "MemberExpression")) return isPureDerivedExpression(candidate.object) && (!candidate.computed || isPureDerivedExpression(candidate.property));
-	if (isNodeOfType(candidate, "BinaryExpression") || isNodeOfType(candidate, "LogicalExpression")) return isPureDerivedExpression(candidate.left) && isPureDerivedExpression(candidate.right);
-	if (isNodeOfType(candidate, "UnaryExpression")) return candidate.operator !== "delete" && isPureDerivedExpression(candidate.argument);
-	if (isNodeOfType(candidate, "ConditionalExpression")) return isPureDerivedExpression(candidate.test) && isPureDerivedExpression(candidate.consequent) && isPureDerivedExpression(candidate.alternate);
-	if (isNodeOfType(candidate, "TemplateLiteral")) return candidate.expressions.every((nestedExpression) => isPureDerivedExpression(nestedExpression));
-	return false;
-};
-const isPureDerivedStatement = (statement) => {
-	if (isNodeOfType(statement, "BlockStatement")) return statement.body.every((nestedStatement) => isPureDerivedStatement(nestedStatement));
-	if (isNodeOfType(statement, "ReturnStatement")) return !statement.argument || isPureDerivedExpression(statement.argument);
-	if (isNodeOfType(statement, "IfStatement")) return isPureDerivedExpression(statement.test) && isPureDerivedStatement(statement.consequent) && (!statement.alternate || isPureDerivedStatement(statement.alternate));
-	return false;
-};
-const isPureDerivedFunction = (functionNode) => {
-	if (!isNodeOfType(functionNode, "FunctionDeclaration") && !isNodeOfType(functionNode, "FunctionExpression") && !isNodeOfType(functionNode, "ArrowFunctionExpression")) return false;
-	if (functionNode.async || functionNode.generator) return false;
-	return isNodeOfType(functionNode.body, "BlockStatement") ? isPureDerivedStatement(functionNode.body) : isPureDerivedExpression(functionNode.body);
-};
-const resolvePureCalledFunctionSourceKeys = (reference, symbol, scopes) => {
-	if (symbol.references.some((symbolReference) => symbolReference.flag !== "read")) return null;
-	const referenceRoot = findTransparentExpressionRoot(reference.identifier);
-	const callExpression = referenceRoot.parent;
-	if (!isNodeOfType(callExpression, "CallExpression") || callExpression.callee !== referenceRoot) return null;
-	const functionNode = getFunctionValueNode(symbol);
-	if (!functionNode || !isPureDerivedFunction(functionNode)) return null;
-	const sourceKeys = /* @__PURE__ */ new Set();
-	for (const capturedReference of closureCaptures(functionNode, scopes)) {
-		const capturedSymbol = capturedReference.resolvedSymbol;
-		if (!capturedSymbol || capturedSymbol.id === symbol.id) continue;
-		if (isOutsideAllFunctions(capturedSymbol) || symbolHasStableValue(capturedSymbol, scopes)) continue;
-		const capturedKey = computeDepKey(capturedReference);
-		if (!capturedKey) return null;
-		if (capturedKey === capturedSymbol.name) {
-			const nestedSourceKeys = resolveReactiveIdentitySourceKeys(capturedSymbol, scopes);
-			if (nestedSourceKeys) {
-				for (const nestedSourceKey of nestedSourceKeys) sourceKeys.add(nestedSourceKey);
-				continue;
-			}
-		}
-		sourceKeys.add(capturedKey);
-	}
-	return sourceKeys.size > 0 ? sourceKeys : null;
-};
-const mergeDerivedExpressionSourceKeys = (expressions, scopes, visitedSymbolIds) => {
-	const sourceKeys = /* @__PURE__ */ new Set();
-	for (const expression of expressions) {
-		const expressionSourceKeys = resolveDerivedExpressionSourceKeys(expression, scopes, visitedSymbolIds);
-		if (!expressionSourceKeys) return null;
-		for (const expressionSourceKey of expressionSourceKeys) sourceKeys.add(expressionSourceKey);
-	}
-	return sourceKeys;
-};
-const resolveDerivedExpressionSourceKeys = (expression, scopes, visitedSymbolIds) => {
-	const candidate = unwrapExpression$3(expression);
-	if (isNodeOfType(candidate, "Literal")) return /* @__PURE__ */ new Set();
-	if (isNodeOfType(candidate, "Identifier")) {
-		if (scopes.isGlobalReference(candidate)) return /* @__PURE__ */ new Set();
-		const sourceSymbol = scopes.symbolFor(candidate);
-		if (!sourceSymbol) return null;
-		if (isOutsideAllFunctions(sourceSymbol) || symbolHasStableValue(sourceSymbol, scopes)) return /* @__PURE__ */ new Set();
-		if (sourceSymbol.kind === "const" && sourceSymbol.initializer && isNodeOfType(sourceSymbol.declarationNode, "VariableDeclarator") && sourceSymbol.declarationNode.id === sourceSymbol.bindingIdentifier && sourceSymbol.references.every((sourceReference) => sourceReference.flag === "read") && !visitedSymbolIds.has(sourceSymbol.id)) {
-			visitedSymbolIds.add(sourceSymbol.id);
-			const sourceKeys = resolveDerivedExpressionSourceKeys(sourceSymbol.initializer, scopes, visitedSymbolIds);
-			visitedSymbolIds.delete(sourceSymbol.id);
-			if (sourceKeys) return sourceKeys;
-		}
-		return new Set([sourceSymbol.name]);
-	}
-	if (isNodeOfType(candidate, "MemberExpression")) {
-		if (hasComputedMemberExpression(candidate)) return null;
-		const sourceKey = stringifyMemberChain(candidate);
-		const rootIdentifier = getMemberRootIdentifier(candidate);
-		const rootSymbol = rootIdentifier ? scopes.symbolFor(rootIdentifier) : null;
-		if (!sourceKey || !rootSymbol) return null;
-		if (isOutsideAllFunctions(rootSymbol) || symbolHasStableValue(rootSymbol, scopes)) return /* @__PURE__ */ new Set();
-		return new Set([sourceKey]);
-	}
-	if (isNodeOfType(candidate, "BinaryExpression") || isNodeOfType(candidate, "LogicalExpression")) return mergeDerivedExpressionSourceKeys([candidate.left, candidate.right], scopes, visitedSymbolIds);
-	if (isNodeOfType(candidate, "UnaryExpression") && candidate.operator !== "delete") return resolveDerivedExpressionSourceKeys(candidate.argument, scopes, visitedSymbolIds);
-	if (isNodeOfType(candidate, "ConditionalExpression")) return mergeDerivedExpressionSourceKeys([
-		candidate.test,
-		candidate.consequent,
-		candidate.alternate
-	], scopes, visitedSymbolIds);
-	if (isNodeOfType(candidate, "TemplateLiteral")) return mergeDerivedExpressionSourceKeys(candidate.expressions, scopes, visitedSymbolIds);
-	if (isNodeOfType(candidate, "NewExpression")) {
-		const callee = unwrapExpression$3(candidate.callee);
-		if (!isNodeOfType(callee, "Identifier") || callee.name !== "Error" || !scopes.isGlobalReference(callee)) return null;
-		const argumentsToAnalyze = [];
-		for (const argument of candidate.arguments) {
-			if (!isAstNode(argument) || isNodeOfType(argument, "SpreadElement")) return null;
-			argumentsToAnalyze.push(argument);
-		}
-		return mergeDerivedExpressionSourceKeys(argumentsToAnalyze, scopes, visitedSymbolIds);
-	}
-	return null;
-};
-const resolveWriteControlSourceKeys = (assignment, boundaryFunction, scopes) => {
-	const sourceKeys = /* @__PURE__ */ new Set();
-	let currentNode = assignment;
-	while (currentNode.parent && currentNode.parent !== boundaryFunction) {
-		const parentNode = currentNode.parent;
-		if (isNodeOfType(parentNode, "IfStatement")) {
-			if (parentNode.test === currentNode) return null;
-			const testSourceKeys = resolveDerivedExpressionSourceKeys(parentNode.test, scopes, /* @__PURE__ */ new Set());
-			if (!testSourceKeys) return null;
-			for (const testSourceKey of testSourceKeys) sourceKeys.add(testSourceKey);
-		} else if (!isNodeOfType(parentNode, "ExpressionStatement") && !isNodeOfType(parentNode, "BlockStatement")) return null;
-		currentNode = parentNode;
-	}
-	return currentNode.parent === boundaryFunction ? sourceKeys : null;
-};
-const isReadOnlyInitialStateUse = (referenceNode, scopes) => {
-	const referenceRoot = findTransparentExpressionRoot(referenceNode);
-	const callExpression = referenceRoot.parent;
-	return isNodeOfType(callExpression, "CallExpression") && callExpression.arguments.some((argument) => argument === referenceRoot) && isReactApiCall(callExpression, "useState", scopes, {
-		allowGlobalReactNamespace: true,
-		allowUnboundBareCalls: true,
-		resolveNamedAliases: true
-	});
-};
-const resolveRenderDerivedMutableSourceKeys = (capturedReference, symbol, scopes) => {
-	if (symbol.kind !== "let" || !isNodeOfType(symbol.declarationNode, "VariableDeclarator") || symbol.declarationNode.id !== symbol.bindingIdentifier) return null;
-	const boundaryFunction = findEnclosingFunction$1(symbol.bindingIdentifier);
-	if (!boundaryFunction) return null;
-	const capturingFunction = findEnclosingFunction$1(capturedReference.identifier);
-	if (!capturingFunction || capturingFunction === boundaryFunction) return null;
-	const sourceKeys = /* @__PURE__ */ new Set();
-	if (symbol.initializer) {
-		const initializerSourceKeys = resolveDerivedExpressionSourceKeys(symbol.initializer, scopes, new Set([symbol.id]));
-		if (!initializerSourceKeys) return null;
-		for (const initializerSourceKey of initializerSourceKeys) sourceKeys.add(initializerSourceKey);
-	}
-	let writeCount = 0;
-	for (const symbolReference of symbol.references) {
-		if (symbolReference.flag === "read") {
-			if (findEnclosingFunction$1(symbolReference.identifier) !== capturingFunction && !isReadOnlyInitialStateUse(symbolReference.identifier, scopes)) return null;
-			continue;
-		}
-		if (symbolReference.flag !== "write") return null;
-		const referenceRoot = findTransparentExpressionRoot(symbolReference.identifier);
-		const assignment = referenceRoot.parent;
-		if (!isNodeOfType(assignment, "AssignmentExpression") || assignment.operator !== "=" || assignment.left !== referenceRoot || findEnclosingFunction$1(referenceRoot) !== boundaryFunction) return null;
-		const assignmentSourceKeys = resolveDerivedExpressionSourceKeys(assignment.right, scopes, new Set([symbol.id]));
-		const controlSourceKeys = resolveWriteControlSourceKeys(assignment, boundaryFunction, scopes);
-		if (!assignmentSourceKeys || !controlSourceKeys) return null;
-		for (const assignmentSourceKey of assignmentSourceKeys) sourceKeys.add(assignmentSourceKey);
-		for (const controlSourceKey of controlSourceKeys) sourceKeys.add(controlSourceKey);
-		writeCount += 1;
-	}
-	return writeCount > 0 && sourceKeys.size > 0 ? sourceKeys : null;
-};
 const isUseCallbackResultDep = (node, scopes) => {
 	const rootSymbol = getRootSymbol(node, scopes);
 	const initializer = rootSymbol?.initializer ? unwrapExpression$3(rootSymbol.initializer) : null;
@@ -41089,223 +40913,41 @@ const readLogicalConditionResult = (operator, leftResult, rightResult) => {
 	if (leftResult === false && rightResult === false) return false;
 	return null;
 };
-const readHydrationConditionResult = (expression, context, runtime, state) => {
+const readHydrationConditionResult = (expression, context, runtime) => {
 	const unwrappedExpression = stripParenExpression(expression);
 	const predicateMatch = matchBrowserPredicate(unwrappedExpression, context);
 	if (predicateMatch) return predicateMatch[`${runtime}Result`];
 	const staticResult = readInitialStateBoolean(unwrappedExpression, context.scopes);
 	if (staticResult !== null) return staticResult;
-	const expressionSymbol = isNodeOfType(unwrappedExpression, "Identifier") ? context.scopes.symbolFor(unwrappedExpression) : null;
-	const parameterValue = expressionSymbol ? state.parameterValuesBySymbolId.get(expressionSymbol.id) : null;
-	if (expressionSymbol && parameterValue && !state.visitedSymbolIds.has(expressionSymbol.id)) {
-		state.visitedSymbolIds.add(expressionSymbol.id);
-		const result = readHydrationConditionResult(parameterValue, context, runtime, state);
-		state.visitedSymbolIds.delete(expressionSymbol.id);
-		return result;
-	}
-	if (expressionSymbol && expressionSymbol.kind === "const" && expressionSymbol.initializer && expressionSymbol.references.every((reference) => reference.flag === "read") && !state.visitedSymbolIds.has(expressionSymbol.id)) {
-		state.visitedSymbolIds.add(expressionSymbol.id);
-		const result = readHydrationConditionResult(expressionSymbol.initializer, context, runtime, state);
-		state.visitedSymbolIds.delete(expressionSymbol.id);
-		return result;
-	}
-	if (isNodeOfType(unwrappedExpression, "CallExpression")) {
-		const callArguments = unwrappedExpression.arguments ?? [];
-		if (isReactApiCall(unwrappedExpression, "useMemo", context.scopes, {
-			allowGlobalReactNamespace: true,
-			resolveNamedAliases: true
-		})) {
-			const callbackArgument = callArguments[0];
-			if (!callbackArgument || isNodeOfType(callbackArgument, "SpreadElement")) return null;
-			const callbackFunction = resolveExactLocalFunction(callbackArgument, context.scopes);
-			return isFunctionLike$1(callbackFunction) && callbackFunction.params.length === 0 ? readHydrationFunctionResult(callbackFunction, context, runtime, state) : null;
-		}
-		const callee = stripParenExpression(unwrappedExpression.callee);
-		if (isNodeOfType(callee, "Identifier") && callee.name === "Boolean" && context.scopes.isGlobalReference(callee) && callArguments.length === 1 && !isNodeOfType(callArguments[0], "SpreadElement")) return readHydrationConditionResult(callArguments[0], context, runtime, state);
-		const helperFunction = resolveExactLocalFunction(callee, context.scopes);
-		if (!isFunctionLike$1(helperFunction) || helperFunction.async || isNodeOfType(helperFunction, "FunctionDeclaration") && helperFunction.generator || isNodeOfType(helperFunction, "FunctionExpression") && helperFunction.generator || helperFunction.params.some((parameter) => !isNodeOfType(parameter, "Identifier")) || callArguments.some((argument) => isNodeOfType(argument, "SpreadElement"))) return null;
-		const parameterValuesBySymbolId = new Map(state.parameterValuesBySymbolId);
-		for (let parameterIndex = 0; parameterIndex < helperFunction.params.length; parameterIndex++) {
-			const parameter = helperFunction.params[parameterIndex];
-			const argument = callArguments[parameterIndex];
-			if (!argument || !isNodeOfType(parameter, "Identifier")) continue;
-			const parameterSymbol = context.scopes.symbolFor(parameter);
-			if (parameterSymbol) parameterValuesBySymbolId.set(parameterSymbol.id, argument);
-		}
-		return readHydrationFunctionResult(helperFunction, context, runtime, {
-			...state,
-			parameterValuesBySymbolId
-		});
-	}
 	if (isNodeOfType(unwrappedExpression, "UnaryExpression") && unwrappedExpression.operator === "!") {
-		const argumentResult = readHydrationConditionResult(unwrappedExpression.argument, context, runtime, state);
+		const argumentResult = readHydrationConditionResult(unwrappedExpression.argument, context, runtime);
 		return argumentResult === null ? null : !argumentResult;
 	}
 	if (!isNodeOfType(unwrappedExpression, "LogicalExpression") || unwrappedExpression.operator !== "&&" && unwrappedExpression.operator !== "||") return null;
-	return readLogicalConditionResult(unwrappedExpression.operator, readHydrationConditionResult(unwrappedExpression.left, context, runtime, state), readHydrationConditionResult(unwrappedExpression.right, context, runtime, state));
+	return readLogicalConditionResult(unwrappedExpression.operator, readHydrationConditionResult(unwrappedExpression.left, context, runtime), readHydrationConditionResult(unwrappedExpression.right, context, runtime));
 };
-const readHydrationStatementResult = (statement, context, runtime, state) => {
-	if (isNodeOfType(statement, "ReturnStatement")) return {
-		didReturn: true,
-		value: statement.argument ? readHydrationConditionResult(statement.argument, context, runtime, state) : null
-	};
-	if (isNodeOfType(statement, "BlockStatement")) {
-		for (const childStatement of statement.body) {
-			const result = readHydrationStatementResult(childStatement, context, runtime, state);
-			if (result.didReturn) return result;
-			if (statementAlwaysExits(childStatement)) break;
-		}
-		return {
-			didReturn: false,
-			value: null
-		};
-	}
-	if (!isNodeOfType(statement, "IfStatement")) return {
-		didReturn: false,
-		value: null
-	};
-	const conditionResult = readHydrationConditionResult(statement.test, context, runtime, state);
-	if (conditionResult !== null) {
-		const selectedBranch = conditionResult ? statement.consequent : statement.alternate;
-		return selectedBranch ? readHydrationStatementResult(selectedBranch, context, runtime, state) : {
-			didReturn: false,
-			value: null
-		};
-	}
-	const consequentResult = readHydrationStatementResult(statement.consequent, context, runtime, state);
-	const alternateResult = statement.alternate ? readHydrationStatementResult(statement.alternate, context, runtime, state) : {
-		didReturn: false,
-		value: null
-	};
-	return consequentResult.didReturn && alternateResult.didReturn && consequentResult.value !== null && consequentResult.value === alternateResult.value ? consequentResult : {
-		didReturn: consequentResult.didReturn || alternateResult.didReturn,
-		value: null
-	};
-};
-const readHydrationFunctionResult = (functionNode, context, runtime, state) => {
-	if (!isFunctionLike$1(functionNode) || state.visitedFunctionNodes.has(functionNode)) return null;
-	state.visitedFunctionNodes.add(functionNode);
-	const result = isNodeOfType(functionNode.body, "BlockStatement") ? readHydrationStatementResult(functionNode.body, context, runtime, state).value : readHydrationConditionResult(functionNode.body, context, runtime, state);
-	state.visitedFunctionNodes.delete(functionNode);
-	return result;
-};
-const doEquivalentExpressionBindingsMatch = (leftExpression, rightExpression, scopes) => {
-	const left = stripParenExpression(leftExpression);
-	const right = stripParenExpression(rightExpression);
-	if (isNodeOfType(left, "Identifier") && isNodeOfType(right, "Identifier")) {
-		const leftSymbol = scopes.symbolFor(left);
-		const rightSymbol = scopes.symbolFor(right);
-		return leftSymbol || rightSymbol ? leftSymbol?.id === rightSymbol?.id : true;
-	}
-	if (isNodeOfType(left, "MemberExpression") && isNodeOfType(right, "MemberExpression")) return doEquivalentExpressionBindingsMatch(left.object, right.object, scopes) && (!left.computed || doEquivalentExpressionBindingsMatch(left.property, right.property, scopes));
-	if (isNodeOfType(left, "CallExpression") && isNodeOfType(right, "CallExpression")) {
-		const rightArguments = right.arguments ?? [];
-		return doEquivalentExpressionBindingsMatch(left.callee, right.callee, scopes) && (left.arguments ?? []).every((argument, index) => {
-			const rightArgument = rightArguments[index];
-			return Boolean(rightArgument && doEquivalentExpressionBindingsMatch(argument, rightArgument, scopes));
-		});
-	}
-	return true;
-};
-const areHelperReturnValuesEquivalent = (leftValue, rightValue, context) => {
-	if (areExpressionsStructurallyEqual(leftValue, rightValue)) return doEquivalentExpressionBindingsMatch(leftValue, rightValue, context.scopes);
-	const leftBoolean = readInitialStateBoolean(leftValue, context.scopes);
-	const rightBoolean = readInitialStateBoolean(rightValue, context.scopes);
-	return leftBoolean !== null && rightBoolean !== null && leftBoolean === rightBoolean;
-};
-const doHelperReturnValuesDiffer = (leftValues, rightValues, context) => {
-	const everyValueHasEquivalent = (values, candidateValues) => values.every((value) => candidateValues.some((candidateValue) => areHelperReturnValuesEquivalent(value, candidateValue, context)));
-	return !everyValueHasEquivalent(leftValues, rightValues) || !everyValueHasEquivalent(rightValues, leftValues);
-};
-const matchHydrationConditionInternal = (expression, context, state) => {
+const matchHydrationCondition = (expression, context) => {
 	const unwrappedExpression = stripParenExpression(expression);
 	const predicateMatch = matchBrowserPredicate(unwrappedExpression, context);
 	if (predicateMatch) return {
 		predicateMatch,
 		predicateNode: unwrappedExpression
 	};
-	if (isNodeOfType(unwrappedExpression, "Identifier")) {
-		const symbol = context.scopes.symbolFor(unwrappedExpression);
-		const parameterValue = symbol ? state.parameterValuesBySymbolId.get(symbol.id) : null;
-		if (symbol && parameterValue && !state.visitedSymbolIds.has(symbol.id)) {
-			state.visitedSymbolIds.add(symbol.id);
-			const match = matchHydrationConditionInternal(parameterValue, context, state);
-			state.visitedSymbolIds.delete(symbol.id);
-			return match;
-		}
-		if (!symbol || symbol.kind !== "const" || !symbol.initializer || symbol.references.some((reference) => reference.flag !== "read") || state.visitedSymbolIds.has(symbol.id)) return null;
-		state.visitedSymbolIds.add(symbol.id);
-		const match = matchHydrationConditionInternal(symbol.initializer, context, state);
-		state.visitedSymbolIds.delete(symbol.id);
-		return match;
-	}
-	if (isNodeOfType(unwrappedExpression, "CallExpression")) {
-		const callArguments = unwrappedExpression.arguments ?? [];
-		if (isReactApiCall(unwrappedExpression, "useMemo", context.scopes, {
-			allowGlobalReactNamespace: true,
-			resolveNamedAliases: true
-		})) {
-			const callbackArgument = callArguments[0];
-			if (!callbackArgument || isNodeOfType(callbackArgument, "SpreadElement")) return null;
-			const callbackFunction = resolveExactLocalFunction(callbackArgument, context.scopes);
-			return isFunctionLike$1(callbackFunction) && callbackFunction.params.length === 0 ? matchHydrationFunctionResult(callbackFunction, context, state) : null;
-		}
-		const callee = stripParenExpression(unwrappedExpression.callee);
-		if (isNodeOfType(callee, "Identifier") && callee.name === "Boolean" && context.scopes.isGlobalReference(callee) && callArguments.length === 1 && !isNodeOfType(callArguments[0], "SpreadElement")) return matchHydrationConditionInternal(callArguments[0], context, state);
-		const helperFunction = resolveExactLocalFunction(callee, context.scopes);
-		if (!isFunctionLike$1(helperFunction) || helperFunction.async || isNodeOfType(helperFunction, "FunctionDeclaration") && helperFunction.generator || isNodeOfType(helperFunction, "FunctionExpression") && helperFunction.generator || helperFunction.params.some((parameter) => !isNodeOfType(parameter, "Identifier")) || callArguments.some((argument) => isNodeOfType(argument, "SpreadElement"))) return null;
-		const parameterValuesBySymbolId = new Map(state.parameterValuesBySymbolId);
-		for (let parameterIndex = 0; parameterIndex < helperFunction.params.length; parameterIndex++) {
-			const parameter = helperFunction.params[parameterIndex];
-			const argument = callArguments[parameterIndex];
-			if (!argument || !isNodeOfType(parameter, "Identifier")) continue;
-			const parameterSymbol = context.scopes.symbolFor(parameter);
-			if (parameterSymbol) parameterValuesBySymbolId.set(parameterSymbol.id, argument);
-		}
-		return matchHydrationFunctionResult(helperFunction, context, {
-			...state,
-			parameterValuesBySymbolId
-		});
-	}
-	if (isNodeOfType(unwrappedExpression, "UnaryExpression") && unwrappedExpression.operator === "!") return matchHydrationConditionInternal(unwrappedExpression.argument, context, state);
+	if (isNodeOfType(unwrappedExpression, "UnaryExpression") && unwrappedExpression.operator === "!") return matchHydrationCondition(unwrappedExpression.argument, context);
 	if (!isNodeOfType(unwrappedExpression, "LogicalExpression") || unwrappedExpression.operator !== "&&" && unwrappedExpression.operator !== "||") return null;
-	const leftMatch = matchHydrationConditionInternal(unwrappedExpression.left, context, state);
-	const rightMatch = matchHydrationConditionInternal(unwrappedExpression.right, context, state);
+	const leftMatch = matchHydrationCondition(unwrappedExpression.left, context);
+	const rightMatch = matchHydrationCondition(unwrappedExpression.right, context);
+	if (leftMatch && rightMatch) {
+		const clientResult = readHydrationConditionResult(unwrappedExpression, context, "client");
+		const serverResult = readHydrationConditionResult(unwrappedExpression, context, "server");
+		return clientResult !== null && serverResult !== null && clientResult !== serverResult ? leftMatch : null;
+	}
 	const nestedMatch = leftMatch ?? rightMatch;
 	if (!nestedMatch) return null;
-	const clientResult = readHydrationConditionResult(unwrappedExpression, context, "client", state);
-	const serverResult = readHydrationConditionResult(unwrappedExpression, context, "server", state);
-	return clientResult !== null && serverResult !== null && clientResult === serverResult ? null : nestedMatch;
-};
-const matchHydrationReturningStatement = (statement, context, state) => {
-	if (isNodeOfType(statement, "ReturnStatement")) return statement.argument ? matchHydrationConditionInternal(statement.argument, context, state) : null;
-	if (isNodeOfType(statement, "IfStatement")) {
-		const conditionMatch = matchHydrationConditionInternal(statement.test, context, state);
-		const consequentValues = getReturnedValues(statement.consequent);
-		const alternateValues = statement.alternate ? getReturnedValues(statement.alternate) : findFollowingReturnedValues(statement);
-		if (conditionMatch && consequentValues.length > 0 && alternateValues.length > 0 && doHelperReturnValuesDiffer(consequentValues, alternateValues, context)) return conditionMatch;
-		return matchHydrationReturningStatement(statement.consequent, context, state) ?? (statement.alternate ? matchHydrationReturningStatement(statement.alternate, context, state) : null);
-	}
-	if (!isNodeOfType(statement, "BlockStatement")) return null;
-	for (const childStatement of statement.body) {
-		const match = matchHydrationReturningStatement(childStatement, context, state);
-		if (match) return match;
-		if (statementAlwaysExits(childStatement)) break;
-	}
-	return null;
+	const otherResult = readInitialStateBoolean(leftMatch ? unwrappedExpression.right : unwrappedExpression.left, context.scopes);
+	if (unwrappedExpression.operator === "&&" && otherResult === false || unwrappedExpression.operator === "||" && otherResult === true) return null;
+	return nestedMatch;
 };
-const matchHydrationFunctionResult = (functionNode, context, state) => {
-	if (!isFunctionLike$1(functionNode) || state.visitedFunctionNodes.has(functionNode)) return null;
-	state.visitedFunctionNodes.add(functionNode);
-	const match = isNodeOfType(functionNode.body, "BlockStatement") ? matchHydrationReturningStatement(functionNode.body, context, state) : matchHydrationConditionInternal(functionNode.body, context, state);
-	state.visitedFunctionNodes.delete(functionNode);
-	return match;
-};
-const matchHydrationCondition = (expression, context) => matchHydrationConditionInternal(expression, context, {
-	parameterValuesBySymbolId: /* @__PURE__ */ new Map(),
-	visitedFunctionNodes: /* @__PURE__ */ new Set(),
-	visitedSymbolIds: /* @__PURE__ */ new Set()
-});
 const areNodeArraysEquivalent = (leftNodes, rightNodes) => leftNodes.length === rightNodes.length && leftNodes.every((leftNode, index) => areRenderedBranchesEquivalent(leftNode, rightNodes[index]));
 const areRenderedBranchesEquivalent = (leftNode, rightNode) => {
 	if (!leftNode || !rightNode) return leftNode === rightNode;
@@ -41448,17 +41090,17 @@ const noHydrationBranchOnBrowserGlobal = defineRule({
 			const { predicateMatch, predicateNode } = conditionMatch;
 			if (reportedNodes.has(predicateNode)) return;
 			if (rightBranch && areRenderedBranchesEquivalent(leftBranch, rightBranch)) return;
-			const componentOrHookNode = findRenderPhaseComponentOrHook(conditionNode, context.scopes);
+			const componentOrHookNode = findRenderPhaseComponentOrHook(predicateNode, context.scopes);
 			if (!componentOrHookNode) return;
 			if (!hasClientRenderEvidence(componentOrHookNode, fileHasUseClientDirective)) return;
-			if (requiresRenderedContext && !isInRenderedOutput(conditionNode, componentOrHookNode, context.scopes)) return;
+			if (requiresRenderedContext && !isInRenderedOutput(predicateNode, componentOrHookNode, context.scopes)) return;
 			if (!isRenderedValue(leftBranch) && (!rightBranch || !isRenderedValue(rightBranch))) {
-				const attribute = findEnclosingJsxAttribute(conditionNode);
+				const attribute = findEnclosingJsxAttribute(predicateNode);
 				if (!attribute || isEventHandlerAttribute(attribute)) return;
 			}
-			if (fileIsEmailTemplate || isGatedByFalsyInitialState(conditionNode, context.scopes)) return;
-			if (isAfterClientOnlyEarlyReturn(conditionNode, componentOrHookNode, context.scopes)) return;
-			const openingElement = findEnclosingJsxOpeningElement(conditionNode);
+			if (fileIsEmailTemplate || isGatedByFalsyInitialState(predicateNode, context.scopes)) return;
+			if (isAfterClientOnlyEarlyReturn(predicateNode, componentOrHookNode, context.scopes)) return;
+			const openingElement = findEnclosingJsxOpeningElement(predicateNode);
 			if (hasSuppressHydrationWarningAttribute(openingElement) && !isStructuralRenderedValue(leftBranch) && !isStructuralRenderedValue(rightBranch)) return;
 			if (branchRootsSuppressSameElement(leftBranch, rightBranch)) return;
 			if (isGeneratedImageRenderContext(context, openingElement ?? leftBranch)) return;
@@ -47444,69 +47086,6 @@ const noRedundantShouldComponentUpdate = defineRule({
 	}
 });
 //#endregion
-//#region src/plugin/rules/correctness/no-ref-callback-cleanup-before-react-19.ts
-const resolveFunctionExpressions = (rawExpression, scopes, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
-	const expression = stripParenExpression(rawExpression);
-	if (isFunctionLike$1(expression)) return expression.async || expression.generator ? [] : [expression];
-	if (isNodeOfType(expression, "ConditionalExpression")) {
-		if (isNodeOfType(expression.test, "Literal")) return resolveFunctionExpressions(expression.test.value ? expression.consequent : expression.alternate, scopes, visitedSymbolIds);
-		return [...resolveFunctionExpressions(expression.consequent, scopes, visitedSymbolIds), ...resolveFunctionExpressions(expression.alternate, scopes, visitedSymbolIds)];
-	}
-	if (isNodeOfType(expression, "LogicalExpression")) {
-		if (isNodeOfType(expression.left, "Literal")) {
-			const isLeftTruthy = Boolean(expression.left.value);
-			if (expression.operator === "&&" && !isLeftTruthy) return [];
-			if (expression.operator === "||" && isLeftTruthy) return [];
-			if (expression.operator === "??" && expression.left.value !== null) return [];
-		}
-		if (expression.operator === "&&") return resolveFunctionExpressions(expression.right, scopes, visitedSymbolIds);
-		return [...resolveFunctionExpressions(expression.left, scopes, visitedSymbolIds), ...resolveFunctionExpressions(expression.right, scopes, visitedSymbolIds)];
-	}
-	if (isNodeOfType(expression, "SequenceExpression")) {
-		const finalExpression = expression.expressions.at(-1);
-		return finalExpression ? resolveFunctionExpressions(finalExpression, scopes, visitedSymbolIds) : [];
-	}
-	if (isNodeOfType(expression, "CallExpression")) {
-		if (!isReactApiCall(expression, "useCallback", scopes)) return [];
-		const callback = expression.arguments[0];
-		return callback && !isNodeOfType(callback, "SpreadElement") ? resolveFunctionExpressions(callback, scopes, visitedSymbolIds) : [];
-	}
-	if (!isNodeOfType(expression, "Identifier")) return [];
-	const symbol = scopes.symbolFor(expression);
-	if (!symbol || visitedSymbolIds.has(symbol.id)) return [];
-	if (symbol.kind === "function" && isNodeOfType(symbol.declarationNode, "FunctionDeclaration") && symbol.references.every((reference) => reference.flag === "read")) return resolveFunctionExpressions(symbol.declarationNode, scopes, new Set([...visitedSymbolIds, symbol.id]));
-	const initializer = getDirectConstInitializer(symbol);
-	if (!initializer) return [];
-	return resolveFunctionExpressions(initializer, scopes, new Set([...visitedSymbolIds, symbol.id]));
-};
-const functionReturnsCleanupFunction = (functionExpression, scopes) => {
-	if (!isFunctionLike$1(functionExpression)) return false;
-	if (!isNodeOfType(functionExpression.body, "BlockStatement")) return resolveFunctionExpressions(functionExpression.body, scopes).length > 0;
-	return collectFunctionReturnStatements(functionExpression).some((returnStatement) => Boolean(returnStatement.argument && resolveFunctionExpressions(returnStatement.argument, scopes).length > 0));
-};
-const callbackReturnsCleanupFunction = (callback, scopes) => {
-	return resolveFunctionExpressions(callback, scopes).some((functionExpression) => functionReturnsCleanupFunction(functionExpression, scopes));
-};
-const noRefCallbackCleanupBeforeReact19 = defineRule({
-	id: "no-ref-callback-cleanup-before-react-19",
-	title: "Ref cleanup requires React 19",
-	requires: ["react:18"],
-	disabledWhen: ["react:19"],
-	severity: "warn",
-	recommendation: "React 18 ignores functions returned from ref callbacks. Handle cleanup when React calls the ref with `null`, or require React 19 before returning a cleanup function.",
-	create: (context) => ({ JSXAttribute(node) {
-		if (getJsxAttributeName(node.name) !== "ref") return;
-		if (!isNodeOfType(node.value, "JSXExpressionContainer")) return;
-		const callback = node.value.expression;
-		if (!callback || isNodeOfType(callback, "JSXEmptyExpression")) return;
-		if (!callbackReturnsCleanupFunction(callback, context.scopes)) return;
-		context.report({
-			node,
-			message: "This ref callback returns a cleanup function, but React 18 ignores ref cleanup returns, so the cleanup never runs. Handle detachment when React calls the ref with `null`, or require React 19."
-		});
-	} })
-});
-//#endregion
 //#region src/plugin/rules/state-and-effects/no-ref-current-in-render.ts
 const REPEATED_ANCESTOR_TYPES = new Set([
 	"DoWhileStatement",
@@ -72274,17 +71853,6 @@ const reactDoctorRules = [
 			requires: [...new Set(["react", ...noRedundantShouldComponentUpdate.requires ?? []])]
 		}
 	},
-	{
-		key: "react-doctor/no-ref-callback-cleanup-before-react-19",
-		id: "no-ref-callback-cleanup-before-react-19",
-		source: "react-doctor",
-		originallyExternal: false,
-		rule: {
-			...noRefCallbackCleanupBeforeReact19,
-			framework: "global",
-			category: "Bugs"
-		}
-	},
 	{
 		key: "react-doctor/no-ref-current-in-render",
 		id: "no-ref-current-in-render",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.9-dev.21043e0",
+  "version": "0.7.9-dev.2979a9b",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",