oxlint-plugin-react-doctor 0.7.5-dev.bc49aaa → 0.7.5-dev.d9676e2

package/dist/index.js

@@ -5934,21 +5934,6 @@ const checkedRequiresOnchangeOrReadonly = defineRule({
 	}
 });
 //#endregion
-//#region src/plugin/utils/get-static-property-key-name.ts
-const getStaticPropertyKeyName = (node, options = {}) => {
-	if (!isNodeOfType(node, "Property")) return null;
-	if (node.computed) {
-		if (options.allowComputedString && isNodeOfType(node.key, "Literal") && typeof node.key.value === "string") return node.key.value;
-		return null;
-	}
-	if (isNodeOfType(node.key, "Identifier")) return node.key.name;
-	if (isNodeOfType(node.key, "Literal")) {
-		if (typeof node.key.value === "string") return node.key.value;
-		if (options.stringifyNonStringLiterals) return String(node.key.value);
-	}
-	return null;
-};
-//#endregion
 //#region src/plugin/utils/is-presentation-role.ts
 const isPresentationRole = (openingElement) => {
 	const roleAttribute = hasJsxPropIgnoreCase(openingElement.attributes, "role");
@@ -5993,21 +5978,6 @@ const isPureEventBlockerHandler = (attribute) => {
 	return false;
 };
 //#endregion
-//#region src/plugin/utils/resolve-const-identifier-alias.ts
-const resolveConstIdentifierAlias = (identifier, scopes) => {
-	if (!isNodeOfType(identifier, "Identifier")) return null;
-	const visitedSymbolIds = /* @__PURE__ */ new Set();
-	let symbol = scopes.symbolFor(identifier);
-	while (symbol?.kind === "const") {
-		if (visitedSymbolIds.has(symbol.id) || !symbol.initializer || !isNodeOfType(symbol.declarationNode, "VariableDeclarator") || symbol.declarationNode.id !== symbol.bindingIdentifier) return null;
-		visitedSymbolIds.add(symbol.id);
-		const initializer = stripParenExpression(symbol.initializer);
-		if (!isNodeOfType(initializer, "Identifier")) return symbol;
-		symbol = scopes.symbolFor(initializer);
-	}
-	return symbol;
-};
-//#endregion
 //#region src/plugin/rules/a11y/click-events-have-key-events.ts
 const MESSAGE$57 = "Keyboard users can't trigger this click handler because there's no keyboard one, so add `onKeyUp`, `onKeyDown`, or `onKeyPress`.";
 const KEY_HANDLERS = [
@@ -6018,63 +5988,6 @@ const KEY_HANDLERS = [
 	"onKeyDownCapture",
 	"onKeyPressCapture"
 ];
-const CLICK_HANDLERS = ["onClick", "onClickCapture"];
-const TRANSPARENT_SPREAD_EVENT_NAMES = new Set([...CLICK_HANDLERS, ...KEY_HANDLERS].map((eventName) => eventName.toLowerCase()));
-const CONSERVATIVE_SPREAD_PROP_NAMES = new Set([
-	"aria-hidden",
-	"onmouseenter",
-	"onmouseover",
-	"role"
-]);
-const resolveSpreadObjectExpression = (expression, scopes) => {
-	const innerExpression = stripParenExpression(expression);
-	if (isNodeOfType(innerExpression, "ObjectExpression")) return innerExpression;
-	if (!isNodeOfType(innerExpression, "Identifier")) return null;
-	const symbol = resolveConstIdentifierAlias(innerExpression, scopes);
-	if (symbol?.kind !== "const" || !symbol.initializer) return null;
-	const initializer = stripParenExpression(symbol.initializer);
-	return isNodeOfType(initializer, "ObjectExpression") ? initializer : null;
-};
-const collectTransparentSpreadEventNames = (expression, scopes, eventValues, visitedObjectExpressions) => {
-	const objectExpression = resolveSpreadObjectExpression(expression, scopes);
-	if (!objectExpression || visitedObjectExpressions.has(objectExpression)) return false;
-	visitedObjectExpressions.add(objectExpression);
-	let isTransparent = true;
-	for (const property of objectExpression.properties) {
-		if (isNodeOfType(property, "SpreadElement")) {
-			if (!collectTransparentSpreadEventNames(property.argument, scopes, eventValues, visitedObjectExpressions)) {
-				isTransparent = false;
-				break;
-			}
-			continue;
-		}
-		if (!isNodeOfType(property, "Property")) {
-			isTransparent = false;
-			break;
-		}
-		const propertyName = getStaticPropertyKeyName(property, { allowComputedString: true });
-		if (!propertyName) {
-			isTransparent = false;
-			break;
-		}
-		const normalizedPropertyName = propertyName.toLowerCase();
-		if (CONSERVATIVE_SPREAD_PROP_NAMES.has(normalizedPropertyName)) {
-			isTransparent = false;
-			break;
-		}
-		if (TRANSPARENT_SPREAD_EVENT_NAMES.has(normalizedPropertyName)) eventValues.set(normalizedPropertyName, property.value);
-	}
-	visitedObjectExpressions.delete(objectExpression);
-	return isTransparent;
-};
-const getTransparentSpreadEventValues = (attributes, scopes) => {
-	const eventValues = /* @__PURE__ */ new Map();
-	for (const attribute of attributes) {
-		if (!isNodeOfType(attribute, "JSXSpreadAttribute")) continue;
-		if (!collectTransparentSpreadEventNames(attribute.argument, scopes, eventValues, /* @__PURE__ */ new Set())) return null;
-	}
-	return eventValues;
-};
 const FOCUSLESS_CONTAINER_TAGS = new Set([
 	"tr",
 	"td",
@@ -6122,10 +6035,7 @@ const isFocusForwardingFunctionBody = (body) => {
 };
 const resolveHandlerFunction = (attribute) => {
 	if (!attribute.value || !isNodeOfType(attribute.value, "JSXExpressionContainer")) return null;
-	return resolveHandlerFunctionExpression(attribute.value.expression);
-};
-const resolveHandlerFunctionExpression = (handlerExpression) => {
-	let expression = handlerExpression;
+	let expression = attribute.value.expression;
 	if (isNodeOfType(expression, "Identifier")) {
 		const binding = findVariableInitializer(expression, expression.name);
 		if (!binding?.initializer) return null;
@@ -6224,22 +6134,18 @@ const clickEventsHaveKeyEvents = defineRule({
 			if (!HTML_TAGS.has(tag)) return;
 			if (tag === "label") return;
 			if (!FOCUSLESS_CONTAINER_TAGS.has(tag) && isInteractiveElement(tag, node)) return;
-			const spreadEventValues = getTransparentSpreadEventValues(node.attributes, context.scopes);
-			if (!spreadEventValues) return;
 			const onClick = hasJsxPropIgnoreCase(node.attributes, "onClick") ?? hasJsxPropIgnoreCase(node.attributes, "onClickCapture");
-			const spreadOnClickExpression = CLICK_HANDLERS.map((name) => spreadEventValues.get(name.toLowerCase())).find((expression) => expression !== void 0);
-			if (!onClick && !spreadOnClickExpression) return;
-			if (onClick && isPureEventBlockerHandler(onClick)) return;
-			if (onClick && isFocusForwardingHandler(onClick)) return;
-			const spreadHandlerFunction = spreadOnClickExpression ? resolveHandlerFunctionExpression(spreadOnClickExpression) : null;
-			if (spreadHandlerFunction && (isFocusForwardingFunctionBody(spreadHandlerFunction.body ?? null) || containsBackdropDismissComparison(spreadHandlerFunction.body ?? null))) return;
+			if (!onClick) return;
+			if (isPureEventBlockerHandler(onClick)) return;
+			if (isFocusForwardingHandler(onClick)) return;
+			if (hasJsxSpreadAttribute$1(node.attributes)) return;
 			if (hasCompositeItemRole(node)) return;
 			if (isHoverSelectionListItem(tag, node)) return;
-			if (onClick && isBackdropDismissHandler(onClick)) return;
+			if (isBackdropDismissHandler(onClick)) return;
 			if (containsKeyboardActivatableDescendant(node.parent)) return;
 			if (isHiddenFromScreenReader(node, context.settings)) return;
 			if (isPresentationRole(node)) return;
-			if (KEY_HANDLERS.some((handler) => hasJsxPropIgnoreCase(node.attributes, handler) || spreadEventValues.has(handler.toLowerCase()))) return;
+			if (KEY_HANDLERS.some((handler) => hasJsxPropIgnoreCase(node.attributes, handler))) return;
 			context.report({
 				node: node.name,
 				message: MESSAGE$57
@@ -7712,7 +7618,7 @@ const isCreateClassLikeCall = (node) => {
 	if (isNodeOfType(callee, "MemberExpression")) return getStaticMemberName$2(callee) === "createClass";
 	return false;
 };
-const isCreateContextCall$1 = (node) => {
+const isCreateContextCall = (node) => {
 	if (!isNodeOfType(node, "CallExpression")) return false;
 	const callee = node.callee;
 	if (isNodeOfType(callee, "Identifier")) return callee.name === "createContext";
@@ -7889,7 +7795,7 @@ const displayName = defineRule({
 				}
 			},
 			CallExpression(node) {
-				if (settings.checkContextObjects && isReactVersionAtLeast$1(settings.reactVersion, 16, 3) && isCreateContextCall$1(node)) {
+				if (settings.checkContextObjects && isReactVersionAtLeast$1(settings.reactVersion, 16, 3) && isCreateContextCall(node)) {
 					const assignedName = getAssignedName(node);
 					if (assignedName) {
 						const programRoot = findProgramRoot(node);
@@ -7936,6 +7842,21 @@ const displayName = defineRule({
 	}
 });
 //#endregion
+//#region src/plugin/utils/get-static-property-key-name.ts
+const getStaticPropertyKeyName = (node, options = {}) => {
+	if (!isNodeOfType(node, "Property")) return null;
+	if (node.computed) {
+		if (options.allowComputedString && isNodeOfType(node.key, "Literal") && typeof node.key.value === "string") return node.key.value;
+		return null;
+	}
+	if (isNodeOfType(node.key, "Identifier")) return node.key.name;
+	if (isNodeOfType(node.key, "Literal")) {
+		if (typeof node.key.value === "string") return node.key.value;
+		if (options.stringifyNonStringLiterals) return String(node.key.value);
+	}
+	return null;
+};
+//#endregion
 //#region src/plugin/utils/read-static-boolean.ts
 const readStaticBoolean = (node) => {
 	if (!node) return null;
@@ -7944,6 +7865,21 @@ const readStaticBoolean = (node) => {
 	return unwrappedNode.value;
 };
 //#endregion
+//#region src/plugin/utils/resolve-const-identifier-alias.ts
+const resolveConstIdentifierAlias = (identifier, scopes) => {
+	if (!isNodeOfType(identifier, "Identifier")) return null;
+	const visitedSymbolIds = /* @__PURE__ */ new Set();
+	let symbol = scopes.symbolFor(identifier);
+	while (symbol?.kind === "const") {
+		if (visitedSymbolIds.has(symbol.id) || !symbol.initializer || !isNodeOfType(symbol.declarationNode, "VariableDeclarator") || symbol.declarationNode.id !== symbol.bindingIdentifier) return null;
+		visitedSymbolIds.add(symbol.id);
+		const initializer = stripParenExpression(symbol.initializer);
+		if (!isNodeOfType(initializer, "Identifier")) return symbol;
+		symbol = scopes.symbolFor(initializer);
+	}
+	return symbol;
+};
+//#endregion
 //#region src/plugin/utils/is-react-api-call.ts
 const includesApiName = (apiNames, apiName) => typeof apiNames === "string" ? apiNames === apiName : apiNames.has(apiName);
 const isImportedFromReact = (symbol) => {
@@ -7951,9 +7887,9 @@ const isImportedFromReact = (symbol) => {
 	const importDeclaration = symbol.declarationNode.parent;
 	return Boolean(importDeclaration && isNodeOfType(importDeclaration, "ImportDeclaration") && typeof importDeclaration.source.value === "string" && REACT_RUNTIME_MODULE_SOURCES.has(importDeclaration.source.value));
 };
-const isNamedReactApiImport = (identifier, apiNames, scopes, resolveAliases) => {
+const isNamedReactApiImport = (identifier, apiNames, scopes) => {
 	if (!isNodeOfType(identifier, "Identifier")) return false;
-	const symbol = resolveAliases ? resolveConstIdentifierAlias(identifier, scopes) : scopes.symbolFor(identifier);
+	const symbol = scopes.symbolFor(identifier);
 	if (!symbol || !isImportedFromReact(symbol)) return false;
 	const importedName = getImportedName(symbol.declarationNode);
 	return Boolean(importedName && includesApiName(apiNames, importedName));
@@ -7967,7 +7903,7 @@ const isReactApiCall = (node, apiNames, scopes, options = {}) => {
 	if (!isNodeOfType(node, "CallExpression")) return false;
 	const callee = stripParenExpression(node.callee);
 	if (isNodeOfType(callee, "Identifier")) {
-		if (isNamedReactApiImport(callee, apiNames, scopes, Boolean(options.resolveNamedAliases))) return true;
+		if (isNamedReactApiImport(callee, apiNames, scopes)) return true;
 		return Boolean(options.allowUnboundBareCalls && includesApiName(apiNames, callee.name) && scopes.isGlobalReference(callee));
 	}
 	if (!isNodeOfType(callee, "MemberExpression") || callee.computed || !isNodeOfType(callee.property, "Identifier") || !includesApiName(apiNames, callee.property.name)) return false;
@@ -11176,11 +11112,6 @@ If the missing value is recreated every render, move it inside the hook or stabi
 		return { CallExpression(node) {
 			const hookName = getHookName(node.callee, context.scopes);
 			if (!hookName || !isHookOfInterest(hookName, node.callee)) return;
-			if (HOOKS_REQUIRING_DEPS_MATCH.has(hookName) && !isReactApiCall(node, HOOKS_REQUIRING_DEPS_MATCH, context.scopes, {
-				allowGlobalReactNamespace: true,
-				allowUnboundBareCalls: true,
-				resolveNamedAliases: true
-			})) return;
 			const callbackArgumentIndex = getCallbackArgumentIndex(hookName);
 			const depsArgumentIndex = getDepsArgumentIndex(hookName);
 			const callbackArgument = node.arguments[callbackArgumentIndex];
@@ -25139,11 +25070,7 @@ const noAsyncEffectCallback = defineRule({
 	severity: "warn",
 	recommendation: "Don't make the effect callback `async`. Define an async function inside the effect and call it, then return a real cleanup function if you need one.",
 	create: (context) => ({ CallExpression(node) {
-		if (!isReactApiCall(node, EFFECT_HOOK_NAMES$1, context.scopes, {
-			allowGlobalReactNamespace: true,
-			allowUnboundBareCalls: true,
-			resolveNamedAliases: true
-		})) return;
+		if (!isHookCall$2(node, EFFECT_HOOK_NAMES$1)) return;
 		const callback = getEffectCallback(node);
 		if (!callback) return;
 		if (!isNodeOfType(callback, "ArrowFunctionExpression") && !isNodeOfType(callback, "FunctionExpression")) return;
@@ -26341,19 +26268,6 @@ const noCloneElement = defineRule({
 	} })
 });
 //#endregion
-//#region src/plugin/utils/get-call-method-name.ts
-/**
-* Returns the static method name of a call's callee when it's a
-* non-computed MemberExpression (`obj.method` → `"method"`), or
-* `null` otherwise. Used by `no-pass-data-to-parent` and
-* `no-pass-live-state-to-parent` to match the receiver-bound
-* method-call shape against an allow/block list.
-*/
-const getCallMethodName = (callee) => {
-	if (isNodeOfType(callee, "MemberExpression") && !callee.computed && isNodeOfType(callee.property, "Identifier")) return callee.property.name;
-	return null;
-};
-//#endregion
 //#region src/plugin/rules/state-and-effects/no-create-context-in-render.ts
 const MESSAGE$31 = "createContext() builds a new context every render, so every consumer gets cut off & resets.";
 const CONTEXT_MODULES = [
@@ -26361,35 +26275,23 @@ const CONTEXT_MODULES = [
 	"use-context-selector",
 	"react-tracked"
 ];
-const getSupportedContextImportSource = (symbol) => {
-	if (symbol?.kind !== "import") return null;
-	const importDeclaration = symbol.declarationNode.parent;
-	if (!importDeclaration || !isNodeOfType(importDeclaration, "ImportDeclaration") || typeof importDeclaration.source.value !== "string" || !CONTEXT_MODULES.includes(importDeclaration.source.value)) return null;
-	return importDeclaration.source.value;
-};
-const isSupportedNamespaceSymbol = (symbol) => getSupportedContextImportSource(symbol) !== null && Boolean(symbol && (isNodeOfType(symbol.declarationNode, "ImportDefaultSpecifier") || isNodeOfType(symbol.declarationNode, "ImportNamespaceSpecifier")));
-const isDestructuredCreateContextBinding = (identifier, scopes) => {
-	if (!isNodeOfType(identifier, "Identifier")) return false;
-	const symbol = scopes.symbolFor(identifier);
-	if (symbol?.kind !== "const" || !symbol.initializer || !isNodeOfType(symbol.declarationNode, "VariableDeclarator") || !isNodeOfType(symbol.declarationNode.id, "ObjectPattern")) return false;
-	const property = symbol.bindingIdentifier.parent;
-	if (!property || !isNodeOfType(property, "Property") || getStaticPropertyKeyName(property, { allowComputedString: true }) !== "createContext") return false;
-	const initializer = stripParenExpression(symbol.initializer);
-	return isNodeOfType(initializer, "Identifier") && isSupportedNamespaceSymbol(resolveConstIdentifierAlias(initializer, scopes));
-};
-const isCreateContextCall = (node, scopes) => {
-	const callee = stripParenExpression(node.callee);
+const isCreateContextCallee = (callee) => {
 	if (isNodeOfType(callee, "Identifier")) {
-		if (isDestructuredCreateContextBinding(callee, scopes)) return true;
-		const symbol = resolveConstIdentifierAlias(callee, scopes);
-		return getSupportedContextImportSource(symbol) !== null && Boolean(symbol && getImportedName(symbol.declarationNode) === "createContext");
+		const binding = getImportBindingForName(callee, callee.name);
+		return binding !== null && binding.exportedName === "createContext" && CONTEXT_MODULES.includes(binding.source);
 	}
-	if (!isNodeOfType(callee, "MemberExpression")) return false;
-	if ((getCallMethodName(callee) ?? (callee.computed && isNodeOfType(callee.property, "Literal") && typeof callee.property.value === "string" ? callee.property.value : null)) !== "createContext") return false;
-	const receiver = stripParenExpression(callee.object);
-	if (!isNodeOfType(receiver, "Identifier")) return false;
-	if (receiver.name === "React" && scopes.isGlobalReference(receiver)) return true;
-	return isSupportedNamespaceSymbol(resolveConstIdentifierAlias(receiver, scopes));
+	if (isNodeOfType(callee, "MemberExpression") && !callee.computed) {
+		const namespaceIdentifier = callee.object;
+		const propertyIdentifier = callee.property;
+		if (!isNodeOfType(namespaceIdentifier, "Identifier")) return false;
+		if (!isNodeOfType(propertyIdentifier, "Identifier")) return false;
+		if (propertyIdentifier.name !== "createContext") return false;
+		const namespaceName = namespaceIdentifier.name;
+		if (isCanonicalReactNamespaceName(namespaceName)) return true;
+		const importSource = getImportSourceForName(namespaceIdentifier, namespaceName);
+		return importSource !== null && CONTEXT_MODULES.includes(importSource);
+	}
+	return false;
 };
 const noCreateContextInRender = defineRule({
 	id: "no-create-context-in-render",
@@ -26398,7 +26300,7 @@ const noCreateContextInRender = defineRule({
 	category: "Correctness",
 	recommendation: "Move `createContext(...)` outside the component, to the top level of the file, so it stays the same on every render.",
 	create: (context) => ({ CallExpression(node) {
-		if (!isCreateContextCall(node, context.scopes)) return;
+		if (!isCreateContextCallee(node.callee)) return;
 		const componentOrHookName = enclosingComponentOrHookName(node);
 		if (!componentOrHookName) return;
 		context.report({
@@ -30449,11 +30351,7 @@ const noFetchInEffect = defineRule({
 	severity: "warn",
 	recommendation: "Use a data-fetching layer or Server Component so fetches do not race, double-fire, or leak from `useEffect`.",
 	create: (context) => ({ CallExpression(node) {
-		if (!isReactApiCall(node, EFFECT_HOOK_NAMES$1, context.scopes, {
-			allowGlobalReactNamespace: true,
-			allowUnboundBareCalls: true,
-			resolveNamedAliases: true
-		})) return;
+		if (!isHookCall$2(node, EFFECT_HOOK_NAMES$1)) return;
 		const callback = getEffectCallback(node);
 		if (!callback) return;
 		const analysisFunctions = collectEffectAnalysisFunctions(callback, context);
@@ -34663,6 +34561,19 @@ const DATA_SINK_METHOD_NAMES = new Set([
 	"deserialize"
 ]);
 //#endregion
+//#region src/plugin/utils/get-call-method-name.ts
+/**
+* Returns the static method name of a call's callee when it's a
+* non-computed MemberExpression (`obj.method` → `"method"`), or
+* `null` otherwise. Used by `no-pass-data-to-parent` and
+* `no-pass-live-state-to-parent` to match the receiver-bound
+* method-call shape against an allow/block list.
+*/
+const getCallMethodName = (callee) => {
+	if (isNodeOfType(callee, "MemberExpression") && !callee.computed && isNodeOfType(callee.property, "Identifier")) return callee.property.name;
+	return null;
+};
+//#endregion
 //#region src/plugin/rules/state-and-effects/no-pass-data-to-parent.ts
 const isUseStateIdentifier = (identifier) => {
 	if (!isNodeOfType(identifier, "Identifier")) return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.5-dev.bc49aaa",
+  "version": "0.7.5-dev.d9676e2",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",