oxlint-plugin-react-doctor 0.7.2-dev.6ae8e46 → 0.7.2-dev.9b59d96

package/dist/index.js

@@ -8980,24 +8980,6 @@ const isAstDescendant = (inner, outer) => {
 	return false;
 };
 //#endregion
-//#region src/plugin/utils/is-imported-from-non-react-module.ts
-const isImportedFromNonReactModule = (contextNode, localIdentifierName) => {
-	const importSource = getImportSourceForName(contextNode, localIdentifierName);
-	if (importSource === null) return false;
-	return !REACT_RUNTIME_MODULE_SOURCES.has(importSource);
-};
-//#endregion
-//#region src/plugin/utils/is-non-react-effect-event-callee.ts
-const resolvesToLocalNonImportBinding = (identifier, scopes) => {
-	const symbol = scopes.referenceFor(identifier)?.resolvedSymbol;
-	return Boolean(symbol && symbol.kind !== "import");
-};
-const isNonReactEffectEventCallee = (callee, contextNode, scopes) => {
-	if (isNodeOfType(callee, "Identifier")) return isImportedFromNonReactModule(contextNode, callee.name) || resolvesToLocalNonImportBinding(callee, scopes);
-	if (isNodeOfType(callee, "MemberExpression") && !callee.computed && isNodeOfType(callee.object, "Identifier")) return isImportedFromNonReactModule(contextNode, callee.object.name);
-	return false;
-};
-//#endregion
 //#region src/plugin/rules/react-builtins/exhaustive-deps-symbol-stability.ts
 /**
 * Symbol-stability helpers consumed by the `exhaustive-deps` rule.
@@ -9062,11 +9044,10 @@ const symbolHasStableHookOrigin = (symbol) => {
 	}
 	return false;
 };
-const symbolHasUseEffectEventOrigin = (symbol, scopes) => {
+const symbolHasUseEffectEventOrigin = (symbol) => {
 	const initializer = symbol.initializer ? unwrapExpression$3(symbol.initializer) : null;
 	if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
-	if (getHookName(initializer.callee) !== "useEffectEvent") return false;
-	return !isNonReactEffectEventCallee(initializer.callee, initializer, scopes);
+	return getHookName(initializer.callee) === "useEffectEvent";
 };
 const getFunctionValueNode = (symbol) => {
 	if (symbol.kind === "function" && isNodeOfType(symbol.declarationNode, "FunctionDeclaration")) return symbol.declarationNode;
@@ -9803,7 +9784,7 @@ If the missing value is recreated every render, move it inside the hook or stabi
 				if (isLiteralOrEmptyTemplate(stripped)) continue;
 				if (isNodeOfType(stripped, "Identifier")) {
 					const depSymbol = context.scopes.symbolFor(stripped);
-					if (depSymbol && symbolHasUseEffectEventOrigin(depSymbol, context.scopes)) {
+					if (depSymbol && symbolHasUseEffectEventOrigin(depSymbol)) {
 						context.report({
 							node: elementNode,
 							message: buildEffectEventDepMessage()
@@ -25779,33 +25760,6 @@ const initializerMarksPlainState = (initializerArgument) => {
 	}
 	return producesPlainStateValue(unwrapped);
 };
-const producesOpaqueInstanceValue = (expression) => {
-	if (isNodeOfType(expression, "NewExpression")) return true;
-	return isNodeOfType(expression, "CallExpression") && isNodeOfType(expression.callee, "MemberExpression") && !isPlainDataProducerCall(expression);
-};
-const collectSetterValueObservations = (componentBody, setterNames) => {
-	const plainFedSetterNames = /* @__PURE__ */ new Set();
-	const opaqueFedSetterNames = /* @__PURE__ */ new Set();
-	walkAst(componentBody, (node) => {
-		if (!isNodeOfType(node, "CallExpression")) return;
-		if (!isNodeOfType(node.callee, "Identifier")) return;
-		const setterName = node.callee.name;
-		if (!setterNames.has(setterName)) return;
-		const argument = node.arguments?.[0];
-		if (!argument) return;
-		const unwrapped = stripParenExpression(argument);
-		if (isNullOrUndefinedExpression(unwrapped)) return;
-		if (producesPlainStateValue(unwrapped)) {
-			plainFedSetterNames.add(setterName);
-			return;
-		}
-		if (producesOpaqueInstanceValue(unwrapped)) opaqueFedSetterNames.add(setterName);
-	});
-	return {
-		plainFedSetterNames,
-		opaqueFedSetterNames
-	};
-};
 const collectCallbackRefSetterNames = (componentBody) => {
 	const callbackRefSetterNames = /* @__PURE__ */ new Set();
 	walkAst(componentBody, (node) => {
@@ -25875,15 +25829,11 @@ const noDirectStateMutation = defineRule({
 			if (bindings.length === 0) return;
 			const stateValueToSetter = new Map(bindings.map((binding) => [binding.valueName, binding.setterName]));
 			const callbackRefSetterNames = collectCallbackRefSetterNames(componentBody);
-			const setterValueObservations = collectSetterValueObservations(componentBody, new Set(bindings.map((binding) => binding.setterName)));
 			const plainObjectStateValueNames = /* @__PURE__ */ new Set();
 			for (const binding of bindings) {
 				if (callbackRefSetterNames.has(binding.setterName)) continue;
 				if (!isNodeOfType(binding.declarator.init, "CallExpression")) continue;
-				const initializerArgument = binding.declarator.init.arguments?.[0];
-				if (!initializerMarksPlainState(initializerArgument)) continue;
-				if ((!initializerArgument || isNullOrUndefinedExpression(stripParenExpression(initializerArgument))) && setterValueObservations.opaqueFedSetterNames.has(binding.setterName) && !setterValueObservations.plainFedSetterNames.has(binding.setterName)) continue;
-				plainObjectStateValueNames.add(binding.valueName);
+				if (initializerMarksPlainState(binding.declarator.init.arguments?.[0])) plainObjectStateValueNames.add(binding.valueName);
 			}
 			const visitMutationCandidate = (child, currentlyShadowed) => {
 				if (isNodeOfType(child, "AssignmentExpression")) {
@@ -26664,6 +26614,13 @@ const noEffectEventHandler = defineRule({
 	}
 });
 //#endregion
+//#region src/plugin/utils/is-imported-from-non-react-module.ts
+const isImportedFromNonReactModule = (contextNode, localIdentifierName) => {
+	const importSource = getImportSourceForName(contextNode, localIdentifierName);
+	if (importSource === null) return false;
+	return !REACT_RUNTIME_MODULE_SOURCES.has(importSource);
+};
+//#endregion
 //#region src/plugin/rules/state-and-effects/no-effect-event-in-deps.ts
 const createComponentBindingStackTracker = (callbacks) => {
 	const componentBindingStack = [];
@@ -26717,7 +26674,12 @@ const noEffectEventInDeps = defineRule({
 			const initializer = declaratorNode.init;
 			if (!initializer || !isNodeOfType(initializer, "CallExpression")) return;
 			if (!isHookCall$2(initializer, "useEffectEvent")) return;
-			if (isNonReactEffectEventCallee(initializer.callee, declaratorNode, context.scopes)) return;
+			if (isNodeOfType(initializer.callee, "Identifier")) {
+				if (isImportedFromNonReactModule(declaratorNode, initializer.callee.name)) return;
+				const calleeSymbol = context.scopes.referenceFor(initializer.callee)?.resolvedSymbol;
+				if (calleeSymbol && calleeSymbol.kind !== "import") return;
+			}
+			if (isNodeOfType(initializer.callee, "MemberExpression") && !initializer.callee.computed && isNodeOfType(initializer.callee.object, "Identifier") && isImportedFromNonReactModule(declaratorNode, initializer.callee.object.name)) return;
 			componentBindings.addBindingToCurrentFrame(declaratorNode.id.name);
 		} });
 		return {
@@ -37388,10 +37350,6 @@ const isRouteFactoryCall = (expression) => {
 	}
 	return false;
 };
-const isConfigOnlyFactoryCall = (call) => call.arguments.every((argument) => {
-	const expression = skipTsExpression(argument);
-	return isNodeOfType(expression, "ObjectExpression") || isNodeOfType(expression, "Literal") || isNodeOfType(expression, "TemplateLiteral");
-});
 const isReactHocName = (name, state) => state.customHocs.has(name);
 const isHocCallee = (callee, state) => {
 	if (isNodeOfType(callee, "Identifier")) return isReactHocName(callee.name, state);
@@ -37624,10 +37582,6 @@ const onlyExportComponents = defineRule({
 							return false;
 						})();
 						if (isHoc && firstArgIsValid) hasReactExport = true;
-						else if (!isHoc && isConfigOnlyFactoryCall(stripped)) exports.push({
-							kind: "non-component",
-							reportNode: stripped
-						});
 						else context.report({
 							node: stripped,
 							message: ANONYMOUS_MESSAGE
@@ -48600,6 +48554,15 @@ const isUseEffectEventSymbol = (symbol) => {
 	if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
 	return getHookNameFromCallee(initializer.callee) === "useEffectEvent";
 };
+const resolvesToLocalNonImportBinding = (identifier, scopes) => {
+	const symbol = scopes.referenceFor(identifier)?.resolvedSymbol;
+	return Boolean(symbol && symbol.kind !== "import");
+};
+const isNonReactEffectEventCallee = (callee, contextNode, scopes) => {
+	if (isNodeOfType(callee, "Identifier")) return isImportedFromNonReactModule(contextNode, callee.name) || resolvesToLocalNonImportBinding(callee, scopes);
+	if (isNodeOfType(callee, "MemberExpression") && !callee.computed && isNodeOfType(callee.object, "Identifier")) return isImportedFromNonReactModule(contextNode, callee.object.name);
+	return false;
+};
 const isNonReactEffectEventSymbol = (symbol, contextNode, scopes) => {
 	const initializer = symbol.initializer;
 	if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.2-dev.6ae8e46",
+  "version": "0.7.2-dev.9b59d96",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",