oxlint-plugin-react-doctor 0.7.0 → 0.7.1-dev.1880b15

package/dist/index.js

@@ -549,6 +549,12 @@ const INDEX_PARAMETER_NAMES = new Set([
 	"idx",
 	"i"
 ]);
+const REACT_RUNTIME_MODULE_SOURCES = new Set([
+	"react",
+	"react-dom",
+	"preact/compat",
+	"preact/hooks"
+]);
 const LOADING_STATE_PATTERN = /^(?:isLoading|isPending)$/;
 const STABLE_HOOK_WRAPPERS = new Set([
 	"useState",
@@ -9219,6 +9225,7 @@ const iframeMissingSandbox = defineRule({
 	severity: "warn",
 	recommendation: "Add `sandbox=\"\"` or a curated value so embedded pages cannot get full access to your site by default.",
 	category: "Security",
+	matchByOccurrence: true,
 	create: skipNonProductionFiles((context) => ({
 		JSXOpeningElement(node) {
 			if (!isNodeOfType(node.name, "JSXIdentifier") || node.name.name !== "iframe") return;
@@ -21605,6 +21612,13 @@ const noEffectEventHandler = defineRule({
 	}
 });
 //#endregion
+//#region src/plugin/utils/is-imported-from-non-react-module.ts
+const isImportedFromNonReactModule = (contextNode, localIdentifierName) => {
+	const importSource = getImportSourceForName(contextNode, localIdentifierName);
+	if (importSource === null) return false;
+	return !REACT_RUNTIME_MODULE_SOURCES.has(importSource);
+};
+//#endregion
 //#region src/plugin/rules/state-and-effects/no-effect-event-in-deps.ts
 const createComponentBindingStackTracker = (callbacks) => {
 	const componentBindingStack = [];
@@ -21658,6 +21672,7 @@ const noEffectEventInDeps = defineRule({
 			const initializer = declaratorNode.init;
 			if (!initializer || !isNodeOfType(initializer, "CallExpression")) return;
 			if (!isHookCall$1(initializer, "useEffectEvent")) return;
+			if (isNodeOfType(initializer.callee, "Identifier") && isImportedFromNonReactModule(declaratorNode, initializer.callee.name)) return;
 			componentBindings.addBindingToCurrentFrame(declaratorNode.id.name);
 		} });
 		return {
@@ -39394,6 +39409,12 @@ const isUseEffectEventSymbol = (symbol) => {
 	if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
 	return getHookNameFromCallee(initializer.callee) === "useEffectEvent";
 };
+const isNonReactEffectEventCallee = (callee, contextNode) => isNodeOfType(callee, "Identifier") && isImportedFromNonReactModule(contextNode, callee.name);
+const isNonReactEffectEventSymbol = (symbol, contextNode) => {
+	const initializer = symbol.initializer;
+	if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
+	return isNonReactEffectEventCallee(initializer.callee, contextNode);
+};
 const findEnclosingComponentOrHookFunction = (node) => {
 	let current = node.parent;
 	while (current) {
@@ -39447,7 +39468,7 @@ const rulesOfHooks = defineRule({
 				const hookContext = isHookCall(node, context.scopes, settings);
 				if (!hookContext) return;
 				const { hookName } = hookContext;
-				if (hookName === "useEffectEvent" && !isUseEffectEventInitializer(node)) {
+				if (hookName === "useEffectEvent" && !isUseEffectEventInitializer(node) && !isNonReactEffectEventCallee(node.callee, node)) {
 					context.report({
 						node: node.callee,
 						message: buildEffectEventPassedDownMessage()
@@ -39557,6 +39578,7 @@ const rulesOfHooks = defineRule({
 			Identifier(node) {
 				const symbol = context.scopes.referenceFor(node)?.resolvedSymbol;
 				if (!symbol || !isUseEffectEventSymbol(symbol)) return;
+				if (isNonReactEffectEventSymbol(symbol, node)) return;
 				if (!isSameComponentOrHookScope(symbol, node)) return;
 				if (isInsideAllowedEffectEventCallback(node, additionalEffectHooksRegex)) return;
 				context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.7.0",
+  "version": "0.7.1-dev.1880b15",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",