oxlint-plugin-react-doctor 0.6.1 → 0.6.2-dev.b4faf74

package/dist/index.js

@@ -212,8 +212,16 @@ const sliceBelowSourceRoot = (filename) => {
 	if (cutAt < 0) return filename;
 	return filename.slice(cutAt);
 };
+let lastFilename;
+let lastResult = false;
 const isTestlikeFilename = (rawFilename) => {
 	if (!rawFilename) return false;
+	if (rawFilename === lastFilename) return lastResult;
+	lastFilename = rawFilename;
+	lastResult = computeIsTestlikeFilename(rawFilename);
+	return lastResult;
+};
+const computeIsTestlikeFilename = (rawFilename) => {
 	const filename = rawFilename.replaceAll("\\", "/");
 	const lastSlash = filename.lastIndexOf("/");
 	const basename = lastSlash === -1 ? filename : filename.slice(lastSlash + 1);
@@ -983,16 +991,8 @@ const buildBindingIndex = (root) => {
 				}
 			}
 		}
-		const nodeRecord = node;
-		for (const key of Object.keys(nodeRecord)) {
-			if (key === "parent") continue;
-			const child = nodeRecord[key];
-			if (Array.isArray(child)) {
-				for (const item of child) if (isAstNode(item)) visit(item);
-			} else if (isAstNode(child)) visit(child);
-		}
 	};
-	visit(root);
+	walkAst(root, visit);
 	return out;
 };
 const programRootCache = /* @__PURE__ */ new WeakMap();
@@ -1423,49 +1423,40 @@ const getElementType = (openingElement, settings) => {
 //#region src/plugin/utils/find-import-source-for-name.ts
 const collectFromProgram = (programRoot) => {
 	const lookup = /* @__PURE__ */ new Map();
-	const visit = (node) => {
-		if (node.type === "ImportDeclaration" && "source" in node && node.source) {
-			const source = node.source.value;
-			if (typeof source !== "string") return;
-			if ("specifiers" in node && Array.isArray(node.specifiers)) for (const specifier of node.specifiers) {
-				if (!("local" in specifier) || !specifier.local) continue;
-				const local = specifier.local;
-				if (typeof local.name !== "string") continue;
-				if (specifier.type === "ImportDefaultSpecifier") lookup.set(local.name, {
-					source,
-					imported: null,
-					isDefault: true,
-					isNamespace: false
-				});
-				else if (specifier.type === "ImportNamespaceSpecifier") lookup.set(local.name, {
+	const bodyStatements = programRoot.body ?? [];
+	for (const node of bodyStatements) {
+		if (node.type !== "ImportDeclaration" || !("source" in node) || !node.source) continue;
+		const source = node.source.value;
+		if (typeof source !== "string") continue;
+		if (!("specifiers" in node) || !Array.isArray(node.specifiers)) continue;
+		for (const specifier of node.specifiers) {
+			if (!("local" in specifier) || !specifier.local) continue;
+			const local = specifier.local;
+			if (typeof local.name !== "string") continue;
+			if (specifier.type === "ImportDefaultSpecifier") lookup.set(local.name, {
+				source,
+				imported: null,
+				isDefault: true,
+				isNamespace: false
+			});
+			else if (specifier.type === "ImportNamespaceSpecifier") lookup.set(local.name, {
+				source,
+				imported: null,
+				isDefault: false,
+				isNamespace: true
+			});
+			else if (specifier.type === "ImportSpecifier") {
+				const importedNode = specifier.imported;
+				const importedName = importedNode?.name ?? (typeof importedNode?.value === "string" ? importedNode.value : null);
+				lookup.set(local.name, {
 					source,
-					imported: null,
+					imported: importedName,
 					isDefault: false,
-					isNamespace: true
+					isNamespace: false
 				});
-				else if (specifier.type === "ImportSpecifier") {
-					const importedNode = specifier.imported;
-					const importedName = importedNode?.name ?? (typeof importedNode?.value === "string" ? importedNode.value : null);
-					lookup.set(local.name, {
-						source,
-						imported: importedName,
-						isDefault: false,
-						isNamespace: false
-					});
-				}
 			}
-			return;
-		}
-		const nodeRecord = node;
-		for (const key of Object.keys(nodeRecord)) {
-			if (key === "parent") continue;
-			const child = nodeRecord[key];
-			if (Array.isArray(child)) {
-				for (const item of child) if (isAstNode(item)) visit(item);
-			} else if (isAstNode(child)) visit(child);
 		}
-	};
-	visit(programRoot);
+	}
 	return lookup;
 };
 const importLookupCache = /* @__PURE__ */ new WeakMap();
@@ -1479,6 +1470,12 @@ const getImportLookup = (node) => {
 	}
 	return cached;
 };
+const hasImportFromModules = (contextNode, moduleSources) => {
+	const lookup = getImportLookup(contextNode);
+	if (!lookup) return false;
+	for (const info of lookup.values()) if (moduleSources.includes(info.source)) return true;
+	return false;
+};
 const isImportedFromModule = (contextNode, localIdentifierName, moduleSource) => {
 	const lookup = getImportLookup(contextNode);
 	if (!lookup) return false;
@@ -1631,6 +1628,7 @@ const normalizeFilename = (filename) => filename.replaceAll("\\", "/");
 //#region src/plugin/utils/is-generated-image-render-context.ts
 const IMAGE_RESPONSE_MODULES = ["next/og", "@vercel/og"];
 const SATORI_MODULE = "satori";
+const GENERATED_IMAGE_MODULES = [...IMAGE_RESPONSE_MODULES, SATORI_MODULE];
 const generatedImageJsxCache = /* @__PURE__ */ new WeakMap();
 const isGeneratedImageRenderFilename = (rawFilename) => {
 	if (!rawFilename) return false;
@@ -1774,7 +1772,7 @@ const collectGeneratedImageJsxNodes = (programRoot) => {
 	const cached = generatedImageJsxCache.get(programRoot);
 	if (cached) return cached;
 	const generatedImageJsxNodes = /* @__PURE__ */ new WeakSet();
-	walkAst(programRoot, (descendantNode) => {
+	if (hasImportFromModules(programRoot, GENERATED_IMAGE_MODULES)) walkAst(programRoot, (descendantNode) => {
 		if (!isGeneratedImageRendererCall(descendantNode)) return;
 		for (const argument of descendantNode.arguments) markGeneratedImageExpression(argument, programRoot, generatedImageJsxNodes, /* @__PURE__ */ new Set());
 	});
@@ -3460,7 +3458,7 @@ const SECRET_UNAMBIGUOUS_PLACEHOLDER_VALUE_PATTERNS = [
 ];
 const SECRET_CONTEXTUAL_PLACEHOLDER_VALUE_PATTERNS = [/(?:^|[_\-\s])(?:example|sample|dummy)(?:$|[_\-\s])/i];
 const SECRET_PLACEHOLDER_CONTEXT_PATTERN = /(?:placeholder|example|sample|dummy|masked|redacted|mask)/i;
-const SECRET_VARIABLE_PATTERN = /(?:api_?key|secret|token|password|credential|auth)/i;
+const SECRET_VARIABLE_PATTERN = /(?:api_?key|secret|token|password|credential|auth(?!or(?!i[sz])))/i;
 const SECRET_TOOLING_FILE_PATTERN = /(?:^|\/)[^/]+\.config\.[cm]?[jt]s$/;
 const SECRET_TOOLING_RC_FILE_PATTERN = /(?:^|\/)(?:\.[a-z-]+rc|[a-z-]+\.rc)\.[cm]?[jt]s$/;
 const SECRET_TEST_FILE_PATTERN = /(?:^|\/)[^/]+\.(?:test|spec|stories|story|fixture|fixtures)\.[cm]?[jt]sx?$/;
@@ -3967,9 +3965,11 @@ const collectScopedReferenceIdentifierNames = (node, into, shadowed) => {
 		return;
 	}
 	if (typeof node.type === "string" && node.type.startsWith("TS")) return;
-	for (const [key, child] of Object.entries(node)) {
+	const nodeRecord = node;
+	for (const key of Object.keys(nodeRecord)) {
 		if (key === "parent") continue;
 		if (TYPE_POSITION_CHILD_KEYS.has(key)) continue;
+		const child = nodeRecord[key];
 		if (Array.isArray(child)) {
 			for (const item of child) if (isAstNode(item)) collectScopedReferenceIdentifierNames(item, into, shadowed);
 		} else if (isAstNode(child)) collectScopedReferenceIdentifierNames(child, into, shadowed);
@@ -10439,10 +10439,15 @@ const jsCombineIterations = defineRule({
 	severity: "warn",
 	recommendation: "Combine `.map().filter()` style chains into one pass with `.reduce()` or a `for...of` loop, so you only loop over the list once",
 	create: (context) => {
-		let generatorNamesInFile = /* @__PURE__ */ new Set();
+		let programNode = null;
+		let generatorNamesInFile = null;
+		const getGeneratorNamesInFile = () => {
+			generatorNamesInFile ??= programNode ? collectGeneratorNames(programNode) : /* @__PURE__ */ new Set();
+			return generatorNamesInFile;
+		};
 		return {
-			Program(programNode) {
-				generatorNamesInFile = collectGeneratorNames(programNode);
+			Program(node) {
+				programNode = node;
 			},
 			CallExpression(node) {
 				if (!isNodeOfType(node.callee, "MemberExpression") || !isNodeOfType(node.callee.property, "Identifier")) return;
@@ -10464,7 +10469,7 @@ const jsCombineIterations = defineRule({
 					if (isNullFilteringPredicate(filterArgument)) return;
 					if (isTypePredicateArrow(filterArgument)) return;
 				}
-				if (isReceiverChainIteratorRooted(innerCall.callee.object, generatorNamesInFile)) return;
+				if (isReceiverChainIteratorRooted(innerCall.callee.object, getGeneratorNamesInFile())) return;
 				if (isSmallLiteralArrayRootedChain(innerCall.callee.object)) return;
 				if (isStringSplitRootedChain(innerCall.callee.object)) return;
 				context.report({
@@ -12524,6 +12529,7 @@ const KNOWN_SLOT_PROP_NAMES = new Set([
 	"bottomContent",
 	"leftContent",
 	"rightContent",
+	"config",
 	"value",
 	"currentValue",
 	"form",
@@ -12662,6 +12668,10 @@ const SLOT_PROP_SUFFIXES = [
 	"Panel",
 	"Overlay",
 	"Shape",
+	"Avatar",
+	"Text",
+	"State",
+	"Zone",
 	"Override",
 	"Overrides",
 	"Items",
@@ -12678,6 +12688,8 @@ const SLOT_PROP_SUFFIXES = [
 ];
 const isSlotPropName = (propName) => {
 	if (KNOWN_SLOT_PROP_NAMES.has(propName)) return true;
+	const decapitalized = propName.charAt(0).toLowerCase() + propName.slice(1);
+	if (decapitalized !== propName && KNOWN_SLOT_PROP_NAMES.has(decapitalized)) return true;
 	for (const suffix of SLOT_PROP_SUFFIXES) if (propName.length > suffix.length && propName.endsWith(suffix)) return true;
 	return false;
 };
@@ -29521,21 +29533,18 @@ const classifyExport = (name, reportNode, isFunction, initializer, state) => {
 		reportNode
 	};
 };
-const collectAllNodes = (programRoot) => {
-	const out = [];
-	const visit = (node) => {
-		out.push(node);
-		const record = node;
-		for (const key of Object.keys(record)) {
-			if (key === "parent") continue;
-			const child = record[key];
-			if (Array.isArray(child)) {
-				for (const item of child) if (isAstNode(item)) visit(item);
-			} else if (isAstNode(child)) visit(child);
-		}
+const collectRelevantNodes = (programRoot) => {
+	const exportNodes = [];
+	const componentCandidates = [];
+	walkAst(programRoot, (child) => {
+		const childType = child.type;
+		if (childType === "ExportAllDeclaration" || childType === "ExportDefaultDeclaration" || childType === "ExportNamedDeclaration") exportNodes.push(child);
+		else if (childType === "FunctionDeclaration" || childType === "VariableDeclarator") componentCandidates.push(child);
+	});
+	return {
+		exportNodes,
+		componentCandidates
 	};
-	visit(programRoot);
-	return out;
 };
 const isEntryPointFile = (filename) => {
 	const lastSlash = Math.max(filename.lastIndexOf("/"), filename.lastIndexOf("\\"));
@@ -29582,13 +29591,13 @@ const onlyExportComponents = defineRule({
 		};
 		return { Program(node) {
 			if (!isFileNameAllowed(normalizeFilename(context.filename ?? ""), settings.checkJS)) return;
-			const allNodes = collectAllNodes(node);
+			const { exportNodes, componentCandidates } = collectRelevantNodes(node);
 			const exports = [];
 			let hasReactExport = false;
 			let hasAnyExports = false;
 			const localComponents = [];
 			const isExportedNodeIds = /* @__PURE__ */ new WeakSet();
-			for (const child of allNodes) {
+			for (const child of exportNodes) {
 				if (isNodeOfType(child, "ExportAllDeclaration")) {
 					if (child.exportKind === "type") continue;
 					hasAnyExports = true;
@@ -29724,12 +29733,12 @@ const onlyExportComponents = defineRule({
 				}
 				return false;
 			};
-			for (const child of allNodes) {
+			for (const child of componentCandidates) {
 				if (isNodeOfType(child, "FunctionDeclaration") && child.id) {
-					if (isReactComponentName(child.id.name) && !isInsideExport(child)) localComponents.push(child.id);
+					if (isReactComponentName(child.id.name) && !isInsideExport(child) && !isInsideFunctionScope(child)) localComponents.push(child.id);
 				}
 				if (isNodeOfType(child, "VariableDeclarator") && isNodeOfType(child.id, "Identifier")) {
-					if (isReactComponentName(child.id.name) && canBeReactFunctionComponent(child.init, state) && !isInsideExport(child)) localComponents.push(child.id);
+					if (isReactComponentName(child.id.name) && canBeReactFunctionComponent(child.init, state) && !isInsideExport(child) && !isInsideFunctionScope(child)) localComponents.push(child.id);
 				}
 			}
 			if (hasAnyExports && hasReactExport) for (const entry of exports) {
@@ -46841,23 +46850,29 @@ const FALLBACK_CFG = {
 	enclosingFunction: () => null,
 	isUnconditionalFromEntry: () => false
 };
+const scopesByProgram = /* @__PURE__ */ new WeakMap();
+const cfgByProgram = /* @__PURE__ */ new WeakMap();
 const wrapWithSemanticContext = (rule) => ({
 	...rule,
 	create: (baseContext) => {
 		let programRoot = null;
-		let cachedScopes = null;
-		let cachedCfg = null;
 		const getScopes = () => {
-			if (cachedScopes) return cachedScopes;
 			if (!programRoot) return buildFallbackScopes();
-			cachedScopes = analyzeScopes(programRoot);
-			return cachedScopes;
+			let scopes = scopesByProgram.get(programRoot);
+			if (!scopes) {
+				scopes = analyzeScopes(programRoot);
+				scopesByProgram.set(programRoot, scopes);
+			}
+			return scopes;
 		};
 		const getCfg = () => {
-			if (cachedCfg) return cachedCfg;
 			if (!programRoot) return FALLBACK_CFG;
-			cachedCfg = analyzeControlFlow(programRoot);
-			return cachedCfg;
+			let cfg = cfgByProgram.get(programRoot);
+			if (!cfg) {
+				cfg = analyzeControlFlow(programRoot);
+				cfgByProgram.set(programRoot, cfg);
+			}
+			return cfg;
 		};
 		const enrichedContext = {
 			report: baseContext.report,
@@ -46872,23 +46887,18 @@ const wrapWithSemanticContext = (rule) => ({
 				return getCfg();
 			}
 		};
-		const captureRootIfNeeded = (node) => {
-			if (programRoot) return;
-			programRoot = findProgramRoot(node);
-		};
 		const visitors = rule.create(enrichedContext);
-		const wrappedVisitors = {};
+		const passthroughVisitors = {};
 		for (const [nodeType, handler] of Object.entries(visitors)) {
 			if (typeof handler !== "function") continue;
-			wrappedVisitors[nodeType] = ((node) => {
-				captureRootIfNeeded(node);
-				handler(node);
-			});
+			passthroughVisitors[nodeType] = handler;
 		}
-		if (!visitors.Program) wrappedVisitors.Program = (node) => {
-			captureRootIfNeeded(node);
-		};
-		return wrappedVisitors;
+		const innerProgramHandler = passthroughVisitors.Program;
+		passthroughVisitors.Program = ((node) => {
+			programRoot = node;
+			if (innerProgramHandler) innerProgramHandler(node);
+		});
+		return passthroughVisitors;
 	}
 });
 //#endregion

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.6.1",
+  "version": "0.6.2-dev.b4faf74",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",