oxlint-plugin-react-doctor 0.5.8-dev.ba2af1b → 0.5.8-dev.c72b560

package/dist/index.js

@@ -10789,10 +10789,22 @@ const isWithinChildrenToArray = (jsxNode) => {
 	}
 	return false;
 };
+const spreadCanOverwriteKey = (spreadAttribute) => {
+	const argument = spreadAttribute.argument;
+	if (!isNodeOfType(argument, "ObjectExpression")) return true;
+	for (const property of argument.properties) {
+		if (!isNodeOfType(property, "Property")) return true;
+		if (property.computed) return true;
+		const propertyKey = property.key;
+		if (isNodeOfType(propertyKey, "Identifier") && propertyKey.name === "key") return true;
+		if (isNodeOfType(propertyKey, "Literal") && String(propertyKey.value) === "key") return true;
+	}
+	return false;
+};
 const checkKeyBeforeSpread = (context, openingElement) => {
 	let keyIndex = null;
 	let keyAttribute = null;
-	let firstSpreadIndex = null;
+	let lastOverwritingSpreadIndex = null;
 	for (let attributeIndex = 0; attributeIndex < openingElement.attributes.length; attributeIndex++) {
 		const attribute = openingElement.attributes[attributeIndex];
 		if (isNodeOfType(attribute, "JSXAttribute")) {
@@ -10800,11 +10812,9 @@ const checkKeyBeforeSpread = (context, openingElement) => {
 				keyIndex = attributeIndex;
 				keyAttribute = attribute;
 			}
-		} else if (isNodeOfType(attribute, "JSXSpreadAttribute")) {
-			if (firstSpreadIndex === null) firstSpreadIndex = attributeIndex;
-		}
+		} else if (isNodeOfType(attribute, "JSXSpreadAttribute") && spreadCanOverwriteKey(attribute)) lastOverwritingSpreadIndex = attributeIndex;
 	}
-	if (keyIndex !== null && firstSpreadIndex !== null && keyIndex > firstSpreadIndex && keyAttribute) context.report({
+	if (keyIndex !== null && lastOverwritingSpreadIndex !== null && lastOverwritingSpreadIndex > keyIndex && keyAttribute) context.report({
 		node: keyAttribute,
 		message: KEY_BEFORE_SPREAD
 	});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.5.8-dev.ba2af1b",
+  "version": "0.5.8-dev.c72b560",
   "description": "React Doctor rules for oxlint.",
   "keywords": [
     "accessibility",