oxlint-plugin-react-doctor 0.5.1-dev.1ca6f0e → 0.5.1-dev.22268f7

package/dist/index.js

@@ -1132,6 +1132,15 @@ const isMemberProperty = (node, propertyName) => Boolean(node && isNodeOfType(no
 const NEXTJS_SOURCE_FILE_EXTENSION_GROUP = "(?:tsx?|jsx?|mts|mjs)";
 const PAGE_FILE_PATTERN = new RegExp(`/page\\.${NEXTJS_SOURCE_FILE_EXTENSION_GROUP}$`);
 const PAGE_OR_LAYOUT_FILE_PATTERN = new RegExp(`/(page|layout)\\.${NEXTJS_SOURCE_FILE_EXTENSION_GROUP}$`);
+const LAYOUT_FILE_NAMES = [
+	"layout.tsx",
+	"layout.jsx",
+	"layout.ts",
+	"layout.js",
+	"layout.mts",
+	"layout.mjs"
+];
+const METADATA_EXPORT_NAMES = ["metadata", "generateMetadata"];
 const INTERNAL_PAGE_PATH_PATTERN = /\/(?:(?:\((?:dashboard|admin|settings|account|internal|manage|console|portal|auth|onboarding|app|ee|protected)\))|(?:dashboard|admin|settings|account|internal|manage|console|portal))\//i;
 const PAGES_DIRECTORY_PATTERN = /\/pages\//;
 const NEXTJS_NAVIGATION_FUNCTIONS = new Set([
@@ -12543,6 +12552,64 @@ const nextjsInlineScriptMissingId = defineRule({
 	} })
 });
 //#endregion
+//#region src/plugin/utils/parse-export-specifiers.ts
+const getSpecifierName = (rawName) => rawName.replace(/^type\s+/, "").trim();
+const parseExportSpecifiers = (specifiersText, declarationIsTypeOnly) => specifiersText.split(",").map((specifierText) => specifierText.trim()).filter(Boolean).map((specifierText) => {
+	const isTypeOnly = declarationIsTypeOnly || specifierText.startsWith("type ");
+	const [rawLocalName, rawExportedName] = specifierText.split(/\s+as\s+/);
+	const localName = getSpecifierName(rawLocalName ?? "");
+	return {
+		localName,
+		exportedName: getSpecifierName(rawExportedName ?? localName),
+		isTypeOnly
+	};
+});
+//#endregion
+//#region src/plugin/utils/strip-js-comments.ts
+const BLOCK_COMMENT_PATTERN = /\/\*[\s\S]*?\*\//g;
+const LINE_COMMENT_PATTERN = /^\s*\/\/.*$/gm;
+const stripJsComments = (sourceText) => sourceText.replace(BLOCK_COMMENT_PATTERN, "").replace(LINE_COMMENT_PATTERN, "");
+//#endregion
+//#region src/plugin/utils/does-module-export-name.ts
+const DEFAULT_EXPORT_DECLARATION_PATTERN = /^\s*export\s+default\b/m;
+const NAMED_EXPORT_DECLARATION_PATTERN = /^\s*export\s+(?:declare\s+)?(?:(?:async\s+)?function|(?:abstract\s+)?class|const|let|var|enum|interface|type)\s+([\w$]+)/gm;
+const LOCAL_EXPORT_SPECIFIER_DECLARATION_PATTERN$1 = /^\s*export\s+(?:type\s+)?\{([\s\S]*?)\}(?:\s+from\s+["'][^"']+["'])?\s*;?\s*(?:(?:\/\/[^\n]*)?\s*)/gm;
+const doesSourceTextExportName = (sourceText, exportedName) => {
+	const strippedSource = stripJsComments(sourceText);
+	if (exportedName === "default" && DEFAULT_EXPORT_DECLARATION_PATTERN.test(strippedSource)) return true;
+	for (const match of strippedSource.matchAll(NAMED_EXPORT_DECLARATION_PATTERN)) if (match[1] === exportedName) return true;
+	for (const match of strippedSource.matchAll(LOCAL_EXPORT_SPECIFIER_DECLARATION_PATTERN$1)) if (parseExportSpecifiers(match[1] ?? "", false).map((specifier) => specifier.exportedName).includes(exportedName)) return true;
+	return false;
+};
+const doesModuleExportName = (filePath, exportedName) => {
+	try {
+		return doesSourceTextExportName(fs.readFileSync(filePath, "utf8"), exportedName);
+	} catch {
+		return false;
+	}
+};
+//#endregion
+//#region src/plugin/utils/has-ancestor-layout-matching.ts
+const hasAncestorLayoutMatching = (pageFilename, matchesLayout) => {
+	const normalizedPage = pageFilename.replaceAll("\\", "/");
+	let currentDirectory = path.dirname(normalizedPage);
+	for (let level = 0; level < 30; level++) {
+		for (const layoutFileName of LAYOUT_FILE_NAMES) {
+			const layoutPath = path.join(currentDirectory, layoutFileName);
+			if (layoutPath.replaceAll("\\", "/") === normalizedPage) continue;
+			if (matchesLayout(layoutPath)) return true;
+		}
+		const parentDirectory = path.dirname(currentDirectory);
+		if (path.basename(currentDirectory) === "app" && path.basename(parentDirectory) !== "app") break;
+		if (parentDirectory === currentDirectory) break;
+		currentDirectory = parentDirectory;
+	}
+	return false;
+};
+//#endregion
+//#region src/plugin/utils/find-ancestor-metadata-layout.ts
+const hasAncestorMetadataLayout = (pageFilename) => hasAncestorLayoutMatching(pageFilename, (layoutPath) => METADATA_EXPORT_NAMES.some((exportName) => doesModuleExportName(layoutPath, exportName)));
+//#endregion
 //#region src/plugin/rules/nextjs/nextjs-missing-metadata.ts
 const nextjsMissingMetadata = defineRule({
 	id: "nextjs-missing-metadata",
@@ -12555,13 +12622,15 @@ const nextjsMissingMetadata = defineRule({
 		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!PAGE_FILE_PATTERN.test(filename)) return;
 		if (INTERNAL_PAGE_PATH_PATTERN.test(filename)) return;
-		if (!programNode.body?.some((statement) => {
+		if (programNode.body?.some((statement) => {
 			if (!isNodeOfType(statement, "ExportNamedDeclaration")) return false;
 			const declaration = statement.declaration;
-			if (isNodeOfType(declaration, "VariableDeclaration")) return declaration.declarations?.some((declarator) => isNodeOfType(declarator.id, "Identifier") && (declarator.id.name === "metadata" || declarator.id.name === "generateMetadata"));
+			if (isNodeOfType(declaration, "VariableDeclaration")) return declaration.declarations?.some((declarator) => isNodeOfType(declarator.id, "Identifier") && METADATA_EXPORT_NAMES.includes(declarator.id.name));
 			if (isNodeOfType(declaration, "FunctionDeclaration")) return declaration.id?.name === "generateMetadata";
-			return false;
-		})) context.report({
+			return (statement.specifiers ?? []).some((specifier) => isNodeOfType(specifier, "ExportSpecifier") && isNodeOfType(specifier.exported, "Identifier") && METADATA_EXPORT_NAMES.includes(specifier.exported.name));
+		})) return;
+		if (hasAncestorMetadataLayout(context.filename ?? "")) return;
+		context.report({
 			node: programNode,
 			message: "This page has no metadata, so search engines and social previews get no title or description."
 		});
@@ -13452,43 +13521,6 @@ const parseSourceFile = (absoluteFilePath) => {
 	return parsedProgram;
 };
 //#endregion
-//#region src/plugin/utils/parse-export-specifiers.ts
-const getSpecifierName = (rawName) => rawName.replace(/^type\s+/, "").trim();
-const parseExportSpecifiers = (specifiersText, declarationIsTypeOnly) => specifiersText.split(",").map((specifierText) => specifierText.trim()).filter(Boolean).map((specifierText) => {
-	const isTypeOnly = declarationIsTypeOnly || specifierText.startsWith("type ");
-	const [rawLocalName, rawExportedName] = specifierText.split(/\s+as\s+/);
-	const localName = getSpecifierName(rawLocalName ?? "");
-	return {
-		localName,
-		exportedName: getSpecifierName(rawExportedName ?? localName),
-		isTypeOnly
-	};
-});
-//#endregion
-//#region src/plugin/utils/strip-js-comments.ts
-const BLOCK_COMMENT_PATTERN = /\/\*[\s\S]*?\*\//g;
-const LINE_COMMENT_PATTERN = /^\s*\/\/.*$/gm;
-const stripJsComments = (sourceText) => sourceText.replace(BLOCK_COMMENT_PATTERN, "").replace(LINE_COMMENT_PATTERN, "");
-//#endregion
-//#region src/plugin/utils/does-module-export-name.ts
-const DEFAULT_EXPORT_DECLARATION_PATTERN = /^\s*export\s+default\b/m;
-const NAMED_EXPORT_DECLARATION_PATTERN = /^\s*export\s+(?:declare\s+)?(?:(?:async\s+)?function|(?:abstract\s+)?class|const|let|var|enum|interface|type)\s+([\w$]+)/gm;
-const LOCAL_EXPORT_SPECIFIER_DECLARATION_PATTERN$1 = /^\s*export\s+(?:type\s+)?\{([\s\S]*?)\}(?:\s+from\s+["'][^"']+["'])?\s*;?\s*(?:(?:\/\/[^\n]*)?\s*)/gm;
-const doesSourceTextExportName = (sourceText, exportedName) => {
-	const strippedSource = stripJsComments(sourceText);
-	if (exportedName === "default" && DEFAULT_EXPORT_DECLARATION_PATTERN.test(strippedSource)) return true;
-	for (const match of strippedSource.matchAll(NAMED_EXPORT_DECLARATION_PATTERN)) if (match[1] === exportedName) return true;
-	for (const match of strippedSource.matchAll(LOCAL_EXPORT_SPECIFIER_DECLARATION_PATTERN$1)) if (parseExportSpecifiers(match[1] ?? "", false).map((specifier) => specifier.exportedName).includes(exportedName)) return true;
-	return false;
-};
-const doesModuleExportName = (filePath, exportedName) => {
-	try {
-		return doesSourceTextExportName(fs.readFileSync(filePath, "utf8"), exportedName);
-	} catch {
-		return false;
-	}
-};
-//#endregion
 //#region src/plugin/utils/is-barrel-index-module.ts
 const INDEX_MODULE_FILE_PATTERN = /^index\.(?:[cm]?[jt]sx?|mjs)$/;
 const BINDING_IMPORT_DECLARATION_PATTERN = /^\s*import\s+(type\s+)?(?!["'])([^;]*?)\s+from\s+["']([^"']+)["']\s*;?\s*(?:(?:\/\/[^\n]*)?\s*)/gm;
@@ -13972,29 +14004,10 @@ const astMentionsSuspense = (programNode) => {
 };
 //#endregion
 //#region src/plugin/utils/find-ancestor-suspense-layout.ts
-const LAYOUT_FILE_NAMES = [
-	"layout.tsx",
-	"layout.jsx",
-	"layout.ts",
-	"layout.js"
-];
-const hasAncestorSuspenseLayout = (pageFilename) => {
-	const normalizedPage = pageFilename.replaceAll("\\", "/");
-	let currentDirectory = path.dirname(normalizedPage);
-	for (let level = 0; level < 30; level++) {
-		for (const layoutFileName of LAYOUT_FILE_NAMES) {
-			const layoutPath = path.join(currentDirectory, layoutFileName);
-			if (layoutPath.replaceAll("\\", "/") === normalizedPage) continue;
-			const programRoot = parseSourceFile(layoutPath);
-			if (programRoot && astMentionsSuspense(programRoot)) return true;
-		}
-		if (path.basename(currentDirectory) === "app") break;
-		const parentDirectory = path.dirname(currentDirectory);
-		if (parentDirectory === currentDirectory) break;
-		currentDirectory = parentDirectory;
-	}
-	return false;
-};
+const hasAncestorSuspenseLayout = (pageFilename) => hasAncestorLayoutMatching(pageFilename, (layoutPath) => {
+	const programRoot = parseSourceFile(layoutPath);
+	return Boolean(programRoot && astMentionsSuspense(programRoot));
+});
 //#endregion
 //#region src/plugin/rules/nextjs/nextjs-no-use-search-params-without-suspense.ts
 const astContainsUseSearchParams = (root) => {
@@ -24344,6 +24357,21 @@ const noZIndex9999 = defineRule({
 	})
 });
 //#endregion
+//#region src/plugin/utils/is-framework-route-or-special-filename.ts
+const sourceFileExtensionGroup = NEXTJS_SOURCE_FILE_EXTENSION_GROUP;
+const FRAMEWORK_ROUTE_FILE_PATTERNS = [
+	new RegExp(`^(page|layout|loading|error|not-found|template|default|global-error|route|_app|_document|_error)\\.${sourceFileExtensionGroup}$`),
+	new RegExp(`^(_layout|\\+html|\\+not-found|\\+native-intent)\\.${sourceFileExtensionGroup}$`),
+	new RegExp(`(?:^__root|\\.lazy)\\.${sourceFileExtensionGroup}$`),
+	new RegExp(`^(root|entry\\.client|entry\\.server)\\.${sourceFileExtensionGroup}$`)
+];
+const isFrameworkRouteOrSpecialFilename = (rawFilename) => {
+	if (!rawFilename) return false;
+	if (isNextjsMetadataImageRouteFilename(rawFilename)) return true;
+	const basename = path.basename(rawFilename);
+	return FRAMEWORK_ROUTE_FILE_PATTERNS.some((pattern) => pattern.test(basename));
+};
+//#endregion
 //#region src/plugin/rules/react-builtins/only-export-components-tables.ts
 const NOT_REACT_COMPONENT_EXPRESSION_TYPES = new Set([
 	"ArrayExpression",
@@ -24395,32 +24423,6 @@ const ENTRY_POINT_BASENAMES = new Set([
 	"client.jsx",
 	"server.tsx",
 	"server.jsx",
-	"page.tsx",
-	"page.jsx",
-	"layout.tsx",
-	"layout.jsx",
-	"loading.tsx",
-	"loading.jsx",
-	"error.tsx",
-	"error.jsx",
-	"not-found.tsx",
-	"not-found.jsx",
-	"template.tsx",
-	"template.jsx",
-	"default.tsx",
-	"default.jsx",
-	"global-error.tsx",
-	"global-error.jsx",
-	"route.tsx",
-	"route.jsx",
-	"_layout.tsx",
-	"_layout.jsx",
-	"_app.tsx",
-	"_app.jsx",
-	"_document.tsx",
-	"_document.jsx",
-	"_error.tsx",
-	"_error.jsx",
 	"app.tsx",
 	"app.jsx",
 	"App.tsx",
@@ -24713,6 +24715,7 @@ const isFileNameAllowed = (filename, checkJS) => {
 	if (filename.includes(".test.") || filename.includes(".spec.") || filename.includes(".cy.") || filename.includes(".stories.")) return false;
 	for (const segment of NON_FAST_REFRESH_PATH_SEGMENTS) if (filename.includes(segment)) return false;
 	if (isEntryPointFile(filename)) return false;
+	if (isFrameworkRouteOrSpecialFilename(filename)) return false;
 	if (isAssetOrUtilityFile(filename)) return false;
 	if (filename.endsWith(".tsx") || filename.endsWith(".jsx")) return true;
 	if (checkJS && filename.endsWith(".js")) return true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.5.1-dev.1ca6f0e",
+  "version": "0.5.1-dev.22268f7",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",
@@ -50,7 +50,7 @@
     "@types/node": "^25.6.0"
   },
   "engines": {
-    "node": "^20.19.0 || >=22.12.0"
+    "node": "^20.19.0 || >=22.13.0"
   },
   "scripts": {
     "dev": "vp pack --watch",