oxlint-plugin-react-doctor 0.4.1-dev.e181ac1 → 0.4.2-dev.727894a

package/dist/index.js

@@ -14445,6 +14445,14 @@ const isSynchronous = (node, within) => {
 	if (isNodeOfType(node, "AwaitExpression") || isNodeOfType(node, "UnaryExpression") && node.operator === "void" || isNodeOfType(node, "FunctionDeclaration") || isNodeOfType(node, "FunctionExpression") || isNodeOfType(node, "ArrowFunctionExpression")) return false;
 	return isSynchronous(node.parent, within);
 };
+const resolveToFunction = (ref) => {
+	const definitionNode = ref.resolved?.defs[0]?.node;
+	if (!definitionNode) return null;
+	if (isFunctionLike$2(definitionNode)) return definitionNode;
+	if (isNodeOfType(definitionNode, "VariableDeclarator") && isFunctionLike$2(definitionNode.init)) return definitionNode.init;
+	return null;
+};
+const resolvesToAsyncFunction = (ref) => Boolean(resolveToFunction(ref)?.async);
 const isEventualCallTo = (analysis, ref, predicate) => {
 	const callExprRefs = [];
 	ascend(analysis, ref, (upRef) => {
@@ -14571,12 +14579,8 @@ const getEffectFn = (analysis, node) => {
 	if (!fn) return null;
 	if (isNodeOfType(fn, "ArrowFunctionExpression") || isNodeOfType(fn, "FunctionExpression")) return fn;
 	if (isNodeOfType(fn, "Identifier")) {
-		const definitionNode = getRef(analysis, fn)?.resolved?.defs[0]?.node;
-		if (definitionNode && isFunctionLike$2(definitionNode)) return definitionNode;
-		if (definitionNode && isNodeOfType(definitionNode, "VariableDeclarator")) {
-			const initializer = definitionNode.init;
-			if (isNodeOfType(initializer, "ArrowFunctionExpression") || isNodeOfType(initializer, "FunctionExpression")) return initializer;
-		}
+		const ref = getRef(analysis, fn);
+		return ref ? resolveToFunction(ref) : null;
 	}
 	return null;
 };
@@ -14657,6 +14661,7 @@ const isRefCurrent = (ref) => {
 	return parent.property.name === "current";
 };
 const isStateSetterCall = (analysis, ref) => isEventualCallTo(analysis, ref, (innerRef) => isStateSetter(analysis, innerRef));
+const isSyncStateSetterCall = (analysis, ref, effectFn) => isStateSetterCall(analysis, ref) && isSynchronous(ref.identifier, effectFn) && !resolvesToAsyncFunction(ref);
 const isPropCall = (analysis, ref) => isEventualCallTo(analysis, ref, (innerRef) => isPropAlias(analysis, innerRef));
 const isRefCall = (analysis, ref) => isEventualCallTo(analysis, ref, (innerRef) => isRefCurrent(innerRef) || isRef(analysis, innerRef));
 const getUseStateDecl = (analysis, ref) => {
@@ -14668,12 +14673,8 @@ const isCleanupReturnArgument = (analysis, node) => {
 	if (isFunctionLike$2(node)) return true;
 	if (isNodeOfType(node, "MemberExpression")) return true;
 	if (isNodeOfType(node, "Identifier")) {
-		const definitionNode = getRef(analysis, node)?.resolved?.defs[0]?.node;
-		if (definitionNode && isFunctionLike$2(definitionNode)) return true;
-		if (definitionNode && isNodeOfType(definitionNode, "VariableDeclarator")) {
-			const initializer = definitionNode.init;
-			return isFunctionLike$2(initializer);
-		}
+		const ref = getRef(analysis, node);
+		if (ref && resolveToFunction(ref)) return true;
 	}
 	if (isNodeOfType(node, "ConditionalExpression")) return isCleanupReturnArgument(analysis, node.consequent) || isCleanupReturnArgument(analysis, node.alternate);
 	return false;
@@ -14723,8 +14724,7 @@ const noAdjustStateOnPropChange = defineRule({
 		if (!effectFn) return;
 		if (!depsRefs.flatMap((ref) => getUpstreamRefs(analysis, ref)).some((ref) => isProp(analysis, ref))) return;
 		for (const ref of effectFnRefs) {
-			if (!isStateSetterCall(analysis, ref)) continue;
-			if (!isSynchronous(ref.identifier, effectFn)) continue;
+			if (!isSyncStateSetterCall(analysis, ref, effectFn)) continue;
 			const callExpr = getCallExpr(ref);
 			if (!callExpr) continue;
 			if (getArgsUpstreamRefs(analysis, ref).some((argRef) => isProp(analysis, argRef))) continue;
@@ -15631,8 +15631,7 @@ const noChainStateUpdates = defineRule({
 		if (!effectFn) return;
 		if (!depsRefs.flatMap((ref) => getUpstreamRefs(analysis, ref)).some((ref) => isState(analysis, ref))) return;
 		for (const ref of effectFnRefs) {
-			if (!isStateSetterCall(analysis, ref)) continue;
-			if (!isSynchronous(ref.identifier, effectFn)) continue;
+			if (!isSyncStateSetterCall(analysis, ref, effectFn)) continue;
 			const callExpr = getCallExpr(ref);
 			if (!callExpr) continue;
 			if (getArgsUpstreamRefs(analysis, ref).some((argRef) => isState(analysis, argRef))) continue;
@@ -16250,8 +16249,7 @@ const noDerivedState = defineRule({
 		const effectFn = getEffectFn(analysis, node);
 		if (!effectFn) return;
 		for (const ref of effectFnRefs) {
-			if (!isStateSetterCall(analysis, ref)) continue;
-			if (!isSynchronous(ref.identifier, effectFn)) continue;
+			if (!isSyncStateSetterCall(analysis, ref, effectFn)) continue;
 			const callExpr = getCallExpr(ref);
 			if (!callExpr) continue;
 			const stateName = getStateNameForUseStateDecl(getUseStateDecl(analysis, ref)) ?? "<state>";
@@ -18640,8 +18638,7 @@ const noInitializeState = defineRule({
 		if (!effectFn) return;
 		if (!(depsRefs.filter((ref) => !isStateSetter(analysis, ref)).length === 0)) return;
 		for (const ref of effectFnRefs) {
-			if (!isStateSetterCall(analysis, ref)) continue;
-			if (!isSynchronous(ref.identifier, effectFn)) continue;
+			if (!isSyncStateSetterCall(analysis, ref, effectFn)) continue;
 			const callExpr = getCallExpr(ref);
 			if (!callExpr || !isNodeOfType(callExpr, "CallExpression")) continue;
 			const useStateDecl = getUseStateDecl(analysis, ref);
@@ -27868,6 +27865,7 @@ const rnListCallbackPerRow = defineRule({
 	tags: ["test-noise"],
 	requires: ["react-native"],
 	severity: "warn",
+	disabledBy: ["react-compiler"],
 	recommendation: "Move the handler out with useCallback at list scope and pass the row id as a prop. Then memo() rows skip redrawing when their data has not changed.",
 	create: (context) => {
 		const inspect = (node) => {
@@ -28304,6 +28302,7 @@ const rnNoInlineFlatlistRenderitem = defineRule({
 	tags: ["test-noise"],
 	requires: ["react-native"],
 	severity: "warn",
+	disabledBy: ["react-compiler"],
 	recommendation: "Move renderItem to a named function or wrap it in useCallback so it is not rebuilt every time the screen redraws.",
 	create: (context) => ({ JSXAttribute(node) {
 		if (!isNodeOfType(node.name, "JSXIdentifier") || node.name.name !== "renderItem") return;
@@ -28328,6 +28327,7 @@ const rnNoInlineObjectInListItem = defineRule({
 	tags: ["test-noise"],
 	requires: ["react-native"],
 	severity: "warn",
+	disabledBy: ["react-compiler"],
 	recommendation: "Move style and object props out of renderItem (StyleSheet.create, useMemo at list scope, or pass primitives) so memo() rows stop redrawing when their data has not changed.",
 	create: (context) => {
 		const renderPropStack = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.4.1-dev.e181ac1",
+  "version": "0.4.2-dev.727894a",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",