oxlint-plugin-react-doctor 0.2.4 → 0.2.6

package/dist/index.d.ts

@@ -529,26 +529,6 @@ declare const REACT_DOCTOR_RULES: readonly [{
     readonly recommendation?: string;
     readonly create: (context: RuleContext) => RuleVisitors;
   };
-}, {
-  readonly key: "react-doctor/design-no-bold-heading";
-  readonly id: "design-no-bold-heading";
-  readonly source: "react-doctor";
-  readonly originallyExternal: false;
-  readonly framework: "global";
-  readonly category: "Architecture";
-  readonly severity: "warn";
-  readonly rule: {
-    readonly framework: "global";
-    readonly category: "Architecture";
-    readonly id: string;
-    readonly severity: RuleSeverity;
-    readonly requires?: ReadonlyArray<string>;
-    readonly disabledBy?: ReadonlyArray<string>;
-    readonly tags?: ReadonlyArray<string>;
-    readonly defaultEnabled?: boolean;
-    readonly recommendation?: string;
-    readonly create: (context: RuleContext) => RuleVisitors;
-  };
 }, {
   readonly key: "react-doctor/design-no-em-dash-in-jsx-text";
   readonly id: "design-no-em-dash-in-jsx-text";
@@ -6315,26 +6295,6 @@ declare const RULES: readonly [{
     readonly recommendation?: string;
     readonly create: (context: RuleContext) => RuleVisitors;
   };
-}, {
-  readonly key: "react-doctor/design-no-bold-heading";
-  readonly id: "design-no-bold-heading";
-  readonly source: "react-doctor";
-  readonly originallyExternal: false;
-  readonly framework: "global";
-  readonly category: "Architecture";
-  readonly severity: "warn";
-  readonly rule: {
-    readonly framework: "global";
-    readonly category: "Architecture";
-    readonly id: string;
-    readonly severity: RuleSeverity;
-    readonly requires?: ReadonlyArray<string>;
-    readonly disabledBy?: ReadonlyArray<string>;
-    readonly tags?: ReadonlyArray<string>;
-    readonly defaultEnabled?: boolean;
-    readonly recommendation?: string;
-    readonly create: (context: RuleContext) => RuleVisitors;
-  };
 }, {
   readonly key: "react-doctor/design-no-em-dash-in-jsx-text";
   readonly id: "design-no-em-dash-in-jsx-text";

package/dist/index.js

@@ -943,6 +943,15 @@ const anchorHasContent = defineRule({
 	} })
 });
 //#endregion
+//#region src/plugin/utils/get-static-template-literal-value.ts
+const getStaticTemplateLiteralValue = (templateLiteral) => {
+	const expressions = templateLiteral.expressions ?? [];
+	const quasis = templateLiteral.quasis ?? [];
+	if (expressions.length !== 0 || quasis.length !== 1) return null;
+	const value = quasis[0]?.value;
+	return value?.cooked ?? value?.raw ?? null;
+};
+//#endregion
 //#region src/plugin/rules/a11y/anchor-is-valid.ts
 const MESSAGE_MISSING_HREF = "`<a>` element is missing an `href` — anchors without `href` aren't keyboard-focusable; use `<button>` for actions.";
 const MESSAGE_INCORRECT_HREF = "`<a>` element has invalid `href` (`#`, `javascript:`, or empty) — provide a real destination.";
@@ -971,8 +980,8 @@ const checkValueIsEmptyOrInvalid = (value, validHrefs) => {
 			if (typeof expression.value === "string") return isInvalidHref(expression.value, validHrefs);
 		}
 		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length > 0) return false;
-			return isInvalidHref(expression.quasis[0]?.value.cooked ?? "", validHrefs);
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			return staticValue === null ? false : isInvalidHref(staticValue, validHrefs);
 		}
 	}
 	if (isNodeOfType(value, "JSXFragment")) return true;
@@ -1303,9 +1312,10 @@ const parseJsxValue = (value) => {
 			}
 		}
 		if (isNodeOfType(expression, "UnaryExpression") && expression.operator === "-" && isNodeOfType(expression.argument, "Literal") && typeof expression.argument.value === "number") return -expression.argument.value;
-		if (isNodeOfType(expression, "TemplateLiteral") && expression.expressions.length === 0 && expression.quasis.length === 1) {
-			const cooked = expression.quasis[0].value.cooked ?? "";
-			const parsed = Number(cooked);
+		if (isNodeOfType(expression, "TemplateLiteral")) {
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			if (staticValue === null) return null;
+			const parsed = Number(staticValue);
 			return Number.isFinite(parsed) ? parsed : null;
 		}
 		if (isNodeOfType(expression, "ConditionalExpression")) {
@@ -1670,8 +1680,8 @@ const expressionToBoolean = (expression) => {
 		return null;
 	}
 	if (isNodeOfType(expression, "TemplateLiteral")) {
-		if (expression.expressions.length === 0 && expression.quasis.length === 1) return (expression.quasis[0]?.value.cooked ?? "").length > 0;
-		return null;
+		const staticValue = getStaticTemplateLiteralValue(expression);
+		return staticValue === null ? null : staticValue.length > 0;
 	}
 	if (isNodeOfType(expression, "UnaryExpression") && expression.operator === "!") {
 		const inner = expressionToBoolean(expression.argument);
@@ -1702,10 +1712,7 @@ const parseAriaValueAsString = (value, booleanAsString) => {
 			if (typeof expression.value === "boolean") return booleanAsString ? String(expression.value) : null;
 			return null;
 		}
-		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length === 0 && expression.quasis.length === 1) return (expression.quasis[0]?.value.cooked ?? "").toLowerCase();
-			return null;
-		}
+		if (isNodeOfType(expression, "TemplateLiteral")) return getStaticTemplateLiteralValue(expression)?.toLowerCase() ?? null;
 		if (booleanAsString && isNodeOfType(expression, "UnaryExpression") && expression.operator === "!") {
 			const inner = expressionToBoolean(expression.argument);
 			if (inner === null) return null;
@@ -1718,7 +1725,7 @@ const isMultiQuasiTemplate = (value) => {
 	if (!isNodeOfType(value, "JSXExpressionContainer")) return false;
 	const expression = value.expression;
 	if (!isNodeOfType(expression, "TemplateLiteral")) return false;
-	return expression.expressions.length > 0;
+	return (expression.expressions ?? []).length > 0;
 };
 const isValidValueForType = (propType, value) => {
 	if (!isTargetLiteralValue(value)) return true;
@@ -3102,9 +3109,9 @@ const isValidTypeValue = (rawValue, settings) => {
 };
 const isProvenValidExpression = (expression, settings) => {
 	if (isNodeOfType(expression, "Literal") && typeof expression.value === "string") return isValidTypeValue(expression.value, settings);
-	if (isNodeOfType(expression, "TemplateLiteral") && expression.expressions.length === 0 && expression.quasis.length === 1) {
-		const cookedValue = expression.quasis[0].value.cooked;
-		if (typeof cookedValue === "string") return isValidTypeValue(cookedValue, settings);
+	if (isNodeOfType(expression, "TemplateLiteral")) {
+		const staticValue = getStaticTemplateLiteralValue(expression);
+		if (staticValue !== null) return isValidTypeValue(staticValue, settings);
 	}
 	if (isNodeOfType(expression, "ConditionalExpression")) return isProvenValidExpression(expression.consequent, settings) && isProvenValidExpression(expression.alternate, settings);
 	return false;
@@ -3520,19 +3527,6 @@ const controlHasAssociatedLabel = defineRule({
 	}
 });
 const LONG_TRANSITION_DURATION_THRESHOLD_MS = 1e3;
-const HEADING_TAG_NAMES = new Set([
-	"h1",
-	"h2",
-	"h3",
-	"h4",
-	"h5",
-	"h6"
-]);
-const HEAVY_HEADING_TAILWIND_WEIGHTS = new Set([
-	"font-bold",
-	"font-extrabold",
-	"font-black"
-]);
 const VAGUE_BUTTON_LABELS = new Set([
 	"continue",
 	"submit",
@@ -3602,85 +3596,6 @@ const getOpeningElementTagName = (openingElement) => {
 	return null;
 };
 //#endregion
-//#region src/plugin/rules/react-ui/utils/get-class-name-literal.ts
-const getClassNameLiteral = (classAttribute) => {
-	if (!isNodeOfType(classAttribute, "JSXAttribute")) return null;
-	if (!classAttribute.value) return null;
-	if (isNodeOfType(classAttribute.value, "Literal") && typeof classAttribute.value.value === "string") return classAttribute.value.value;
-	if (isNodeOfType(classAttribute.value, "JSXExpressionContainer")) {
-		const expression = classAttribute.value.expression;
-		if (isNodeOfType(expression, "Literal") && typeof expression.value === "string") return expression.value;
-		if (isNodeOfType(expression, "TemplateLiteral") && expression.quasis?.length === 1) return expression.quasis[0].value?.raw ?? null;
-	}
-	return null;
-};
-//#endregion
-//#region src/plugin/rules/react-ui/no-bold-heading.ts
-const getInlineStyleObjectExpression = (jsxAttribute) => {
-	if (!isNodeOfType(jsxAttribute, "JSXAttribute")) return null;
-	if (!isNodeOfType(jsxAttribute.name, "JSXIdentifier") || jsxAttribute.name.name !== "style") return null;
-	if (!isNodeOfType(jsxAttribute.value, "JSXExpressionContainer")) return null;
-	const expression = jsxAttribute.value.expression;
-	if (!isNodeOfType(expression, "ObjectExpression")) return null;
-	return expression;
-};
-const getStylePropertyKeyName = (objectProperty) => {
-	if (!isNodeOfType(objectProperty, "Property")) return null;
-	if (isNodeOfType(objectProperty.key, "Identifier")) return objectProperty.key.name;
-	if (isNodeOfType(objectProperty.key, "Literal") && typeof objectProperty.key.value === "string") return objectProperty.key.value;
-	return null;
-};
-const getStylePropertyNumericValue = (objectProperty) => {
-	if (!isNodeOfType(objectProperty, "Property")) return null;
-	const valueNode = objectProperty.value;
-	if (!valueNode) return null;
-	if (isNodeOfType(valueNode, "Literal") && typeof valueNode.value === "number") return valueNode.value;
-	if (isNodeOfType(valueNode, "Literal") && typeof valueNode.value === "string") {
-		const parsed = parseFloat(valueNode.value);
-		return Number.isFinite(parsed) ? parsed : null;
-	}
-	return null;
-};
-const noBoldHeading = defineRule({
-	id: "design-no-bold-heading",
-	tags: ["design", "test-noise"],
-	severity: "warn",
-	category: "Architecture",
-	recommendation: "Use `font-semibold` (600) or `font-medium` (500) on headings — 700+ crushes letter counter shapes at display sizes",
-	create: (context) => ({ JSXOpeningElement(openingNode) {
-		const tagName = getOpeningElementTagName(openingNode);
-		if (!tagName || !HEADING_TAG_NAMES.has(tagName)) return;
-		const classAttribute = findJsxAttribute(openingNode.attributes ?? [], "className");
-		if (classAttribute) {
-			const classNameLiteral = getClassNameLiteral(classAttribute);
-			if (classNameLiteral) {
-				for (const tailwindWeightToken of HEAVY_HEADING_TAILWIND_WEIGHTS) if (new RegExp(`(?:^|\\s)${tailwindWeightToken}(?:$|\\s|:)`).test(classNameLiteral)) {
-					context.report({
-						node: classAttribute,
-						message: `${tailwindWeightToken} on <${tagName}> crushes counter shapes at display sizes — use font-semibold (600) or font-medium (500)`
-					});
-					return;
-				}
-			}
-		}
-		const styleAttribute = findJsxAttribute(openingNode.attributes ?? [], "style");
-		if (!styleAttribute) return;
-		const styleObject = getInlineStyleObjectExpression(styleAttribute);
-		if (!styleObject) return;
-		for (const objectProperty of styleObject.properties ?? []) {
-			if (getStylePropertyKeyName(objectProperty) !== "fontWeight") continue;
-			const numericWeight = getStylePropertyNumericValue(objectProperty);
-			if (numericWeight !== null && numericWeight >= 700) {
-				context.report({
-					node: objectProperty,
-					message: `fontWeight: ${numericWeight} on <${tagName}> crushes counter shapes at display sizes — use 500 or 600`
-				});
-				return;
-			}
-		}
-	} })
-});
-//#endregion
 //#region src/plugin/rules/react-ui/utils/is-inside-excluded-typography-ancestor.ts
 const isInsideExcludedTypographyAncestor = (jsxTextNode) => {
 	let cursor = jsxTextNode.parent;
@@ -3714,6 +3629,19 @@ const noEmDashInJsxText = defineRule({
 	} })
 });
 //#endregion
+//#region src/plugin/rules/react-ui/utils/get-class-name-literal.ts
+const getClassNameLiteral = (classAttribute) => {
+	if (!isNodeOfType(classAttribute, "JSXAttribute")) return null;
+	if (!classAttribute.value) return null;
+	if (isNodeOfType(classAttribute.value, "Literal") && typeof classAttribute.value.value === "string") return classAttribute.value.value;
+	if (isNodeOfType(classAttribute.value, "JSXExpressionContainer")) {
+		const expression = classAttribute.value.expression;
+		if (isNodeOfType(expression, "Literal") && typeof expression.value === "string") return expression.value;
+		if (isNodeOfType(expression, "TemplateLiteral") && expression.quasis?.length === 1) return expression.quasis[0].value?.raw ?? null;
+	}
+	return null;
+};
+//#endregion
 //#region src/plugin/rules/react-ui/utils/collect-axis-shorthand-pairs.ts
 const collectAxisShorthandPairs = (classNameValue, horizontalPattern, verticalPattern) => {
 	const horizontalValues = /* @__PURE__ */ new Set();
@@ -3845,10 +3773,10 @@ const collectJsxLabelText = (jsxElementNode) => {
 				collectedFragments.push(expression.value);
 				continue;
 			}
-			if (isNodeOfType(expression, "TemplateLiteral") && expression.quasis?.length === 1) {
-				const rawTemplate = expression.quasis[0].value?.raw;
-				if (typeof rawTemplate === "string" && expression.expressions.length === 0) {
-					collectedFragments.push(rawTemplate);
+			if (isNodeOfType(expression, "TemplateLiteral")) {
+				const staticValue = getStaticTemplateLiteralValue(expression);
+				if (staticValue !== null) {
+					collectedFragments.push(staticValue);
 					continue;
 				}
 			}
@@ -5031,7 +4959,7 @@ const symbolHasStableHookOrigin = (symbol) => {
 	const initializer = unwrapExpression(initializerRaw);
 	if (symbol.kind === "const") {
 		if (isNodeOfType(initializer, "Literal") && (initializer.value === null || typeof initializer.value === "number" || typeof initializer.value === "string" || typeof initializer.value === "boolean")) return true;
-		if (isNodeOfType(initializer, "TemplateLiteral") && initializer.expressions.length === 0) return true;
+		if (isNodeOfType(initializer, "TemplateLiteral") && getStaticTemplateLiteralValue(initializer) !== null) return true;
 	}
 	if (!isNodeOfType(initializer, "CallExpression")) return false;
 	const initializerHookName = getHookName(initializer.callee);
@@ -5251,7 +5179,7 @@ const isOutsideAllFunctions = (symbol) => {
 	}
 	return true;
 };
-const isLiteralOrEmptyTemplate = (node) => isNodeOfType(node, "Literal") || isNodeOfType(node, "TemplateLiteral") && node.expressions.length === 0;
+const isLiteralOrEmptyTemplate = (node) => isNodeOfType(node, "Literal") || isNodeOfType(node, "TemplateLiteral") && getStaticTemplateLiteralValue(node) !== null;
 const isNonStringLiteral = (node) => isNodeOfType(node, "Literal") && typeof node.value !== "string";
 const isMatchingDepOrPrefix = (declaredKey, captureKey) => captureKey === declaredKey || captureKey.startsWith(`${declaredKey}.`);
 const hasBroaderDeclaredDependency = (declaredKey, declaredKeys) => {
@@ -6169,11 +6097,8 @@ const evaluateLang = (attributeValue) => {
 			return "ok";
 		}
 		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length === 0 && expression.quasis.length === 1) {
-				const cooked = expression.quasis[0].value.cooked;
-				return cooked && cooked.length > 0 ? "ok" : "empty";
-			}
-			return "ok";
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			return staticValue === null ? "ok" : staticValue.length > 0 ? "ok" : "empty";
 		}
 		return "ok";
 	}
@@ -6235,11 +6160,8 @@ const evaluateTitleValue = (value) => {
 			return "dynamic-ok";
 		}
 		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length === 0 && expression.quasis.length === 1) {
-				const cooked = expression.quasis[0].value.cooked;
-				return cooked && cooked.length > 0 ? "ok" : "empty";
-			}
-			return "dynamic-ok";
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			return staticValue === null ? "dynamic-ok" : staticValue.length > 0 ? "ok" : "empty";
 		}
 		return "dynamic-ok";
 	}
@@ -7513,10 +7435,9 @@ const checkExpressionContainer = (container, parentIsAttribute, context, setting
 		return;
 	}
 	if (isNodeOfType(expression, "TemplateLiteral") && allowed === "never") {
-		if (expression.expressions.length !== 0 || expression.quasis.length !== 1) return;
-		const quasi = expression.quasis[0];
-		const rawSource = quasi.value.raw ?? "";
-		const cooked = quasi.value.cooked ?? "";
+		const cooked = getStaticTemplateLiteralValue(expression);
+		if (cooked === null) return;
+		const rawSource = expression.quasis?.[0]?.value.raw ?? "";
 		if (!parentIsAttribute && containsAnyQuote(cooked)) return;
 		if (isAllowedStringLikeInContainer(rawSource, container, parentIsAttribute)) return;
 		context.report({
@@ -7883,8 +7804,7 @@ const resolveSettings$31 = (settings) => {
 	const ruleSettings = typeof reactDoctor === "object" && reactDoctor !== null ? reactDoctor.jsxKey ?? {} : {};
 	return {
 		checkKeyMustBeforeSpread: ruleSettings.checkKeyMustBeforeSpread ?? true,
-		warnOnDuplicates: ruleSettings.warnOnDuplicates ?? false,
-		checkFragmentShorthand: ruleSettings.checkFragmentShorthand ?? true
+		warnOnDuplicates: ruleSettings.warnOnDuplicates ?? false
 	};
 };
 const findEnclosingIteratorContext = (jsxNode) => {
@@ -7999,10 +7919,10 @@ const getKeyAttributeValueString = (openingElement) => {
 				};
 				return null;
 			}
-			if (isNodeOfType(expression, "TemplateLiteral") && expression.expressions.length === 0 && expression.quasis.length === 1) {
-				const cookedValue = expression.quasis[0].value.cooked;
-				if (typeof cookedValue === "string") return {
-					keyValue: cookedValue,
+			if (isNodeOfType(expression, "TemplateLiteral")) {
+				const staticValue = getStaticTemplateLiteralValue(expression);
+				if (staticValue !== null) return {
+					keyValue: staticValue,
 					node: attribute
 				};
 			}
@@ -8042,16 +7962,6 @@ const jsxKey = defineRule({
 					message: enclosingContext.kind === "array" ? MISSING_KEY_ARRAY : MISSING_KEY_ITERATOR
 				});
 			},
-			JSXFragment(node) {
-				if (!settings.checkFragmentShorthand) return;
-				const enclosingContext = findEnclosingIteratorContext(node);
-				if (!enclosingContext) return;
-				if (isWithinChildrenToArray(node)) return;
-				context.report({
-					node,
-					message: enclosingContext.kind === "array" ? MISSING_KEY_ARRAY : MISSING_KEY_ITERATOR
-				});
-			},
 			ArrayExpression(node) {
 				if (!settings.warnOnDuplicates) return;
 				const seenKeys = /* @__PURE__ */ new Set();
@@ -13054,7 +12964,7 @@ const isFalseAttributeValue = (value) => {
 			if (typeof expression.value === "string") return expression.value === "false";
 			return false;
 		}
-		if (isNodeOfType(expression, "TemplateLiteral")) return expression.expressions.length === 0 && expression.quasis.length === 1 && expression.quasis[0].value.cooked === "false";
+		if (isNodeOfType(expression, "TemplateLiteral")) return getStaticTemplateLiteralValue(expression) === "false";
 	}
 	return false;
 };
@@ -24078,7 +23988,7 @@ const isPlatformSelectCallee = (callee) => {
 const isStringLiteralEqualTo = (node, expected) => {
 	if (!node) return false;
 	if (isNodeOfType(node, "Literal") && node.value === expected) return true;
-	if (isNodeOfType(node, "TemplateLiteral") && node.quasis.length === 1) return node.quasis[0]?.value?.cooked === expected;
+	if (isNodeOfType(node, "TemplateLiteral")) return getStaticTemplateLiteralValue(node) === expected;
 	return false;
 };
 const readStaticPropertyKeyName = (property) => {
@@ -29892,20 +29802,6 @@ const reactDoctorRules = [
 			category: "Accessibility"
 		}
 	},
-	{
-		key: "react-doctor/design-no-bold-heading",
-		id: "design-no-bold-heading",
-		source: "react-doctor",
-		originallyExternal: false,
-		framework: "global",
-		category: "Architecture",
-		severity: "warn",
-		rule: {
-			...noBoldHeading,
-			framework: "global",
-			category: "Architecture"
-		}
-	},
 	{
 		key: "react-doctor/design-no-em-dash-in-jsx-text",
 		id: "design-no-em-dash-in-jsx-text",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.2.4",
+  "version": "0.2.6",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",
@@ -50,7 +50,7 @@
     "oxc-parser": "^0.132.0"
   },
   "engines": {
-    "node": ">=22.13.0"
+    "node": "^20.19.0 || >=22.12.0"
   },
   "scripts": {
     "dev": "vp pack --watch",