oxlint-plugin-react-doctor 0.2.4 → 0.2.5

package/dist/index.js

@@ -943,6 +943,15 @@ const anchorHasContent = defineRule({
 	} })
 });
 //#endregion
+//#region src/plugin/utils/get-static-template-literal-value.ts
+const getStaticTemplateLiteralValue = (templateLiteral) => {
+	const expressions = templateLiteral.expressions ?? [];
+	const quasis = templateLiteral.quasis ?? [];
+	if (expressions.length !== 0 || quasis.length !== 1) return null;
+	const value = quasis[0]?.value;
+	return value?.cooked ?? value?.raw ?? null;
+};
+//#endregion
 //#region src/plugin/rules/a11y/anchor-is-valid.ts
 const MESSAGE_MISSING_HREF = "`<a>` element is missing an `href` — anchors without `href` aren't keyboard-focusable; use `<button>` for actions.";
 const MESSAGE_INCORRECT_HREF = "`<a>` element has invalid `href` (`#`, `javascript:`, or empty) — provide a real destination.";
@@ -971,8 +980,8 @@ const checkValueIsEmptyOrInvalid = (value, validHrefs) => {
 			if (typeof expression.value === "string") return isInvalidHref(expression.value, validHrefs);
 		}
 		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length > 0) return false;
-			return isInvalidHref(expression.quasis[0]?.value.cooked ?? "", validHrefs);
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			return staticValue === null ? false : isInvalidHref(staticValue, validHrefs);
 		}
 	}
 	if (isNodeOfType(value, "JSXFragment")) return true;
@@ -1303,9 +1312,10 @@ const parseJsxValue = (value) => {
 			}
 		}
 		if (isNodeOfType(expression, "UnaryExpression") && expression.operator === "-" && isNodeOfType(expression.argument, "Literal") && typeof expression.argument.value === "number") return -expression.argument.value;
-		if (isNodeOfType(expression, "TemplateLiteral") && expression.expressions.length === 0 && expression.quasis.length === 1) {
-			const cooked = expression.quasis[0].value.cooked ?? "";
-			const parsed = Number(cooked);
+		if (isNodeOfType(expression, "TemplateLiteral")) {
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			if (staticValue === null) return null;
+			const parsed = Number(staticValue);
 			return Number.isFinite(parsed) ? parsed : null;
 		}
 		if (isNodeOfType(expression, "ConditionalExpression")) {
@@ -1670,8 +1680,8 @@ const expressionToBoolean = (expression) => {
 		return null;
 	}
 	if (isNodeOfType(expression, "TemplateLiteral")) {
-		if (expression.expressions.length === 0 && expression.quasis.length === 1) return (expression.quasis[0]?.value.cooked ?? "").length > 0;
-		return null;
+		const staticValue = getStaticTemplateLiteralValue(expression);
+		return staticValue === null ? null : staticValue.length > 0;
 	}
 	if (isNodeOfType(expression, "UnaryExpression") && expression.operator === "!") {
 		const inner = expressionToBoolean(expression.argument);
@@ -1702,10 +1712,7 @@ const parseAriaValueAsString = (value, booleanAsString) => {
 			if (typeof expression.value === "boolean") return booleanAsString ? String(expression.value) : null;
 			return null;
 		}
-		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length === 0 && expression.quasis.length === 1) return (expression.quasis[0]?.value.cooked ?? "").toLowerCase();
-			return null;
-		}
+		if (isNodeOfType(expression, "TemplateLiteral")) return getStaticTemplateLiteralValue(expression)?.toLowerCase() ?? null;
 		if (booleanAsString && isNodeOfType(expression, "UnaryExpression") && expression.operator === "!") {
 			const inner = expressionToBoolean(expression.argument);
 			if (inner === null) return null;
@@ -1718,7 +1725,7 @@ const isMultiQuasiTemplate = (value) => {
 	if (!isNodeOfType(value, "JSXExpressionContainer")) return false;
 	const expression = value.expression;
 	if (!isNodeOfType(expression, "TemplateLiteral")) return false;
-	return expression.expressions.length > 0;
+	return (expression.expressions ?? []).length > 0;
 };
 const isValidValueForType = (propType, value) => {
 	if (!isTargetLiteralValue(value)) return true;
@@ -3102,9 +3109,9 @@ const isValidTypeValue = (rawValue, settings) => {
 };
 const isProvenValidExpression = (expression, settings) => {
 	if (isNodeOfType(expression, "Literal") && typeof expression.value === "string") return isValidTypeValue(expression.value, settings);
-	if (isNodeOfType(expression, "TemplateLiteral") && expression.expressions.length === 0 && expression.quasis.length === 1) {
-		const cookedValue = expression.quasis[0].value.cooked;
-		if (typeof cookedValue === "string") return isValidTypeValue(cookedValue, settings);
+	if (isNodeOfType(expression, "TemplateLiteral")) {
+		const staticValue = getStaticTemplateLiteralValue(expression);
+		if (staticValue !== null) return isValidTypeValue(staticValue, settings);
 	}
 	if (isNodeOfType(expression, "ConditionalExpression")) return isProvenValidExpression(expression.consequent, settings) && isProvenValidExpression(expression.alternate, settings);
 	return false;
@@ -3845,10 +3852,10 @@ const collectJsxLabelText = (jsxElementNode) => {
 				collectedFragments.push(expression.value);
 				continue;
 			}
-			if (isNodeOfType(expression, "TemplateLiteral") && expression.quasis?.length === 1) {
-				const rawTemplate = expression.quasis[0].value?.raw;
-				if (typeof rawTemplate === "string" && expression.expressions.length === 0) {
-					collectedFragments.push(rawTemplate);
+			if (isNodeOfType(expression, "TemplateLiteral")) {
+				const staticValue = getStaticTemplateLiteralValue(expression);
+				if (staticValue !== null) {
+					collectedFragments.push(staticValue);
 					continue;
 				}
 			}
@@ -5031,7 +5038,7 @@ const symbolHasStableHookOrigin = (symbol) => {
 	const initializer = unwrapExpression(initializerRaw);
 	if (symbol.kind === "const") {
 		if (isNodeOfType(initializer, "Literal") && (initializer.value === null || typeof initializer.value === "number" || typeof initializer.value === "string" || typeof initializer.value === "boolean")) return true;
-		if (isNodeOfType(initializer, "TemplateLiteral") && initializer.expressions.length === 0) return true;
+		if (isNodeOfType(initializer, "TemplateLiteral") && getStaticTemplateLiteralValue(initializer) !== null) return true;
 	}
 	if (!isNodeOfType(initializer, "CallExpression")) return false;
 	const initializerHookName = getHookName(initializer.callee);
@@ -5251,7 +5258,7 @@ const isOutsideAllFunctions = (symbol) => {
 	}
 	return true;
 };
-const isLiteralOrEmptyTemplate = (node) => isNodeOfType(node, "Literal") || isNodeOfType(node, "TemplateLiteral") && node.expressions.length === 0;
+const isLiteralOrEmptyTemplate = (node) => isNodeOfType(node, "Literal") || isNodeOfType(node, "TemplateLiteral") && getStaticTemplateLiteralValue(node) !== null;
 const isNonStringLiteral = (node) => isNodeOfType(node, "Literal") && typeof node.value !== "string";
 const isMatchingDepOrPrefix = (declaredKey, captureKey) => captureKey === declaredKey || captureKey.startsWith(`${declaredKey}.`);
 const hasBroaderDeclaredDependency = (declaredKey, declaredKeys) => {
@@ -6169,11 +6176,8 @@ const evaluateLang = (attributeValue) => {
 			return "ok";
 		}
 		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length === 0 && expression.quasis.length === 1) {
-				const cooked = expression.quasis[0].value.cooked;
-				return cooked && cooked.length > 0 ? "ok" : "empty";
-			}
-			return "ok";
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			return staticValue === null ? "ok" : staticValue.length > 0 ? "ok" : "empty";
 		}
 		return "ok";
 	}
@@ -6235,11 +6239,8 @@ const evaluateTitleValue = (value) => {
 			return "dynamic-ok";
 		}
 		if (isNodeOfType(expression, "TemplateLiteral")) {
-			if (expression.expressions.length === 0 && expression.quasis.length === 1) {
-				const cooked = expression.quasis[0].value.cooked;
-				return cooked && cooked.length > 0 ? "ok" : "empty";
-			}
-			return "dynamic-ok";
+			const staticValue = getStaticTemplateLiteralValue(expression);
+			return staticValue === null ? "dynamic-ok" : staticValue.length > 0 ? "ok" : "empty";
 		}
 		return "dynamic-ok";
 	}
@@ -7513,10 +7514,9 @@ const checkExpressionContainer = (container, parentIsAttribute, context, setting
 		return;
 	}
 	if (isNodeOfType(expression, "TemplateLiteral") && allowed === "never") {
-		if (expression.expressions.length !== 0 || expression.quasis.length !== 1) return;
-		const quasi = expression.quasis[0];
-		const rawSource = quasi.value.raw ?? "";
-		const cooked = quasi.value.cooked ?? "";
+		const cooked = getStaticTemplateLiteralValue(expression);
+		if (cooked === null) return;
+		const rawSource = expression.quasis?.[0]?.value.raw ?? "";
 		if (!parentIsAttribute && containsAnyQuote(cooked)) return;
 		if (isAllowedStringLikeInContainer(rawSource, container, parentIsAttribute)) return;
 		context.report({
@@ -7883,8 +7883,7 @@ const resolveSettings$31 = (settings) => {
 	const ruleSettings = typeof reactDoctor === "object" && reactDoctor !== null ? reactDoctor.jsxKey ?? {} : {};
 	return {
 		checkKeyMustBeforeSpread: ruleSettings.checkKeyMustBeforeSpread ?? true,
-		warnOnDuplicates: ruleSettings.warnOnDuplicates ?? false,
-		checkFragmentShorthand: ruleSettings.checkFragmentShorthand ?? true
+		warnOnDuplicates: ruleSettings.warnOnDuplicates ?? false
 	};
 };
 const findEnclosingIteratorContext = (jsxNode) => {
@@ -7999,10 +7998,10 @@ const getKeyAttributeValueString = (openingElement) => {
 				};
 				return null;
 			}
-			if (isNodeOfType(expression, "TemplateLiteral") && expression.expressions.length === 0 && expression.quasis.length === 1) {
-				const cookedValue = expression.quasis[0].value.cooked;
-				if (typeof cookedValue === "string") return {
-					keyValue: cookedValue,
+			if (isNodeOfType(expression, "TemplateLiteral")) {
+				const staticValue = getStaticTemplateLiteralValue(expression);
+				if (staticValue !== null) return {
+					keyValue: staticValue,
 					node: attribute
 				};
 			}
@@ -8042,16 +8041,6 @@ const jsxKey = defineRule({
 					message: enclosingContext.kind === "array" ? MISSING_KEY_ARRAY : MISSING_KEY_ITERATOR
 				});
 			},
-			JSXFragment(node) {
-				if (!settings.checkFragmentShorthand) return;
-				const enclosingContext = findEnclosingIteratorContext(node);
-				if (!enclosingContext) return;
-				if (isWithinChildrenToArray(node)) return;
-				context.report({
-					node,
-					message: enclosingContext.kind === "array" ? MISSING_KEY_ARRAY : MISSING_KEY_ITERATOR
-				});
-			},
 			ArrayExpression(node) {
 				if (!settings.warnOnDuplicates) return;
 				const seenKeys = /* @__PURE__ */ new Set();
@@ -13054,7 +13043,7 @@ const isFalseAttributeValue = (value) => {
 			if (typeof expression.value === "string") return expression.value === "false";
 			return false;
 		}
-		if (isNodeOfType(expression, "TemplateLiteral")) return expression.expressions.length === 0 && expression.quasis.length === 1 && expression.quasis[0].value.cooked === "false";
+		if (isNodeOfType(expression, "TemplateLiteral")) return getStaticTemplateLiteralValue(expression) === "false";
 	}
 	return false;
 };
@@ -24078,7 +24067,7 @@ const isPlatformSelectCallee = (callee) => {
 const isStringLiteralEqualTo = (node, expected) => {
 	if (!node) return false;
 	if (isNodeOfType(node, "Literal") && node.value === expected) return true;
-	if (isNodeOfType(node, "TemplateLiteral") && node.quasis.length === 1) return node.quasis[0]?.value?.cooked === expected;
+	if (isNodeOfType(node, "TemplateLiteral")) return getStaticTemplateLiteralValue(node) === expected;
 	return false;
 };
 const readStaticPropertyKeyName = (property) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",
@@ -50,7 +50,7 @@
     "oxc-parser": "^0.132.0"
   },
   "engines": {
-    "node": ">=22.13.0"
+    "node": "^20.19.0 || >=22.12.0"
   },
   "scripts": {
     "dev": "vp pack --watch",