oxlint-plugin-react-doctor 0.2.18-dev.eba20ae → 0.3.0-dev.6130583

package/dist/index.js

@@ -1,7 +1,7 @@
-import path from "node:path";
+import * as path from "node:path";
 import { analyze } from "eslint-scope";
 import * as eslintVisitorKeys from "eslint-visitor-keys";
-import fs from "node:fs";
+import * as fs from "node:fs";
 import { parseSync } from "oxc-parser";
 //#region src/plugin/utils/is-testlike-filename.ts
 const NON_PRODUCTION_PATH_SEGMENTS = [
@@ -14786,6 +14786,37 @@ const isSetterIdentifier = (name) => SETTER_PATTERN.test(name);
 //#region src/plugin/utils/is-setter-call.ts
 const isSetterCall = (node) => isNodeOfType(node, "CallExpression") && isNodeOfType(node.callee, "Identifier") && isSetterIdentifier(node.callee.name);
 //#endregion
+//#region src/plugin/utils/is-hook-binding-in-scope.ts
+const isHookBindingInScope = (node, query) => {
+	const { bindingName, hookName, destructureIndex } = query;
+	let cursor = node;
+	while (cursor) {
+		if (isNodeOfType(cursor, "BlockStatement") || isNodeOfType(cursor, "Program")) for (const statement of cursor.body ?? []) {
+			if (!isNodeOfType(statement, "VariableDeclaration")) continue;
+			for (const declarator of statement.declarations ?? []) {
+				if (!isNodeOfType(declarator.init, "CallExpression")) continue;
+				if (!isHookCall$1(declarator.init, hookName)) continue;
+				if (destructureIndex !== void 0) {
+					if (!isNodeOfType(declarator.id, "ArrayPattern")) continue;
+					const elements = declarator.id.elements ?? [];
+					if (elements.length <= destructureIndex) continue;
+					const element = elements[destructureIndex];
+					if (isNodeOfType(element, "Identifier") && element.name === bindingName) return true;
+				} else if (isNodeOfType(declarator.id, "Identifier") && declarator.id.name === bindingName) return true;
+			}
+		}
+		cursor = cursor.parent ?? null;
+	}
+	return false;
+};
+//#endregion
+//#region src/plugin/utils/is-use-state-setter-in-scope.ts
+const isUseStateSetterInScope = (node, setterName) => isHookBindingInScope(node, {
+	bindingName: setterName,
+	hookName: "useState",
+	destructureIndex: 1
+});
+//#endregion
 //#region src/plugin/rules/state-and-effects/no-cascading-set-state.ts
 const isAsyncFunctionLike = (node) => {
 	if (isNodeOfType(node, "ArrowFunctionExpression") || isNodeOfType(node, "FunctionExpression") || isNodeOfType(node, "FunctionDeclaration")) return Boolean(node.async);
@@ -14827,7 +14858,7 @@ const countMaxPathSetStateCalls = (node) => {
 		const finallyCount = node.finalizer ? countMaxPathSetStateCalls(node.finalizer) : 0;
 		return Math.max(tryCount, catchCount) + finallyCount;
 	}
-	if (isSetterCall(node)) {
+	if (isNodeOfType(node, "CallExpression") && isSetterCall(node) && isNodeOfType(node.callee, "Identifier") && isUseStateSetterInScope(node, node.callee.name)) {
 		let nestedSettersInArgs = 0;
 		for (const argument of node.arguments ?? []) nestedSettersInArgs += countMaxPathSetStateCalls(argument);
 		return 1 + nestedSettersInArgs;
@@ -15628,7 +15659,11 @@ const noDerivedStateEffect = defineRule({
 		if (statements.length === 0) return;
 		if (!statements.every((statement) => {
 			if (!isNodeOfType(statement, "ExpressionStatement")) return false;
-			return isSetterCall(statement.expression);
+			const expression = statement.expression;
+			if (!isSetterCall(expression)) return false;
+			if (!isNodeOfType(expression, "CallExpression")) return false;
+			if (!isNodeOfType(expression.callee, "Identifier")) return false;
+			return isUseStateSetterInScope(expression, expression.callee.name);
 		})) return;
 		let allArgumentsDeriveFromDeps = true;
 		let hasAnyDependencyReference = false;
@@ -25968,7 +26003,9 @@ const renderingHydrationNoFlicker = defineRule({
 		const bodyStatements = isNodeOfType(callback.body, "BlockStatement") ? callback.body.body : [callback.body];
 		if (!bodyStatements || bodyStatements.length !== 1) return;
 		const soleStatement = bodyStatements[0];
-		if (isNodeOfType(soleStatement, "ExpressionStatement") && isSetterCall(soleStatement.expression)) context.report({
+		if (!isNodeOfType(soleStatement, "ExpressionStatement")) return;
+		const expression = soleStatement.expression;
+		if (isSetterCall(expression) && isNodeOfType(expression, "CallExpression") && isNodeOfType(expression.callee, "Identifier") && isUseStateSetterInScope(expression, expression.callee.name)) context.report({
 			node,
 			message: "This flashes for your users because useEffect(setState, []) runs after the first paint, so use useSyncExternalStore, or add suppressHydrationWarning"
 		});
@@ -26491,6 +26528,7 @@ const rerenderFunctionalSetstate = defineRule({
 		if (!isSetterCall(node)) return;
 		if (!node.arguments?.length) return;
 		if (!isNodeOfType(node.callee, "Identifier")) return;
+		if (!isUseStateSetterInScope(node, node.callee.name)) return;
 		const calleeName = node.callee.name;
 		const argument = node.arguments[0];
 		const expectedStateName = deriveStateVariableName(calleeName);
@@ -26825,7 +26863,7 @@ const handlerCallsSetState = (handler) => {
 	let setStateCall = null;
 	walkAst(handler.body, (child) => {
 		if (setStateCall) return;
-		if (isNodeOfType(child, "CallExpression") && isNodeOfType(child.callee, "Identifier") && /^set[A-Z]/.test(child.callee.name)) setStateCall = child;
+		if (isNodeOfType(child, "CallExpression") && isNodeOfType(child.callee, "Identifier") && /^set[A-Z]/.test(child.callee.name) && isUseStateSetterInScope(child, child.callee.name)) setStateCall = child;
 	});
 	return setStateCall;
 };
@@ -28073,7 +28111,7 @@ const findSetStateInBody = (body) => {
 	let setStateCallNode = null;
 	walkAst(body, (child) => {
 		if (setStateCallNode) return;
-		if (isNodeOfType(child, "CallExpression") && isNodeOfType(child.callee, "Identifier") && SET_STATE_PATTERN.test(child.callee.name)) setStateCallNode = child;
+		if (isNodeOfType(child, "CallExpression") && isNodeOfType(child.callee, "Identifier") && SET_STATE_PATTERN.test(child.callee.name) && isUseStateSetterInScope(child, child.callee.name)) setStateCallNode = child;
 	});
 	return setStateCallNode;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.2.18-dev.eba20ae",
+  "version": "0.3.0-dev.6130583",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",