oxlint-plugin-react-doctor 0.2.10 → 0.2.11-dev.f036b0f

package/dist/index.d.ts

@@ -82,10 +82,17 @@ interface ScopeAnalysis {
 //#region src/plugin/utils/rule-context.d.ts
 interface BaseRuleContext {
   report: (descriptor: ReportDescriptor) => void;
-  getFilename?: () => string;
+  readonly filename?: string;
+  /**
+   * @deprecated Rules use `context.filename`. Read only as a fallback by
+   * `wrapWithSemanticContext`; ESLint implements it as a `this`-bound class
+   * method, so it must be called on the host context, never a detached
+   * reference.
+   */
+  getFilename?: () => string | undefined;
   readonly settings?: Readonly<Record<string, unknown>>;
 }
-interface RuleContext extends BaseRuleContext {
+interface RuleContext extends Omit<BaseRuleContext, "getFilename"> {
   readonly scopes: ScopeAnalysis;
   readonly cfg: ControlFlowAnalysis;
 }
@@ -3954,23 +3961,6 @@ declare const REACT_DOCTOR_RULES: readonly [{
     readonly recommendation?: string;
     readonly create: (context: RuleContext) => RuleVisitors;
   };
-}, {
-  readonly key: "react-doctor/react-compiler-destructure-method";
-  readonly id: "react-compiler-destructure-method";
-  readonly source: "react-doctor";
-  readonly originallyExternal: false;
-  readonly rule: {
-    readonly framework: "global";
-    readonly category: "Architecture";
-    readonly id: string;
-    readonly severity: RuleSeverity;
-    readonly requires?: ReadonlyArray<string>;
-    readonly disabledBy?: ReadonlyArray<string>;
-    readonly tags?: ReadonlyArray<string>;
-    readonly defaultEnabled?: boolean;
-    readonly recommendation?: string;
-    readonly create: (context: RuleContext) => RuleVisitors;
-  };
 }, {
   readonly key: "react-doctor/react-compiler-no-manual-memoization";
   readonly id: "react-compiler-no-manual-memoization";
@@ -9239,23 +9229,6 @@ declare const RULES: readonly [{
     readonly recommendation?: string;
     readonly create: (context: RuleContext) => RuleVisitors;
   };
-}, {
-  readonly key: "react-doctor/react-compiler-destructure-method";
-  readonly id: "react-compiler-destructure-method";
-  readonly source: "react-doctor";
-  readonly originallyExternal: false;
-  readonly rule: {
-    readonly framework: "global";
-    readonly category: "Architecture";
-    readonly id: string;
-    readonly severity: RuleSeverity;
-    readonly requires?: ReadonlyArray<string>;
-    readonly disabledBy?: ReadonlyArray<string>;
-    readonly tags?: ReadonlyArray<string>;
-    readonly defaultEnabled?: boolean;
-    readonly recommendation?: string;
-    readonly create: (context: RuleContext) => RuleVisitors;
-  };
 }, {
   readonly key: "react-doctor/react-compiler-no-manual-memoization";
   readonly id: "react-compiler-no-manual-memoization";

package/dist/index.js

@@ -223,7 +223,7 @@ const jsxAttributeIsNonReactDialectMarker = (openingNode) => {
 //#endregion
 //#region src/plugin/utils/define-rule.ts
 const wrapCreateForTestNoise = (create) => ((context) => {
-	if (isTestlikeFilename(context.getFilename?.())) return {};
+	if (isTestlikeFilename(context.filename)) return {};
 	return create(context);
 });
 const VISITOR_NODE_NAME_PATTERN = /^[A-Z]/;
@@ -813,6 +813,12 @@ const getElementType = (openingElement, settings) => {
 	return baseName;
 };
 //#endregion
+//#region src/plugin/utils/is-nextjs-metadata-image-route-filename.ts
+const isNextjsMetadataImageRouteFilename = (rawFilename) => {
+	if (!rawFilename) return false;
+	return /^(opengraph-image|twitter-image|icon|apple-icon)\d*\.(jsx?|tsx?)$/.test(path.basename(rawFilename));
+};
+//#endregion
 //#region src/plugin/utils/is-hidden-from-screen-reader.ts
 const isHiddenFromScreenReader = (openingElement, settings) => {
 	if (getElementType(openingElement, settings).toLowerCase() === "input") {
@@ -983,6 +989,7 @@ const altText = defineRule({
 	recommendation: "Provide `alt` (or aria-label / aria-labelledby) for non-decorative images.",
 	category: "Accessibility",
 	create: (context) => {
+		if (isNextjsMetadataImageRouteFilename(context.filename)) return {};
 		const settings = resolveSettings$53(context.settings);
 		const checkImg = !settings.elements || settings.elements.includes("img");
 		const checkObject = !settings.elements || settings.elements.includes("object");
@@ -2712,6 +2719,17 @@ const asyncAwaitInLoop = defineRule({
 	}
 });
 //#endregion
+//#region src/plugin/constants/ts-type-position-keys.ts
+const TYPE_POSITION_CHILD_KEYS = new Set([
+	"implements",
+	"returnType",
+	"superTypeArguments",
+	"superTypeParameters",
+	"typeAnnotation",
+	"typeArguments",
+	"typeParameters"
+]);
+//#endregion
 //#region src/plugin/utils/collect-pattern-names.ts
 const collectPatternNames = (pattern, into) => {
 	if (!pattern) return;
@@ -2741,14 +2759,6 @@ const collectPatternNames = (pattern, into) => {
 };
 //#endregion
 //#region src/plugin/utils/collect-reference-identifier-names.ts
-const TYPE_POSITION_KEYS = new Set([
-	"typeAnnotation",
-	"typeParameters",
-	"typeArguments",
-	"returnType",
-	"superTypeArguments",
-	"superTypeParameters"
-]);
 const collectScopedReferencesInPattern = (pattern, into, shadowed) => {
 	if (!pattern) return;
 	if (isNodeOfType(pattern, "Identifier")) return;
@@ -2809,7 +2819,7 @@ const collectScopedReferenceIdentifierNames = (node, into, shadowed) => {
 	if (typeof node.type === "string" && node.type.startsWith("TS")) return;
 	for (const [key, child] of Object.entries(node)) {
 		if (key === "parent") continue;
-		if (TYPE_POSITION_KEYS.has(key)) continue;
+		if (TYPE_POSITION_CHILD_KEYS.has(key)) continue;
 		if (Array.isArray(child)) {
 			for (const item of child) if (isAstNode(item)) collectScopedReferenceIdentifierNames(item, into, shadowed);
 		} else if (isAstNode(child)) collectScopedReferenceIdentifierNames(child, into, shadowed);
@@ -3127,7 +3137,7 @@ const asyncParallel = defineRule({
 	severity: "warn",
 	recommendation: "Use `const [a, b] = await Promise.all([fetchA(), fetchB()])` to run independent operations concurrently",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const isBrowserTestFile = BROWSER_TEST_FILE_PATTERN.test(filename);
 		let hasTestLibraryImport = false;
 		const shouldSkipFile = () => isBrowserTestFile || hasTestLibraryImport;
@@ -3330,7 +3340,7 @@ const buttonHasType = defineRule({
 	recommendation: "Set `type=\"button\"` (or `\"submit\"` / `\"reset\"`) explicitly on every `<button>`.",
 	create: (context) => {
 		const settings = resolveSettings$48(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return {
 			JSXOpeningElement(node) {
 				if (isTestlikeFile) return;
@@ -3530,7 +3540,7 @@ const clickEventsHaveKeyEvents = defineRule({
 	recommendation: "Pair `onClick` with `onKeyUp` / `onKeyDown` / `onKeyPress` for keyboard users.",
 	category: "Accessibility",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			const tag = getElementType(node, context.settings);
@@ -3791,7 +3801,7 @@ const controlHasAssociatedLabel = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$46(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXElement(node) {
 			if (isTestlikeFile) return;
 			const opening = node.openingElement;
@@ -4928,6 +4938,33 @@ const inferReferenceFlag = (identifier) => {
 const setNodeScope = (node, state) => {
 	state.nodeScope.set(node, state.currentScope);
 };
+const walkParameterReferences = (pattern, state) => {
+	if (isNodeOfType(pattern, "AssignmentPattern")) {
+		walkParameterReferences(pattern.left, state);
+		const defaultValue = pattern.right ?? null;
+		if (defaultValue) walk(defaultValue, state);
+		return;
+	}
+	if (isNodeOfType(pattern, "ObjectPattern")) {
+		for (const property of pattern.properties) {
+			const propertyNode = property;
+			if (isNodeOfType(propertyNode, "RestElement")) {
+				walkParameterReferences(propertyNode.argument, state);
+				continue;
+			}
+			if (!isNodeOfType(propertyNode, "Property")) continue;
+			const propertyDetail = propertyNode;
+			if (propertyDetail.computed) walk(propertyDetail.key, state);
+			walkParameterReferences(propertyDetail.value, state);
+		}
+		return;
+	}
+	if (isNodeOfType(pattern, "ArrayPattern")) {
+		for (const element of pattern.elements) if (element) walkParameterReferences(element, state);
+		return;
+	}
+	if (isNodeOfType(pattern, "RestElement")) walkParameterReferences(pattern.argument, state);
+};
 const walk = (node, state) => {
 	if (isFunctionLike$1(node)) {
 		if (isNodeOfType(node, "FunctionDeclaration") && node.id) handleFunctionDeclaration(node, state);
@@ -4943,7 +4980,9 @@ const walk = (node, state) => {
 			});
 			tagAsBinding(state, node.id);
 		}
-		handleFunctionParameters(node.params ?? [], fnScope, state);
+		const functionParams = node.params ?? [];
+		handleFunctionParameters(functionParams, fnScope, state);
+		for (const param of functionParams) walkParameterReferences(param, state);
 		const body = node.body;
 		if (body) walk(body, state);
 		popScope(state);
@@ -4985,6 +5024,7 @@ const walk = (node, state) => {
 		const nodeRecord = node;
 		for (const key of Object.keys(nodeRecord)) {
 			if (key === "parent") continue;
+			if (TYPE_POSITION_CHILD_KEYS.has(key)) continue;
 			const child = nodeRecord[key];
 			if (Array.isArray(child)) {
 				for (const item of child) if (isAstNode(item)) walk(item, state);
@@ -5047,6 +5087,7 @@ const walk = (node, state) => {
 	const nodeRecord = node;
 	for (const key of Object.keys(nodeRecord)) {
 		if (key === "parent") continue;
+		if (TYPE_POSITION_CHILD_KEYS.has(key)) continue;
 		const child = nodeRecord[key];
 		if (Array.isArray(child)) {
 			for (const item of child) if (isAstNode(item)) walk(item, state);
@@ -5166,14 +5207,6 @@ const isAstDescendant = (inner, outer) => {
 };
 //#endregion
 //#region src/plugin/semantic/closure-captures.ts
-const TYPE_ONLY_CHILD_KEYS = new Set([
-	"implements",
-	"returnType",
-	"superTypeArguments",
-	"typeAnnotation",
-	"typeArguments",
-	"typeParameters"
-]);
 const closureCaptures = (functionNode, scopes) => {
 	const functionScope = scopes.ownScopeFor(functionNode) ?? scopes.scopeFor(functionNode);
 	const out = [];
@@ -5201,7 +5234,7 @@ const closureCaptures = (functionNode, scopes) => {
 		const record = node;
 		for (const key of Object.keys(record)) {
 			if (key === "parent") continue;
-			if (TYPE_ONLY_CHILD_KEYS.has(key)) continue;
+			if (TYPE_POSITION_CHILD_KEYS.has(key)) continue;
 			const child = record[key];
 			if (Array.isArray(child)) {
 				for (const item of child) if (isAstNode(item)) visit(item);
@@ -5564,33 +5597,6 @@ const collectCaptureDepKeys = (callback, scopes) => {
 		if (!depKey) continue;
 		keys.add(depKey);
 	}
-	const functionParams = callback.params ?? [];
-	for (const param of functionParams) {
-		if (!isNodeOfType(param, "AssignmentPattern")) continue;
-		const visitDefaultValue = (node) => {
-			if (isNodeOfType(node, "Identifier") || isNodeOfType(node, "MemberExpression")) {
-				const depKey = stringifyMemberChain(node);
-				if (depKey) keys.add(depKey);
-			}
-			const reference = scopes.referenceFor(node);
-			if (reference?.resolvedSymbol) {
-				const symbol = reference.resolvedSymbol;
-				if (!isOutsideAllFunctions(symbol)) {
-					const depKey = computeDepKey(reference);
-					if (depKey) keys.add(depKey);
-				}
-			}
-			const record = node;
-			for (const key of Object.keys(record)) {
-				if (key === "parent") continue;
-				const child = record[key];
-				if (Array.isArray(child)) {
-					for (const item of child) if (isAstNode(item)) visitDefaultValue(item);
-				} else if (isAstNode(child)) visitDefaultValue(child);
-			}
-		};
-		visitDefaultValue(param.right);
-	}
 	return {
 		keys,
 		stableCapturedNames
@@ -8423,6 +8429,7 @@ const jsTosortedImmutable = defineRule({
 	id: "js-tosorted-immutable",
 	tags: ["test-noise"],
 	severity: "warn",
+	disabledBy: ["react-native"],
 	recommendation: "Use `array.toSorted()` (ES2023) instead of `[...array].sort()` for immutable sorting without the spread allocation",
 	create: (context) => ({ CallExpression(node) {
 		if (!isMemberProperty(node.callee, "sort")) return;
@@ -8711,7 +8718,7 @@ const jsxFilenameExtension = defineRule({
 		const settings = resolveSettings$34(context.settings);
 		const allowedExtensions = normalizeExtensions(settings.extensions);
 		const allowedList = [...allowedExtensions].map((extension) => `.${extension}`).join(", ");
-		const filename = context.getFilename ? normalizeFilename$1(context.getFilename()) : "fixture.tsx";
+		const filename = normalizeFilename$1(context.filename ?? "fixture.tsx");
 		const extensionOnly = path.extname(filename).slice(1);
 		const fileHasAllowedExtension = allowedExtensions.has(extensionOnly);
 		let didReportMismatch = false;
@@ -9495,7 +9502,7 @@ const jsxNoConstructedContextValues = defineRule({
 	recommendation: "Memoize the context value (`useMemo`) or hoist it outside the render.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			if (!isProviderName(node.name)) return;
@@ -9841,7 +9848,7 @@ const jsxNoJsxAsProp = defineRule({
 	recommendation: "Hoist the inner JSX outside the render or memoize via `useMemo`.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -10212,7 +10219,7 @@ const jsxNoNewArrayAsProp = defineRule({
 	recommendation: "Memoize the array (`useMemo`) or hoist it outside the component.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -10674,7 +10681,7 @@ const jsxNoNewFunctionAsProp = defineRule({
 	recommendation: "Memoize the callback (`useCallback`) or hoist it outside the component.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -10980,7 +10987,7 @@ const jsxNoNewObjectAsProp = defineRule({
 	recommendation: "Memoize the object (`useMemo`) or hoist it outside the component.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -11785,7 +11792,7 @@ const labelHasAssociatedControl = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$24(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXElement(node) {
 			if (isTestlikeFile) return;
 			const opening = node.openingElement;
@@ -12323,7 +12330,7 @@ const nextjsMissingMetadata = defineRule({
 	severity: "warn",
 	recommendation: "Add `export const metadata = { title: '...', description: '...' }` or `export async function generateMetadata()`",
 	create: (context) => ({ Program(programNode) {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!PAGE_FILE_PATTERN.test(filename)) return;
 		if (INTERNAL_PAGE_PATH_PATTERN.test(filename)) return;
 		if (!programNode.body?.some((statement) => {
@@ -12388,7 +12395,7 @@ const nextjsNoClientFetchForServerData = defineRule({
 				if (!fileHasUseClient || !isHookCall$1(node, EFFECT_HOOK_NAMES$1)) return;
 				const callback = getEffectCallback(node);
 				if (!callback || !containsFetchCall(callback)) return;
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (PAGE_OR_LAYOUT_FILE_PATTERN.test(filename) || PAGES_DIRECTORY_PATTERN.test(filename)) context.report({
 					node,
 					message: "useEffect + fetch in a page/layout — fetch data server-side with a server component instead"
@@ -12421,7 +12428,7 @@ const nextjsNoClientSideRedirect = defineRule({
 	severity: "warn",
 	recommendation: "Avoid redirects inside useEffect. Use an event handler, middleware, or server-side redirect (App Router: redirect() from next/navigation; Pages Router: getServerSideProps redirect)",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const isPagesRouterFile = PAGES_DIRECTORY_PATTERN.test(filename);
 		return { CallExpression(node) {
 			if (!isHookCall$1(node, EFFECT_HOOK_NAMES$1)) return;
@@ -12490,7 +12497,7 @@ const nextjsNoHeadImport = defineRule({
 	recommendation: "Use the Metadata API instead: `export const metadata = { title: '...' }` or `export async function generateMetadata()`",
 	create: (context) => ({ ImportDeclaration(node) {
 		if (node.source?.value !== "next/head") return;
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!APP_DIRECTORY_PATTERN.test(filename)) return;
 		context.report({
 			node,
@@ -12507,7 +12514,7 @@ const nextjsNoImgElement = defineRule({
 	severity: "warn",
 	recommendation: "`import Image from 'next/image'` — provides automatic WebP/AVIF, lazy loading, and responsive srcset",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const isOgRoute = OG_ROUTE_PATTERN.test(filename);
 		return { JSXOpeningElement(node) {
 			if (isOgRoute) return;
@@ -12861,7 +12868,7 @@ const nextjsNoSideEffectInGetHandler = defineRule({
 				resolveBinding = buildProgramBindingLookup(node);
 			},
 			ExportNamedDeclaration(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!ROUTE_HANDLER_FILE_PATTERN.test(filename)) return;
 				if (CRON_ROUTE_PATTERN.test(filename)) return;
 				if (!isExportedGetHandler(node)) return;
@@ -13405,9 +13412,9 @@ const findContainingNode = (analysis, node) => {
 //#region src/plugin/rules/state-and-effects/no-adjust-state-on-prop-change.ts
 const noAdjustStateOnPropChange = defineRule({
 	id: "no-adjust-state-on-prop-change",
-	severity: "warn",
+	severity: "error",
 	tags: ["test-noise"],
-	recommendation: "Adjust the state inline during render instead of via a useEffect, or refactor the state to avoid the need entirely. See https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes",
+	recommendation: "Adjust the state inline during render with a `prev`-prop comparison (`if (prop !== prevProp) { setPrevProp(prop); setX(...); }`), or refactor to remove the duplicated state. Routing the adjustment through a useEffect forces an extra render with a stale UI between the two commits. See https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes",
 	create: (context) => ({ CallExpression(node) {
 		if (!isUseEffect(node)) return;
 		const analysis = getProgramAnalysis(node);
@@ -13426,7 +13433,7 @@ const noAdjustStateOnPropChange = defineRule({
 			if (getArgsUpstreamRefs(analysis, ref).some((argRef) => isProp(analysis, argRef))) continue;
 			context.report({
 				node: callExpr,
-				message: "Avoid adjusting state when a prop changes. Instead, adjust the state directly during render, or refactor your state to avoid this need entirely."
+				message: "State adjusted in a useEffect when a prop changes — forces an extra render with a stale UI between the two commits. Adjust the state during render with a `prev`-prop comparison instead, or refactor to remove the duplicated state."
 			});
 		}
 	} })
@@ -14093,7 +14100,7 @@ const noAutofocus = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$21(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			const autoFocusAttribute = node.attributes.find((attribute) => {
@@ -14467,7 +14474,7 @@ const noBarrelImport = defineRule({
 			if (didReportForFile) return;
 			const source = node.source?.value;
 			if (typeof source !== "string" || !source.startsWith(".")) return;
-			const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+			const filename = normalizeFilename$1(context.filename ?? "");
 			if (!filename) return;
 			const importRequests = getRuntimeImportRequests(node);
 			if (importRequests.length === 0) return;
@@ -18246,7 +18253,7 @@ const noMultiComp = defineRule({
 	category: "Architecture",
 	create: (context) => {
 		const settings = resolveSettings$16(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { Program(node) {
 			if (isTestlikeFile) return;
 			const visitContext = {
@@ -20193,7 +20200,7 @@ const noSecretsInClientCode = defineRule({
 	severity: "warn",
 	recommendation: "Move secrets to server-only code. Public client environment variables are bundled into browser code and must not contain secrets",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const framework = getReactDoctorStringSetting(context.settings, "framework");
 		const rootDirectory = getReactDoctorStringSetting(context.settings, "rootDirectory");
 		let shouldUseVariableNameHeuristic = classifySecretFileExposure(filename, {
@@ -20448,7 +20455,7 @@ const noStaticElementInteractions = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$12(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			let hasNonBlockerHandler = false;
@@ -20525,7 +20532,7 @@ const noStringRefs = defineRule({
 	recommendation: "Use a callback ref (`ref={(node) => { this.foo = node }}`) or `useRef` instead of string refs.",
 	create: (context) => {
 		const { noTemplateLiterals = false } = resolveSettings$11(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return {
 			JSXAttribute(node) {
 				if (isTestlikeFile) return;
@@ -22660,7 +22667,7 @@ const isFileNameAllowed = (filename, checkJS) => {
 };
 const onlyExportComponents = defineRule({
 	id: "only-export-components",
-	severity: "error",
+	severity: "warn",
 	recommendation: "Move non-component exports out of files that export components.",
 	category: "Architecture",
 	create: (context) => {
@@ -22671,7 +22678,7 @@ const onlyExportComponents = defineRule({
 			allowConstantExport: settings.allowConstantExport
 		};
 		return { Program(node) {
-			if (!isFileNameAllowed(context.getFilename ? normalizeFilename$1(context.getFilename()) : void 0, settings.checkJS)) return;
+			if (!isFileNameAllowed(normalizeFilename$1(context.filename ?? ""), settings.checkJS)) return;
 			const allNodes = collectAllNodes(node);
 			const exports = [];
 			let hasReactExport = false;
@@ -23717,106 +23724,6 @@ const queryStableQueryClient = defineRule({
 	}
 });
 //#endregion
-//#region src/plugin/rules/architecture/react-compiler-destructure-method.ts
-const HOOK_OBJECTS_WITH_METHODS = new Map([
-	["useRouter", new Set([
-		"push",
-		"replace",
-		"back",
-		"forward",
-		"refresh",
-		"prefetch"
-	])],
-	["useNavigation", new Set([
-		"navigate",
-		"push",
-		"goBack",
-		"popToTop",
-		"reset",
-		"replace",
-		"dispatch"
-	])],
-	["useSearchParams", new Set([
-		"get",
-		"getAll",
-		"has",
-		"set"
-	])]
-]);
-const HOOK_IMPORT_SOURCES_WITH_UNSAFE_METHOD_DESTRUCTURING = new Map([["useNavigation", new Set(["@react-navigation/native", "@react-navigation/core"])]]);
-const isUnsafeMethodDestructureHookImport = (node, hookSource) => {
-	const moduleSources = HOOK_IMPORT_SOURCES_WITH_UNSAFE_METHOD_DESTRUCTURING.get(hookSource);
-	if (!moduleSources) return false;
-	for (const moduleSource of moduleSources) if (isImportedFromModule(node, hookSource, moduleSource)) return true;
-	return false;
-};
-const buildHookBindingMap = (componentBody) => {
-	const result = /* @__PURE__ */ new Map();
-	if (!componentBody || !isNodeOfType(componentBody, "BlockStatement")) return result;
-	for (const statement of componentBody.body ?? []) {
-		if (!isNodeOfType(statement, "VariableDeclaration")) continue;
-		for (const declarator of statement.declarations ?? []) {
-			if (!isNodeOfType(declarator.id, "Identifier")) continue;
-			if (!isNodeOfType(declarator.init, "CallExpression")) continue;
-			const callee = declarator.init.callee;
-			if (!isNodeOfType(callee, "Identifier")) continue;
-			result.set(declarator.id.name, callee.name);
-		}
-	}
-	return result;
-};
-const reactCompilerDestructureMethod = defineRule({
-	id: "react-compiler-destructure-method",
-	tags: ["test-noise"],
-	severity: "warn",
-	recommendation: "Destructure the method up front: `const { push } = useRouter()` then call `push(...)` directly — clearer dependency graph and easier for React Compiler to memoize",
-	create: (context) => {
-		const hookBindingMapStack = [];
-		const isComponent = (node) => {
-			if (isNodeOfType(node, "FunctionDeclaration")) return Boolean(node.id?.name && isUppercaseName(node.id.name));
-			if (isNodeOfType(node, "VariableDeclarator")) return isComponentAssignment(node);
-			return false;
-		};
-		const enter = (node) => {
-			if (!isComponent(node)) return;
-			let body;
-			if (isNodeOfType(node, "FunctionDeclaration")) body = node.body;
-			else if (isNodeOfType(node, "VariableDeclarator")) {
-				const initializer = node.init;
-				body = isInlineFunctionExpression(initializer) ? initializer.body : null;
-			}
-			hookBindingMapStack.push(buildHookBindingMap(body));
-		};
-		const exit = (node) => {
-			if (isComponent(node)) hookBindingMapStack.pop();
-		};
-		return {
-			FunctionDeclaration: enter,
-			"FunctionDeclaration:exit": exit,
-			VariableDeclarator: enter,
-			"VariableDeclarator:exit": exit,
-			MemberExpression(node) {
-				if (hookBindingMapStack.length === 0) return;
-				if (node.computed) return;
-				if (!isNodeOfType(node.object, "Identifier")) return;
-				if (!isNodeOfType(node.property, "Identifier")) return;
-				const bindingName = node.object.name;
-				const methodName = node.property.name;
-				const hookSource = hookBindingMapStack[hookBindingMapStack.length - 1].get(bindingName);
-				if (!hookSource) return;
-				const allowedMethods = HOOK_OBJECTS_WITH_METHODS.get(hookSource);
-				if (!allowedMethods || !allowedMethods.has(methodName)) return;
-				if (isUnsafeMethodDestructureHookImport(node, hookSource)) return;
-				if (!isNodeOfType(node.parent, "CallExpression") || node.parent.callee !== node) return;
-				context.report({
-					node,
-					message: `Destructure for clarity: \`const { ${methodName} } = ${hookSource}()\` then call \`${methodName}(...)\` directly — easier for React Compiler to memoize and clearer about which methods this component depends on`
-				});
-			}
-		};
-	}
-});
-//#endregion
 //#region src/plugin/rules/architecture/react-compiler-no-manual-memoization.ts
 const REMOVAL_MESSAGE_BY_REACT_API_NAME = new Map([
 	["useMemo", "Remove `useMemo` — React Compiler auto-memoizes every value in this component. Manual `useMemo` adds noise without improving performance."],
@@ -24192,7 +24099,7 @@ const renderingSvgPrecision = defineRule({
 	category: "Performance",
 	recommendation: "Truncate path/points/transform decimals to 1–2 digits — sub-pixel precision adds bytes with no visible difference",
 	create: (context) => {
-		const filename = context.getFilename?.();
+		const filename = context.filename;
 		const isAutoGenerated = isAutoGeneratedSvgFile(filename ? normalizeFilename$1(filename) : void 0);
 		return { JSXAttribute(node) {
 			if (isAutoGenerated) return;
@@ -25524,7 +25431,8 @@ const classifyPackagePlatform = (filename) => {
 //#endregion
 //#region src/plugin/utils/is-expo-managed-file.ts
 const isExpoManagedFileActive = (context) => {
-	const filename = context.getFilename?.() ? normalizeFilename$1(context.getFilename()) : void 0;
+	const rawFilename = context.filename;
+	const filename = rawFilename ? normalizeFilename$1(rawFilename) : void 0;
 	if (filename) {
 		const packagePlatform = classifyPackagePlatform(filename);
 		if (packagePlatform === "expo") return true;
@@ -30692,7 +30600,7 @@ const serverFetchWithoutRevalidate = defineRule({
 		let isServerSideFile = false;
 		return {
 			Program(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!APP_ROUTER_FILE_PATTERN.test(filename)) {
 					isServerSideFile = false;
 					return;
@@ -30805,7 +30713,7 @@ const serverHoistStaticIo = defineRule({
 			inspectHandlerBody(context, declaration.body, `${handlerName} route handler`, collectIdentifierParams(declaration.params ?? []));
 		},
 		ExportDefaultDeclaration(node) {
-			const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+			const filename = normalizeFilename$1(context.filename ?? "");
 			if (!PAGES_ROUTER_API_PATH_PATTERN.test(filename)) return;
 			const declaration = node.declaration;
 			if (!declaration || !isNodeOfType(declaration, "FunctionDeclaration") && !isNodeOfType(declaration, "FunctionExpression") && !isNodeOfType(declaration, "ArrowFunctionExpression")) return;
@@ -31356,7 +31264,7 @@ const tanstackStartMissingHeadContent = defineRule({
 		};
 		return {
 			Program(node) {
-				const filename = context.getFilename?.() ?? "";
+				const filename = context.filename ?? "";
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				const statements = node.body ?? [];
 				for (const statement of statements) collectImportBindings(statement);
@@ -31366,17 +31274,17 @@ const tanstackStartMissingHeadContent = defineRule({
 				}
 			},
 			ImportDeclaration(node) {
-				const filename = context.getFilename?.() ?? "";
+				const filename = context.filename ?? "";
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				collectImportBindings(node);
 			},
 			VariableDeclarator(node) {
-				const filename = context.getFilename?.() ?? "";
+				const filename = context.filename ?? "";
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				collectVariableAlias(node);
 			},
 			JSXOpeningElement(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isNodeOfType(node.name, "JSXIdentifier")) {
 					if (node.name.name === DOCUMENT_HEAD_ELEMENT_NAME) hasDocumentHeadElement = true;
@@ -31391,7 +31299,7 @@ const tanstackStartMissingHeadContent = defineRule({
 				if (isInsideDocumentHeadElement(node) && isCustomJsxElementName(node.name)) hasCustomHeadChildElement = true;
 			},
 			"Program:exit"(programNode) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (hasDocumentHeadElement && !hasHeadContentElement && !hasCustomHeadChildElement) context.report({
 					node: programNode,
@@ -31410,7 +31318,7 @@ const tanstackStartNoAnchorElement = defineRule({
 	severity: "warn",
 	recommendation: "`import { Link } from '@tanstack/react-router'` — enables type-safe routes, preloading via `preload=\"intent\"`, and client-side navigation",
 	create: (context) => ({ JSXOpeningElement(node) {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 		if (!isNodeOfType(node.name, "JSXIdentifier") || node.name.name !== "a") return;
 		const hrefAttribute = (node.attributes ?? []).find((attribute) => isNodeOfType(attribute, "JSXAttribute") && isNodeOfType(attribute.name, "JSXIdentifier") && attribute.name.name === "href");
@@ -31484,7 +31392,7 @@ const tanstackStartNoNavigateInRender = defineRule({
 		const isEventHandlerAttribute = (node) => isNodeOfType(node, "JSXAttribute") && isNodeOfType(node.name, "JSXIdentifier") && typeof node.name.name === "string" && node.name.name.startsWith("on") && UPPERCASE_PATTERN.test(node.name.name.charAt(2));
 		return {
 			CallExpression(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isDeferredHookCall(node)) deferredCallbackDepth++;
 				if (deferredCallbackDepth > 0 || eventHandlerDepth > 0) return;
@@ -31494,17 +31402,17 @@ const tanstackStartNoNavigateInRender = defineRule({
 				});
 			},
 			"CallExpression:exit"(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isDeferredHookCall(node)) deferredCallbackDepth = Math.max(0, deferredCallbackDepth - 1);
 			},
 			JSXAttribute(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isEventHandlerAttribute(node)) eventHandlerDepth++;
 			},
 			"JSXAttribute:exit"(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isEventHandlerAttribute(node)) eventHandlerDepth = Math.max(0, eventHandlerDepth - 1);
 			}
@@ -31585,7 +31493,7 @@ const tanstackStartNoUseEffectFetch = defineRule({
 	severity: "warn",
 	recommendation: "Fetch data in the route `loader` instead — the router coordinates loading before rendering to avoid waterfalls",
 	create: (context) => ({ CallExpression(node) {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 		if (!isHookCall$1(node, EFFECT_HOOK_NAMES$1)) return;
 		const callback = node.arguments?.[0];
@@ -34308,17 +34216,6 @@ const reactDoctorRules = [
 			category: "TanStack Query"
 		}
 	},
-	{
-		key: "react-doctor/react-compiler-destructure-method",
-		id: "react-compiler-destructure-method",
-		source: "react-doctor",
-		originallyExternal: false,
-		rule: {
-			...reactCompilerDestructureMethod,
-			framework: "global",
-			category: "Architecture"
-		}
-	},
 	{
 		key: "react-doctor/react-compiler-no-manual-memoization",
 		id: "react-compiler-no-manual-memoization",
@@ -35254,7 +35151,7 @@ const ruleRegistry = Object.fromEntries(reactDoctorRules.map((rule) => [rule.id,
 const WEB_FILE_EXTENSION_PATTERN = /\.web\.[cm]?[jt]sx?$/;
 const NATIVE_FILE_EXTENSION_PATTERN = /\.(?:ios|android|native)\.[cm]?[jt]sx?$/;
 const isReactNativeFileActive = (context) => {
-	const rawFilename = context.getFilename?.();
+	const rawFilename = context.filename;
 	if (!rawFilename) return true;
 	const filename = normalizeFilename$1(rawFilename);
 	if (NATIVE_FILE_EXTENSION_PATTERN.test(filename)) return true;
@@ -35742,7 +35639,9 @@ const wrapWithSemanticContext = (rule) => ({
 		};
 		const enrichedContext = {
 			report: baseContext.report,
-			getFilename: baseContext.getFilename,
+			get filename() {
+				return baseContext.filename ?? baseContext.getFilename?.();
+			},
 			settings: baseContext.settings,
 			get scopes() {
 				return getScopes();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.2.10",
+  "version": "0.2.11-dev.f036b0f",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",