oxlint-plugin-react-doctor 0.2.10 → 0.2.11

package/dist/index.d.ts

@@ -82,10 +82,17 @@ interface ScopeAnalysis {
 //#region src/plugin/utils/rule-context.d.ts
 interface BaseRuleContext {
   report: (descriptor: ReportDescriptor) => void;
-  getFilename?: () => string;
+  readonly filename?: string;
+  /**
+   * @deprecated Rules use `context.filename`. Read only as a fallback by
+   * `wrapWithSemanticContext`; ESLint implements it as a `this`-bound class
+   * method, so it must be called on the host context, never a detached
+   * reference.
+   */
+  getFilename?: () => string | undefined;
   readonly settings?: Readonly<Record<string, unknown>>;
 }
-interface RuleContext extends BaseRuleContext {
+interface RuleContext extends Omit<BaseRuleContext, "getFilename"> {
   readonly scopes: ScopeAnalysis;
   readonly cfg: ControlFlowAnalysis;
 }

package/dist/index.js

@@ -223,7 +223,7 @@ const jsxAttributeIsNonReactDialectMarker = (openingNode) => {
 //#endregion
 //#region src/plugin/utils/define-rule.ts
 const wrapCreateForTestNoise = (create) => ((context) => {
-	if (isTestlikeFilename(context.getFilename?.())) return {};
+	if (isTestlikeFilename(context.filename)) return {};
 	return create(context);
 });
 const VISITOR_NODE_NAME_PATTERN = /^[A-Z]/;
@@ -3127,7 +3127,7 @@ const asyncParallel = defineRule({
 	severity: "warn",
 	recommendation: "Use `const [a, b] = await Promise.all([fetchA(), fetchB()])` to run independent operations concurrently",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const isBrowserTestFile = BROWSER_TEST_FILE_PATTERN.test(filename);
 		let hasTestLibraryImport = false;
 		const shouldSkipFile = () => isBrowserTestFile || hasTestLibraryImport;
@@ -3330,7 +3330,7 @@ const buttonHasType = defineRule({
 	recommendation: "Set `type=\"button\"` (or `\"submit\"` / `\"reset\"`) explicitly on every `<button>`.",
 	create: (context) => {
 		const settings = resolveSettings$48(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return {
 			JSXOpeningElement(node) {
 				if (isTestlikeFile) return;
@@ -3530,7 +3530,7 @@ const clickEventsHaveKeyEvents = defineRule({
 	recommendation: "Pair `onClick` with `onKeyUp` / `onKeyDown` / `onKeyPress` for keyboard users.",
 	category: "Accessibility",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			const tag = getElementType(node, context.settings);
@@ -3791,7 +3791,7 @@ const controlHasAssociatedLabel = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$46(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXElement(node) {
 			if (isTestlikeFile) return;
 			const opening = node.openingElement;
@@ -8423,6 +8423,7 @@ const jsTosortedImmutable = defineRule({
 	id: "js-tosorted-immutable",
 	tags: ["test-noise"],
 	severity: "warn",
+	disabledBy: ["react-native"],
 	recommendation: "Use `array.toSorted()` (ES2023) instead of `[...array].sort()` for immutable sorting without the spread allocation",
 	create: (context) => ({ CallExpression(node) {
 		if (!isMemberProperty(node.callee, "sort")) return;
@@ -8711,7 +8712,7 @@ const jsxFilenameExtension = defineRule({
 		const settings = resolveSettings$34(context.settings);
 		const allowedExtensions = normalizeExtensions(settings.extensions);
 		const allowedList = [...allowedExtensions].map((extension) => `.${extension}`).join(", ");
-		const filename = context.getFilename ? normalizeFilename$1(context.getFilename()) : "fixture.tsx";
+		const filename = normalizeFilename$1(context.filename ?? "fixture.tsx");
 		const extensionOnly = path.extname(filename).slice(1);
 		const fileHasAllowedExtension = allowedExtensions.has(extensionOnly);
 		let didReportMismatch = false;
@@ -9495,7 +9496,7 @@ const jsxNoConstructedContextValues = defineRule({
 	recommendation: "Memoize the context value (`useMemo`) or hoist it outside the render.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			if (!isProviderName(node.name)) return;
@@ -9841,7 +9842,7 @@ const jsxNoJsxAsProp = defineRule({
 	recommendation: "Hoist the inner JSX outside the render or memoize via `useMemo`.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -10212,7 +10213,7 @@ const jsxNoNewArrayAsProp = defineRule({
 	recommendation: "Memoize the array (`useMemo`) or hoist it outside the component.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -10674,7 +10675,7 @@ const jsxNoNewFunctionAsProp = defineRule({
 	recommendation: "Memoize the callback (`useCallback`) or hoist it outside the component.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -10980,7 +10981,7 @@ const jsxNoNewObjectAsProp = defineRule({
 	recommendation: "Memoize the object (`useMemo`) or hoist it outside the component.",
 	category: "Performance",
 	create: (context) => {
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		let memoRegistry = null;
 		return {
 			Program(node) {
@@ -11785,7 +11786,7 @@ const labelHasAssociatedControl = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$24(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXElement(node) {
 			if (isTestlikeFile) return;
 			const opening = node.openingElement;
@@ -12323,7 +12324,7 @@ const nextjsMissingMetadata = defineRule({
 	severity: "warn",
 	recommendation: "Add `export const metadata = { title: '...', description: '...' }` or `export async function generateMetadata()`",
 	create: (context) => ({ Program(programNode) {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!PAGE_FILE_PATTERN.test(filename)) return;
 		if (INTERNAL_PAGE_PATH_PATTERN.test(filename)) return;
 		if (!programNode.body?.some((statement) => {
@@ -12388,7 +12389,7 @@ const nextjsNoClientFetchForServerData = defineRule({
 				if (!fileHasUseClient || !isHookCall$1(node, EFFECT_HOOK_NAMES$1)) return;
 				const callback = getEffectCallback(node);
 				if (!callback || !containsFetchCall(callback)) return;
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (PAGE_OR_LAYOUT_FILE_PATTERN.test(filename) || PAGES_DIRECTORY_PATTERN.test(filename)) context.report({
 					node,
 					message: "useEffect + fetch in a page/layout — fetch data server-side with a server component instead"
@@ -12421,7 +12422,7 @@ const nextjsNoClientSideRedirect = defineRule({
 	severity: "warn",
 	recommendation: "Avoid redirects inside useEffect. Use an event handler, middleware, or server-side redirect (App Router: redirect() from next/navigation; Pages Router: getServerSideProps redirect)",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const isPagesRouterFile = PAGES_DIRECTORY_PATTERN.test(filename);
 		return { CallExpression(node) {
 			if (!isHookCall$1(node, EFFECT_HOOK_NAMES$1)) return;
@@ -12490,7 +12491,7 @@ const nextjsNoHeadImport = defineRule({
 	recommendation: "Use the Metadata API instead: `export const metadata = { title: '...' }` or `export async function generateMetadata()`",
 	create: (context) => ({ ImportDeclaration(node) {
 		if (node.source?.value !== "next/head") return;
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!APP_DIRECTORY_PATTERN.test(filename)) return;
 		context.report({
 			node,
@@ -12507,7 +12508,7 @@ const nextjsNoImgElement = defineRule({
 	severity: "warn",
 	recommendation: "`import Image from 'next/image'` — provides automatic WebP/AVIF, lazy loading, and responsive srcset",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const isOgRoute = OG_ROUTE_PATTERN.test(filename);
 		return { JSXOpeningElement(node) {
 			if (isOgRoute) return;
@@ -12861,7 +12862,7 @@ const nextjsNoSideEffectInGetHandler = defineRule({
 				resolveBinding = buildProgramBindingLookup(node);
 			},
 			ExportNamedDeclaration(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!ROUTE_HANDLER_FILE_PATTERN.test(filename)) return;
 				if (CRON_ROUTE_PATTERN.test(filename)) return;
 				if (!isExportedGetHandler(node)) return;
@@ -14093,7 +14094,7 @@ const noAutofocus = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$21(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			const autoFocusAttribute = node.attributes.find((attribute) => {
@@ -14467,7 +14468,7 @@ const noBarrelImport = defineRule({
 			if (didReportForFile) return;
 			const source = node.source?.value;
 			if (typeof source !== "string" || !source.startsWith(".")) return;
-			const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+			const filename = normalizeFilename$1(context.filename ?? "");
 			if (!filename) return;
 			const importRequests = getRuntimeImportRequests(node);
 			if (importRequests.length === 0) return;
@@ -18246,7 +18247,7 @@ const noMultiComp = defineRule({
 	category: "Architecture",
 	create: (context) => {
 		const settings = resolveSettings$16(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { Program(node) {
 			if (isTestlikeFile) return;
 			const visitContext = {
@@ -20193,7 +20194,7 @@ const noSecretsInClientCode = defineRule({
 	severity: "warn",
 	recommendation: "Move secrets to server-only code. Public client environment variables are bundled into browser code and must not contain secrets",
 	create: (context) => {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		const framework = getReactDoctorStringSetting(context.settings, "framework");
 		const rootDirectory = getReactDoctorStringSetting(context.settings, "rootDirectory");
 		let shouldUseVariableNameHeuristic = classifySecretFileExposure(filename, {
@@ -20448,7 +20449,7 @@ const noStaticElementInteractions = defineRule({
 	category: "Accessibility",
 	create: (context) => {
 		const settings = resolveSettings$12(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return { JSXOpeningElement(node) {
 			if (isTestlikeFile) return;
 			let hasNonBlockerHandler = false;
@@ -20525,7 +20526,7 @@ const noStringRefs = defineRule({
 	recommendation: "Use a callback ref (`ref={(node) => { this.foo = node }}`) or `useRef` instead of string refs.",
 	create: (context) => {
 		const { noTemplateLiterals = false } = resolveSettings$11(context.settings);
-		const isTestlikeFile = isTestlikeFilename(context.getFilename?.());
+		const isTestlikeFile = isTestlikeFilename(context.filename);
 		return {
 			JSXAttribute(node) {
 				if (isTestlikeFile) return;
@@ -22671,7 +22672,7 @@ const onlyExportComponents = defineRule({
 			allowConstantExport: settings.allowConstantExport
 		};
 		return { Program(node) {
-			if (!isFileNameAllowed(context.getFilename ? normalizeFilename$1(context.getFilename()) : void 0, settings.checkJS)) return;
+			if (!isFileNameAllowed(normalizeFilename$1(context.filename ?? ""), settings.checkJS)) return;
 			const allNodes = collectAllNodes(node);
 			const exports = [];
 			let hasReactExport = false;
@@ -24192,7 +24193,7 @@ const renderingSvgPrecision = defineRule({
 	category: "Performance",
 	recommendation: "Truncate path/points/transform decimals to 1–2 digits — sub-pixel precision adds bytes with no visible difference",
 	create: (context) => {
-		const filename = context.getFilename?.();
+		const filename = context.filename;
 		const isAutoGenerated = isAutoGeneratedSvgFile(filename ? normalizeFilename$1(filename) : void 0);
 		return { JSXAttribute(node) {
 			if (isAutoGenerated) return;
@@ -25524,7 +25525,8 @@ const classifyPackagePlatform = (filename) => {
 //#endregion
 //#region src/plugin/utils/is-expo-managed-file.ts
 const isExpoManagedFileActive = (context) => {
-	const filename = context.getFilename?.() ? normalizeFilename$1(context.getFilename()) : void 0;
+	const rawFilename = context.filename;
+	const filename = rawFilename ? normalizeFilename$1(rawFilename) : void 0;
 	if (filename) {
 		const packagePlatform = classifyPackagePlatform(filename);
 		if (packagePlatform === "expo") return true;
@@ -30692,7 +30694,7 @@ const serverFetchWithoutRevalidate = defineRule({
 		let isServerSideFile = false;
 		return {
 			Program(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!APP_ROUTER_FILE_PATTERN.test(filename)) {
 					isServerSideFile = false;
 					return;
@@ -30805,7 +30807,7 @@ const serverHoistStaticIo = defineRule({
 			inspectHandlerBody(context, declaration.body, `${handlerName} route handler`, collectIdentifierParams(declaration.params ?? []));
 		},
 		ExportDefaultDeclaration(node) {
-			const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+			const filename = normalizeFilename$1(context.filename ?? "");
 			if (!PAGES_ROUTER_API_PATH_PATTERN.test(filename)) return;
 			const declaration = node.declaration;
 			if (!declaration || !isNodeOfType(declaration, "FunctionDeclaration") && !isNodeOfType(declaration, "FunctionExpression") && !isNodeOfType(declaration, "ArrowFunctionExpression")) return;
@@ -31356,7 +31358,7 @@ const tanstackStartMissingHeadContent = defineRule({
 		};
 		return {
 			Program(node) {
-				const filename = context.getFilename?.() ?? "";
+				const filename = context.filename ?? "";
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				const statements = node.body ?? [];
 				for (const statement of statements) collectImportBindings(statement);
@@ -31366,17 +31368,17 @@ const tanstackStartMissingHeadContent = defineRule({
 				}
 			},
 			ImportDeclaration(node) {
-				const filename = context.getFilename?.() ?? "";
+				const filename = context.filename ?? "";
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				collectImportBindings(node);
 			},
 			VariableDeclarator(node) {
-				const filename = context.getFilename?.() ?? "";
+				const filename = context.filename ?? "";
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				collectVariableAlias(node);
 			},
 			JSXOpeningElement(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isNodeOfType(node.name, "JSXIdentifier")) {
 					if (node.name.name === DOCUMENT_HEAD_ELEMENT_NAME) hasDocumentHeadElement = true;
@@ -31391,7 +31393,7 @@ const tanstackStartMissingHeadContent = defineRule({
 				if (isInsideDocumentHeadElement(node) && isCustomJsxElementName(node.name)) hasCustomHeadChildElement = true;
 			},
 			"Program:exit"(programNode) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROOT_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (hasDocumentHeadElement && !hasHeadContentElement && !hasCustomHeadChildElement) context.report({
 					node: programNode,
@@ -31410,7 +31412,7 @@ const tanstackStartNoAnchorElement = defineRule({
 	severity: "warn",
 	recommendation: "`import { Link } from '@tanstack/react-router'` — enables type-safe routes, preloading via `preload=\"intent\"`, and client-side navigation",
 	create: (context) => ({ JSXOpeningElement(node) {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 		if (!isNodeOfType(node.name, "JSXIdentifier") || node.name.name !== "a") return;
 		const hrefAttribute = (node.attributes ?? []).find((attribute) => isNodeOfType(attribute, "JSXAttribute") && isNodeOfType(attribute.name, "JSXIdentifier") && attribute.name.name === "href");
@@ -31484,7 +31486,7 @@ const tanstackStartNoNavigateInRender = defineRule({
 		const isEventHandlerAttribute = (node) => isNodeOfType(node, "JSXAttribute") && isNodeOfType(node.name, "JSXIdentifier") && typeof node.name.name === "string" && node.name.name.startsWith("on") && UPPERCASE_PATTERN.test(node.name.name.charAt(2));
 		return {
 			CallExpression(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isDeferredHookCall(node)) deferredCallbackDepth++;
 				if (deferredCallbackDepth > 0 || eventHandlerDepth > 0) return;
@@ -31494,17 +31496,17 @@ const tanstackStartNoNavigateInRender = defineRule({
 				});
 			},
 			"CallExpression:exit"(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isDeferredHookCall(node)) deferredCallbackDepth = Math.max(0, deferredCallbackDepth - 1);
 			},
 			JSXAttribute(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isEventHandlerAttribute(node)) eventHandlerDepth++;
 			},
 			"JSXAttribute:exit"(node) {
-				const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+				const filename = normalizeFilename$1(context.filename ?? "");
 				if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 				if (isEventHandlerAttribute(node)) eventHandlerDepth = Math.max(0, eventHandlerDepth - 1);
 			}
@@ -31585,7 +31587,7 @@ const tanstackStartNoUseEffectFetch = defineRule({
 	severity: "warn",
 	recommendation: "Fetch data in the route `loader` instead — the router coordinates loading before rendering to avoid waterfalls",
 	create: (context) => ({ CallExpression(node) {
-		const filename = normalizeFilename$1(context.getFilename?.() ?? "");
+		const filename = normalizeFilename$1(context.filename ?? "");
 		if (!TANSTACK_ROUTE_FILE_PATTERN.test(filename)) return;
 		if (!isHookCall$1(node, EFFECT_HOOK_NAMES$1)) return;
 		const callback = node.arguments?.[0];
@@ -35254,7 +35256,7 @@ const ruleRegistry = Object.fromEntries(reactDoctorRules.map((rule) => [rule.id,
 const WEB_FILE_EXTENSION_PATTERN = /\.web\.[cm]?[jt]sx?$/;
 const NATIVE_FILE_EXTENSION_PATTERN = /\.(?:ios|android|native)\.[cm]?[jt]sx?$/;
 const isReactNativeFileActive = (context) => {
-	const rawFilename = context.getFilename?.();
+	const rawFilename = context.filename;
 	if (!rawFilename) return true;
 	const filename = normalizeFilename$1(rawFilename);
 	if (NATIVE_FILE_EXTENSION_PATTERN.test(filename)) return true;
@@ -35742,7 +35744,9 @@ const wrapWithSemanticContext = (rule) => ({
 		};
 		const enrichedContext = {
 			report: baseContext.report,
-			getFilename: baseContext.getFilename,
+			get filename() {
+				return baseContext.filename ?? baseContext.getFilename?.();
+			},
 			settings: baseContext.settings,
 			get scopes() {
 				return getScopes();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-react-doctor",
-  "version": "0.2.10",
+  "version": "0.2.11",
   "description": "oxlint plugin for React Doctor: diagnose React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",