oxlint-plugin-effect 0.4.0 → 0.5.1

package/README.md

@@ -25,19 +25,20 @@ If the project uses JSON configuration, copy the exported rule map into `rules`;
 
 ## Recommended Rules
 
-| Rule                         | Contract                                                                                  |
-| ---------------------------- | ----------------------------------------------------------------------------------------- |
-| `effect/noAsyncFunction`     | Bans async functions and await expressions                                                |
-| `effect/noTryCatch`          | Bans every try/catch/finally statement                                                    |
-| `effect/noThrowStatement`    | Bans every throw statement                                                                |
-| `effect/noNewPromise`        | Bans new Promise, Promise calls, and Promise static APIs                                  |
-| `effect/noNewError`          | Allows native Error values only as direct arguments to Effect.die, Cause.die, or Exit.die |
-| `effect/noTernary`           | Bans conditional expressions while allowing ordinary if statements                        |
-| `effect/noDynamicImports`    | Allows import() only behind a named lazy-loading boundary; bans require()                 |
-| `effect/noEffectDo`          | Bans Effect.Do                                                                            |
-| `effect/noEffectBind`        | Bans Effect.bind                                                                          |
-| `effect/noGlobals`           | Bans ambient capabilities with direct Effect replacements                                 |
-| `effect/noNodeBuiltinImport` | Bans fully replaced Node modules and replaced operations from partial modules             |
+| Rule                          | Contract                                                                                  |
+| ----------------------------- | ----------------------------------------------------------------------------------------- |
+| `effect/noAsyncFunction`      | Bans async functions and await expressions                                                |
+| `effect/noTryCatch`           | Bans every try/catch/finally statement                                                    |
+| `effect/noTestLifecycleHooks` | Bans `beforeEach`, `afterEach`, `beforeAll`, and `afterAll`; use Effect scopes instead    |
+| `effect/noThrowStatement`     | Bans every throw statement                                                                |
+| `effect/noNewPromise`         | Bans new Promise, Promise calls, and Promise static APIs                                  |
+| `effect/noNewError`           | Allows native Error values only as direct arguments to Effect.die, Cause.die, or Exit.die |
+| `effect/noTernary`            | Bans conditional expressions while allowing ordinary if statements                        |
+| `effect/noDynamicImports`     | Allows import() only behind a named lazy-loading boundary; bans require()                 |
+| `effect/noEffectDo`           | Bans Effect.Do                                                                            |
+| `effect/noEffectBind`         | Bans Effect.bind                                                                          |
+| `effect/noGlobals`            | Bans ambient capabilities with direct Effect replacements; allows `process.std*.isTTY`    |
+| `effect/noNodeBuiltinImport`  | Bans fully replaced Node modules and replaced operations from partial modules             |
 
 The preset intentionally allows `Effect.as`, `Option.as`, `Effect.never`, `Effect.async`, ordinary `if` and `switch` statements, and runtime runners at explicit application boundaries.
 

package/dist/presets/recommended.d.ts

@@ -10,6 +10,7 @@ declare const recommended: {
   readonly "effect/noNewPromise": "error";
   readonly "effect/noNodeBuiltinImport": "error";
   readonly "effect/noTernary": "error";
+  readonly "effect/noTestLifecycleHooks": "error";
   readonly "effect/noThrowStatement": "error";
   readonly "effect/noTryCatch": "error";
 };

package/dist/presets/recommended.js

@@ -10,6 +10,7 @@ const recommended = {
 	"effect/noNewPromise": "error",
 	"effect/noNodeBuiltinImport": "error",
 	"effect/noTernary": "error",
+	"effect/noTestLifecycleHooks": "error",
 	"effect/noThrowStatement": "error",
 	"effect/noTryCatch": "error"
 };

package/dist/rules/index.d.ts

@@ -7,12 +7,13 @@ import { noNewError } from "./no-new-error.js";
 import { noNewPromise } from "./no-new-promise.js";
 import { noNodeBuiltinImport } from "./no-node-builtin-import.js";
 import { noTernary } from "./no-ternary.js";
+import { noTestLifecycleHooks } from "./no-test-lifecycle-hooks.js";
 import { noThrowStatement } from "./no-throw-statement.js";
 import { noTryCatch } from "./no-try-catch.js";
 
 //#region src/rules/index.d.ts
 declare namespace index_d_exports {
-  export { noAsyncFunction, noDynamicImports, noEffectBind, noEffectDo, noGlobals, noNewError, noNewPromise, noNodeBuiltinImport, noTernary, noThrowStatement, noTryCatch };
+  export { noAsyncFunction, noDynamicImports, noEffectBind, noEffectDo, noGlobals, noNewError, noNewPromise, noNodeBuiltinImport, noTernary, noTestLifecycleHooks, noThrowStatement, noTryCatch };
 }
 //#endregion
-export { index_d_exports, noAsyncFunction, noDynamicImports, noEffectBind, noEffectDo, noGlobals, noNewError, noNewPromise, noNodeBuiltinImport, noTernary, noThrowStatement, noTryCatch };
+export { index_d_exports, noAsyncFunction, noDynamicImports, noEffectBind, noEffectDo, noGlobals, noNewError, noNewPromise, noNodeBuiltinImport, noTernary, noTestLifecycleHooks, noThrowStatement, noTryCatch };

package/dist/rules/index.js

@@ -8,6 +8,7 @@ import { noNewError } from "./no-new-error.js";
 import { noNewPromise } from "./no-new-promise.js";
 import { noNodeBuiltinImport } from "./no-node-builtin-import.js";
 import { noTernary } from "./no-ternary.js";
+import { noTestLifecycleHooks } from "./no-test-lifecycle-hooks.js";
 import { noThrowStatement } from "./no-throw-statement.js";
 import { noTryCatch } from "./no-try-catch.js";
 //#region src/rules/index.ts
@@ -21,8 +22,9 @@ var rules_exports = /* @__PURE__ */ __exportAll({
 	noNewPromise: () => noNewPromise,
 	noNodeBuiltinImport: () => noNodeBuiltinImport,
 	noTernary: () => noTernary,
+	noTestLifecycleHooks: () => noTestLifecycleHooks,
 	noThrowStatement: () => noThrowStatement,
 	noTryCatch: () => noTryCatch
 });
 //#endregion
-export { noAsyncFunction, noDynamicImports, noEffectBind, noEffectDo, noGlobals, noNewError, noNewPromise, noNodeBuiltinImport, noTernary, noThrowStatement, noTryCatch, rules_exports };
+export { noAsyncFunction, noDynamicImports, noEffectBind, noEffectDo, noGlobals, noNewError, noNewPromise, noNodeBuiltinImport, noTernary, noTestLifecycleHooks, noThrowStatement, noTryCatch, rules_exports };

package/dist/rules/no-globals.js

@@ -148,6 +148,16 @@ const isUnshadowedGlobal = (ctx, node, name) => Option.match(findVariableUp(ctx.
 	onSome: (variable) => variable.defs.length === 0
 });
 const staticMember = (node) => Option.getOrUndefined(memberNames(node));
+const processStreams = new Set([
+	"stderr",
+	"stdin",
+	"stdout"
+]);
+const isTtyRead = (node) => {
+	const parent = node.parent;
+	if (parent?.type !== "MemberExpression" || parent.computed) return false;
+	return parent.object === node && parent.property.type === "Identifier" && parent.property.name === "isTTY";
+};
 const isCryptoDigest = (node) => {
 	if (node.computed || node.property.type !== "Identifier" || node.property.name !== "digest") return false;
 	const object = node.object;
@@ -175,7 +185,10 @@ const noGlobals = define({
 				if (names === void 0) return Effect.void;
 				const [object, property] = names;
 				if (!isUnshadowedGlobal(ctx, memberExpression, object)) return Effect.void;
-				for (const [bannedObject, properties, alternative] of memberBans) if (object === bannedObject && properties.has(property)) return report(memberExpression, `${object}.${property}`, alternative);
+				for (const [bannedObject, properties, alternative] of memberBans) if (object === bannedObject && properties.has(property)) {
+					if (object === "process" && processStreams.has(property) && isTtyRead(memberExpression)) return Effect.void;
+					return report(memberExpression, `${object}.${property}`, alternative);
+				}
 				return Effect.void;
 			},
 			CallExpression: (node) => {

package/dist/rules/no-test-lifecycle-hooks.d.ts

@@ -0,0 +1,6 @@
+import * as _$_oxlint_plugins0 from "@oxlint/plugins";
+
+//#region src/rules/no-test-lifecycle-hooks.d.ts
+declare const noTestLifecycleHooks: _$_oxlint_plugins0.CreateRule;
+//#endregion
+export { noTestLifecycleHooks };

package/dist/rules/no-test-lifecycle-hooks.js

@@ -0,0 +1,37 @@
+import { calleeName, narrow } from "../vendor/effect-oxlint/AST.js";
+import { make } from "../vendor/effect-oxlint/Diagnostic.js";
+import { RuleContext } from "../vendor/effect-oxlint/RuleContext.js";
+import { define, meta } from "../vendor/effect-oxlint/Rule.js";
+import "../vendor/effect-oxlint/index.js";
+import * as Option from "effect/Option";
+import * as Effect from "effect/Effect";
+//#region src/rules/no-test-lifecycle-hooks.ts
+const lifecycleHooks = new Set([
+	"afterAll",
+	"afterEach",
+	"beforeAll",
+	"beforeEach"
+]);
+const noTestLifecycleHooks = define({
+	name: "no-test-lifecycle-hooks",
+	meta: meta({
+		type: "problem",
+		description: "Model test fixtures with Effect scopes instead of lifecycle hooks."
+	}),
+	create: function* () {
+		const ctx = yield* RuleContext;
+		return { CallExpression: (node) => Option.match(narrow(node, "CallExpression"), {
+			onNone: () => Effect.void,
+			onSome: (call) => {
+				const name = Option.getOrUndefined(calleeName(call));
+				if (name === void 0 || !lifecycleHooks.has(name)) return Effect.void;
+				return ctx.report(make({
+					node: call,
+					message: `Avoid ${name}(). Use effect-bun-test scoped tests and Effect.acquireRelease for fixture lifecycles.`
+				}));
+			}
+		}) };
+	}
+});
+//#endregion
+export { noTestLifecycleHooks };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-effect",
-  "version": "0.4.0",
+  "version": "0.5.1",
   "description": "oxlint plugin with Effect-specific lint rules",
   "license": "MIT",
   "repository": {