oxlint-plugin-effect 0.2.0 → 0.2.2

package/tests/context-rules.test.ts

@@ -1,263 +0,0 @@
-import { describe, test, expect } from "bun:test"
-import { Testing } from "../src/vendor/effect-oxlint/index.js"
-import {
-  noGlobals,
-  noThrowStatement,
-  noTryCatch,
-  noNewPromise,
-  noNewError,
-  noReturnNullish,
-  noRunInEffectGen,
-} from "../src/rules/index.js"
-
-// Helper: simulate entering and exiting Effect.gen context
-const effectGenNode = Testing.callOfMember("Effect", "gen", [])
-
-// --- Global Effect-enforcing rules (fire everywhere) ---
-
-describe("noThrowStatement", () => {
-  test("reports throw", () => {
-    const result = Testing.runRule(noThrowStatement, "ThrowStatement", Testing.throwStmt())
-    expect(result.length).toBe(1)
-  })
-})
-
-describe("noTryCatch", () => {
-  test("reports try/catch", () => {
-    const result = Testing.runRule(noTryCatch, "TryStatement", Testing.tryStmt())
-    expect(result.length).toBe(1)
-  })
-})
-
-describe("noNewPromise", () => {
-  test("reports new Promise()", () => {
-    const result = Testing.runRule(noNewPromise, "NewExpression", Testing.newExpr("Promise"))
-    expect(result.length).toBe(1)
-  })
-})
-
-describe("noNewError", () => {
-  test("reports new Error()", () => {
-    const result = Testing.runRule(noNewError, "NewExpression", Testing.newExpr("Error"))
-    expect(result.length).toBe(1)
-  })
-
-  test("reports new TypeError()", () => {
-    const result = Testing.runRule(noNewError, "NewExpression", Testing.newExpr("TypeError"))
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores new MyError()", () => {
-    const result = Testing.runRule(noNewError, "NewExpression", Testing.newExpr("MyError"))
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noReturnNullish", () => {
-  test("reports return null", () => {
-    const node = {
-      type: "ReturnStatement",
-      argument: { type: "Literal", value: null },
-    } as never
-    const result = Testing.runRule(noReturnNullish, "ReturnStatement", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("reports return undefined", () => {
-    const node = {
-      type: "ReturnStatement",
-      argument: { type: "Identifier", name: "undefined" },
-    } as never
-    const result = Testing.runRule(noReturnNullish, "ReturnStatement", node)
-    expect(result.length).toBe(1)
-  })
-})
-
-// --- Effect-context rules (inside Effect.gen/fn only) ---
-
-describe("noGlobals", () => {
-  test("reports console.log inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("console", "log")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports fetch() inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callExpr("fetch")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports Date.now inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("Date", "now")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports new Date() inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["NewExpression", Testing.newExpr("Date")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports Math.random inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("Math", "random")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports setTimeout inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callExpr("setTimeout")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports JSON.parse inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("JSON", "parse")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports process.env inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("process", "env")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports process.exit with hint", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("process", "exit")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectDiagnostics(result, [{
-      message: "Avoid process.exit inside Effect context. Use Effect.fail or Effect.die.",
-    }])
-  })
-
-  test("reports Bun.file with FileSystem hint", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("Bun", "file")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectDiagnostics(result, [{
-      message: "Avoid Bun.file inside Effect context. Use FileSystem from 'effect'.",
-    }])
-  })
-
-  test("reports Deno.readFile with FileSystem hint", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("Deno", "readFile")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectDiagnostics(result, [{
-      message: "Avoid Deno.readFile inside Effect context. Use FileSystem from 'effect'.",
-    }])
-  })
-
-  test("ignores console.log outside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["MemberExpression", Testing.memberExpr("console", "log")],
-    ])
-    Testing.expectNoDiagnostics(result)
-  })
-
-  test("ignores Effect.succeed inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noGlobals, [
-      ["CallExpression", effectGenNode],
-      ["MemberExpression", Testing.memberExpr("Effect", "succeed")],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noRunInEffectGen", () => {
-  test("reports Effect.runPromise inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callOfMember("Effect", "runPromise", [Testing.id("x")])],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports Effect.runFork inside Effect.fn", () => {
-    const effectFnNode = Testing.callOfMember("Effect", "fn", [])
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", effectFnNode],
-      ["CallExpression", Testing.callOfMember("Effect", "runFork", [Testing.id("x")])],
-      ["CallExpression:exit", effectFnNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("reports Runtime.runFork inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callOfMember("Runtime", "runFork", [Testing.id("x")])],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores Effect.runForkWith inside Effect.gen (legit v4 callback boundary)", () => {
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callOfMember("Effect", "runForkWith", [Testing.id("services")])],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectNoDiagnostics(result)
-  })
-
-  test("ignores managedRuntime.runFork on identifier callee", () => {
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callOfMember("managedRuntime", "runFork", [Testing.id("x")])],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectNoDiagnostics(result)
-  })
-
-  test("ignores Effect.runPromise outside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", Testing.callOfMember("Effect", "runPromise", [Testing.id("x")])],
-    ])
-    Testing.expectNoDiagnostics(result)
-  })
-
-  test("ignores yield* child effect inside Effect.gen", () => {
-    const result = Testing.runRuleMulti(noRunInEffectGen, [
-      ["CallExpression", effectGenNode],
-      ["CallExpression", Testing.callOfMember("Effect", "succeed", [Testing.id("x")])],
-      ["CallExpression:exit", effectGenNode],
-    ])
-    Testing.expectNoDiagnostics(result)
-  })
-})

package/tests/pattern-rules.test.ts

@@ -1,247 +0,0 @@
-import { describe, test, expect } from "bun:test"
-import { Testing } from "../src/vendor/effect-oxlint/index.js"
-import {
-  noUnnecessaryPipe,
-  noEffectSucceedVoid,
-  noEffectMapVoid,
-  noEffectFnGenerator,
-  noExtendsNativeError,
-  noIifeWrapper,
-  noEffectSucceedString,
-  noFromNullableCoalesce,
-  noInstanceofSchema,
-  noNestedPipe,
-  noNestedEffectCall,
-  noPositionalLogError,
-} from "../src/rules/index.js"
-
-describe("noUnnecessaryPipe", () => {
-  test("reports pipe(x) with single arg", () => {
-    const node = Testing.callExpr("pipe", [Testing.id("myEffect")])
-    const result = Testing.runRule(noUnnecessaryPipe, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores pipe(x, f)", () => {
-    const node = Testing.callExpr("pipe", [Testing.id("myEffect"), Testing.id("mapFn")])
-    const result = Testing.runRule(noUnnecessaryPipe, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noEffectSucceedVoid", () => {
-  test("reports Effect.succeed(undefined)", () => {
-    const node = Testing.callOfMember("Effect", "succeed", [Testing.id("undefined")])
-    const result = Testing.runRule(noEffectSucceedVoid, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores Effect.succeed(42)", () => {
-    const node = Testing.callOfMember("Effect", "succeed", [Testing.numLiteral(42)])
-    const result = Testing.runRule(noEffectSucceedVoid, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noEffectMapVoid", () => {
-  test("reports Effect.map(() => undefined)", () => {
-    const fn = Testing.arrowFn(Testing.id("undefined"))
-    const node = Testing.callOfMember("Effect", "map", [fn])
-    const result = Testing.runRule(noEffectMapVoid, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("reports Effect.map(() => {})", () => {
-    const fn = Testing.arrowFn(Testing.blockStmt([]))
-    const node = Testing.callOfMember("Effect", "map", [fn])
-    const result = Testing.runRule(noEffectMapVoid, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-})
-
-describe("noEffectFnGenerator", () => {
-  test("reports Effect.fn(function*() {})", () => {
-    const gen = {
-      type: "FunctionExpression",
-      generator: true,
-      params: [],
-      body: Testing.blockStmt([]),
-    }
-    const node = Testing.callOfMember("Effect", "fn", [gen])
-    const result = Testing.runRule(noEffectFnGenerator, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores Effect.fn('name')", () => {
-    const node = Testing.callOfMember("Effect", "fn", [Testing.strLiteral("myFn")])
-    const result = Testing.runRule(noEffectFnGenerator, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noExtendsNativeError", () => {
-  test("reports class extends Error", () => {
-    const node = {
-      type: "ClassDeclaration",
-      superClass: Testing.id("Error"),
-      id: Testing.id("MyError"),
-      body: { type: "ClassBody", body: [] },
-    } as never
-    const result = Testing.runRule(noExtendsNativeError, "ClassDeclaration", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores class extends Schema.TaggedErrorClass", () => {
-    const node = {
-      type: "ClassDeclaration",
-      superClass: Testing.memberExpr("Schema", "TaggedErrorClass"),
-      id: Testing.id("MyError"),
-      body: { type: "ClassBody", body: [] },
-    } as never
-    const result = Testing.runRule(noExtendsNativeError, "ClassDeclaration", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noIifeWrapper", () => {
-  test("reports (() => expr)()", () => {
-    const node = {
-      type: "CallExpression",
-      callee: Testing.arrowFn(Testing.id("x")),
-      arguments: [],
-    } as never
-    const result = Testing.runRule(noIifeWrapper, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores normal calls", () => {
-    const result = Testing.runRule(noIifeWrapper, "CallExpression", Testing.callExpr("myFn"))
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noEffectSucceedString", () => {
-  test("reports Effect.succeed('done')", () => {
-    const node = Testing.callOfMember("Effect", "succeed", [Testing.strLiteral("done")])
-    const result = Testing.runRule(noEffectSucceedString, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores Effect.succeed(42)", () => {
-    const node = Testing.callOfMember("Effect", "succeed", [Testing.numLiteral(42)])
-    const result = Testing.runRule(noEffectSucceedString, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noFromNullableCoalesce", () => {
-  test("reports Option.fromNullable(x ?? null)", () => {
-    const coalesce = {
-      type: "LogicalExpression",
-      operator: "??",
-      left: Testing.id("x"),
-      right: { type: "Literal", value: null },
-    }
-    const node = Testing.callOfMember("Option", "fromNullable", [coalesce])
-    const result = Testing.runRule(noFromNullableCoalesce, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores Option.fromNullable(x)", () => {
-    const node = Testing.callOfMember("Option", "fromNullable", [Testing.id("x")])
-    const result = Testing.runRule(noFromNullableCoalesce, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noInstanceofSchema", () => {
-  test("reports instanceof check", () => {
-    const node = {
-      type: "BinaryExpression",
-      operator: "instanceof",
-      left: Testing.id("x"),
-      right: Testing.id("MySchema"),
-    } as never
-    const result = Testing.runRule(noInstanceofSchema, "BinaryExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores === check", () => {
-    const node = {
-      type: "BinaryExpression",
-      operator: "===",
-      left: Testing.id("x"),
-      right: Testing.id("y"),
-    } as never
-    const result = Testing.runRule(noInstanceofSchema, "BinaryExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noNestedPipe", () => {
-  test("reports pipe(pipe(x, f), g)", () => {
-    const innerPipe = Testing.callExpr("pipe", [Testing.id("x"), Testing.id("f")])
-    const outerPipe = Testing.callExpr("pipe", [innerPipe, Testing.id("g")])
-    const result = Testing.runRule(noNestedPipe, "CallExpression", outerPipe)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores flat pipe(x, f, g)", () => {
-    const node = Testing.callExpr("pipe", [Testing.id("x"), Testing.id("f"), Testing.id("g")])
-    const result = Testing.runRule(noNestedPipe, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noNestedEffectCall", () => {
-  test("reports Effect.map(Effect.flatMap(...))", () => {
-    const inner = Testing.callOfMember("Effect", "flatMap", [Testing.id("x")])
-    const outer = Testing.callOfMember("Effect", "map", [inner])
-    const result = Testing.runRule(noNestedEffectCall, "CallExpression", outer)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores flat Effect.map(x)", () => {
-    const node = Testing.callOfMember("Effect", "map", [Testing.id("x")])
-    const result = Testing.runRule(noNestedEffectCall, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})
-
-describe("noPositionalLogError", () => {
-  test("reports Effect.logWarning with two args", () => {
-    const node = Testing.callOfMember("Effect", "logWarning", [
-      Testing.strLiteral("something failed"),
-      Testing.id("error"),
-    ])
-    const result = Testing.runRule(noPositionalLogError, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("reports Effect.logError with two args", () => {
-    const node = Testing.callOfMember("Effect", "logError", [
-      Testing.strLiteral("fatal"),
-      Testing.id("err"),
-    ])
-    const result = Testing.runRule(noPositionalLogError, "CallExpression", node)
-    expect(result.length).toBe(1)
-  })
-
-  test("ignores Effect.log with single arg", () => {
-    const node = Testing.callOfMember("Effect", "log", [
-      Testing.strLiteral("hello"),
-    ])
-    const result = Testing.runRule(noPositionalLogError, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-
-  test("allows Cause as second arg", () => {
-    const causeArg = Testing.callOfMember("Cause", "fail", [Testing.id("error")])
-    const node = Testing.callOfMember("Effect", "logWarning", [
-      Testing.strLiteral("something failed"),
-      causeArg,
-    ])
-    const result = Testing.runRule(noPositionalLogError, "CallExpression", node)
-    Testing.expectNoDiagnostics(result)
-  })
-})

package/tsconfig.json

@@ -1,15 +0,0 @@
-{
-  "compilerOptions": {
-    "noUncheckedIndexedAccess": true,
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitOverride": true,
-    "noPropertyAccessFromIndexSignature": true,
-    "allowImportingTsExtensions": true,
-    "moduleDetection": "force",
-    "skipLibCheck": true,
-    "types": ["bun"],
-    "noEmit": true
-  },
-  "include": ["src/**/*.ts", "tests/**/*.ts"],
-  "exclude": ["node_modules"]
-}