oxlint-plugin-effect 0.15.0 → 0.16.1

package/README.md

@@ -21,7 +21,19 @@ export default {
 };
 ```
 
-If the project uses JSON configuration, copy the exported rule map into `rules`; every recommended rule has `error` severity. The complexity rules carry their limit as an option, `["error", { "max": 21 }]`.
+A JSON configuration extends the generated preset file. It loads the plugin and enables every recommended rule, so new rules arrive with each release:
+
+```jsonc
+{
+  "extends": ["./node_modules/oxlint-plugin-effect/presets/recommended.json"],
+  "rules": {
+    // Local choices override the preset.
+    "effect/noTernary": "off",
+  },
+}
+```
+
+Every recommended rule has `error` severity. The complexity rules carry their limit as an option, `["error", { "max": 21 }]`.
 
 ## Recommended Rules
 
@@ -55,8 +67,8 @@ If the project uses JSON configuration, copy the exported rule map into `rules`;
 | `effect/noEffectBind`                  | Bans Effect.bind                                                                          |
 | `effect/preferCatchTag`                | Replaces manual `_tag` predicates and `catchAll` dispatch with tagged recovery            |
 | `effect/preferEffectFn`                | Requires `Effect.fn` for a generator operation that adds a span                           |
-| `effect/preferMatchTagsExhaustive`     | Requires exhaustive `Match` for return-only `_tag` switches and if chains                 |
-| `effect/preferPredicateIsTagged`       | Replaces combined `_tag` comparisons with a named `Predicate` refinement                  |
+| `effect/preferMatchTagsExhaustive`     | Requires exhaustive `Match` for return-only `_tag` switches and if chains in Effect files |
+| `effect/preferPredicateIsTagged`       | Replaces combined `_tag` comparisons with a named `Predicate` refinement in Effect files  |
 | `effect/preferServiceOf`               | Checks inline Layer implementations through `Service.of`                                  |
 | `effect/requireNamedEffectFn`          | Requires stable names for `Effect.fn` operations                                          |
 | `effect/requireSuppressionReason`      | Requires lint, Effect, and TS suppressions to name their target and give a `--` reason    |
@@ -204,7 +216,7 @@ bun run codegen
 bun run add-rule -- no-example --dry-run
 ```
 
-`bun run codegen` owns both the rule export barrel and the recommended preset.
+`bun run codegen` owns the rule export barrel and both forms of the recommended preset: `src/presets/recommended.ts` and `presets/recommended.json`.
 `bun run gate` fails when either generated file is stale.
 
 ## License

package/dist/rules/_effect-namespaces.js

@@ -21,5 +21,10 @@ const visibleNamespaces = (ctx, node, namespaces) => new Set([...namespaces].fil
 })));
 const isStaticMember = (node, namespaces, property) => node.type === "MemberExpression" && !node.computed && node.object.type === "Identifier" && namespaces.has(node.object.name) && node.property.type === "Identifier" && node.property.name === property;
 const isStaticCall = (node, namespaces, property) => node.type === "CallExpression" && node.callee.type !== "Super" && isStaticMember(node.callee, namespaces, property);
+/** Whether an import loads the effect package, one of its subpaths, or an @effect package. */
+const isEffectPackageImport = (node) => {
+	const source = node.source.value;
+	return source === "effect" || source.startsWith("effect/") || source.startsWith("@effect/");
+};
 //#endregion
-export { importedNamespaces, isStaticCall, isStaticMember, visibleNamespaces };
+export { importedNamespaces, isEffectPackageImport, isStaticCall, isStaticMember, visibleNamespaces };

package/dist/rules/prefer-match-tags-exhaustive.js

@@ -2,6 +2,7 @@ import { make } from "../vendor/effect-oxlint/Diagnostic.js";
 import { RuleContext } from "../vendor/effect-oxlint/RuleContext.js";
 import { define, meta } from "../vendor/effect-oxlint/Rule.js";
 import "../vendor/effect-oxlint/index.js";
+import { isEffectPackageImport } from "./_effect-namespaces.js";
 import { hasOneTaggedSubject, isInsideCatchAllHandler, tagComparison, taggedSwitchSubject } from "./_tagged-control-flow.js";
 import * as Arr from "effect/Array";
 import * as Option from "effect/Option";
@@ -66,16 +67,21 @@ const preferMatchTagsExhaustive = define({
 	}),
 	create: function* () {
 		const context = yield* RuleContext;
+		const effectImports = /* @__PURE__ */ new Set();
 		return {
+			ImportDeclaration: (node) => {
+				if (isEffectPackageImport(node)) effectImports.add(node.source.value);
+				return Effect.void;
+			},
 			SwitchStatement: (node) => {
-				if (!isCompleteSwitchTransformation(node) || isInsideCatchAllHandler(node)) return Effect.void;
+				if (effectImports.size === 0 || !isCompleteSwitchTransformation(node) || isInsideCatchAllHandler(node)) return Effect.void;
 				return context.report(make({
 					node,
 					message: "Use Match.type with Match.tagsExhaustive so a new tagged variant requires a new case."
 				}));
 			},
 			IfStatement: (node) => {
-				if (!isCompleteIfTransformation(node) && !isCompleteSequentialIfTransformation(node) || isInsideCatchAllHandler(node)) return Effect.void;
+				if (effectImports.size === 0 || !isCompleteIfTransformation(node) && !isCompleteSequentialIfTransformation(node) || isInsideCatchAllHandler(node)) return Effect.void;
 				return context.report(make({
 					node,
 					message: "Use Match.type with Match.tagsExhaustive so a new tagged variant requires a new branch."

package/dist/rules/prefer-predicate-is-tagged.js

@@ -2,6 +2,7 @@ import { make } from "../vendor/effect-oxlint/Diagnostic.js";
 import { RuleContext } from "../vendor/effect-oxlint/RuleContext.js";
 import { define, meta } from "../vendor/effect-oxlint/Rule.js";
 import "../vendor/effect-oxlint/index.js";
+import { isEffectPackageImport } from "./_effect-namespaces.js";
 import { effectCallbackLocation, hasOneTaggedSubject, tagComparisonsInOr } from "./_tagged-control-flow.js";
 import * as Option from "effect/Option";
 import * as Effect from "effect/Effect";
@@ -19,16 +20,23 @@ const preferPredicateIsTagged = define({
 	}),
 	create: function* () {
 		const context = yield* RuleContext;
-		return { LogicalExpression: (node) => {
-			if (node.operator !== "||") return Effect.void;
-			if (node.parent?.type === "LogicalExpression" && node.parent.operator === "||") return Effect.void;
-			if (isCatchIfPredicate(node)) return Effect.void;
-			if (!Option.exists(tagComparisonsInOr(node), hasOneTaggedSubject)) return Effect.void;
-			return context.report(make({
-				node,
-				message: "Use a named Predicate refinement composed from Predicate.isTagged for multiple tags."
-			}));
-		} };
+		const effectImports = /* @__PURE__ */ new Set();
+		return {
+			ImportDeclaration: (node) => {
+				if (isEffectPackageImport(node)) effectImports.add(node.source.value);
+				return Effect.void;
+			},
+			LogicalExpression: (node) => {
+				if (effectImports.size === 0 || node.operator !== "||") return Effect.void;
+				if (node.parent?.type === "LogicalExpression" && node.parent.operator === "||") return Effect.void;
+				if (isCatchIfPredicate(node)) return Effect.void;
+				if (!Option.exists(tagComparisonsInOr(node), hasOneTaggedSubject)) return Effect.void;
+				return context.report(make({
+					node,
+					message: "Use a named Predicate refinement composed from Predicate.isTagged for multiple tags."
+				}));
+			}
+		};
 	}
 });
 //#endregion

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-effect",
-  "version": "0.15.0",
+  "version": "0.16.1",
   "description": "oxlint plugin with Effect-specific lint rules",
   "license": "MIT",
   "repository": {
@@ -9,6 +9,7 @@
   },
   "files": [
     "dist",
+    "presets",
     "THIRD_PARTY_NOTICES.md"
   ],
   "type": "module",
@@ -31,6 +32,7 @@
         "default": "./dist/vendor/effect-oxlint/index.js"
       }
     },
+    "./presets/recommended.json": "./presets/recommended.json",
     "./presets/*": {
       "import": {
         "types": "./dist/presets/*.d.ts",

package/presets/recommended.json

@@ -0,0 +1,58 @@
+{
+  "jsPlugins": ["oxlint-plugin-effect/plugin"],
+  "rules": {
+    "complexity": ["error", { "max": 21 }],
+    "effect/maxCognitiveComplexity": ["error", { "max": 21 }],
+    "effect/maxHalsteadDifficulty": ["error", { "max": 79 }],
+    "effect/noArrayFilterMap": "error",
+    "effect/noAs": "error",
+    "effect/noAsyncFunction": "error",
+    "effect/noChainedTypeAssertions": "error",
+    "effect/noConditionalEmptyObjectSpread": "error",
+    "effect/noDynamicImports": "error",
+    "effect/noEagerAcquire": "error",
+    "effect/noEffectBind": "error",
+    "effect/noEffectDo": "error",
+    "effect/noEffectRunInTests": "error",
+    "effect/noGlobals": "error",
+    "effect/noInlineProvide": "error",
+    "effect/noKnownValueWidening": "error",
+    "effect/noManagedRuntimeInEffect": "error",
+    "effect/noModuleLevelMutableState": "error",
+    "effect/noModuleMocks": "error",
+    "effect/noNestedEffectGen": "error",
+    "effect/noNewError": "error",
+    "effect/noNewPromise": "error",
+    "effect/noNodeBuiltinImport": "error",
+    "effect/noNullish": "error",
+    "effect/noObjectParameters": "error",
+    "effect/noPerCallCacheConstruction": "error",
+    "effect/noReduceAccumulatorCopy": "error",
+    "effect/noReflectApply": "error",
+    "effect/noReflectGet": "error",
+    "effect/noRunCollectOnUnboundedStream": "error",
+    "effect/noRuntimeTypeof": "error",
+    "effect/noSequentialEffectAll": "error",
+    "effect/noShapeInSymbolNames": "error",
+    "effect/noSilentCatchAll": "error",
+    "effect/noTernary": "error",
+    "effect/noTestGlobals": "error",
+    "effect/noTestLifecycleHooks": "error",
+    "effect/noThrowStatement": "error",
+    "effect/noTryCatch": "error",
+    "effect/noUnboundedConcurrency": "error",
+    "effect/noUnboundedRetry": "error",
+    "effect/noUnknownParameters": "error",
+    "effect/noUnknownReturns": "error",
+    "effect/noUnknownTypeAliases": "error",
+    "effect/noUnsafeDictionaryType": "error",
+    "effect/noWidenThenAssert": "error",
+    "effect/preferCatchTag": "error",
+    "effect/preferEffectFn": "error",
+    "effect/preferMatchTagsExhaustive": "error",
+    "effect/preferPredicateIsTagged": "error",
+    "effect/preferServiceOf": "error",
+    "effect/requireNamedEffectFn": "error",
+    "effect/requireSuppressionReason": "error"
+  }
+}