oxlint-plugin-effect 0.12.0 → 0.13.0

package/README.md

@@ -27,14 +27,14 @@ If the project uses JSON configuration, copy the exported rule map into `rules`;
 
 | Rule                                   | Contract                                                                                  |
 | -------------------------------------- | ----------------------------------------------------------------------------------------- |
-| `effect/noAs`                          | Bans TypeScript `as` assertions; use `satisfies`                                          |
+| `effect/noAs`                          | Bans TypeScript `as` assertions; use `satisfies` (`as const` is allowed)                  |
 | `effect/noAsyncFunction`               | Bans async functions and await expressions                                                |
 | `effect/noTryCatch`                    | Bans every try/catch/finally statement                                                    |
 | `effect/noTestLifecycleHooks`          | Bans `beforeEach`, `afterEach`, `beforeAll`, and `afterAll`; use Effect scopes instead    |
 | `effect/noThrowStatement`              | Bans every throw statement                                                                |
 | `effect/noNewPromise`                  | Bans new Promise, Promise calls, and Promise static APIs                                  |
 | `effect/noNewError`                    | Allows native Error values only as direct arguments to Effect.die, Cause.die, or Exit.die |
-| `effect/noNullish`                     | Bans null and undefined; use Option or a domain enum for richer state                     |
+| `effect/noNullish`                     | Bans null and undefined; permits `Object.create(null)` for prototype-free dictionaries   |
 | `effect/noModuleMocks`                 | Bans Vitest and Jest module mocks and method spies; use Effect service test layers        |
 | `effect/noTernary`                     | Bans conditional expressions while allowing ordinary if statements                        |
 | `effect/noManagedRuntimeInEffect`      | Keeps ManagedRuntime construction at non-Effect host boundaries                           |

package/dist/rules/no-as.js

@@ -1,21 +1,27 @@
+import { narrow } from "../vendor/effect-oxlint/AST.js";
 import { make } from "../vendor/effect-oxlint/Diagnostic.js";
 import { RuleContext } from "../vendor/effect-oxlint/RuleContext.js";
 import { define, meta } from "../vendor/effect-oxlint/Rule.js";
 import "../vendor/effect-oxlint/index.js";
+import * as Option from "effect/Option";
+import * as Effect from "effect/Effect";
 //#region src/rules/no-as.ts
-/** Ban TypeScript `as` assertions. */
+const isConstAssertion = (node) => Option.exists(narrow(node, "TSAsExpression"), ({ typeAnnotation }) => typeAnnotation.type === "TSTypeReference" && typeAnnotation.typeName.type === "Identifier" && typeAnnotation.typeName.name === "const");
 const noAs = define({
 	name: "no-as",
 	meta: meta({
 		type: "problem",
-		description: "Use satisfies instead of an as assertion."
+		description: "Use satisfies instead of an as assertion; `as const` is allowed."
 	}),
 	create: function* () {
 		const ctx = yield* RuleContext;
-		return { TSAsExpression: (node) => ctx.report(make({
-			node,
-			message: "Avoid as assertions. Use satisfies instead."
-		})) };
+		return { TSAsExpression: (node) => {
+			if (isConstAssertion(node)) return Effect.void;
+			return ctx.report(make({
+				node,
+				message: "Avoid as assertions. Use satisfies instead."
+			}));
+		} };
 	}
 });
 //#endregion

package/dist/rules/no-nullish.js

@@ -1,4 +1,4 @@
-import { narrow } from "../vendor/effect-oxlint/AST.js";
+import { isMember, narrow } from "../vendor/effect-oxlint/AST.js";
 import { make } from "../vendor/effect-oxlint/Diagnostic.js";
 import { RuleContext } from "../vendor/effect-oxlint/RuleContext.js";
 import { define, meta } from "../vendor/effect-oxlint/Rule.js";
@@ -8,6 +8,10 @@ import * as Option from "effect/Option";
 import * as Effect from "effect/Effect";
 //#region src/rules/no-nullish.ts
 const message = "Avoid null and undefined. Use Option for presence or absence. Use a domain enum when the state has more than two cases.";
+const isNullPrototypeArgument = (node) => {
+	const parent = node.parent;
+	return parent?.type === "CallExpression" && parent.arguments[0] === node && parent.callee.type === "MemberExpression" && isMember(parent.callee, "Object", "create");
+};
 const noNullish = define({
 	name: "no-nullish",
 	meta: meta({
@@ -33,7 +37,7 @@ const noNullish = define({
 			}),
 			Literal: (node) => Option.match(narrow(node, "Literal"), {
 				onNone: () => Effect.void,
-				onSome: (literal) => literal.value === null && !("regex" in literal) ? report(literal) : Effect.void
+				onSome: (literal) => literal.value === null && !("regex" in literal) && !isNullPrototypeArgument(literal) ? report(literal) : Effect.void
 			}),
 			TSNullKeyword: (node) => Option.match(narrow(node, "TSNullKeyword"), {
 				onNone: () => Effect.void,

package/dist/vendor/effect-oxlint/AST.js

@@ -211,4 +211,4 @@ const findAncestor = dual(2, (node, type) => {
 */
 const hasAncestor = dual(2, (node, type) => Option.isSome(findAncestor(node, type)));
 //#endregion
-export { AST_exports, calleeName, importSource, matchImport, matchMember, memberNames, narrow };
+export { AST_exports, calleeName, importSource, isMember, matchImport, matchMember, memberNames, narrow };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oxlint-plugin-effect",
-  "version": "0.12.0",
+  "version": "0.13.0",
   "description": "oxlint plugin with Effect-specific lint rules",
   "license": "MIT",
   "repository": {
@@ -61,8 +61,8 @@
     "@oxlint/plugins": "^1.64.0"
   },
   "devDependencies": {
-    "@changesets/changelog-github": "^0.7.0",
-    "@changesets/cli": "^2.31.0",
+    "@changesets/changelog-github": "^1.0.1",
+    "@changesets/cli": "^3.0.3",
     "@effect/language-service": "latest",
     "@effect/vitest": "latest",
     "@types/bun": "latest",