oxlint-plugin-effect 0.0.0 → 0.1.0

package/CHANGELOG.md

@@ -0,0 +1,37 @@
+# oxlint-plugin-effect
+
+## 0.1.0
+
+### Minor Changes
+
+- [`e1c49ed`](https://github.com/cevr/effect-oxlint/commit/e1c49ed4195de9df24c0e30196285ec29cfe5748) Thanks [@cevr](https://github.com/cevr)! - Major rule overhaul: add 16 Go type-aware rules, consolidate JS rules, enforce Effect model.
+
+  **JS plugin (59 rules, was 66):**
+
+  New rules:
+
+  - noCatchAllToMapError, noUnnecessaryPipeChain, noMultipleEffectProvide
+  - noSchemaUnionOfLiterals, noSchemaStructWithTag, noRedundantSchemaTagIdentifier
+  - noEffectMapFlatten, noGlobalErrorInFailure, noGlobalErrorInCatch
+  - noPositionalLogError (from agent session analysis — 57 violations)
+  - noReturnNullish (catches null, undefined, void 0 → points to Option.none())
+  - noGlobals (consolidated context rule — console, fetch, Date, Math.random, crypto, timers, JSON, process/Bun/Deno with per-API Effect alternative hints)
+
+  Removed 14 generic global bans (no-console, no-date, no-fetch, etc.) — these belong in oxlint built-in config, not an Effect plugin. Every removed rule has an Effect-context counterpart in noGlobals.
+
+  Restored 5 Effect-enforcing rules that prevent escaping the Effect model:
+
+  - noThrowStatement → "Use yield* Effect.fail() or yield* new MyError()"
+  - noTryCatch → "Use Effect.try / Effect.tryPromise"
+  - noNewPromise → "Use Effect.async / Effect.tryPromise / Effect.promise"
+  - noNewError → "Define class MyError extends Schema.TaggedErrorClass..."
+  - noReturnNullish → "Use Option.none() / Effect.void"
+
+  Redesigned Rule.banMultiple API with per-spec BanSpec discriminated union.
+  Promoted high-frequency agent violations from warn to error in core/full presets.
+
+  **Go binary (24 rules, was 8):**
+
+  - Layer/leak detection: missingEffectContext, missingEffectError, missingLayerContext, leakingRequirements, layerMergeAllWithDependencies
+  - Error hygiene: anyUnknownInError, unknownInEffectCatch
+  - Code quality: effectFnOpportunity, classSelfMismatch, fnImplicitAny, scopeInLayerEffect, strictProvide, unnecessaryFailYieldable, genericServices, overriddenSchemaConstructor, nonObjectServiceType

package/package.json

@@ -1,10 +1,13 @@
 {
   "name": "oxlint-plugin-effect",
-  "version": "0.0.0",
+  "version": "0.1.0",
   "type": "module",
   "description": "oxlint plugin with Effect-specific lint rules",
   "license": "MIT",
-  "repository": { "type": "git", "url": "https://github.com/cevr/effect-oxlint" },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/cevr/effect-oxlint"
+  },
   "exports": {
     ".": "./src/index.ts",
     "./plugin": "./src/plugin.ts",
@@ -23,9 +26,7 @@
     "test": "bun test",
     "gate": "concurrently -n type,style,test -c blue,yellow,green \"bun run typecheck\" \"bun run lint\" \"bun run test\"",
     "codegen": "bun run scripts/codegen.ts",
-    "add-rule": "bun run scripts/add-rule.ts",
-    "version": "changeset version",
-    "release": "changeset publish"
+    "add-rule": "bun run scripts/add-rule.ts"
   },
   "dependencies": {
     "@oxlint/plugins": "^1.60.0"
@@ -34,8 +35,6 @@
     "effect": ">=4.0.0-beta.49"
   },
   "devDependencies": {
-    "@changesets/changelog-github": "^0.6.0",
-    "@changesets/cli": "^2.30.0",
     "@effect/language-service": "latest",
     "@effect/vitest": "latest",
     "@types/bun": "latest",

package/src/presets/core.ts

@@ -1,5 +1,5 @@
 /**
- * Core preset — essential Effect rules without global bans.
+ * Core preset — essential Effect rules.
  * Good starting point for projects transitioning to Effect.
  */
 export const core = {
@@ -13,9 +13,9 @@ export const core = {
   // AST pattern rules
   "effect/noNestedPipe": "error",
   "effect/noNestedEffectGen": "error",
-  "effect/noUnnecessaryEffectGen": "warn",
-  "effect/noEffectSucceedVoid": "warn",
-  "effect/noEffectMapVoid": "warn",
+  "effect/noUnnecessaryEffectGen": "error",
+  "effect/noEffectSucceedVoid": "error",
+  "effect/noEffectMapVoid": "error",
   "effect/noUnnecessaryPipe": "warn",
   "effect/noEffectFnGenerator": "warn",
   "effect/noFlatmapLadder": "error",
@@ -23,14 +23,25 @@ export const core = {
   "effect/noIifeWrapper": "warn",
   "effect/noFromNullableCoalesce": "warn",
   "effect/noUnnecessaryArrowBlock": "warn",
-  "effect/noEffectGenAdapter": "warn",
+  "effect/noEffectGenAdapter": "error",
   "effect/noEffectSyncConsole": "error",
-  "effect/noArrowLadder": "warn",
+  "effect/noCatchAllToMapError": "error",
+  "effect/noUnnecessaryPipeChain": "error",
+  "effect/noMultipleEffectProvide": "error",
+  "effect/noSchemaUnionOfLiterals": "warn",
+  "effect/noSchemaStructWithTag": "warn",
+  "effect/noRedundantSchemaTagIdentifier": "warn",
+  "effect/noEffectMapFlatten": "warn",
+  "effect/noPositionalLogError": "error",
 
-  // Effect-context rules
-  "effect/noThrowInEffectGen": "error",
-  "effect/noTryCatchInEffectGen": "warn",
-  "effect/noConsoleInEffect": "warn",
-  "effect/noInlineRuntimeProvide": "warn",
-  "effect/noPlatformGlobals": "warn",
+  // Effect-enforcing bans (prevent escaping Effect model)
+  "effect/noThrowStatement": "error",
+  "effect/noTryCatch": "error",
+  "effect/noNewPromise": "error",
+  "effect/noNewError": "error",
+  "effect/noReturnNullish": "warn",
+
+  // Effect-context rules (inside Effect.gen/fn)
+  "effect/noGlobals": "error",
+  "effect/noInlineProvide": "error",
 } as const

package/src/presets/effect-native.ts

@@ -1,37 +1,30 @@
 /**
  * Effect-native preset — for codebases fully committed to Effect.
- * Bans all globals and builtins in favor of Effect platform services.
+ * All Effect-context rules at error. Enforces Effect platform services
+ * and tagged errors inside generators.
  */
 export const effectNative = {
-  // Global bans (everywhere)
-  "effect/noGlobalFetch": "error",
-  "effect/noGlobalConsole": "error",
-  "effect/noGlobalDate": "error",
-  "effect/noGlobalRandom": "error",
-  "effect/noGlobalTimers": "error",
-  "effect/noNewPromise": "error",
-  "effect/noNewError": "error",
-  "effect/noProcessEnv": "error",
+  // Global bans (everywhere, not just Effect context)
+  "effect/noAsyncFunction": "error",
   "effect/noNodeBuiltinImport": "error",
+
+  // Effect-enforcing bans
   "effect/noThrowStatement": "error",
   "effect/noTryCatch": "error",
-  "effect/noReturnNull": "error",
-  "effect/noJsonParse": "error",
+  "effect/noNewPromise": "error",
+  "effect/noNewError": "error",
+  "effect/noReturnNullish": "error",
+
+  // Effect-context
+  "effect/noGlobals": "error",
+  "effect/noInlineProvide": "error",
+
+  // Error hygiene
+  "effect/noGlobalErrorInFailure": "error",
+  "effect/noGlobalErrorInCatch": "error",
   "effect/noExtendsNativeError": "error",
-  "effect/noAsyncFunction": "error",
   "effect/noInstanceofSchema": "error",
-  "effect/noRuntimeRunFork": "error",
-  "effect/noDynamicImport": "error",
-  "effect/noSwitchStatement": "error",
-
-  // Effect-context (inside Effect.gen/fn)
-  "effect/noFetchInEffect": "error",
-  "effect/noDateInEffect": "error",
-  "effect/noRandomInEffect": "error",
-  "effect/noTimersInEffect": "error",
-  "effect/noJsonInEffect": "error",
-  "effect/noProcessEnvInEffect": "error",
-  "effect/noPlatformGlobals": "error",
+  "effect/noPositionalLogError": "error",
 
   // Type hygiene
   "effect/noEffectTypeAlias": "error",

package/src/presets/full.ts

@@ -1,5 +1,8 @@
 /**
- * Full preset — all rules enabled.
+ * Full preset — all Effect-specific rules enabled.
+ *
+ * Does NOT include generic JS rules (no-console, no-throw, etc.) —
+ * configure those via oxlint's built-in rules in .oxlintrc.json.
  */
 export const full = {
   // API bans
@@ -12,42 +15,20 @@ export const full = {
   "effect/noRuntimeRunFork": "error",
   "effect/noRunInEffect": "error",
 
-  // Global bans
-  "effect/noGlobalFetch": "warn",
-  "effect/noGlobalConsole": "warn",
-  "effect/noGlobalDate": "warn",
-  "effect/noGlobalRandom": "warn",
-  "effect/noGlobalTimers": "warn",
-  "effect/noNewPromise": "warn",
-  "effect/noNewError": "warn",
-  "effect/noProcessEnv": "warn",
-
-  // Import bans
+  // Global bans (everywhere, not just Effect context)
+  "effect/noAsyncFunction": "warn",
   "effect/noNodeBuiltinImport": "warn",
-  "effect/noDynamicImport": "error",
-
-  // Statement bans
-  "effect/noThrowStatement": "error",
-  "effect/noTryCatch": "warn",
-  "effect/noReturnNull": "warn",
-  "effect/noSwitchStatement": "warn",
-  "effect/noIfStatement": "off",
-  "effect/noTernary": "off",
-
-  // JSON
-  "effect/noJsonParse": "warn",
 
   // AST pattern rules
   "effect/noNestedPipe": "error",
   "effect/noNestedEffectGen": "error",
-  "effect/noUnnecessaryEffectGen": "warn",
-  "effect/noEffectSucceedVoid": "warn",
-  "effect/noEffectMapVoid": "warn",
+  "effect/noUnnecessaryEffectGen": "error",
+  "effect/noEffectSucceedVoid": "error",
+  "effect/noEffectMapVoid": "error",
   "effect/noUnnecessaryPipe": "warn",
-  "effect/noExtendsNativeError": "warn",
+  "effect/noExtendsNativeError": "error",
   "effect/noEffectFnGenerator": "warn",
-  "effect/noInstanceofSchema": "warn",
-  "effect/noAsyncFunction": "warn",
+  "effect/noInstanceofSchema": "error",
   "effect/noFlatmapLadder": "error",
   "effect/noNestedEffectCall": "error",
   "effect/noIifeWrapper": "warn",
@@ -55,7 +36,7 @@ export const full = {
   "effect/noEffectOrElseLadder": "warn",
   "effect/noFromNullableCoalesce": "warn",
   "effect/noUnnecessaryArrowBlock": "warn",
-  "effect/noEffectGenAdapter": "warn",
+  "effect/noEffectGenAdapter": "error",
   "effect/noEffectSyncConsole": "error",
   "effect/noEffectTypeAlias": "warn",
   "effect/noEffectWrapperAlias": "warn",
@@ -63,22 +44,27 @@ export const full = {
   "effect/noManualEffectChannels": "warn",
   "effect/noMatchVoidBranch": "warn",
   "effect/noOptionBooleanNormalization": "warn",
-  "effect/noReturnInArrow": "off",
-  "effect/noStringSentinelConst": "off",
   "effect/noEffectSyncWrapper": "off",
-  "effect/noArrowLadder": "warn",
   "effect/noMatchEffectBranch": "warn",
+  "effect/noCatchAllToMapError": "error",
+  "effect/noUnnecessaryPipeChain": "error",
+  "effect/noMultipleEffectProvide": "error",
+  "effect/noSchemaUnionOfLiterals": "warn",
+  "effect/noSchemaStructWithTag": "warn",
+  "effect/noRedundantSchemaTagIdentifier": "warn",
+  "effect/noEffectMapFlatten": "warn",
+  "effect/noGlobalErrorInFailure": "error",
+  "effect/noGlobalErrorInCatch": "error",
+  "effect/noPositionalLogError": "error",
+
+  // Effect-enforcing bans (prevent escaping Effect model)
+  "effect/noThrowStatement": "error",
+  "effect/noTryCatch": "error",
+  "effect/noNewPromise": "error",
+  "effect/noNewError": "error",
+  "effect/noReturnNullish": "warn",
 
-  // Effect-context rules
-  "effect/noThrowInEffectGen": "error",
-  "effect/noTryCatchInEffectGen": "warn",
-  "effect/noConsoleInEffect": "warn",
-  "effect/noFetchInEffect": "warn",
-  "effect/noDateInEffect": "warn",
-  "effect/noRandomInEffect": "warn",
-  "effect/noTimersInEffect": "warn",
-  "effect/noJsonInEffect": "warn",
-  "effect/noProcessEnvInEffect": "warn",
-  "effect/noPlatformGlobals": "warn",
-  "effect/noInlineRuntimeProvide": "warn",
+  // Effect-context rules (inside Effect.gen/fn)
+  "effect/noGlobals": "error",
+  "effect/noInlineProvide": "error",
 } as const

package/src/presets/functional.ts

@@ -0,0 +1,18 @@
+/**
+ * Functional preset — strict functional style for Effect code.
+ * Bans imperative patterns. Layer on top of core or full.
+ */
+export const functional = {
+  "effect/noIfStatement": "error",
+  "effect/noSwitchStatement": "error",
+  "effect/noTernary": "error",
+  "effect/noReturnInArrow": "warn",
+  "effect/noReturnNull": "warn",
+  "effect/noEffectSucceedVariable": "error",
+  "effect/noEffectSucceedString": "error",
+  "effect/noStringSentinelConst": "warn",
+  "effect/noMatchVoidBranch": "error",
+  "effect/noMatchEffectBranch": "error",
+  "effect/noOptionBooleanNormalization": "error",
+  "effect/noArrowLadder": "error",
+} as const

package/src/presets/index.ts

@@ -1,3 +1,5 @@
 export { full } from "./full.js"
 export { core } from "./core.js"
 export { effectNative } from "./effect-native.js"
+export { functional } from "./functional.js"
+export { strict } from "./strict.js"

package/src/presets/strict.ts

@@ -0,0 +1,77 @@
+/**
+ * Strict preset — every rule at error. No warnings, no off.
+ * The nuclear option. Use when you want zero tolerance.
+ */
+export const strict = {
+  // API bans
+  "effect/noEffectDo": "error",
+  "effect/noEffectNever": "error",
+  "effect/noEffectAs": "error",
+  "effect/noEffectAsync": "error",
+  "effect/noEffectBind": "error",
+  "effect/noOptionAs": "error",
+  "effect/noRuntimeRunFork": "error",
+  "effect/noRunInEffect": "error",
+
+  // Style / functional
+  "effect/noReturnNull": "error",
+  "effect/noSwitchStatement": "error",
+  "effect/noIfStatement": "error",
+  "effect/noTernary": "error",
+  "effect/noReturnInArrow": "error",
+  "effect/noStringSentinelConst": "error",
+  "effect/noArrowLadder": "error",
+
+  // Global bans (everywhere, not just Effect context)
+  "effect/noAsyncFunction": "error",
+  "effect/noNodeBuiltinImport": "error",
+
+  // AST pattern rules
+  "effect/noNestedPipe": "error",
+  "effect/noNestedEffectGen": "error",
+  "effect/noUnnecessaryEffectGen": "error",
+  "effect/noEffectSucceedVoid": "error",
+  "effect/noEffectMapVoid": "error",
+  "effect/noUnnecessaryPipe": "error",
+  "effect/noExtendsNativeError": "error",
+  "effect/noEffectFnGenerator": "error",
+  "effect/noInstanceofSchema": "error",
+  "effect/noFlatmapLadder": "error",
+  "effect/noNestedEffectCall": "error",
+  "effect/noIifeWrapper": "error",
+  "effect/noEffectSucceedString": "error",
+  "effect/noEffectOrElseLadder": "error",
+  "effect/noFromNullableCoalesce": "error",
+  "effect/noUnnecessaryArrowBlock": "error",
+  "effect/noEffectGenAdapter": "error",
+  "effect/noEffectSyncConsole": "error",
+  "effect/noEffectTypeAlias": "error",
+  "effect/noEffectWrapperAlias": "error",
+  "effect/noEffectSucceedVariable": "error",
+  "effect/noManualEffectChannels": "error",
+  "effect/noMatchVoidBranch": "error",
+  "effect/noOptionBooleanNormalization": "error",
+  "effect/noEffectSyncWrapper": "error",
+  "effect/noMatchEffectBranch": "error",
+  "effect/noCatchAllToMapError": "error",
+  "effect/noUnnecessaryPipeChain": "error",
+  "effect/noMultipleEffectProvide": "error",
+  "effect/noSchemaUnionOfLiterals": "error",
+  "effect/noSchemaStructWithTag": "error",
+  "effect/noRedundantSchemaTagIdentifier": "error",
+  "effect/noEffectMapFlatten": "error",
+  "effect/noGlobalErrorInFailure": "error",
+  "effect/noGlobalErrorInCatch": "error",
+  "effect/noPositionalLogError": "error",
+
+  // Effect-enforcing bans
+  "effect/noThrowStatement": "error",
+  "effect/noTryCatch": "error",
+  "effect/noNewPromise": "error",
+  "effect/noNewError": "error",
+  "effect/noReturnNullish": "error",
+
+  // Effect-context rules
+  "effect/noGlobals": "error",
+  "effect/noInlineProvide": "error",
+} as const

package/src/rules/index.ts

@@ -14,29 +14,17 @@ export { noOptionAs } from "./no-option-as.js"
 export { noRunInEffect } from "./no-run-in-effect.js"
 export { noRuntimeRunFork } from "./no-runtime-run-fork.js"
 
-// --- Global bans ---
-export { noGlobalConsole } from "./no-global-console.js"
-export { noGlobalDate } from "./no-global-date.js"
-export { noGlobalFetch } from "./no-global-fetch.js"
-export { noGlobalRandom } from "./no-global-random.js"
-export { noGlobalTimers } from "./no-global-timers.js"
-export { noProcessEnv } from "./no-process-env.js"
-
 // --- Statement bans ---
-export { noDynamicImport } from "./no-dynamic-import.js"
 export { noIfStatement } from "./no-if-statement.js"
 export { noSwitchStatement } from "./no-switch-statement.js"
-export { noThrowStatement } from "./no-throw-statement.js"
-export { noTryCatch } from "./no-try-catch.js"
-
-// --- JSON ---
-export { noJsonParse } from "./no-json-parse.js"
 
 // --- AST pattern rules ---
 export { noArrowLadder } from "./no-arrow-ladder.js"
 export { noAsyncFunction } from "./no-async-function.js"
+export { noCatchAllToMapError } from "./no-catch-all-to-map-error.js"
 export { noEffectFnGenerator } from "./no-effect-fn-generator.js"
 export { noEffectGenAdapter } from "./no-effect-gen-adapter.js"
+export { noEffectMapFlatten } from "./no-effect-map-flatten.js"
 export { noEffectMapVoid } from "./no-effect-map-void.js"
 export { noEffectOrElseLadder } from "./no-effect-orElse-ladder.js"
 export { noEffectSucceedString } from "./no-effect-succeed-string.js"
@@ -49,35 +37,36 @@ export { noEffectWrapperAlias } from "./no-effect-wrapper-alias.js"
 export { noExtendsNativeError } from "./no-extends-native-error.js"
 export { noFlatmapLadder } from "./no-flatmap-ladder.js"
 export { noFromNullableCoalesce } from "./no-fromnullable-coalesce.js"
+export { noGlobalErrorInCatch } from "./no-global-error-in-catch.js"
+export { noGlobalErrorInFailure } from "./no-global-error-in-failure.js"
 export { noIifeWrapper } from "./no-iife-wrapper.js"
 export { noInstanceofSchema } from "./no-instanceof-schema.js"
 export { noManualEffectChannels } from "./no-manual-effect-channels.js"
 export { noMatchEffectBranch } from "./no-match-effect-branch.js"
 export { noMatchVoidBranch } from "./no-match-void-branch.js"
+export { noMultipleEffectProvide } from "./no-multiple-effect-provide.js"
 export { noNestedEffectCall } from "./no-nested-effect-call.js"
 export { noNestedEffectGen } from "./no-nested-effect-gen.js"
 export { noNestedPipe } from "./no-nested-pipe.js"
-export { noNewError } from "./no-new-error.js"
-export { noNewPromise } from "./no-new-promise.js"
 export { noNodeBuiltinImport } from "./no-node-builtin-import.js"
 export { noOptionBooleanNormalization } from "./no-option-boolean-normalization.js"
+export { noPositionalLogError } from "./no-positional-log-error.js"
+export { noRedundantSchemaTagIdentifier } from "./no-redundant-schema-tag-identifier.js"
 export { noReturnInArrow } from "./no-return-in-arrow.js"
-export { noReturnNull } from "./no-return-null.js"
+export { noSchemaStructWithTag } from "./no-schema-struct-with-tag.js"
+export { noSchemaUnionOfLiterals } from "./no-schema-union-of-literals.js"
 export { noStringSentinelConst } from "./no-string-sentinel-const.js"
 export { noTernary } from "./no-ternary.js"
 export { noUnnecessaryArrowBlock } from "./no-unnecessary-arrow-block.js"
 export { noUnnecessaryEffectGen } from "./no-unnecessary-effect-gen.js"
+export { noUnnecessaryPipeChain } from "./no-unnecessary-pipe-chain.js"
 export { noUnnecessaryPipe } from "./no-unnecessary-pipe.js"
 
 // --- Effect-context rules ---
-export { noConsoleInEffect } from "./no-console-in-effect.js"
-export { noDateInEffect } from "./no-date-in-effect.js"
-export { noFetchInEffect } from "./no-fetch-in-effect.js"
-export { noInlineRuntimeProvide } from "./no-inline-runtime-provide.js"
-export { noJsonInEffect } from "./no-json-in-effect.js"
-export { noPlatformGlobals } from "./no-platform-globals.js"
-export { noProcessEnvInEffect } from "./no-process-env-in-effect.js"
-export { noRandomInEffect } from "./no-random-in-effect.js"
-export { noThrowInEffectGen } from "./no-throw-in-effect-gen.js"
-export { noTimersInEffect } from "./no-timers-in-effect.js"
-export { noTryCatchInEffectGen } from "./no-try-catch-in-effect-gen.js"
+export { noGlobals } from "./no-globals.js"
+export { noInlineProvide } from "./no-inline-provide.js"
+export { noNewError } from "./no-new-error.js"
+export { noNewPromise } from "./no-new-promise.js"
+export { noReturnNullish } from "./no-return-nullish.js"
+export { noThrowStatement } from "./no-throw-statement.js"
+export { noTryCatch } from "./no-try-catch.js"

package/src/rules/no-arrow-ladder.ts

@@ -5,8 +5,7 @@
  *
  * Source: biome-effect-linting-rules/no-arrow-ladder
  */
-import { Diagnostic, Rule } from "../vendor/effect-oxlint/index.js"
-import { RuleContext } from "../vendor/effect-oxlint/index.js"
+import { Diagnostic, Rule, RuleContext } from "../vendor/effect-oxlint/index.js"
 import * as Effect from "effect/Effect"
 
 const isIife = (node: unknown): boolean => {

package/src/rules/no-async-function.ts

@@ -8,8 +8,7 @@
  * Note: This is an effectNative rule — off by default.
  * Only enable in codebases fully committed to Effect.
  */
-import { Diagnostic, Rule } from "../vendor/effect-oxlint/index.js"
-import { RuleContext } from "../vendor/effect-oxlint/index.js"
+import { Diagnostic, Rule, RuleContext } from "../vendor/effect-oxlint/index.js"
 import * as Effect from "effect/Effect"
 
 export const noAsyncFunction = Rule.define({

package/src/rules/no-catch-all-to-map-error.ts

@@ -0,0 +1,89 @@
+/**
+ * Ban `Effect.catchAll(e => Effect.fail(f(e)))` — use `Effect.mapError(f)`.
+ *
+ * Source: language-service/catchAllToMapError
+ */
+import type { ESTree } from "@oxlint/plugins"
+import { AST, Diagnostic, Rule, RuleContext } from "../vendor/effect-oxlint/index.js"
+import * as Effect from "effect/Effect"
+import * as Option from "effect/Option"
+
+const catchNames = new Set(["catchAll", "catchAllCause"])
+
+/**
+ * Check if a node is `Effect.fail(...)` or `Effect.failCause(...)`.
+ */
+const isEffectFailCall = (node: ESTree.Node): boolean => {
+  if (node.type !== "CallExpression") return false
+  const call = node as ESTree.CallExpression
+  return (
+    Option.isSome(AST.matchCallOf(call, "Effect", "fail")) ||
+    Option.isSome(AST.matchCallOf(call, "Effect", "failCause"))
+  )
+}
+
+/**
+ * Check if a function body is a single `Effect.fail(...)` expression.
+ * Handles: `(e) => Effect.fail(f(e))` and `(e) => { return Effect.fail(f(e)) }`
+ */
+const bodyIsEffectFail = (fn: ESTree.Node): boolean => {
+  const body = (fn as unknown as Record<string, unknown>)["body"]
+  if (body == null || typeof body !== "object") return false
+  const bodyNode = body as ESTree.Node
+  // Arrow with expression body: (e) => Effect.fail(f(e))
+  if (bodyNode.type !== "BlockStatement") {
+    return isEffectFailCall(bodyNode)
+  }
+  // Block body with single return: (e) => { return Effect.fail(f(e)) }
+  const stmts = (bodyNode as unknown as Record<string, unknown>)["body"]
+  if (!Array.isArray(stmts) || stmts.length !== 1) return false
+  const stmt = stmts[0] as ESTree.Node
+  if (stmt.type !== "ReturnStatement") return false
+  const arg = (stmt as unknown as Record<string, unknown>)["argument"]
+  return arg != null && typeof arg === "object" && isEffectFailCall(arg as ESTree.Node)
+}
+
+export const noCatchAllToMapError = Rule.define({
+  name: "no-catch-all-to-map-error",
+  meta: Rule.meta({
+    type: "suggestion",
+    description:
+      "Use Effect.mapError instead of Effect.catchAll(e => Effect.fail(f(e))).",
+  }),
+  create: function* () {
+    const ctx = yield* RuleContext
+    return {
+      CallExpression: (node) => {
+        const call = node as ESTree.CallExpression
+        const names = Option.getOrUndefined(AST.memberNames(call.callee as ESTree.MemberExpression))
+        if (names === undefined) return Effect.void
+        const [obj, prop] = names
+        if (obj !== "Effect" && obj !== "_") return Effect.void
+        if (!catchNames.has(prop)) return Effect.void
+
+        // The callback is the last argument
+        const args = call.arguments
+        if (args.length === 0) return Effect.void
+        const callback = args[args.length - 1]
+        if (callback === undefined) return Effect.void
+        if (
+          callback.type !== "ArrowFunctionExpression" &&
+          callback.type !== "FunctionExpression"
+        ) {
+          return Effect.void
+        }
+
+        if (bodyIsEffectFail(callback as ESTree.Node)) {
+          const replacement = prop === "catchAllCause" ? "mapErrorCause" : "mapError"
+          return ctx.report(
+            Diagnostic.make({
+              node,
+              message: `Use Effect.${replacement} instead of Effect.${prop}(e => Effect.fail(...)).`,
+            }),
+          )
+        }
+        return Effect.void
+      },
+    }
+  },
+})

package/src/rules/no-effect-fn-generator.ts

@@ -11,8 +11,7 @@
  * a name span, which is the discouraged pattern from the biome rules.
  */
 import type { ESTree } from "@oxlint/plugins"
-import { AST, Diagnostic, Rule } from "../vendor/effect-oxlint/index.js"
-import { RuleContext } from "../vendor/effect-oxlint/index.js"
+import { AST, Diagnostic, Rule, RuleContext } from "../vendor/effect-oxlint/index.js"
 import * as Effect from "effect/Effect"
 
 export const noEffectFnGenerator = Rule.define({

package/src/rules/no-effect-gen-adapter.ts

@@ -6,8 +6,7 @@
  * Source: language-service/effectGenUsesAdapter
  */
 import type { ESTree } from "@oxlint/plugins"
-import { AST, Diagnostic, Rule } from "../vendor/effect-oxlint/index.js"
-import { RuleContext } from "../vendor/effect-oxlint/index.js"
+import { AST, Diagnostic, Rule, RuleContext } from "../vendor/effect-oxlint/index.js"
 import * as Effect from "effect/Effect"
 
 export const noEffectGenAdapter = Rule.define({