oxe-cc 1.2.1 → 1.3.0

package/packages/runtime/src/plugins/plugin-abi.ts

@@ -1,95 +1,97 @@
-import type { WorkspaceRequest, WorkspaceManager } from '../workspace/workspace-manager';
-import type { WorkspaceLease, SnapshotRef } from '../models/workspace';
-import type { VerificationResult } from '../models/verification-result';
-
-// ─── ToolProvider ────────────────────────────────────────────────────────────
-
-export interface ToolInvocationInput {
-  action_type: string;
-  work_item_id: string;
-  run_id: string;
-  attempt_id: string;
-  params: Record<string, unknown>;
-  workspace_root: string;
-}
-
-export interface ToolInvocationResult {
-  success: boolean;
-  output: string;
-  evidence_paths: string[];
-  side_effects_applied: string[];
-  error?: string;
-}
-
-export interface ToolProvider {
-  readonly name: string;
-  readonly kind: 'read' | 'mutation' | 'verification' | 'analysis' | 'external_operation';
-  readonly idempotent: boolean;
-  supports(actionType: string): boolean;
-  invoke(input: ToolInvocationInput): Promise<ToolInvocationResult>;
-}
-
-// ─── WorkspaceProvider ───────────────────────────────────────────────────────
-
-export interface WorkspaceProvider extends WorkspaceManager {
-  readonly name: string;
-  supportsStrategy(strategy: string): boolean;
-}
-
-// ─── VerifierProvider ────────────────────────────────────────────────────────
-
-export interface VerificationInput {
-  check_id: string;
-  check_type: string;
-  command: string | null;
-  work_item_id: string;
-  workspace_root: string;
-  evidence_dir: string;
-}
-
-export interface VerifierProvider {
-  readonly name: string;
-  supports(checkType: string): boolean;
-  execute(input: VerificationInput): Promise<VerificationResult>;
-}
-
-// ─── ContextProvider ─────────────────────────────────────────────────────────
-
-export interface ContextRequest {
-  work_item_id: string;
-  run_id: string;
-  decision_type: 'execute' | 'verify' | 'plan' | 'review';
-  artifact_paths: string[];
-  project_root: string;
-}
-
-export interface PluginContextArtifact {
-  source: string;
-  weight: number;
-  reason: string;
-  content?: string;
-}
-
-export interface PluginContextArtifacts {
-  included: PluginContextArtifact[];
-  excluded: Array<{ source: string; reason: string }>;
-  total_weight: number;
-}
-
-export interface ContextProvider {
-  readonly name: string;
-  collect(input: ContextRequest): Promise<PluginContextArtifacts>;
-}
-
-// ─── OxePlugin (unified) ─────────────────────────────────────────────────────
-
-export interface OxePlugin {
-  readonly name: string;
-  readonly version?: string;
-  toolProviders?: ToolProvider[];
-  workspaceProviders?: WorkspaceProvider[];
-  verifierProviders?: VerifierProvider[];
-  contextProviders?: ContextProvider[];
-  /** Legacy lifecycle hooks (compatible with oxe-plugins.cjs) */
-  hooks?: Record<string, (ctx: Record<string, unknown>) => Promise<void> | void>;
-}
+import type { WorkspaceRequest, WorkspaceManager } from '../workspace/workspace-manager';
+import type { WorkspaceLease, SnapshotRef } from '../models/workspace';
+import type { VerificationResult } from '../models/verification-result';
+
+// ─── ToolProvider ────────────────────────────────────────────────────────────
+
+export interface ToolInvocationInput {
+  action_type: string;
+  work_item_id: string;
+  run_id: string;
+  attempt_id: string;
+  params: Record<string, unknown>;
+  workspace_root: string;
+}
+
+export interface ToolInvocationResult {
+  success: boolean;
+  output: string;
+  evidence_paths: string[];
+  side_effects_applied: string[];
+  error?: string;
+}
+
+export interface ToolProvider {
+  readonly name: string;
+  readonly kind: 'read' | 'mutation' | 'verification' | 'analysis' | 'external_operation';
+  readonly idempotent: boolean;
+  supports(actionType: string): boolean;
+  invoke(input: ToolInvocationInput): Promise<ToolInvocationResult>;
+}
+
+// ─── WorkspaceProvider ───────────────────────────────────────────────────────
+
+export interface WorkspaceProvider extends WorkspaceManager {
+  readonly name: string;
+  readonly isolation_level: 'shared' | 'isolated';
+  supportsStrategy(strategy: string): boolean;
+}
+
+// ─── VerifierProvider ────────────────────────────────────────────────────────
+
+export interface VerificationInput {
+  check_id: string;
+  check_type: string;
+  command: string | null;
+  work_item_id: string;
+  workspace_root: string;
+  evidence_dir: string;
+}
+
+export interface VerifierProvider {
+  readonly name: string;
+  supports(checkType: string): boolean;
+  execute(input: VerificationInput): Promise<VerificationResult>;
+}
+
+// ─── ContextProvider ─────────────────────────────────────────────────────────
+
+export interface ContextRequest {
+  work_item_id: string;
+  run_id: string;
+  decision_type: 'execute' | 'verify' | 'plan' | 'review';
+  artifact_paths: string[];
+  project_root: string;
+}
+
+export interface PluginContextArtifact {
+  source: string;
+  weight: number;
+  reason: string;
+  content?: string;
+}
+
+export interface PluginContextArtifacts {
+  included: PluginContextArtifact[];
+  excluded: Array<{ source: string; reason: string }>;
+  total_weight: number;
+}
+
+export interface ContextProvider {
+  readonly name: string;
+  collect(input: ContextRequest): Promise<PluginContextArtifacts>;
+}
+
+// ─── OxePlugin (unified) ─────────────────────────────────────────────────────
+
+export interface OxePlugin {
+  readonly name: string;
+  readonly version?: string;
+  readonly abi_version?: string;
+  toolProviders?: ToolProvider[];
+  workspaceProviders?: WorkspaceProvider[];
+  verifierProviders?: VerifierProvider[];
+  contextProviders?: ContextProvider[];
+  /** Legacy lifecycle hooks (compatible with oxe-plugins.cjs) */
+  hooks?: Record<string, (ctx: Record<string, unknown>) => Promise<void> | void>;
+}

package/packages/runtime/src/plugins/plugin-manifest.ts

@@ -1,113 +1,118 @@
-import type { OxePlugin } from './plugin-abi';
-
-export const CURRENT_ABI_VERSION = '1.0.0';
-
-export interface PluginManifest {
-  name: string;
-  version: string;
-  abi_version: string;
-  capabilities: Array<'tool' | 'workspace' | 'verifier' | 'context' | 'hooks'>;
-  tool_action_types?: string[];
-  workspace_strategies?: string[];
-  verifier_check_types?: string[];
-  context_provider_names?: string[];
-  hook_names?: string[];
-}
-
-export interface PluginValidationResult {
-  valid: boolean;
-  errors: string[];
-  warnings: string[];
-}
-
-export function extractManifest(plugin: OxePlugin): PluginManifest {
-  const capabilities: PluginManifest['capabilities'] = [];
-  if (plugin.toolProviders?.length) capabilities.push('tool');
-  if (plugin.workspaceProviders?.length) capabilities.push('workspace');
-  if (plugin.verifierProviders?.length) capabilities.push('verifier');
-  if (plugin.contextProviders?.length) capabilities.push('context');
-  if (plugin.hooks && Object.keys(plugin.hooks).length > 0) capabilities.push('hooks');
-
-  return {
-    name: plugin.name,
-    version: plugin.version ?? '0.0.0',
-    abi_version: CURRENT_ABI_VERSION,
-    capabilities,
-    tool_action_types: plugin.toolProviders?.flatMap((p) =>
-      ['read_code', 'generate_patch', 'run_tests', 'collect_evidence', 'custom'].filter((t) => p.supports(t))
-    ) ?? [],
-    workspace_strategies: plugin.workspaceProviders?.map((p) => p.name) ?? [],
-    verifier_check_types: plugin.verifierProviders?.flatMap((p) =>
-      ['unit', 'integration', 'smoke', 'policy', 'security', 'custom'].filter((t) => p.supports(t))
-    ) ?? [],
-    context_provider_names: plugin.contextProviders?.map((p) => p.name) ?? [],
-    hook_names: plugin.hooks ? Object.keys(plugin.hooks) : [],
-  };
-}
-
-export function validatePlugin(plugin: OxePlugin): PluginValidationResult {
-  const errors: string[] = [];
-  const warnings: string[] = [];
-
-  if (!plugin.name || typeof plugin.name !== 'string') {
-    errors.push('Plugin must have a non-empty string name');
-  }
-
-  if (plugin.version && !/^\d+\.\d+\.\d+/.test(plugin.version)) {
-    warnings.push(`Plugin version "${plugin.version}" does not follow semver`);
-  }
-
-  if (!plugin.toolProviders?.length &&
-      !plugin.workspaceProviders?.length &&
-      !plugin.verifierProviders?.length &&
-      !plugin.contextProviders?.length &&
-      !plugin.hooks) {
-    warnings.push('Plugin declares no providers or hooks — it has no effect');
-  }
-
-  // Validate each tool provider
-  for (const tp of plugin.toolProviders ?? []) {
-    if (!tp.name) errors.push('ToolProvider missing name');
-    if (typeof tp.supports !== 'function') errors.push(`ToolProvider "${tp.name}" missing supports() method`);
-    if (typeof tp.invoke !== 'function') errors.push(`ToolProvider "${tp.name}" missing invoke() method`);
-  }
-
-  // Validate each workspace provider
-  for (const wp of plugin.workspaceProviders ?? []) {
-    if (!wp.name) errors.push('WorkspaceProvider missing name');
-    if (typeof wp.supportsStrategy !== 'function') errors.push(`WorkspaceProvider "${wp.name}" missing supportsStrategy()`);
-    if (typeof wp.allocate !== 'function') errors.push(`WorkspaceProvider "${wp.name}" missing allocate()`);
-  }
-
-  // Validate each verifier provider
-  for (const vp of plugin.verifierProviders ?? []) {
-    if (!vp.name) errors.push('VerifierProvider missing name');
-    if (typeof vp.supports !== 'function') errors.push(`VerifierProvider "${vp.name}" missing supports()`);
-    if (typeof vp.execute !== 'function') errors.push(`VerifierProvider "${vp.name}" missing execute()`);
-  }
-
-  return { valid: errors.length === 0, errors, warnings };
-}
-
-export function isAbiCompatible(pluginAbiVersion: string): boolean {
-  // Major version must match; minor/patch are backwards-compatible
-  const [currMajor] = CURRENT_ABI_VERSION.split('.').map(Number);
-  const [plugMajor] = pluginAbiVersion.split('.').map(Number);
-  return currMajor === plugMajor;
-}
-
-export function sandboxInvoke<T>(
-  fn: () => Promise<T>,
-  timeoutMs = 10_000
-): Promise<T> {
-  return new Promise<T>((resolve, reject) => {
-    const timer = setTimeout(() => {
-      reject(new Error(`Plugin invocation timed out after ${timeoutMs}ms`));
-    }, timeoutMs);
-
-    fn().then(
-      (result) => { clearTimeout(timer); resolve(result); },
-      (err) => { clearTimeout(timer); reject(err instanceof Error ? err : new Error(String(err))); }
-    );
-  });
-}
+import type { OxePlugin } from './plugin-abi';
+
+export const CURRENT_ABI_VERSION = '1';
+
+export interface PluginManifest {
+  name: string;
+  version: string;
+  abi_version: string;
+  capabilities: Array<'tool' | 'workspace' | 'verifier' | 'context' | 'hooks'>;
+  tool_action_types?: string[];
+  workspace_strategies?: string[];
+  verifier_check_types?: string[];
+  context_provider_names?: string[];
+  hook_names?: string[];
+}
+
+export interface PluginValidationResult {
+  valid: boolean;
+  errors: string[];
+  warnings: string[];
+}
+
+export function extractManifest(plugin: OxePlugin): PluginManifest {
+  const capabilities: PluginManifest['capabilities'] = [];
+  if (plugin.toolProviders?.length) capabilities.push('tool');
+  if (plugin.workspaceProviders?.length) capabilities.push('workspace');
+  if (plugin.verifierProviders?.length) capabilities.push('verifier');
+  if (plugin.contextProviders?.length) capabilities.push('context');
+  if (plugin.hooks && Object.keys(plugin.hooks).length > 0) capabilities.push('hooks');
+
+  return {
+    name: plugin.name,
+    version: plugin.version ?? '0.0.0',
+    abi_version: plugin.abi_version ?? CURRENT_ABI_VERSION,
+    capabilities,
+    tool_action_types: plugin.toolProviders?.flatMap((p) =>
+      ['read_code', 'generate_patch', 'run_tests', 'collect_evidence', 'custom'].filter((t) => p.supports(t))
+    ) ?? [],
+    workspace_strategies: plugin.workspaceProviders?.map((p) => p.name) ?? [],
+    verifier_check_types: plugin.verifierProviders?.flatMap((p) =>
+      ['unit', 'integration', 'smoke', 'policy', 'security', 'custom'].filter((t) => p.supports(t))
+    ) ?? [],
+    context_provider_names: plugin.contextProviders?.map((p) => p.name) ?? [],
+    hook_names: plugin.hooks ? Object.keys(plugin.hooks) : [],
+  };
+}
+
+export function validatePlugin(plugin: OxePlugin): PluginValidationResult {
+  const errors: string[] = [];
+  const warnings: string[] = [];
+
+  if (!plugin.name || typeof plugin.name !== 'string') {
+    errors.push('Plugin must have a non-empty string name');
+  }
+
+  if (plugin.version && !/^\d+\.\d+\.\d+/.test(plugin.version)) {
+    warnings.push(`Plugin version "${plugin.version}" does not follow semver`);
+  }
+
+  const abiVersion = plugin.abi_version ?? CURRENT_ABI_VERSION;
+  if (!isAbiCompatible(abiVersion)) {
+    errors.push(`Plugin ABI "${abiVersion}" is incompatible with runtime ABI "${CURRENT_ABI_VERSION}"`);
+  }
+
+  if (!plugin.toolProviders?.length &&
+      !plugin.workspaceProviders?.length &&
+      !plugin.verifierProviders?.length &&
+      !plugin.contextProviders?.length &&
+      !plugin.hooks) {
+    warnings.push('Plugin declares no providers or hooks — it has no effect');
+  }
+
+  // Validate each tool provider
+  for (const tp of plugin.toolProviders ?? []) {
+    if (!tp.name) errors.push('ToolProvider missing name');
+    if (typeof tp.supports !== 'function') errors.push(`ToolProvider "${tp.name}" missing supports() method`);
+    if (typeof tp.invoke !== 'function') errors.push(`ToolProvider "${tp.name}" missing invoke() method`);
+  }
+
+  // Validate each workspace provider
+  for (const wp of plugin.workspaceProviders ?? []) {
+    if (!wp.name) errors.push('WorkspaceProvider missing name');
+    if (typeof wp.supportsStrategy !== 'function') errors.push(`WorkspaceProvider "${wp.name}" missing supportsStrategy()`);
+    if (typeof wp.allocate !== 'function') errors.push(`WorkspaceProvider "${wp.name}" missing allocate()`);
+  }
+
+  // Validate each verifier provider
+  for (const vp of plugin.verifierProviders ?? []) {
+    if (!vp.name) errors.push('VerifierProvider missing name');
+    if (typeof vp.supports !== 'function') errors.push(`VerifierProvider "${vp.name}" missing supports()`);
+    if (typeof vp.execute !== 'function') errors.push(`VerifierProvider "${vp.name}" missing execute()`);
+  }
+
+  return { valid: errors.length === 0, errors, warnings };
+}
+
+export function isAbiCompatible(pluginAbiVersion: string): boolean {
+  // Major version must match; minor/patch are backwards-compatible
+  const [currMajor] = CURRENT_ABI_VERSION.split('.').map(Number);
+  const [plugMajor] = pluginAbiVersion.split('.').map(Number);
+  return currMajor === plugMajor;
+}
+
+export function sandboxInvoke<T>(
+  fn: () => Promise<T>,
+  timeoutMs = 10_000
+): Promise<T> {
+  return new Promise<T>((resolve, reject) => {
+    const timer = setTimeout(() => {
+      reject(new Error(`Plugin invocation timed out after ${timeoutMs}ms`));
+    }, timeoutMs);
+
+    fn().then(
+      (result) => { clearTimeout(timer); resolve(result); },
+      (err) => { clearTimeout(timer); reject(err instanceof Error ? err : new Error(String(err))); }
+    );
+  });
+}