ox 1.0.0-beta.9 → 1.0.1

package/src/core/_test/Siwe.test.ts

@@ -4,7 +4,7 @@ import { describe, expect, test, vi } from 'vp/test'
 describe('createMessage', () => {
   const message = {
     address: '0xA0Cf798816D4b9b9866b5330EEa46a18382f251e',
-    chainId: 1n,
+    chainId: 1,
     domain: 'example.com',
     nonce: 'foobarbaz',
     uri: 'https://example.com/path',
@@ -277,10 +277,8 @@ describe('createMessage', () => {
   })
 
   test('behavior: invalid chainId', () => {
-    expect(() =>
-      // @ts-expect-error chain IDs must be bigint.
-      Siwe.createMessage({ ...message, chainId: 1.1 }),
-    ).toThrowErrorMatchingInlineSnapshot(`
+    expect(() => Siwe.createMessage({ ...message, chainId: 1.1 }))
+      .toThrowErrorMatchingInlineSnapshot(`
     [Siwe.InvalidMessageFieldError: Invalid Sign-In with Ethereum message field "chainId".
 
     - Chain ID must be a EIP-155 chain ID.
@@ -478,7 +476,7 @@ Issued At: 2023-02-01T00:00:00.000Z`
     expect(parsed).toMatchInlineSnapshot(`
     {
       "address": "0xA0Cf798816D4b9b9866b5330EEa46a18382f251e",
-      "chainId": 1n,
+      "chainId": 1,
       "domain": "example.com",
       "issuedAt": 2023-02-01T00:00:00.000Z,
       "nonce": "foobarbaz",
@@ -626,7 +624,7 @@ Request ID: 123e4567-e89b-12d3-a456-426614174000`
     const parsed = Siwe.parseMessage(message)
     expect(parsed).toMatchInlineSnapshot(`
     {
-      "chainId": 1n,
+      "chainId": 1,
       "issuedAt": 2023-02-01T00:00:00.000Z,
       "nonce": "foobarbaz",
       "requestId": "123e4567-e89b-12d3-a456-426614174000",
@@ -646,7 +644,7 @@ Request ID: 123e4567-e89b-12d3-a456-426614174000`
 describe('validateMessage', () => {
   const message = {
     address: '0xA0Cf798816D4b9b9866b5330EEa46a18382f251e',
-    chainId: 1n,
+    chainId: 1,
     domain: 'example.com',
     nonce: 'foobarbaz',
     uri: 'https://example.com/path',

package/src/core/internal/abiParameters.ts

@@ -150,7 +150,8 @@ export function decodeArray(
 
   // If the length of the array is not known in advance (dynamic array),
   // this means we will need to wonder off to the pointer and decode.
-  if (!length) {
+  // Note: zero-length fixed arrays (`T[0]`) are not dynamic.
+  if (length === null) {
     // Dealing with a dynamic type, so get the offset of the array data.
     const offset = Bytes.toNumber(cursor.readBytes(sizeOfOffset))
 
@@ -177,6 +178,12 @@ export function decodeArray(
       })
       consumed += consumed_
       value.push(data)
+      // Charge zero-width elements against the read limit to bound work
+      // on huge lengths of zero-width types (e.g. `uint256[0][]`).
+      if (consumed_ === 0) {
+        cursor.assertReadLimit()
+        cursor._touch()
+      }
     }
 
     // As we have gone wondering, restore to the original position + next slot.
@@ -206,7 +213,10 @@ export function decodeArray(
     }
 
     // As we have gone wondering, restore to the original position + next slot.
-    cursor.setPosition(staticPosition + 32)
+    // Zero-length arrays of dynamic types (e.g. `string[0]`) have no tail, so
+    // the next slot may sit past the end of the data.
+    if (staticPosition + 32 < cursor.bytes.length)
+      cursor.setPosition(staticPosition + 32)
     return [value, 32]
   }
 
@@ -221,6 +231,12 @@ export function decodeArray(
     })
     consumed += consumed_
     value.push(data)
+    // Charge zero-width elements against the read limit to bound work
+    // on huge lengths of zero-width types (e.g. `uint256[0][4294967295]`).
+    if (consumed_ === 0) {
+      cursor.assertReadLimit()
+      cursor._touch()
+    }
   }
   return [value, consumed]
 }
@@ -391,7 +407,7 @@ export function decodeString(
   }
 
   const data = cursor.readBytes(length, 32)
-  const value = Bytes.toString(Bytes.trimLeft(data))
+  const value = Bytes.toString(data)
 
   // As we have gone wondering, restore to the original position + next slot.
   cursor.setPosition(staticPosition + 32)
@@ -403,7 +419,6 @@ export declare namespace decodeString {
   type ErrorType =
     | Bytes.toNumber.ErrorType
     | Bytes.toString.ErrorType
-    | Bytes.trimLeft.ErrorType
     | Errors.GlobalErrorType
 }
 
@@ -593,7 +608,9 @@ export function encodeArray<const parameter extends AbiParameters.Parameter>(
       type: `${parameter.type}[${length}]`,
     })
 
-  let dynamicChild = false
+  // Zero-length fixed arrays of dynamic types (e.g. `string[0]`) are dynamic
+  // per the ABI spec, even though they have no elements to inspect.
+  let dynamicChild = value.length === 0 && hasDynamicChild(parameter)
   const preparedParameters: PreparedParameter[] = []
   for (let i = 0; i < value.length; i++) {
     const preparedParam = prepareParameter({

package/src/core/internal/rpcSchemas/eth.ts

@@ -218,6 +218,26 @@ export type Eth = RpcSchema.From<
       }
       ReturnType: Fee.FeeHistoryRpc
     }
+  /**
+   * Fills the defaults (nonce, gas, gasPrice, or 1559 fields) on a given unsigned transaction, and returns the unsigned transaction along with its raw form
+   *
+   * @example
+   * ```
+   * request({ method: 'eth_fillTransaction', params: [{ from: '0x...', to: '0x...', value: '0x...' }] })
+   * // { raw: '0x...', tx: { ... } }
+   * ```
+   */
+  | {
+      Request: {
+        method: 'eth_fillTransaction'
+        params: [transaction: TransactionRequest.Rpc]
+      }
+      ReturnType: {
+        capabilities?: Record<string, unknown> | undefined
+        raw: Hex.Hex
+        tx: Transaction.Rpc
+      }
+    }
   /**
    * Returns the current price of gas expressed in wei
    *
@@ -425,6 +445,22 @@ export type Eth = RpcSchema.From<
       }
       ReturnType: AccountProof.Rpc
     }
+  /**
+   * Returns the raw, serialized transaction specified by hash
+   *
+   * @example
+   * ```
+   * request({ method: 'eth_getRawTransactionByHash', params: ['0x...'] })
+   * // '0x...'
+   * ```
+   */
+  | {
+      Request: {
+        method: 'eth_getRawTransactionByHash'
+        params: [hash: Hex.Hex]
+      }
+      ReturnType: Hex.Hex | null
+    }
   /**
    * Returns the value from a storage position at an address
    *