overtime-live-trading-utils 4.0.0-rc.7 → 4.0.0-rc.9

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "overtime-live-trading-utils",
-    "version": "4.0.0-rc.7",
+    "version": "4.0.0-rc.9",
     "description": "",
     "main": "main.js",
     "scripts": {
@@ -14,7 +14,7 @@
     "dependencies": {
         "@types/node": "^20.8.10",
         "oddslib": "^2.1.1",
-        "overtime-utils": "^0.1.50",
+        "overtime-utils": "^0.1.59",
         "react": "^17.0.1"
     },
     "devDependencies": {

package/src/tests/unit/bookmakers.test.ts

@@ -1,7 +1,8 @@
 import { DIFF_BETWEEN_BOOKMAKERS_MESSAGE, ZERO_ODDS_MESSAGE } from '../../constants/errors';
-import { ODDS_THRESHOLD_ANCHORS } from '../../constants/odds';
+import { __test__ } from '../../utils/bookmakers';
 import { processMarket } from '../../utils/markets';
 import { mapOpticOddsApiFixtureOdds } from '../../utils/opticOdds';
+import { ODDS_THRESHOLD_ANCHORS } from '../mock/MockAnchors';
 import { LeagueMocks } from '../mock/MockLeagueMap';
 import {
     MockOddsChildMarketsDifferentBookmakers,
@@ -150,3 +151,29 @@ describe('Bookmakers', () => {
         expect(market.childMarkets.length).toBe(1);
     });
 });
+
+describe('Bookmakers', () => {
+    it('Should export test only functions', () => {
+        const OUR_ODDS = 1.943;
+        const OTHER_ODDS = 1.847;
+
+        const THRESHOLDS = [
+            { our: 1.02, otherMin: 1.01 },
+            { our: 1.05, otherMin: 1.04 },
+            { our: 1.1, otherMin: 1.09 },
+            { our: 1.2, otherMin: 1.19 },
+            { our: 1.3, otherMin: 1.29 },
+            { our: 1.4, otherMin: 1.39 },
+            { our: 1.5, otherMin: 1.48 },
+            { our: 2.0, otherMin: 1.95 },
+            { our: 2.5, otherMin: 2.25 },
+            { our: 3.0, otherMin: 2.5 },
+            { our: 4.0, otherMin: 3.5 },
+            { our: 8.0, otherMin: 6.5 },
+            { our: 10.0, otherMin: 8.0 },
+            { our: 100.0, otherMin: 70.0 },
+        ];
+
+        expect(__test__.shouldBlockOdds(OUR_ODDS, OTHER_ODDS, THRESHOLDS)).toBe(true);
+    });
+});

package/src/tests/unit/markets.test.ts

@@ -1,7 +1,7 @@
 import { NO_MARKETS_FOR_LEAGUE_ID } from '../../constants/errors';
-import { ODDS_THRESHOLD_ANCHORS } from '../../constants/odds';
 import { processMarket } from '../../utils/markets';
 import { mapOpticOddsApiFixtureOdds } from '../../utils/opticOdds';
+import { ODDS_THRESHOLD_ANCHORS } from '../mock/MockAnchors';
 import { LeagueMocks } from '../mock/MockLeagueMap';
 import { MockOnlyMoneyline, MockOpticSoccer } from '../mock/MockOpticSoccer';
 import { mockSoccer } from '../mock/MockSoccerRedis';

package/src/tests/unit/odds.test.ts

@@ -1,7 +1,7 @@
 import { ZERO_ODDS_MESSAGE_SINGLE_BOOKMAKER } from '../../constants/errors';
-import { ODDS_THRESHOLD_ANCHORS } from '../../constants/odds';
 import { processMarket } from '../../utils/markets';
 import { mapOpticOddsApiFixtureOdds } from '../../utils/opticOdds';
+import { ODDS_THRESHOLD_ANCHORS } from '../mock/MockAnchors';
 import { LeagueMocks } from '../mock/MockLeagueMap';
 import {
     MockOddsChildMarketsGoodOdds,

package/src/tests/unit/spread.test.ts

@@ -1,7 +1,7 @@
 import { ZERO_ODDS_AFTER_SPREAD_ADJUSTMENT } from '../../constants/errors';
-import { ODDS_THRESHOLD_ANCHORS } from '../../constants/odds';
 import { processMarket } from '../../utils/markets';
 import { mapOpticOddsApiFixtureOdds } from '../../utils/opticOdds';
+import { ODDS_THRESHOLD_ANCHORS } from '../mock/MockAnchors';
 import { LeagueMocks } from '../mock/MockLeagueMap';
 import { MockAfterSpreadZeroOdds1, MockOnlyMoneylineFavorite, MockOpticSoccer } from '../mock/MockOpticSoccer';
 import { mockSoccer } from '../mock/MockSoccerRedis';

package/src/utils/bookmakers.ts

@@ -295,3 +295,6 @@ const shouldBlockOdds = (ourOdds: number, otherOdds: number, anchors: Anchor[])
     // Block if the other book is below the required threshold
     return otherOdds < requiredOther;
 };
+
+// Export only when running tests
+export const __test__ = { getRequiredOtherOdds, shouldBlockOdds };

package/src/utils/odds.ts

@@ -291,12 +291,10 @@ export const createChildMarkets: (
             const maxOdds = leagueInfoByTypeId?.maxOdds; // maximum odds configured for child market (e.g. 0.05 implied probability)
 
             if (minOdds && maxOdds) {
-                let conditionToAddChildMarket = true;
-                data.odds.forEach((odd: number) => {
-                    if (odd >= minOdds || odd <= maxOdds) {
-                        conditionToAddChildMarket = false;
-                    }
-                });
+                const conditionToAddChildMarket =
+                    data.type === 'Total'
+                        ? data.odds.some((odd: number) => odd < minOdds && odd > maxOdds)
+                        : data.odds.every((odd: number) => odd < minOdds && odd > maxOdds);
                 if (conditionToAddChildMarket) {
                     childMarkets.push(childMarket);
                 }
@@ -461,7 +459,7 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
 
         acc.push({
             line: line as any,
-            odds: [(value as any).over, (value as any).under].filter((odd) => odd !== null),
+            odds: [(value as any).over, (value as any).under].map((odd) => odd || ZERO),
             typeId: !shouldIncreaseTypeId ? (value as any).typeId : Number((value as any).typeId) + 1,
             sportId: (value as any).sportId,
             type: (value as any).type,