overtime-live-trading-utils 3.0.2-rc.2 → 3.0.3

package/src/utils/markets.ts

@@ -1,6 +1,6 @@
 import * as oddslib from 'oddslib';
 import { ZERO_ODDS_AFTER_SPREAD_ADJUSTMENT } from '../constants/errors';
-import { Anchor, OddsObject } from '../types/odds';
+import { OddsObject } from '../types/odds';
 import { LastPolledArray } from '../types/sports';
 import { createChildMarkets, getParentOdds } from './odds';
 import { getLeagueInfo } from './sports';
@@ -16,10 +16,8 @@ import { adjustAddedSpread } from './spread';
  * @param {Array} spreadData - Spread data for odds.
  * @param {Boolean} isDrawAvailable - Is it two or three-positional sport
  * @param {Number} defaultSpreadForLiveMarkets - Default spread for live markets
- * @param {Object} leagueMap - League map for additional league information
- * @param {LastPolledArray} lastPolledData - Array containing last polled timestamps for bookmakers
- * @param {Number} maxAllowedProviderDataStaleDelay - Maximum allowed delay for provider data to be considered fresh
- * @param {Map<string, number>} playersMap - Map of player OO IDs to our internal player ID
+ * @param {Number} maxPercentageDiffBetwenOdds - Maximum allowed percentage difference between same position odds from different providers
+ * @param {Boolean} isTestnet - Flag showing should we process for testnet or mainnet
  * @returns {Promise<Object|null>} A promise that resolves to the processed event object or null if the event is invalid or mapping fails.
  */
 export const processMarket = (
@@ -29,11 +27,10 @@ export const processMarket = (
     spreadData: any,
     isDrawAvailable: any,
     defaultSpreadForLiveMarkets: any,
-    anchors: Anchor[],
+    maxPercentageDiffBetwenOdds: number,
     leagueMap: any,
     lastPolledData: LastPolledArray,
-    maxAllowedProviderDataStaleDelay: number,
-    playersMap: Map<string, number>
+    maxAllowedProviderDataStaleDelay: number
 ) => {
     const sportSpreadData = spreadData.filter((data: any) => data.sportId === String(market.leagueId));
     const leagueInfo = getLeagueInfo(market.leagueId, leagueMap);
@@ -45,7 +42,7 @@ export const processMarket = (
         apiResponseWithOdds,
         market.leagueId,
         defaultSpreadForLiveMarkets,
-        anchors,
+        maxPercentageDiffBetwenOdds,
         leagueInfo,
         lastPolledData,
         maxAllowedProviderDataStaleDelay
@@ -92,8 +89,7 @@ export const processMarket = (
         leagueMap,
         lastPolledData,
         maxAllowedProviderDataStaleDelay,
-        anchors,
-        playersMap
+        maxPercentageDiffBetwenOdds
     );
 
     const packedChildMarkets = childMarkets.map((childMarket: any) => {

package/src/utils/odds.ts

@@ -1,9 +1,9 @@
 import * as oddslib from 'oddslib';
 import { MarketType, MarketTypeMap } from 'overtime-utils';
-import { DRAW, MONEYLINE_TYPE_ID, ZERO } from '../constants/common';
+import { DRAW, MIN_ODDS_FOR_DIFF_CHECKING, MONEYLINE_TYPE_ID, ZERO } from '../constants/common';
 import { LAST_POLLED_TOO_OLD, NO_MARKETS_FOR_LEAGUE_ID } from '../constants/errors';
 import { MoneylineTypes } from '../enums/sports';
-import { Anchor, HomeAwayTeams, Odds, OddsObject } from '../types/odds';
+import { HomeAwayTeams, Odds, OddsObject } from '../types/odds';
 import { ChildMarket, LastPolledArray, LeagueConfigInfo } from '../types/sports';
 import {
     checkOddsFromBookmakers,
@@ -128,7 +128,7 @@ export const getParentOdds = (
     oddsApiObject: OddsObject,
     sportId: string,
     defaultSpreadForLiveMarkets: number,
-    anchors: Anchor[],
+    maxPercentageDiffBetwenOdds: number,
     leagueInfo: LeagueConfigInfo[],
     lastPolledData: LastPolledArray,
     maxAllowedProviderDataStaleDelay: number
@@ -164,7 +164,13 @@ export const getParentOdds = (
     );
 
     // CHECKING AND COMPARING ODDS FOR THE GIVEN BOOKMAKERS
-    const oddsObject = checkOddsFromBookmakers(moneylineOddsMap, bookmakers, isTwoPositionalSport, anchors);
+    const oddsObject = checkOddsFromBookmakers(
+        moneylineOddsMap,
+        bookmakers,
+        isTwoPositionalSport,
+        maxPercentageDiffBetwenOdds,
+        MIN_ODDS_FOR_DIFF_CHECKING
+    );
 
     if (oddsObject.errorMessage) {
         return {
@@ -208,8 +214,7 @@ export const createChildMarkets: (
     leagueMap: any,
     lastPolledData: LastPolledArray,
     maxAllowedProviderDataStaleDelay: number,
-    anchors: Anchor[],
-    playersMap: Map<string, number>
+    maxImpliedPercentageDifference: number
 ) => ChildMarket[] = (
     apiResponseWithOdds,
     spreadDataForSport,
@@ -219,8 +224,7 @@ export const createChildMarkets: (
     leagueMap,
     lastPolledData,
     maxAllowedProviderDataStaleDelay,
-    anchors,
-    playersMap
+    maxImpliedPercentageDifference
 ) => {
     const [spreadOdds, totalOdds, moneylineOdds, correctScoreOdds, doubleChanceOdds, ggOdds, childMarkets]: any[] = [
         [],
@@ -238,14 +242,14 @@ export const createChildMarkets: (
     };
 
     if (leagueInfo.length > 0) {
-        const allChildOdds = filterOdds(apiResponseWithOdds.odds, leagueInfo, playersMap);
+        const allChildOdds = filterOddsByMarketNameBookmaker(apiResponseWithOdds.odds, leagueInfo);
         const checkedChildOdds = checkOddsFromBookmakersForChildMarkets(
             allChildOdds,
             leagueInfo,
             liveOddsProviders,
             lastPolledData,
             maxAllowedProviderDataStaleDelay,
-            anchors
+            maxImpliedPercentageDifference
         );
         checkedChildOdds.forEach((odd) => {
             if (odd.type === 'Total') {
@@ -265,7 +269,7 @@ export const createChildMarkets: (
 
         const homeAwayFormattedOdds = [
             ...groupAndFormatSpreadOdds(spreadOdds, commonData),
-            ...groupAndFormatTotalOdds(totalOdds, commonData), // playerProps are handled inside this function
+            ...groupAndFormatTotalOdds(totalOdds, commonData),
             ...groupAndFormatMoneylineOdds(moneylineOdds, commonData),
             ...groupAndFormatGGOdds(ggOdds),
             ...groupAndFormatDoubleChanceOdds(doubleChanceOdds, commonData),
@@ -280,29 +284,13 @@ export const createChildMarkets: (
         );
 
         homeAwayOddsWithSpreadAdjusted.forEach((data) => {
-            let childMarket = {
+            const childMarket = {
                 leagueId: Number(data.sportId),
                 typeId: Number(data.typeId),
                 type: MarketTypeMap[data.typeId as MarketType]?.key || '',
                 line: Number(data.line || 0),
                 odds: data.odds,
-                playerProps: {
-                    playerId: 0,
-                    playerName: '',
-                },
-                isPlayerPropsMarket: false,
             };
-            if (data.playerProps) {
-                childMarket = {
-                    ...childMarket,
-                    playerProps: {
-                        playerId: playersMap.get(data.playerProps.playerId.toString()) || 0, // convert from opticOdds playerId to our internal playerId
-                        playerName: data.playerProps.playerName,
-                    },
-                    isPlayerPropsMarket: true,
-                };
-            }
-
             const leagueInfoByTypeId = leagueInfo.find((league) => Number(league.typeId) === Number(data.typeId));
             const minOdds = leagueInfoByTypeId?.minOdds; // minimum odds configured for child market (e.g. 0.95 implied probability)
             const maxOdds = leagueInfoByTypeId?.maxOdds; // maximum odds configured for child market (e.g. 0.05 implied probability)
@@ -355,7 +343,7 @@ export const createChildMarkets: (
  * @param {string} oddsProvider - The main odds provider to filter by.
  * @returns {Array} The filtered odds array.
  */
-export const filterOdds = (oddsArray: Odds, leagueInfos: LeagueConfigInfo[], playersMap: Map<string, number>): any => {
+export const filterOddsByMarketNameBookmaker = (oddsArray: Odds, leagueInfos: LeagueConfigInfo[]): any => {
     const allChildMarketsTypes = leagueInfos
         .filter(
             (leagueInfo) =>
@@ -365,10 +353,7 @@ export const filterOdds = (oddsArray: Odds, leagueInfos: LeagueConfigInfo[], pla
         .map((leagueInfo) => leagueInfo.marketName.toLowerCase());
     return oddsArray.reduce((acc: any, odd: any) => {
         if (allChildMarketsTypes.includes(odd.marketName.toLowerCase())) {
-            const { points, marketName, selection, selectionLine, sportsBookName, playerId } = odd;
-            if (playerId && !playersMap.has(playerId)) {
-                return acc;
-            }
+            const { points, marketName, selection, selectionLine, sportsBookName } = odd;
             const key = `${sportsBookName.toLowerCase()}_${marketName.toLowerCase()}_${points}_${selection}_${selectionLine}`;
             acc[key] = {
                 ...odd,
@@ -455,13 +440,6 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
             acc[key].typeId = odd.typeId;
             acc[key].type = odd.type;
             acc[key].sportId = odd.sportId;
-
-            if (odd.playerId) {
-                acc[key].playerProps = {
-                    playerId: odd.playerId, // Player ID from OpticOdds, this will be converted to our internal playerId later
-                    playerName: odd.selection,
-                };
-            }
         }
 
         return acc;
@@ -469,8 +447,8 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
 
     // Format the grouped odds into the desired output
     const formattedOdds = Object.entries(groupedOdds as any).reduce((acc: any, [key, value]) => {
-        const [_marketName, selection, points] = key.split('_');
-        const line = parseFloat(points);
+        const [_marketName, selection, selectionLine] = key.split('_');
+        const line = parseFloat(selectionLine);
 
         // if we have away team in total odds we know the market is team total and we need to increase typeId by one.
         // if this is false typeId is already mapped correctly
@@ -482,7 +460,6 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
                 typeId: !isAwayTeam ? (value as any).typeId : Number((value as any).typeId) + 1,
                 sportId: (value as any).sportId,
                 type: (value as any).type,
-                playerProps: (value as any).playerProps,
             });
         }
         return acc;

package/src/constants/odds.ts

@@ -1,19 +0,0 @@
-// For each ourOdds, this is the minimum otherOdds we require to NOT block
-// USED FOR TESTS ONLY, real anchors are passed from risk repo
-export const ODDS_THRESHOLD_ANCHORS = [
-    { our: 1.05, otherMin: 1.03 },
-    { our: 1.1, otherMin: 1.06 },
-    { our: 1.2, otherMin: 1.15 },
-    { our: 1.3, otherMin: 1.25 },
-    { our: 1.4, otherMin: 1.33 },
-    { our: 1.5, otherMin: 1.4 },
-
-    { our: 2.0, otherMin: 1.85 },
-    { our: 2.5, otherMin: 2.25 },
-    { our: 3.0, otherMin: 2.5 },
-    { our: 4.0, otherMin: 3.5 },
-
-    { our: 8.0, otherMin: 6.5 },
-    { our: 10.0, otherMin: 8.0 },
-    { our: 100.0, otherMin: 70.0 },
-];