overtime-live-trading-utils 3.0.0-rc.3 → 3.0.2-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "overtime-live-trading-utils",
-    "version": "3.0.0-rc.3",
+    "version": "3.0.2-rc.0",
     "description": "",
     "main": "main.js",
     "scripts": {
@@ -14,7 +14,7 @@
     "dependencies": {
         "@types/node": "^20.8.10",
         "oddslib": "^2.1.1",
-        "overtime-utils": "^0.1.44",
+        "overtime-utils": "^0.1.50",
         "react": "^17.0.1"
     },
     "devDependencies": {

package/src/constants/common.ts

@@ -1,7 +1,7 @@
 export const ZERO = 0;
 export const DRAW = 'Draw';
 export const MONEYLINE_TYPE_ID = 0;
-export const MIN_ODDS_FOR_DIFF_CHECKING = 0.2;
+export const MIN_ODDS_FOR_DIFF_CHECKING = 0.1;
 export const MAX_IMPLIED_PERCENTAGE_DIFF = 20; // 20%
 export const TAG_CHILD_SPREAD = 10001;
 export const TAG_CHILD_TOTALS = 10002;

package/src/tests/unit/bookmakers.test.ts

@@ -10,9 +10,14 @@ import {
     MockOnlyMoneylineWithDifferentSportsbook,
 } from '../mock/MockOpticSoccer';
 import { mockSoccer } from '../mock/MockSoccerRedis';
-import { getLastPolledDataForBookmakers, MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST } from '../utils/helper';
+import {
+    getLastPolledDataForBookmakers,
+    getPlayersMap,
+    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+} from '../utils/helper';
 
 const lastPolledData = getLastPolledDataForBookmakers();
+const playersMap = getPlayersMap();
 
 describe('Bookmakers', () => {
     it('Should return zero odds for moneyline when one of the bookmakers has no odds', () => {
@@ -28,7 +33,8 @@ describe('Bookmakers', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasOdds = market.odds.some(
@@ -53,7 +59,8 @@ describe('Bookmakers', () => {
             5,
             LeagueMocks.leagueInfoOnlyParent,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasOdds = market.odds.some(
@@ -78,7 +85,8 @@ describe('Bookmakers', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasOdds = market.odds.some(
@@ -103,7 +111,8 @@ describe('Bookmakers', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         expect(market.childMarkets.length).toBe(2);
@@ -122,7 +131,8 @@ describe('Bookmakers', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leaguInfoDifferentPrimaryBookmaker,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         expect(market.childMarkets.length).toBe(3);
@@ -141,7 +151,8 @@ describe('Bookmakers', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         expect(market.childMarkets.length).toBe(1);

package/src/tests/unit/markets.test.ts

@@ -5,9 +5,16 @@ import { mapOpticOddsApiFixtureOdds } from '../../utils/opticOdds';
 import { LeagueMocks } from '../mock/MockLeagueMap';
 import { MockOnlyMoneyline, MockOpticSoccer } from '../mock/MockOpticSoccer';
 import { mockSoccer } from '../mock/MockSoccerRedis';
-import { getLastPolledDataForBookmakers, MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST } from '../utils/helper';
+import { MockNbaData } from '../mock/OpticOddsMock/MockNBA';
+import { MockRedisNba } from '../mock/OpticOddsMock/MockRedisNba';
+import {
+    getLastPolledDataForBookmakers,
+    getPlayersMap,
+    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+} from '../utils/helper';
 
 const lastPolledData = getLastPolledDataForBookmakers();
+const playersMap = getPlayersMap();
 
 describe('Markets', () => {
     describe('LeagueMap configuration', () => {
@@ -25,7 +32,8 @@ describe('Markets', () => {
                 MAX_IMPLIED_PERCENTAGE_DIFF,
                 LeagueMocks.leagueInfoOnlyParent,
                 lastPolledData,
-                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
             );
 
             expect(market.childMarkets).toHaveLength(0);
@@ -44,7 +52,8 @@ describe('Markets', () => {
                 MAX_IMPLIED_PERCENTAGE_DIFF,
                 LeagueMocks.leagueInfoMockDisabledChilds,
                 lastPolledData,
-                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
             );
 
             expect(market.childMarkets).toHaveLength(0);
@@ -63,7 +72,8 @@ describe('Markets', () => {
                 MAX_IMPLIED_PERCENTAGE_DIFF,
                 LeagueMocks.leagueInfoEnabledSpreadDisabledTotals,
                 lastPolledData,
-                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
             );
 
             const containsSpread = market.childMarkets.some((child: any) => child.type === 'spread');
@@ -86,7 +96,8 @@ describe('Markets', () => {
                 MAX_IMPLIED_PERCENTAGE_DIFF,
                 LeagueMocks.leagueInfoEnabledSpeadAndTotals,
                 lastPolledData,
-                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
             );
 
             const containsSpread = market.childMarkets.some((child: any) => child.type === 'spread');
@@ -109,7 +120,8 @@ describe('Markets', () => {
                 MAX_IMPLIED_PERCENTAGE_DIFF,
                 LeagueMocks.leagueInfoEnabledAll,
                 lastPolledData,
-                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
             );
 
             const containsSpread = market.childMarkets.some((child: any) => child.type === 'spread');
@@ -164,7 +176,8 @@ describe('Markets', () => {
                 MAX_IMPLIED_PERCENTAGE_DIFF,
                 LeagueMocks.leagueInfoOnlyParentDiffSportId,
                 lastPolledData,
-                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
             );
 
             expect(warnSpy).toHaveBeenCalled();
@@ -173,5 +186,29 @@ describe('Markets', () => {
             // Restore the original implementation
             warnSpy.mockRestore();
         });
+
+        it('Should return child markets with player props', () => {
+            const freshMockSoccer = JSON.parse(JSON.stringify(MockRedisNba));
+            const freshMockOpticSoccer = JSON.parse(JSON.stringify(MockNbaData));
+            const market = processMarket(
+                freshMockSoccer,
+                mapOpticOddsApiFixtureOdds([freshMockOpticSoccer])[0],
+                ['bovada', 'draftkings'], // this will be ignored as primaryBookmaker is defined in LeagueMap
+                [],
+                true,
+                undefined,
+                MAX_IMPLIED_PERCENTAGE_DIFF,
+                LeagueMocks.PlayerAssist, // league map with player props configured
+                lastPolledData,
+                MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                playersMap
+            );
+
+            market.childMarkets.forEach((child: any) => {
+                expect(child.playerProps).toBeDefined();
+                expect(child.playerProps.playerId).toBeDefined();
+                expect(child.playerProps.playerName).toBeDefined();
+            });
+        });
     });
 });

package/src/tests/unit/odds.test.ts

@@ -10,9 +10,14 @@ import {
     MockZeroOdds,
 } from '../mock/MockOpticSoccer';
 import { mockSoccer } from '../mock/MockSoccerRedis';
-import { getLastPolledDataForBookmakers, MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST } from '../utils/helper';
+import {
+    getLastPolledDataForBookmakers,
+    getPlayersMap,
+    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+} from '../utils/helper';
 
 const lastPolledData = getLastPolledDataForBookmakers();
+const playersMap = getPlayersMap();
 
 describe('Odds', () => {
     it('Should return odds for moneyline', () => {
@@ -28,7 +33,8 @@ describe('Odds', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoOnlyParent,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasOdds = market.odds.some(
@@ -51,7 +57,8 @@ describe('Odds', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasOdds = market.odds.some(
@@ -76,7 +83,8 @@ describe('Odds', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasChildMarkets = market.childMarkets.length > 0;
@@ -96,7 +104,8 @@ describe('Odds', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         expect(market.childMarkets).toHaveLength(0);

package/src/tests/unit/spread.test.ts

@@ -5,9 +5,14 @@ import { mapOpticOddsApiFixtureOdds } from '../../utils/opticOdds';
 import { LeagueMocks } from '../mock/MockLeagueMap';
 import { MockAfterSpreadZeroOdds1, MockOnlyMoneylineFavorite, MockOpticSoccer } from '../mock/MockOpticSoccer';
 import { mockSoccer } from '../mock/MockSoccerRedis';
-import { getLastPolledDataForBookmakers, MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST } from '../utils/helper';
+import {
+    getLastPolledDataForBookmakers,
+    getPlayersMap,
+    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+} from '../utils/helper';
 
 const lastPolledData = getLastPolledDataForBookmakers();
+const playersMap = getPlayersMap();
 
 describe('Spread configuration', () => {
     it('Should return zero odds for quotes that sum up total probability above 1', () => {
@@ -23,7 +28,8 @@ describe('Spread configuration', () => {
             MAX_IMPLIED_PERCENTAGE_DIFF,
             LeagueMocks.leagueInfoEnabledSpeadAndTotals,
             lastPolledData,
-            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+            MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+            playersMap
         );
 
         const hasOdds = market.odds.some(
@@ -50,7 +56,8 @@ describe('Spread configuration', () => {
                     MAX_IMPLIED_PERCENTAGE_DIFF,
                     LeagueMocks.leagueInfoOnlyParent,
                     lastPolledData,
-                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                    playersMap
                 )
             )
         );
@@ -67,7 +74,8 @@ describe('Spread configuration', () => {
                     MAX_IMPLIED_PERCENTAGE_DIFF,
                     LeagueMocks.leagueInfoOnlyParentWithSpreadAdded,
                     lastPolledData,
-                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                    playersMap
                 )
             )
         );
@@ -104,7 +112,8 @@ describe('Spread configuration', () => {
                     MAX_IMPLIED_PERCENTAGE_DIFF,
                     LeagueMocks.leagueInfoOnlyParent,
                     lastPolledData,
-                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                    playersMap
                 )
             )
         );
@@ -121,7 +130,8 @@ describe('Spread configuration', () => {
                     MAX_IMPLIED_PERCENTAGE_DIFF,
                     LeagueMocks.leagueInfoOnlyParentWithSpreadAdded,
                     lastPolledData,
-                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST
+                    MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST,
+                    playersMap
                 )
             )
         );

package/src/tests/utils/helper.ts

@@ -8,4 +8,12 @@ export const getLastPolledDataForBookmakers = () => {
     return lastPolledData;
 };
 
+export const getPlayersMap = () => {
+    const playersMap: Map<string, number> = new Map<string, number>();
+    playersMap.set('0C07D14CC5DC', 13234);
+    playersMap.set('AD91EA260284', 56789);
+    playersMap.set('674851E026BC', 98765);
+    return playersMap;
+};
+
 export const MAX_ALLOWED_PROVIDER_DATA_STALE_DELAY_TEST = 30000; // 30 seconds

package/src/utils/markets.ts

@@ -30,7 +30,8 @@ export const processMarket = (
     maxPercentageDiffBetwenOdds: number,
     leagueMap: any,
     lastPolledData: LastPolledArray,
-    maxAllowedProviderDataStaleDelay: number
+    maxAllowedProviderDataStaleDelay: number,
+    playersMap: Map<string, number>
 ) => {
     const sportSpreadData = spreadData.filter((data: any) => data.sportId === String(market.leagueId));
     const leagueInfo = getLeagueInfo(market.leagueId, leagueMap);
@@ -89,7 +90,8 @@ export const processMarket = (
         leagueMap,
         lastPolledData,
         maxAllowedProviderDataStaleDelay,
-        maxPercentageDiffBetwenOdds
+        maxPercentageDiffBetwenOdds,
+        playersMap
     );
 
     const packedChildMarkets = childMarkets.map((childMarket: any) => {

package/src/utils/odds.ts

@@ -141,9 +141,6 @@ export const getParentOdds = (
         0 // typeId for moneyline
     );
 
-    console.log('defaultProviders', liveOddsProviders);
-    console.log('bookmakers for moneyline', bookmakers);
-
     const isValidLastPolled = isLastPolledForBookmakersValid(
         lastPolledData,
         maxAllowedProviderDataStaleDelay,
@@ -217,7 +214,8 @@ export const createChildMarkets: (
     leagueMap: any,
     lastPolledData: LastPolledArray,
     maxAllowedProviderDataStaleDelay: number,
-    maxImpliedPercentageDifference: number
+    maxImpliedPercentageDifference: number,
+    playersMap: Map<string, number>
 ) => ChildMarket[] = (
     apiResponseWithOdds,
     spreadDataForSport,
@@ -227,7 +225,8 @@ export const createChildMarkets: (
     leagueMap,
     lastPolledData,
     maxAllowedProviderDataStaleDelay,
-    maxImpliedPercentageDifference
+    maxImpliedPercentageDifference,
+    playersMap
 ) => {
     const [spreadOdds, totalOdds, moneylineOdds, correctScoreOdds, doubleChanceOdds, ggOdds, childMarkets]: any[] = [
         [],
@@ -245,7 +244,7 @@ export const createChildMarkets: (
     };
 
     if (leagueInfo.length > 0) {
-        const allChildOdds = filterOddsByMarketNameBookmaker(apiResponseWithOdds.odds, leagueInfo);
+        const allChildOdds = filterOdds(apiResponseWithOdds.odds, leagueInfo, playersMap);
         const checkedChildOdds = checkOddsFromBookmakersForChildMarkets(
             allChildOdds,
             leagueInfo,
@@ -272,7 +271,7 @@ export const createChildMarkets: (
 
         const homeAwayFormattedOdds = [
             ...groupAndFormatSpreadOdds(spreadOdds, commonData),
-            ...groupAndFormatTotalOdds(totalOdds, commonData),
+            ...groupAndFormatTotalOdds(totalOdds, commonData), // playerProps are handled inside this function
             ...groupAndFormatMoneylineOdds(moneylineOdds, commonData),
             ...groupAndFormatGGOdds(ggOdds),
             ...groupAndFormatDoubleChanceOdds(doubleChanceOdds, commonData),
@@ -287,12 +286,20 @@ export const createChildMarkets: (
         );
 
         homeAwayOddsWithSpreadAdjusted.forEach((data) => {
+            let playerProps = undefined;
+            if (data.playerProps) {
+                playerProps = {
+                    playerId: playersMap.get(data.playerProps.playerId.toString()), // convert from opticOdds playerId to our internal playerId
+                    playerName: data.playerProps.playerName,
+                };
+            }
             const childMarket = {
                 leagueId: Number(data.sportId),
                 typeId: Number(data.typeId),
                 type: MarketTypeMap[data.typeId as MarketType]?.key || '',
                 line: Number(data.line || 0),
                 odds: data.odds,
+                playerProps,
             };
             const leagueInfoByTypeId = leagueInfo.find((league) => Number(league.typeId) === Number(data.typeId));
             const minOdds = leagueInfoByTypeId?.minOdds; // minimum odds configured for child market (e.g. 0.95 implied probability)
@@ -346,7 +353,7 @@ export const createChildMarkets: (
  * @param {string} oddsProvider - The main odds provider to filter by.
  * @returns {Array} The filtered odds array.
  */
-export const filterOddsByMarketNameBookmaker = (oddsArray: Odds, leagueInfos: LeagueConfigInfo[]): any => {
+export const filterOdds = (oddsArray: Odds, leagueInfos: LeagueConfigInfo[], playersMap: Map<string, number>): any => {
     const allChildMarketsTypes = leagueInfos
         .filter(
             (leagueInfo) =>
@@ -356,7 +363,10 @@ export const filterOddsByMarketNameBookmaker = (oddsArray: Odds, leagueInfos: Le
         .map((leagueInfo) => leagueInfo.marketName.toLowerCase());
     return oddsArray.reduce((acc: any, odd: any) => {
         if (allChildMarketsTypes.includes(odd.marketName.toLowerCase())) {
-            const { points, marketName, selection, selectionLine, sportsBookName } = odd;
+            const { points, marketName, selection, selectionLine, sportsBookName, playerId } = odd;
+            if (playerId && !playersMap.has(playerId)) {
+                return acc;
+            }
             const key = `${sportsBookName.toLowerCase()}_${marketName.toLowerCase()}_${points}_${selection}_${selectionLine}`;
             acc[key] = {
                 ...odd,
@@ -443,6 +453,13 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
             acc[key].typeId = odd.typeId;
             acc[key].type = odd.type;
             acc[key].sportId = odd.sportId;
+
+            if (odd.playerId) {
+                acc[key].playerProps = {
+                    playerId: odd.playerId, // Player ID from OpticOdds, this will be converted to our internal playerId later
+                    playerName: odd.selection,
+                };
+            }
         }
 
         return acc;
@@ -450,8 +467,8 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
 
     // Format the grouped odds into the desired output
     const formattedOdds = Object.entries(groupedOdds as any).reduce((acc: any, [key, value]) => {
-        const [_marketName, selection, selectionLine] = key.split('_');
-        const line = parseFloat(selectionLine);
+        const [_marketName, selection, points] = key.split('_');
+        const line = parseFloat(points);
 
         // if we have away team in total odds we know the market is team total and we need to increase typeId by one.
         // if this is false typeId is already mapped correctly
@@ -463,6 +480,7 @@ export const groupAndFormatTotalOdds = (oddsArray: any[], commonData: HomeAwayTe
                 typeId: !isAwayTeam ? (value as any).typeId : Number((value as any).typeId) + 1,
                 sportId: (value as any).sportId,
                 type: (value as any).type,
+                playerProps: (value as any).playerProps,
             });
         }
         return acc;