overtime-live-trading-utils 3.0.0-rc.0 → 3.0.0-rc.1

package/src/tests/mock/OpticOddsMock/MockRedisNba.ts

@@ -0,0 +1,21 @@
+export const MockRedisNba = {
+    leagueId: 4,
+    typeId: 0,
+    odds: [
+        {
+            american: -140.056022408986,
+            decimal: 1.71399999999988,
+            normalizedImplied: 0.583430571762,
+        },
+        {
+            american: 450.00000000055,
+            decimal: 5.5000000000055,
+            normalizedImplied: 0.181818181818,
+        },
+        {
+            american: 234.999999999514,
+            decimal: 3.34999999999514,
+            normalizedImplied: 0.298507462687,
+        },
+    ],
+};

package/src/tests/utils/helper.ts

@@ -4,6 +4,7 @@ export const getLastPolledDataForBookmakers = () => {
     const lastPolledData: LastPolledArray = [];
     lastPolledData.push({ sportsbook: 'draftkings', timestamp: Date.now() });
     lastPolledData.push({ sportsbook: 'bovada', timestamp: Date.now() });
+    lastPolledData.push({ sportsbook: 'superbet', timestamp: Date.now() });
     return lastPolledData;
 };
 

package/src/utils/bookmakers.ts

@@ -204,7 +204,7 @@ export const checkOddsFromBookmakersForChildMarkets = (
     odds: any,
     leagueInfos: LeagueConfigInfo[],
     oddsProviders: string[],
-    lastPolledMap: LastPolledArray,
+    lastPolledData: LastPolledArray,
     maxAllowedProviderDataStaleDelay: number,
     maxImpliedPercentageDifference: number
 ): OddsWithLeagueInfo => {
@@ -212,20 +212,21 @@ export const checkOddsFromBookmakersForChildMarkets = (
         const [sportsBookName, marketName, points, selection, selectionLine] = key.split('_');
         const info = leagueInfos.find((leagueInfo) => leagueInfo.marketName.toLowerCase() === marketName.toLowerCase());
         if (info) {
-            const { primaryBookmaker, secondaryBookmaker } = getPrimaryAndSecondaryBookmakerForTypeId(
+            const bookmakers = getPrimaryAndSecondaryBookmakerForTypeId(
                 oddsProviders,
                 leagueInfos,
                 Number(info.typeId)
             );
 
             const isValidLastPolled = isLastPolledForBookmakersValid(
-                lastPolledMap,
+                lastPolledData,
                 maxAllowedProviderDataStaleDelay,
-                primaryBookmaker,
-                secondaryBookmaker
+                bookmakers
             );
 
             if (isValidLastPolled) {
+                const primaryBookmaker = bookmakers[0];
+                const secondaryBookmaker = bookmakers[1];
                 if (primaryBookmaker && !secondaryBookmaker) {
                     if (sportsBookName.toLowerCase() === primaryBookmaker.toLowerCase()) {
                         acc.push(value);
@@ -267,7 +268,7 @@ export const getPrimaryAndSecondaryBookmakerForTypeId = (
     defaultProviders: string[],
     leagueInfos: LeagueConfigInfo[], // LeagueConfigInfo for specific sport, not the entire list from csv
     typeId: number
-): { primaryBookmaker: string; secondaryBookmaker: string | undefined } => {
+): string[] => {
     const info = leagueInfos.find((leagueInfo) => Number(leagueInfo.typeId) === typeId);
     let primaryBookmaker = defaultProviders[0].toLowerCase();
     let secondaryBookmaker = defaultProviders[1] ? defaultProviders[1].toLowerCase() : undefined;
@@ -277,43 +278,29 @@ export const getPrimaryAndSecondaryBookmakerForTypeId = (
             secondaryBookmaker = info.secondaryBookmaker ? info.secondaryBookmaker.toLowerCase() : undefined;
         }
     }
-    return { primaryBookmaker, secondaryBookmaker };
+    return secondaryBookmaker ? [primaryBookmaker, secondaryBookmaker] : [primaryBookmaker];
 };
 
 export const isLastPolledForBookmakersValid = (
-    lastPolledMap: LastPolledArray,
+    lastPolledData: LastPolledArray,
     maxAllowedProviderDataStaleDelay: number,
-    primaryBookmaker: string,
-    secondaryBookmaker?: string
+    bookmakers: string[]
 ): boolean => {
-    const lastPolledTimePrimary = lastPolledMap.find(
-        (entry) => entry.sportsbook.toLowerCase() === primaryBookmaker.toLowerCase()
-    )?.timestamp;
-    if (typeof lastPolledTimePrimary !== 'number') {
-        return false;
-    }
-
     const now = new Date();
-    if (secondaryBookmaker) {
-        const lastPolledTimeSecondary = lastPolledMap.find(
-            (entry) => entry.sportsbook.toLowerCase() === secondaryBookmaker.toLowerCase()
+    const isNotValid = bookmakers.some((bookmakerId) => {
+        const lastPolledTime = lastPolledData.find(
+            (entry) => entry.sportsbook.toLowerCase() === bookmakerId.toLowerCase()
         )?.timestamp;
-
-        if (typeof lastPolledTimeSecondary !== 'number') {
-            return false;
+        if (typeof lastPolledTime !== 'number') {
+            return true;
         }
-
-        const oddsDate = new Date(lastPolledTimeSecondary * 1000);
+        const oddsDate = new Date(lastPolledTime * 1000);
         const timeDiff = now.getTime() - oddsDate.getTime();
         if (timeDiff > maxAllowedProviderDataStaleDelay) {
-            return false;
+            return true;
         }
-    }
-
-    const oddsDate = new Date(lastPolledTimePrimary * 1000);
-    const timeDiff = now.getTime() - oddsDate.getTime();
-
-    return timeDiff <= maxAllowedProviderDataStaleDelay;
+    });
+    return !isNotValid;
 };
 
 export const calculateImpliedOddsDifference = (impliedOddsA: number, impliedOddsB: number): number => {

package/src/utils/odds.ts

@@ -135,7 +135,7 @@ export const getParentOdds = (
 ) => {
     const commonData = { homeTeam: oddsApiObject.homeTeam, awayTeam: oddsApiObject.awayTeam };
 
-    const { primaryBookmaker, secondaryBookmaker } = getPrimaryAndSecondaryBookmakerForTypeId(
+    const bookmakers = getPrimaryAndSecondaryBookmakerForTypeId(
         liveOddsProviders,
         leagueInfo,
         0 // typeId for moneyline
@@ -144,8 +144,7 @@ export const getParentOdds = (
     const isValidLastPolled = isLastPolledForBookmakersValid(
         lastPolledData,
         maxAllowedProviderDataStaleDelay,
-        primaryBookmaker,
-        secondaryBookmaker
+        bookmakers
     );
 
     if (!isValidLastPolled) {
@@ -159,7 +158,7 @@ export const getParentOdds = (
     const moneylineOddsMap = filterOddsByMarketNameTeamNameBookmaker(
         oddsApiObject.odds,
         MoneylineTypes.MONEYLINE,
-        liveOddsProviders,
+        bookmakers,
         commonData,
         isTwoPositionalSport
     );
@@ -167,7 +166,7 @@ export const getParentOdds = (
     // CHECKING AND COMPARING ODDS FOR THE GIVEN BOOKMAKERS
     const oddsObject = checkOddsFromBookmakers(
         moneylineOddsMap,
-        liveOddsProviders,
+        bookmakers,
         isTwoPositionalSport,
         maxPercentageDiffBetwenOdds,
         MIN_ODDS_FOR_DIFF_CHECKING