overtime-live-trading-utils 2.1.34 → 2.1.35

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "overtime-live-trading-utils",
-    "version": "2.1.34",
+    "version": "2.1.35",
     "description": "",
     "main": "main.js",
     "scripts": {

package/resolution_live_markets.md

@@ -1,12 +1,15 @@
 # Live Market Resolution - TypeId-Based Implementation Plan
 
 ## Overview
+
 Enhance the resolution utilities to support checking if specific market types (identified by `typeId`) can be resolved based on which periods are complete in a live game.
 
 ## Problem Statement
+
 The current `canResolveMarketForGameIdAndSport` function only checks if periods are complete, but doesn't answer the key question: **"Can I resolve market type 10021 (e.g., 1st Quarter Winner) right now?"**
 
 For live trading, we need to know which specific markets can be resolved based on:
+
 1. Which periods have been completed
 2. The market type (typeId)
 3. Whether the game is still live or fully completed
@@ -14,12 +17,14 @@ For live trading, we need to know which specific markets can be resolved based o
 ## Understanding TypeIds
 
 TypeIds identify specific market types:
-- `10021` - 1st period/quarter/half markets (various bet types)
-- `10022` - 2nd period markets
-- `10031` - 1st period totals
-- `0`, `10001`, `10002` - Full game markets (should NOT resolve during live games)
+
+-   `10021` - 1st period/quarter/half markets (various bet types)
+-   `10022` - 2nd period markets
+-   `10031` - 1st period totals
+-   `0`, `10001`, `10002` - Full game markets (should NOT resolve during live games)
 
 Example from codebase:
+
 ```typescript
 {
     sportId: 9806,
@@ -32,6 +37,7 @@ Example from codebase:
 ## Solution Design
 
 ### 1. Sport-Specific Period-to-TypeId Mappings
+
 Created three separate mappings for different sport period structures:
 
 ```typescript
@@ -70,13 +76,15 @@ const FULL_GAME_TYPE_IDS = [0, 10001, 10002, 10003, 10004, 10010, 10011, 10012];
 ```
 
 **Key Insight**: TypeId 10051 (1st half) resolves at different periods depending on sport type:
-- Soccer (HALVES): Period 1
-- NFL (QUARTERS): Period 2 (after both quarters 1 & 2)
-- MLB (INNINGS): Period 5 (after first 5 innings)
+
+-   Soccer (HALVES): Period 1
+-   NFL (QUARTERS): Period 2 (after both quarters 1 & 2)
+-   MLB (INNINGS): Period 5 (after first 5 innings)
 
 ### 2. Updated Function Signature
 
 **Before:**
+
 ```typescript
 canResolveMarketForGameIdAndSport(
     gameId: string,
@@ -86,6 +94,7 @@ canResolveMarketForGameIdAndSport(
 ```
 
 **After:**
+
 ```typescript
 // Single typeId overload
 canResolveMarketsForEvent(
@@ -122,7 +131,7 @@ function selectMappingForSportType(sportType: SportPeriodType) {
 export function canResolveMarketsForEvent(
     event: OpticOddsEvent,
     typeIdOrTypeIds: number | number[],
-    sportType: SportPeriodType,  // REQUIRED - must specify sport type
+    sportType: SportPeriodType, // REQUIRED - must specify sport type
     sportName?: string
 ): boolean | number[] {
     // Get completed periods
@@ -143,7 +152,7 @@ export function canResolveMarketsForEvent(
 
     for (const period of periodData.completedPeriods) {
         const typeIdsForPeriod = mapping[period] || [];
-        typeIdsForPeriod.forEach(id => resolvableTypeIds.add(id));
+        typeIdsForPeriod.forEach((id) => resolvableTypeIds.add(id));
     }
 
     // Full game typeIds can only be resolved when game is completed
@@ -163,7 +172,7 @@ export function canResolveMarketsForEvent(
 
     // Batch typeIds check
     if (typeIds !== undefined) {
-        return typeIds.filter(id => {
+        return typeIds.filter((id) => {
             // Exclude full game typeIds during live games
             if (!isCompleted && FULL_GAME_TYPE_IDS.includes(id)) {
                 return false;
@@ -173,76 +182,80 @@ export function canResolveMarketsForEvent(
     }
 
     return false;
-};
+}
 ```
 
 ### 4. Why Sport Parameter is Needed
 
 Different sports have different period structures:
-- **Soccer**: 2 halves (periods 1-2)
-- **NFL/NBA**: 4 quarters (periods 1-4)
-- **MLB**: 9+ innings (periods 1-9)
-- **NHL**: 3 periods (periods 1-3)
-- **Tennis**: Sets (periods 1-5)
+
+-   **Soccer**: 2 halves (periods 1-2)
+-   **NFL/NBA**: 4 quarters (periods 1-4)
+-   **MLB**: 9+ innings (periods 1-9)
+-   **NHL**: 3 periods (periods 1-3)
+-   **Tennis**: Sets (periods 1-5)
 
 The sport parameter allows future customization where period-to-typeId mappings could be sport-specific. For example:
-- Soccer might map period 1 → "1st Half" markets
-- Basketball might map period 1 → "1st Quarter" markets
-- Both use period 1, but represent different market types
+
+-   Soccer might map period 1 → "1st Half" markets
+-   Basketball might map period 1 → "1st Quarter" markets
+-   Both use period 1, but represent different market types
 
 ## Implementation Steps
 
 ### Phase 1: Add Sport-Specific Mappings ✅ COMPLETED
-- [x] Add `SportPeriodType` enum to `src/types/resolution.ts`
-- [x] Add `HALVES_PERIOD_TYPE_ID_MAPPING` to `src/types/resolution.ts`
-- [x] Add `QUARTERS_PERIOD_TYPE_ID_MAPPING` to `src/types/resolution.ts`
-- [x] Add `INNINGS_PERIOD_TYPE_ID_MAPPING` to `src/types/resolution.ts`
-- [x] Add `FULL_GAME_TYPE_IDS` to `src/types/resolution.ts`
-- [x] Export all constants and enum
+
+-   [x] Add `SportPeriodType` enum to `src/types/resolution.ts`
+-   [x] Add `HALVES_PERIOD_TYPE_ID_MAPPING` to `src/types/resolution.ts`
+-   [x] Add `QUARTERS_PERIOD_TYPE_ID_MAPPING` to `src/types/resolution.ts`
+-   [x] Add `INNINGS_PERIOD_TYPE_ID_MAPPING` to `src/types/resolution.ts`
+-   [x] Add `FULL_GAME_TYPE_IDS` to `src/types/resolution.ts`
+-   [x] Export all constants and enum
 
 ### Phase 2: Update Resolution Function ✅ COMPLETED
-- [x] Update `canResolveMarketsForEvent` function signature to accept `sportType` parameter
-- [x] Implement sport-type-based mapping selection logic
-- [x] Update function overloads for clean API (no undefined placeholders)
-- [x] Handle full game typeIds exclusion during live games
-- [x] Keep backward compatibility with existing functions
+
+-   [x] Update `canResolveMarketsForEvent` function signature to accept `sportType` parameter
+-   [x] Implement sport-type-based mapping selection logic
+-   [x] Update function overloads for clean API (no undefined placeholders)
+-   [x] Handle full game typeIds exclusion during live games
+-   [x] Keep backward compatibility with existing functions
 
 ### Phase 3: Add Tests ✅ COMPLETED
-- [x] Test single typeId resolution
-- [x] Test batch typeIds resolution
-- [x] Test that full game typeIds are NOT resolved during live games
-- [x] Test with real event data (Soccer, NFL, MLB)
-- [x] Test edge cases (no completed periods, game in overtime, etc.)
-- [x] Add sport-specific tests for typeId 10051 (1st half) with HALVES, QUARTERS, INNINGS
-- [x] Add sport-specific tests for typeId 10052 (2nd half)
-- [x] Test default behavior (QUARTERS_BASED when no sportType provided)
+
+-   [x] Test single typeId resolution
+-   [x] Test batch typeIds resolution
+-   [x] Test that full game typeIds are NOT resolved during live games
+-   [x] Test with real event data (Soccer, NFL, MLB)
+-   [x] Test edge cases (no completed periods, game in overtime, etc.)
+-   [x] Add sport-specific tests for typeId 10051 (1st half) with HALVES, QUARTERS, INNINGS
+-   [x] Add sport-specific tests for typeId 10052 (2nd half)
+-   [x] Test default behavior (QUARTERS_BASED when no sportType provided)
 
 ### Phase 4: Update Exports ✅ COMPLETED
-- [x] Export `SportPeriodType` enum from index.ts
-- [x] Export `HALVES_PERIOD_TYPE_ID_MAPPING` from index.ts
-- [x] Export `QUARTERS_PERIOD_TYPE_ID_MAPPING` from index.ts
-- [x] Export `INNINGS_PERIOD_TYPE_ID_MAPPING` from index.ts
-- [x] Export `FULL_GAME_TYPE_IDS` from index.ts
-- [x] Keep existing exports for backward compatibility
+
+-   [x] Export `SportPeriodType` enum from index.ts
+-   [x] Export `HALVES_PERIOD_TYPE_ID_MAPPING` from index.ts
+-   [x] Export `QUARTERS_PERIOD_TYPE_ID_MAPPING` from index.ts
+-   [x] Export `INNINGS_PERIOD_TYPE_ID_MAPPING` from index.ts
+-   [x] Export `FULL_GAME_TYPE_IDS` from index.ts
+-   [x] Keep existing exports for backward compatibility
 
 ### Phase 5: Testing & Validation ✅ COMPLETED
-- [x] Run full test suite
-- [x] Verify all 85 tests pass
-- [x] Test with real OpticOdds API responses (Soccer, NFL, MLB)
-- [x] Verify TypeScript compilation succeeds
+
+-   [x] Run full test suite
+-   [x] Verify all 85 tests pass
+-   [x] Test with real OpticOdds API responses (Soccer, NFL, MLB)
+-   [x] Verify TypeScript compilation succeeds
 
 ## Example Usage
 
 ### Single TypeId Check
+
 ```typescript
 import { canResolveMarketsForEvent, SportPeriodType } from 'overtime-live-trading-utils';
 
 // Check NFL (quarters-based) - Can we resolve "1st Quarter Winner" market (typeId 10021)?
-const canResolve = canResolveMarketsForEvent(
-    nflEvent,
-    10021,
-    SportPeriodType.QUARTERS_BASED
-);
+const canResolve = canResolveMarketsForEvent(nflEvent, 10021, SportPeriodType.QUARTERS_BASED);
 
 if (canResolve) {
     // Resolve the 1st quarter market
@@ -251,52 +264,40 @@ if (canResolve) {
 ```
 
 ### Sport-Specific TypeId 10051 (1st Half) Resolution
+
 ```typescript
 // Soccer (halves-based): Resolves after period 1
-const soccerCanResolve = canResolveMarketsForEvent(
-    soccerEvent,
-    10051,
-    SportPeriodType.HALVES_BASED
-); // true if period 1 complete
+const soccerCanResolve = canResolveMarketsForEvent(soccerEvent, 10051, SportPeriodType.HALVES_BASED); // true if period 1 complete
 
 // NFL (quarters-based): Resolves after period 2
-const nflCanResolve = canResolveMarketsForEvent(
-    nflEvent,
-    10051,
-    SportPeriodType.QUARTERS_BASED
-); // true if period 2 complete
+const nflCanResolve = canResolveMarketsForEvent(nflEvent, 10051, SportPeriodType.QUARTERS_BASED); // true if period 2 complete
 
 // MLB (innings-based): Resolves after period 5
-const mlbCanResolve = canResolveMarketsForEvent(
-    mlbEvent,
-    10051,
-    SportPeriodType.INNINGS_BASED
-); // true if period 5 complete
+const mlbCanResolve = canResolveMarketsForEvent(mlbEvent, 10051, SportPeriodType.INNINGS_BASED); // true if period 5 complete
 ```
 
 ### Batch TypeIds Check
+
 ```typescript
 // Which of these markets can we resolve right now for an NFL game?
 const marketTypeIds = [10021, 10022, 10031, 10001];
-const resolvableMarkets = canResolveMarketsForEvent(
-    nflEvent,
-    marketTypeIds,
-    SportPeriodType.QUARTERS_BASED
-);
+const resolvableMarkets = canResolveMarketsForEvent(nflEvent, marketTypeIds, SportPeriodType.QUARTERS_BASED);
 
 // Returns: [10021, 10031] if only period 1 is complete
 // Full game typeId 10001 is excluded during live games
-resolvableMarkets.forEach(typeId => resolveMarket(typeId));
+resolvableMarkets.forEach((typeId) => resolveMarket(typeId));
 ```
 
 ### Function Overloads (TypeScript)
+
 The function uses TypeScript overloads for clean API:
+
 ```typescript
 // Single typeId → returns boolean
 function canResolveMarketsForEvent(
     event: OpticOddsEvent,
     typeId: number,
-    sportType: SportPeriodType,  // REQUIRED
+    sportType: SportPeriodType, // REQUIRED
     sportName?: string
 ): boolean;
 
@@ -304,7 +305,7 @@ function canResolveMarketsForEvent(
 function canResolveMarketsForEvent(
     event: OpticOddsEvent,
     typeIds: number[],
-    sportType: SportPeriodType,  // REQUIRED
+    sportType: SportPeriodType, // REQUIRED
     sportName?: string
 ): number[];
 ```
@@ -312,25 +313,29 @@ function canResolveMarketsForEvent(
 ## Testing Strategy
 
 ### Test Cases
+
 1. **Period 1 Complete (Live Soccer 2nd Half)**
-   - Input: Soccer event in 2nd half, period 1 complete
-   - TypeIds: [10021, 10022, 10001]
-   - Expected: [10021] (only 1st half markets resolvable)
+
+    - Input: Soccer event in 2nd half, period 1 complete
+    - TypeIds: [10021, 10022, 10001]
+    - Expected: [10021] (only 1st half markets resolvable)
 
 2. **Periods 1-4 Complete (NFL Overtime)**
-   - Input: NFL event in overtime, all 4 quarters complete
-   - TypeIds: [10021, 10022, 10023, 10024, 10001]
-   - Expected: [10021, 10022, 10023, 10024] (all quarter markets, but not full game)
+
+    - Input: NFL event in overtime, all 4 quarters complete
+    - TypeIds: [10021, 10022, 10023, 10024, 10001]
+    - Expected: [10021, 10022, 10023, 10024] (all quarter markets, but not full game)
 
 3. **Game Completed**
-   - Input: Completed game with all periods
-   - TypeIds: [10021, 10001]
-   - Expected: [10021, 10001] (all markets including full game)
+
+    - Input: Completed game with all periods
+    - TypeIds: [10021, 10001]
+    - Expected: [10021, 10001] (all markets including full game)
 
 4. **No Periods Complete**
-   - Input: Live game in 1st period
-   - TypeIds: [10021, 10022]
-   - Expected: [] (no markets resolvable yet)
+    - Input: Live game in 1st period
+    - TypeIds: [10021, 10022]
+    - Expected: [] (no markets resolvable yet)
 
 ## Benefits
 

package/src/tests/mock/MockOpticOddsEvents.ts

@@ -516,3 +516,147 @@ export const MockNFLCompletedWithOvertime = {
         clock: null,
     },
 };
+
+export const MockNBACompletedEvent = {
+    sport: {
+        id: 'basketball',
+        name: 'Basketball',
+        numerical_id: 4,
+    },
+    league: {
+        id: 'nba',
+        name: 'NBA',
+        numerical_id: 355,
+    },
+    fixture: {
+        id: '202511053DEE59D4',
+        numerical_id: 402396,
+        game_id: '10459-24860-2025-11-04',
+        start_date: '2025-11-05T03:00:00Z',
+        home_competitors: [
+            {
+                id: 'DFC9A735A4D7',
+                name: 'Golden State Warriors',
+                numerical_id: 21801,
+                base_id: 14357,
+                abbreviation: 'GSW',
+                logo: 'https://cdn.opticodds.com/team-logos/basketball/14357.png',
+            },
+        ],
+        away_competitors: [
+            {
+                id: '9BF9A5FD18B1',
+                name: 'Phoenix Suns',
+                numerical_id: 21815,
+                base_id: 14371,
+                abbreviation: 'PHX',
+                logo: 'https://cdn.opticodds.com/team-logos/basketball/14371.png',
+            },
+        ],
+        home_team_display: 'Golden State Warriors',
+        away_team_display: 'Phoenix Suns',
+        status: 'completed',
+        is_live: false,
+        season_type: 'Regular Season',
+        season_year: '2025',
+        season_week: '45',
+        venue_name: 'Chase Center',
+        venue_location: 'San Francisco, CA, USA',
+        venue_neutral: false,
+    },
+    scores: {
+        home: {
+            total: 118.0,
+            periods: {
+                period_1: 33.0,
+                period_2: 35.0,
+                period_3: 24.0,
+                period_4: 26.0,
+            },
+            aggregate: null,
+        },
+        away: {
+            total: 107.0,
+            periods: {
+                period_1: 19.0,
+                period_2: 30.0,
+                period_3: 34.0,
+                period_4: 24.0,
+            },
+            aggregate: null,
+        },
+    },
+    in_play: {
+        period: '4',
+        clock: null,
+    },
+};
+
+export const MockNBALiveAtHalftime = {
+    sport: {
+        id: 'basketball',
+        name: 'Basketball',
+        numerical_id: 4,
+    },
+    league: {
+        id: 'nba',
+        name: 'NBA',
+        numerical_id: 355,
+    },
+    fixture: {
+        id: '202511053DEE59D4',
+        numerical_id: 402396,
+        game_id: '10459-24860-2025-11-04',
+        start_date: '2025-11-05T03:00:00Z',
+        home_competitors: [
+            {
+                id: 'DFC9A735A4D7',
+                name: 'Golden State Warriors',
+                numerical_id: 21801,
+                base_id: 14357,
+                abbreviation: 'GSW',
+                logo: 'https://cdn.opticodds.com/team-logos/basketball/14357.png',
+            },
+        ],
+        away_competitors: [
+            {
+                id: '9BF9A5FD18B1',
+                name: 'Phoenix Suns',
+                numerical_id: 21815,
+                base_id: 14371,
+                abbreviation: 'PHX',
+                logo: 'https://cdn.opticodds.com/team-logos/basketball/14371.png',
+            },
+        ],
+        home_team_display: 'Golden State Warriors',
+        away_team_display: 'Phoenix Suns',
+        status: 'half',
+        is_live: true,
+        season_type: 'Regular Season',
+        season_year: '2025',
+        season_week: '45',
+        venue_name: 'Chase Center',
+        venue_location: 'San Francisco, CA, USA',
+        venue_neutral: false,
+    },
+    scores: {
+        home: {
+            total: 68.0,
+            periods: {
+                period_1: 33.0,
+                period_2: 35.0,
+            },
+        },
+        away: {
+            total: 49.0,
+            periods: {
+                period_1: 19.0,
+                period_2: 30.0,
+            },
+        },
+    },
+    in_play: {
+        period: 'half',
+        clock: null,
+    },
+};