overtime-live-trading-utils 2.1.30 → 2.1.31

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "overtime-live-trading-utils",
-    "version": "2.1.30",
+    "version": "2.1.31",
     "description": "",
     "main": "main.js",
     "scripts": {

package/src/tests/unit/resolution.test.ts

@@ -568,6 +568,64 @@ describe('Resolution Utils', () => {
 
             expect(result).toBeNull();
         });
+
+        it('Bug Fix: Should NOT mark current period as complete when future periods have data (live in period 3)', () => {
+            // This tests the bug where OpticOdds API includes future period data with scores (including zeros)
+            // Period 3 is currently being played, period 4 has 0-0 scores but hasn't started
+            const event = {
+                status: 'live',
+                is_live: true,
+                in_play: { period: '3' },
+                scores: {
+                    home: { periods: { period_1: 33, period_2: 32, period_3: 12, period_4: 0 } },
+                    away: { periods: { period_1: 23, period_2: 27, period_3: 18, period_4: 0 } },
+                },
+            };
+
+            const result = detectCompletedPeriods(event);
+
+            expect(result).not.toBeNull();
+            expect(result?.completedPeriods).toEqual([1, 2]); // Only periods 1 and 2 are complete
+            expect(result?.currentPeriod).toBe(3);
+            // Period 3 is currently being played, so NOT complete
+            // Period 4 has data (0-0) but hasn't started, so NOT complete
+        });
+
+        it('Bug Fix: Should mark all periods as complete for completed game', () => {
+            const event = {
+                status: 'completed',
+                is_live: false,
+                scores: {
+                    home: { periods: { period_1: 33, period_2: 32, period_3: 25, period_4: 20 } },
+                    away: { periods: { period_1: 23, period_2: 27, period_3: 18, period_4: 22 } },
+                },
+            };
+
+            const result = detectCompletedPeriods(event);
+
+            expect(result).not.toBeNull();
+            expect(result?.completedPeriods).toEqual([1, 2, 3, 4]);
+            // All periods complete because game status is 'completed'
+        });
+
+        it('Bug Fix: Should NOT mark current period as complete during transition to period 4', () => {
+            const event = {
+                status: 'live',
+                is_live: true,
+                in_play: { period: '4' },
+                scores: {
+                    home: { periods: { period_1: 33, period_2: 32, period_3: 25, period_4: 5 } },
+                    away: { periods: { period_1: 23, period_2: 27, period_3: 18, period_4: 3 } },
+                },
+            };
+
+            const result = detectCompletedPeriods(event);
+
+            expect(result).not.toBeNull();
+            expect(result?.completedPeriods).toEqual([1, 2, 3]); // Periods 1, 2, 3 are complete
+            expect(result?.currentPeriod).toBe(4);
+            // Period 4 is currently in_play, so NOT complete yet
+        });
     });
 
 

package/src/utils/resolution.ts

@@ -60,26 +60,27 @@ export const detectCompletedPeriods = (
             periodScores[`period${periodNum}`] = { home: homeScore, away: awayScore };
 
             // Period is complete if:
-            // 1. Next period exists in periods data, OR
-            // 2. Game is completed, OR
-            // 3. Game is live with numeric period AND current live period is greater than this period, OR
-            // 4. Game is in overtime (all regulation periods are complete)
-            const nextPeriodKey = `period_${periodNum + 1}`;
+            // 1. Game is completed (status = completed/finished), OR
+            // 2. Game is live AND in_play.period is GREATER than this period, OR
+            // 3. Game is in overtime (all regulation periods are complete)
+            //
+            // Note: We do NOT check if next period exists in data, as OpticOdds may include
+            //       future periods with scores (including zeros). Only in_play.period is
+            //       the source of truth for live games.
             const isCompleted = status === 'completed' || status === 'complete' || status === 'finished';
-            const hasNextPeriod = homePeriods[nextPeriodKey] !== undefined && awayPeriods[nextPeriodKey] !== undefined;
             const isCompletedInLiveGame = isLive && currentLivePeriod !== null && currentLivePeriod > periodNum;
 
-            if (hasNextPeriod || isCompleted || isCompletedInLiveGame || isInOvertime) {
+            if (isCompleted || isCompletedInLiveGame || isInOvertime) {
                 completedPeriods.push(periodNum);
             }
         }
     }
 
     // Determine current period
-    // If we have a numeric in_play period and it's greater than highest period in data, use it
+    // For live games with numeric in_play period, use that as the authoritative current period
     // Otherwise use highest period number from the data
     const highestPeriodInData = periodKeys.length > 0 ? Math.max(...periodKeys) : undefined;
-    const currentPeriod = currentLivePeriod && currentLivePeriod > (highestPeriodInData || 0)
+    const currentPeriod = isLive && currentLivePeriod !== null
         ? currentLivePeriod
         : highestPeriodInData;