overtime-live-trading-utils 2.0.38 → 2.0.40

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "overtime-live-trading-utils",
-    "version": "2.0.38",
+    "version": "2.0.40",
     "description": "",
     "main": "main.js",
     "scripts": {

package/src/constants/errors.ts

@@ -2,4 +2,4 @@ export const ZERO_ODDS_MESSAGE = 'Returning zero odds cause bookmakers have 0 or
 export const DIFF_BETWEEN_BOOKMAKERS_MESSAGE = 'Returning zero odds due to percentage difference between bookmakers';
 export const NO_MATCHING_BOOKMAKERS_MESSAGE = 'Returning zero odds cause no matching bookmakers have been found';
 export const ZERO_ODDS_AFTER_SPREAD_ADJUSTMENT = 'Bad odds after spread adjustment';
-export const NO_MARKETS_FOR_LEAGUE_ID = 'No child markets for leagueID: 9806';
+export const NO_MARKETS_FOR_LEAGUE_ID = 'No child markets for leagueID';

package/src/tests/mock/MockSoccerRedis.ts

@@ -50,7 +50,6 @@ export const mockSoccer = {
         '0x80974b0005f2b5c5ea75d1717a23c7a4c907839a585aadee58d0c4baacdfc4e8',
         '0x20e31e07d357ce06a783a29a13f5eac28664182ecd6e7bee3b41ba131cc606eb',
     ],
-    isV3: true,
     childMarkets: [
         {
             gameId: '0x3030394130434633343445450000000000000000000000000000000000000000',

package/src/tests/unit/bookmakers.test.ts

@@ -50,6 +50,7 @@ describe('Bookmakers', () => {
         expect(hasOdds).toBe(false);
         expect(market).toHaveProperty('errorMessage');
         expect(market.errorMessage).toBe(DIFF_BETWEEN_BOOKMAKERS_MESSAGE);
+        expect(market).not.toHaveProperty('childMarkets');
     });
 
     it('Should return zero odds for moneyline as no matching bookmaker was provided', () => {

package/src/tests/unit/markets.test.ts

@@ -130,7 +130,7 @@ describe('Markets', () => {
             );
 
             expect(warnSpy).toHaveBeenCalled();
-            expect(warnSpy).toHaveBeenCalledWith(NO_MARKETS_FOR_LEAGUE_ID);
+            expect(warnSpy).toHaveBeenCalledWith(`${NO_MARKETS_FOR_LEAGUE_ID}: ${Number(mockSoccer.leagueId)}`);
 
             // Restore the original implementation
             warnSpy.mockRestore();

package/src/utils/bookmakers.ts

@@ -1,4 +1,9 @@
 import * as oddslib from 'oddslib';
+import {
+    DIFF_BETWEEN_BOOKMAKERS_MESSAGE,
+    NO_MATCHING_BOOKMAKERS_MESSAGE,
+    ZERO_ODDS_MESSAGE,
+} from '../constants/errors';
 
 export const getBookmakersArray = (bookmakersData: any[], sportId: any, backupLiveOddsProviders: string[]) => {
     const sportBookmakersData = bookmakersData.find((data) => Number(data.sportId) === Number(sportId));
@@ -33,7 +38,7 @@ export const checkOddsFromBookmakers = (
             homeOdds: 0,
             awayOdds: 0,
             drawOdds: 0,
-            errorMessage: 'Returning zero odds cause no matching bookmakers have been found',
+            errorMessage: NO_MATCHING_BOOKMAKERS_MESSAGE,
         };
     }
 
@@ -63,7 +68,7 @@ export const checkOddsFromBookmakers = (
             homeOdds: 0,
             awayOdds: 0,
             drawOdds: 0,
-            errorMessage: `Returning zero odds cause bookmakers have 0 or 1 odds`,
+            errorMessage: ZERO_ODDS_MESSAGE,
             // TODO: Return sportsbook name with zero odds
         };
     }
@@ -128,7 +133,7 @@ export const checkOddsFromBookmakers = (
                 return true;
             }
         }
-        return false; // fix for es-lint
+        return false;
     });
 
     if (hasLargeImpliedPercentageDifference) {
@@ -136,7 +141,7 @@ export const checkOddsFromBookmakers = (
             homeOdds: 0,
             awayOdds: 0,
             drawOdds: 0,
-            errorMessage: 'Returning zero odds due to percentage difference between bookmakers',
+            errorMessage: DIFF_BETWEEN_BOOKMAKERS_MESSAGE,
         };
     }
 

package/src/utils/markets.ts

@@ -1,4 +1,5 @@
 import * as oddslib from 'oddslib';
+import { DIFF_BETWEEN_BOOKMAKERS_MESSAGE, ZERO_ODDS_AFTER_SPREAD_ADJUSTMENT } from '../constants/errors';
 import { OddsObject } from '../types/odds';
 import { createChildMarkets, getParentOdds } from './odds';
 import { getLeagueInfo } from './sports';
@@ -63,7 +64,7 @@ export const processMarket = (
                     normalizedImplied: probability,
                 };
             } else {
-                market.errorMessage = 'Bad odds after spread adjustment';
+                market.errorMessage = ZERO_ODDS_AFTER_SPREAD_ADJUSTMENT;
                 return {
                     american: 0,
                     decimal: 0,
@@ -73,38 +74,42 @@ export const processMarket = (
         });
     }
 
-    const childMarkets = createChildMarkets(
-        apiResponseWithOdds,
-        sportSpreadData,
-        market.leagueId,
-        liveOddsProviders,
-        defaultSpreadForLiveMarkets,
-        leagueMap
-    );
+    if (moneylineOdds.errorMessage === DIFF_BETWEEN_BOOKMAKERS_MESSAGE) {
+        delete market.childMarkets;
+    } else {
+        const childMarkets = createChildMarkets(
+            apiResponseWithOdds,
+            sportSpreadData,
+            market.leagueId,
+            liveOddsProviders,
+            defaultSpreadForLiveMarkets,
+            leagueMap
+        );
+
+        const packedChildMarkets = childMarkets.map((childMarket: any) => {
+            const preparedMarket = { ...market, ...childMarket };
+            const oddsAfterSpread = adjustAddedSpread(preparedMarket.odds, leagueInfo, preparedMarket.typeId);
+            if (preparedMarket.odds.length > 0) {
+                preparedMarket.odds = oddsAfterSpread.map((probability) => {
+                    if (probability == 0) {
+                        return {
+                            american: 0,
+                            decimal: 0,
+                            normalizedImplied: 0,
+                        };
+                    }
 
-    const packedChildMarkets = childMarkets.map((childMarket: any) => {
-        const preparedMarket = { ...market, ...childMarket };
-        const oddsAfterSpread = adjustAddedSpread(preparedMarket.odds, leagueInfo, preparedMarket.typeId);
-        if (preparedMarket.odds.length > 0) {
-            preparedMarket.odds = oddsAfterSpread.map((probability) => {
-                if (probability == 0) {
                     return {
-                        american: 0,
-                        decimal: 0,
-                        normalizedImplied: 0,
+                        american: oddslib.from('impliedProbability', probability).to('moneyline'),
+                        decimal: Number(oddslib.from('impliedProbability', probability).to('decimal').toFixed(10)),
+                        normalizedImplied: probability,
                     };
-                }
-
-                return {
-                    american: oddslib.from('impliedProbability', probability).to('moneyline'),
-                    decimal: Number(oddslib.from('impliedProbability', probability).to('decimal').toFixed(10)),
-                    normalizedImplied: probability,
-                };
-            });
-        }
-        return preparedMarket;
-    });
-    market.childMarkets = packedChildMarkets;
+                });
+            }
+            return preparedMarket;
+        });
+        market.childMarkets = packedChildMarkets;
+    }
 
     return market;
 };

package/src/utils/odds.ts

@@ -1,6 +1,7 @@
 import * as oddslib from 'oddslib';
 import { MarketType, MarketTypeMap } from 'overtime-utils';
 import { DRAW, MIN_ODDS_FOR_DIFF_CHECKING, MONEYLINE_TYPE_ID, ZERO } from '../constants/common';
+import { NO_MARKETS_FOR_LEAGUE_ID } from '../constants/errors';
 import { MoneylineTypes } from '../enums/sports';
 import { HomeAwayTeams, Odds, OddsObject } from '../types/odds';
 import { ChildMarket, LeagueConfigInfo } from '../types/sports';
@@ -286,7 +287,7 @@ export const createChildMarkets: (
             childMarkets.push(childMarket);
         });
     } else {
-        console.warn(`No child markets for leagueID: ${Number(leagueId)}`);
+        console.warn(`${NO_MARKETS_FOR_LEAGUE_ID}: ${Number(leagueId)}`);
     }
 
     return childMarkets;