osborn 0.9.231 → 0.9.233

package/dist/claude-llm.js

@@ -58,7 +58,13 @@ async function buildRecallInjection(sessionId, workingDir, prompt) {
         // fetch, not a local model load). If embed is null, recall() runs keyword-only.
         const embed = process.env.OSBORN_EMBED !== '0' ? (await getEmbedder(QUERY_EMBED_TIMEOUT_MS)) ?? undefined : undefined;
         const { getStorePath } = await import('./session-store.js');
-        const db = openStore(getStorePath(sessionId, workingDir));
+        // READ-ONLY open (regression fix): the writable branch runs synchronous
+        // migration/DDL + meta writes every turn AND lock-contends with the concurrent
+        // ingest writer (triggerStoreUpdate) — under WAL those serialize, stacking the
+        // 5s busy_timeout per statement and blowing the UserPromptSubmit hook past 30s.
+        // A readonly connection takes only SHARED locks and never blocks. storeExists()
+        // above guarantees the DB is present, so readonly can't fail on a missing file.
+        const db = openStore(getStorePath(sessionId, workingDir), { readonly: true });
         let hits;
         try {
             hits = await recall(db, q, { mode: embed ? 'hybrid' : 'keyword', topK: RECALL_TOP_K, embed });
@@ -896,9 +902,12 @@ export const VERIFIER_CHAIN = {
             'at most 2 fix rounds, after which surface the outcome to the user rather than looping.',
     },
     researcher: {
-        afterReminder: 'The researcher sub-agent just finished. Before you finalize, use the Task tool to dispatch the ' +
-            '`reasoner` gate to judge whether the research is complete and well-sourced for the original ' +
-            'question. If it returns NEEDS-MORE, send the researcher back — at most 2 rounds, then surface.',
+        afterReminder: 'The researcher sub-agent just finished. Before you finalize, you MUST now use the Task tool to ' +
+            'dispatch the `reasoner` GATE to judge whether the research is complete and well-sourced for the ' +
+            'original question — it returns GATE: PASS or GATE: NEEDS-MORE. ' +
+            'If it returns NEEDS-MORE, dispatch the `researcher` again with the gaps it named and then re-gate — ' +
+            'at most 2 rounds, after which surface the outcome to the user rather than looping. ' +
+            "This is the research analogue of writer→reviewer: don't rely on the findings until an independent agent has vetted them.",
     },
 };
 const RESEARCH_TOOLS = [
@@ -1627,6 +1636,11 @@ export class ClaudeLLM extends llm.LLM {
             else {
                 console.error('❌ Persistent session error:', error);
                 callbacks.eventEmitter.emit('tts_say', { text: 'Sorry, I encountered an error.' });
+                // Surface the failure to any listener (background slots wire this to a
+                // background_session_error → frontend). Without it a cold-start crash here
+                // is swallowed and the "Spawning…" UI hangs forever. Harmless for the main
+                // agent (no consumer_error listener; it already spoke the error above).
+                callbacks.eventEmitter.emit('consumer_error', { message: String(error?.message || error) });
             }
         }
         finally {

package/dist/index.js

@@ -2259,6 +2259,12 @@ async function main() {
             console.error(`❌ Background slot ${slotId.substring(0, 8)}: resume failed — requested ${requestedSessionId?.substring(0, 8)} got ${actualSessionId?.substring(0, 8)}`);
             sendToFrontend({ type: 'background_session_error', slotId, error: 'Session resume failed' }).catch(() => { });
         });
+        // Cold-start crash in the background consumer (claude-llm #startBackgroundConsumer
+        // catch): surface it so the frontend's "Spawning…" clears instead of hanging forever.
+        bgEmitter.on('consumer_error', ({ message }) => {
+            console.error(`❌ Background slot ${slotId.substring(0, 8)}: consumer error — ${message}`);
+            sendToFrontend({ type: 'background_session_error', slotId, error: String(message || 'Background session failed to start') }).catch(() => { });
+        });
         // P1: a real dispatch finished — notify the frontend. The [BACKGROUND_INIT]
         // ack also fires assistant_result, so gate on dispatchInFlight to skip it.
         bgEmitter.on('assistant_result', ({ text }) => {

package/dist/prompts/direct-mode-research.md

@@ -113,9 +113,9 @@ THE SUB-AGENTS:
   · NEVER use the SDK's built-in 'general-purpose' agent — it is not configured for this project and will hit write blocks. Always pick researcher, reasoner, writer, tester, or reviewer explicitly.
 
 DIVISION OF LABOR — follow this chain by default for any substantive or code task:
-  researcher (gather facts) → planner (step plan for multi-step work) → THEN dispatch writer AND tester IN THE SAME STEP, in parallel: the writer executes the plan while the tester writes tests from the spec, blind to the implementation (TDD) → after the writer returns, RUN the tester's tests against the new code AND dispatch the reviewer on the diff → on test-FAIL or REJECT, send the writer back to fix and re-verify (at most 2 rounds) → you synthesize and speak.
-For a quick factual query: researcher only → you speak.
-NEVER skip the tester+reviewer verification after a code change — and dispatch the tester IN PARALLEL with the writer (not after), so tests are written independently of the code.
+  researcher (gather facts) → after the researcher returns on a substantive question, dispatch the `reasoner` GATE to judge whether the research is complete and well-sourced (GATE: PASS / NEEDS-MORE); on NEEDS-MORE send the researcher back with the named gaps and re-gate (at most 2 rounds) → planner (step plan for multi-step work) → THEN dispatch writer AND tester IN THE SAME STEP, in parallel: the writer executes the plan while the tester writes tests from the spec, blind to the implementation (TDD) → after the writer returns, RUN the tester's tests against the new code AND dispatch the reviewer on the diff → on test-FAIL or REJECT, send the writer back to fix and re-verify (at most 2 rounds) → you synthesize and speak.
+For a quick factual lookup: researcher only → you speak (a trivial lookup needs no gate).
+NEVER skip verification — it is symmetric across both flows: the reasoner GATE after substantive research, and the tester+reviewer after a code change. Both are the same pattern (generate → an INDEPENDENT agent verifies before you rely on it). Dispatch the tester IN PARALLEL with the writer (not after) so tests are written independently of the code.
 You may OVERRIDE this chain at any time — stop a running agent, inject, or reorder — because you can see each task's live state. The chain is the default, not a cage.
 Surfacing findings and communicating to the user is YOUR job, not a sub-agent's.
 </turn-shape>

package/dist/session-store.js

@@ -525,8 +525,18 @@ export async function recall(db, query, opts) {
         const qvecs = await opts.embed([query]);
         const qv = qvecs?.[0];
         if (qv) {
-            const rows = db.prepare('SELECT rowid AS id FROM vec WHERE embedding MATCH vec_int8(?) ORDER BY distance LIMIT ?').all(Buffer.from(qv.buffer, qv.byteOffset, qv.byteLength), pool);
-            rows.forEach((r, i) => vec.set(r.id, i));
+            try {
+                // sqlite-vec KNN REQUIRES an explicit `k = ?` bound; relying on LIMIT alone can
+                // degrade to a brute-force full scan over every int8[EMBED_DIM] row — a multi-second
+                // synchronous stall on a large session. `k = pool` caps the KNN search itself.
+                // Wrapped like the keyword leg: a vec0 version/index mismatch degrades to
+                // keyword-only rather than throwing out of recall() for callers without an outer guard.
+                const rows = db.prepare('SELECT rowid AS id FROM vec WHERE embedding MATCH vec_int8(?) AND k = ? ORDER BY distance').all(Buffer.from(qv.buffer, qv.byteOffset, qv.byteLength), pool);
+                rows.forEach((r, i) => vec.set(r.id, i));
+            }
+            catch {
+                // vec query failed (stale index / dim mismatch) — ignore vector leg, keep keyword
+            }
         }
     }
     // ── Reciprocal Rank Fusion ──

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "osborn",
-  "version": "0.9.231",
+  "version": "0.9.233",
   "description": "Voice AI coding assistant - local agent that connects to Osborn frontend",
   "type": "module",
   "bin": {