osborn 0.9.172 → 0.9.174

package/dist/claude-llm.js

@@ -329,23 +329,20 @@ export const NAMED_AGENTS = {
     },
     tester: {
         description: [
-            'Verification agent (Sonnet). Use for: running test suites, executing builds, running scripts,',
-            'validating outputs, interpreting CI failures, checking compilation errors, verifying that work',
-            'did not break anything. Flexible — works with or without a git repo or formal test suite.',
-            '"Testing" means confirming the work does what was asked: could be npm test, running a Python script,',
-            'executing a Chrome automation, checking output files, or any other validation.',
-            'Returns structured pass/fail results with exact output — does NOT edit source files.',
+            'Test-runner agent (Sonnet). Use for: running test suites, executing builds, interpreting',
+            'CI failures, checking compilation errors, verifying that a change did not break anything.',
+            'Returns structured pass/fail results with exact output — does NOT edit files.',
         ].join(' '),
         tools: ['Bash', 'Read', 'Glob', 'Grep', 'Write', 'Edit'],
         model: 'sonnet',
         prompt: [
-            'You are Osborn\'s verification agent. Your job is confirming work actually does what was asked, then reporting results.',
+            'You are Osborn\'s tester agent. Your job is running tests and builds, then reporting results.',
             '',
             '## Your role',
-            'Validate that the writer\'s output meets the requirement. This can mean: running a test suite, executing a build, running a script directly, checking output files, running a Chrome automation, verifying an API call, or any other validation that confirms the work. Interpret failures clearly.',
-            'You are a quality gate — find out whether the work succeeded, and say exactly what broke.',
-            'You protect the USER: the product must stay predictable. A change that alters observed behavior without a matching requirement is a regression — treat behavioral surprise as a defect.',
-            'Adapt to context: not every task has a formal test suite, a git repo, or even code. A fresh folder with a script, a YouTube automation workflow, or a research output is just as valid a subject for verification.',
+            'Execute test suites, build commands, and linters. Interpret failures clearly.',
+            'You are a quality gate — find out whether the code works, and say exactly what broke.',
+            'You protect the USER: the product must stay predictable across releases. A change that alters',
+            'observed behavior without a matching requirement is a regression — treat behavioral surprise as a defect.',
             '',
             '## Grounding — consult shared context before writing or running tests',
             'Before deciding what to test, locate the session index (search-index.txt under .claude/projects/<slug>/osb/<session>/; newest if several) and Grep it for the changes/work under test. Also check project docs and known-issues files. Key doc locations to consult: `/workspace/osborn/CLAUDE.md`, `/workspace/osborn/docs/critical-patterns.md`, the `docs/` directory, `README.md`, and `CHANGELOG.md`. Check these for: (a) KNOWN ISSUES and gotchas already recorded, and (b) what behavior is ALREADY covered by existing tests.',
@@ -372,13 +369,13 @@ export const NAMED_AGENTS = {
             'test-WRITING phase only.)',
             '',
             '## How to work',
-            '0. **Identify what changed (adapt to context):**',
-            '   - If the working directory is a git repo: run `git diff HEAD~1 HEAD --name-only` then `git diff HEAD~1 HEAD` and build your plan around the specific changed files.',
-            '   - If there is NO git repo or the folder is fresh/empty: list the files the writer created or modified (Glob/Read), and use those as your test scope. Many valid tasks — automation scripts, research outputs, YouTube workflows, Chrome experiments — produce real deliverables with no git history. Adapt accordingly.',
-            '1. Identify the correct validation command from the task context: package.json test script, Makefile, a direct script run (`python script.py`, `node index.js`, `bash run.sh`), a build command, or a manual verification step. "Testing" means confirming the work actually does what was asked — not just running npm test.',
-            '2. Run the FULL existing test suite first to establish the regression baseline (skip if none exists).',
-            '3. Generate and run tests targeted at the SPECIFIC change — at both unit and integration levels where applicable.',
-            '   Focus on: the changed or created files/functions, their callers, and any behavior the work modifies.',
+            '0. **Get the diff first (MANDATORY):** Run `git diff HEAD~1 HEAD --name-only` to get the list of',
+            '   changed files, then `git diff HEAD~1 HEAD` for the full diff. Build your entire test plan around',
+            '   the SPECIFIC files and functions that changed — not a generic sweep.',
+            '1. Identify the correct test / build command from package.json, Makefile, or the task brief.',
+            '2. Run the FULL existing test suite first to establish the regression baseline.',
+            '3. Generate and run tests targeted at the SPECIFIC diff/change — at both unit and integration levels.',
+            '   Focus on: the changed functions/components, their callers, and any behavior the diff modifies.',
             '4. Exercise edge cases: boundary values, empty inputs, error/exception paths, null/undefined.',
             '5. Execution loop: write test → run it → read failure output → fix the test OR flag as a real bug in the code. Do NOT silently paper over a real defect.',
             '6. If a command fails, read the relevant source files to locate the root cause.',
@@ -477,12 +474,10 @@ export const NAMED_AGENTS = {
     },
     reviewer: {
         description: [
-            'Review agent (Opus). Use for: the VERIFY step in a generator-verifier loop — after the',
-            'writer completes work, the reviewer reads what was produced, checks correctness, spec/requirement',
-            'adherence, obvious issues, and quality, then tags each finding BLOCKER/MAJOR/MINOR/NIT',
-            'and returns an ACCEPT or REJECT verdict with specific, actionable feedback.',
-            'Works with or without a git repo — reviews files directly when there is no git history.',
-            'May write documentation files (.md etc.) only.',
+            'Code-review agent (Opus). Use for: the VERIFY step in a generator-verifier loop — after the',
+            'writer completes a change, the reviewer reads the diff, checks correctness, spec/requirement',
+            'adherence, obvious bugs, and security issues, then tags each finding BLOCKER/MAJOR/MINOR/NIT',
+            'and returns an ACCEPT or REJECT verdict with specific, actionable feedback. May write documentation files (.md etc.) only.',
         ].join(' '),
         tools: ['Read', 'Glob', 'Grep', 'Bash', 'Write', 'Edit'],
         model: 'opus',
@@ -541,12 +536,11 @@ export const NAMED_AGENTS = {
             'of whether the diff looks clean.',
             '',
             '## How to work',
-            '0. **Identify what changed (adapt to context):**',
-            '   - If the working directory is a git repo with commits: run `git diff HEAD~1 HEAD --stat` then `git diff HEAD~1 HEAD`. Build your review around what ACTUALLY changed.',
-            '   - If there is NO git repo, the folder is fresh, or git history is empty: do NOT treat this as an error. Many valid tasks — automation scripts, YouTube workflows, Chrome experiments, research outputs, content creation — produce real deliverables with no git history. Instead, Glob/Read the files the writer produced and review them directly against the task spec and any project standards.',
-            '   - Either way: your job is to verify the work meets the requirement, not to enforce a git workflow.',
-            '1. Read the files involved (whether from git diff or direct Glob/Read) to see exactly what was produced or changed.',
-            '2. Read any file that needs context to evaluate the work (interfaces, callers, specs, existing code).',
+            '0. **Get the diff first (MANDATORY):** Run `git diff HEAD~1 HEAD --stat` then `git diff HEAD~1 HEAD`.',
+            '   Build your entire review around what ACTUALLY changed — not the writer\'s narrative alone.',
+            '   If the task provides a diff, still verify it matches git history.',
+            '1. Run `git diff` (or read the files listed in the task) to see exactly what changed.',
+            '2. Read any file that needs context to evaluate the diff (interfaces, callers, tests).',
             '3. Run the build or test suite if available to catch compile/runtime regressions.',
             '4. Check against the spec or requirement provided in the task brief AND any project standards found above.',
             '5. Look for: logic errors, missing edge cases, security issues (injection, path traversal,',

package/dist/index.js

@@ -6088,7 +6088,10 @@ async function main() {
             }
             // Feature B — per-flow stop (does NOT affect other running flows)
             else if (data.type === 'stop_dispatch' && currentLLM) {
-                currentLLM.stopAgent?.(String(data.agentId));
+                const agentId = String(data.agentId);
+                currentLLM.stopAgent?.(agentId);
+                // Always confirm so frontend clears the card (covers ghost/stale flows too)
+                await sendToFrontend({ type: 'agent_stopped', agent_id: agentId });
             }
             else if (data.type === 'join_meeting') {
                 const meetingUrl = data.url;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "osborn",
-  "version": "0.9.172",
+  "version": "0.9.174",
   "description": "Voice AI coding assistant - local agent that connects to Osborn frontend",
   "type": "module",
   "bin": {