orkeon-code 1.0.0-rc.1 → 1.0.0-rc.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.orkeon-runtime +10 -0
- package/.orkeon-version +1 -1
- package/NOTICE.md +1 -1
- package/README.fr.md +16 -22
- package/README.md +16 -22
- package/config/appsettings.jev.example.json +4 -1
- package/config/appsettings.kev.example.json +4 -1
- package/config/appsettings.liquid.example.json +4 -1
- package/config/appsettings.ollama-whisper.example.json +1 -0
- package/config/appsettings.whisper.example.json +1 -0
- package/mcp/whisper/README.md +2 -1
- package/orkeon-code +206 -11
- package/orkeon-code.ps1 +109 -7
- package/package.json +2 -1
- package/src/commands/.orkeon/orkeon-cli.d.ts +1 -4
- package/src/commands/_lib/args.ts +5 -4
- package/src/commands/_lib/dev/dev-batches.ts +34 -36
- package/src/commands/_lib/dev/dev-implement.ts +11 -14
- package/src/commands/_lib/dev/dev-source.ts +7 -11
- package/src/commands/_lib/dev/dev.ts +34 -37
- package/src/commands/_lib/dev/markers.ts +7 -0
- package/src/commands/_lib/dev/messages.ts +112 -0
- package/src/commands/_lib/dev-step.ts +16 -13
- package/src/commands/_lib/dispatch.ts +62 -39
- package/src/commands/_lib/git/branch.ts +9 -10
- package/src/commands/_lib/git/commit.ts +9 -13
- package/src/commands/_lib/git/diff.ts +22 -12
- package/src/commands/_lib/git/messages.ts +54 -0
- package/src/commands/_lib/git/review.ts +9 -10
- package/src/commands/_lib/memory/memory-admit.ts +19 -21
- package/src/commands/_lib/memory/memory.ts +3 -2
- package/src/commands/_lib/memory/messages.ts +32 -0
- package/src/commands/_lib/messages.ts +48 -0
- package/src/commands/_lib/project/messages.ts +8 -0
- package/src/commands/_lib/session/export.ts +3 -2
- package/src/commands/_lib/session/messages.ts +87 -0
- package/src/commands/_lib/session/prompts.ts +4 -0
- package/src/commands/_lib/session/resume.ts +15 -24
- package/src/commands/_lib/session/tasks.ts +20 -23
- package/src/commands/_lib/settings/advisor.ts +11 -16
- package/src/commands/_lib/settings/agents.ts +18 -28
- package/src/commands/_lib/settings/choices.ts +8 -0
- package/src/commands/_lib/settings/config.ts +43 -43
- package/src/commands/_lib/settings/effort.ts +147 -0
- package/src/commands/_lib/settings/hooks.ts +12 -20
- package/src/commands/_lib/settings/messages.ts +408 -0
- package/src/commands/_lib/settings/mode.ts +33 -24
- package/src/commands/_lib/settings/model.ts +71 -36
- package/src/commands/_lib/settings/output-style.ts +39 -0
- package/src/commands/_lib/settings/permissions.ts +71 -93
- package/src/commands/_lib/settings/route.ts +63 -0
- package/src/commands/_lib/settings/skills.ts +53 -11
- package/src/commands/_lib/settings/theme.ts +42 -0
- package/src/commands/_lib/speech/messages.ts +58 -0
- package/src/commands/_lib/speech/prompts.ts +4 -0
- package/src/commands/_lib/speech/say.ts +9 -10
- package/src/commands/_lib/speech/transcribe.ts +14 -23
- package/src/commands/_lib/speech/voice.ts +14 -18
- package/src/commands/_lib/status/doctor.ts +47 -28
- package/src/commands/_lib/status/messages.ts +100 -0
- package/src/commands/_lib/status/meta.ts +3 -24
- package/src/commands/_lib/status/status.ts +10 -11
- package/src/commands/_lib/status/usage-tools.ts +2 -3
- package/src/commands/_lib/status/usage.ts +7 -18
- package/src/commands/_lib/view.ts +6 -1
- package/src/commands/dev/dev-batches.cmd.ts +4 -3
- package/src/commands/dev/dev-learn.cmd.ts +3 -3
- package/src/commands/dev/dev-plan.cmd.ts +6 -7
- package/src/commands/dev/dev-spec.cmd.ts +6 -7
- package/src/commands/git/commit.cmd.ts +3 -3
- package/src/commands/git/review.cmd.ts +3 -3
- package/src/commands/memory/memory.cmd.ts +2 -2
- package/src/commands/project/analyze.cmd.ts +3 -3
- package/src/commands/project/debug-tool-call.cmd.ts +4 -9
- package/src/commands/project/init-verifiers.cmd.ts +3 -3
- package/src/commands/project/init.cmd.ts +3 -3
- package/src/commands/project/verify.cmd.ts +2 -2
- package/src/commands/session/assistant.cmd.ts +2 -2
- package/src/commands/session/compact.cmd.ts +1 -1
- package/src/commands/session/copy.cmd.ts +8 -7
- package/src/commands/session/rename.cmd.ts +3 -2
- package/src/commands/session/rewind.cmd.ts +3 -4
- package/src/commands/session/summary.cmd.ts +3 -3
- package/src/commands/session/tasks.cmd.ts +4 -2
- package/src/commands/settings/config.cmd.ts +4 -2
- package/src/commands/settings/effort.cmd.ts +10 -31
- package/src/commands/settings/fast.cmd.ts +2 -1
- package/src/commands/settings/mode.cmd.ts +3 -3
- package/src/commands/settings/model.cmd.ts +3 -2
- package/src/commands/settings/output-style.cmd.ts +9 -38
- package/src/commands/settings/permissions.cmd.ts +2 -2
- package/src/commands/settings/proactive.cmd.ts +2 -1
- package/src/commands/settings/route.cmd.ts +16 -0
- package/src/commands/settings/skills.cmd.ts +3 -3
- package/src/commands/settings/theme.cmd.ts +14 -0
- package/src/commands/speech/say.cmd.ts +2 -2
- package/src/commands/speech/transcribe.cmd.ts +2 -2
- package/src/commands/status/release-notes.cmd.ts +1 -1
- package/src/crews/.orkeon/orkeon.d.ts +538 -93
- package/src/crews/_probe-shared-memory/domain/messages.ts +54 -0
- package/src/crews/_probe-shared-memory/domain/probe-verdict.ts +17 -12
- package/src/crews/_probe-shared-memory/domain/prompts.ts +5 -0
- package/src/crews/_probe-shared-memory/probe.ork.ts +5 -3
- package/src/crews/advisor/application/messages.ts +4 -0
- package/src/crews/advisor/application/prompts.ts +4 -0
- package/src/crews/advisor/application/run-advisor.ts +2 -1
- package/src/crews/advisor/crew.ork.ts +5 -4
- package/src/crews/advisor/domain/advice.ts +7 -23
- package/src/crews/advisor/domain/messages.ts +8 -0
- package/src/crews/advisor/domain/prompts.ts +26 -0
- package/src/crews/agent-run/application/messages.ts +18 -0
- package/src/crews/agent-run/application/run-agent-run.ts +5 -4
- package/src/crews/agent-run/crew.ork.ts +3 -3
- package/src/crews/analyze/application/messages.ts +27 -0
- package/src/crews/analyze/application/prompts.ts +4 -0
- package/src/crews/analyze/application/run-analyze.ts +16 -14
- package/src/crews/analyze/crew.ork.ts +5 -4
- package/src/crews/analyze/domain/harvest.ts +33 -65
- package/src/crews/analyze/domain/prompts.ts +86 -0
- package/src/crews/code-review/application/lens-material.ts +24 -0
- package/src/crews/code-review/application/messages.ts +17 -0
- package/src/crews/code-review/application/prompts.ts +10 -17
- package/src/crews/code-review/application/review.ts +4 -1
- package/src/crews/code-review/application/run-code-review.ts +13 -15
- package/src/crews/code-review/crew.ork.ts +5 -4
- package/src/crews/code-review/domain/lenses.ts +6 -45
- package/src/crews/code-review/domain/messages.ts +25 -0
- package/src/crews/code-review/domain/prompts.ts +58 -0
- package/src/crews/code-review/domain/report.ts +5 -6
- package/src/crews/code-review/domain/scope.ts +6 -12
- package/src/crews/dev-batches/application/messages.ts +127 -0
- package/src/crews/dev-batches/application/plan-close.ts +12 -12
- package/src/crews/dev-batches/application/prompts.ts +10 -0
- package/src/crews/dev-batches/application/run-dev-batches.ts +57 -50
- package/src/crews/dev-batches/application/run-wave.ts +24 -22
- package/src/crews/dev-batches/application/seed-harvest.ts +8 -7
- package/src/crews/dev-batches/crew.ork.ts +12 -9
- package/src/crews/dev-batches/domain/batches-log.ts +1 -3
- package/src/crews/dev-batches/domain/markers.ts +5 -0
- package/src/crews/dev-batches/domain/messages.ts +6 -0
- package/src/crews/dev-batches/domain/wave-order.ts +3 -2
- package/src/crews/dev-change/application/change-material.ts +44 -0
- package/src/crews/dev-change/application/evidence.ts +25 -22
- package/src/crews/dev-change/application/messages.ts +81 -0
- package/src/crews/dev-change/application/{change-prompt.ts → prompts.ts} +40 -43
- package/src/crews/dev-change/application/run-dev-change.ts +43 -34
- package/src/crews/dev-change/crew.ork.ts +11 -9
- package/src/crews/dev-change/domain/change-answer.ts +24 -20
- package/src/crews/dev-change/domain/change-render.ts +13 -15
- package/src/crews/dev-change/domain/markers.ts +28 -0
- package/src/crews/dev-change/domain/messages.ts +16 -0
- package/src/crews/dev-implement/application/close.ts +21 -18
- package/src/crews/dev-implement/application/locate-sheet.ts +7 -5
- package/src/crews/dev-implement/application/messages.ts +161 -0
- package/src/crews/dev-implement/application/observe.ts +4 -2
- package/src/crews/dev-implement/application/prompts.ts +9 -0
- package/src/crews/dev-implement/application/report-writes.ts +14 -9
- package/src/crews/dev-implement/application/run-dev-implement.ts +84 -73
- package/src/crews/dev-implement/application/suite-job.ts +15 -11
- package/src/crews/dev-implement/crew.ork.ts +2 -1
- package/src/crews/dev-implement/domain/contracts.ts +59 -60
- package/src/crews/dev-implement/domain/correction.ts +16 -15
- package/src/crews/dev-implement/domain/cycles.ts +2 -1
- package/src/crews/dev-implement/domain/markers.ts +23 -0
- package/src/crews/dev-implement/domain/messages.ts +58 -0
- package/src/crews/dev-implement/domain/prompts.ts +93 -0
- package/src/crews/dev-implement/domain/roles.ts +3 -7
- package/src/crews/dev-implement/domain/sheet-edits.ts +6 -5
- package/src/crews/dev-implement/domain/sheet-ticks.ts +5 -4
- package/src/crews/dev-implement/domain/step-checks.ts +17 -16
- package/src/crews/dev-implement/domain/step-section.ts +6 -4
- package/src/crews/dev-learn/application/learn-prompt-fit.ts +63 -0
- package/src/crews/dev-learn/application/messages.ts +51 -0
- package/src/crews/dev-learn/application/{learn-prompt.ts → prompts.ts} +24 -65
- package/src/crews/dev-learn/application/run-dev-learn.ts +37 -32
- package/src/crews/dev-learn/crew.ork.ts +4 -3
- package/src/crews/dev-learn/domain/learn-answer.ts +25 -27
- package/src/crews/dev-learn/domain/messages.ts +65 -0
- package/src/crews/dev-learn/domain/owner-lines.ts +12 -9
- package/src/crews/dev-learn/domain/proposals-render.ts +8 -9
- package/src/crews/dev-plan/application/anchor-paths.ts +57 -20
- package/src/crews/dev-plan/application/inventory.ts +17 -13
- package/src/crews/dev-plan/application/messages.ts +88 -0
- package/src/crews/dev-plan/application/plan-prompt-fit.ts +44 -0
- package/src/crews/dev-plan/application/{plan-prompt.ts → prompts.ts} +37 -55
- package/src/crews/dev-plan/application/run-dev-plan.ts +103 -75
- package/src/crews/dev-plan/crew.ork.ts +11 -8
- package/src/crews/dev-plan/domain/inventory-model.ts +3 -3
- package/src/crews/dev-plan/domain/markers.ts +18 -0
- package/src/crews/dev-plan/domain/messages.ts +118 -0
- package/src/crews/dev-plan/domain/plan-answer.ts +118 -103
- package/src/crews/dev-plan/domain/plan-render.ts +30 -31
- package/src/crews/dev-plan/domain/prompts.ts +44 -0
- package/src/crews/dev-spec/application/messages.ts +30 -0
- package/src/crews/dev-spec/application/{spec-prompt.ts → prompts.ts} +42 -47
- package/src/crews/dev-spec/application/run-dev-spec.ts +67 -36
- package/src/crews/dev-spec/application/spec-material.ts +42 -0
- package/src/crews/dev-spec/crew.ork.ts +11 -9
- package/src/crews/dev-spec/domain/markers.ts +30 -0
- package/src/crews/dev-spec/domain/messages.ts +39 -0
- package/src/crews/dev-spec/domain/spec-answer.ts +46 -47
- package/src/crews/dev-spec/domain/spec-render.ts +18 -18
- package/src/crews/dev-verify/application/audit-brief.ts +187 -0
- package/src/crews/dev-verify/application/audit.ts +38 -30
- package/src/crews/dev-verify/application/capture.ts +34 -26
- package/src/crews/dev-verify/application/messages.ts +119 -0
- package/src/crews/dev-verify/application/prompts.ts +209 -0
- package/src/crews/dev-verify/application/run-dev-verify.ts +60 -46
- package/src/crews/dev-verify/application/run-gate.ts +11 -9
- package/src/crews/dev-verify/crew.ork.ts +6 -6
- package/src/crews/dev-verify/domain/audit-answer.ts +16 -12
- package/src/crews/dev-verify/domain/capture-sections.ts +5 -4
- package/src/crews/dev-verify/domain/commands.ts +3 -3
- package/src/crews/dev-verify/domain/gate.ts +21 -16
- package/src/crews/dev-verify/domain/markers.ts +16 -0
- package/src/crews/dev-verify/domain/mechanical-table.ts +37 -44
- package/src/crews/dev-verify/domain/messages.ts +92 -0
- package/src/crews/dev-verify/domain/verdict.ts +4 -4
- package/src/crews/git-commit/application/draft.ts +16 -37
- package/src/crews/git-commit/application/messages.ts +15 -0
- package/src/crews/git-commit/application/prompts.ts +47 -0
- package/src/crews/git-commit/application/run-git-commit.ts +13 -12
- package/src/crews/git-commit/crew.ork.ts +5 -4
- package/src/crews/git-commit/domain/commit.ts +15 -35
- package/src/crews/git-commit/domain/markers.ts +4 -0
- package/src/crews/git-commit/domain/messages.ts +48 -0
- package/src/crews/init-verifiers/application/authoring.ts +2 -1
- package/src/crews/init-verifiers/application/messages.ts +13 -0
- package/src/crews/init-verifiers/application/prompts.ts +5 -1
- package/src/crews/init-verifiers/application/run-init-verifiers.ts +3 -2
- package/src/crews/init-verifiers/crew.ork.ts +5 -4
- package/src/crews/main-loop/application/auto-compact.ts +2 -1
- package/src/crews/main-loop/application/messages.ts +81 -0
- package/src/crews/main-loop/application/prompts.ts +12 -0
- package/src/crews/main-loop/application/run-main-loop.ts +63 -30
- package/src/crews/main-loop/application/{turn-prompt.ts → turn-context.ts} +7 -8
- package/src/crews/main-loop/crew.ork.ts +12 -7
- package/src/crews/main-loop/domain/prompt-assembly.ts +45 -228
- package/src/crews/main-loop/domain/prompts.ts +336 -0
- package/src/crews/main-loop/domain/turn-chains.ts +10 -9
- package/src/crews/project-init/application/detect.ts +5 -4
- package/src/crews/project-init/application/messages.ts +15 -0
- package/src/crews/project-init/application/prompts.ts +11 -7
- package/src/crews/project-init/crew.ork.ts +5 -4
- package/src/crews/project-init/domain/existing-files.ts +6 -4
- package/src/crews/project-init/domain/messages.ts +13 -0
- package/src/crews/project-init/domain/package-map.ts +3 -3
- package/src/crews/project-init/domain/prompts.ts +10 -0
- package/src/crews/session-compact/application/prompts.ts +5 -0
- package/src/crews/session-compact/crew.ork.ts +5 -4
- package/src/crews/shared-memory-admit/application/prompts.ts +5 -0
- package/src/crews/shared-memory-admit/crew.ork.ts +3 -2
- package/src/crews/speech/application/messages.ts +3 -0
- package/src/crews/speech/application/prompts.ts +3 -0
- package/src/crews/speech/application/run-speech.ts +2 -1
- package/src/crews/speech/crew.ork.ts +2 -1
- package/src/shared/application/agents/child-agent.ts +11 -7
- package/src/shared/application/agents/messages.ts +35 -0
- package/src/shared/application/agents/route-agent.ts +115 -0
- package/src/shared/application/agents/run-sub-agent.ts +31 -8
- package/src/shared/application/compaction/compact-session.ts +19 -14
- package/src/shared/application/compaction/messages.ts +20 -0
- package/src/shared/application/compaction/prune-context.ts +94 -0
- package/src/shared/application/compaction/pruned-llm.ts +35 -0
- package/src/shared/application/dev/brief-inventory.ts +6 -4
- package/src/shared/application/dev/close-batch.ts +9 -7
- package/src/shared/application/dev/find-repo-pack.ts +4 -3
- package/src/shared/application/dev/learn-decision.ts +20 -18
- package/src/shared/application/dev/load-dev-context.ts +7 -8
- package/src/shared/application/dev/measure-access-cost.ts +5 -4
- package/src/shared/application/dev/messages.ts +132 -0
- package/src/shared/application/dev/phase-timer.ts +54 -0
- package/src/shared/application/dev/plan-source.ts +12 -8
- package/src/shared/application/dev/preflight.ts +8 -8
- package/src/shared/application/dev/prompts.ts +34 -0
- package/src/shared/application/dev/question-round.ts +25 -17
- package/src/shared/application/dev/resolve-work-folder.ts +4 -3
- package/src/shared/application/dev/settle-questions.ts +4 -2
- package/src/shared/application/dev/source-review.ts +12 -8
- package/src/shared/application/dev/source-step.ts +12 -10
- package/src/shared/application/dev/spend.ts +17 -4
- package/src/shared/application/dev/step-precedents.ts +2 -1
- package/src/shared/application/dev/tool-call-policy.ts +9 -11
- package/src/shared/application/dev/tool-callbacks.ts +52 -5
- package/src/shared/application/dev/tool-trace-recorder.ts +2 -1
- package/src/shared/application/dev/verdict-sources.ts +5 -3
- package/src/shared/application/dev/wrapped-tools.ts +4 -2
- package/src/shared/application/extra-tools.ts +2 -1
- package/src/shared/application/git/batch-worktree.ts +22 -17
- package/src/shared/application/git/commit-files.ts +24 -19
- package/src/shared/application/git/merge-batch.ts +11 -7
- package/src/shared/application/git/messages.ts +75 -0
- package/src/shared/application/git/open-pull-request.ts +4 -3
- package/src/shared/application/host-context.ts +59 -0
- package/src/shared/application/host-layout-store.ts +45 -0
- package/src/shared/application/llm-profile.ts +4 -3
- package/src/shared/application/messages.ts +14 -0
- package/src/shared/application/permission-rules.ts +10 -0
- package/src/shared/application/ports/decision.ts +14 -0
- package/src/shared/application/ports/human.ts +25 -0
- package/src/shared/application/ports/llm.ts +32 -3
- package/src/shared/application/ports/memory.ts +1 -1
- package/src/shared/application/ports/theme.ts +11 -0
- package/src/shared/application/ports.ts +4 -2
- package/src/shared/application/session-io.ts +2 -1
- package/src/shared/application/shared-memory/admit-entries.ts +16 -14
- package/src/shared/application/shared-memory/harvest-after-gaps.ts +5 -8
- package/src/shared/application/shared-memory/harvest-mistakes.ts +3 -2
- package/src/shared/application/shared-memory/import-agent-memory.ts +9 -7
- package/src/shared/application/shared-memory/memory-files.ts +2 -1
- package/src/shared/application/shared-memory/memory-settings.ts +2 -1
- package/src/shared/application/shared-memory/messages.ts +63 -0
- package/src/shared/application/shared-memory/push-candidate.ts +14 -11
- package/src/shared/application/shared-memory/recall-precedents.ts +2 -1
- package/src/shared/application/skills/messages.ts +4 -0
- package/src/shared/application/skills/suggest-skills.ts +102 -0
- package/src/shared/application/workflow/messages.ts +8 -0
- package/src/shared/application/workflow/workflow-state.ts +7 -6
- package/src/shared/domain/agent-policy/behavior-flags.ts +4 -10
- package/src/shared/domain/agent-policy/extra-tools.ts +2 -4
- package/src/shared/domain/agent-policy/messages.ts +66 -0
- package/src/shared/domain/agent-policy/path-rules.ts +299 -0
- package/src/shared/domain/agent-policy/permission.ts +20 -18
- package/src/shared/domain/agent-policy/prompts.ts +17 -0
- package/src/shared/domain/agent-policy/reasoning.ts +59 -0
- package/src/shared/domain/agent-policy/rule-sets.ts +18 -14
- package/src/shared/domain/agent-policy/tool-access.ts +17 -3
- package/src/shared/domain/agent-registry.ts +6 -5
- package/src/shared/domain/agents/chain.ts +2 -2
- package/src/shared/domain/agents/charter.ts +8 -5
- package/src/shared/domain/agents/exclusive.ts +2 -1
- package/src/shared/domain/agents/instances.ts +18 -15
- package/src/shared/domain/agents/messages.ts +39 -0
- package/src/shared/domain/agents/model-route.ts +199 -0
- package/src/shared/domain/agents/prompts.ts +20 -0
- package/src/shared/domain/code-intel-contract.ts +5 -4
- package/src/shared/domain/code-intel-routing.ts +8 -61
- package/src/shared/domain/compact-outcome.ts +5 -3
- package/src/shared/domain/compaction-thresholds.ts +2 -1
- package/src/shared/domain/compaction.ts +22 -113
- package/src/shared/domain/config-schema.ts +94 -81
- package/src/shared/domain/context-prune.ts +176 -0
- package/src/shared/domain/decision/questions.ts +102 -0
- package/src/shared/domain/dev/access-cost.ts +19 -15
- package/src/shared/domain/dev/batches-concurrency.ts +5 -6
- package/src/shared/domain/dev/build-commands.ts +5 -4
- package/src/shared/domain/dev/call-guard.ts +29 -28
- package/src/shared/domain/dev/carried-text.ts +3 -5
- package/src/shared/domain/dev/learn-proposals.ts +5 -4
- package/src/shared/domain/dev/learn-state.ts +3 -2
- package/src/shared/domain/dev/markers.ts +107 -0
- package/src/shared/domain/dev/messages.ts +259 -0
- package/src/shared/domain/dev/phase-timing.ts +50 -0
- package/src/shared/domain/dev/plan-checks.ts +24 -23
- package/src/shared/domain/dev/plan-format.ts +14 -24
- package/src/shared/domain/dev/project-files.ts +1 -15
- package/src/shared/domain/dev/prompts/brief-blocks.ts +20 -0
- package/src/shared/domain/dev/{review-prompt.ts → prompts.ts} +91 -61
- package/src/shared/domain/dev/questions.ts +33 -15
- package/src/shared/domain/dev/repo-pack.ts +12 -9
- package/src/shared/domain/dev/review-answer.ts +40 -17
- package/src/shared/domain/dev/review-brief.ts +54 -0
- package/src/shared/domain/dev/reviewer-charter.ts +4 -0
- package/src/shared/domain/dev/sheet-facts.ts +2 -4
- package/src/shared/domain/dev/spec-format.ts +13 -14
- package/src/shared/domain/dev/step-budget.ts +4 -2
- package/src/shared/domain/dev/step-rules.ts +3 -4
- package/src/shared/domain/dev/test-commands.ts +14 -10
- package/src/shared/domain/dev/tool-guards.ts +4 -3
- package/src/shared/domain/dev/trait-pattern.ts +14 -10
- package/src/shared/domain/dev/verdict-format.ts +14 -21
- package/src/shared/domain/dev/whitespace.ts +3 -2
- package/src/shared/domain/dev/work-folder.ts +4 -3
- package/src/shared/domain/dev/yaml-subset.ts +8 -26
- package/src/shared/domain/error-text.ts +13 -0
- package/src/shared/domain/git/close.ts +5 -4
- package/src/shared/domain/git/messages.ts +20 -0
- package/src/shared/domain/git/pull-request.ts +5 -5
- package/src/shared/domain/host-layout.ts +147 -0
- package/src/shared/domain/host-paths.ts +399 -0
- package/src/shared/domain/llm-failure.ts +35 -7
- package/src/shared/domain/llm-profile.ts +22 -3
- package/src/shared/domain/marked-message.ts +1 -5
- package/src/shared/domain/markers.ts +30 -0
- package/src/shared/domain/messages.ts +291 -0
- package/src/shared/domain/model-catalog.ts +2 -9
- package/src/shared/domain/permission-modes.ts +4 -8
- package/src/shared/domain/prelude.ts +2 -2
- package/src/shared/domain/project-manifests.ts +3 -2
- package/src/shared/domain/prompts.ts +233 -0
- package/src/shared/domain/search-routing.ts +3 -11
- package/src/shared/domain/secret-patterns.ts +3 -2
- package/src/shared/domain/session-keys.ts +7 -0
- package/src/shared/domain/session-start.ts +3 -2
- package/src/shared/domain/shared-memory/agent-memory-import.ts +4 -2
- package/src/shared/domain/shared-memory/candidates.ts +3 -4
- package/src/shared/domain/shared-memory/entry.ts +26 -20
- package/src/shared/domain/shared-memory/front-matter.ts +17 -13
- package/src/shared/domain/shared-memory/gate.ts +4 -3
- package/src/shared/domain/shared-memory/harvest.ts +9 -6
- package/src/shared/domain/shared-memory/layout.ts +11 -8
- package/src/shared/domain/shared-memory/markers.ts +9 -0
- package/src/shared/domain/shared-memory/messages.ts +66 -0
- package/src/shared/domain/shared-memory/precedents-block.ts +4 -15
- package/src/shared/domain/shared-memory/prompts.ts +28 -0
- package/src/shared/domain/shared-memory/refused.ts +3 -3
- package/src/shared/domain/skills/prompts.ts +4 -0
- package/src/shared/domain/skills/shortlist.ts +149 -0
- package/src/shared/domain/snip-turns.ts +2 -14
- package/src/shared/domain/speech.ts +2 -1
- package/src/shared/domain/tool-trace.ts +5 -7
- package/src/shared/domain/verifiers.ts +7 -11
- package/src/shared/domain/vfs.ts +8 -1
- package/src/shared/domain/workflow/prompts.ts +15 -0
- package/src/shared/domain/workflow/state-file.ts +14 -12
- package/src/shared/infrastructure/globals.ts +7 -2
- package/src/shared/infrastructure/orkeon/child-agents.ts +11 -16
- package/src/shared/infrastructure/orkeon/chooser.ts +32 -0
- package/src/shared/infrastructure/orkeon/decision-model.ts +31 -0
- package/src/shared/infrastructure/orkeon/dev-deps.ts +21 -14
- package/src/shared/infrastructure/orkeon/files.ts +24 -6
- package/src/shared/infrastructure/orkeon/github-pull-requests.ts +3 -2
- package/src/shared/infrastructure/orkeon/host-context.ts +36 -0
- package/src/shared/infrastructure/orkeon/human-input.ts +1 -5
- package/src/shared/infrastructure/orkeon/llm-profile.ts +36 -16
- package/src/shared/infrastructure/orkeon/llm.ts +85 -30
- package/src/shared/infrastructure/orkeon/markers.ts +6 -0
- package/src/shared/infrastructure/orkeon/memory-store.ts +1 -1
- package/src/shared/infrastructure/orkeon/memory-tools.ts +18 -20
- package/src/shared/infrastructure/orkeon/messages.ts +15 -0
- package/src/shared/infrastructure/orkeon/prompts.ts +47 -0
- package/src/shared/infrastructure/orkeon/reasoning.ts +40 -0
- package/src/shared/infrastructure/orkeon/script-tools.ts +14 -19
- package/src/shared/infrastructure/orkeon/session-store.ts +7 -51
- package/src/shared/infrastructure/orkeon/shell-jobs.ts +13 -7
- package/src/shared/infrastructure/orkeon/shell.ts +13 -5
- package/src/shared/infrastructure/orkeon/tool-catalogue.ts +3 -2
- package/src/shared/infrastructure/orkeon/wiring.ts +68 -12
- package/src/crews/dev-verify/application/auditor-prompt.ts +0 -323
- package/src/shared/domain/session-summary.ts +0 -13
|
@@ -7,6 +7,7 @@
|
|
|
7
7
|
// written before the next question - folds them in, and has the read-only reviewer question the brief once. With
|
|
8
8
|
// nobody to answer, the questions stay in the file and the run ends BLOCKED. An existing brief is revised.
|
|
9
9
|
import type { CodeIndex, Files, HumanInput, Llm, Logger, Shell } from "../../../shared/application/ports.ts";
|
|
10
|
+
import type { ActRoute } from "../../../shared/application/agents/route-agent.ts";
|
|
10
11
|
import { stepRules } from "../../../shared/domain/dev/step-rules.ts";
|
|
11
12
|
import { shellRuleGuard } from "../../../shared/domain/dev/tool-guards.ts";
|
|
12
13
|
import type { ConfigStore } from "../../../shared/application/config-store.ts";
|
|
@@ -26,16 +27,23 @@ import type { Decision, Question } from "../../../shared/domain/dev/questions.ts
|
|
|
26
27
|
import { parsePlanSource } from "../../../shared/domain/dev/spec-format.ts";
|
|
27
28
|
import type { ChangeKind } from "../../../shared/domain/dev/spec-format.ts";
|
|
28
29
|
import { CHANGE_ANSWER_SCHEMA, checkChangeAnswer, criterionId, pinOnlyKnown } from "../domain/change-answer.ts";
|
|
29
|
-
import {
|
|
30
|
-
|
|
31
|
-
renderChange, reproFileName, sectionBody,
|
|
32
|
-
} from "../domain/change-render.ts";
|
|
30
|
+
import { changeFileName, originLines, renderChange, reproFileName, sectionBody } from "../domain/change-render.ts";
|
|
31
|
+
import { CHANGE_DECISIONS_SECTION, CHANGE_QUESTIONS_SECTION, EVIDENCE_HEADING, ORIGIN_HEADING, SUSPECTED_CAUSE } from "../domain/markers.ts";
|
|
33
32
|
import { noPrecedents, precedentsLine, recallQuery } from "../../../shared/application/dev/step-precedents.ts";
|
|
34
33
|
import type { StepPrecedents } from "../../../shared/application/dev/step-precedents.ts";
|
|
35
34
|
import { runDevSpec } from "../../dev-spec/application/run-dev-spec.ts";
|
|
36
|
-
import { buildChangePrompt } from "./change-
|
|
37
|
-
import type { ChangePromptInput } from "./change-
|
|
35
|
+
import { buildChangePrompt } from "./change-material.ts";
|
|
36
|
+
import type { ChangePromptInput } from "./change-material.ts";
|
|
38
37
|
import { factLines, pickCommand, readOrigin, reproFile, runEvidence, runStop } from "./evidence.ts";
|
|
38
|
+
import {
|
|
39
|
+
DEV_CHANGE_NEXT, FEATURE_LINE, ROUTED_TO_SPEC, answerBriefQuestions, briefBlockedUnanswered, briefKeepsKind, deniedNothingWritten, evidenceLine,
|
|
40
|
+
invalidKind, mustNotChangeLine, nameTheKind, newBriefNeedsOrigin, newPromiseKept, briefRefusedTwice, briefRendererDefect,
|
|
41
|
+
reproNotWritten, runIsForBugOrPerf, specExists, briefStillBlocking, titleNamesNoKind, unknownTest,
|
|
42
|
+
} from "./messages.ts";
|
|
43
|
+
import { cannotBeReadNothingWritten, specNotWrittenAnswersKept, decisionsThisRun } from "../../dev-spec/application/messages.ts";
|
|
44
|
+
import { PERMISSION_GATE_OFF } from "../../../shared/application/dev/messages.ts";
|
|
45
|
+
import { answerDidNotParse } from "../../../shared/application/agents/messages.ts";
|
|
46
|
+
import { errorText } from "../../../shared/domain/error-text.ts";
|
|
39
47
|
|
|
40
48
|
export interface DevChangeInputs { code?: unknown; kind?: unknown; run?: unknown; text?: unknown }
|
|
41
49
|
export interface DevChangeDeps {
|
|
@@ -43,13 +51,14 @@ export interface DevChangeDeps {
|
|
|
43
51
|
llm: Pick<Llm, "extract" | "act" | "permissionGateEnabled">; human: HumanInput; log: Logger; clock: () => Date;
|
|
44
52
|
/** The shared memory's code-triggered recall (T1); absent, nothing is recalled. */
|
|
45
53
|
precedents?: StepPrecedents;
|
|
54
|
+
/** The route of the brief reviewer's act to a cheaper or stronger profile (shared/application/agents/route-agent.ts actRoute);
|
|
55
|
+
* absent, the act runs on the crew's profile. */
|
|
56
|
+
route?: ActRoute;
|
|
46
57
|
}
|
|
47
58
|
|
|
48
59
|
const STEP = "dev-change";
|
|
49
60
|
const KINDS: readonly ChangeKind[] = ["bug", "refactor", "perf"];
|
|
50
61
|
const HEADINGS = { questions: CHANGE_QUESTIONS_SECTION, decisions: CHANGE_DECISIONS_SECTION };
|
|
51
|
-
export const DEV_CHANGE_NEXT = "→ Next step, once you have validated the brief: /dev-plan {code}";
|
|
52
|
-
export const FEATURE_LINE = "→ a feature, not a change: the spec SPEC-{code}.md follows";
|
|
53
62
|
|
|
54
63
|
type Drafted = { feature: true } | { feature: false; text: string; open: Question[]; unknown: string[] };
|
|
55
64
|
|
|
@@ -101,7 +110,7 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
101
110
|
const code = inputCode(STEP, input.code);
|
|
102
111
|
if (typeof code !== "string") return code.refused;
|
|
103
112
|
const kindIn = inputText(STEP, "kind", input.kind);
|
|
104
|
-
if (typeof kindIn !== "string" || (kindIn !== "" && !KINDS.includes(kindIn as ChangeKind))) return
|
|
113
|
+
if (typeof kindIn !== "string" || (kindIn !== "" && !KINDS.includes(kindIn as ChangeKind))) return invalidKind(STEP);
|
|
105
114
|
const given = inputText(STEP, "run", input.run);
|
|
106
115
|
if (typeof given !== "string") return given.refused;
|
|
107
116
|
const typed = inputText(STEP, "text", input.text);
|
|
@@ -114,7 +123,7 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
114
123
|
|
|
115
124
|
// 2. One source per code; an existing brief is revised, its kind kept.
|
|
116
125
|
if (folder.names.includes(`SPEC-${code}.md`)) {
|
|
117
|
-
return
|
|
126
|
+
return specExists(STEP, folder.shown, code);
|
|
118
127
|
}
|
|
119
128
|
const brief = folder.file(changeFileName(code));
|
|
120
129
|
let existing: string | null = null;
|
|
@@ -122,24 +131,24 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
122
131
|
try {
|
|
123
132
|
existing = await deps.files.read(brief.vfs);
|
|
124
133
|
} catch (e) {
|
|
125
|
-
return
|
|
134
|
+
return cannotBeReadNothingWritten(STEP, brief.shown, firstLine(e));
|
|
126
135
|
}
|
|
127
136
|
}
|
|
128
137
|
const fileKind = existing === null ? undefined : parsePlanSource(existing, "change").changeKind;
|
|
129
|
-
if (existing !== null && fileKind === undefined) return
|
|
138
|
+
if (existing !== null && fileKind === undefined) return titleNamesNoKind(STEP, brief.shown);
|
|
130
139
|
if (fileKind !== undefined && kindIn !== "" && kindIn !== fileKind) {
|
|
131
|
-
return
|
|
140
|
+
return briefKeepsKind(STEP, brief.shown, fileKind, kindIn);
|
|
132
141
|
}
|
|
133
142
|
const kind = (fileKind ?? kindIn) as ChangeKind | "";
|
|
134
|
-
if (kind === "") return
|
|
135
|
-
if (given !== "" && kind === "refactor") return
|
|
143
|
+
if (kind === "") return nameTheKind(STEP, code);
|
|
144
|
+
if (given !== "" && kind === "refactor") return runIsForBugOrPerf(STEP);
|
|
136
145
|
|
|
137
146
|
// 3. The origin (a new brief) or the request (a revision).
|
|
138
147
|
let originText = "";
|
|
139
148
|
let originFrom = "";
|
|
140
149
|
let request = "";
|
|
141
150
|
if (existing === null) {
|
|
142
|
-
if (typed === "") return
|
|
151
|
+
if (typed === "") return newBriefNeedsOrigin(STEP, code, kind);
|
|
143
152
|
const origin = await readOrigin(STEP, deps, typed);
|
|
144
153
|
if ("refused" in origin) return origin.refused;
|
|
145
154
|
originText = origin.text;
|
|
@@ -152,19 +161,19 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
152
161
|
// 4. Evidence by running, before anything else is written.
|
|
153
162
|
const today = dateOf(deps.clock());
|
|
154
163
|
const commands = ctx.pack?.pack.commands ?? {};
|
|
155
|
-
let facts: string[] = existing === null ? [] : sectionBody(existing, EVIDENCE_HEADING).filter((l) => !l.startsWith(
|
|
164
|
+
let facts: string[] = existing === null ? [] : sectionBody(existing, EVIDENCE_HEADING).filter((l) => !l.startsWith(SUSPECTED_CAUSE));
|
|
156
165
|
let ran: { command: string; seconds: number } | null = null;
|
|
157
166
|
if (kind !== "refactor" && (existing === null || given !== "")) {
|
|
158
167
|
const picked = await pickCommand(STEP, deps.llm, kind, given, originText, commands);
|
|
159
168
|
if ("refused" in picked) return picked.refused;
|
|
160
169
|
const denied = shellRuleGuard(stepRules("dev-change"))(picked.command);
|
|
161
|
-
if (denied !== null) return
|
|
170
|
+
if (denied !== null) return deniedNothingWritten(STEP, denied);
|
|
162
171
|
const result = await runEvidence(deps.shell, picked.command, deps.clock);
|
|
163
172
|
const repro = folder.file(reproFileName(code));
|
|
164
173
|
try {
|
|
165
174
|
await deps.files.write(repro.vfs, reproFile(result, today));
|
|
166
175
|
} catch (e) {
|
|
167
|
-
return
|
|
176
|
+
return reproNotWritten(STEP, repro.shown, firstLine(e));
|
|
168
177
|
}
|
|
169
178
|
const stop = runStop(STEP, kind, result, repro.shown);
|
|
170
179
|
if (stop !== null) return stop;
|
|
@@ -192,7 +201,7 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
192
201
|
try {
|
|
193
202
|
value = await deps.llm.extract(buildChangePrompt(prompt, problems), CHANGE_ANSWER_SCHEMA);
|
|
194
203
|
} catch (e) {
|
|
195
|
-
problems = [
|
|
204
|
+
problems = [answerDidNotParse(errorText(e))];
|
|
196
205
|
continue;
|
|
197
206
|
}
|
|
198
207
|
const checked = checkChangeAnswer(value, kind);
|
|
@@ -204,7 +213,7 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
204
213
|
const ids = pinned.answer.criteria.map((_, i) => criterionId(i));
|
|
205
214
|
const self = sourceSelfCheck(text, "change", { code, ids, open: questions, decisions });
|
|
206
215
|
if (self.length > 0) {
|
|
207
|
-
deps.log.warn(
|
|
216
|
+
deps.log.warn(briefRendererDefect(STEP, self[0]));
|
|
208
217
|
problems = self;
|
|
209
218
|
continue;
|
|
210
219
|
}
|
|
@@ -231,15 +240,15 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
231
240
|
mode: existing === null ? "draft" : "revision", code, kind, origin: originText, facts: factsText, request,
|
|
232
241
|
current: existing ?? "", decisions: decisions0, fresh: [], inventory: inventoryText, precedents: recalled.block,
|
|
233
242
|
}, questionsOf(decisions0, open0), decisions0);
|
|
234
|
-
if (!asked.ok) return [
|
|
243
|
+
if (!asked.ok) return [briefRefusedTwice(STEP), ...problemLines(asked.problems)].join("\n");
|
|
235
244
|
if (asked.drafted.feature) {
|
|
236
245
|
// A new brief goes on as a spec in the same run, over the same ports; a brief that exists keeps its code.
|
|
237
246
|
if (existing !== null) {
|
|
238
|
-
return
|
|
247
|
+
return newPromiseKept(STEP, brief.shown);
|
|
239
248
|
}
|
|
240
249
|
return [FEATURE_LINE.replace("{code}", code), await runDevSpec({ code, request: originText }, deps)].join("\n");
|
|
241
250
|
}
|
|
242
|
-
warnings.push(...asked.drafted.unknown.map(
|
|
251
|
+
warnings.push(...asked.drafted.unknown.map(unknownTest));
|
|
243
252
|
state = { text: asked.drafted.text, open: asked.drafted.open, decisions: decisions0 };
|
|
244
253
|
await write(state.text);
|
|
245
254
|
verb = existing === null ? "written" : "revised";
|
|
@@ -253,7 +262,7 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
253
262
|
decisions: st.decisions, fresh, inventory: inventoryText, precedents: recalled.block,
|
|
254
263
|
}, questionsOf(st.decisions, st.open), st.decisions);
|
|
255
264
|
if (!r.ok) return { ok: false, problems: r.problems };
|
|
256
|
-
if (r.drafted.feature) return { ok: false, problems: [
|
|
265
|
+
if (r.drafted.feature) return { ok: false, problems: [ROUTED_TO_SPEC] };
|
|
257
266
|
return { ok: true, text: r.drafted.text, open: r.drafted.open };
|
|
258
267
|
};
|
|
259
268
|
const round = { human: deps.human, today, label: `${STEP} ${code}`, headings: HEADINGS, write, fold };
|
|
@@ -268,8 +277,8 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
268
277
|
review = await reviewSource(deps.llm, state, {
|
|
269
278
|
mode: "change", whole: "brief", folder: folder.shown, fileShown: brief.shown, origin: originFrom,
|
|
270
279
|
inventory: inventoryText, ids, headings: HEADINGS,
|
|
271
|
-
}, write);
|
|
272
|
-
if (deps.llm.permissionGateEnabled() === false) warnings.push(
|
|
280
|
+
}, write, deps.route);
|
|
281
|
+
if (deps.llm.permissionGateEnabled() === false) warnings.push(PERMISSION_GATE_OFF);
|
|
273
282
|
if (review.ran && review.added.length > 0) {
|
|
274
283
|
state = review.state;
|
|
275
284
|
const added = new Set(review.added);
|
|
@@ -287,9 +296,9 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
287
296
|
const unpinned = parsed.mustNotChange.filter((r) => r.pinnedBy === null).length;
|
|
288
297
|
const lines = [
|
|
289
298
|
`${STEP}: ${brief.shown} ${verb} — ${kind}, ${plural(ids.length, "criterion", "criteria")} (${ids.join(", ") || "none"})`,
|
|
290
|
-
...(ran === null ? [] : [
|
|
291
|
-
|
|
292
|
-
|
|
299
|
+
...(ran === null ? [] : [evidenceLine(ran.command, ran.seconds, `${folder.shown}/${reproFileName(code)}`)]),
|
|
300
|
+
mustNotChangeLine(plural(parsed.mustNotChange.length, "row", "rows"), unpinned),
|
|
301
|
+
decisionsThisRun(made.length === 0 ? "none" : made.map((d) => `${d.id} → ${d.answer}`).join("; ")),
|
|
293
302
|
`open questions: ${openLine(state.open)}`,
|
|
294
303
|
...(review === null ? [] : [reviewLine(review)]),
|
|
295
304
|
briefInventoryLine(inventory),
|
|
@@ -299,17 +308,17 @@ export async function runDevChange(input: DevChangeInputs, deps: DevChangeDeps):
|
|
|
299
308
|
const blockingLeft = state.open.filter((q) => q.severity === "Blocking");
|
|
300
309
|
if (blocked) {
|
|
301
310
|
lines.push(
|
|
302
|
-
|
|
303
|
-
|
|
311
|
+
briefBlockedUnanswered(STEP, brief.shown),
|
|
312
|
+
answerBriefQuestions(code, kind),
|
|
304
313
|
);
|
|
305
314
|
} else if (blockingLeft.length > 0) {
|
|
306
|
-
lines.push(
|
|
315
|
+
lines.push(briefStillBlocking(blockingLeft.map((q) => q.id).join(", "), code, kind));
|
|
307
316
|
} else {
|
|
308
317
|
lines.push(DEV_CHANGE_NEXT.replace("{code}", code));
|
|
309
318
|
}
|
|
310
319
|
return lines.join("\n");
|
|
311
320
|
} catch (e) {
|
|
312
321
|
if (!(e instanceof SourceWriteFailure)) throw e;
|
|
313
|
-
return
|
|
322
|
+
return specNotWrittenAnswersKept(STEP, brief.shown, e.message);
|
|
314
323
|
}
|
|
315
324
|
}
|
|
@@ -9,8 +9,7 @@
|
|
|
9
9
|
// the answers in, then has the read-only reviewer question the brief once. Unattended: BLOCKED, questions in the file.
|
|
10
10
|
// A new brief the model routes as a feature goes on as a spec in the same run (runDevSpec, over the same ports).
|
|
11
11
|
// The reviewer's act runs in a background child, `dev-reviewer` (its charter: read tools only, plan mode), which
|
|
12
|
-
// /tasks lists and stops while it runs, as /dev-plan's (A-3, approach A2)
|
|
13
|
-
// it runs inline.
|
|
12
|
+
// /tasks lists and stops while it runs, as /dev-plan's (A-3, approach A2).
|
|
14
13
|
//
|
|
15
14
|
// Input (globalThis.inputs): { code: string, kind?: "bug" | "refactor" | "perf", run?: string (the command to run),
|
|
16
15
|
// text?: string (the origin of a new brief, or a revision request), hooks?: /hooks,
|
|
@@ -27,6 +26,7 @@
|
|
|
27
26
|
|
|
28
27
|
import { CrewBuilder, publishCrew, inputs, ToolBuilder } from "../../shared/infrastructure/globals.ts";
|
|
29
28
|
import {
|
|
29
|
+
orkeonActRoute, orkeonPrunedLlm,
|
|
30
30
|
orkeonAgent,
|
|
31
31
|
orkeonClock,
|
|
32
32
|
orkeonCodeIndex,
|
|
@@ -39,7 +39,7 @@ import {
|
|
|
39
39
|
orkeonShell,
|
|
40
40
|
} from "../../shared/infrastructure/orkeon/wiring.ts";
|
|
41
41
|
import { memoryReadTools, memoryRecallOn, memoryRecallTools } from "../../shared/infrastructure/orkeon/memory-tools.ts";
|
|
42
|
-
import {
|
|
42
|
+
import { agentLlm } from "../../shared/infrastructure/orkeon/llm.ts";
|
|
43
43
|
import { providerEffort } from "../../shared/domain/agent-policy/behavior-flags.ts";
|
|
44
44
|
import { memoryDirOf } from "../../shared/application/shared-memory/memory-settings.ts";
|
|
45
45
|
import { devToolCallbacks } from "../../shared/application/dev/tool-callbacks.ts";
|
|
@@ -47,9 +47,11 @@ import { childAgentBody, openChildAct } from "../../shared/infrastructure/orkeon
|
|
|
47
47
|
import { charterCatalogue } from "../../shared/domain/agents/charter.ts";
|
|
48
48
|
import { instanceLimits } from "../../shared/domain/agents/instances.ts";
|
|
49
49
|
import { REVIEWER_CHARTER } from "../../shared/domain/dev/reviewer-charter.ts";
|
|
50
|
+
import { reviewerCallbacks } from "../../shared/application/dev/spend.ts";
|
|
50
51
|
import { STEP_BUDGETS } from "../../shared/domain/dev/step-budget.ts";
|
|
51
52
|
import { stepPrecedents } from "../../shared/application/dev/step-precedents.ts";
|
|
52
53
|
import { runDevChange } from "./application/run-dev-change.ts";
|
|
54
|
+
import { BRIEF_REVIEW_TASK, CHANGE_WRITER_GOAL } from "./application/messages.ts";
|
|
53
55
|
|
|
54
56
|
const ports = { shell: orkeonShell(), files: orkeonFiles(), config: orkeonConfigStore(), index: orkeonCodeIndex(), human: orkeonHumanInput() };
|
|
55
57
|
// memory_recall is attached unless a session rule denies every call of it (the command says so).
|
|
@@ -57,7 +59,7 @@ const memoryOn = memoryRecallOn(inputs());
|
|
|
57
59
|
const effort = providerEffort(inputs().effort);
|
|
58
60
|
const session = orkeonSessionIo();
|
|
59
61
|
const limits = instanceLimits(inputs());
|
|
60
|
-
//
|
|
62
|
+
// These callbacks, then the host's gate on the input they return (Orkeon #303): the step's rule sets again and the /hooks the command passed.
|
|
61
63
|
const callbacksFor = (ctx: any) => devToolCallbacks(
|
|
62
64
|
{ step: "dev-change", hooks: inputs().hooks, readTools: memoryReadTools(memoryOn) }, { shell: ports.shell, log: ctx.log, memoryDir: memoryDirOf(ports.config) },
|
|
63
65
|
);
|
|
@@ -71,14 +73,14 @@ const reviewer = () => {
|
|
|
71
73
|
.tools(charterCatalogue(REVIEWER_CHARTER))
|
|
72
74
|
.withAutonomousTools(memoryRecallTools(ToolBuilder, orkeonMemoryToolPorts, memoryOn))
|
|
73
75
|
.maxIterations(REVIEWER_CHARTER.maxIterations)
|
|
74
|
-
.body(childAgentBody(callbacksFor));
|
|
76
|
+
.body(childAgentBody((ctx: any) => reviewerCallbacks(callbacksFor(ctx)), (llm, ctx) => orkeonPrunedLlm(llm, ctx.log, ctx.tools)));
|
|
75
77
|
return effort === undefined ? builder : builder.effort(effort);
|
|
76
78
|
};
|
|
77
79
|
|
|
78
80
|
const builder = orkeonAgent()
|
|
79
81
|
.name("dev-change-writer")
|
|
80
82
|
.role("Change analyst")
|
|
81
|
-
.goal(
|
|
83
|
+
.goal(CHANGE_WRITER_GOAL)
|
|
82
84
|
// The catalogue is the reviewer's: read tools only. The brief itself is an extract call, which offers none.
|
|
83
85
|
.tools(charterCatalogue(REVIEWER_CHARTER))
|
|
84
86
|
.withAutonomousTools(memoryRecallTools(ToolBuilder, orkeonMemoryToolPorts, memoryOn))
|
|
@@ -86,14 +88,14 @@ const builder = orkeonAgent()
|
|
|
86
88
|
.body(async (_input: any, ctx: any) => {
|
|
87
89
|
const clock = orkeonClock();
|
|
88
90
|
const child = openChildAct(
|
|
89
|
-
|
|
91
|
+
agentLlm(ctx, callbacksFor(ctx), { effort }), ctx, crew, { state: session, clock, log: ctx.log, effort },
|
|
90
92
|
{ crew: "dev-change", step: "dev-change" },
|
|
91
|
-
{ agent: REVIEWER_CHARTER.name, charter: REVIEWER_CHARTER.name, task:
|
|
93
|
+
{ agent: REVIEWER_CHARTER.name, charter: REVIEWER_CHARTER.name, task: BRIEF_REVIEW_TASK, builder: reviewer },
|
|
92
94
|
);
|
|
93
95
|
try {
|
|
94
96
|
// T1: the shared memory's precedents in the draft's prompt, unless memory_recall is denied.
|
|
95
97
|
const precedents = stepPrecedents({ ...ports, memory: orkeonSharedMemory(), log: ctx.log }, { on: memoryOn });
|
|
96
|
-
return await runDevChange(inputs(), { ...ports, llm: child.llm, log: ctx.log, clock, precedents });
|
|
98
|
+
return await runDevChange(inputs(), { ...ports, llm: child.llm, log: ctx.log, clock, precedents, route: orkeonActRoute(ctx.log) });
|
|
97
99
|
} finally {
|
|
98
100
|
await child.close();
|
|
99
101
|
}
|
|
@@ -5,8 +5,12 @@
|
|
|
5
5
|
// `route: "feature"` says the request is a new promise, for /dev-spec. CH ids are code's, by position. Pure.
|
|
6
6
|
import type { Checked } from "../../../shared/domain/agents/charter.ts";
|
|
7
7
|
import type { ChangeKind } from "../../../shared/domain/dev/spec-format.ts";
|
|
8
|
-
import { MAX_QUESTIONS, QUESTION_SCHEMA, breaksCell, draftQuestionProblems } from "../../../shared/domain/dev/questions.ts";
|
|
8
|
+
import { MAX_QUESTIONS, QUESTION_SCHEMA, breaksCell, draftQuestionProblems, tidyOptions } from "../../../shared/domain/dev/questions.ts";
|
|
9
9
|
import type { DraftQuestion } from "../../../shared/domain/dev/questions.ts";
|
|
10
|
+
import { NO_CRITERION, NO_CHANGE_SUMMARY, PERF_NEEDS_NUMBER, REFACTOR_NEEDS_PIN, cellOneLine, noBehaviour, noDesign, noProof, severityIsBlockingOrWarning, tooManyCriteria, tooManyLines } from "./messages.ts";
|
|
11
|
+
import {
|
|
12
|
+
ANSWER_NOT_AN_OBJECT as NOT_AN_OBJECT, idNameOneLine, nameOneLine, rowIsEmpty, statementOneLine, TBD_WITHOUT_QUESTION, tooManyQuestions,
|
|
13
|
+
} from "../../../shared/domain/dev/messages.ts";
|
|
10
14
|
|
|
11
15
|
export type CriterionSeverity = "blocking" | "warning";
|
|
12
16
|
export interface ChangeCriterion { name: string; statement: string; proof: string; severity: CriterionSeverity }
|
|
@@ -90,57 +94,57 @@ function readChangeAnswer(value: unknown): ChangeAnswer {
|
|
|
90
94
|
assumptions: rows(o.assumptions, ["assumption", "validatedBy"]),
|
|
91
95
|
questions: list(o.questions).map((q) => {
|
|
92
96
|
const x = isObject(q) ? q : {};
|
|
93
|
-
return { severity: text(x.severity), question: text(x.question), impact: text(x.impact), options: textList(x.options) };
|
|
97
|
+
return { severity: text(x.severity), question: text(x.question), impact: text(x.impact), options: tidyOptions(textList(x.options)) };
|
|
94
98
|
}),
|
|
95
99
|
};
|
|
96
100
|
}
|
|
97
101
|
|
|
98
102
|
export function checkChangeAnswer(value: unknown, kind: ChangeKind): Checked<ChangeAnswer> {
|
|
99
|
-
if (!isObject(value)) return { ok: false, problems: [
|
|
103
|
+
if (!isObject(value)) return { ok: false, problems: [NOT_AN_OBJECT] };
|
|
100
104
|
const a = readChangeAnswer(value);
|
|
101
105
|
if (a.route === "feature") return { ok: true, value: a };
|
|
102
106
|
const problems: string[] = [];
|
|
103
107
|
const oneLine = (t: string): boolean => !/[\r\n]/.test(t);
|
|
104
108
|
if (a.name === "" || !oneLine(a.name) || a.name.length > MAX_NAME_CHARS || a.name.includes("—")) {
|
|
105
|
-
problems.push(
|
|
109
|
+
problems.push(nameOneLine(MAX_NAME_CHARS));
|
|
106
110
|
}
|
|
107
|
-
if (a.summary === "") problems.push(
|
|
108
|
-
if (a.criteria.length === 0) problems.push(
|
|
109
|
-
if (a.criteria.length > MAX_CRITERIA) problems.push(
|
|
111
|
+
if (a.summary === "") problems.push(NO_CHANGE_SUMMARY);
|
|
112
|
+
if (a.criteria.length === 0) problems.push(NO_CRITERION);
|
|
113
|
+
if (a.criteria.length > MAX_CRITERIA) problems.push(tooManyCriteria(MAX_CRITERIA));
|
|
110
114
|
a.criteria.forEach((c, i) => {
|
|
111
115
|
const id = criterionId(i);
|
|
112
|
-
if (c.name === "" || !oneLine(c.name) || c.name.length > MAX_NAME_CHARS) problems.push(
|
|
116
|
+
if (c.name === "" || !oneLine(c.name) || c.name.length > MAX_NAME_CHARS) problems.push(idNameOneLine(id, MAX_NAME_CHARS));
|
|
113
117
|
if (c.statement === "" || !oneLine(c.statement) || c.statement.length > MAX_STATEMENT_CHARS || c.statement.includes(" · ")) {
|
|
114
|
-
problems.push(
|
|
118
|
+
problems.push(statementOneLine(id, MAX_STATEMENT_CHARS));
|
|
115
119
|
}
|
|
116
|
-
if (c.proof === "" || !oneLine(c.proof)) problems.push(
|
|
117
|
-
if (!CRITERION_SEVERITIES.includes(c.severity)) problems.push(
|
|
120
|
+
if (c.proof === "" || !oneLine(c.proof)) problems.push(noProof(id));
|
|
121
|
+
if (!CRITERION_SEVERITIES.includes(c.severity)) problems.push(severityIsBlockingOrWarning(id));
|
|
118
122
|
});
|
|
119
123
|
if (kind === "perf" && !a.criteria.some((c) => /\d/.test(`${c.statement} ${c.proof}`))) {
|
|
120
|
-
problems.push(
|
|
124
|
+
problems.push(PERF_NEEDS_NUMBER);
|
|
121
125
|
}
|
|
122
126
|
if (kind === "refactor" && a.mustNotChange.length === 0) {
|
|
123
|
-
problems.push(
|
|
127
|
+
problems.push(REFACTOR_NEEDS_PIN);
|
|
124
128
|
}
|
|
125
129
|
const tables: Array<[string, ReadonlyArray<Record<string, string>>]> = [
|
|
126
130
|
["mustNotChange", a.mustNotChange], ["scope", a.scope], ["assumptions", a.assumptions],
|
|
127
131
|
];
|
|
128
132
|
for (const [name, items] of tables) {
|
|
129
133
|
items.forEach((row, i) => {
|
|
130
|
-
if (Object.values(row).some(breaksCell)) problems.push(
|
|
131
|
-
if (Object.values(row).every((v) => v === "")) problems.push(
|
|
134
|
+
if (Object.values(row).some(breaksCell)) problems.push(cellOneLine(name, i + 1));
|
|
135
|
+
if (Object.values(row).every((v) => v === "")) problems.push(rowIsEmpty(name, i + 1));
|
|
132
136
|
});
|
|
133
137
|
}
|
|
134
|
-
a.mustNotChange.forEach((r, i) => { if (r.behaviour === "") problems.push(
|
|
135
|
-
if (a.constraints.length > MAX_LIST || a.evidence.length > MAX_LIST) problems.push(
|
|
138
|
+
a.mustNotChange.forEach((r, i) => { if (r.behaviour === "") problems.push(noBehaviour(i + 1)); });
|
|
139
|
+
if (a.constraints.length > MAX_LIST || a.evidence.length > MAX_LIST) problems.push(tooManyLines(MAX_LIST));
|
|
136
140
|
const all = [
|
|
137
141
|
a.name, a.summary, ...a.evidence, a.suspected, ...a.criteria.flatMap((c) => [c.name, c.statement, c.proof]),
|
|
138
142
|
...a.scope.flatMap((s) => [s.in, s.out]), ...a.constraints,
|
|
139
143
|
];
|
|
140
144
|
const design = all.find((t) => DESIGN.test(t));
|
|
141
|
-
if (design !== undefined) problems.push(
|
|
142
|
-
if (/\bTBD\b/.test(all.join("\n")) && a.questions.length === 0) problems.push(
|
|
143
|
-
if (a.questions.length > MAX_QUESTIONS) problems.push(
|
|
145
|
+
if (design !== undefined) problems.push(noDesign(design.slice(0, 60)));
|
|
146
|
+
if (/\bTBD\b/.test(all.join("\n")) && a.questions.length === 0) problems.push(TBD_WITHOUT_QUESTION);
|
|
147
|
+
if (a.questions.length > MAX_QUESTIONS) problems.push(tooManyQuestions(MAX_QUESTIONS));
|
|
144
148
|
a.questions.forEach((q, i) => problems.push(...draftQuestionProblems(q, i + 1)));
|
|
145
149
|
return problems.length > 0 ? { ok: false, problems } : { ok: true, value: a };
|
|
146
150
|
}
|
|
@@ -2,18 +2,16 @@
|
|
|
2
2
|
// empty section left out. § 1 (the origin, quoted) and the facts of § 2 (the reproduction or the measurement that
|
|
3
3
|
// ran) are code's and carried over from the file on a revision or a fold; the model adds its own facts after them.
|
|
4
4
|
// A criterion carries a `- **Statement**:` line first, which spec-format.ts reads for /dev-plan. Pure, no IO.
|
|
5
|
+
import { STATEMENT } from "../../../shared/domain/dev/markers.ts";
|
|
5
6
|
import { decisionTable, questionTable } from "../../../shared/domain/dev/questions.ts";
|
|
6
7
|
import type { Decision, Question } from "../../../shared/domain/dev/questions.ts";
|
|
7
8
|
import type { ChangeKind } from "../../../shared/domain/dev/spec-format.ts";
|
|
8
9
|
import { criterionId } from "./change-answer.ts";
|
|
9
10
|
import type { ChangeAnswer } from "./change-answer.ts";
|
|
11
|
+
import { CHANGE_COLUMNS, CHANGE_DECISIONS_SECTION, CHANGE_QUESTIONS_SECTION, CHANGE_SECTIONS, SUSPECTED_CAUSE } from "./markers.ts";
|
|
10
12
|
|
|
11
13
|
export const changeFileName = (code: string): string => `CHANGE-${code}.md`;
|
|
12
14
|
export const reproFileName = (code: string): string => `repro-${code}.txt`;
|
|
13
|
-
export const CHANGE_QUESTIONS_SECTION = "## 8. Open questions";
|
|
14
|
-
export const CHANGE_DECISIONS_SECTION = "## 9. Decisions";
|
|
15
|
-
export const ORIGIN_HEADING = /^## 1\. Origin\s*$/;
|
|
16
|
-
export const EVIDENCE_HEADING = /^## 2\. Evidence\s*$/;
|
|
17
15
|
const MAX_ORIGIN_LINES = 12;
|
|
18
16
|
|
|
19
17
|
export interface ChangeRenderInput {
|
|
@@ -56,22 +54,22 @@ export function renderChange(input: ChangeRenderInput): string {
|
|
|
56
54
|
const a = input.answer;
|
|
57
55
|
const lines: string[] = [`# ${input.code} — ${a.name} — ${input.kind}`, ""];
|
|
58
56
|
if (a.summary !== "") lines.push(...a.summary.split(/\r?\n/).map((l) => `> ${l}`.trimEnd()), "");
|
|
59
|
-
lines.push(...section(
|
|
57
|
+
lines.push(...section(CHANGE_SECTIONS.origin, input.origin));
|
|
60
58
|
const known = input.facts.join("\n");
|
|
61
59
|
const own = a.evidence.filter((e) => !known.includes(e)).map((e) => `- ${e}`);
|
|
62
|
-
const suspected = a.suspected === "" || known.includes(a.suspected) ? [] : [
|
|
63
|
-
lines.push(...section(
|
|
64
|
-
lines.push(
|
|
60
|
+
const suspected = a.suspected === "" || known.includes(a.suspected) ? [] : [`${SUSPECTED_CAUSE} (suspected): ${a.suspected}`];
|
|
61
|
+
lines.push(...section(CHANGE_SECTIONS.evidence, [...input.facts, ...(input.facts.length > 0 && own.length + suspected.length > 0 ? [""] : []), ...own, ...suspected]));
|
|
62
|
+
lines.push(CHANGE_SECTIONS.acceptance, "");
|
|
65
63
|
a.criteria.forEach((c, i) => {
|
|
66
|
-
lines.push(`### ${criterionId(i)} — ${c.name}`, `-
|
|
64
|
+
lines.push(`### ${criterionId(i)} — ${c.name}`, `- ${STATEMENT}: ${c.statement} · **Proof**: ${c.proof} · **Severity**: ${c.severity}`, "");
|
|
67
65
|
});
|
|
68
|
-
lines.push(...section(
|
|
69
|
-
|
|
66
|
+
lines.push(...section(CHANGE_SECTIONS.mustNotChange, table(
|
|
67
|
+
CHANGE_COLUMNS.mustNotChange, a.mustNotChange.map((r) => [r.behaviour, r.pinnedBy === "unpinned" ? "unpinned" : `\`${r.pinnedBy}\``]),
|
|
70
68
|
)));
|
|
71
|
-
lines.push(...section(
|
|
72
|
-
lines.push(...section(
|
|
73
|
-
lines.push(...section(
|
|
74
|
-
|
|
69
|
+
lines.push(...section(CHANGE_SECTIONS.scope, table(CHANGE_COLUMNS.scope, a.scope.map((s) => [s.in, s.out]))));
|
|
70
|
+
lines.push(...section(CHANGE_SECTIONS.constraints, a.constraints.map((c) => `- ${c}`)));
|
|
71
|
+
lines.push(...section(CHANGE_SECTIONS.assumptions, table(
|
|
72
|
+
CHANGE_COLUMNS.assumptions, a.assumptions.map((r, i) => [`A${i + 1}`, r.assumption, r.validatedBy]),
|
|
75
73
|
)));
|
|
76
74
|
lines.push(...section(CHANGE_QUESTIONS_SECTION, questionTable(input.open)));
|
|
77
75
|
lines.push(...section(CHANGE_DECISIONS_SECTION, decisionTable(input.decisions)));
|
|
@@ -0,0 +1,28 @@
|
|
|
1
|
+
// The markers of a change brief: the headings and table headers the renderer writes and the run, /dev-plan, the
|
|
2
|
+
// review and the question round read back (ADR 0026).
|
|
3
|
+
|
|
4
|
+
export const CHANGE_QUESTIONS_SECTION = "## 8. Open questions";
|
|
5
|
+
export const CHANGE_DECISIONS_SECTION = "## 9. Decisions";
|
|
6
|
+
export const ORIGIN_HEADING = /^## 1\. Origin\s*$/;
|
|
7
|
+
export const EVIDENCE_HEADING = /^## 2\. Evidence\s*$/;
|
|
8
|
+
|
|
9
|
+
/** The template's sections, numbered as /dev-plan expects them. */
|
|
10
|
+
export const CHANGE_SECTIONS = {
|
|
11
|
+
origin: "## 1. Origin",
|
|
12
|
+
evidence: "## 2. Evidence",
|
|
13
|
+
acceptance: "## 3. Acceptance",
|
|
14
|
+
mustNotChange: "## 4. What must not change",
|
|
15
|
+
scope: "## 5. Scope",
|
|
16
|
+
constraints: "## 6. Constraints",
|
|
17
|
+
assumptions: "## 7. Assumptions",
|
|
18
|
+
} as const;
|
|
19
|
+
|
|
20
|
+
/** The column headers of the template's tables. */
|
|
21
|
+
export const CHANGE_COLUMNS = {
|
|
22
|
+
mustNotChange: ["Behaviour", "Pinned by"],
|
|
23
|
+
scope: ["In", "Out"],
|
|
24
|
+
assumptions: ["#", "Assumption", "To be validated by"],
|
|
25
|
+
} as const;
|
|
26
|
+
|
|
27
|
+
/** The model's own cause in § 2, which a revision drops from the facts it carries over. */
|
|
28
|
+
export const SUSPECTED_CAUSE = "- **Suspected cause**";
|
|
@@ -0,0 +1,16 @@
|
|
|
1
|
+
// The messages of dev-change's domain: the problems the check of a change answer reports, which the model reads back
|
|
2
|
+
// on a re-ask and the person in the refusal (ADR 0026).
|
|
3
|
+
|
|
4
|
+
export const NO_CHANGE_SUMMARY = "summary: what is wrong or costly, where it shows, why now";
|
|
5
|
+
export const NO_CRITERION = "criteria: at least one acceptance criterion";
|
|
6
|
+
export const tooManyCriteria = (max: number): string => `criteria: at most ${max}`;
|
|
7
|
+
export const noProof = (id: string): string =>
|
|
8
|
+
`${id}: no proof (the test that reproduces, the measurement and its target, or "no observable behaviour changes")`;
|
|
9
|
+
export const severityIsBlockingOrWarning = (id: string): string => `${id}: severity is blocking or warning`;
|
|
10
|
+
export const PERF_NEEDS_NUMBER = "a performance change has a criterion with a number as its target";
|
|
11
|
+
export const REFACTOR_NEEDS_PIN = "a refactor names at least one behaviour that must not change, and the test pinning it or unpinned";
|
|
12
|
+
export const cellOneLine = (name: string, row: number): string => `${name} ${row}: every cell is one line, no '|'`;
|
|
13
|
+
export const noBehaviour = (row: number): string => `mustNotChange ${row}: no behaviour`;
|
|
14
|
+
export const tooManyLines = (max: number): string => `evidence and constraints: at most ${max} lines each`;
|
|
15
|
+
export const noDesign = (hit: string): string =>
|
|
16
|
+
`no design: "${hit}" names a new type, file, pattern or library; say what is observed and expected`;
|
|
@@ -14,16 +14,19 @@ import type { WorkFolder } from "../../../shared/application/dev/resolve-work-fo
|
|
|
14
14
|
import { auditCommand, closeCommand, lastVerdict, parseVerdictFile } from "../../../shared/domain/dev/verdict-format.ts";
|
|
15
15
|
import { parseBatchSheet } from "../../../shared/domain/dev/plan-format.ts";
|
|
16
16
|
import type { RepoPack } from "../../../shared/domain/dev/repo-pack.ts";
|
|
17
|
-
import {
|
|
17
|
+
import {
|
|
18
|
+
DEV_PR_AUTO_CONFIG_KEY, GIT_CURRENT_BRANCH_COMMAND, GIT_DEFAULT_BRANCH_COMMAND, parseDefaultBranch, shellQuote, workBranchFromPattern,
|
|
19
|
+
} from "../../../shared/domain/git/close.ts";
|
|
18
20
|
import type { PrSummary } from "../../../shared/domain/git/close.ts";
|
|
19
21
|
import type { PermissionRule } from "../../../shared/domain/agent-policy/permission.ts";
|
|
20
22
|
import { under } from "../domain/step-checks.ts";
|
|
21
23
|
import { openSteps, parseImplementSheet } from "../domain/step-section.ts";
|
|
22
24
|
import { markPlanBatchDone, markSheetDone } from "../domain/sheet-edits.ts";
|
|
23
|
-
import { shellQuote, workBranchFromPattern } from "../../../shared/domain/git/close.ts";
|
|
24
25
|
import { verdictMarkOf } from "./touched.ts";
|
|
25
26
|
import type { LocatedSheet } from "./locate-sheet.ts";
|
|
26
27
|
import { WORKSPACE } from "../../../shared/domain/vfs.ts";
|
|
28
|
+
import { NO_CURRENT_BRANCH, branchExistsSwitchToIt, defaultBranchAsksWorkBranch, noBranchName, noFileRecorded, notAudited, notValid, planBatchMarkedDone, planNotFound, sheetMarkedDone, sheetNotMarkedDone, sheetUnreadableAtClose, switchFailed, tddBoxOpen, verdictNotRewritten } from "./messages.ts";
|
|
29
|
+
import { branchCreated } from "../../../shared/application/git/messages.ts";
|
|
27
30
|
|
|
28
31
|
export interface CloseInput {
|
|
29
32
|
pack: RepoPack;
|
|
@@ -77,32 +80,32 @@ export async function closeDevBatch(
|
|
|
77
80
|
try {
|
|
78
81
|
verdictText = await deps.files.read(`${WORKSPACE}/${located.dir}/${verdictName}`);
|
|
79
82
|
} catch {
|
|
80
|
-
return [
|
|
83
|
+
return [notAudited(`${located.dir}/${verdictName}`, auditCommand(located.code, batch))];
|
|
81
84
|
}
|
|
82
85
|
const verdict = lastVerdict(parseVerdictFile(verdictText));
|
|
83
86
|
if (verdict?.verdict !== "VALID") {
|
|
84
|
-
return [
|
|
87
|
+
return [notValid(verdictName, verdict?.verdict ?? "missing")];
|
|
85
88
|
}
|
|
86
89
|
if (input.touched.length === 0) {
|
|
87
|
-
return [
|
|
90
|
+
return [noFileRecorded(batch, located.code)];
|
|
88
91
|
}
|
|
89
92
|
if (input.verdictMark === null || input.verdictMark === verdictMarkOf(verdictText)) {
|
|
90
|
-
return [
|
|
93
|
+
return [verdictNotRewritten(verdictName, batch, auditCommand(located.code, batch))];
|
|
91
94
|
}
|
|
92
95
|
let sheetText: string;
|
|
93
96
|
try {
|
|
94
97
|
sheetText = await deps.files.read(`${WORKSPACE}/${located.dir}/${located.name}`);
|
|
95
98
|
} catch {
|
|
96
|
-
return [
|
|
99
|
+
return [sheetUnreadableAtClose(`${located.dir}/${located.name}`)];
|
|
97
100
|
}
|
|
98
101
|
const open = openSteps(parseImplementSheet(sheetText)).map((s) => s.number);
|
|
99
102
|
if (open.length > 0) {
|
|
100
|
-
return [
|
|
103
|
+
return [tddBoxOpen(open.join(", "), located.name, located.code, batch)];
|
|
101
104
|
}
|
|
102
105
|
|
|
103
106
|
const current = await runGit(deps.shell, GIT_CURRENT_BRANCH_COMMAND);
|
|
104
107
|
const branch = current.exitCode === 0 ? current.stdout.trim() : "";
|
|
105
|
-
if (branch === "") return [
|
|
108
|
+
if (branch === "") return [NO_CURRENT_BRANCH + rerun];
|
|
106
109
|
const base = await runGit(deps.shell, GIT_DEFAULT_BRANCH_COMMAND);
|
|
107
110
|
const defaultBranch = base.exitCode === 0 ? parseDefaultBranch(base.stdout) : null;
|
|
108
111
|
const wanted = input.pack.contrib.branch?.trim();
|
|
@@ -110,9 +113,9 @@ export async function closeDevBatch(
|
|
|
110
113
|
const notes: string[] = [];
|
|
111
114
|
if (wanted && defaultBranch !== null && branch === defaultBranch) {
|
|
112
115
|
const made = await createWorkBranch(deps.shell, wanted, located.code, batch);
|
|
113
|
-
if (!made.ok) return [
|
|
116
|
+
if (!made.ok) return [defaultBranchAsksWorkBranch(branch, wanted, made.reason, rerun)];
|
|
114
117
|
onBranch = made.branch;
|
|
115
|
-
notes.push(
|
|
118
|
+
notes.push(branchCreated(made.branch, branch, wanted));
|
|
116
119
|
}
|
|
117
120
|
|
|
118
121
|
const parsed = parseBatchSheet(sheetText);
|
|
@@ -146,12 +149,12 @@ async function createWorkBranch(
|
|
|
146
149
|
shell: Pick<Shell, "run">, pattern: string, code: string, batch: string,
|
|
147
150
|
): Promise<{ ok: true; branch: string } | { ok: false; reason: string }> {
|
|
148
151
|
const name = workBranchName(pattern, code, batch);
|
|
149
|
-
if (name === null) return { ok: false, reason:
|
|
152
|
+
if (name === null) return { ok: false, reason: noBranchName(pattern) };
|
|
150
153
|
const exists = await runGit(shell, `git rev-parse --verify --quiet ${shellQuote(`refs/heads/${name}`)}`);
|
|
151
|
-
if (exists.exitCode === 0) return { ok: false, reason:
|
|
154
|
+
if (exists.exitCode === 0) return { ok: false, reason: branchExistsSwitchToIt(name) };
|
|
152
155
|
const made = await runGit(shell, `git switch -c ${shellQuote(name)}`);
|
|
153
156
|
if (made.exitCode !== 0) {
|
|
154
|
-
return { ok: false, reason:
|
|
157
|
+
return { ok: false, reason: switchFailed(name, (made.stderr || made.stdout).trim().split("\n")[0] || `exit ${made.exitCode}`) };
|
|
155
158
|
}
|
|
156
159
|
return { ok: true, branch: name };
|
|
157
160
|
}
|
|
@@ -165,19 +168,19 @@ async function markDone(files: Files, located: LocatedSheet, batch: string, shee
|
|
|
165
168
|
const now = await files.read(sheetPath).catch(() => sheetText);
|
|
166
169
|
const marked = markSheetDone(now, today);
|
|
167
170
|
if (marked !== now) await files.write(sheetPath, marked);
|
|
168
|
-
out.push(
|
|
171
|
+
out.push(sheetMarkedDone(located.name, today));
|
|
169
172
|
} catch (e) {
|
|
170
|
-
out.push(
|
|
173
|
+
out.push(sheetNotMarkedDone(located.name, String((e as Error)?.message ?? e).split("\n")[0]));
|
|
171
174
|
}
|
|
172
175
|
try {
|
|
173
176
|
const plan = await files.read(`${WORKSPACE}/${located.dir}/${planName}`);
|
|
174
177
|
const marked = markPlanBatchDone(plan, batch, today);
|
|
175
178
|
if (marked !== plan) {
|
|
176
179
|
await files.write(`${WORKSPACE}/${located.dir}/${planName}`, marked);
|
|
177
|
-
out.push(
|
|
180
|
+
out.push(planBatchMarkedDone(planName, batch));
|
|
178
181
|
}
|
|
179
182
|
} catch {
|
|
180
|
-
out.push(
|
|
183
|
+
out.push(planNotFound(planName, batch));
|
|
181
184
|
}
|
|
182
185
|
return out;
|
|
183
186
|
}
|