orez 0.0.63 → 0.0.64

package/src/replication/change-tracker.test.ts

@@ -144,6 +144,23 @@ describe('change-tracker', () => {
     expect(internalChanges).toHaveLength(0)
   })
 
+  it('respects empty configured publication (tracks no public tables)', async () => {
+    const prev = process.env.ZERO_APP_PUBLICATIONS
+    process.env.ZERO_APP_PUBLICATIONS = 'zero_scope'
+    try {
+      await db.exec(`CREATE PUBLICATION "zero_scope"`)
+      await installChangeTracking(db) // reinstall picks up publication scope
+      await db.exec(`TRUNCATE public._zero_changes`)
+
+      await db.exec(`INSERT INTO public.items (name, value) VALUES ('x', 1)`)
+      const changes = await getChangesSince(db, 0)
+      expect(changes).toHaveLength(0)
+    } finally {
+      if (prev === undefined) delete process.env.ZERO_APP_PUBLICATIONS
+      else process.env.ZERO_APP_PUBLICATIONS = prev
+    }
+  })
+
   it('handles NULL column values', async () => {
     await db.exec(`INSERT INTO public.items (name, value) VALUES ('nulltest', NULL)`)
 

package/src/replication/change-tracker.ts

@@ -76,12 +76,10 @@ function quoteIdent(name: string): string {
 }
 
 async function installTriggersOnAllTables(db: PGlite): Promise<void> {
-  // use the configured app publication to determine which tables to track.
-  // this avoids streaming changes for private tables (user, account, session, etc.)
-  // that zero-cache doesn't know about.
-  const pubName = process.env.ZERO_APP_PUBLICATIONS
+  // If a publication is configured, respect it strictly. This avoids accidentally
+  // streaming private tables when publication membership is temporarily empty.
+  const pubName = process.env.ZERO_APP_PUBLICATIONS?.trim()
   let tables: { tablename: string }[]
-
   if (pubName) {
     const result = await db.query<{ tablename: string }>(
       `SELECT tablename FROM pg_publication_tables
@@ -91,38 +89,38 @@ async function installTriggersOnAllTables(db: PGlite): Promise<void> {
       [pubName]
     )
     tables = result.rows
-    log.debug.pglite(`using publication "${pubName}" (${tables.length} tables)`)
-    if (tables.length === 0) {
-      log.debug.pglite(
-        `publication "${pubName}" has no tables yet (will be populated by migrations)`
-      )
-    }
-
-    // drop stale triggers from tables NOT in the publication
-    // (these may exist from a prior install before the publication was created)
-    const publishedSet = new Set(tables.map((t) => t.tablename))
-    const allTriggered = await db.query<{ event_object_table: string }>(
-      `SELECT DISTINCT event_object_table FROM information_schema.triggers
-       WHERE trigger_name = '_zero_change_trigger'
-         AND event_object_schema = 'public'`
-    )
-    for (const { event_object_table } of allTriggered.rows) {
-      if (!publishedSet.has(event_object_table)) {
-        const quoted = quoteIdent(event_object_table)
-        await db.exec(`DROP TRIGGER IF EXISTS _zero_change_trigger ON public.${quoted}`)
-        log.debug.pglite(
-          `removed stale trigger from non-published table: ${event_object_table}`
-        )
-      }
+    if (tables.length > 0) {
+      log.debug.pglite(`using publication "${pubName}" (${tables.length} tables)`)
+    } else {
+      log.pglite(`publication "${pubName}" is empty; installing no public table triggers`)
     }
   } else {
-    const result = await db.query<{ tablename: string }>(
+    const all = await db.query<{ tablename: string }>(
       `SELECT tablename FROM pg_tables
        WHERE schemaname = 'public'
          AND tablename NOT IN ('migrations', '_zero_changes')
          AND tablename NOT LIKE '_zero_%'`
     )
-    tables = result.rows
+    tables = all.rows
+    log.debug.pglite(`using all public tables (${tables.length})`)
+  }
+
+  // drop stale triggers from tables NOT in the publication
+  // (these may exist from a prior install before the publication was created)
+  const publishedSet = new Set(tables.map((t) => t.tablename))
+  const allTriggered = await db.query<{ event_object_table: string }>(
+    `SELECT DISTINCT event_object_table FROM information_schema.triggers
+     WHERE trigger_name = '_zero_change_trigger'
+       AND event_object_schema = 'public'`
+  )
+  for (const { event_object_table } of allTriggered.rows) {
+    if (!publishedSet.has(event_object_table)) {
+      const quoted = quoteIdent(event_object_table)
+      await db.exec(`DROP TRIGGER IF EXISTS _zero_change_trigger ON public.${quoted}`)
+      log.debug.pglite(
+        `removed stale trigger from non-published table: ${event_object_table}`
+      )
+    }
   }
 
   let count = 0

package/src/replication/handler.ts

@@ -299,24 +299,30 @@ export async function handleStartReplication(
     $$ LANGUAGE plpgsql;
   `)
 
-    // install notify trigger on tracked tables (use configured publication if available)
-    const pubName = process.env.ZERO_APP_PUBLICATIONS
+    // install notify triggers from configured publication when available.
+    // when publication is configured but empty, install none to preserve scope.
+    const pubName = process.env.ZERO_APP_PUBLICATIONS?.trim()
     let tables: { tablename: string }[]
     if (pubName) {
       const result = await db.query<{ tablename: string }>(
         `SELECT tablename FROM pg_publication_tables
-       WHERE pubname = $1 AND schemaname = 'public' AND tablename NOT LIKE '_zero_%'`,
+         WHERE pubname = $1 AND schemaname = 'public' AND tablename NOT LIKE '_zero_%'`,
         [pubName]
       )
       tables = result.rows
+      if (tables.length === 0) {
+        log.proxy(
+          `publication "${pubName}" is empty; installing no public notify triggers`
+        )
+      }
     } else {
-      const result = await db.query<{ tablename: string }>(
+      const all = await db.query<{ tablename: string }>(
         `SELECT tablename FROM pg_tables
-       WHERE schemaname = 'public'
-         AND tablename NOT IN ('migrations', '_zero_changes')
-         AND tablename NOT LIKE '_zero_%'`
+         WHERE schemaname = 'public'
+           AND tablename NOT IN ('migrations', '_zero_changes')
+           AND tablename NOT LIKE '_zero_%'`
       )
-      tables = result.rows
+      tables = all.rows
     }
 
     for (const { tablename } of tables) {