orchid-orm 1.57.6 → 1.57.8

package/dist/migrations/node-postgres.mjs

@@ -1,5 +1,5 @@
 import { promptSelect, getSchemaAndTableFromName, getDbTableColumnsChecks, dbColumnToAst, instantiateDbColumn, concatSchemaAndName, encodeColumnDefault, getIndexName, getExcludeName, getConstraintName, tableToAst, getDbStructureTableData, makeDomainsMap, astToMigration, createMigrationInterface, introspectDbSchema, makeStructureToAstCtx, makeFileVersion, writeMigrationFile, migrateAndClose, migrate, structureToAst, saveMigratedVersion, rakeDbCommands } from 'rake-db';
-import { colors, toSnakeCase, deepCompare, emptyArray, toArray, getFreeSetAlias, exhaustive, toCamelCase, addCode, pluralize, codeToString, toPascalCase, getImportPath, singleQuote, quoteObjectKey, pathToLog } from 'orchid-core';
+import { noop, colors, toSnakeCase, deepCompare, emptyArray, toArray, getFreeSetAlias, exhaustive, toCamelCase, addCode, pluralize, codeToString, toPascalCase, getImportPath, singleQuote, quoteObjectKey, pathToLog } from 'orchid-core';
 import { EnumColumn, ArrayColumn, getColumnBaseType, RawSQL, VirtualColumn, DomainColumn, UnknownColumn, defaultSchemaConfig, columnsShapeToCode, pushTableDataCode } from 'pqb';
 import path from 'node:path';
 import { pathToFileURL } from 'url';
@@ -8,43 +8,33 @@ import typescript from 'typescript';
 export * from 'rake-db/node-postgres';
 
 const compareSqlExpressions = async (tableExpressions, adapter) => {
-  if (tableExpressions.length) {
-    let id = 1;
-    await Promise.all(
-      tableExpressions.map(async ({ source, compare, handle }) => {
-        const viewName = `orchidTmpView${id++}`;
-        const values = [];
-        let result;
-        try {
-          const results = await adapter.query(
-            // It is important to run `CREATE TEMPORARY VIEW` and `DROP VIEW` on the same db connection,
-            // that's why SQLs are combined into a single query.
-            [
-              `CREATE TEMPORARY VIEW ${viewName} AS (SELECT ${compare.map(
-                ({ inDb, inCode }, i) => `${inDb} AS "*inDb-${i}*", ${inCode.map(
-                  (s, j) => `(${typeof s === "string" ? s : s.toSQL({ values })}) "*inCode-${i}-${j}*"`
-                ).join(", ")}`
-              ).join(", ")} FROM ${source})`,
-              `SELECT pg_get_viewdef('${viewName}') v`,
-              `DROP VIEW ${viewName}`
-            ].join("; "),
-            values
-          );
-          result = results[1];
-        } catch {
-        }
-        if (!result) {
-          handle();
-          return;
-        }
-        const match = compareSqlExpressionResult(
-          result.rows[0].v,
-          compare[0].inCode
-        );
-        handle(match);
-      })
-    );
-  }
+  if (!tableExpressions.length) return;
+  let id = 1;
+  await Promise.all(
+    tableExpressions.map(async ({ source, compare, handle }) => {
+      const viewName = `orchidTmpView${id++}`;
+      const values = [];
+      const combinedQueries = [
+        `CREATE TEMPORARY VIEW ${viewName} AS (SELECT ${compare.map(
+          ({ inDb, inCode }, i) => `${inDb} AS "*inDb-${i}*", ${inCode.map(
+            (s, j) => `(${typeof s === "string" ? s : s.toSQL({ values })}) "*inCode-${i}-${j}*"`
+          ).join(", ")}`
+        ).join(", ")} FROM ${source})`,
+        `SELECT pg_get_viewdef('${viewName}') v`,
+        `DROP VIEW ${viewName}`
+      ].join("; ");
+      const result = await adapter.query(combinedQueries, values).then((res) => res[1], noop);
+      if (!result) {
+        handle();
+        return;
+      }
+      const match = compareSqlExpressionResult(
+        result.rows[0].v,
+        compare[0].inCode
+      );
+      handle(match);
+    })
+  );
 };
 const compareSqlExpressionResult = (resultSql, inCode) => {
   let pos = 7;
@@ -626,6 +616,12 @@ const getColumnDbType = (column, currentSchema) => {
     return column.dataType;
   }
 };
+const getColumnDbTypeQuoted = (column, currentSchema) => {
+  const [schema, type] = getSchemaAndTableFromName(
+    getColumnDbType(column, currentSchema)
+  );
+  return schema ? `"${schema}"."${type}"` : `"${type}"`;
+};
 const renameColumn = (columns, from, to) => {
   for (let i = 0; i < columns.length; i++) {
     if (columns[i] === from) {
@@ -1975,7 +1971,7 @@ const applyChangeTables = async (adapter, changeTables, structureToAstCtx, dbStr
         if (!column.dataType) continue;
         const name = column.data.name ?? key;
         names.push(name);
-        types.push(getColumnDbType(column, currentSchema));
+        types.push(getColumnDbTypeQuoted(column, currentSchema));
       }
       const tableName = codeTable.table;
       const source = `(VALUES (${types.map((x) => `NULL::${x}`).join(", ")})) "${tableName}"(${names.map((x) => `"${x}"`).join(", ")})`;