orchestrator-workflow 0.30.0 → 0.31.0

package/CHANGELOG.md

@@ -7,6 +7,45 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.31.0] - 2026-09-07
+
+### Changed
+
+- Tests only, no asset wording change. The reviewer prompt's output-contract
+  yaml-block negative pin now slices from the output-contract heading (and
+  requires exactly one yaml fence after it) instead of matching the first
+  yaml fence in the file, so an unrelated fence earlier in the prompt cannot
+  be mistaken for the output contract. The CHANGELOG's own prose copy of the
+  fix-round mutation-probe replay rule is now pinned, anchored on the
+  bullet's own opening text rather than the release heading above it, so
+  the pin survives the bullet moving under a version heading. A new guard
+  asserts every reviewer checklist item mirrored in SKILL.md (Placement,
+  the GitHub Actions run-step replay, identifier drift) still carries its
+  SKILL.md counterpart sentence, from one table of paired phrases, so
+  either half going missing fails the same test.
+
+- The implementer prompt now requires running every long test, build, or
+  mutation-probe command in the foreground and waiting for it to finish
+  before returning, never backgrounding it and ending the turn: a batch
+  review found a probe run left running in the background whose result
+  was only recovered by resuming the subagent later, which is not
+  evidence the orchestrator can trust unattended. The reviewer and
+  implementer prompts now both caution against a spawned-CLI test
+  calibrated to a byte-count ceiling that sits inside the tool's own
+  run-to-run noise (timing digits, temp-directory names): a batch review
+  found exactly such a test pass locally and fail on the next run one
+  byte off, with no code change, and the fix is to pin the argument
+  under test in-process or assert the actual contract (a bound, or the
+  presence of a warning), never a byte ceiling. SKILL.md's Delegate
+  review step now prohibits running mutation probes in place against a
+  worktree a reviewer subagent is concurrently reviewing, after a batch
+  review found a reviewer verifying findings against a tree that was
+  mutating under it from a concurrent probe; the fix is worktree
+  isolation or waiting until the reviewer has returned. Consumers refresh
+  their installs at the next release to pick up all three prompt changes.
+  Motivated by agent-tasks task 0e17fb63; see `docs/okf/log.md` for the
+  incident detail behind each of the three rules.
+
 ## [0.30.0] - 2026-09-06
 
 ### Added

package/assets/agents/implementer.md

@@ -53,6 +53,17 @@ Rules:
   criteria name and report its summary under `tests.executed`; when a
   mutation-probe runner is available, run the named probes through it and
   copy its fields into `mutation_probes`.
+- Run every long test, build, or mutation-probe command in the foreground
+  and wait for it to finish before returning. When one foreground call
+  cannot hold it to completion, poll the backgrounded run to completion
+  and report its result before ending your turn; never end your turn with
+  the run still outstanding, since a run that outlives your turn is not
+  evidence you can report.
+- A test that spawns a CLI and asserts its output against a byte-count
+  ceiling calibrated to sit inside the output's own run-to-run noise
+  (timing digits, temporary-directory names) is not a regression test; pin
+  the argument under test in-process, or assert the actual contract (a
+  bound, or the presence of a warning), never a byte ceiling.
 - For any diff that adds or changes a GitHub Actions `run:` step, replay it
   locally under the shell the step actually runs: `bash --noprofile --norc
   -eo pipefail` when `shell: bash` is set on the step or via

package/assets/agents/reviewer.md

@@ -38,7 +38,12 @@ Check, at minimum:
 - Edge cases: empty inputs, error paths, concurrency, encoding, limits.
 - Security: injection, path traversal, secrets, permissions, unsafe defaults.
 - Test adequacy: are the new or changed behaviors covered, and would the new
-  tests actually fail if the change were reverted? Flag inert tests.
+  tests actually fail if the change were reverted? Flag inert tests. A test
+  that spawns a CLI and asserts its output against a byte-count ceiling
+  calibrated to sit inside the output's own run-to-run noise (timing digits,
+  temporary-directory names) is not a regression test; the fix is to pin
+  the argument under test in-process, or assert the actual contract (a
+  bound, or the presence of a warning), never a byte ceiling.
 - Maintainability: naming, dead code, needless abstraction, doc drift.
 - Placement: does the change add org-, machine-, or point-in-time-bound
   evidence (dates, sample sizes, task ids, home paths, incident tallies) to a

package/assets/skill/SKILL.md

@@ -273,8 +273,8 @@ directory and the subagents.
    implementer's log — and record the method, sample size, and result against
    the implementer's claim in the reviewer output contract's `reproduction`
    field. This does not apply to deterministic checks (a single test run,
-   `tsc`, lint): only claims that could vary run to run trigger it. The
-   GitHub Actions shell replay named in step 6 is a second, explicitly
+   `tsc`, lint): only claims that could vary run to run trigger it. The GitHub
+   Actions shell replay named in step 6 is a second, explicitly
    non-probabilistic trigger for the same field, with `sample_size:
    not_applicable` allowed when the replay itself has no meaningful sample
    size. A change that deletes or renames an exported identifier, type, config
@@ -282,18 +282,21 @@ directory and the subagents.
    describing the old name as current), by the reviewer or by the orchestrator
    itself when it reviews a trivial rename per Scaling delegation, using a
    connected drift check when one exists. When this is not the task's first
-   review round, name the round
-   number in the briefing; the reviewer marks each finding's `recurrence` as
-   `new` or `repeated` against the earlier rounds it was told about, which is
-   what lets the orchestrator detect the Review-round escalation budget's
-   trigger (see below) without re-deriving it by hand. When the implementer's
-   report replays a prior round's mutation probe, the orchestrator's reviewer
-   briefing names the replayed probes the implementer reports as killed
-   together with their `mutant` and `verified_applied_via` values; the reviewer
-   may then skip re-running those. The reviewer output contract itself is
-   unchanged. For an explicitly adopted v1 run, ask the reviewer to compare the frozen delegated criteria with
-   the referenced evidence and judge semantic adequacy, including whether a
-   manual check is actually concrete and reasoned.
+   review round, name the round number in the briefing; the reviewer marks each
+   finding's `recurrence` as `new` or `repeated` against the earlier rounds it
+   was told about, which is what lets the orchestrator detect the Review-round
+   escalation budget's trigger (see below) without re-deriving it by hand. When
+   the implementer's report replays a prior round's mutation probe, the
+   orchestrator's reviewer briefing names the replayed probes the implementer
+   reports as killed together with their `mutant` and `verified_applied_via`
+   values; the reviewer may then skip re-running those. The reviewer output
+   contract itself is unchanged. Never run mutation probes in place against a
+   worktree a reviewer subagent is concurrently reviewing; isolate the probe in
+   a separate worktree or wait until the reviewer has returned before probing
+   that tree again. For an explicitly adopted v1 run, ask the reviewer to
+   compare the frozen delegated criteria with the referenced evidence and judge
+   semantic adequacy, including whether a manual check is actually concrete and
+   reasoned.
 8. **Decide acceptance.** Accept, request fixes, defer, or escalate to the
    operator. High or critical findings block acceptance until fixed or
    explicitly waived: critical findings require operator sign-off; high

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "orchestrator-workflow",
-  "version": "0.30.0",
+  "version": "0.31.0",
   "description": "Installer for an orchestrator-led agent workflow: .ai/ run state, an AGENTS.md policy section, and per-harness subagent definitions for Claude Code, OpenAI Codex, and opencode",
   "main": "dist/index.js",
   "type": "module",