orc-shared 5.8.0-dev.8 → 5.8.0

package/src/components/MaterialUI/hocs/withDeferredPopper.js

@@ -78,16 +78,13 @@ const withDeferredPopper =
 		const defaultComponent = <Comp onClick={event => togglePopper(event)} {...props} />;
 
 		const togglePopper = function (event) {
-			const linkParent = event?._dispatchInstances?.filter(item => item.elementType === "a");
-			if (linkParent) {
-				event.preventDefault();
-			}
 			const isDisplayed = !popperState.isDisplayed;
 			const anchorElement = event.currentTarget;
 			setPopperState({
 				isDisplayed: isDisplayed,
 				anchorElement: anchorElement,
 			});
+			event.preventDefault();
 			event.bubbles = false;
 			event.stopPropagation();
 		};

package/src/components/MaterialUI/hocs/withDeferredPopper.test.js

@@ -265,6 +265,7 @@ describe("withDeferredPopper", () => {
 		ignoreConsoleError(() => {
 			const event = {
 				currentTarget: wrapper,
+				preventDefault: jest.fn(),
 				stopPropagation: jest.fn(),
 			};
 
@@ -296,6 +297,7 @@ describe("withDeferredPopper", () => {
 		ignoreConsoleError(() => {
 			const event = {
 				currentTarget: null,
+				preventDefault: jest.fn(),
 				stopPropagation: jest.fn(),
 			};
 

package/src/components/Modal/Modal.test.js

@@ -22,7 +22,9 @@ describe("Modal", () => {
 	afterEach(() => {
 		try {
 			ReactDOM.unmountComponentAtNode(appRoot);
-		} catch (_) {}
+		} catch {
+			// don't do anything
+		}
 		document.body.removeChild(appRoot);
 		document.body.removeChild(modalRoot);
 	});

package/src/components/Modal/Wrapper.test.js

@@ -35,7 +35,9 @@ describe("Wrapper", () => {
 		afterEach(() => {
 			try {
 				ReactDOM.unmountComponentAtNode(appRoot);
-			} catch (_) {}
+			} catch {
+				// don't do anything
+			}
 			document.body.removeChild(appRoot);
 			document.body.removeChild(modalRoot);
 		});

package/src/components/Routing/SegmentPage.js

@@ -168,7 +168,7 @@ const SegmentPage = ({
 	modulePrependPath,
 	entityIdResolver,
 }) => {
-	const classes = useStyles({ isComponentNull: !!!View });
+	const classes = useStyles({ isComponentNull: !View });
 	const pattern = new UrlPattern(path);
 	const baseHref = pattern.stringify(match.params);
 	const pages = [],

package/src/components/Scope/Scope.test.js

@@ -121,7 +121,9 @@ beforeEach(() => {
 afterEach(() => {
 	try {
 		ReactDOM.unmountComponentAtNode(appRoot);
-	} catch (_) {}
+	} catch {
+		// don't do anything
+	}
 	document.body.removeChild(appRoot);
 	document.body.removeChild(modalRoot);
 });

package/src/components/Sidepanel.test.js

@@ -25,7 +25,9 @@ describe("Sidepanel", () => {
 	afterEach(() => {
 		try {
 			ReactDOM.unmountComponentAtNode(appRoot);
-		} catch (_) {}
+		} catch {
+			// don't do anything
+		}
 		document.body.removeChild(appRoot);
 		document.body.removeChild(modalRoot);
 	});

package/src/components/ToastList.js

@@ -104,8 +104,8 @@ const ListWrapper = styled(TransitionGroup)`
 export const ToastList = ({ toasts }) =>
 	ReactDOM.createPortal(
 		<ListWrapper>
-			{toasts.map(props => (
-				<Toast {...props} />
+			{toasts.map((props, idx) => (
+				<Toast key={"toast" + idx} {...props} />
 			))}
 		</ListWrapper>,
 		portal,

package/src/constants.js

@@ -1,5 +1,10 @@
 export const infoBar = "infoBar";
 
+export const applications = {
+	oms: "oms",
+	pim: "pim",
+};
+
 export const scopeTypes = {
 	global: "Global",
 	virtual: "Virtual",

package/src/hocs/withErrorBoundary.test.js

@@ -28,9 +28,10 @@ describe("withErrorBoundary", () => {
 			{ args: ["Caught an error: Fail, at boundary Failed"] },
 			{
 				args: [
-					"\n    in FailBall (created by ErrorBoundary)\n" +
-						"    in ErrorBoundary (created by BoundedFailBall)\n" +
-						"    in BoundedFailBall",
+					expect.it(
+						"to match",
+						/at FailBall.*withErrorBoundary\.test\.js.*at ErrorBoundary.*withErrorBoundary\.js.*at BoundedFailBall/s,
+					),
 				],
 			},
 		]);

package/src/hooks/useEditState.test.js

@@ -1,3 +1,5 @@
+/* eslint-disable react/no-unknown-property */
+
 import React from "react";
 import { useEditState, useDynamicEditState } from "./useEditState";
 import { TestWrapper } from "./../utils/testUtils";

package/src/hooks/useLabelMessage.test.js

@@ -1,3 +1,5 @@
+/* eslint react/no-unknown-property: off */
+
 import React from "react";
 import { Provider } from "react-redux";
 import { IntlProvider } from "react-intl";

package/src/utils/buildUrl.js

@@ -1,3 +1,5 @@
+import { applications } from "../constants";
+
 /* Constructs a URL search string from an object with key value pairs */
 const buildParamString = params =>
 	Object.entries(params)
@@ -32,6 +34,19 @@ export const loadConfig = () =>
 				`${host}/${pathParts.join("/")}` + (parameters ? "?" + buildParamString(parameters) : "");
 		});
 
+export const buildExternalAppUrl = (app, relativeUrl) => {
+	const url = relativeUrl[0] === "/" ? relativeUrl.substring(1) : relativeUrl;
+
+	let lowercaseApp = app.toLowerCase();
+	switch (lowercaseApp) {
+		case applications.oms:
+		case applications.pim:
+			return `/${lowercaseApp}/app/${url}`;
+		default:
+			throw new Error("Not implemented app '" + app + "'");
+	}
+};
+
 /* Reset function for testing, never use this in actual code */
 export const resetConfig = () => {
 	buildUrl = placeholder;

package/src/utils/buildUrl.test.js

@@ -1,6 +1,6 @@
 import sinon from "sinon";
 import { spyOnConsole } from "./testUtils";
-import { loadConfig, resetConfig, buildUrl } from "./buildUrl";
+import { loadConfig, resetConfig, buildUrl, buildExternalAppUrl } from "./buildUrl";
 
 describe("loadConfig", () => {
 	spyOnConsole();
@@ -72,4 +72,30 @@ describe("loadConfig", () => {
 				));
 		});
 	});
+
+	describe("buildExternalAppUrl", () => {
+		it("throws an error if called with an unknown app", () => {
+			expect(
+				() => expect(buildExternalAppUrl, "when called with", ["unknown", "fakeurl"]),
+				"to throw",
+				"Not implemented app 'unknown'",
+			);
+		});
+
+		it("should build an valid relative url with oms", () => {
+			expect(buildExternalAppUrl, "called with", ["oms", "fakeurl"], "to equal", "/oms/app/fakeurl");
+		});
+
+		it("should build an valid relative url with pim", () => {
+			expect(buildExternalAppUrl, "called with", ["pim", "fakeurl"], "to equal", "/pim/app/fakeurl");
+		});
+
+		it("should not be case sensitive about the app name", () => {
+			expect(buildExternalAppUrl, "called with", ["PIM", "fakeurl"], "to equal", "/pim/app/fakeurl");
+		});
+
+		it("should handle delimiter", () => {
+			expect(buildExternalAppUrl, "called with", ["pim", "/fakeurl"], "to equal", "/pim/app/fakeurl");
+		});
+	});
 });

package/src/utils/inputHelper.js

@@ -1,6 +1,22 @@
 export const trimSpacesAndLeadingZeros = (value, fallback = "") => {
-	const trimmed = (value ?? "").trim().replace(/^0+/, "");
-	return trimmed === "" ? fallback : limitNumericValueLength(trimmed);
+	if (!value || isNaN(value)) {
+		return fallback;
+	}
+
+	let trimmed = value.trim();
+	const isNegative = trimmed[0] === "-";
+	if (isNegative) {
+		trimmed = trimmed.substring(1, trimmed.length);
+	}
+
+	const withoutLeadingZeros = trimmed.replace(/^0+/, "");
+	if (withoutLeadingZeros == "") {
+		return "0";
+	}
+
+	const cleanNumber = `${isNegative ? "-" : ""}${withoutLeadingZeros}`;
+
+	return limitNumericValueLength(cleanNumber);
 };
 
 export const limitNumericValueLength = (value, maximum = 9) => value.substring(0, maximum);

package/src/utils/inputHelper.test.js

@@ -5,14 +5,26 @@ describe("Numeric Input Helper", () => {
 		expect(trimSpacesAndLeadingZeros, "when called with", ["  00013 "], "to equal", "13");
 	});
 
-	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning fallback value", () => {
-		expect(trimSpacesAndLeadingZeros, "when called with", [" 000  ", "def"], "to equal", "def");
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning 0 when 000 value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", [" 000  ", "def"], "to equal", "0");
+	});
+
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning fallback when empty string value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["", "def"], "to equal", "def");
+	});
+
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning 0 when 0 value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", [" 0 ", "def"], "to equal", "0");
 	});
 
 	it("trimSpacesAndLeadingZeros should work on floating values", () => {
 		expect(trimSpacesAndLeadingZeros, "when called with", ["042.2", "def"], "to equal", "42.2");
 	});
 
+	it("trimSpacesAndLeadingZeros should work on negative values", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["-0012.2", "def"], "to equal", "-12.2");
+	});
+
 	it("trimSpacesAndLeadingZeros returns fallback on null value", () => {
 		expect(trimSpacesAndLeadingZeros, "when called with", [null, "def"], "to equal", "def");
 	});
@@ -21,6 +33,10 @@ describe("Numeric Input Helper", () => {
 		expect(trimSpacesAndLeadingZeros, "when called with", [undefined, "def"], "to equal", "def");
 	});
 
+	it("trimSpacesAndLeadingZeros returns fallback when value is not a number", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["hello", "def"], "to equal", "def");
+	});
+
 	it("limitNumericValueLength trims extra characters", () => {
 		expect(limitNumericValueLength, "when called with", ["01234567890"], "to equal", "012345678");
 	});

package/src/utils/normalizeForSearch.js

@@ -6,6 +6,8 @@ if ("".normalize) {
 			.toLowerCase()
 			// Strip accents by normalizing to letters + combining chars, then strip all combining chars.
 			.normalize("NFKD")
+			// Note AD20240801: the new eslint config complains on the next line however I have no idea what it is supposed to do so to be safe I'll disable the warning
+			// eslint-disable-next-line no-misleading-character-class
 			.replace(/[\u0300-\u036f\u1ab0-\u1aff\u1dc0-\u1dff\u20d0-\u20ff\ufe20-\ufe2f]/g, "");
 } else {
 	// IE11 does not support string#normalize(). V. sad for IE users.

package/src/utils/propertyBagHelper.js

@@ -149,7 +149,7 @@ export const getPropertyBagFormattedPrimitiveValue = (propertyBagValue, formatMe
 	}
 
 	if (dataTypesChecker.isBoolean(propertyBagValue[serializationTypeKey])) {
-		return Boolean(propertyBagValue.value)
+		return propertyBagValue.value
 			? formatMessage(sharedMessages.valueTypeWrapperTrue)
 			: formatMessage(sharedMessages.valueTypeWrapperFalse);
 	}
@@ -182,7 +182,7 @@ export const formatNumber = (value, precision) => Number(value).toFixed(precisio
 
 export const fixPropertyBagModifiedModel = (model, ...fields) => {
 	const fixProfileOperations = model => {
-		if (model.hasOwnProperty("profileOperations")) {
+		if (Object.prototype.hasOwnProperty.call(model, "profileOperations")) {
 			let { profilesToAdd, profilesToUpdate } = model.profileOperations;
 			if (profilesToAdd) {
 				const items = Array.isArray(profilesToAdd) ? profilesToAdd : Object.values(profilesToAdd);
@@ -224,7 +224,10 @@ export const fixPropertyBagEmptyValues = propertyBag => {
 	const modifiedFields = Object.keys(propertyBag);
 	modifiedFields.forEach(propertyName => {
 		let property = propertyBag[propertyName];
-		let propertyValue = property && isObject(property) && property.hasOwnProperty("value") ? property.value : property;
+		let propertyValue =
+			property && isObject(property) && Object.prototype.hasOwnProperty.call(property, "value")
+				? property.value
+				: property;
 		if (propertyValue === "") {
 			propertyBag[propertyName] = null;
 		}

package/src/utils/propertyHelper.js

@@ -22,13 +22,13 @@ export function getPropertyOrDefault(obj, property, defaultValue, ignoreCase = f
 	}
 
 	if (ignoreCase === false && startWith === false) {
-		return obj.hasOwnProperty(property) ? obj[property] : defaultValue;
+		return Object.prototype.hasOwnProperty.call(obj, property) ? obj[property] : defaultValue;
 	}
 
 	const compareFunction = startWith ? caseInsensitiveStartWithCompare : caseInsensitiveCompare;
 
 	for (let prop in obj) {
-		if (obj.hasOwnProperty(prop) && compareFunction(prop, property)) {
+		if (Object.prototype.hasOwnProperty.call(obj, prop) && compareFunction(prop, property)) {
 			return obj[prop];
 		}
 	}
@@ -39,12 +39,12 @@ export function getPropertyOrDefault(obj, property, defaultValue, ignoreCase = f
 export const isObjectContainsPropertyWithValue = (obj, propertyName, value) => {
 	if (obj === null || obj === undefined) return false;
 
-	if (obj.hasOwnProperty(propertyName) && obj[propertyName] === value) {
+	if (Object.prototype.hasOwnProperty.call(obj, propertyName) && obj[propertyName] === value) {
 		return true;
 	}
 
 	for (let prop in obj) {
-		if (obj.hasOwnProperty(prop) && typeof obj[prop] === "object") {
+		if (Object.prototype.hasOwnProperty.call(obj, prop) && typeof obj[prop] === "object") {
 			if (isObjectContainsPropertyWithValue(obj[prop], propertyName, value)) return true;
 		}
 	}
@@ -55,12 +55,12 @@ export const isObjectContainsPropertyWithValue = (obj, propertyName, value) => {
 export const isObjectContainsPropertyWithAnyValue = (obj, propertyName) => {
 	if (!obj) return false;
 
-	if (obj.hasOwnProperty(propertyName) && obj[propertyName]) {
+	if (Object.prototype.hasOwnProperty.call(obj, propertyName) && obj[propertyName]) {
 		return true;
 	}
 
 	for (let prop in obj) {
-		if (obj.hasOwnProperty(prop) && typeof obj[prop] === "object") {
+		if (Object.prototype.hasOwnProperty.call(obj, prop) && typeof obj[prop] === "object") {
 			if (isObjectContainsPropertyWithAnyValue(obj[prop], propertyName)) return true;
 		}
 	}

package/src/utils/testUtils.js

@@ -15,6 +15,7 @@ const sinon = require("sinon");
 /* istanbul ignore next */
 export const spyOnConsole = (spyNames = ["log", "warn", "error"]) => {
 	let spiedFuncs;
+	// eslint-disable-next-line no-undef
 	beforeEach(() => {
 		spiedFuncs = spyNames.map(funcName => {
 			const func = sinon.spy().named("console." + funcName);
@@ -23,6 +24,7 @@ export const spyOnConsole = (spyNames = ["log", "warn", "error"]) => {
 			return oldFunc;
 		});
 	});
+	// eslint-disable-next-line no-undef
 	afterEach(() => {
 		spiedFuncs.forEach((func, index) => {
 			const name = spyNames[index];
@@ -74,34 +76,35 @@ export const PropStruct = React.forwardRef((props, ref) => (
 				value === undefined || value === null
 					? null
 					: value === "__ignore"
-					? [<Ignore key={"dt-" + key} />, <Ignore key={"dd-" + key} />]
-					: [
-							<dt key={"dt-" + key}>{`${key}:`}</dt>,
-							<dd key={"dd-" + key}>
-								{key === "children" ? (
-									value
-								) : typeof value === "object" ? (
-									value["$$typeof"] && value["$$typeof"] === Symbol.for("react.element") ? (
-										"React <" + (value.type.name || value.type) + ">"
+						? [<Ignore key={"dt-" + key} />, <Ignore key={"dd-" + key} />]
+						: [
+								<dt key={"dt-" + key}>{`${key}:`}</dt>,
+								<dd key={"dd-" + key}>
+									{key === "children" ? (
+										value
+									) : typeof value === "object" ? (
+										value["$$typeof"] && value["$$typeof"] === Symbol.for("react.element") ? (
+											"React <" + (value.type.name || value.type) + ">"
+										) : (
+											<PropStruct {...value} />
+										)
+									) : typeof value === "function" ? (
+										"Function"
+									) : typeof value === "string" ? (
+										`string "${value}"`
+									) : typeof value === "symbol" ? (
+										`symbol ${value.toString()}`
 									) : (
-										<PropStruct {...value} />
-									)
-								) : typeof value === "function" ? (
-									"Function"
-								) : typeof value === "string" ? (
-									`string "${value}"`
-								) : typeof value === "symbol" ? (
-									`symbol ${value.toString()}`
-								) : (
-									typeof value + " " + value
-								)}
-							</dd>,
-					  ],
+										typeof value + " " + value
+									)}
+								</dd>,
+							],
 			)}
 	</dl>
 ));
 
 export const ignoreConsoleError = func => {
+	// eslint-disable-next-line no-undef
 	jest.spyOn(console, "error");
 	console.error.mockImplementation(() => {});
 

package/src/utils/testUtils.test.js

@@ -187,7 +187,7 @@ describe("PropStruct", () => {
 				<dt>num:</dt>
 				<dd>number 1</dd>
 				<dt>str:</dt>
-				<dd>string "foo"</dd>
+				<dd>string &quot;foo&quot;</dd>
 			</dl>,
 		));
 
@@ -198,7 +198,7 @@ describe("PropStruct", () => {
 			"to satisfy",
 			<dl id="testProps">
 				<dt>id:</dt>
-				<dd>string "testProps"</dd>
+				<dd>string &quot;testProps&quot;</dd>
 			</dl>,
 		));
 
@@ -261,7 +261,7 @@ describe("PropStruct", () => {
 					<div id="tc2" />
 				</dd>
 				<dt>foo:</dt>
-				<dd>string "bar"</dd>
+				<dd>string &quot;bar&quot;</dd>
 			</dl>,
 		));
 
@@ -275,7 +275,7 @@ describe("PropStruct", () => {
 				<dd>
 					<dl>
 						<dt>bar:</dt>
-						<dd>string "false"</dd>
+						<dd>string &quot;false&quot;</dd>
 						<dt>foo:</dt>
 						<dd>boolean true</dd>
 					</dl>