orc-shared 5.8.0-dev.2 → 5.8.0-dev.21

package/src/utils/buildUrl.test.js

@@ -1,6 +1,6 @@
 import sinon from "sinon";
 import { spyOnConsole } from "./testUtils";
-import { loadConfig, resetConfig, buildUrl } from "./buildUrl";
+import { loadConfig, resetConfig, buildUrl, buildExternalAppUrl } from "./buildUrl";
 
 describe("loadConfig", () => {
 	spyOnConsole();
@@ -72,4 +72,30 @@ describe("loadConfig", () => {
 				));
 		});
 	});
+
+	describe("buildExternalAppUrl", () => {
+		it("throws an error if called with an unknown app", () => {
+			expect(
+				() => expect(buildExternalAppUrl, "when called with", ["unknown", "fakeurl"]),
+				"to throw",
+				"Not implemented app 'unknown'",
+			);
+		});
+
+		it("should build an valid relative url with oms", () => {
+			expect(buildExternalAppUrl, "called with", ["oms", "fakeurl"], "to equal", "/oms/app/fakeurl");
+		});
+
+		it("should build an valid relative url with pim", () => {
+			expect(buildExternalAppUrl, "called with", ["pim", "fakeurl"], "to equal", "/pim/app/fakeurl");
+		});
+
+		it("should not be case sensitive about the app name", () => {
+			expect(buildExternalAppUrl, "called with", ["PIM", "fakeurl"], "to equal", "/pim/app/fakeurl");
+		});
+
+		it("should handle delimiter", () => {
+			expect(buildExternalAppUrl, "called with", ["pim", "/fakeurl"], "to equal", "/pim/app/fakeurl");
+		});
+	});
 });

package/src/utils/filterHelper.js

@@ -1,5 +1,6 @@
 import { allValue } from "../constants";
 import { memoize } from "./index";
+import { getNotLocalizedString } from "./localizationHelper";
 
 export const getValueWithAll = value => {
 	if (!value) return allValue;
@@ -20,9 +21,10 @@ export const extractDropboxOptionsMemo = (data, config = undefined) => {
 	let options = [];
 	items.forEach(v => {
 		if (!activeKey || v.get(activeKey)) {
+			const value = v.get(valueKey);
 			options.push({
-				value: v.get(valueKey),
-				label: v.get(labelKey) || (fallbackLabelKey && v.get(fallbackLabelKey)),
+				value: value,
+				label: v.get(labelKey) || (fallbackLabelKey && v.get(fallbackLabelKey)) || getNotLocalizedString(value),
 				sortOrder: v.get(sortOrderKey),
 			});
 		}

package/src/utils/filterHelper.test.js

@@ -43,8 +43,8 @@ describe("extractDropboxOptions", () => {
 		const result = extractDropboxOptions(lookup);
 
 		expect(result, "to equal", [
-			{ value: "value1", label: undefined, sortOrder: 0 },
-			{ value: "value3", label: undefined, sortOrder: 3 },
+			{ value: "value1", label: "[value1]", sortOrder: 0 },
+			{ value: "value3", label: "[value3]", sortOrder: 3 },
 		]);
 	});
 
@@ -60,8 +60,8 @@ describe("extractDropboxOptions", () => {
 		const result = extractDropboxOptions(lookups);
 
 		expect(result, "to equal", [
-			{ value: "value4", label: undefined, sortOrder: 0 },
-			{ value: "value6", label: undefined, sortOrder: 3 },
+			{ value: "value4", label: "[value4]", sortOrder: 0 },
+			{ value: "value6", label: "[value6]", sortOrder: 3 },
 		]);
 	});
 
@@ -77,8 +77,8 @@ describe("extractDropboxOptions", () => {
 		const result = extractDropboxOptions(lookup);
 
 		expect(result, "to equal", [
-			{ value: "value1", label: undefined, sortOrder: 0 },
-			{ value: "value3", label: undefined, sortOrder: 3 },
+			{ value: "value1", label: "[value1]", sortOrder: 0 },
+			{ value: "value3", label: "[value3]", sortOrder: 3 },
 		]);
 	});
 

package/src/utils/inputHelper.js

@@ -0,0 +1,22 @@
+export const trimSpacesAndLeadingZeros = (value, fallback = "") => {
+	if (!value || isNaN(value)) {
+		return fallback;
+	}
+
+	let trimmed = value.trim();
+	const isNegative = trimmed[0] === "-";
+	if (isNegative) {
+		trimmed = trimmed.substring(1, trimmed.length);
+	}
+
+	const withoutLeadingZeros = trimmed.replace(/^0+/, "");
+	if (withoutLeadingZeros == "") {
+		return "0";
+	}
+
+	const cleanNumber = `${isNegative ? "-" : ""}${withoutLeadingZeros}`;
+
+	return limitNumericValueLength(cleanNumber);
+};
+
+export const limitNumericValueLength = (value, maximum = 9) => value.substring(0, maximum);

package/src/utils/inputHelper.test.js

@@ -0,0 +1,47 @@
+import { limitNumericValueLength, trimSpacesAndLeadingZeros } from "./inputHelper";
+
+describe("Numeric Input Helper", () => {
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["  00013 "], "to equal", "13");
+	});
+
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning 0 when 000 value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", [" 000  ", "def"], "to equal", "0");
+	});
+
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning fallback when empty string value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["", "def"], "to equal", "def");
+	});
+
+	it("trimSpacesAndLeadingZeros trims spaces and leading zeros returning 0 when 0 value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", [" 0 ", "def"], "to equal", "0");
+	});
+
+	it("trimSpacesAndLeadingZeros should work on floating values", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["042.2", "def"], "to equal", "42.2");
+	});
+
+	it("trimSpacesAndLeadingZeros should work on negative values", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["-0012.2", "def"], "to equal", "-12.2");
+	});
+
+	it("trimSpacesAndLeadingZeros returns fallback on null value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", [null, "def"], "to equal", "def");
+	});
+
+	it("trimSpacesAndLeadingZeros returns fallback on undefined value", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", [undefined, "def"], "to equal", "def");
+	});
+
+	it("trimSpacesAndLeadingZeros returns fallback when value is not a number", () => {
+		expect(trimSpacesAndLeadingZeros, "when called with", ["hello", "def"], "to equal", "def");
+	});
+
+	it("limitNumericValueLength trims extra characters", () => {
+		expect(limitNumericValueLength, "when called with", ["01234567890"], "to equal", "012345678");
+	});
+
+	it("limitNumericValueLength trims extra characters with another maximum", () => {
+		expect(limitNumericValueLength, "when called with", ["01234567890", 5], "to equal", "01234");
+	});
+});

package/src/utils/normalizeForSearch.js

@@ -6,6 +6,8 @@ if ("".normalize) {
 			.toLowerCase()
 			// Strip accents by normalizing to letters + combining chars, then strip all combining chars.
 			.normalize("NFKD")
+			// Note AD20240801: the new eslint config complains on the next line however I have no idea what it is supposed to do so to be safe I'll disable the warning
+			// eslint-disable-next-line no-misleading-character-class
 			.replace(/[\u0300-\u036f\u1ab0-\u1aff\u1dc0-\u1dff\u20d0-\u20ff\ufe20-\ufe2f]/g, "");
 } else {
 	// IE11 does not support string#normalize(). V. sad for IE users.

package/src/utils/propertyBagHelper.js

@@ -149,7 +149,7 @@ export const getPropertyBagFormattedPrimitiveValue = (propertyBagValue, formatMe
 	}
 
 	if (dataTypesChecker.isBoolean(propertyBagValue[serializationTypeKey])) {
-		return Boolean(propertyBagValue.value)
+		return propertyBagValue.value
 			? formatMessage(sharedMessages.valueTypeWrapperTrue)
 			: formatMessage(sharedMessages.valueTypeWrapperFalse);
 	}
@@ -182,7 +182,7 @@ export const formatNumber = (value, precision) => Number(value).toFixed(precisio
 
 export const fixPropertyBagModifiedModel = (model, ...fields) => {
 	const fixProfileOperations = model => {
-		if (model.hasOwnProperty("profileOperations")) {
+		if (Object.prototype.hasOwnProperty.call(model, "profileOperations")) {
 			let { profilesToAdd, profilesToUpdate } = model.profileOperations;
 			if (profilesToAdd) {
 				const items = Array.isArray(profilesToAdd) ? profilesToAdd : Object.values(profilesToAdd);
@@ -224,7 +224,10 @@ export const fixPropertyBagEmptyValues = propertyBag => {
 	const modifiedFields = Object.keys(propertyBag);
 	modifiedFields.forEach(propertyName => {
 		let property = propertyBag[propertyName];
-		let propertyValue = property && isObject(property) && property.hasOwnProperty("value") ? property.value : property;
+		let propertyValue =
+			property && isObject(property) && Object.prototype.hasOwnProperty.call(property, "value")
+				? property.value
+				: property;
 		if (propertyValue === "") {
 			propertyBag[propertyName] = null;
 		}

package/src/utils/propertyHelper.js

@@ -22,13 +22,13 @@ export function getPropertyOrDefault(obj, property, defaultValue, ignoreCase = f
 	}
 
 	if (ignoreCase === false && startWith === false) {
-		return obj.hasOwnProperty(property) ? obj[property] : defaultValue;
+		return Object.prototype.hasOwnProperty.call(obj, property) ? obj[property] : defaultValue;
 	}
 
 	const compareFunction = startWith ? caseInsensitiveStartWithCompare : caseInsensitiveCompare;
 
 	for (let prop in obj) {
-		if (obj.hasOwnProperty(prop) && compareFunction(prop, property)) {
+		if (Object.prototype.hasOwnProperty.call(obj, prop) && compareFunction(prop, property)) {
 			return obj[prop];
 		}
 	}
@@ -39,12 +39,12 @@ export function getPropertyOrDefault(obj, property, defaultValue, ignoreCase = f
 export const isObjectContainsPropertyWithValue = (obj, propertyName, value) => {
 	if (obj === null || obj === undefined) return false;
 
-	if (obj.hasOwnProperty(propertyName) && obj[propertyName] === value) {
+	if (Object.prototype.hasOwnProperty.call(obj, propertyName) && obj[propertyName] === value) {
 		return true;
 	}
 
 	for (let prop in obj) {
-		if (obj.hasOwnProperty(prop) && typeof obj[prop] === "object") {
+		if (Object.prototype.hasOwnProperty.call(obj, prop) && typeof obj[prop] === "object") {
 			if (isObjectContainsPropertyWithValue(obj[prop], propertyName, value)) return true;
 		}
 	}
@@ -55,12 +55,12 @@ export const isObjectContainsPropertyWithValue = (obj, propertyName, value) => {
 export const isObjectContainsPropertyWithAnyValue = (obj, propertyName) => {
 	if (!obj) return false;
 
-	if (obj.hasOwnProperty(propertyName) && obj[propertyName]) {
+	if (Object.prototype.hasOwnProperty.call(obj, propertyName) && obj[propertyName]) {
 		return true;
 	}
 
 	for (let prop in obj) {
-		if (obj.hasOwnProperty(prop) && typeof obj[prop] === "object") {
+		if (Object.prototype.hasOwnProperty.call(obj, prop) && typeof obj[prop] === "object") {
 			if (isObjectContainsPropertyWithAnyValue(obj[prop], propertyName)) return true;
 		}
 	}

package/src/utils/testUtils.js

@@ -15,6 +15,7 @@ const sinon = require("sinon");
 /* istanbul ignore next */
 export const spyOnConsole = (spyNames = ["log", "warn", "error"]) => {
 	let spiedFuncs;
+	// eslint-disable-next-line no-undef
 	beforeEach(() => {
 		spiedFuncs = spyNames.map(funcName => {
 			const func = sinon.spy().named("console." + funcName);
@@ -23,6 +24,7 @@ export const spyOnConsole = (spyNames = ["log", "warn", "error"]) => {
 			return oldFunc;
 		});
 	});
+	// eslint-disable-next-line no-undef
 	afterEach(() => {
 		spiedFuncs.forEach((func, index) => {
 			const name = spyNames[index];
@@ -74,34 +76,35 @@ export const PropStruct = React.forwardRef((props, ref) => (
 				value === undefined || value === null
 					? null
 					: value === "__ignore"
-					? [<Ignore key={"dt-" + key} />, <Ignore key={"dd-" + key} />]
-					: [
-							<dt key={"dt-" + key}>{`${key}:`}</dt>,
-							<dd key={"dd-" + key}>
-								{key === "children" ? (
-									value
-								) : typeof value === "object" ? (
-									value["$$typeof"] && value["$$typeof"] === Symbol.for("react.element") ? (
-										"React <" + (value.type.name || value.type) + ">"
+						? [<Ignore key={"dt-" + key} />, <Ignore key={"dd-" + key} />]
+						: [
+								<dt key={"dt-" + key}>{`${key}:`}</dt>,
+								<dd key={"dd-" + key}>
+									{key === "children" ? (
+										value
+									) : typeof value === "object" ? (
+										value["$$typeof"] && value["$$typeof"] === Symbol.for("react.element") ? (
+											"React <" + (value.type.name || value.type) + ">"
+										) : (
+											<PropStruct {...value} />
+										)
+									) : typeof value === "function" ? (
+										"Function"
+									) : typeof value === "string" ? (
+										`string "${value}"`
+									) : typeof value === "symbol" ? (
+										`symbol ${value.toString()}`
 									) : (
-										<PropStruct {...value} />
-									)
-								) : typeof value === "function" ? (
-									"Function"
-								) : typeof value === "string" ? (
-									`string "${value}"`
-								) : typeof value === "symbol" ? (
-									`symbol ${value.toString()}`
-								) : (
-									typeof value + " " + value
-								)}
-							</dd>,
-					  ],
+										typeof value + " " + value
+									)}
+								</dd>,
+							],
 			)}
 	</dl>
 ));
 
 export const ignoreConsoleError = func => {
+	// eslint-disable-next-line no-undef
 	jest.spyOn(console, "error");
 	console.error.mockImplementation(() => {});
 

package/src/utils/testUtils.test.js

@@ -187,7 +187,7 @@ describe("PropStruct", () => {
 				<dt>num:</dt>
 				<dd>number 1</dd>
 				<dt>str:</dt>
-				<dd>string "foo"</dd>
+				<dd>string &quot;foo&quot;</dd>
 			</dl>,
 		));
 
@@ -198,7 +198,7 @@ describe("PropStruct", () => {
 			"to satisfy",
 			<dl id="testProps">
 				<dt>id:</dt>
-				<dd>string "testProps"</dd>
+				<dd>string &quot;testProps&quot;</dd>
 			</dl>,
 		));
 
@@ -261,7 +261,7 @@ describe("PropStruct", () => {
 					<div id="tc2" />
 				</dd>
 				<dt>foo:</dt>
-				<dd>string "bar"</dd>
+				<dd>string &quot;bar&quot;</dd>
 			</dl>,
 		));
 
@@ -275,7 +275,7 @@ describe("PropStruct", () => {
 				<dd>
 					<dl>
 						<dt>bar:</dt>
-						<dd>string "false"</dd>
+						<dd>string &quot;false&quot;</dd>
 						<dt>foo:</dt>
 						<dd>boolean true</dd>
 					</dl>