orc-shared 1.5.0-dev.1 → 1.5.0-dev.11

package/dist/utils/urlHelper.js

@@ -2,39 +2,31 @@
 
 exports.__esModule = true;
 exports.tryGetNewEntityIdKey = exports.resolveEntityId = exports.getValueFromUrlByKey = exports.NEW_ENTITY_URL_KEY = void 0;
-
 (function () {
   var enterModule = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.enterModule : undefined;
   enterModule && enterModule(module);
 })();
-
 (function () {
   var enterModule = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.enterModule : undefined;
   enterModule && enterModule(module);
 })();
-
 function _createForOfIteratorHelperLoose(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (it) return (it = it.call(o)).next.bind(it); if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; return function () { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); }
-
 function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
-
-function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }
-
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
 var __signature__ = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default.signature : function (a) {
   return a;
 };
-
 var __signature__ = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default.signature : function (a) {
   return a;
 };
-
 var getValueFromUrlByKey = function getValueFromUrlByKey(url, path, key) {
-  var valuesFromUrl = url.split("/"); // remove the regex of the parameters, the part between parentheses (path to regex syntax)
+  var valuesFromUrl = url.split("/");
 
+  // remove the regex of the parameters, the part between parentheses (path to regex syntax)
   var keysFromPath = path.replace(/(\([^/]+?\))/g, "").split("/");
   var keyIndex = keysFromPath.indexOf(key);
   return valuesFromUrl[keyIndex];
 };
-
 exports.getValueFromUrlByKey = getValueFromUrlByKey;
 var NEW_ENTITY_URL_KEY = "new";
 /* expected url formats for new mode:
@@ -43,13 +35,10 @@ var NEW_ENTITY_URL_KEY = "new";
 	/new{number} => new{number}
 	/new{number}/section => new{number}
 */
-
 exports.NEW_ENTITY_URL_KEY = NEW_ENTITY_URL_KEY;
-
 var tryGetNewEntityIdKey = function tryGetNewEntityIdKey(url) {
   var valuesFromUrl = url.split("/");
   if (valuesFromUrl.length < 2) return;
-
   for (var _iterator = _createForOfIteratorHelperLoose(valuesFromUrl), _step; !(_step = _iterator()).done;) {
     var section = _step.value;
     if (section === NEW_ENTITY_URL_KEY) return section;
@@ -57,55 +46,41 @@ var tryGetNewEntityIdKey = function tryGetNewEntityIdKey(url) {
     if (match) return match[1];
   }
 };
-
 exports.tryGetNewEntityIdKey = tryGetNewEntityIdKey;
-
 var resolveEntityId = function resolveEntityId(url, path, entityIdKey) {
   var newKey = tryGetNewEntityIdKey(url);
   var key = entityIdKey === newKey ? entityIdKey : ":".concat(entityIdKey);
   return getValueFromUrlByKey(url, path, key);
 };
-
 exports.resolveEntityId = resolveEntityId;
 ;
-
 (function () {
   var reactHotLoader = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default : undefined;
-
   if (!reactHotLoader) {
     return;
   }
-
   reactHotLoader.register(getValueFromUrlByKey, "getValueFromUrlByKey", "/home/vsts/work/1/s/src/utils/urlHelper.js");
   reactHotLoader.register(NEW_ENTITY_URL_KEY, "NEW_ENTITY_URL_KEY", "/home/vsts/work/1/s/src/utils/urlHelper.js");
   reactHotLoader.register(tryGetNewEntityIdKey, "tryGetNewEntityIdKey", "/home/vsts/work/1/s/src/utils/urlHelper.js");
   reactHotLoader.register(resolveEntityId, "resolveEntityId", "/home/vsts/work/1/s/src/utils/urlHelper.js");
 })();
-
 ;
-
 (function () {
   var leaveModule = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.leaveModule : undefined;
   leaveModule && leaveModule(module);
 })();
-
 ;
-
 (function () {
   var reactHotLoader = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default : undefined;
-
   if (!reactHotLoader) {
     return;
   }
-
   reactHotLoader.register(getValueFromUrlByKey, "getValueFromUrlByKey", "/home/vsts/work/1/s/src/utils/urlHelper.js");
   reactHotLoader.register(NEW_ENTITY_URL_KEY, "NEW_ENTITY_URL_KEY", "/home/vsts/work/1/s/src/utils/urlHelper.js");
   reactHotLoader.register(tryGetNewEntityIdKey, "tryGetNewEntityIdKey", "/home/vsts/work/1/s/src/utils/urlHelper.js");
   reactHotLoader.register(resolveEntityId, "resolveEntityId", "/home/vsts/work/1/s/src/utils/urlHelper.js");
 })();
-
 ;
-
 (function () {
   var leaveModule = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.leaveModule : undefined;
   leaveModule && leaveModule(module);

package/dist/whyDidYouRerender.js

@@ -1,21 +1,16 @@
 "use strict";
 
 var _react = _interopRequireDefault(require("react"));
-
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-
 var __signature__ = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default.signature : function (a) {
   return a;
 };
-
 var __signature__ = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default.signature : function (a) {
   return a;
 };
-
 // If you want to investigate rerenderer of components, import that file before "react-hot-loader", usually in App.js
 if (process.env.NODE_ENV === "development") {
   var whyDidYouRender = require("@welldone-software/why-did-you-render");
-
   whyDidYouRender(_react.default, {
     trackAllPureComponents: true
   });

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "orc-shared",
-	"version": "1.5.0-dev.1",
+	"version": "1.5.0-dev.11",
 	"description": "Shared code for Orckestra applications",
 	"main": "./src/index.js",
 	"exports": {
@@ -49,7 +49,7 @@
 	],
 	"devDependencies": {},
 	"peerDependencies": {
-		"orc-scripts": "1.5.0-dev.2"
+		"orc-scripts": "1.5.0"
 	},
 	"sideEffects": false,
 	"lint-staged": {
@@ -69,6 +69,6 @@
 		}
 	},
 	"dependencies": {
-		"orc-scripts": "1.5.0-dev.2"
+		"orc-scripts": "1.5.0"
 	}
 }

package/src/actions/tasks.js

@@ -0,0 +1,77 @@
+import { makeActionTypes } from "./makeApiAction";
+import makeOrcApiAction from "./makeOrcApiAction";
+import {
+	deleteTaskInfoRequest,
+	getRequesterTasksInfoRequest,
+	getTaskExecutionLogsRequest,
+	getTaskInfoRequest,
+} from "./requestsApi";
+
+const GET_TASKINFO = "GET_TASKINFO";
+
+export const [GET_TASKINFO_REQUEST, GET_TASKINFO_SUCCESS, GET_TASKINFO_FAILURE] = makeActionTypes(GET_TASKINFO);
+
+export const getTaskInfo = taskId => makeOrcApiAction(GET_TASKINFO, getTaskInfoRequest.buildUrl(taskId));
+
+export const GET_TASK_LIST = "GET_TASK_LIST";
+
+export const ssrsDownloadFilterTaskNames = [
+	"Orckestra.Overture.Providers.CommerceEngine.Profiles.ProfileSchemaExportTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Profiles.ProfileSchemaImportTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Orders.ExportOrderSchemaTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Orders.ImportOrderSchemaTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Products.ImportExport.ExportProductsTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Products.ImportExport.ProductSchemaExportTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Products.ImportExport.ImportProductsTask, Orckestra.Overture.Providers.CommerceEngine",
+	"OrckestraCommerce.DataExchange.Product.Tasks.ProductExportTask, OrckestraCommerce.DataExchange",
+	"Orckestra.Overture.Providers.CommerceEngine.Marketing.ExportCouponCodesTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Marketing.ImportCouponCodesTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Marketing.GenerateCouponTask, Orckestra.Overture.Providers.CommerceEngine",
+	"Orckestra.Overture.Providers.CommerceEngine.Reporting.ReportExportTask, Orckestra.Overture.Providers.CommerceEngine",
+];
+
+export const [GET_TASK_LIST_REQUEST, GET_TASK_LIST_SUCCESS, GET_TASK_LIST_FAILURE] = makeActionTypes(GET_TASK_LIST);
+
+export const getTaskList = (requester, filterTaskNames, lastModified = null, addToActiveRequests = true) =>
+	makeOrcApiAction(
+		GET_TASK_LIST,
+		getRequesterTasksInfoRequest.buildUrl({
+			filterTaskNames: filterTaskNames,
+			requester: requester,
+			lastModified: lastModified,
+		}),
+		getRequesterTasksInfoRequest.verb,
+		{
+			meta: {
+				addToActiveRequests,
+			},
+		},
+	);
+
+const DELETE_TASK = "DELETE_TASK";
+
+export const [DELETE_TASK_REQUEST, DELETE_TASK_SUCCESS, DELETE_TASK_FAILURE] = makeActionTypes(DELETE_TASK);
+
+export const deleteTask = taskId =>
+	makeOrcApiAction(DELETE_TASK, deleteTaskInfoRequest.buildUrl(taskId), deleteTaskInfoRequest.verb, {
+		meta: { taskId },
+	});
+
+const GET_TASK_LOG = "GET_TASK_LOG";
+
+export const [GET_TASK_LOG_REQUEST, GET_TASK_LOG_SUCCESS, GET_TASK_LOG_FAILURE] = makeActionTypes(GET_TASK_LOG);
+
+export const getTaskLog = (taskId, addToActiveRequests = true) =>
+	makeOrcApiAction(GET_TASK_LOG, getTaskExecutionLogsRequest.buildUrl(taskId), getTaskExecutionLogsRequest.verb, {
+		meta: {
+			taskId,
+			addToActiveRequests,
+		},
+	});
+
+export const CLEAR_TASK_LOG = "CLEAR_TASK_LOG";
+
+export const clearTaskLog = taskId => ({
+	type: CLEAR_TASK_LOG,
+	meta: { taskId },
+});

package/src/actions/tasks.test.js

@@ -0,0 +1,169 @@
+import { RSAA } from "redux-api-middleware";
+import {
+	GET_TASKINFO_REQUEST,
+	GET_TASKINFO_SUCCESS,
+	GET_TASKINFO_FAILURE,
+	getTaskInfo,
+	getTaskList,
+	getTaskLog,
+	ssrsDownloadFilterTaskNames,
+	deleteTask,
+} from "./tasks";
+
+jest.mock("../utils/buildUrl", () => {
+	const modExport = {};
+	modExport.loadConfig = () => Promise.resolve({});
+	modExport.buildUrl = (path = [], params = "") => "URL: " + path.join("/") + " " + JSON.stringify(params);
+	return modExport;
+});
+
+describe("getTaskInfo", () => {
+	it("creates a RSAA to get task info", () =>
+		expect(getTaskInfo, "when called with", ["1234"], "to exhaustively satisfy", {
+			[RSAA]: {
+				types: [GET_TASKINFO_REQUEST, GET_TASKINFO_SUCCESS, GET_TASKINFO_FAILURE],
+				endpoint: 'URL: tasks/1234 ""',
+				method: "GET",
+				body: undefined,
+				credentials: "include",
+				bailout: expect.it("to be a function"),
+				headers: {
+					Accept: "application/json; charset=utf-8",
+					"Content-Type": "application/json",
+				},
+				options: { redirect: "follow" },
+			},
+		}));
+});
+
+describe("getTaskLog", () => {
+	it("creates a RSAA to get task info", () =>
+		expect(getTaskLog, "when called with", ["1234"], "to exhaustively satisfy", {
+			[RSAA]: {
+				types: [
+					{ type: "GET_TASK_LOG_REQUEST", meta: { taskId: "1234", addToActiveRequests: true } },
+					{ type: "GET_TASK_LOG_SUCCESS", meta: { taskId: "1234", addToActiveRequests: true } },
+					{ type: "GET_TASK_LOG_FAILURE", meta: { taskId: "1234", addToActiveRequests: true } },
+				],
+				endpoint: 'URL: tasks/1234/logs ""',
+				method: "GET",
+				body: undefined,
+				credentials: "include",
+				bailout: expect.it("to be a function"),
+				headers: {
+					Accept: "application/json; charset=utf-8",
+					"Content-Type": "application/json",
+				},
+				options: { redirect: "follow" },
+			},
+		}));
+
+	it("creates a RSAA to get task info with addToActiveRequests false", () =>
+		expect(getTaskLog, "when called with", ["1234", false], "to exhaustively satisfy", {
+			[RSAA]: {
+				types: [
+					{ type: "GET_TASK_LOG_REQUEST", meta: { taskId: "1234", addToActiveRequests: false } },
+					{ type: "GET_TASK_LOG_SUCCESS", meta: { taskId: "1234", addToActiveRequests: false } },
+					{ type: "GET_TASK_LOG_FAILURE", meta: { taskId: "1234", addToActiveRequests: false } },
+				],
+				endpoint: 'URL: tasks/1234/logs ""',
+				method: "GET",
+				body: undefined,
+				credentials: "include",
+				bailout: expect.it("to be a function"),
+				headers: {
+					Accept: "application/json; charset=utf-8",
+					"Content-Type": "application/json",
+				},
+				options: { redirect: "follow" },
+			},
+		}));
+});
+
+describe("getTaskList", () => {
+	it("creates a RSAA to get task info", () => {
+		const expectedParameters = {
+			filterTaskNames: ssrsDownloadFilterTaskNames,
+			requester: "freddie",
+			lastModified: "date value",
+		};
+
+		expect(
+			getTaskList,
+			"when called with",
+			["freddie", ssrsDownloadFilterTaskNames, "date value", false],
+			"to exhaustively satisfy",
+			{
+				[RSAA]: {
+					types: [
+						{ type: "GET_TASK_LIST_REQUEST", meta: { addToActiveRequests: false } },
+						{ type: "GET_TASK_LIST_SUCCESS", meta: { addToActiveRequests: false } },
+						{ type: "GET_TASK_LIST_FAILURE", meta: { addToActiveRequests: false } },
+					],
+					endpoint: "URL: tasks " + JSON.stringify(expectedParameters),
+					method: "GET",
+					body: undefined,
+					credentials: "include",
+					bailout: expect.it("to be a function"),
+					headers: {
+						Accept: "application/json; charset=utf-8",
+						"Content-Type": "application/json",
+					},
+					options: { redirect: "follow" },
+				},
+			},
+		);
+	});
+
+	it("creates a RSAA to get task info with null lastModified and true addToActiveRequests", () => {
+		const expectedParameters = {
+			filterTaskNames: ssrsDownloadFilterTaskNames,
+			requester: "freddie",
+			lastModified: null,
+		};
+
+		expect(getTaskList, "when called with", ["freddie", ssrsDownloadFilterTaskNames], "to exhaustively satisfy", {
+			[RSAA]: {
+				types: [
+					{ type: "GET_TASK_LIST_REQUEST", meta: { addToActiveRequests: true } },
+					{ type: "GET_TASK_LIST_SUCCESS", meta: { addToActiveRequests: true } },
+					{ type: "GET_TASK_LIST_FAILURE", meta: { addToActiveRequests: true } },
+				],
+				endpoint: "URL: tasks " + JSON.stringify(expectedParameters),
+				method: "GET",
+				body: undefined,
+				credentials: "include",
+				bailout: expect.it("to be a function"),
+				headers: {
+					Accept: "application/json; charset=utf-8",
+					"Content-Type": "application/json",
+				},
+				options: { redirect: "follow" },
+			},
+		});
+	});
+});
+
+describe("deleteTask", () => {
+	it("creates a RSAA to delete a task", () => {
+		expect(deleteTask, "when called with", ["1234"], "to exhaustively satisfy", {
+			[RSAA]: {
+				types: [
+					{ type: "DELETE_TASK_REQUEST", meta: { taskId: "1234" } },
+					{ type: "DELETE_TASK_SUCCESS", meta: { taskId: "1234" } },
+					{ type: "DELETE_TASK_FAILURE", meta: { taskId: "1234" } },
+				],
+				endpoint: 'URL: tasks/1234 ""',
+				method: "DELETE",
+				body: undefined,
+				credentials: "include",
+				bailout: expect.it("to be a function"),
+				headers: {
+					Accept: "application/json; charset=utf-8",
+					"Content-Type": "application/json",
+				},
+				options: { redirect: "follow" },
+			},
+		});
+	});
+});

package/src/buildStore.js

@@ -20,6 +20,7 @@ import timezonesReducer from "./reducers/timezones";
 import modulesReducer from "./reducers/modules";
 import metadataReducer from "./reducers/metadata";
 import requestStatesReducer from "./reducers/requestStates";
+import tasksReducer from "./reducers/tasks";
 
 window.BUILD_ID = BUILD_ID;
 window.BUILD_NUMBER = BUILD_NUMBER;
@@ -65,6 +66,7 @@ const buildStore = (reducers, devOptions = {}) => {
 			modules: modulesReducer,
 			metadata: metadataReducer,
 			requestStates: requestStatesReducer,
+			tasks: tasksReducer,
 		});
 	const rootReducer = buildReducer(reducers);
 

package/src/components/AppFrame/About.test.js

@@ -79,7 +79,7 @@ describe("About", () => {
 						</AboutLink>
 					</AboutParagraph>
 					<AboutParagraph>
-						{stringifyWithoutQuotes(messages["orc-shared.copyright"])}
+						{stringifyWithoutQuotes(messages["orc-shared.copyright"]).replace("{year}", new Date().getFullYear())}
 						<br />
 						{stringifyWithoutQuotes(messages["orc-shared.allRightsReserved"])}
 					</AboutParagraph>
@@ -130,7 +130,7 @@ describe("About", () => {
 						</AboutLink>
 					</AboutParagraph>
 					<AboutParagraph>
-						{stringifyWithoutQuotes(messages["orc-shared.copyright"])}
+						{stringifyWithoutQuotes(messages["orc-shared.copyright"]).replace("{year}", new Date().getFullYear())}
 						<br />
 						{stringifyWithoutQuotes(messages["orc-shared.allRightsReserved"])}
 					</AboutParagraph>
@@ -165,7 +165,7 @@ describe("About", () => {
 						</AboutLink>
 					</AboutParagraph>
 					<AboutParagraph>
-						{stringifyWithoutQuotes(messages["orc-shared.copyright"])}
+						{stringifyWithoutQuotes(messages["orc-shared.copyright"]).replace("{year}", new Date().getFullYear())}
 						<br />
 						{stringifyWithoutQuotes(messages["orc-shared.allRightsReserved"])}
 					</AboutParagraph>

package/src/components/AppFrame/Sidebar.js

@@ -60,9 +60,10 @@ const LogoSvg = styled.svg`
 `;
 
 export const Logo = () => (
-	<LogoSvg viewBox="0 0 260 260">
-		<path d="M1.11,125.62C1.11,74.94,40.22,39,93.72,39S186,74.94,186,125.62s-38.79,86.66-92.29,86.66S1.11,176.3,1.11,125.62Zm135.47,0c0-29.1-18.46-46.62-42.86-46.62S50.54,96.52,50.54,125.62s18.77,46.62,43.18,46.62S136.58,154.72,136.58,125.62Z" />
-		<circle cx="227.6" cy="181.13" r="31.29" />
+	<LogoSvg viewBox="0 0 354 354">
+		<g>
+			<path d="M0 241.41c0-65.49 50.53-111.98 119.66-111.98s119.25 46.49 119.25 111.98c0 65.49-50.13 111.97-119.25 111.97S0 306.9 0 241.41Zm175.04 0c0-37.6-23.85-60.23-55.38-60.23s-55.79 22.64-55.79 60.23c0 37.59 24.26 60.23 55.79 60.23 31.53 0 55.38-22.64 55.38-60.23Zm178.1-76.35h-77.48c0-48.29-39.29-87.58-87.58-87.58V0c91.02 0 165.07 74.05 165.07 165.06h-.01Z" />
+		</g>
 	</LogoSvg>
 );
 

package/src/components/Routing/SubPage.js

@@ -78,9 +78,24 @@ export const SubPage = ({ config, match, location, history, root, modulePrependP
 						variant={action.isPrimary ? "contained" : "outlined"}
 						color={action.isPrimary ? "primary" : "default"}
 						disableElevation={action.isPrimary}
+						disabled={action.disabled}
 						onClick={e => {
-							action.handler && action.handler(e);
-							closeSubPage();
+							if (!action.handler) {
+								closeSubPage();
+								return;
+							}
+
+							let actionHandlerResult = action.handler(e);
+							if (typeof actionHandlerResult === "object") {
+								// promise
+								actionHandlerResult.then(actionResult => {
+									if (action.validateBeforeClose && !actionResult) return;
+									closeSubPage();
+								});
+							} else {
+								if (action.validateBeforeClose && !actionHandlerResult) return;
+								closeSubPage();
+							}
 						}}
 					>
 						<FormattedMessage {...action.label} />

package/src/components/Routing/SubPage.test.js

@@ -180,7 +180,6 @@ describe("SubPage", () => {
 		expect(history.push, "to have calls satisfying", [{ args: ["/foo"] }]);
 		expect(dispatch, "to have calls satisfying", [{ args: [mapHref("/foo", "/foo")] }]);
 	});
-
 	it("renders action panel passed from props", () => {
 		const actions = () => [{ label: sharedMessages.cancel }, { label: sharedMessages.applyChanges }];
 
@@ -262,4 +261,172 @@ describe("SubPage", () => {
 		expect(applyButtonClassName, "to contain", "MuiButton-containedPrimary");
 		expect(someEvent, "was called");
 	});
+
+	it("Do not close when clicking action button has validateBeforeClose and result is false", () => {
+		const applyHandler = () => false;
+
+		const actions = () => [
+			{ label: sharedMessages.applyChanges, isPrimary: true, handler: applyHandler, validateBeforeClose: true },
+		];
+
+		const component = (
+			<TestWrapper provider={{ store }} intlProvider={intlProvider} stylesProvider muiThemeProvider={{ theme }}>
+				<div>
+					<div id="outer" />
+					<Router history={history}>
+						<Route
+							path="/foo/bar"
+							render={route => (
+								<SubPage
+									config={{
+										component: InnerView,
+										set: true,
+										title: "Item Details",
+										componentProps: { actionPanel: actions },
+									}}
+									root="/foo"
+									path="/foo/bar"
+									{...route}
+								/>
+							)}
+						/>
+					</Router>
+				</div>
+			</TestWrapper>
+		);
+		const mountedComponent = mount(component);
+
+		const applyButton = mountedComponent.find("button").at(0);
+
+		applyButton.invoke("onClick")();
+		expect(history.push, "not to have calls satisfying", [{ args: ["/foo"] }]);
+		expect(dispatch, "not to have calls satisfying", [{ args: [mapHref("/foo", "/foo")] }]);
+	});
+
+	it("Close when clicking action button has validateBeforeClose and result is true", () => {
+		const applyHandler = () => true;
+
+		const actions = () => [
+			{ label: sharedMessages.applyChanges, isPrimary: true, handler: applyHandler, validateBeforeClose: true },
+		];
+
+		const component = (
+			<TestWrapper provider={{ store }} intlProvider={intlProvider} stylesProvider muiThemeProvider={{ theme }}>
+				<div>
+					<div id="outer" />
+					<Router history={history}>
+						<Route
+							path="/foo/bar"
+							render={route => (
+								<SubPage
+									config={{
+										component: InnerView,
+										set: true,
+										title: "Item Details",
+										componentProps: { actionPanel: actions },
+									}}
+									root="/foo"
+									path="/foo/bar"
+									{...route}
+								/>
+							)}
+						/>
+					</Router>
+				</div>
+			</TestWrapper>
+		);
+		const mountedComponent = mount(component);
+
+		const applyButton = mountedComponent.find("button").at(0);
+
+		applyButton.invoke("onClick")();
+		expect(history.push, "to have calls satisfying", [{ args: ["/foo"] }]);
+		expect(dispatch, "to have calls satisfying", [{ args: [mapHref("/foo", "/foo")] }]);
+	});
+
+	it("Close when clicking action button has validateBeforeClose and result as promise with true", () => {
+		const applyHandler = () => Promise.resolve(true);
+
+		const actions = () => [
+			{ label: sharedMessages.applyChanges, isPrimary: true, handler: applyHandler, validateBeforeClose: true },
+		];
+
+		const component = (
+			<TestWrapper provider={{ store }} intlProvider={intlProvider} stylesProvider muiThemeProvider={{ theme }}>
+				<div>
+					<div id="outer" />
+					<Router history={history}>
+						<Route
+							path="/foo/bar"
+							render={route => (
+								<SubPage
+									config={{
+										component: InnerView,
+										set: true,
+										title: "Item Details",
+										componentProps: { actionPanel: actions },
+									}}
+									root="/foo"
+									path="/foo/bar"
+									{...route}
+								/>
+							)}
+						/>
+					</Router>
+				</div>
+			</TestWrapper>
+		);
+		const mountedComponent = mount(component);
+
+		const applyButton = mountedComponent.find("button").at(0);
+
+		applyButton.invoke("onClick")();
+		setTimeout(() => {
+			expect(history.push, "to have calls satisfying", [{ args: ["/foo"] }]);
+			expect(dispatch, "to have calls satisfying", [{ args: [mapHref("/foo", "/foo")] }]);
+		}, 200);
+	});
+
+	it("Do not Close when clicking action button has validateBeforeClose and result as promise with false", () => {
+		const applyHandler = () => Promise.resolve(false);
+
+		const actions = () => [
+			{ label: sharedMessages.applyChanges, isPrimary: true, handler: applyHandler, validateBeforeClose: true },
+		];
+
+		const component = (
+			<TestWrapper provider={{ store }} intlProvider={intlProvider} stylesProvider muiThemeProvider={{ theme }}>
+				<div>
+					<div id="outer" />
+					<Router history={history}>
+						<Route
+							path="/foo/bar"
+							render={route => (
+								<SubPage
+									config={{
+										component: InnerView,
+										set: true,
+										title: "Item Details",
+										componentProps: { actionPanel: actions },
+									}}
+									root="/foo"
+									path="/foo/bar"
+									{...route}
+								/>
+							)}
+						/>
+					</Router>
+				</div>
+			</TestWrapper>
+		);
+		const mountedComponent = mount(component);
+
+		const applyButton = mountedComponent.find("button").at(0);
+
+		applyButton.invoke("onClick")();
+		setTimeout(() => {
+			expect(history.push, "not to have calls satisfying", [{ args: ["/foo"] }]);
+			expect(dispatch, "not to have calls satisfying", [{ args: [mapHref("/foo", "/foo")] }]);
+		}, 200);
+	});
 });