orator-static-server 2.0.0 → 2.0.3

package/CONTRIBUTING.md

@@ -0,0 +1,50 @@
+# Contributing to Retold
+
+We welcome contributions to Retold and its modules. This guide covers the expectations and process for contributing.
+
+## Code of Conduct
+
+The Retold community values **empathy**, **equity**, **kindness**, and **thoughtfulness**. We expect all participants to treat each other with respect, assume good intent, and engage constructively. These values apply to all interactions: pull requests, issues, discussions, and code review.
+
+## How to Contribute
+
+### Pull Requests
+
+Pull requests are the preferred method for contributing changes. To submit one:
+
+1. Fork the module repository you want to change
+2. Create a branch for your work
+3. Make your changes, following the code style of the module you are editing
+4. Ensure your changes have test coverage (see below)
+5. Open a pull request against the module's main branch
+
+**Submitting a pull request does not guarantee it will be accepted.** Maintainers review contributions for fit, quality, and alignment with the project's direction. A PR may be declined, or you may be asked to revise it. This is normal and not a reflection on the quality of your effort.
+
+### Reporting Issues
+
+If you find a bug or have a feature suggestion, open an issue on the relevant module's repository. Include enough detail to reproduce the problem or understand the proposal.
+
+## Test Coverage
+
+Every commit must include test coverage for the changes it introduces. Retold modules use Mocha in TDD style. Before submitting:
+
+- **Write tests** for any new functionality or bug fixes
+- **Run the existing test suite** with `npm test` and confirm all tests pass
+- **Check coverage** with `npm run coverage` if the module supports it
+
+Pull requests that break existing tests or lack coverage for new code will not be merged.
+
+## Code Style
+
+Follow the conventions of the module you are working in. The general Retold style is:
+
+- **Tabs** for indentation, never spaces
+- **Plain JavaScript** only (no TypeScript)
+- **Allman-style braces** (opening brace on its own line)
+- **Variable naming:** `pVariable` for parameters, `tmpVariable` for temporaries, `libSomething` for imports
+
+When in doubt, match what the surrounding code does.
+
+## Repository Structure
+
+Each module is its own git repository. The [retold](https://github.com/stevenvelozo/retold) repository tracks module organization but does not contain module source code. Direct your pull request to the specific module repository where your change belongs.

package/README.md

@@ -99,6 +99,14 @@ npx docsify-cli serve docs
 
 ## Related Packages
 
-- [orator](https://github.com/stevenvelozo/orator) - Main Orator service (includes addStaticRoute)
-- [orator-serviceserver-restify](https://github.com/stevenvelozo/orator-serviceserver-restify) - Restify service server
-- [fable](https://github.com/stevenvelozo/fable) - Service provider framework
+- [orator](https://github.com/stevenvelozo/orator) - API server abstraction
+- [orator-serviceserver-restify](https://github.com/stevenvelozo/orator-serviceserver-restify) - Restify service server implementation
+- [fable](https://github.com/stevenvelozo/fable) - Application services framework
+
+## License
+
+MIT
+
+## Contributing
+
+Pull requests are welcome. For details on our code of conduct, contribution process, and testing requirements, see the [Retold Contributing Guide](https://github.com/stevenvelozo/retold/blob/main/docs/contributing.md).

package/docs/css/docuserve.css

@@ -0,0 +1,73 @@
+/* ============================================================================
+   Pict Docuserve - Base Styles
+   ============================================================================ */
+
+/* Reset and base */
+*, *::before, *::after {
+	box-sizing: border-box;
+}
+
+html, body {
+	margin: 0;
+	padding: 0;
+	font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif;
+	font-size: 16px;
+	line-height: 1.5;
+	color: #423D37;
+	background-color: #fff;
+	-webkit-font-smoothing: antialiased;
+	-moz-osx-font-smoothing: grayscale;
+}
+
+/* Typography */
+h1, h2, h3, h4, h5, h6 {
+	margin-top: 0;
+	line-height: 1.3;
+}
+
+a {
+	color: #2E7D74;
+	text-decoration: none;
+}
+
+a:hover {
+	color: #256861;
+}
+
+/* Application container */
+#Docuserve-Application-Container {
+	min-height: 100vh;
+}
+
+/* Utility: scrollbar styling */
+::-webkit-scrollbar {
+	width: 8px;
+}
+
+::-webkit-scrollbar-track {
+	background: #F5F0E8;
+}
+
+::-webkit-scrollbar-thumb {
+	background: #D4CCBE;
+	border-radius: 4px;
+}
+
+::-webkit-scrollbar-thumb:hover {
+	background: #B5AA9A;
+}
+
+/* Responsive adjustments */
+@media (max-width: 768px) {
+	html {
+		font-size: 14px;
+	}
+
+	#Docuserve-Sidebar-Container {
+		display: none;
+	}
+
+	.docuserve-body {
+		flex-direction: column;
+	}
+}

package/docs/index.html

@@ -9,7 +9,7 @@
 		<title>Documentation</title>
 
 		<!-- Application Stylesheet -->
-		<link href="https://cdn.jsdelivr.net/npm/pict-docuserve@0/dist/css/docuserve.css" rel="stylesheet">
+		<link href="css/docuserve.css" rel="stylesheet">
 		<!-- KaTeX stylesheet for LaTeX equation rendering -->
 		<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/katex@0.16.21/dist/katex.min.css">
 		<!-- PICT Dynamic View CSS Container -->

package/docs/retold-catalog.json

@@ -0,0 +1,41 @@
+{
+	"Generated": "2026-02-18T03:41:38.903Z",
+	"GitHubOrg": "stevenvelozo",
+	"DefaultBranch": "master",
+	"Groups": [
+		{
+			"Name": "Dist",
+			"Key": "dist",
+			"Description": "",
+			"Modules": [
+				{
+					"Name": "indoctrinate_content_staging",
+					"Repo": "indoctrinate_content_staging",
+					"Group": "dist",
+					"Branch": "master",
+					"HasDocs": false,
+					"HasCover": false,
+					"Sidebar": [],
+					"DocFiles": []
+				}
+			]
+		},
+		{
+			"Name": "Test",
+			"Key": "test",
+			"Description": "",
+			"Modules": [
+				{
+					"Name": "static_content",
+					"Repo": "static_content",
+					"Group": "test",
+					"Branch": "master",
+					"HasDocs": false,
+					"HasCover": false,
+					"Sidebar": [],
+					"DocFiles": []
+				}
+			]
+		}
+	]
+}

package/docs/retold-keyword-index.json

@@ -0,0 +1,19 @@
+{
+	"Generated": "2026-02-18T03:41:38.985Z",
+	"DocumentCount": 0,
+	"LunrIndex": {
+		"version": "2.3.9",
+		"fields": [
+			"title",
+			"module",
+			"group",
+			"body"
+		],
+		"fieldVectors": [],
+		"invertedIndex": [],
+		"pipeline": [
+			"stemmer"
+		]
+	},
+	"Documents": {}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "orator-static-server",
-    "version": "2.0.0",
+    "version": "2.0.3",
     "description": "Static file serving for Orator API servers.",
     "main": "source/Orator-Static-Server.js",
     "scripts": {
@@ -38,17 +38,17 @@
     },
     "homepage": "https://github.com/stevenvelozo/orator-static-server#readme",
     "dependencies": {
-        "fable-serviceproviderbase": "^3.0.15",
+        "fable-serviceproviderbase": "^3.0.18",
         "finalhandler": "^1.3.1",
         "mime": "^3.0.0",
         "serve-static": "^1.16.2"
     },
     "devDependencies": {
         "chai": "^4.3.7",
-        "fable": "^3.1.51",
+        "fable": "^3.1.57",
         "mocha": "^10.2.0",
-        "orator": "^5.0.1",
-        "orator-serviceserver-restify": "^2.0.5",
-        "quackage": "^1.0.45"
+        "orator": "^6.0.1",
+        "orator-serviceserver-restify": "^2.0.7",
+        "quackage": "^1.0.51"
     }
 }

package/source/Orator-Static-Server.js

@@ -161,15 +161,12 @@ class OratorStaticServer extends libFableServiceProviderBase
 							return pRequest.url;
 					};
 
-					// When the URL is a directory (e.g. '/' or '/docs/'), use the default file for MIME detection
-					// so the browser gets text/html instead of application/octet-stream
-					let tmpMimeTarget = pRequest.url;
-					if (tmpMimeTarget.endsWith('/') || tmpMimeTarget.indexOf('.') < 0)
-					{
-						tmpMimeTarget = tmpDefaultFile;
-					}
-					this.setMimeHeader(tmpMimeTarget, pResponse);
-
+					// Let serve-static handle Content-Type detection.  It resolves
+					// the actual file path first (e.g. / → /index.html) and then
+					// sets the correct MIME type with charset.  Pre-setting the
+					// header here would prevent serve-static from overriding it
+					// because the underlying `send` library skips Content-Type
+					// when the header is already present.
 					const tmpServe = libServeStatic(servePath, Object.assign({ index: tmpDefaultFile }, pParams));
 					tmpServe(pRequest, pResponse, libFinalHandler(pRequest, pResponse));
 					// TODO: This may break things if a post request send handler is setup...

package/test/Orator-Static-Server_tests.js

@@ -1308,6 +1308,175 @@ suite
 			}
 		);
 
+		suite
+		(
+			'MIME Type Resolution by serve-static',
+			() =>
+			{
+				test
+				(
+					'serve-static should set content-type with charset for HTML files',
+					(fDone) =>
+					{
+						let tmpPort = getNextTestPort();
+						let tmpHarness = createHarness(tmpPort);
+
+						startHarness(tmpHarness,
+							(pError) =>
+							{
+								tmpHarness.orator.addStaticRoute(_StaticContentPath, 'index.html', '/mime/*', '/mime/');
+
+								makeRequest(tmpPort, '/mime/index.html',
+									(pError, pStatusCode, pHeaders, pBody) =>
+									{
+										Expect(pError).to.equal(null);
+										Expect(pStatusCode).to.equal(200);
+										// serve-static sets charset on text types; a manual setMimeHeader would not
+										Expect(pHeaders['content-type']).to.equal('text/html; charset=UTF-8');
+										tmpHarness.orator.log.info(`HTML content-type with charset: ${pHeaders['content-type']}`);
+										tmpHarness.orator.stopService(
+											() =>
+											{
+												return fDone();
+											});
+									});
+							});
+					}
+				);
+
+				test
+				(
+					'serve-static should set content-type with charset for CSS files',
+					(fDone) =>
+					{
+						let tmpPort = getNextTestPort();
+						let tmpHarness = createHarness(tmpPort);
+
+						startHarness(tmpHarness,
+							(pError) =>
+							{
+								tmpHarness.orator.addStaticRoute(_StaticContentPath, 'index.html', '/mimecss/*', '/mimecss/');
+
+								makeRequest(tmpPort, '/mimecss/style.css',
+									(pError, pStatusCode, pHeaders, pBody) =>
+									{
+										Expect(pError).to.equal(null);
+										Expect(pStatusCode).to.equal(200);
+										// serve-static adds charset for text/* types
+										Expect(pHeaders['content-type']).to.equal('text/css; charset=UTF-8');
+										tmpHarness.orator.log.info(`CSS content-type with charset: ${pHeaders['content-type']}`);
+										tmpHarness.orator.stopService(
+											() =>
+											{
+												return fDone();
+											});
+									});
+							});
+					}
+				);
+
+				test
+				(
+					'directory request to / should get text/html from serve-static not application/octet-stream',
+					(fDone) =>
+					{
+						let tmpPort = getNextTestPort();
+						let tmpHarness = createHarness(tmpPort);
+
+						startHarness(tmpHarness,
+							(pError) =>
+							{
+								tmpHarness.orator.addStaticRoute(_StaticContentPath, 'index.html', '/*', '/');
+
+								makeRequest(tmpPort, '/',
+									(pError, pStatusCode, pHeaders, pBody) =>
+									{
+										Expect(pError).to.equal(null);
+										Expect(pStatusCode).to.equal(200);
+										// The core bug: mime.getType('/') returns null, falling back to
+										// application/octet-stream. serve-static resolves / to /index.html
+										// and correctly determines text/html with charset.
+										Expect(pHeaders['content-type']).to.equal('text/html; charset=UTF-8');
+										Expect(pHeaders['content-type']).to.not.contain('octet-stream');
+										Expect(pBody).to.contain('Test Index');
+										tmpHarness.orator.log.info(`Root / content-type: ${pHeaders['content-type']}`);
+										tmpHarness.orator.stopService(
+											() =>
+											{
+												return fDone();
+											});
+									});
+							});
+					}
+				);
+
+				test
+				(
+					'directory request to /subdir/ should get text/html from serve-static',
+					(fDone) =>
+					{
+						let tmpPort = getNextTestPort();
+						let tmpHarness = createHarness(tmpPort);
+
+						startHarness(tmpHarness,
+							(pError) =>
+							{
+								tmpHarness.orator.addStaticRoute(_StaticContentPath, 'index.html', '/app/*', '/app/');
+
+								makeRequest(tmpPort, '/app/subsite/',
+									(pError, pStatusCode, pHeaders, pBody) =>
+									{
+										Expect(pError).to.equal(null);
+										Expect(pStatusCode).to.equal(200);
+										// serve-static resolves /subsite/ to /subsite/index.html
+										Expect(pHeaders['content-type']).to.equal('text/html; charset=UTF-8');
+										Expect(pBody).to.contain('Subsite');
+										tmpHarness.orator.log.info(`Subdir / content-type: ${pHeaders['content-type']}`);
+										tmpHarness.orator.stopService(
+											() =>
+											{
+												return fDone();
+											});
+									});
+							});
+					}
+				);
+
+				test
+				(
+					'JSON file should get application/json content-type from serve-static',
+					(fDone) =>
+					{
+						let tmpPort = getNextTestPort();
+						let tmpHarness = createHarness(tmpPort);
+
+						startHarness(tmpHarness,
+							(pError) =>
+							{
+								tmpHarness.orator.addStaticRoute(_StaticContentPath, 'index.html', '/mj/*', '/mj/');
+
+								makeRequest(tmpPort, '/mj/data.json',
+									(pError, pStatusCode, pHeaders, pBody) =>
+									{
+										Expect(pError).to.equal(null);
+										Expect(pStatusCode).to.equal(200);
+										// JSON should not have charset added by serve-static
+										Expect(pHeaders['content-type']).to.contain('application/json');
+										let tmpParsed = JSON.parse(pBody);
+										Expect(tmpParsed.TestKey).to.equal('TestValue');
+										tmpHarness.orator.log.info(`JSON content-type: ${pHeaders['content-type']}`);
+										tmpHarness.orator.stopService(
+											() =>
+											{
+												return fDone();
+											});
+									});
+							});
+					}
+				);
+			}
+		);
+
 		suite
 		(
 			'addStaticRoute Parameter Defaults',