orange-orm 4.7.7 → 4.7.8

package/dist/index.mjs

@@ -18269,7 +18269,9 @@ function requireWrapQuery$1 () {
 		}
 
 		function doQuery(query, onCompleted) {
-			const result = [];
+			const results = []; // Array to hold multiple result sets
+			let currentResult = []; // Current result set being built
+			let hasResultSet = false; // Track if we're in an actual result set
 
 			log.emitQuery({ sql: query.sql(), parameters: query.parameters });
 			const sql = replaceParamChar(query.sql(), query.parameters);
@@ -18297,7 +18299,6 @@ function requireWrapQuery$1 () {
 			}
 
 			let keys;
-			// Now we can safely create Request using CachedRequest
 			var request = new CachedRequest(sql, onInnerCompleted);
 			addParameters(request, query.parameters, CachedTypes);
 
@@ -18309,7 +18310,35 @@ function requireWrapQuery$1 () {
 				keys.forEach(cols => {
 					tmp[cols] = rows[cols].value;
 				});
-				result.push(tmp);
+				currentResult.push(tmp);
+				hasResultSet = true; // We're definitely in a result set
+			});
+
+			// Handle column metadata - indicates a result set is starting
+			request.on('columnMetadata', (_columns) => {
+				hasResultSet = true; // A result set is starting (even if it ends up empty)
+			});
+
+			// Handle end of each result set
+			request.on('doneInProc', (_rowCount, _more) => {
+				// End of a result set within a stored procedure
+				// Add to results if we had a result set (even if empty)
+				if (hasResultSet) {
+					results.push(currentResult);
+					currentResult = [];
+					keys = null; // Reset keys for next result set
+					hasResultSet = false; // Reset for next potential result set
+				}
+			});
+
+			request.on('doneProc', (_rowCount, _more) => {
+				// End of stored procedure execution
+				// Add to results if we had a result set (even if empty)
+				if (hasResultSet) {
+					results.push(currentResult);
+					currentResult = [];
+					hasResultSet = false; // Reset for next potential result set
+				}
 			});
 
 			connection.execSql(request);
@@ -18318,14 +18347,28 @@ function requireWrapQuery$1 () {
 				if (err) {
 					onCompleted(extractError(err));
 				} else {
-					onCompleted(null, result);
+					// If we have any remaining result set, add it
+					if (hasResultSet) {
+						results.push(currentResult);
+					}
+
+					// Return based on number of actual result sets
+					if (results.length === 0) {
+						// No result sets - return empty array
+						onCompleted(null, []);
+					} else if (results.length === 1) {
+						// Single result set - return as single-depth array (even if empty)
+						onCompleted(null, results[0]);
+					} else {
+						// Multiple result sets - return as array of arrays
+						onCompleted(null, results);
+					}
 				}
 			}
 		}
 	}
 
-	// same helpers as before
-
+	// Helper functions remain the same
 	function extractError(e) {
 		if (e && e.errors) {
 			return e.errors[0];

package/docs/changelog.md

@@ -1,4 +1,6 @@
 ## Changelog
+__4.7.8__  
+Bugfix: Support for multiple result sets from stored procedures in MsSql. See [#130](https://github.com/alfateam/issues/130)  
 __4.7.7__  
 Always do logging with question mark as placeholder instead of dialect specific placeholder.  
 __4.7.6__  

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "orange-orm",
-  "version": "4.7.7",
+  "version": "4.7.8",
   "main": "./src/index.js",
   "module": "./dist/index.mjs",
   "browser": "./dist/index.browser.mjs",

package/src/tedious/wrapQuery.js

@@ -22,7 +22,9 @@ function wrapQuery(_context, connection) {
 	}
 
 	function doQuery(query, onCompleted) {
-		const result = [];
+		const results = []; // Array to hold multiple result sets
+		let currentResult = []; // Current result set being built
+		let hasResultSet = false; // Track if we're in an actual result set
 
 		log.emitQuery({ sql: query.sql(), parameters: query.parameters });
 		const sql = replaceParamChar(query.sql(), query.parameters);
@@ -50,7 +52,6 @@ function wrapQuery(_context, connection) {
 		}
 
 		let keys;
-		// Now we can safely create Request using CachedRequest
 		var request = new CachedRequest(sql, onInnerCompleted);
 		addParameters(request, query.parameters, CachedTypes);
 
@@ -62,7 +63,35 @@ function wrapQuery(_context, connection) {
 			keys.forEach(cols => {
 				tmp[cols] = rows[cols].value;
 			});
-			result.push(tmp);
+			currentResult.push(tmp);
+			hasResultSet = true; // We're definitely in a result set
+		});
+
+		// Handle column metadata - indicates a result set is starting
+		request.on('columnMetadata', (_columns) => {
+			hasResultSet = true; // A result set is starting (even if it ends up empty)
+		});
+
+		// Handle end of each result set
+		request.on('doneInProc', (_rowCount, _more) => {
+			// End of a result set within a stored procedure
+			// Add to results if we had a result set (even if empty)
+			if (hasResultSet) {
+				results.push(currentResult);
+				currentResult = [];
+				keys = null; // Reset keys for next result set
+				hasResultSet = false; // Reset for next potential result set
+			}
+		});
+
+		request.on('doneProc', (_rowCount, _more) => {
+			// End of stored procedure execution
+			// Add to results if we had a result set (even if empty)
+			if (hasResultSet) {
+				results.push(currentResult);
+				currentResult = [];
+				hasResultSet = false; // Reset for next potential result set
+			}
 		});
 
 		connection.execSql(request);
@@ -71,14 +100,28 @@ function wrapQuery(_context, connection) {
 			if (err) {
 				onCompleted(extractError(err));
 			} else {
-				onCompleted(null, result);
+				// If we have any remaining result set, add it
+				if (hasResultSet) {
+					results.push(currentResult);
+				}
+
+				// Return based on number of actual result sets
+				if (results.length === 0) {
+					// No result sets - return empty array
+					onCompleted(null, []);
+				} else if (results.length === 1) {
+					// Single result set - return as single-depth array (even if empty)
+					onCompleted(null, results[0]);
+				} else {
+					// Multiple result sets - return as array of arrays
+					onCompleted(null, results);
+				}
 			}
 		}
 	}
 }
 
-// same helpers as before
-
+// Helper functions remain the same
 function extractError(e) {
 	if (e && e.errors) {
 		return e.errors[0];
@@ -130,4 +173,4 @@ function addParameters(request, params, TYPES) {
 	}
 }
 
-module.exports = wrapQuery;
+module.exports = wrapQuery;