oracledb 6.5.0 → 6.6.0

package/README.md

@@ -1,10 +1,10 @@
-# node-oracledb version 6.5.0
+# node-oracledb version 6.6.0
 
 The node-oracledb add-on for Node.js powers high performance Oracle Database
 applications.  Applications can be written in TypeScript, or directly in
 JavaScript.
 
-Use node-oracledb 6.5.0 to connect Node.js 14.6, or later, to Oracle
+Use node-oracledb 6.6.0 to connect Node.js 14.6, or later, to Oracle
 Database.  Older versions of node-oracledb may work with older versions of
 Node.js.
 

package/build/Release/oracledb-6.6.0-darwin-arm64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.6.0-darwin-arm64.node v22.2.0 6e81601d4d09137e859660fbbe090e1b272adbb2 5f182c720d6541c3b267d5d370f606f90b5b0c38 Wed, 17 Jul 2024 06:45:24 GMT

package/build/Release/oracledb-6.6.0-darwin-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.6.0-darwin-x64.node v20.11.1 6e81601d4d09137e859660fbbe090e1b272adbb2 5f182c720d6541c3b267d5d370f606f90b5b0c38 Wed, 17 Jul 2024 04:43:48 GMT

package/build/Release/oracledb-6.6.0-js-buildinfo.txt

@@ -0,0 +1 @@
+6e81601d4d09137e859660fbbe090e1b272adbb2

package/build/Release/oracledb-6.6.0-linux-arm64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.6.0-linux-arm64.node v20.12.2 6e81601d4d09137e859660fbbe090e1b272adbb2 5f182c720d6541c3b267d5d370f606f90b5b0c38 Wed, 17 Jul 2024 07:10:04 GMT

package/build/Release/oracledb-6.6.0-linux-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.6.0-linux-x64.node v16.20.2 6e81601d4d09137e859660fbbe090e1b272adbb2 5f182c720d6541c3b267d5d370f606f90b5b0c38 Wed, 17 Jul 2024 07:13:04 GMT

package/build/Release/oracledb-6.6.0-win32-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.6.0-win32-x64.node v18.16.0 6e81601d4d09137e859660fbbe090e1b272adbb2 5f182c720d6541c3b267d5d370f606f90b5b0c38 Wed, 17 Jul 2024 07:26:50 GMT

package/examples/README.md

@@ -106,6 +106,7 @@ File Name                                                 | Description
 [`plsqlproc.js`](plsqlproc.js)                            | How to call a PL/SQL procedure
 [`plsqlrecord.js`](plsqlrecord.js)                        | Shows binding of PL/SQL RECORDS
 [`plsqlvarrayrecord.js`](plsqlvarrayrecord.js)            | Shows binding a VARRAY of RECORD in PL/SQL
+[`plsqlrowtype.js`](plsqlrowtype.js)                      | Shows binding of PL/SQL %ROWTYPE object
 [`raw.js`](raw.js)                                        | Shows using a Buffer to insert and select a RAW
 [`refcursor.js`](refcursor.js)                            | Shows using a ResultSet to fetch rows from a REF CURSOR
 [`refcursortoquerystream.js`](refcursortoquerystream.js)  | Converts a REF CURSOR returned from `execute()` to a query stream.
@@ -130,5 +131,8 @@ File Name                                                 | Description
 [`soda1.js`](soda1.js)                                    | Basic Simple Oracle Document Access (SODA) example
 [`typehandlerdate.js`](typehandlerdate.js)                | Show how a type handler can format a queried date in a locale-specific way
 [`typehandlernum.js`](typehandlernum.js)                  | Show how a type handler can alter queried numbers
+[`vectortype1.js`](vectortype1.js)                        | Insert and query VECTOR columns.
+[`vectortype2.js`](vectortype2.js)                        | Insert data into VECTOR columns and verify vector operations.
 [`version.js`](version.js)                                | Shows the node-oracledb version attributes
 [`webapp.js`](webapp.js)                                  | A simple web application using a connection pool
+[`xmltypeInDbObject.js`](xmltypeInDbObject.js)            | Work with XMLType data in DbObject (Thin mode only)

package/lib/configProviders/azure.js

@@ -0,0 +1,167 @@
+// Copyright (c) 2024, Oracle and/or its affiliates.
+
+//-----------------------------------------------------------------------------
+//
+// This software is dual-licensed to you under the Universal Permissive License
+// (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
+// 2.0 as shown at http://www.apache.org/licenses/LICENSE-2.0. You may choose
+// either license.
+//
+// If you elect to accept the software under the Apache License, Version 2.0,
+// the following applies:
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//-----------------------------------------------------------------------------
+
+'use strict';
+
+let AppConfigurationClient;
+let ClientSecretCredential, ClientCertificateCredential, ChainedTokenCredential, ManagedIdentityCredential, EnvironmentCredential;
+const errors = require("../errors.js");
+const { base } = require("./base.js");
+
+class AzureProvider extends base {
+  constructor(provider_arg, urlExtendedPart) {
+    super(urlExtendedPart);
+    this._addParam("appconfigname", provider_arg);
+  }
+
+  //---------------------------------------------------------------------------
+  // init()
+  //
+  // Require/import modules from azure
+  //---------------------------------------------------------------------------
+  init() {
+    ({AppConfigurationClient } = require("@azure/app-configuration"));
+    ({ClientSecretCredential, ClientCertificateCredential, ChainedTokenCredential, ManagedIdentityCredential, EnvironmentCredential} = require("@azure/identity"));
+  }
+
+  //---------------------------------------------------------------------------
+  // _withChainedTokenCredential()
+  //
+  // Use of ChainedTokenCredential class which provides the ability to link
+  // together multiple credential instances to be tried sequentially when authenticating.
+  // Default authentication to try when no authentication parameter is given by the user
+  //---------------------------------------------------------------------------
+  _withChainedTokenCredential() {
+    const tokens = [];
+    if ((this.paramMap.get("azure_client_secret")))
+      tokens.push(new ClientSecretCredential(this.paramMap.get("azure_tenant_id"), this.paramMap.get("azure_client_id"), this.paramMap.get("azure_client_secret")));
+    if ((this.paramMap.get("azure_client_certificate_path")))
+      tokens.push(new ClientCertificateCredential(this.paramMap.get("azure_tenant_id"), this.paramMap.get("azure_client_id"), this.paramMap.get("azure_client_certificate_path")));
+    if ((this.paramMap.get('azure_managed_identity_client_id')))
+      tokens.push(this.paramMap.get('azure_managed_identity_client_id'));
+    tokens.push(new EnvironmentCredential());
+    const credential = new ChainedTokenCredential(...tokens);
+    return credential;
+  }
+
+  //---------------------------------------------------------------------------
+  // _returnCredential()
+  //
+  // Returns credential to access Azure Config Store on the basis of
+  // authentication parameters given by the user.
+  //---------------------------------------------------------------------------
+  _returnCredential() {
+    let auth = null;
+    if (this.paramMap.get('authentication')) {
+      auth = this.paramMap.get('authentication').toUpperCase();
+    }
+    if (auth && !(auth == 'AZURE_DEFAULT')) {
+      // do the given authentication
+      if (auth == 'AZURE_SERVICE_PRINCIPAL') {
+        if (this.paramMap.get("azure_client_certificate_path"))
+          return new ClientCertificateCredential(this.paramMap.get("azure_tenant_id"), this.paramMap.get("azure_client_id"), this.paramMap.get("azure_client_certificate_path"));
+        else if (this.paramMap.get("azure_client_secret"))
+          return new ClientSecretCredential(this.paramMap.get("azure_tenant_id"), this.paramMap.get("azure_client_id"), this.paramMap.get("azure_client_secret"));
+        else
+          errors.throwErr(errors.ERR_AZURE_SERVICE_PRINCIPAL_AUTH_FAILED);
+      } else if (auth == 'AZURE_MANAGED_IDENTITY') {
+        return new ManagedIdentityCredential(this.paramMap.get('azure_managed_identity_client_id'));
+      } else {
+        errors.throwErr(errors.ERR_AZURE_CONFIG_PROVIDER_AUTH_FAILED, auth);
+      }
+    } else {
+      //return default token credential
+      return this._withChainedTokenCredential();
+    }
+  }
+
+  //---------------------------------------------------------------------------
+  // _getConfigurationSetting()
+  //
+  // Get configuration setting from the config provider given a key
+  //and an optional label
+  //---------------------------------------------------------------------------
+  async _getConfigurationSetting(client, key, label) {
+    return await client.getConfigurationSetting({ key: key, label: label });
+
+  }
+
+  async returnConfig() {
+    const configObject = {};
+    const label = this.paramMap.get("label");
+    const credential = this._returnCredential();
+    // azure config store
+    const client = new AppConfigurationClient(
+      "https://" + this.paramMap.get("appconfigname"), // ex: <https://<your appconfig resource>.azconfig.io>
+      credential
+    );
+    // retrieve connect_description
+    configObject.connectString = (await this._getConfigurationSetting(client, this.paramMap.get("key") + 'connect_descriptor', label)).value;
+
+    // retrieve node-oracledb parameters
+    try {
+      const params = (await this._getConfigurationSetting(client, this.paramMap.get("key") + 'node-oracledb', label)).value;
+      const obj = JSON.parse(params);
+      for (const key in obj) {
+        var val = obj[key];
+        configObject[key] = val;
+      }
+    } catch {
+      configObject['node-oracledb'] = null;
+    }
+    try {
+      // retrieve user
+      configObject.user = (await this._getConfigurationSetting(client, this.paramMap.get("key") + 'user', label)).value;
+    } catch {
+      configObject.user = null;
+    }
+    //retrieve password
+    let pwdJson = null;
+    try {
+      pwdJson = await this._getConfigurationSetting(client, this.paramMap.get("key") + 'password', label);
+    } catch {
+      configObject.password = null;
+    }
+    if (pwdJson) {
+      let obj;
+      try {
+        obj = JSON.parse(pwdJson.value);
+      } catch {
+        obj = pwdJson.value;
+      }
+      if (obj.uri) {
+        const { SecretClient } = require("@azure/keyvault-secrets");
+        const vault_detail = await this._parsePwd(obj.uri);
+        const client1 = new SecretClient(vault_detail[0], credential);
+        configObject.password  = (await client1.getSecret(vault_detail[1])).value;
+      } else {
+        configObject.password = pwdJson.value;
+      }
+    }
+    return configObject;
+  }
+}
+module.exports = AzureProvider;

package/lib/configProviders/base.js

@@ -0,0 +1,99 @@
+// Copyright (c) 2024, Oracle and/or its affiliates.
+
+//-----------------------------------------------------------------------------
+//
+// This software is dual-licensed to you under the Universal Permissive License
+// (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
+// 2.0 as shown at http://www.apache.org/licenses/LICENSE-2.0. You may choose
+// either license.
+//
+// If you elect to accept the software under the Apache License, Version 2.0,
+// the following applies:
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//-----------------------------------------------------------------------------
+
+'use strict';
+
+class base {
+  constructor(url) {
+    const params = new URLSearchParams(url);
+    this.paramMap = new URLSearchParams([...params].map(([key, value]) => [key.toLowerCase(), value])); //parse the extended part and store parameters in Map
+  }
+
+  /**
+  * Sets precedence for different parameters in cloudConfig/userConfig
+  * @param {cloudConfig} object - object retreived from cloud
+  * @param {userConfig} object -  user input Object
+  */
+  modifyOptionsPrecedence(cloudConfig, userConfig) {
+    // create a copy of userConfig object
+    userConfig = { ...userConfig };
+    if (!userConfig.user)
+      userConfig.user = cloudConfig.user;
+    if (!userConfig.password)
+      userConfig.password = cloudConfig.password;
+    if (cloudConfig.connectString) {
+      userConfig.connectString = cloudConfig.connectString;
+      userConfig.connectionString = undefined;
+    }
+    if (cloudConfig.poolMin)
+      userConfig.poolMin = cloudConfig.poolMin;
+    if (cloudConfig.poolMax)
+      userConfig.poolMax = cloudConfig.poolMax;
+    if (cloudConfig.poolIncrement)
+      userConfig.poolIncrement = cloudConfig.poolIncrement;
+    if (cloudConfig.poolTimeout)
+      userConfig.poolTimeout = cloudConfig.poolTimeout;
+    if (cloudConfig.poolPingInterval)
+      userConfig.poolPingInterval = cloudConfig.poolPingInterval;
+    if (cloudConfig.poolPingTimeout)
+      userConfig.poolPingTimeout = cloudConfig.poolPingTimeout;
+    if (cloudConfig.stmtCacheSize)
+      userConfig.stmtCacheSize = cloudConfig.stmtCacheSize;
+    if (cloudConfig.prefetchRows)
+      userConfig.prefetchRows = cloudConfig.prefetchRows;
+    if (cloudConfig.lobPrefetch)
+      userConfig.lobPrefetch = cloudConfig.lobPrefetch;
+
+    return userConfig;
+
+  }
+
+  //---------------------------------------------------------------------------
+  // _addParam()
+  // Adds key,value pairs to the Map
+  //---------------------------------------------------------------------------
+  _addParam(key, value) {
+    const aliasKeyName = key.toLowerCase();
+    this.paramMap.set(aliasKeyName, value);
+  }
+
+  //---------------------------------------------------------------------------
+  // _parsePwd()
+  // Parse password which is in url format
+  // “uri”:“https://mykeyvault.vault.azure.net/secrets/secretkey”}
+  //---------------------------------------------------------------------------
+  _parsePwd(str) {
+    const vault_uri = new RegExp("(?<vault_url>https://[A-Za-z0-9._-]+)/secrets/(?<secretKey>[A-Za-z][A-Za-z0-9-]*)$", 'g');
+    const vault_detail = [];
+    for (const match of str.matchAll(vault_uri)) {
+      vault_detail[0] = match.groups.vault_url;
+      vault_detail[1] = match.groups.secretKey;
+    }
+    return vault_detail;
+  }
+
+}
+module.exports = {base};

package/lib/configProviders/ociobject.js

@@ -0,0 +1,203 @@
+// Copyright (c) 2024, Oracle and/or its affiliates.
+
+//-----------------------------------------------------------------------------
+//
+// This software is dual-licensed to you under the Universal Permissive License
+// (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
+// 2.0 as shown at http://www.apache.org/licenses/LICENSE-2.0. You may choose
+// either license.
+//
+// If you elect to accept the software under the Apache License, Version 2.0,
+// the following applies:
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//-----------------------------------------------------------------------------
+
+'use strict';
+const errors = require("../errors.js");
+const { base } = require("./base.js");
+const fs = require('fs');
+
+const cloud_net_naming_pattern_oci = new RegExp("(?<objservername>[A-Za-z0-9._-]+)/n/" + "(?<namespace>[A-Za-z0-9._-]+)/b/" + "(?<bucketname>[A-Za-z0-9._-]+)/o/" + "(?<filename>[A-Za-z0-9._-]+)" + "(/c/(?<alias>.+))?$");
+// object to store module references that will be populated by init()
+const oci = {};
+
+class OCIProvider extends base {
+  constructor(provider_arg, urlExtendedPart) {
+    super(urlExtendedPart);
+    const match = provider_arg.match(cloud_net_naming_pattern_oci);
+    if (match) {
+      this._addParam("objservername", match.groups.objservername);
+      this._addParam("namespace", match.groups.namespace);
+      this._addParam("bucketname", match.groups.bucketname);
+      this._addParam("filename", match.groups.filename);
+      if (match.groups.alias)
+        this._addParam("alias", match.groups.alias);
+    }
+  }
+
+  //---------------------------------------------------------------------------
+  // init()
+  //
+  // Require/import modules from ociobject
+  //---------------------------------------------------------------------------
+  init() {
+    oci.common = require('oci-common');
+    oci.objectstorage = require('oci-objectstorage');
+  }
+
+  //---------------------------------------------------------------------------
+  // _streamToString()
+  //
+  // Converts data stored in a Readable stream to string
+  //---------------------------------------------------------------------------
+  async _streamToString(stream) {
+    const chunks = [];
+    for await (const chunk of stream) {
+      chunks.push(Buffer.from(chunk));
+    }
+    return Buffer.concat(chunks).toString("utf-8");
+  }
+
+  //---------------------------------------------------------------------------
+  // _returnCredential()
+  //
+  // Returns credential to access OCI Object Store on the basis of
+  // authentication parameters given by the user.
+  //---------------------------------------------------------------------------
+  async _returnCredential() {
+    let provider = null;
+    let auth = null;
+    if (this.paramMap.get('authentication')) {
+      auth = this.paramMap.get('authentication').toUpperCase();
+    }
+    // authentication parameter given and its not OCI_DEFAULT
+    if (auth && !(auth == 'OCI_DEFAULT')) {
+      if (auth == 'OCI_INSTANCE_PRINCIPAL') {
+        provider = await new oci.common.InstancePrincipalsAuthenticationDetailsProviderBuilder().build();
+      } else if (auth == 'OCI_RESOURCE_PRINCIPAL') {
+        provider = await new oci.common.ResourcePrincipalAuthenticationDetailsProvider.builder();
+      } else
+        errors.throwErr(errors.ERR_OCIOBJECT_CONFIG_PROVIDER_AUTH_FAILED, auth);
+    } else {
+      // default authentication
+      try {
+        //authentication parameters exist in the configurationFile
+        provider = new oci.common.ConfigFileAuthenticationDetailsProvider(
+          this.paramMap.get("oci_profile_path"), //default path ~/.oci/config
+          this.paramMap.get("oci_profile")
+        );
+      } catch (err) {
+        //throw error for wrong profile or wrong path
+        if (!this.paramMap.get("oci_tenancy") || !this.paramMap.get("oci_user")) {
+          throw (err);
+        }
+        // authentication parameters are directly given in the connectString
+        const publicKey = fs.readFileSync(this.paramMap.get('oci_key_file'), { encoding: "utf8" });
+        const region = this.retrieveRegion(this.paramMap.get('objservername'));
+        provider = new oci.common.SimpleAuthenticationDetailsProvider(
+          this.paramMap.get("oci_tenancy"),
+          this.paramMap.get("oci_user"),
+          this.paramMap.get("oci_fingerprint"),
+          publicKey,
+          undefined,
+          oci.common.Region[region]
+        );
+      }
+    }
+    return provider;
+  }
+
+  //---------------------------------------------------------------------------
+  // returnConfig()
+  //
+  // Returns config stored in the OCI Object Store and
+  // parses and gets password field stored in OCI/Azure Vault
+  //---------------------------------------------------------------------------
+  async returnConfig() {
+    const configObject = {};
+    const credential = await this._returnCredential();
+    // oci object store
+    const client_oci = new (oci.objectstorage).ObjectStorageClient({
+      authenticationDetailsProvider: credential
+    });
+    const getObjectRequest = {
+      objectName: this.paramMap.get('filename'),
+      bucketName: this.paramMap.get('bucketname'),
+      namespaceName: this.paramMap.get('namespace')
+    };
+    let credential1;
+    const getObjectResponse = await client_oci.getObject(getObjectRequest);
+    const resp = await this._streamToString(getObjectResponse.value);
+    // Entire object we get from OCI Object Storage
+    let obj = JSON.parse(resp);
+    const userAlias = this.paramMap.get('alias');
+    if (userAlias) {
+      obj = obj[userAlias];
+    }
+    const pmSection = 'node-oracledb';
+    const params = obj[pmSection];
+    for (const key in params) {
+      var val = params[key];
+      configObject[key] = val;
+    }
+    configObject.connectString = obj.connect_descriptor;
+    configObject.user = obj.user;
+    if (obj.password) {
+      if (obj.password.type == "vault-azure") {
+        if (obj.password.authentication) {
+          const { SecretClient } = require("@azure/keyvault-secrets");
+          const {ClientSecretCredential, ClientCertificateCredential} = require("@azure/identity");
+          if (obj.password.authentication.azure_client_secret)
+            credential1 = new ClientSecretCredential(obj.password.authentication.azure_tenant_id, obj.password.authentication.azure_client_id, obj.password.authentication.azure_client_secret);
+          else if (obj.password.authentication.azure_client_certificate_path)
+            credential1 = new ClientCertificateCredential(obj.password.authentication.azure_tenant_id, obj.password.authentication.azure_client_id, obj.password.authentication.azure_client_certificate_path);
+          else
+            errors.throwErr(errors.ERR_AZURE_VAULT_AUTH_FAILED);
+          const vault_detail = await this._parsePwd(obj.password.value);
+          const client1 = new SecretClient(vault_detail[0], credential1);
+          configObject.password = (await client1.getSecret(vault_detail[1])).value;
+        } else {
+          errors.throwErr(errors.ERR_AZURE_VAULT_AUTH_FAILED);
+        }
+      } else if (obj.password.type == "vault-oci") {
+        const secrets = require('oci-secrets');
+        const secretClientOci =  new secrets.SecretsClient({
+          authenticationDetailsProvider: credential
+        });
+        const getSecretBundleRequest = {
+          secretId: obj.password.value
+        };
+        const getSecretBundleResponse = await secretClientOci.getSecretBundle(getSecretBundleRequest);
+        configObject.password = getSecretBundleResponse.secretBundle.secretBundleContent.content;
+      } else if (obj.password) {
+        configObject.password = obj.password;
+      }
+    } else {
+      configObject.password = null;
+    }
+    return configObject;
+  }
+
+  //---------------------------------------------------------------------------
+  // retrieveRegion(objservername)
+  //
+  // returns region from the given objservername.
+  //---------------------------------------------------------------------------
+  retrieveRegion(objservername) {
+    const arr = objservername.split(".");
+    return arr[1].toUpperCase().replaceAll('-', '_');
+  }
+}
+module.exports = OCIProvider;

package/lib/connection.js

@@ -202,9 +202,7 @@ class Connection extends EventEmitter {
       typeof value === 'boolean' ||
       typeof value === 'bigint' ||
       Array.isArray(value) ||
-      value instanceof Float32Array ||
-      value instanceof Float64Array ||
-      value instanceof Int8Array ||
+      nodbUtil.isVectorValue(value) ||
       Buffer.isBuffer(value) ||
       util.types.isDate(value) ||
       value instanceof Lob ||
@@ -1412,7 +1410,7 @@ class Connection extends EventEmitter {
   async tpcBegin(xid, flag, timeout) {
     errors.assertArgCount(arguments, 1, 3);
     errors.assertParamValue(nodbUtil.isXid(xid), 1);
-
+    const normalizedXid = nodbUtil.normalizeXid(xid);
     if (arguments.length < 3) {
       timeout = 60;   // seconds
     } else {
@@ -1423,9 +1421,14 @@ class Connection extends EventEmitter {
       flag = constants.TPC_BEGIN_NEW;
     } else {
       errors.assertParamValue(typeof flag === 'number', 2);
+      const options = [constants.TPC_BEGIN_NEW, constants.TPC_BEGIN_JOIN,
+        constants.TPC_BEGIN_RESUME, constants.TPC_BEGIN_PROMOTE];
+      if (options.indexOf(flag) < 0) {
+        errors.throwErr(errors.ERR_INVALID_TPC_BEGIN_FLAGS);
+      }
     }
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
-    await this._impl.tpcBegin(xid, flag, timeout);
+    await this._impl.tpcBegin(normalizedXid, flag, timeout);
   }
 
   //---------------------------------------------------------------------------
@@ -1441,11 +1444,13 @@ class Connection extends EventEmitter {
     } else {
       errors.assertParamValue(typeof onePhase === 'boolean', 2);
     }
+    let normalizedXid;
     if (arguments.length >= 1) {
       errors.assertParamValue(nodbUtil.isXid(xid), 1);
+      normalizedXid = nodbUtil.normalizeXid(xid);
     }
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
-    await this._impl.tpcCommit(xid, onePhase);
+    await this._impl.tpcCommit(normalizedXid, onePhase);
   }
 
   //---------------------------------------------------------------------------
@@ -1460,14 +1465,19 @@ class Connection extends EventEmitter {
       flag = constants.TPC_END_NORMAL;
     } else {
       errors.assertParamValue(typeof flag === 'number', 2);
+      const options = [constants.TPC_END_NORMAL, constants.TPC_END_SUSPEND];
+      if (!options.includes(flag)) {
+        errors.throwErr(errors.ERR_INVALID_TPC_END_FLAGS);
+      }
     }
-
+    let normalizedXid;
     if (arguments.length >= 1) {
       errors.assertParamValue(nodbUtil.isXid(xid), 1);
+      normalizedXid = nodbUtil.normalizeXid(xid);
     }
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
 
-    await this._impl.tpcEnd(xid, flag);
+    await this._impl.tpcEnd(normalizedXid, flag);
   }
 
   //---------------------------------------------------------------------------
@@ -1479,9 +1489,10 @@ class Connection extends EventEmitter {
   async tpcForget(xid) {
     errors.assertArgCount(arguments, 1, 1);
     errors.assertParamValue(nodbUtil.isXid(xid), 1);
+    const normalizedXid = nodbUtil.normalizeXid(xid);
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
 
-    await this._impl.tpcForget(xid);
+    await this._impl.tpcForget(normalizedXid);
   }
 
   //---------------------------------------------------------------------------
@@ -1491,12 +1502,14 @@ class Connection extends EventEmitter {
   //---------------------------------------------------------------------------
   async tpcPrepare(xid) {
     errors.assertArgCount(arguments, 0, 1);
+    let normalizedXid;
     if (arguments.length >= 1) {
       errors.assertParamValue(nodbUtil.isXid(xid), 1);
+      normalizedXid = nodbUtil.normalizeXid(xid);
     }
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
 
-    return await this._impl.tpcPrepare(xid);
+    return await this._impl.tpcPrepare(normalizedXid);
   }
 
   //---------------------------------------------------------------------------
@@ -1541,12 +1554,14 @@ class Connection extends EventEmitter {
   //---------------------------------------------------------------------------
   async tpcRollback(xid) {
     errors.assertArgCount(arguments, 0, 1);
+    let normalizedXid;
     if (arguments.length == 1) {
       errors.assertParamValue(nodbUtil.isXid(xid), 1);
+      normalizedXid = nodbUtil.normalizeXid(xid);
     }
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
 
-    await this._impl.tpcRollback(xid);
+    await this._impl.tpcRollback(normalizedXid);
   }
 
   //---------------------------------------------------------------------------
@@ -1570,6 +1585,8 @@ class Connection extends EventEmitter {
 // NOTE: breakExecution() should not be serialized
 Connection.prototype.break =
     nodbUtil.callbackify(Connection.prototype.breakExecution);
+Connection.prototype.tpcRecover =
+    nodbUtil.callbackify(Connection.prototype.tpcRecover);
 nodbUtil.wrapFns(Connection.prototype,
   "changePassword",
   "close",
@@ -1590,7 +1607,6 @@ nodbUtil.wrapFns(Connection.prototype,
   "tpcEnd",
   "tpcForget",
   "tpcPrepare",
-  "tpcRecover",
   "tpcRollback",
   "unsubscribe");
 

package/lib/constants.js

@@ -205,5 +205,6 @@ module.exports = {
   VECTOR_FORMAT_FLOAT32: 2,
   VECTOR_FORMAT_FLOAT64: 3,
   VECTOR_FORMAT_INT8: 4,
+  VECTOR_FORMAT_BINARY: 5,
 
 };