oracledb 6.0.2 → 6.1.0

package/README.md

@@ -1,10 +1,10 @@
-# node-oracledb version 6.0.2
+# node-oracledb version 6.1.0
 
 The node-oracledb add-on for Node.js powers high performance Oracle Database
 applications.  Applications can be written in TypeScript, or directly in
 JavaScript.
 
-Use node-oracledb 6.0.2 to connect Node.js 14.6, or later, to Oracle
+Use node-oracledb 6.1.0 to connect Node.js 14.6, or later, to Oracle
 Database.  Older versions of node-oracledb may work with older versions of
 Node.js.
 
@@ -20,12 +20,12 @@ See [Getting Started with Node-oracledb][1] and [Quick Start Node-oracledb Insta
 
 ## Documentation
 
-See [Documentation for the Oracle Database Node.js Add-on][32] and the [release
-notes][33].
+See [Documentation for the Oracle Database Node.js Add-on][9] and the [release
+notes][10].
 
 ## Examples
 
-See the [examples][30] directory.  Start with [examples/example.js][31].
+See the [examples][7] directory.  Start with [examples/example.js][8].
 
 ## Help
 
@@ -34,19 +34,16 @@ to join Slack][6]).
 
 ## <a name="testing"></a> Tests
 
-To run the test suite see [test/README][34].
+To run the test suite see [test/README][11].
 
 ## Contributing
 
 This project welcomes contributions from the community. Before submitting a
-pull request, please [review our contribution guide][35].
-
-Oracle gratefully acknowledges the contributions to node-oracledb that have
-been made by the community.
+pull request, please [review our contribution guide][12].
 
 ## Security
 
-Please consult the [security guide](./SECURITY.md) for our responsible security
+Please consult the [security guide][13] for our responsible security
 vulnerability disclosure process.
 
 ## License
@@ -79,9 +76,10 @@ limitations under the License.
 [4]: https://oracle.github.io/node-oracledb
 [5]: https://node-oracledb.slack.com/
 [6]: https://join.slack.com/t/node-oracledb/shared_invite/enQtNDU4Mjc2NzM5OTA2LWMzY2ZlZDY5MDdlMGZiMGRkY2IzYjI5OGU4YTEzZWM5YjQ3ODUzMjcxNWQyNzE4MzM5YjNkYjVmNDk5OWU5NDM
-[30]: https://github.com/oracle/node-oracledb/blob/main/examples
-[31]: https://github.com/oracle/node-oracledb/blob/main/examples/example.js
-[32]: https://node-oracledb.readthedocs.io/en/latest/
-[33]: https://node-oracledb.readthedocs.io/en/latest/release_notes.html
-[34]: https://github.com/oracle/node-oracledb/blob/main/test/README.md
-[35]: https://github.com/oracle/node-oracledb/blob/main/CONTRIBUTING.md
+[7]: https://github.com/oracle/node-oracledb/blob/main/examples
+[8]: https://github.com/oracle/node-oracledb/blob/main/examples/example.js
+[9]: https://node-oracledb.readthedocs.io/en/latest/
+[10]: https://node-oracledb.readthedocs.io/en/latest/release_notes.html
+[11]: https://github.com/oracle/node-oracledb/blob/main/test/README.md
+[12]: https://github.com/oracle/node-oracledb/blob/main/CONTRIBUTING.md
+[13]: https://github.com/oracle/node-oracledb/blob/main/SECURITY.md

package/SECURITY.md

@@ -21,7 +21,7 @@ security features are welcome on GitHub Issues.
 
 Security updates will be released on a regular cadence. Many of our projects
 will typically release security fixes in conjunction with the
-[Oracle Critical Patch Update][3] program. Additional
+Oracle Critical Patch Update program. Additional
 information, including past advisories, is available on our [security alerts][4]
 page.
 

package/build/Release/oracledb-6.1.0-darwin-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.1.0-darwin-x64.node v18.17.1 98df02823e1fc31b0e57044cd1fb2358dfc620ed 20785f251426f274f4216369b9259908a103384d Mon, 21 Aug 2023 05:58:15 GMT

package/build/Release/oracledb-6.1.0-js-buildinfo.txt

@@ -0,0 +1 @@
+98df02823e1fc31b0e57044cd1fb2358dfc620ed

package/build/Release/oracledb-6.1.0-linux-arm64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.1.0-linux-arm64.node v18.15.0 98df02823e1fc31b0e57044cd1fb2358dfc620ed 20785f251426f274f4216369b9259908a103384d Mon, 21 Aug 2023 07:05:34 GMT

package/build/Release/oracledb-6.1.0-linux-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.1.0-linux-x64.node v16.20.0 98df02823e1fc31b0e57044cd1fb2358dfc620ed 20785f251426f274f4216369b9259908a103384d Mon, 21 Aug 2023 05:55:55 GMT

package/build/Release/oracledb-6.1.0-win32-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-6.1.0-win32-x64.node v16.19.0 98df02823e1fc31b0e57044cd1fb2358dfc620ed 20785f251426f274f4216369b9259908a103384d Mon, 21 Aug 2023 09:35:54 GMT

package/examples/example.js

@@ -127,7 +127,6 @@ async function run() {
     // For a complete list of options see the documentation.
     options = {
       outFormat: oracledb.OUT_FORMAT_OBJECT,   // query result format
-      // extendedMetaData: true,               // get extra metadata
       // fetchArraySize:   100                 // internal buffer allocation size for tuning
     };
 

package/lib/aqQueue.js

@@ -27,13 +27,14 @@
 'use strict';
 
 const { Buffer } = require('buffer');
-const constants = require('./constants.js');
 const errors = require('./errors.js');
 const nodbUtil = require('./util.js');
 const AqDeqOptions = require('./aqDeqOptions.js');
 const AqEnqOptions = require('./aqEnqOptions.js');
 const AqMessage = require('./aqMessage.js');
 const BaseDbObject = require('./dbObject.js');
+const transformer = require('./transformer.js');
+const types = require('./types.js');
 
 class AqQueue {
 
@@ -47,6 +48,19 @@ class AqQueue {
         value instanceof BaseDbObject);
   }
 
+  //---------------------------------------------------------------------------
+  // _makeMessage()
+  //
+  // For enqOne()/deqOne()/enqMany()/deqMany(), wrap the return value with JS
+  // layer object.
+  //---------------------------------------------------------------------------
+  _makeMessage(msgImpl) {
+    const msg = new AqMessage();
+    msg._impl = msgImpl;
+    msg._payloadTypeClass = this._payloadTypeClass;
+    return msg;
+  }
+
   //---------------------------------------------------------------------------
   // _verifyMessage()
   //
@@ -64,7 +78,7 @@ class AqQueue {
       message = {};
     } else {
       message = {...message};
-      if (this._isPayload(message.payload)) {
+      if (this._isJson || this._isPayload(message.payload)) {
         payload = message.payload;
       } else if (this._payloadTypeClass) {
         payload = new this._payloadTypeClass(message.payload);
@@ -74,7 +88,9 @@ class AqQueue {
     }
 
     // validate payload
-    if (typeof payload === 'string') {
+    if (this._isJson) {
+      message.payload = transformer.transformJsonValue(payload);
+    } else if (typeof payload === 'string') {
       message.payload = Buffer.from(payload);
     } else if (Buffer.isBuffer(payload)) {
       message.payload = payload;
@@ -116,8 +132,17 @@ class AqQueue {
   // Creates the queue and populates some internal attributes.
   //---------------------------------------------------------------------------
   async create(conn, name, options) {
-    if (options.payloadType) {
-      if (typeof options.payloadType == 'string') {
+    if (options.payloadType === types.DB_TYPE_JSON) {
+      this._isJson = true;
+      this._payloadType = types.DB_TYPE_JSON;
+      this._payloadTypeName = "JSON";
+    } else if (options.payloadType === undefined ||
+               options.payloadType === types.DB_TYPE_RAW) {
+      this._payloadType = types.DB_TYPE_RAW;
+      this._payloadTypeName = "RAW";
+    } else {
+      if (typeof options.payloadType === 'string') {
+        // DB Object type
         const cls = await conn._getDbObjectClassForName(options.payloadType);
         this._payloadTypeClass = cls;
         options.payloadType = cls;
@@ -126,14 +151,12 @@ class AqQueue {
           options.payloadType.prototype instanceof BaseDbObject, 2, "payloadType");
         this._payloadTypeClass = options.payloadType;
       }
-      this._payloadType = constants.DB_TYPE_OBJECT;
+      this._payloadType = types.DB_TYPE_OBJECT;
       this._payloadTypeName = this._payloadTypeClass.prototype.name;
-    } else {
-      this._payloadType = constants.DB_TYPE_RAW;
-      this._payloadTypeName = "RAW";
     }
     this._name = name;
-    this._impl = await conn._impl.getQueue(name, options);
+    this._impl = await conn._impl.getQueue(name, this._payloadTypeClass,
+      this._payloadType);
   }
 
   //---------------------------------------------------------------------------
@@ -147,14 +170,7 @@ class AqQueue {
     errors.assertParamValue(Number.isInteger(maxMessages) && maxMessages > 0,
       1);
     const msgImpls = await this._impl.deqMany(maxMessages);
-    const messages = new Array(msgImpls.length);
-    for (let i = 0; i < msgImpls.length; i++) {
-      const msg = new AqMessage();
-      msg._impl = msgImpls[i];
-      msg._payloadTypeClass = this._payloadTypeClass;
-      messages[i] = msg;
-    }
-    return messages;
+    return  msgImpls.map(i => this._makeMessage(i));
   }
 
   //---------------------------------------------------------------------------
@@ -165,12 +181,8 @@ class AqQueue {
   async deqOne() {
     errors.assertArgCount(arguments, 0, 0);
     const msgImpl = await this._impl.deqOne();
-    if (msgImpl) {
-      const msg = new AqMessage();
-      msg._impl = msgImpl;
-      msg._payloadTypeClass = this._payloadTypeClass;
-      return msg;
-    }
+    if (msgImpl)
+      return this._makeMessage(msgImpl);
   }
 
   //---------------------------------------------------------------------------
@@ -200,7 +212,8 @@ class AqQueue {
     for (let i = 0; i < messages.length; i++) {
       verifiedMessages[i] = this._verifyMessage(messages[i]);
     }
-    return await this._impl.enqMany(verifiedMessages);
+    const msgImpls = await this._impl.enqMany(verifiedMessages);
+    return msgImpls.map(i => this._makeMessage(i));
   }
 
   //---------------------------------------------------------------------------
@@ -211,7 +224,8 @@ class AqQueue {
   async enqOne(message) {
     errors.assertArgCount(arguments, 1, 1);
     message = this._verifyMessage(message);
-    return await this._impl.enqOne(message);
+    const msgImpl = await this._impl.enqOne(message);
+    return this._makeMessage(msgImpl);
   }
 
   //---------------------------------------------------------------------------

package/lib/connection.js

@@ -1039,6 +1039,19 @@ class Connection extends EventEmitter {
     return info;
   }
 
+  //---------------------------------------------------------------------------
+  // instanceName
+  //
+  // Returns the Oracle Database instance name associated with the connection.
+  // This is the equivalent of the SQL expression:
+  // sys_context('userenv', 'instance_name')
+  //---------------------------------------------------------------------------
+  get instanceName() {
+    if (this._impl)
+      return this._impl.getInstanceName();
+    return undefined;
+  }
+
   //---------------------------------------------------------------------------
   // internalName
   //
@@ -1227,7 +1240,7 @@ class Connection extends EventEmitter {
     errors.assertArgCount(arguments, 2, 2);
     errors.assertParamValue(typeof name === 'string', 1);
     errors.assertParamValue(nodbUtil.isObject(options), 2);
-    options = {...options};
+    options = {name: name, ...options};
     errors.assertParamPropUnsignedInt(options, 2, "namespace");
     if (options.namespace === undefined)
       options.namespace = constants.SUBSCR_NAMESPACE_DBCHANGE;
@@ -1253,14 +1266,13 @@ class Connection extends EventEmitter {
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
 
     const inSubscr = _subscriptions.get(name);
-    let outValue = await this._impl.subscribe(inSubscr, options);
+    const outValue = await this._impl.subscribe(inSubscr, options);
     let subscription;
     if (options.namespace === constants.SUBSCR_NAMESPACE_DBCHANGE) {
       subscription = outValue.subscription;
       delete outValue.subscription;
     } else {
       subscription = outValue;
-      outValue = undefined;
     }
     _subscriptions.set(name, subscription);
     return outValue;

package/lib/errors.js

@@ -116,7 +116,6 @@ const ERR_UNEXPECTED_DATA = 113;
 const ERR_OSON_FIELD_NAME_LIMITATION = 114;
 const ERR_ORACLE_NUMBER_NO_REPR = 115;
 const ERR_UNSUPPORTED_VERIFIER_TYPE = 116;
-const ERR_INVALID_PRIVATE_KEY = 117;
 const ERR_THIN_CONNECTION_ALREADY_CREATED = 118;
 const ERR_UNSUPPORTED_CONVERSION = 119;
 const ERR_FETCH_TYPE_HANDLER_RETURN_VALUE = 120;
@@ -161,7 +160,8 @@ const ERR_INVALID_SID = 519;
 const ERR_TNS_NAMES_FILE_MISSING = 520;
 const ERR_CONNECTION_EOF = 521;
 
-// define mapping for ODPI-C errors that need to be wrapped with NJS errors
+// define mapping for ODPI-C, OCI & ORA errors that need to be wrapped
+// with NJS errors
 const adjustErrorXref = new Map();
 adjustErrorXref.set("DPI-1010", ERR_CONNECTION_CLOSED);
 adjustErrorXref.set("DPI-1024", [ERR_INVALID_COLL_INDEX_GET, 'at index ([0-9]+) does']);
@@ -177,7 +177,6 @@ adjustErrorXref.set("OCI-22165", [ERR_INVALID_COLL_INDEX_SET, /index \[([0-9]+)\
 adjustErrorXref.set("ORA-00028", ERR_CONNECTION_CLOSED);
 adjustErrorXref.set("ORA-00600", ERR_CONNECTION_CLOSED);
 adjustErrorXref.set("ORA-24338", ERR_INVALID_REF_CURSOR);
-adjustErrorXref.set("ORA-24422", ERR_POOL_HAS_BUSY_CONNECTIONS);
 adjustErrorXref.set("ORA-25708", ERR_TOKEN_HAS_EXPIRED);
 
 // define mapping for error messages
@@ -327,7 +326,7 @@ messages.set(ERR_MISSING_CREDENTIALS,                   // NJS-101
 messages.set(ERR_UNEXPECTED_END_OF_DATA,                // NJS-102
   'unexpected end of data: want %d bytes but only %d bytes are available');
 messages.set(ERR_UNEXPECTED_MESSAGE_TYPE,               // NJS-103
-  'unexpected message type %d received');
+  'unexpected message type %d received at position %d of packet %d');
 messages.set(ERR_POOL_HAS_BUSY_CONNECTIONS,             // NJS-104
   'connection pool cannot be closed because connections are busy');
 messages.set(ERR_NAN_VALUE,                             // NJS-105
@@ -343,9 +342,9 @@ messages.set(ERR_INVALID_TYPE_NUM,                      // NJS-109
 messages.set(ERR_INVALID_ORACLE_TYPE_NUM,               // NJS-110
   'invalid Oracle type number %d [csfrm: %d]');
 messages.set(ERR_UNEXPECTED_NEGATIVE_INTEGER,           // NJS-111
-  'internal error: read a negative integer when expecting a positive integer');
+  'internal error: read a negative integer when expecting a positive integer at position %d of packet %d');
 messages.set(ERR_INTEGER_TOO_LARGE,                     // NJS-112
-  'internal error: read integer of length %d when expecting integer of no more than length %d');
+  'internal error: read integer of length %d when expecting integer of no more than length %d at position %d of packet %d');
 messages.set(ERR_UNEXPECTED_DATA,                       // NJS-113
   'unexpected data received: %s');
 messages.set(ERR_OSON_FIELD_NAME_LIMITATION,            // NJS-114
@@ -354,8 +353,6 @@ messages.set(ERR_ORACLE_NUMBER_NO_REPR,                 // NJS-115
   'value cannot be represented as an Oracle Database number');
 messages.set(ERR_UNSUPPORTED_VERIFIER_TYPE,             // NJS-116
   'password verifier type 0x%s is not supported by node-oracledb in Thin mode');
-messages.set(ERR_INVALID_PRIVATE_KEY,                   // NJS-117
-  'invalid private key. Headers and footers are not allowed');
 messages.set(ERR_THIN_CONNECTION_ALREADY_CREATED,       // NJS-118
   'node-oracledb Thick mode cannot be enabled because a Thin mode connection has already been created');
 messages.set(ERR_UNSUPPORTED_CONVERSION,                // NJS-119
@@ -611,10 +608,19 @@ function transformErr(err, fnOpt) {
     const pos = err.message.indexOf(":");
     if (pos > 0) {
       err.code = err.message.substr(0, pos);
+      /* add Oracle Database Error Help Portal URL for database error
+         messages, but only in thin mode since this is done
+         automatically in thick mode with Oracle Client 23c and higher
+      */
+      const settings = require('./settings.js');
+      if (err.errorNum && settings.thin) {
+        err.message += '\n' + 'Help: https://docs.oracle.com/error-help/db/ora-' +
+          `${err.errorNum.toString().padStart(5, '0')}/`;
+      }
       if (adjustErrorXref.has(err.code)) {
         let args = [];
         let driverErrorNum;
-        let driverErrorInfo = adjustErrorXref.get(err.code);
+        const driverErrorInfo = adjustErrorXref.get(err.code);
         if (typeof driverErrorInfo === 'number') {
           driverErrorNum = driverErrorInfo;
         } else {
@@ -747,7 +753,6 @@ module.exports = {
   ERR_UNEXPECTED_DATA,
   ERR_OSON_FIELD_NAME_LIMITATION,
   ERR_OSON_VERSION_NOT_SUPPORTED,
-  ERR_INVALID_PRIVATE_KEY,
   ERR_THIN_CONNECTION_ALREADY_CREATED,
   ERR_UNSUPPORTED_CONVERSION,
   ERR_FETCH_TYPE_HANDLER_RETURN_VALUE,

package/lib/impl/connection.js

@@ -226,6 +226,15 @@ class ConnectionImpl {
     errors.throwNotImplemented("getting the external name");
   }
 
+  //---------------------------------------------------------------------------
+  // getInstanceName()
+  //
+  // Returns the Oracle Database instance name associated with the connection.
+  //---------------------------------------------------------------------------
+  getInstanceName() {
+    errors.throwNotImplemented("getting the Oracle Database instance name.");
+  }
+
   //---------------------------------------------------------------------------
   // getInternalName()
   //

package/lib/impl/resultset.js

@@ -111,14 +111,17 @@ class ResultSetImpl {
       if (metadata.dbType === types.DB_TYPE_NUMBER &&
           metadata.fetchType === types.DB_TYPE_NUMBER) {
         converter = (v) => (v === null) ? null : parseFloat(v);
-      } else if (metadata.fetchType === types.DB_TYPE_VARCHAR &&
-          (metadata.dbType === types.DB_TYPE_BINARY_DOUBLE ||
+      } else if (metadata.fetchType === types.DB_TYPE_VARCHAR) {
+        if (metadata.dbType === types.DB_TYPE_BINARY_DOUBLE ||
            metadata.dbType === types.DB_TYPE_BINARY_FLOAT ||
            metadata.dbType === types.DB_TYPE_DATE ||
            metadata.dbType === types.DB_TYPE_TIMESTAMP ||
            metadata.dbType === types.DB_TYPE_TIMESTAMP_LTZ ||
-           metadata.dbType === types.DB_TYPE_TIMESTAMP_TZ)) {
-        converter = (v) => (v === null) ? null : v.toString();
+           metadata.dbType === types.DB_TYPE_TIMESTAMP_TZ) {
+          converter = (v) => (v === null) ? null : v.toString();
+        } else if (metadata.dbType === types.DB_TYPE_RAW) {
+          converter = (v) => (v === null) ? null : v.toString('hex').toUpperCase();
+        }
       }
       if (userConverter && converter) {
         const internalConverter = converter;

package/lib/oracledb.js

@@ -67,7 +67,6 @@ const defaultPoolAlias = 'default';
 
 // save arguments for call to initOracleClient()
 let _initOracleClientArgs;
-let _thinDriverInitialized = false;
 
 // Load the Oracledb binary
 function _initCLib() {
@@ -248,6 +247,12 @@ async function _verifyOptions(options, inCreatePool) {
     outOptions.sslServerDNMatch = options.sslServerDNMatch;
   }
 
+  // sslAllowWeakDNMatch must be a boolean
+  if (options.sslAllowWeakDNMatch !== undefined) {
+    errors.assertParamPropValue(typeof options.sslAllowWeakDNMatch === 'boolean',
+      1, "sslAllowWeakDNMatch");
+    outOptions.sslAllowWeakDNMatch = options.sslAllowWeakDNMatch;
+  }
   // httpsProxy must be a string
   if (options.httpsProxy !== undefined) {
     errors.assertParamPropValue(typeof options.httpsProxy === 'string',
@@ -472,8 +477,10 @@ async function _verifyOptions(options, inCreatePool) {
     errors.assert(nodbUtil.isTokenValid(accessToken),
       errors.ERR_TOKEN_HAS_EXPIRED);
     if (accessToken.privateKey !== undefined) {
-      errors.assert(nodbUtil.isPrivateKeyValid(accessToken),
-        errors.ERR_INVALID_PRIVATE_KEY);
+      errors.assert(typeof accessToken.privateKey === 'string', errors.ERR_TOKEN_BASED_AUTH);
+      accessToken.privateKey = accessToken.privateKey.replace(/\n/g, '');
+      accessToken.privateKey = accessToken.privateKey.replace('-----BEGIN PRIVATE KEY-----', '');
+      accessToken.privateKey = accessToken.privateKey.replace('-----END PRIVATE KEY-----', '');
     }
 
     // store token and privatekey
@@ -546,7 +553,7 @@ async function createPool(options) {
   }
 
   // initialize the Oracle client, if necessary
-  if (_initOracleClientArgs === undefined && !_thinDriverInitialized) {
+  if (_initOracleClientArgs === undefined && !settings.thinDriverInitialized) {
     _initializeThinDriver();
   }
 
@@ -579,6 +586,9 @@ async function createPool(options) {
       delete poolCache[pool.poolAlias];
     }
   });
+  if (_initOracleClientArgs === undefined) {
+    settings.thinDriverInitialized = true;
+  }
 
   return pool;
 }
@@ -638,7 +648,6 @@ async function getConnection(a1) {
 // Returns a pool for the given alias.
 //-----------------------------------------------------------------------------
 function getPool(poolAlias) {
-  let pool;
 
   errors.assertArgCount(arguments, 0, 1);
 
@@ -649,7 +658,7 @@ function getPool(poolAlias) {
 
   poolAlias = poolAlias || defaultPoolAlias;
 
-  pool = poolCache[poolAlias];
+  const pool = poolCache[poolAlias];
 
   if (!pool) {
     errors.throwErr(errors.ERR_POOL_WITH_ALIAS_NOT_FOUND, poolAlias);
@@ -1053,16 +1062,10 @@ module.exports = {
   },
 
   get oracleClientVersion() {
-    if (_initOracleClientArgs === undefined) {
-      errors.throwNotImplemented("getting the Oracle Client version");
-    }
     return settings.oracleClientVersion;
   },
 
   get oracleClientVersionString() {
-    if (_initOracleClientArgs === undefined) {
-      errors.throwNotImplemented("getting the Oracle Client version");
-    }
     return settings.oracleClientVersionString;
   },
 

package/lib/pool.js

@@ -47,6 +47,7 @@ class Pool extends EventEmitter {
     this._timeOfReset = this._createdDate = Date.now();
     this._sessionCallback = undefined;
     this._connRequestQueue = [];
+    this._connectionClass = settings.connectionClass;
   }
 
   //---------------------------------------------------------------------------
@@ -278,8 +279,14 @@ class Pool extends EventEmitter {
       });
     }
 
+    // if any connections are still out and the pool is not being force closed,
+    // throw an exception
+    if (!forceClose && this._connectionsOut > 0) {
+      errors.throwErr(errors.ERR_POOL_HAS_BUSY_CONNECTIONS);
+    }
+
     // close the pool
-    await this._impl.close({forceClose: forceClose});
+    await this._impl.close();
     this._status = constants.POOL_STATUS_CLOSED;
     this.emit('_afterPoolClose');
 
@@ -376,7 +383,9 @@ class Pool extends EventEmitter {
       errors.assertParamValue(nodbUtil.isObject(a1), 1);
       options = this._verifyGetConnectionOptions(a1);
     }
-    settings.addToOptions(options, "connectionClass");
+
+    // get connection class value from pool
+    options.connectionClass = this._connectionClass;
 
     // if pool is draining/closed, throw an appropriate error
     this._checkPoolOpen(true);

package/lib/settings.js

@@ -69,7 +69,7 @@ class Settings {
   // database are returned as though they used the JavaScript time zone
   // setting. TIMESTAMP WITH TIME ZONE and TIMESTAMP WITH LOCAL TIME ZONE data
   // are returned in native JavaScript format (since they contain time zone
-  // information).
+  // information). This is used only in Thick mode (from node-oracledb 6.0.0).
   //---------------------------------------------------------------------------
   _getDateComponents(useLocal, date) {
     if (useLocal) {

package/lib/sodaCollection.js

@@ -109,7 +109,7 @@ class SodaCollection {
     errors.assertArgCount(arguments, 1, 1);
     errors.assertParamValue(Array.isArray(docs) && docs.length > 0, 1);
 
-    let actualDocs = Array(docs.length);
+    const actualDocs = Array(docs.length);
     for (let i = 0; i < docs.length; i++) {
       actualDocs[i] = nodbUtil.verifySodaDoc(docs[i]);
     }