oracledb 5.1.0 → 5.4.0

package/README.md

@@ -1,11 +1,10 @@
-# node-oracledb version 5.1
+# node-oracledb version 5.4.0
 
-**This release is under development and information may be incomplete**
+The node-oracledb add-on for Node.js powers high performance Oracle Database
+applications.  Applications can be written in TypeScript, or directly in
+JavaScript.
 
-The node-oracledb add-on for Node.js powers high performance Oracle
-Database applications.
-
-Use node-oracledb 5.1 to connect Node.js 10.16, 12, 14, or later, to Oracle Database.
+Use node-oracledb 5.4.0 to connect Node.js 14, or later, to Oracle Database.
 Older versions of node-oracledb may work with older versions of Node.js.
 
 Node-oracledb supports basic and advanced features of Oracle Database
@@ -45,7 +44,7 @@ have been made by the community.
 
 ## <a name="license"></a> License
 
-Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved.
+Copyright (c) 2015, 2022, Oracle and/or its affiliates.
 
 You may not use the identified files except in compliance with the Apache
 License, Version 2.0 (the "License.")
@@ -59,7 +58,10 @@ CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 
-
+Developers choosing to distribute a binary implementation of this project are
+responsible for obtaining and providing all required licenses and copyright
+notices for the third-party code used in order to ensure compliance with their
+respective open source licenses.
 
 [1]: https://oracle.github.io/node-oracledb/doc/api.html#getstarted
 [2]: https://oracle.github.io/node-oracledb/INSTALL.html#quickstart
@@ -67,10 +69,10 @@ limitations under the License.
 [4]: https://oracle.github.io/node-oracledb
 [5]: https://node-oracledb.slack.com/
 [6]: https://join.slack.com/t/node-oracledb/shared_invite/enQtNDU4Mjc2NzM5OTA2LWMzY2ZlZDY5MDdlMGZiMGRkY2IzYjI5OGU4YTEzZWM5YjQ3ODUzMjcxNWQyNzE4MzM5YjNkYjVmNDk5OWU5NDM
-[30]: https://github.com/oracle/node-oracledb/blob/master/examples
-[31]: https://github.com/oracle/node-oracledb/blob/master/examples/example.js#L32
+[30]: https://github.com/oracle/node-oracledb/blob/main/examples
+[31]: https://github.com/oracle/node-oracledb/blob/main/examples/example.js#L32
 [32]: https://oracle.github.io/node-oracledb/doc/api.html
-[33]: https://github.com/oracle/node-oracledb/blob/master/CHANGELOG.md
-[34]: https://github.com/oracle/node-oracledb/blob/master/test/README.md
-[35]: https://github.com/oracle/node-oracledb/blob/master/CONTRIBUTING.md
+[33]: https://github.com/oracle/node-oracledb/blob/main/CHANGELOG.md
+[34]: https://github.com/oracle/node-oracledb/blob/main/test/README.md
+[35]: https://github.com/oracle/node-oracledb/blob/main/CONTRIBUTING.md
 [36]: http://www.apache.org/licenses/LICENSE-2.0

package/THIRD_PARTY_LICENSES.txt

@@ -0,0 +1,52 @@
+This product calls the top level APIs of Node.js. 
+
+Node.js is licensed for use as follows:
+
+"""
+Copyright Node.js contributors. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to
+deal in the Software without restriction, including without limitation the
+rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+sell copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+IN THE SOFTWARE.
+"""
+
+This license applies to parts of Node.js originating from the
+https://github.com/joyent/node repository:
+
+"""
+Copyright Joyent, Inc. and other Node contributors. All rights reserved.
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to
+deal in the Software without restriction, including without limitation the
+rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+sell copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+IN THE SOFTWARE.
+"""
+
+The Node.js license applies to all parts of Node.js that are not externally
+maintained libraries.

package/build/Release/oracledb-5.4.0-darwin-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-5.4.0-darwin-x64.node v18.2.0 84de9360da1af5b66be23bd5dcf0de230baf2a86 7682f57b334c378986a2687b418fe45daaf70af0 Wed, 01 Jun 2022 07:28:15 GMT

package/build/Release/oracledb-5.4.0-linux-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-5.4.0-linux-x64.node v10.23.1 84de9360da1af5b66be23bd5dcf0de230baf2a86 7682f57b334c378986a2687b418fe45daaf70af0 Wed, 01 Jun 2022 07:08:49 GMT

package/build/Release/oracledb-5.4.0-win32-x64.node-buildinfo.txt

@@ -0,0 +1 @@
+oracledb-5.4.0-win32-x64.node v18.2.0 84de9360da1af5b66be23bd5dcf0de230baf2a86 7682f57b334c378986a2687b418fe45daaf70af0 Wed, 01 Jun 2022 07:24:49 GMT

package/lib/aqDeqOptions.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved
+// Copyright (c) 2019, 2022, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //

package/lib/aqEnqOptions.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved
+// Copyright (c) 2019, 2022, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //

package/lib/aqMessage.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved
+// Copyright (c) 2019, 2022, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //

package/lib/aqQueue.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved
+// Copyright (c) 2019, 2022, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //
@@ -70,10 +70,14 @@ async function enqMany(messages) {
 class AqQueue {
 
   _extend() {
-    this.deqOne = nodbUtil.callbackify(deqOne);
-    this.deqMany = nodbUtil.callbackify(deqMany);
-    this.enqOne = nodbUtil.callbackify(enqOne);
-    this.enqMany = nodbUtil.callbackify(enqMany);
+    this.deqOne = nodbUtil.callbackify(nodbUtil.serialize(deqOne));
+    this.deqMany = nodbUtil.callbackify(nodbUtil.serialize(deqMany));
+    this.enqOne = nodbUtil.callbackify(nodbUtil.serialize(enqOne));
+    this.enqMany = nodbUtil.callbackify(nodbUtil.serialize(enqMany));
+  }
+
+  _getConnection() {
+    return this._connection;
   }
 
 }

package/lib/connection.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved
+// Copyright (c) 2016, 2022, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //
@@ -71,7 +71,7 @@ async function execute(sql, a2, a3) {
     }
   }
 
-  return result;
+  return (result);
 }
 
 
@@ -97,7 +97,7 @@ async function executeMany(sql, bindsOrNumIters, a3) {
     options = a3;
   }
 
-  return await this._executeMany(sql, bindsOrNumIters, options);
+  return (await this._executeMany(sql, bindsOrNumIters, options));
 }
 
 
@@ -115,7 +115,7 @@ async function getDbObjectClass(name) {
   if (cls) {
     return cls;
   }
-  return await this._getDbObjectClass(name);
+  return (await this._getDbObjectClass(name));
 }
 
 
@@ -125,7 +125,7 @@ async function getDbObjectClass(name) {
 //-----------------------------------------------------------------------------
 async function getStatementInfo(sql) {
   nodbUtil.checkArgCount(arguments, 1, 1);
-  return await this._getStatementInfo(sql);
+  return (await this._getStatementInfo(sql));
 }
 
 
@@ -146,7 +146,7 @@ async function commit() {
 async function createLob(type) {
   nodbUtil.checkArgCount(arguments, 1, 1);
   nodbUtil.assert(typeof type === 'number', 'NJS-005', 1);
-  return await this._createLob(type);
+  return (await this._createLob(type));
 }
 
 
@@ -172,12 +172,25 @@ async function close(a1) {
     nodbUtil.assert(nodbUtil.isObject(a1), 'NJS-005', 1);
     options = a1;
   }
-  await this._close(options);
+
+  // If already in the process of closing, throw an error instead of doing
+  // a roundtrip
+  if (this._closing) {
+    throw new Error (nodbUtil.getErrorMessage('NJS-003'));
+  }
+
+  this._closing = true;
+  try {
+    await this._close(options);
+  } finally {
+    this._closing = false;
+  }
+
   for (const cls of Object.values(this._dbObjectClasses)) {
     cls.prototype.constructor = Object;
     cls.prototype = null;
   }
-  this.emit('_after_close');
+  this.emit('_afterConnClose');
 }
 
 
@@ -217,7 +230,7 @@ async function getQueue(name, a2) {
     nodbUtil.assert(nodbUtil.isObject(a2), 'NJS-005', 2);
     options = a2;
   }
-  return await this._getQueue(name, options);
+  return (await this._getQueue(name, options));
 }
 
 
@@ -298,7 +311,7 @@ function buildDbObjectClass(schema, name, fqn) {
           this.append(initialValue[i]);
         }
       }
-      return proxy;
+      return (proxy);
     } else if (initialValue !== undefined) {
       Object.assign(this, initialValue);
     }
@@ -309,9 +322,147 @@ function buildDbObjectClass(schema, name, fqn) {
   DbObject.prototype.name = name;
   DbObject.prototype.fqn = fqn;
   DbObject.toString = function() {
-    return 'DbObjectClass [' + fqn + ']';
+    return ('DbObjectClass [' + fqn + ']');
   };
-  return DbObject;
+  return (DbObject);
+}
+
+//-----------------------------------------------------------------------------
+//  tpcBegin()
+//    Starts a two-phase-commit transaction
+//----------------------------------------------------------------------------
+async function tpcBegin(xid, flag, timeout) {
+  nodbUtil.checkArgCount(arguments, 1, 3);
+  nodbUtil.assert(nodbUtil.isXid(xid), 'NJS-005', 1);
+
+  if (arguments.length < 3) {
+    timeout = 60;   // seconds
+  } else {
+    nodbUtil.assert(typeof timeout === 'number', 'NJS-005', 3);
+  }
+
+  if (arguments.length < 2) {
+    flag = this._oracledb.TPC_BEGIN_NEW;
+  } else {
+    nodbUtil.assert(typeof flag === 'number', 'NJS-005', 2);
+  }
+  await this._tpcBegin(xid, flag, timeout);
+}
+
+
+//-----------------------------------------------------------------------------
+//  tpcCommit
+//    Commit the two-phase-commit transaction
+//-----------------------------------------------------------------------------
+async function tpcCommit(xid, onePhase) {
+  nodbUtil.checkArgCount(arguments, 0, 2);
+
+  if (arguments.length < 2) {
+    onePhase = false;
+  } else {
+    nodbUtil.assert(typeof onePhase === 'boolean', 'NJS-005', 2);
+  }
+  if (arguments.length >= 1) {
+    nodbUtil.assert(nodbUtil.isXid(xid), 'NJS-005', 1);
+  }
+  await this._tpcCommit(xid, onePhase);
+}
+
+
+//-----------------------------------------------------------------------------
+//  tpcEnd
+//    Ends the two-phase-commit transaction
+//-----------------------------------------------------------------------------
+async function tpcEnd(xid, flag) {
+  nodbUtil.checkArgCount(arguments, 0, 2);
+
+  if (arguments.length < 2) {
+    flag = this._oracledb.TPC_END_NORMAL;
+  } else {
+    nodbUtil.assert(typeof flag === 'number', 'NJS-005', 2);
+  }
+
+  if (arguments.length >= 1) {
+    nodbUtil.assert(nodbUtil.isXid(xid), 'NJS-005', 1);
+  }
+
+  await this._tpcEnd(xid, flag);
+}
+
+
+//-----------------------------------------------------------------------------
+//  tpcForget
+//    causes the server to forget a heuristically completed global transaction.
+//-----------------------------------------------------------------------------
+async function tpcForget(xid) {
+
+  nodbUtil.checkArgCount(arguments, 1, 1);
+  nodbUtil.assert(nodbUtil.isXid(xid), 'NJS-005', 1);
+
+  await this._tpcForget(xid);
+}
+
+
+//-----------------------------------------------------------------------------
+//  tpcPrepare
+//    prepares a global transaction for commit.
+//-----------------------------------------------------------------------------
+async function tpcPrepare(xid) {
+  nodbUtil.checkArgCount(arguments, 0, 1);
+
+  if (arguments.length >= 1) {
+    nodbUtil.assert(nodbUtil.isXid(xid), 'NJS-005', 1);
+  }
+
+  return await this._tpcPrepare(xid);
+}
+
+
+//-----------------------------------------------------------------------------
+//  tpcRecover
+//    Returns a list of pending transactions
+//-----------------------------------------------------------------------------
+async function tpcRecover(asString) {
+  nodbUtil.checkArgCount(arguments, 0, 1);
+
+  if (arguments.length == 1) {
+    nodbUtil.assert(typeof asString === 'boolean', 'NJS-005', 1);
+  } else {
+    asString = true;
+  }
+
+  const sqlStr = `
+    SELECT
+        formatid as "formatId",
+        UTL_RAW.CAST_TO_VARCHAR2(globalid) as "globalTransactionId",
+        UTL_RAW.CAST_TO_VARCHAR2(branchid) as "branchQualifier"
+    FROM DBA_PENDING_TRANSACTIONS`;
+  const sqlBuf = `
+    SELECT
+        formatid as "formatId",
+        globalid as "globalTransactionId",
+        branchid as "branchQualifier"
+    FROM DBA_PENDING_TRANSACTIONS`;
+  const options = {
+    outFormat: this._oracledb.OUT_FORMAT_OBJECT,
+  };
+
+  const result = await this._execute(asString ? sqlStr : sqlBuf, {}, options);
+  return result.resultSet._getAllRows(options, result.metaData, false);
+}
+
+
+//-----------------------------------------------------------------------------
+//  tpcRollback()
+//    Rollbacks the current changes in two-phase-commit
+//-----------------------------------------------------------------------------
+async function tpcRollback(xid) {
+  nodbUtil.checkArgCount(arguments, 0, 1);
+  if (arguments.length == 1) {
+    nodbUtil.assert(nodbUtil.isXid(xid), 'NJS-005', 1);
+  }
+
+  await this._tpcRollback(xid);
 }
 
 
@@ -321,28 +472,55 @@ class Connection extends EventEmitter {
   constructor() {
     super();
     this._dbObjectClasses = {};
+    this._requestQueue = [];
+    this._inProgress = false;
+    this._closing = false;
   }
 
   // extend class with promisified functions
   _extend(oracledb) {
     this._oracledb = oracledb;
-    this.break = nodbUtil.callbackify(module.break);
-    this.changePassword = nodbUtil.callbackify(changePassword);
-    this.close = nodbUtil.callbackify(close);
-    this.commit = nodbUtil.callbackify(commit);
-    this.createLob = nodbUtil.callbackify(createLob);
-    this.execute = nodbUtil.callbackify(execute);
-    this.executeMany = nodbUtil.callbackify(executeMany);
-    this.getDbObjectClass = nodbUtil.callbackify(getDbObjectClass);
-    this.getQueue = nodbUtil.callbackify(getQueue);
-    this.getStatementInfo = nodbUtil.callbackify(getStatementInfo);
-    this.ping = nodbUtil.callbackify(ping);
-    this.release = nodbUtil.callbackify(close);
-    this.rollback = nodbUtil.callbackify(rollback);
-    this.shutdown = nodbUtil.callbackify(shutdown);
-    this.startup = nodbUtil.callbackify(startup);
-    this.subscribe = nodbUtil.callbackify(subscribe);
-    this.unsubscribe = nodbUtil.callbackify(unsubscribe);
+    this.break = nodbUtil.callbackify(module.break);  // should not be serialized
+    this.changePassword = nodbUtil.callbackify(nodbUtil.serialize(changePassword));
+    this.close = nodbUtil.callbackify(nodbUtil.serialize(close));
+    this.commit = nodbUtil.callbackify(nodbUtil.serialize(commit));
+    this.createLob = nodbUtil.callbackify(nodbUtil.serialize(createLob));
+    this.execute = nodbUtil.callbackify(nodbUtil.serialize(execute));
+    this.executeMany = nodbUtil.callbackify(nodbUtil.serialize(executeMany));
+    this.getDbObjectClass = nodbUtil.callbackify(nodbUtil.serialize(getDbObjectClass));
+    this.getQueue = nodbUtil.callbackify(nodbUtil.serialize(getQueue));
+    this.getStatementInfo = nodbUtil.callbackify(nodbUtil.serialize(getStatementInfo));
+    this.ping = nodbUtil.callbackify(nodbUtil.serialize(ping));
+    this.release = nodbUtil.callbackify(nodbUtil.serialize(close));
+    this.rollback = nodbUtil.callbackify(nodbUtil.serialize(rollback));
+    this.shutdown = nodbUtil.callbackify(nodbUtil.serialize(shutdown));
+    this.startup = nodbUtil.callbackify(nodbUtil.serialize(startup));
+    this.subscribe = nodbUtil.callbackify(nodbUtil.serialize(subscribe));
+    this.tpcBegin = nodbUtil.callbackify(nodbUtil.serialize(tpcBegin));
+    this.tpcCommit = nodbUtil.callbackify(nodbUtil.serialize(tpcCommit));
+    this.tpcEnd = nodbUtil.callbackify(nodbUtil.serialize(tpcEnd));
+    this.tpcForget = nodbUtil.callbackify(nodbUtil.serialize(tpcForget));
+    this.tpcPrepare = nodbUtil.callbackify(nodbUtil.serialize(tpcPrepare));
+    this.tpcRecover = nodbUtil.callbackify(nodbUtil.serialize(tpcRecover));
+    this.tpcRollback = nodbUtil.callbackify(nodbUtil.serialize(tpcRollback));
+    this.unsubscribe = nodbUtil.callbackify(nodbUtil.serialize(unsubscribe));
+  }
+
+  async _acquireLock() {
+    if (this._inProgress) {
+      if (this._oracledb.errorOnConcurrentExecute) {
+        throw new Error(nodbUtil.getErrorMessage('NJS-081'));
+      }
+      await new Promise((resolve, reject) => {
+        const payload = {resolve: resolve, reject: reject};
+        this._requestQueue.push(payload);
+      });
+    }
+    this._inProgress = true;
+  }
+
+  _getConnection() {
+    return this;
   }
 
   _getDbObjectClassJS(schema, name) {
@@ -350,22 +528,44 @@ class Connection extends EventEmitter {
     let cls = this._dbObjectClasses[fqn];
     if (!cls) {
       cls = buildDbObjectClass(schema, name, fqn);
+      cls._connection = this;
       this._dbObjectClasses[fqn] = cls;
     }
-    return cls;
+    return (cls);
   }
 
   _isDate(val) {
-    return util.isDate(val);
+    return (util.isDate(val));
+  }
+
+  _releaseLock() {
+    if (this._requestQueue.length > 0) {
+      const payload = this._requestQueue.shift();
+      payload.resolve();
+    } else {
+      this._inProgress = false;
+    }
   }
 
   // To obtain a SodaDatabase object (high-level SODA object associated with
   // current connection)
   getSodaDatabase() {
     nodbUtil.checkArgCount(arguments, 0, 0);
-    return this._getSodaDatabase();
+    return (this._getSodaDatabase());
   }
 
+  //--------------------------------------------------------------------------
+  //  isHealthy()
+  //    To get the health status of the connection.
+  //  NOTE: if this function returns false, the application must close the
+  //        connection obect.
+  //        This is a synchronous call.
+  //---------------------------------------------------------------------------
+  isHealthy() {
+    return (!this._closing && this._isHealthy());
+  }
+
+
   // The queryStream function is similar to execute except that it immediately
   // returns a QueryStream.
   queryStream(sql, binding, options) {
@@ -408,7 +608,7 @@ class Connection extends EventEmitter {
       }
     });
 
-    return stream;
+    return (stream);
   }
 
 }

package/lib/dbObject.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, Oracle and/or its affiliates.  All rights reserved.
+// Copyright (c) 2019, 2022, Oracle and/or its affiliates.
 //
 //----------------------------------------------------------------------------
 //
@@ -51,7 +51,7 @@ class BaseDbObject {
           result[i] = result[i]._toPojo();
         }
       }
-      return result;
+      return (result);
     }
     const result = {};
     for (let name in this.attributes) {
@@ -61,18 +61,18 @@ class BaseDbObject {
       }
       result[name] = value;
     }
-    return result;
+    return (result);
   }
 
   // custom inspection routine
   [util.inspect.custom](depth, options) {
-    return '[' + this.fqn + '] ' + util.inspect(this._toPojo(), options);
+    return ('[' + this.fqn + '] ' + util.inspect(this._toPojo(), options));
   }
 
   [Symbol.iterator]() {
     if (this.isCollection) {
       const values = this.getValues();
-      return values[Symbol.iterator]();
+      return (values[Symbol.iterator]());
     }
     throw TypeError("obj is not iterable");
   }
@@ -80,18 +80,18 @@ class BaseDbObject {
   [Symbol.toPrimitive](hint) {
     switch (hint) {
       case 'number':
-        return NaN;
+        return (NaN);
       default:
-        return '[' + this.fqn + '] ' + util.inspect(this._toPojo(), {});
+        return ('[' + this.fqn + '] ' + util.inspect(this._toPojo(), {}));
     }
   }
 
   get [Symbol.toStringTag]() {
-    return this.fqn;
+    return (this.fqn);
   }
 
   toJSON() {
-    return this._toPojo();
+    return (this._toPojo());
   }
 
 }
@@ -104,10 +104,10 @@ BaseDbObject._collectionProxyHandler = {
     if (typeof prop === 'string') {
       const index = +prop;
       if (!isNaN(index)) {
-        return target.deleteElement(index);
+        return (target.deleteElement(index));
       }
     }
-    return delete target[prop];
+    return (delete target[prop]);
   },
 
   get(target, prop) {
@@ -118,18 +118,18 @@ BaseDbObject._collectionProxyHandler = {
       // available when calling napi_unwrap() on the target; this property
       // forces the target to get returned
       if (prop === '_target') {
-        return target;
+        return (target);
       }
       const index = +prop;
       if (!isNaN(index)) {
-        return target.getElement(index);
+        return (target.getElement(index));
       }
     }
     const value = target[prop];
     if (typeof value === 'function') {
-      return value.bind(target);
+      return (value.bind(target));
     }
-    return value;
+    return (value);
   },
 
   set(target, prop, value) {
@@ -137,11 +137,11 @@ BaseDbObject._collectionProxyHandler = {
       const index = +prop;
       if (!isNaN(index)) {
         target.setElement(index, value);
-        return true;
+        return (true);
       }
     }
     target[prop] = value;
-    return true;
+    return (true);
   }
 
 };