openzoo 0.49.10 → 0.49.11

package/lib/launch.js

@@ -68,15 +68,63 @@ export function claudeCodeBinDirs(home = os.homedir()) {
   ];
 }
 
-/** Resolve the Claude Code TERMINAL CLI. */
-export function resolveClaudeCli(env = process.env) {
+/**
+ * Is this file something execvp can actually RUN?
+ *
+ * The +x bit says "you are allowed to run this", not "this is runnable". A
+ * truncated download, a half-written install, or a plain text stub all carry
+ * the bit happily, and execvp then fails with ENOEXEC — which surfaced to a
+ * user as the bare string `openzoo: spawn ENOEXEC` with no path, no cause, and
+ * nothing to act on. A script is runnable when it starts with a shebang; a
+ * binary when it carries a known image magic. Anything else is a bad candidate
+ * and we should keep looking rather than hand it to spawn.
+ */
+export function isRunnableExecutable(file) {
+  let fd;
+  try {
+    fd = fs.openSync(file, 'r');
+    const buf = Buffer.alloc(4);
+    const n = fs.readSync(fd, buf, 0, 4, 0);
+    if (n < 2) return false;                              // empty/truncated
+    if (buf[0] === 0x23 && buf[1] === 0x21) return true;  // "#!"  script
+    if (buf[0] === 0x4d && buf[1] === 0x5a) return true;  // "MZ"  PE (win)
+    if (n < 4) return false;
+    const be = buf.readUInt32BE(0);
+    if (be === 0x7f454c46) return true;                   // ELF
+    // Mach-O thin (32/64, either endianness) and universal/fat.
+    if (be === 0xfeedface || be === 0xfeedfacf) return true;
+    if (be === 0xcefaedfe || be === 0xcffaedfe) return true;
+    if (be === 0xcafebabe || be === 0xbebafeca) return true;
+    return false;
+  } catch {
+    return false;
+  } finally {
+    if (fd !== undefined) { try { fs.closeSync(fd); } catch { /* ignore */ } }
+  }
+}
+
+/**
+ * Resolve the Claude Code TERMINAL CLI.
+ *
+ * NOTE THE SEARCH ORDER: claudeCodeBinDirs() is tried BEFORE $PATH, because a
+ * Finder-launched process has no shell PATH. The cost is that a broken
+ * ~/.local/bin/claude — the exact file a half-finished install leaves behind —
+ * outranks a working one further down $PATH. So candidates are now format
+ * checked, and a rejected one does not stop the search; it is recorded so the
+ * caller can say WHICH file was wrong instead of printing an errno.
+ */
+export function resolveClaudeCli(env = process.env, rejected = []) {
   const name = 'claude' + (process.platform === 'win32' ? '.cmd' : '');
   const extras = env.OPENZOO_CLAUDE_PATH_ONLY === '1' ? [] : claudeCodeBinDirs();
   const pathDirs = String(env.PATH || '').split(path.delimiter).filter(Boolean);
   for (const dir of [...new Set([...extras, ...pathDirs])]) {
     if (!dir) continue;
     const f = path.join(dir, name);
-    try { fs.accessSync(f, fs.constants.X_OK); return f; } catch { /* next */ }
+    try { fs.accessSync(f, fs.constants.X_OK); } catch { continue; }
+    // A .cmd shim on Windows is dispatched by the shell, not execvp, so the
+    // magic-number test does not apply there.
+    if (process.platform === 'win32' || isRunnableExecutable(f)) return f;
+    rejected.push(f);
   }
   return null;
 }
@@ -231,8 +279,21 @@ export async function launchClaude(argv) {
   const env = claudeZooEnv(process.env, { base });
 
   if (terminal) {
-    const cli = resolveClaudeCli();
-    if (!cli) { console.error('openzoo: `claude` CLI not found on PATH — install Claude Code, or drop --terminal for the desktop app'); process.exit(1); }
+    const rejected = [];
+    const cli = resolveClaudeCli(process.env, rejected);
+    if (!cli) {
+      if (rejected.length) {
+        // Found it, could not run it. Say so — "not found on PATH" is a lie
+        // here and sends the user off to reinstall something they already have.
+        console.error('openzoo: found `claude` but it is not a runnable executable:');
+        for (const f of rejected) console.error(`         ${f}`);
+        console.error('         (no shebang and no binary magic — usually a truncated or half-finished install)');
+        console.error('         fix: reinstall Claude Code, or delete the broken file so another copy on PATH is used.');
+      } else {
+        console.error('openzoo: `claude` CLI not found on PATH — install Claude Code, or drop --terminal for the desktop app');
+      }
+      process.exit(1);
+    }
     // ALWAYS-ON HUD via Claude Code's NATIVE status line (the title bar is owned
     // by Claude Code and gets overwritten, so OSC there is useless). We write a
     // tiny status script that reads the proxy's /v1/info, and merge a statusLine
@@ -350,9 +411,38 @@ export async function launchClaude(argv) {
     console.error('     spend    : live in the status line below (bottom of screen); receipts in ~/.openzoo/proxy.log');
     console.error('     every turn pays x402.');
     console.error('');
-    const child = spawn(cli, rest, { stdio: 'inherit', env });
+    // spawn() THROWS SYNCHRONOUSLY on ENOEXEC — the 'error' listener below is
+    // never reached, which is why this reached a user as the unprefixed
+    // `openzoo: spawn ENOEXEC` from the top-level handler. Catch it here where
+    // `cli` is in scope and the message can name the file.
+    let child;
+    try {
+      child = spawn(cli, rest, { stdio: 'inherit', env });
+    } catch (e) {
+      try { restoreStatus?.(); } catch { /* ignore */ }
+      console.error(`openzoo: cannot execute ${cli} (${e?.code || e?.message})`);
+      console.error('         it is marked executable but the OS refused to run it.');
+      console.error(`         check: head -1 ${cli}   and   file ${cli}`);
+      console.error('         usually a truncated install, a wrong-architecture binary,');
+      console.error('         or a shebang pointing at an interpreter that no longer exists.');
+      process.exit(1);
+    }
     child.on('exit', (c) => { try { restoreStatus?.(); } catch { /* ignore */ } process.exit(c ?? 0); });
-    child.on('error', (e) => { console.error(`openzoo: could not launch claude: ${e.message}`); process.exit(1); });
+    child.on('error', (e) => {
+      // ENOEXEC reaches here only if the format check passed and the kernel
+      // still refused it — a wrong-architecture binary, or a shebang pointing
+      // at an interpreter that is gone. Name the file either way; the bare
+      // errno is unactionable.
+      if (e?.code === 'ENOEXEC' || e?.code === 'EACCES') {
+        console.error(`openzoo: cannot execute ${cli} (${e.code})`);
+        console.error('         the file exists and is marked executable, but the OS refused to run it.');
+        console.error(`         check: head -1 ${cli}   and   file ${cli}`);
+        console.error('         a shebang pointing at a missing interpreter (e.g. a removed node) does this.');
+      } else {
+        console.error(`openzoo: could not launch claude (${cli}): ${e.message}`);
+      }
+      process.exit(1);
+    });
     return;
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openzoo",
-  "version": "0.49.10",
+  "version": "0.49.11",
   "description": "Local x402-paying proxy + MCP server for openzoo.fun — point any OpenAI-compatible harness (Cursor, Claude Code, aider, SDKs) at localhost and it pays per call from a local burner wallet. Solana and Base rails live; Robinhood experimental.",
   "license": "MIT",
   "type": "module",