openxiangda 1.0.230 → 1.0.231

package/lib/cli.js

@@ -16309,7 +16309,12 @@ function removeDirectStateResource(target, resourceType, code) {
 function normalizeMenuDirectBody(bound, menuItem) {
   const formUuid = resolveManifestFormUuid(bound, menuItem);
   const pageId = resolveManifestPageId(bound, menuItem);
-  const parentId = resolveManifestMenuId(bound, menuItem.parentCode) || menuItem.parentId || null;
+  const parentId = requireResolvedMenuParentId(
+    bound,
+    menuItem,
+    new Map(),
+    'direct menu mutation'
+  );
   return stripUndefinedValues({
     resourceCode: menuItem.code || menuItem.resourceCode,
     name: menuItem.name || menuItem.code,
@@ -19087,7 +19092,19 @@ async function buildResourcePlan(
   ]);
   const actions = [];
   addPlanActions(actions, 'role', manifest.roles, existing.roles, roleEquals);
-  addPlanActions(actions, 'menu', manifest.menus, existing.menus, (item, current) => menuEquals(target.bound, item, current));
+  const orderedMenus = orderMenuResourcesForPublish(
+    manifest.menus,
+    target.bound,
+    existing.menus
+  );
+  addPlanActions(
+    actions,
+    'menu',
+    orderedMenus,
+    existing.menus,
+    (item, current) =>
+      menuEquals(target.bound, item, current, existing.menus)
+  );
   addPlanActions(actions, 'connector', manifest.connectors, existing.connectors, connectorEquals);
   addNotificationPlanActions(target, actions, manifest.notifications || [], existing);
   await addWorkflowPlanActions(config, target, actions, manifest.workflows, existing.workflows);
@@ -22594,21 +22611,61 @@ async function publishFormSettingsResources(
 }
 
 async function publishMenuResources(config, target, menus, result, options = {}) {
-  for (const menuItem of menus) {
-    if (shouldSkipNoopResource(options, 'menu', menuItem.code)) {
-      recordNoopResource(result, 'menu', menuItem.code, options);
+  if (menus.length === 0) return;
+  const existingMenus = await fetchExistingMenusByCode(config, target);
+  const orderedMenus = orderMenuResourcesForPublish(
+    menus,
+    target.bound,
+    existingMenus
+  );
+  for (const menuItem of orderedMenus) {
+    const code = menuResourceCode(menuItem);
+    const plannedAction = getPlannedResourceAction(options, 'menu', code);
+    const existing = existingMenus.get(code);
+    if (existing && !menuPlatformId(existing)) {
+      const error = new Error(
+        `MENU_ONLINE_ID_REQUIRED: 在线 menu ${code} 缺少 menuId，禁止执行恢复发布`
+      );
+      error.code = 'MENU_ONLINE_ID_REQUIRED';
+      throw error;
+    }
+    if (
+      ['noop', 'update'].includes(plannedAction?.action) &&
+      !menuPlatformId(existing)
+    ) {
+      const error = new Error(
+        `MENU_PLAN_TARGET_MISSING: menu ${code} 的冻结计划为 ${plannedAction.action}，但写入前在线菜单已不存在`
+      );
+      error.code = 'MENU_PLAN_TARGET_MISSING';
+      throw error;
+    }
+  }
+  for (const menuItem of orderedMenus) {
+    const code = menuResourceCode(menuItem);
+    const existing = existingMenus.get(code);
+    if (shouldSkipNoopResource(options, 'menu', code)) {
+      const existingId = menuPlatformId(existing);
+      saveMenuResource(target, code, existingId, {
+        formUuid: existing.formUuid,
+        pageId: existing.pageId,
+        parentId: existing.parentId,
+        routeCode: existing.routeCode,
+        path: existing.path,
+      });
+      recordNoopResource(result, 'menu', code, options);
       continue;
     }
-    const existing = await findExistingMenu(config, target, menuItem.code);
     const formUuid = resolveManifestFormUuid(target.bound, menuItem);
     const pageId = resolveManifestPageId(target.bound, menuItem);
-    const parentId =
-      resolveManifestMenuId(target.bound, menuItem.parentCode) ||
-      menuItem.parentId ||
-      null;
+    const parentId = requireResolvedMenuParentId(
+      target.bound,
+      menuItem,
+      existingMenus,
+      `resource publish menu ${code}`
+    );
     const body = {
-      resourceCode: menuItem.code,
-      name: menuItem.name || menuItem.code,
+      resourceCode: code,
+      name: menuItem.name || code,
       type: menuItem.type || 'nav',
       formUuid,
       pageId,
@@ -22619,11 +22676,12 @@ async function publishMenuResources(config, target, menus, result, options = {})
       routeCode: menuItem.routeCode || null,
       path: menuItem.path || null,
     };
+    const existingId = menuPlatformId(existing);
     let data = existing
       ? await requestWithAuth(
           config,
           target.profileName,
-          `/openxiangda-api/v1/apps/${encodeURIComponent(target.appType)}/menus/${encodeURIComponent(existing.id)}`,
+          `/openxiangda-api/v1/apps/${encodeURIComponent(target.appType)}/menus/${encodeURIComponent(existingId)}`,
           { method: 'POST', body }
         )
       : await requestWithAuth(
@@ -22632,37 +22690,54 @@ async function publishMenuResources(config, target, menus, result, options = {})
           `/openxiangda-api/v1/apps/${encodeURIComponent(target.appType)}/menus`,
           { method: 'POST', body }
         );
-    if (data?.id) {
-      saveMenuResource(target, menuItem.code, data.id, {
-        resourceCode: menuItem.code,
-        name: data.name,
-        type: data.type,
-        ...(formUuid ? { formUuid } : {}),
-        ...(pageId ? { pageId } : {}),
-        ...(menuItem.pageCode ? { pageCode: menuItem.pageCode } : {}),
-        ...(menuItem.routeCode || data.routeCode
-          ? { routeCode: data.routeCode || menuItem.routeCode }
-          : {}),
-        ...(menuItem.path || data.path ? { path: data.path || menuItem.path } : {}),
-      });
+    if (!data?.id) {
+      const error = new Error(
+        `MENU_WRITE_ID_REQUIRED: menu ${code} 写入成功响应缺少 menuId，禁止继续发布子菜单`
+      );
+      error.code = 'MENU_WRITE_ID_REQUIRED';
+      throw error;
     }
-    result.published.push({ kind: 'menu', code: menuItem.code, action: existing ? 'update' : 'create', id: data?.id });
+    saveMenuResource(target, code, data.id, {
+      resourceCode: code,
+      name: data.name,
+      type: data.type,
+      ...(formUuid ? { formUuid } : {}),
+      ...(pageId ? { pageId } : {}),
+      ...(menuItem.pageCode ? { pageCode: menuItem.pageCode } : {}),
+      ...(menuItem.routeCode || data.routeCode
+        ? { routeCode: data.routeCode || menuItem.routeCode }
+        : {}),
+      ...(menuItem.path || data.path ? { path: data.path || menuItem.path } : {}),
+      parentId: data.parentId || parentId,
+    });
+    existingMenus.set(code, {
+      ...(existing || {}),
+      ...body,
+      ...data,
+      id: data.id,
+    });
+    result.published.push({
+      kind: 'menu',
+      code,
+      action: existing ? 'update' : 'create',
+      id: data?.id,
+    });
   }
 }
 
-async function findExistingMenu(config, target, code) {
+async function fetchExistingMenusByCode(config, target) {
   const data = await requestWithAuth(
     config,
     target.profileName,
     `/openxiangda-api/v1/apps/${encodeURIComponent(target.appType)}/menus`
   );
-  const items = flattenItems(normalizeItems(data));
-  const stateId = target.bound.resources?.menus?.[code]?.menuId;
-  if (stateId) {
-    const byState = items.find(item => item.id === stateId);
-    if (byState) return byState;
-  }
-  return items.find(item => item.resourceCode === code);
+  const menus = new Map();
+  indexByCode(
+    menus,
+    flattenItems(normalizeItems(data)),
+    item => item.resourceCode
+  );
+  return menus;
 }
 
 async function publishConnectorResources(config, target, connectors, result, options = {}) {
@@ -26026,7 +26101,123 @@ function resolveManifestPageId(bound, item) {
 
 function resolveManifestMenuId(bound, menuCode) {
   if (!menuCode) return undefined;
-  return bound.resources?.menus?.[menuCode]?.menuId || menuCode;
+  return bound.resources?.menus?.[menuCode]?.menuId;
+}
+
+function menuResourceCode(menuItem) {
+  return String(menuItem?.code || menuItem?.resourceCode || '').trim();
+}
+
+function menuPlatformId(menuItem) {
+  const value = menuItem?.id || menuItem?.menuId;
+  return value ? String(value) : undefined;
+}
+
+function resolveMenuParentId(bound, menuItem, existingMenus = new Map()) {
+  const parentCode = String(menuItem?.parentCode || '').trim();
+  if (!parentCode) return menuItem?.parentId || null;
+  const boundId = resolveManifestMenuId(bound, parentCode);
+  const onlineId = menuPlatformId(existingMenus.get(parentCode));
+  return onlineId || boundId || menuItem?.parentId;
+}
+
+function menuParentResolutionError(code, parentCode, label) {
+  const error = new Error(
+    `MENU_PARENT_UNRESOLVED: ${label || `menu ${code}`} 无法将 parentCode ${parentCode} 解析为在线 menuId`
+  );
+  error.code = 'MENU_PARENT_UNRESOLVED';
+  return error;
+}
+
+function requireResolvedMenuParentId(
+  bound,
+  menuItem,
+  existingMenus = new Map(),
+  label
+) {
+  const parentId = resolveMenuParentId(bound, menuItem, existingMenus);
+  if (menuItem?.parentCode && !parentId) {
+    throw menuParentResolutionError(
+      menuResourceCode(menuItem),
+      menuItem.parentCode,
+      label
+    );
+  }
+  return parentId || null;
+}
+
+function orderMenuResourcesForPublish(
+  menus = [],
+  bound = {},
+  existingMenus = new Map()
+) {
+  const items = Array.isArray(menus) ? menus : [];
+  const byCode = new Map();
+  const sourceIndex = new Map();
+  for (const [index, menuItem] of items.entries()) {
+    const code = menuResourceCode(menuItem);
+    if (!code) {
+      const error = new Error('MENU_CODE_REQUIRED: menu resource 缺少 code');
+      error.code = 'MENU_CODE_REQUIRED';
+      throw error;
+    }
+    if (byCode.has(code)) {
+      const error = new Error(`MENU_CODE_DUPLICATE: menu code ${code} 重复`);
+      error.code = 'MENU_CODE_DUPLICATE';
+      throw error;
+    }
+    byCode.set(code, menuItem);
+    sourceIndex.set(code, index);
+  }
+
+  const children = new Map();
+  const indegree = new Map([...byCode.keys()].map(code => [code, 0]));
+  for (const [code, menuItem] of byCode) {
+    const parentCode = String(menuItem.parentCode || '').trim();
+    if (!parentCode) continue;
+    if (!byCode.has(parentCode)) {
+      if (!resolveMenuParentId(bound, menuItem, existingMenus)) {
+        throw menuParentResolutionError(code, parentCode, `menu ${code}`);
+      }
+      continue;
+    }
+    indegree.set(code, indegree.get(code) + 1);
+    const siblings = children.get(parentCode) || [];
+    siblings.push(code);
+    children.set(parentCode, siblings);
+  }
+
+  const bySourceOrder = (left, right) =>
+    sourceIndex.get(left) - sourceIndex.get(right);
+  const ready = [...indegree.entries()]
+    .filter(([, count]) => count === 0)
+    .map(([code]) => code)
+    .sort(bySourceOrder);
+  const ordered = [];
+  while (ready.length > 0) {
+    const code = ready.shift();
+    ordered.push(byCode.get(code));
+    for (const childCode of (children.get(code) || []).sort(bySourceOrder)) {
+      const next = indegree.get(childCode) - 1;
+      indegree.set(childCode, next);
+      if (next === 0) {
+        ready.push(childCode);
+        ready.sort(bySourceOrder);
+      }
+    }
+  }
+  if (ordered.length !== items.length) {
+    const cycleCodes = [...indegree.entries()]
+      .filter(([, count]) => count > 0)
+      .map(([code]) => code)
+      .sort(bySourceOrder);
+    const error = new Error(
+      `MENU_PARENT_CYCLE: menu parentCode 存在循环依赖: ${cycleCodes.join(' -> ')}`
+    );
+    error.code = 'MENU_PARENT_CYCLE';
+    throw error;
+  }
+  return ordered;
 }
 
 function resolveAutomationManifestPayload(target, automationItem) {
@@ -26178,12 +26369,16 @@ function unwrapFormSettingPlanValue(value, key) {
   return value;
 }
 
-function menuEquals(bound, desired, existing) {
+function menuEquals(bound, desired, existing, existingMenus = new Map()) {
   if (!existing) return false;
   const desiredFormUuid = resolveManifestFormUuid(bound, desired);
   const desiredPageId = resolveManifestPageId(bound, desired);
-  const desiredParentId =
-    resolveManifestMenuId(bound, desired.parentCode) || desired.parentId || null;
+  const desiredParentId = resolveMenuParentId(
+    bound,
+    desired,
+    existingMenus
+  );
+  if (desired.parentCode && !desiredParentId) return false;
   return (
     String(existing.name || '') === String(desired.name || desired.code || '') &&
     String(existing.type || '') === String(desired.type || 'nav') &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openxiangda",
-  "version": "1.0.230",
+  "version": "1.0.231",
   "description": "OpenXiangda CLI, workspace build tools, runtime SDK, and form components.",
   "private": false,
   "bin": {