openvisio-agent 0.7.0 → 0.8.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openvisio-agent",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "description": "Connect your coding agent (Claude Code) to an OpenVisio team — MCP tools + optional autonomy — in one command. No shell scripts.",
   "type": "module",
   "bin": {

package/src/watch.mjs

@@ -5,7 +5,7 @@
 // than written to disk from a pasted heredoc.
 
 import { spawn, spawnSync } from 'node:child_process'
-import { writeFileSync, mkdirSync, existsSync } from 'node:fs'
+import { writeFileSync, mkdirSync, existsSync, readFileSync, unlinkSync } from 'node:fs'
 import { homedir } from 'node:os'
 import { join, dirname } from 'node:path'
 import { OV_DIR, DEFAULT_WORKSPACE, readConfig, writeJson, configPath, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
@@ -29,6 +29,7 @@ const REPLY_DISCIPLINE = [
   '  • IS IT FOR YOU? Act ONLY on messages addressed to YOU — an @mention of your exact name, a direct question to you, or a reply to something YOU said or did. If a DIFFERENT agent or person was @mentioned or asked to do something, STAY OUT: do not answer for them and do not pick up their task. When it is not yours, posting nothing is the correct move.',
   '  • NO DUPLICATES. Before you post, scan the recent thread/channel for what YOU already said. If you already replied to or acknowledged this exact request, do NOT post again. One acknowledgement per task; one answer per question. While a task is in progress, post again ONLY when you have something genuinely NEW (a result, a link, a real blocker) — never re-post "on it".',
   '  • BE SURE BEFORE YOU SPEAK. Do not claim something is possible, done, or broken until you have actually verified it — call the tool, read the code, check the real state. Never assert then contradict yourself. If you are unsure, verify FIRST, then give ONE clear, final answer instead of thinking out loud across several messages.',
+  '  • NO INVENTED HISTORY. You have NO memory beyond the messages visible in THIS thread and what your tools return right now. Never fabricate past events, competitions, conversations, results, links, PR numbers, deploy URLs, or figures. If you are asked about something you have no actual record of, say plainly "I don\'t have a record of that" — do NOT make one up to play along or be helpful. Only state things you can see or verify.',
 ].join('\n')
 
 // ── CHAT-ONLY agents (no --workdir): chat/ticket tools, no code surface. ──────
@@ -131,6 +132,29 @@ const SESSION_IDLE_MS = 1200000
 const MAX_CYCLE_MS = 240000
 const MAX_CODE_CYCLE_MS = 900000
 
+// Refuse to run a SECOND watcher for the same agent. Two watchers connect to the
+// WS as the same agent and BOTH reply to every mention — the #1 cause of duplicate
+// (and contradicting, if the two are different versions) messages. A pid lock file
+// in ~/.openvisio makes the second start fail fast instead. Stale locks (dead pid)
+// are taken over. Returns { release } or { conflict: <pid> }.
+function acquireSingleInstance(key) {
+  const lockPath = join(OV_DIR, 'watch-' + key + '.lock')
+  try {
+    mkdirSync(OV_DIR, { recursive: true })
+    if (existsSync(lockPath)) {
+      const pid = parseInt(String(readFileSync(lockPath, 'utf8')).trim(), 10)
+      if (pid && pid !== process.pid) {
+        let alive = false
+        try { process.kill(pid, 0); alive = true } catch (e) { alive = !!(e && e.code === 'EPERM') }
+        if (alive) return { conflict: pid }
+      }
+    }
+    writeFileSync(lockPath, String(process.pid))
+  } catch { /* if the lock can't be written, don't block the agent from running */ }
+  const release = () => { try { if (parseInt(String(readFileSync(lockPath, 'utf8')).trim(), 10) === process.pid) unlinkSync(lockPath) } catch { /* already gone */ } }
+  return { release }
+}
+
 export async function runWatch({ flags }) {
   const slug = flags.name ? slugify(String(flags.name)) : null
   const saved = slug ? readConfig(slug) : null
@@ -161,6 +185,19 @@ export async function runWatch({ flags }) {
   const model = String(flags.model || (saved && saved.model) || (agent === 'opencode' ? '' : 'sonnet'))
   const chatModel = String(flags['chat-model'] || (saved && saved.chatModel) || '')
 
+  // ONE watcher per agent. A second one (e.g. a manual `watch` alongside the
+  // background service, or a stale service) is the #1 cause of duplicate replies:
+  // both connect as the same agent and both answer every mention. Refuse to start.
+  if (!flags.install) {
+    const lock = acquireSingleInstance(slug || 'openvisio')
+    if (lock.conflict) {
+      fail(`Another openvisio-agent watcher for "${slug || 'openvisio'}" is already running (pid ${lock.conflict}).\n` +
+        `  Two watchers for the same agent BOTH reply to every mention — that is what causes duplicate/contradicting messages.\n` +
+        `  Stop the other one (kill ${lock.conflict}), or rely on ONLY the background service. Refusing to start a second.`)
+    }
+    process.on('exit', () => { try { lock.release && lock.release() } catch { /* noop */ } })
+  }
+
   // Backend agents (connect --backend) drive autonomy over a real-time WS instead
   // of REST-polling the frontend relay. Detected by the saved mode / a --ws flag.
   const backendMode = (saved && saved.mode === 'backend') || !!flags.ws
@@ -239,7 +276,7 @@ function createOpencodeRunner({ mcpUrl, mcpHeaders, cfgKey, workdir, canCode, ma
 // ── Claude Code warm-session cycle runner (shared by the REST + WS loops) ─────
 // One persistent stream-json session, poked with a prompt per cycle. Recycled
 // after MAX_TURNS or SESSION_IDLE_MS. Returns { runCycle, canCode }.
-function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, mcpConfig, workdir, log, debug, model }) {
+function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, mcpConfig, workdir, log, debug, model, onTool }) {
   const canCode = !!workdir
   const maxCycleMs = canCode ? MAX_CODE_CYCLE_MS : MAX_CYCLE_MS
   // opencode drives cycles differently — a headless `opencode run` per cycle rather
@@ -291,6 +328,10 @@ function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, mcpConfi
         if (!line.trim()) continue
         let o; try { o = JSON.parse(line) } catch { continue }
         if (debug) logEvent(o)
+        // Surface tool calls (e.g. post_message) so the loop can emit a live status.
+        if (onTool && o.type === 'assistant' && o.message && Array.isArray(o.message.content)) {
+          for (const b of o.message.content) if (b.type === 'tool_use' && b.name) { try { onTool(b.name) } catch { /* status is best-effort */ } }
+        }
         if (o.type === 'result') { log('cycle done (' + (o.subtype || 'ok') + (o.is_error ? ' · ERROR' : '') + ')'); settleTurn(o) }
       }
     })
@@ -341,7 +382,17 @@ function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, mcpConfi
 // stack up N sessions. Plus a one-time intro on first connect and a daily catch-up sweep.
 function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConfig, mcpUrl, workdir, model, chatModel, debug }) {
   const log = (m) => process.stdout.write('[ws ' + new Date().toISOString() + '] ' + m + '\n')
-  const { runCycle, canCode } = createCycleRunner({ claude, agent, mcpUrl, mcpHeaders: { 'x-agent-api-key': apiKey, 'x-agent-identifier': identifier }, cfgKey: identifier, mcpConfig, workdir, log, debug, model })
+  let handle = null
+  // Channels the agent is actively working in this cycle — drives the live
+  // agent:status broadcast (thinking → working → typing → done).
+  const statusTargets = new Set()
+  const emitStatus = (state) => { for (const c of statusTargets) { try { handle && handle.sendStatus(c, state) } catch { /* best-effort */ } } }
+  const { runCycle, canCode } = createCycleRunner({
+    claude, agent, mcpUrl, mcpHeaders: { 'x-agent-api-key': apiKey, 'x-agent-identifier': identifier },
+    cfgKey: identifier, mcpConfig, workdir, log, debug, model,
+    // The moment the agent calls post_message it is about to speak → "typing".
+    onTool: (name) => { if (/post_message/.test(name)) emitStatus('typing') },
+  })
   const fullPrompt = canCode ? CODE_FULL : CYCLE
   const fastPrompt = canCode ? CODE_FAST : CYCLE_FAST
   // Live model state — changeable at runtime by the in-chat `/model` command.
@@ -352,7 +403,6 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
 
   let busy = false
   let queued = null // 'full' | 'fast' | 'sweep' | 'intro' — a cycle requested while one was running
-  let handle = null
   // Tasks we've already reacted to (keyed task-id:agent — so a REASSIGNMENT to a
   // different agent re-triggers), so a noisy stream of task:updated events doesn't
   // re-acknowledge the same assignment.
@@ -386,9 +436,16 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
     // work (full/sweep) uses the main model.
     const useModel = (kind === 'fast' || kind === 'intro') ? liteModel : codeModel
     log('running ' + kind + ' cycle…' + (ctx.length ? ' (' + ctx.length + ' event' + (ctx.length === 1 ? '' : 's') + ')' : '') + (useModel ? ' [' + useModel + ']' : ''))
+    // Live status: "working" now + a heartbeat so the UI (and its TTL) stays lit
+    // through a long cycle; onTool flips it to "typing" when post_message fires.
+    const targets = [...statusTargets]
+    emitStatus('working')
+    const heartbeat = targets.length ? setInterval(() => emitStatus('working'), 9000) : null
     try {
       await runCycle(prompt, useModel)
     } finally {
+      if (heartbeat) clearInterval(heartbeat)
+      for (const c of targets) { try { handle && handle.sendStatus(c, 'done') } catch { /* noop */ } statusTargets.delete(c) }
       busy = false
       if (queued || pending.length) { const next = queued || 'fast'; queued = null; void drain(next) }
     }
@@ -491,6 +548,9 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
         return
       }
       log('agent:mention in channel ' + (cid != null ? cid : '?') + (threadRoot != null ? ' (thread ' + threadRoot + ')' : ''))
+      // Light up the live status the instant we pick this up (thinking → the cycle
+      // takes it to working → typing → done).
+      if (cid != null) { statusTargets.add(cid); try { handle && handle.sendStatus(cid, 'thinking') } catch { /* best-effort */ } }
       const ctx = cid != null
         ? `You were @mentioned in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". This mention is FOR YOU. Send EXACTLY ONE reply with mcp__openvisio-team__post_message — arguments: channel_id ${cid}${threadRoot != null ? `, parent_id ${threadRoot} (reply IN THAT THREAD, do not start a new top-level message)` : ''}, plus agent_identifier + agent_api_key from the AUTH line above, and a 1-3 sentence reply. Compose the whole answer, then post it ONCE — do NOT post a first reply and then a revised/"better" one. FIRST read the recent messages in this thread: if you already answered this, or another agent was the one addressed, do NOT post at all. Be sure of your answer before sending.${who ? ` To @mention them back, write their EXACT full name "@${who}" (a mention only links when the name matches exactly — "@${who.split(' ')[0]}" alone will NOT).` : ''} You ALREADY have the message here — do NOT poll_inbox, and after your single reply, STOP.`
         : undefined

package/src/ws.mjs

@@ -100,6 +100,10 @@ export function connectAgentWs({ wsUrl, apiKey, identifier, onEvent, log }) {
     send(obj) { try { if (ws && ws.readyState === 1) ws.send(JSON.stringify(obj)) } catch { /* closing */ } },
     /** Show the agent as typing in a channel (docs/WEBSOCKET.md `{type:'typing'}`). */
     sendTyping(channelId) { api.send({ type: 'typing', channel_id: channelId }) },
+    /** Broadcast a richer live activity state for the agent in a channel — the
+     *  backend fans it out as `agent:status` (see docs/AGENT_STATUS.md). state is
+     *  one of thinking | working | typing | done. */
+    sendStatus(channelId, state, detail) { api.send({ type: 'agent_status', channel_id: channelId, state, ...(detail ? { detail: String(detail).slice(0, 120) } : {}) }) },
     close() {
       closed = true
       clearKeepalive()