openvisio-agent 0.7.0 → 0.7.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openvisio-agent",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "Connect your coding agent (Claude Code) to an OpenVisio team — MCP tools + optional autonomy — in one command. No shell scripts.",
   "type": "module",
   "bin": {

package/src/watch.mjs

@@ -5,7 +5,7 @@
 // than written to disk from a pasted heredoc.
 
 import { spawn, spawnSync } from 'node:child_process'
-import { writeFileSync, mkdirSync, existsSync } from 'node:fs'
+import { writeFileSync, mkdirSync, existsSync, readFileSync, unlinkSync } from 'node:fs'
 import { homedir } from 'node:os'
 import { join, dirname } from 'node:path'
 import { OV_DIR, DEFAULT_WORKSPACE, readConfig, writeJson, configPath, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
@@ -29,6 +29,7 @@ const REPLY_DISCIPLINE = [
   '  • IS IT FOR YOU? Act ONLY on messages addressed to YOU — an @mention of your exact name, a direct question to you, or a reply to something YOU said or did. If a DIFFERENT agent or person was @mentioned or asked to do something, STAY OUT: do not answer for them and do not pick up their task. When it is not yours, posting nothing is the correct move.',
   '  • NO DUPLICATES. Before you post, scan the recent thread/channel for what YOU already said. If you already replied to or acknowledged this exact request, do NOT post again. One acknowledgement per task; one answer per question. While a task is in progress, post again ONLY when you have something genuinely NEW (a result, a link, a real blocker) — never re-post "on it".',
   '  • BE SURE BEFORE YOU SPEAK. Do not claim something is possible, done, or broken until you have actually verified it — call the tool, read the code, check the real state. Never assert then contradict yourself. If you are unsure, verify FIRST, then give ONE clear, final answer instead of thinking out loud across several messages.',
+  '  • NO INVENTED HISTORY. You have NO memory beyond the messages visible in THIS thread and what your tools return right now. Never fabricate past events, competitions, conversations, results, links, PR numbers, deploy URLs, or figures. If you are asked about something you have no actual record of, say plainly "I don\'t have a record of that" — do NOT make one up to play along or be helpful. Only state things you can see or verify.',
 ].join('\n')
 
 // ── CHAT-ONLY agents (no --workdir): chat/ticket tools, no code surface. ──────
@@ -131,6 +132,29 @@ const SESSION_IDLE_MS = 1200000
 const MAX_CYCLE_MS = 240000
 const MAX_CODE_CYCLE_MS = 900000
 
+// Refuse to run a SECOND watcher for the same agent. Two watchers connect to the
+// WS as the same agent and BOTH reply to every mention — the #1 cause of duplicate
+// (and contradicting, if the two are different versions) messages. A pid lock file
+// in ~/.openvisio makes the second start fail fast instead. Stale locks (dead pid)
+// are taken over. Returns { release } or { conflict: <pid> }.
+function acquireSingleInstance(key) {
+  const lockPath = join(OV_DIR, 'watch-' + key + '.lock')
+  try {
+    mkdirSync(OV_DIR, { recursive: true })
+    if (existsSync(lockPath)) {
+      const pid = parseInt(String(readFileSync(lockPath, 'utf8')).trim(), 10)
+      if (pid && pid !== process.pid) {
+        let alive = false
+        try { process.kill(pid, 0); alive = true } catch (e) { alive = !!(e && e.code === 'EPERM') }
+        if (alive) return { conflict: pid }
+      }
+    }
+    writeFileSync(lockPath, String(process.pid))
+  } catch { /* if the lock can't be written, don't block the agent from running */ }
+  const release = () => { try { if (parseInt(String(readFileSync(lockPath, 'utf8')).trim(), 10) === process.pid) unlinkSync(lockPath) } catch { /* already gone */ } }
+  return { release }
+}
+
 export async function runWatch({ flags }) {
   const slug = flags.name ? slugify(String(flags.name)) : null
   const saved = slug ? readConfig(slug) : null
@@ -161,6 +185,19 @@ export async function runWatch({ flags }) {
   const model = String(flags.model || (saved && saved.model) || (agent === 'opencode' ? '' : 'sonnet'))
   const chatModel = String(flags['chat-model'] || (saved && saved.chatModel) || '')
 
+  // ONE watcher per agent. A second one (e.g. a manual `watch` alongside the
+  // background service, or a stale service) is the #1 cause of duplicate replies:
+  // both connect as the same agent and both answer every mention. Refuse to start.
+  if (!flags.install) {
+    const lock = acquireSingleInstance(slug || 'openvisio')
+    if (lock.conflict) {
+      fail(`Another openvisio-agent watcher for "${slug || 'openvisio'}" is already running (pid ${lock.conflict}).\n` +
+        `  Two watchers for the same agent BOTH reply to every mention — that is what causes duplicate/contradicting messages.\n` +
+        `  Stop the other one (kill ${lock.conflict}), or rely on ONLY the background service. Refusing to start a second.`)
+    }
+    process.on('exit', () => { try { lock.release && lock.release() } catch { /* noop */ } })
+  }
+
   // Backend agents (connect --backend) drive autonomy over a real-time WS instead
   // of REST-polling the frontend relay. Detected by the saved mode / a --ws flag.
   const backendMode = (saved && saved.mode === 'backend') || !!flags.ws