openvisio-agent 0.3.5 → 0.3.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openvisio-agent",
-  "version": "0.3.5",
+  "version": "0.3.7",
   "description": "Connect your coding agent (Claude Code) to an OpenVisio team — MCP tools + optional autonomy — in one command. No shell scripts.",
   "type": "module",
   "bin": {

package/src/watch.mjs

@@ -11,15 +11,13 @@ import { join, dirname } from 'node:path'
 import { OV_DIR, readConfig, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
 import { connectAgentWs, assertWebSocket } from './ws.mjs'
 
-// Shared preamble — the #1 cause of slow replies was the model shelling around to
-// "find credentials". The openvisio-team MCP tools are authenticated by the
-// connection itself, so this hammers that shut.
-const AUTH_NOTE = 'IMPORTANT: your openvisio-team (mcp__openvisio-team__*) tools are ALREADY authenticated through this connection. You do NOT need — and must NEVER look for — any API key, credential, identifier, token, or config file. NEVER run Bash/shell/grep/cat/find or read your memory to locate credentials or tools; just CALL the openvisio-team tools directly. If one returns unauthorized, say so briefly in one line — do not try to fix it by hunting for keys. Act immediately with the fewest tool calls.'
-
-const CYCLE = 'Run one OpenVisio autonomy cycle. ' + AUTH_NOTE
-const CYCLE_FAST = AUTH_NOTE + ' New chat activity in OpenVisio. If a specific mention is given above, post that reply FIRST with mcp__openvisio-team__post_message. Then call poll_inbox once and also handle any .followUps (thread replies you are part of, even without an @mention) — ignore .tasks/.claimable. Post AT MOST ONE reply per channel: if the same person sent several nudges, answer them together in ONE post. HONESTY: your only tools are the openvisio-team chat/ticket tools — you cannot write code or touch other tools; if asked for work you have no tool for, say so plainly in one short message (or offer to file a ticket). Never invent progress. Reply in 1-3 sentences, no summary. Then stop.'
-const CODE_FULL = 'Run one OpenVisio autonomy cycle. ' + AUTH_NOTE + ' Call get_marching_orders and poll_inbox. You have file + Bash tools and a git repo at your working directory FOR CODE WORK ONLY. For assigned tickets or mentions asking for real code work: FIRST "git checkout -B agent/work", make the changes with Read/Edit/Write, run tests if present, then "git add -A && git commit -m ...". NEVER git push, merge, or touch main. Then comment_ticket with a short summary + the branch name, and post a brief channel reply. Do NOT use Bash for anything other than git/tests/build — never to find credentials. If you truly cannot (missing repo/specs), say so in one message — never fabricate.'
-const CODE_FAST = AUTH_NOTE + ' New chat activity in OpenVisio. If a specific mention is given above, post that reply FIRST with mcp__openvisio-team__post_message — do this before any Bash. Then poll_inbox and handle .followUps (thread replies you are part of, even without an @mention), AT MOST ONE reply per channel. Only if a message asks for real CODE work in your git repo, do it on a branch (checkout -B agent/work, edit, commit locally — never push/merge) and reply with the branch name. Bash is for git/tests ONLY, never for credentials. 1-3 sentences, no summary. Then stop.'
+// Behaviour prompts. The openvisio-team MCP bridge requires the agent's
+// credentials as ARGUMENTS on every tool call — those are injected at runtime by
+// loopBackendWs (see credNote), NOT baked in here, so nothing needs hunting.
+const CYCLE = 'Run one OpenVisio autonomy cycle.'
+const CYCLE_FAST = 'New chat activity in OpenVisio. If a specific mention is given above, post that reply FIRST with mcp__openvisio-team__post_message. Then call poll_inbox and handle any .followUps (thread replies you are part of, even without an @mention) — ignore .tasks/.claimable. Post AT MOST ONE reply per channel: if the same person sent several nudges, answer them together in ONE post. HONESTY: your only tools are the openvisio-team chat/ticket tools — you cannot write code or touch other tools; if asked for work you have no tool for, say so plainly in one short message (or offer to file a ticket). Never invent progress. Reply in 1-3 sentences, no summary. Then stop.'
+const CODE_FULL = 'Run one OpenVisio autonomy cycle. Call get_marching_orders and poll_inbox. You have file + Bash tools and a git repo at your working directory FOR CODE WORK ONLY. For assigned tickets or mentions asking for real code work: FIRST "git checkout -B agent/work", make the changes with Read/Edit/Write, run tests if present, then "git add -A && git commit -m ...". NEVER git push, merge, or touch main. Then comment_ticket with a short summary + the branch name, and post a brief channel reply. Do NOT use Bash to find credentials — they are given to you. If you truly cannot (missing repo/specs), say so in one message — never fabricate.'
+const CODE_FAST = 'New chat activity in OpenVisio. If a specific mention is given above, post that reply FIRST with mcp__openvisio-team__post_message — do this before any Bash. Then poll_inbox and handle .followUps (thread replies you are part of, even without an @mention), AT MOST ONE reply per channel. Only if a message asks for real CODE work in your git repo, do it on a branch (checkout -B agent/work, edit, commit locally — never push/merge) and reply with the branch name. Bash is for git/tests ONLY, never for credentials. 1-3 sentences, no summary. Then stop.'
 
 const CODE_TOOLS = ['Read', 'Grep', 'Glob', 'Edit', 'Write', 'MultiEdit', 'TodoWrite', 'Bash', 'mcp__openvisio-team__*']
 const DENY_TOOLS = ['Bash(git push:*)', 'Bash(git reset --hard:*)', 'Bash(git clean:*)', 'Bash(rm:*)', 'Bash(sudo:*)', 'Bash(chmod:*)', 'Bash(curl:*)', 'Bash(wget:*)', 'Bash(npm publish:*)', 'Bash(pnpm publish:*)', 'Bash(gh pr merge:*)', 'Bash(gh repo:*)']
@@ -160,20 +158,16 @@ function loopBackendWs({ wsUrl, apiKey, identifier, claude, mcpConfig, workdir,
   let busy = false
   let queued = null // 'full' | 'fast' — a cycle requested while one was running
   let handle = null
-  let lastActivityAt = Date.now()
   // Context lines from the events themselves (the WS payload already carries the
   // channel + message / task), so the agent acts on THEM directly instead of
   // hoping poll_inbox re-surfaces the same item. Accumulated across coalesced
   // events and drained into the next cycle's prompt.
   const pending = []
 
-  // Typing indicator — pulse `channel:typing` for the channel we're working on so
-  // the reply feels immediate while the cycle runs. Cleared when the queue drains.
-  let typingChan = null
-  let typingTimer = null
-  const pulseTyping = () => { if (typingChan != null && handle) handle.sendTyping(typingChan) }
-  const startTyping = (cid) => { if (cid == null) return; typingChan = cid; pulseTyping(); if (!typingTimer) typingTimer = setInterval(pulseTyping, 3000) }
-  const stopTyping = () => { typingChan = null; if (typingTimer) { clearInterval(typingTimer); typingTimer = null } }
+  // The Mastra bridge authenticates per-CALL, not per-connection: every
+  // openvisio-team tool needs agent_identifier + agent_api_key as arguments.
+  // Hand them to the model up front so it never shells around hunting for them.
+  const credNote = `AUTH: the openvisio-team (mcp__openvisio-team__*) tools REQUIRE two arguments on EVERY call — agent_identifier: "${identifier}" and agent_api_key: "${apiKey}". Include BOTH on every openvisio-team tool call (post_message, poll_inbox, react_message, comment_ticket, …). They are given to you right here: do NOT search for them, do NOT run Bash/shell/grep/cat/find, do NOT read memory — just call the tools with these exact values.`
 
   async function drain(kind, context) {
     if (context) pending.push(context)
@@ -181,14 +175,13 @@ function loopBackendWs({ wsUrl, apiKey, identifier, claude, mcpConfig, workdir,
     busy = true
     const ctx = pending.splice(0) // take everything accumulated so far
     const base = kind === 'full' ? fullPrompt : fastPrompt
-    const prompt = ctx.length ? ctx.join('\n') + '\n\n' + base : base
+    const prompt = credNote + '\n\n' + (ctx.length ? ctx.join('\n') + '\n\n' : '') + base
     log('running ' + kind + ' cycle…' + (ctx.length ? ' (' + ctx.length + ' event' + (ctx.length === 1 ? '' : 's') + ')' : ''))
     try {
       await runCycle(prompt)
     } finally {
       busy = false
       if (queued || pending.length) { const next = queued || 'fast'; queued = null; void drain(next) }
-      else stopTyping()
     }
   }
 
@@ -202,7 +195,6 @@ function loopBackendWs({ wsUrl, apiKey, identifier, claude, mcpConfig, workdir,
 
   function onEvent(k, d) {
     const raw = d && typeof d === 'object' ? d : {}
-    lastActivityAt = Date.now()
     if (k === 'task:assigned') {
       const t = raw.task || {}
       log('task:assigned ' + (t.id != null ? '#' + t.id + ' “' + (t.title || '') + '”' : ''))
@@ -213,35 +205,36 @@ function loopBackendWs({ wsUrl, apiKey, identifier, claude, mcpConfig, workdir,
       const msg = raw.message && typeof raw.message === 'object' ? raw.message : {}
       const text = String(msg.content || msg.body || msg.text || '').replace(/\s+/g, ' ').slice(0, 600)
       const who = senderName(msg)
-      log('agent:mention in channel ' + (cid != null ? cid : '?'))
-      startTyping(cid) // show the agent as typing immediately, before the cycle finishes
+      // Reply IN THE SAME THREAD: parent is the thread root (the message's own id
+      // for a top-level mention, or its parent when the mention is itself a reply).
+      const mid = msg.id != null ? msg.id : (msg.message_id != null ? msg.message_id : null)
+      const parent = msg.parent_id != null ? msg.parent_id : (msg.parentId != null ? msg.parentId : null)
+      const threadRoot = parent != null ? parent : mid
+      log('agent:mention in channel ' + (cid != null ? cid : '?') + (threadRoot != null ? ' (thread ' + threadRoot + ')' : ''))
       const ctx = cid != null
-        ? `You were @mentioned in OpenVisio channel ${cid}${who ? ` by ${who}` : ''}: "${text}". Your FIRST action must be mcp__openvisio-team__post_message with channel_id ${cid} and a 1-3 sentence reply — you already have the message here, so do NOT poll_inbox to find it and do NOT run any Bash/shell to look for credentials or tools (they are already authenticated). After posting, you MAY poll_inbox once for other .followUps.`
+        ? `You were @mentioned in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". Reply with mcp__openvisio-team__post_message as your FIRST action — arguments: channel_id ${cid}${threadRoot != null ? `, parent_id ${threadRoot} (reply IN THAT THREAD, do not start a new top-level message)` : ''}, plus agent_identifier + agent_api_key from the AUTH line above, and a 1-3 sentence reply.${who ? ` To @mention them back, write their EXACT full name "@${who}" (a mention only links when the name matches exactly — "@${who.split(' ')[0]}" alone will NOT).` : ''} You already have the message here — do NOT poll_inbox to find it.`
         : undefined
       void drain('fast', ctx)
+    } else if (k === 'error') {
+      // Surface the backend's rejection detail instead of a bare "event error".
+      log('error event: ' + JSON.stringify(raw).slice(0, 220))
     } else {
       log('event ' + k)
     }
   }
 
-  // Follow-up sweep: thread replies you are part of get NO @mention (no WS event
-  // fires), so poll the inbox on a slow cadence to catch .followUps — but ONLY
-  // within a short window after real activity, so an idle agent costs nothing.
-  const FOLLOWUP_MS = 60_000
-  const ACTIVE_WINDOW_MS = 5 * 60_000
-  const sweep = setInterval(() => {
-    if (busy) return
-    if (Date.now() - lastActivityAt > ACTIVE_WINDOW_MS) return // idle → don't spend a cycle
-    void drain('fast', 'Follow-up check: call poll_inbox and reply to any NEW .followUps (thread replies you are part of, even with no @mention) or unanswered .mentions. If there is nothing new, do nothing and stop — do NOT post.')
-  }, FOLLOWUP_MS)
-
+  // NO polling — the WebSocket is the only trigger (task:assigned / agent:mention).
+  // A thread reply that @mentions the agent fires agent:mention and is handled
+  // in-thread above; genuinely un-mentioned thread activity has no WS event, so
+  // it's a backend concern (dispatch a thread event to participant agents), not a
+  // reason to poll.
   log('up — backend WS watcher on ' + wsUrl + (canCode ? ' [code: ' + workdir + ']' : ''))
   handle = connectAgentWs({ wsUrl, apiKey, identifier, onEvent, log })
 
   return new Promise(() => {
     // Run until killed. Tidy up the socket on termination so a restarting
     // service doesn't leak a half-open connection.
-    const bye = () => { clearInterval(sweep); stopTyping(); try { handle && handle.close() } catch { /* noop */ } process.exit(0) }
+    const bye = () => { try { handle && handle.close() } catch { /* noop */ } process.exit(0) }
     process.on('SIGTERM', bye)
     process.on('SIGINT', bye)
   })