openvisio-agent 0.21.1 → 0.22.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +11 -0
- package/README.md +5 -1
- package/USER_GUIDE.md +2 -2
- package/package.json +2 -2
- package/scenarios/runtime.scenarios.mjs +6 -11
- package/scenarios/workspace.scenarios.mjs +2 -1
- package/scripts/certify.mjs +11 -11
- package/src/codex-mcp-proxy.mjs +12 -1
- package/src/events.mjs +7 -1
- package/src/mastra-harness.mjs +19 -17
- package/src/memory.mjs +4 -3
- package/src/opencode-config.mjs +13 -16
- package/src/runtime-control.mjs +50 -0
- package/src/watch.mjs +153 -128
- package/studio/app.mjs +6 -5
- package/studio/guide.html +2 -1
package/src/watch.mjs
CHANGED
|
@@ -6,12 +6,14 @@
|
|
|
6
6
|
|
|
7
7
|
import { spawn, spawnSync } from 'node:child_process'
|
|
8
8
|
import { AsyncLocalStorage } from 'node:async_hooks'
|
|
9
|
-
import { closeSync, writeFileSync, mkdirSync, existsSync, openSync, readFileSync, readdirSync, unlinkSync } from 'node:fs'
|
|
10
|
-
import { homedir } from 'node:os'
|
|
9
|
+
import { closeSync, writeFileSync, mkdirSync, mkdtempSync, rmSync, existsSync, openSync, readFileSync, readdirSync, unlinkSync } from 'node:fs'
|
|
10
|
+
import { homedir, tmpdir } from 'node:os'
|
|
11
|
+
import { fileURLToPath } from 'node:url'
|
|
11
12
|
import { join, dirname } from 'node:path'
|
|
12
13
|
import { OV_DIR, DEFAULT_WORKSPACE, readConfig, writeJson, configPath, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
|
|
13
14
|
import { connectAgentWs, assertWebSocket } from './ws.mjs'
|
|
14
|
-
import {
|
|
15
|
+
import { buildTaskCompletionReport, claudeEventEvidence, classifyConversationTarget, conversationAsksPendingTickets, conversationCreatesTicket, conversationNeedsCode, failedTaskRevisionIsCurrent, mentionDedupeKeys, messageParentId, messageSenderIsSelf, normalizeRenderedMessageText, renderedAgentMessages, taskAgentId, taskAgentIdentifier, taskBelongsToAgent, taskFromEvent, taskIsAwaitingReview, taskIsCompleted, taskIsCoordinationOnly, taskRevision, ticketDisplaySlug } from './events.mjs'
|
|
16
|
+
import { WORK_SESSION_TOOL, workSessionRequest, agentProfileContext } from './runtime-control.mjs'
|
|
15
17
|
import { createMastraMemory } from './memory.mjs'
|
|
16
18
|
import { repositoryHasPrPushAuthorization, configurePrPublishing } from './pr-push.mjs'
|
|
17
19
|
import { createMcpHttpClient } from './mcp-http.mjs'
|
|
@@ -75,9 +77,9 @@ const REPLY_DISCIPLINE = [
|
|
|
75
77
|
' • IS IT FOR YOU? Act ONLY on messages addressed to YOU — an @mention of your exact name, a direct question to you, or a reply to something YOU said or did. If a DIFFERENT agent or person was @mentioned or asked to do something, STAY OUT: do not answer for them and do not pick up their task. When it is not yours, posting nothing is the correct move.',
|
|
76
78
|
' • EVENT NAMES ARE NOT OWNERSHIP. A transport may wake you for activity in a thread you once joined. Trust only the watcher\'s verified recipient decision for the current source message; never infer that every thread update is yours.',
|
|
77
79
|
' • NO DUPLICATES OR PICKUP NOISE. Before you post, scan the recent thread/channel for what YOU already said. If you already replied to this exact request, do NOT repeat the same message. Do not send a generic pickup acknowledgement; activity shows that work is underway. For longer code work, you may send at most one concrete progress update after work has actually begun, but that update NEVER completes the cycle: keep using tools, then send one distinct verified result or real blocker. One final answer per question.',
|
|
78
|
-
' • BE SURE BEFORE YOU SPEAK. Do not claim something is possible, done, or broken until you have actually verified it — call the tool, read the code, check the real state.
|
|
80
|
+
' • BE SURE BEFORE YOU SPEAK. Do not claim something is possible, done, or broken until you have actually verified it — call the tool, read the code, check the real state. Be willing to disagree or revise a conclusion when evidence changes. If you are unsure, investigate and distinguish a finding from an assumption.',
|
|
79
81
|
' • USE RECALL, NEVER INVENT IT. Before answering a context-dependent question, search the visible thread and use any available history, search, docs, or recall tools. Reuse verified context instead of asking the user to repeat it. If no record exists, say plainly "I don\'t have a record of that". Never fabricate past events, conversations, results, links, PR numbers, deploy URLs, or figures.',
|
|
80
|
-
' • LOOK UP ASSIGNED WORK. If someone says they assigned you a task, asks which task is yours, or asks for its status, check the live board yourself with
|
|
82
|
+
' • LOOK UP ASSIGNED WORK. If someone says they assigned you a task, asks which task is yours, or asks for its status, check the live board yourself with list_projects + list_tasks and then get_ticket as needed. Use list_agents only if assignment data requires a numeric identity lookup. Match assignments to your authenticated agent identity. Do not ask the teammate for a project slug, ticket slug, or numeric id before trying those MCP tools; ask only if the live lookup fails or returns genuinely ambiguous matches.',
|
|
81
83
|
' • TICKET SLUGS, NEVER DATABASE IDS. In every human-facing channel message, ticket comment, PR description, summary, blocker, and result, reference a ticket by the exact project-scoped slug returned by get_ticket/list_tasks (for example, `OVS-57`). Numeric project_id and ticket_id values are internal MCP arguments only: never write `#57`, `ticket 57`, or expose a database id to teammates. If the backend omits the slug, use the ticket title or say “the ticket”; do not invent a slug.',
|
|
82
84
|
' • CLOSE CONCERNS. Never leave a concern, direct question, correction, or blocker addressed to you without a clear response. Acknowledge the concern, act if you can, then report the verified result. If blocked, name the blocker and the exact next action or owner in one message.',
|
|
83
85
|
' • NEW THREADS BELONG IN YOUR DEDICATED CHANNEL. Reply to an existing request in its original thread. For any fresh top-level thread (results, blockers, or an introduction), use only your own dedicated agent channel, resolved from live list_channels by your exact identity/name. Never open a fresh thread in general, a project channel, or another agent’s channel. If no unique dedicated channel exists, keep results on the ticket and report the missing channel in an existing source thread. Never invent a channel or tool.',
|
|
@@ -86,9 +88,9 @@ const REPLY_DISCIPLINE = [
|
|
|
86
88
|
|
|
87
89
|
// ── CHAT-ONLY agents (no --workdir): chat/ticket tools, no code surface. ──────
|
|
88
90
|
const CHAT_CHARTER = [
|
|
89
|
-
'
|
|
90
|
-
'
|
|
91
|
-
'',
|
|
91
|
+
'You are the same connected OpenVisio teammate in every session. Your role, voice, current request, and available capabilities are supplied with the context.',
|
|
92
|
+
'Discover tools, retrieve relevant context, explore, plan, and choose your next steps. Use native context management. If local execution or edits are needed and openvisio_request_work_session is advertised, use it to continue the same request in your own workspace. A reply session is an internal scheduling choice, not a reason to ask the teammate to reassign your work.',
|
|
93
|
+
'Stay honest about what you have checked and what remains uncertain. Do the requested work within its authority, and give a useful final response when you choose to end your turn.',
|
|
92
94
|
REPLY_DISCIPLINE,
|
|
93
95
|
].join('\n')
|
|
94
96
|
|
|
@@ -100,13 +102,13 @@ const CYCLE_FAST = [
|
|
|
100
102
|
'New chat activity. Do EXACTLY ONE of these:',
|
|
101
103
|
' • IF a specific mention/message FOR YOU is given above: reply to THAT ONE message exactly once with post_message, then STOP. Do NOT call poll_inbox and do NOT answer anything else this cycle — you already have the message; polling would make you re-answer it and double-post.',
|
|
102
104
|
' • IF NO specific mention is given above: call poll_inbox and reply only to items truly directed at YOU (a question to you, or a reply to your own message) — SKIP chatter aimed at someone else / another agent, ignore .tasks/.claimable, at most one reply per channel.',
|
|
103
|
-
'Post ONE message total for the thing you are answering — compose it fully, then send once. Never send a reply and then a "better" version; never repeat a reply you already sent. Be sure of your answer before sending. If asked for work you have no tool for, say so plainly and offer to file a ticket.
|
|
105
|
+
'Post ONE message total for the thing you are answering — compose it fully, then send once. Never send a reply and then a "better" version; never repeat a reply you already sent. Be sure of your answer before sending. If asked for work you have no tool for, say so plainly and offer to file a ticket. Use enough detail to answer the request, then end your turn.',
|
|
104
106
|
].join('\n')
|
|
105
107
|
|
|
106
108
|
const COORDINATE = [
|
|
107
109
|
'COORDINATION-ONLY cycle. Use the lightweight lane for messaging, triage, ticket comments, assignment, and board movement.',
|
|
108
110
|
'Call get_marching_orders or poll_inbox only when the event context does not already contain enough detail. Use update_ticket to move a ticket to the correct board column when requested or when non-code work is complete.',
|
|
109
|
-
'
|
|
111
|
+
'Explore the context and available tools as needed; this session has no writable coding workspace. If local work is needed, use openvisio_request_work_session when advertised to continue in your coding workspace. Preserve the current request and recipient.',
|
|
110
112
|
'Respond to every direct concern assigned to you, but post only once per item and never duplicate an existing answer.',
|
|
111
113
|
].join('\n')
|
|
112
114
|
|
|
@@ -122,7 +124,7 @@ const CODE_CHARTER = [
|
|
|
122
124
|
'',
|
|
123
125
|
'WORK ETHIC — how a reliable teammate behaves (this is the difference between useful and ignored):',
|
|
124
126
|
' 1. CLOSE THE LOOP in THIS cycle. Never say "I\'ll do X" and stop. If you commit to something, do it NOW — the human must never have to remind you to circle back. Sending an intent or progress message is not a stop condition: continue using tools and send the verified result or blocker afterward.',
|
|
125
|
-
' 2. FINISH, then REPORT.
|
|
127
|
+
' 2. FINISH, then REPORT. Update the ticket when the actual work calls for a state change. Reply in a supplied human source thread when one exists. For backlog-assigned work, do not call post_message yourself: the watcher publishes your final response in the dedicated agent channel.',
|
|
126
128
|
' 3. Be honest and specific. Never invent progress. If you are genuinely blocked (missing repo, unclear spec, a failing tool), say exactly what you need in one message — that IS closing the loop.',
|
|
127
129
|
' 4. One final reply per request; answer several nudges together. A single concrete progress update is allowed during longer work, but it must be followed by the final result or blocker in the same cycle.',
|
|
128
130
|
' 5. RECOVER DEAD COMMAND SESSIONS. If write_stdin reports “Unknown process id”, that command session has already exited. Never poll the same process id again. Start a fresh exec_command when more work is required, then continue the task and verify the final state.',
|
|
@@ -134,24 +136,20 @@ const CODE_CHARTER = [
|
|
|
134
136
|
].join('\n')
|
|
135
137
|
|
|
136
138
|
const CODE_FULL = [
|
|
137
|
-
'
|
|
138
|
-
'
|
|
139
|
-
'
|
|
140
|
-
'
|
|
141
|
-
'
|
|
142
|
-
'
|
|
143
|
-
' 4. COMMIT + PUSH YOUR BRANCH: stage only the specific paths or hunks changed for this task; inspect git diff --cached before committing. If unrelated changes are already staged, use an isolated worktree. Commit with a clear message, then publish only your own agent/* branch using the runtime-specific authorized push flow. Never --force, never push to main/master, never merge.',
|
|
144
|
-
' 5. RAISE A PR: gh pr create --fill --base <default-branch> --head agent/<slug> (a clear title + a body summarizing the change and how you verified it). Never gh pr merge.',
|
|
145
|
-
' 6. CLOSE THE LOOP: move/update the ticket with update_ticket. Use a ticket-comment tool for a blocker or clarification only when that tool actually appears; otherwise keep the blocker in the ticket update and let the watcher deliver the visible channel result. When a source thread is supplied, follow its explicit delivery rule: either post once or return final text for watcher delivery. For backlog-only tickets, do not call post_message yourself; the watcher sends one verified dedicated-channel completion message and deduplicates it across reconnects.',
|
|
146
|
-
'Bash is for git / gh / tests / clone ONLY — never to hunt for credentials (they are given to you above).',
|
|
139
|
+
'Handle the supplied verified ticket or source request. You decide how to investigate, which tools to use, what context to retain or compact, and when the work is ready for a final response.',
|
|
140
|
+
'There is no required sequence of tools, code edits, ticket updates, or PR creation. Research, audits, explanations, coordination, and already-satisfied requests may finish without repository changes. Choose validation and delivery appropriate to the actual request.',
|
|
141
|
+
'Use available tool discovery, resources, history, search, skills, and planning tools when useful. Prefer the repository knowledge graph when available. Recover from optional tool failures using alternatives; report only a limitation that actually prevents the requested outcome.',
|
|
142
|
+
'A usable local clone is your primary code surface. Preserve unrelated work and use an isolated worktree when needed. Remote codebase tools are a fallback only when the repository cannot be obtained locally. For code changes, verify the result and use the authorized branch/PR flow when the request calls for it.',
|
|
143
|
+
'You own ticket state: use update_ticket when its state should change, including review, completion, or a real blocker. Ending your turn does not mark the ticket done. Your native final response ends this cycle; it can report a result, ask a necessary question, or explain a blocker. Do not describe unperformed work as complete.',
|
|
144
|
+
'Follow the supplied source delivery rule. For backlog-only tickets, return your final response; the watcher delivers it once to your dedicated channel. Do not call post_message for that same result.',
|
|
147
145
|
].join('\n')
|
|
148
146
|
|
|
149
147
|
const CODE_FAST = [
|
|
150
148
|
'New chat activity. Do EXACTLY ONE of these:',
|
|
151
149
|
' • IF a specific mention/message FOR YOU is given above: reply to THAT ONE message exactly once with post_message, then STOP. Do NOT call poll_inbox and do NOT answer anything else this cycle — polling would re-surface the same message and make you double-post.',
|
|
152
150
|
' • IF NO specific mention is given above: call poll_inbox and reply only to items directed at YOU (asks you something, or responds to your own message) — SKIP chatter aimed at someone else / another agent; at most one reply per channel.',
|
|
153
|
-
'
|
|
154
|
-
'For a non-code question, post ONE answer and stop. For code work, do not post a generic pickup message. You may post one concrete progress update after work starts, but keep working after it; then post one distinct final result with the PR/test evidence or a real blocker. Never repeat the same message.
|
|
151
|
+
'Explore the request and its context. If local execution or edits are needed, use openvisio_request_work_session when advertised to continue in your own coding workspace. Do not turn an internal scheduling choice into a reassignment request.',
|
|
152
|
+
'For a non-code question, post ONE answer and stop. For code work, do not post a generic pickup message. You may post one concrete progress update after work starts, but keep working after it; then post one distinct final result with the PR/test evidence or a real blocker. Never repeat the same message. Let the request determine how much detail the final response needs.',
|
|
155
153
|
].join('\n')
|
|
156
154
|
|
|
157
155
|
// ── Workspace-ethics cycles (both chat-only + code agents) ───────────────────
|
|
@@ -172,7 +170,8 @@ const SWEEP = [
|
|
|
172
170
|
].join('\n')
|
|
173
171
|
|
|
174
172
|
// Bash covers git/gh/clone/tests; the deny list is where the guardrails live.
|
|
175
|
-
const
|
|
173
|
+
const CONTEXT_TOOLS = ['Read', 'Grep', 'Glob', 'TodoWrite', 'ToolSearch', 'WebSearch', 'WebFetch', 'Task', 'Agent', 'Skill']
|
|
174
|
+
const CODE_TOOLS = [...CONTEXT_TOOLS, 'Edit', 'Write', 'MultiEdit', 'Bash', 'mcp__openvisio-team__*']
|
|
176
175
|
// Push + PR creation ARE allowed (agents raise PRs), but main/master, force-pushes,
|
|
177
176
|
// merges and destructive/publishing/repo-deleting commands stay blocked.
|
|
178
177
|
const DENY_TOOLS = [
|
|
@@ -190,14 +189,9 @@ const DENY_TOOLS = [
|
|
|
190
189
|
const FAST = 5000
|
|
191
190
|
const SLOW = 60000
|
|
192
191
|
const IDLE_AFTER = 30000
|
|
193
|
-
//
|
|
194
|
-
// mention → a reply, a task → its work), so keeping a session across cycles just
|
|
195
|
-
// re-bills the entire prior history on every new cycle — the #1 token sink. Fresh
|
|
196
|
-
// per cycle keeps each cycle's cost to its own work (the static charter/creds ride
|
|
197
|
-
// in the cached system prompt, so a fresh spawn is cheap).
|
|
198
|
-
const MAX_TURNS = 1
|
|
192
|
+
// Keep source-scoped sessions warm; the native agent owns compaction.
|
|
199
193
|
const SESSION_IDLE_MS = 1200000
|
|
200
|
-
// A
|
|
194
|
+
// A silent runtime is stopped after this inactivity interval — otherwise a hung
|
|
201
195
|
// cycle (e.g. an MCP tool stalling on a down bridge) would leave `busy` stuck
|
|
202
196
|
// true forever and silently queue every later mention. Code cycles get a much
|
|
203
197
|
// longer budget: a real clone → branch → test → push → PR flow legitimately takes
|
|
@@ -336,20 +330,20 @@ export async function runWatch({ flags }) {
|
|
|
336
330
|
}
|
|
337
331
|
|
|
338
332
|
// Claude keeps its native stream; Codex and OpenCode use Mastra ACP.
|
|
339
|
-
export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, mcpConfig, workdir, log, debug, model, onTool, onEvent, systemPrompt, canCoordinate = false }) {
|
|
333
|
+
export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, mcpConfig, workdir, log, debug, model, onTool, onEvent, systemPrompt, canCoordinate = false, workspaceAvailable = !!workdir }) {
|
|
340
334
|
const canCode = !!workdir
|
|
341
335
|
const maxCycleMs = canCode ? MAX_CODE_CYCLE_MS : MAX_CYCLE_MS
|
|
342
336
|
// Codex and OpenCode run through Mastra's ACP harness. Each queue worker gets
|
|
343
337
|
// its own ACP session and worktree, so cancellation, permissions and context
|
|
344
338
|
// cannot bleed across concurrently assigned tickets.
|
|
345
|
-
const mastraRunner = createMastraAcpRunner({ agent, mcpUrl, mcpHeaders, workdir, canCode, canCoordinate, maxCycleMs, log, debug, model, onTool, onEvent, systemPrompt })
|
|
339
|
+
const mastraRunner = createMastraAcpRunner({ agent, mcpUrl, mcpHeaders, workdir, canCode, canCoordinate, workspaceAvailable, maxCycleMs, log, debug, model, onTool, onEvent, systemPrompt })
|
|
346
340
|
if (mastraRunner) return mastraRunner
|
|
347
341
|
let child = null
|
|
342
|
+
let privateMcpDir = ''
|
|
348
343
|
// The model the CURRENT session was spawned with. runCycle can pass a different
|
|
349
344
|
// model per cycle (cheap for chat, stronger for code) — a change recycles the
|
|
350
345
|
// session so the new model takes effect.
|
|
351
346
|
let sessionModel = resolveClaudeModel(model) || null
|
|
352
|
-
let turnsThisSession = 0
|
|
353
347
|
let sessionStartedAt = 0
|
|
354
348
|
let resolveTurn = null
|
|
355
349
|
let cycleTimer = null
|
|
@@ -363,6 +357,7 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
363
357
|
let turnDidResultMessage = false
|
|
364
358
|
let turnDidMcpTaskRead = false
|
|
365
359
|
let turnDidMcpTaskUpdate = false
|
|
360
|
+
let turnWorkRequest = null
|
|
366
361
|
let turnOutputText = ''
|
|
367
362
|
let turnCycleId = null
|
|
368
363
|
let turnRuntimePid = null
|
|
@@ -374,10 +369,11 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
374
369
|
const clearCycleTimer = () => { if (cycleTimer) { clearTimeout(cycleTimer); cycleTimer = null } }
|
|
375
370
|
const settleTurn = (o) => {
|
|
376
371
|
clearCycleTimer()
|
|
372
|
+
sessionStartedAt = Date.now()
|
|
377
373
|
const r = resolveTurn
|
|
378
374
|
resolveTurn = null
|
|
379
375
|
const finalText = typeof o.result === 'string' ? o.result.trim() : turnOutputText.trim()
|
|
380
|
-
if (r && finalText) emit('output.final', { text: safeText(finalText, 8000), status: o.subtype || '
|
|
376
|
+
if (r && finalText) emit('output.final', { text: safeText(finalText, 8000), status: o.is_error ? 'error' : o.subtype || 'error' })
|
|
381
377
|
const mcpCalls = [...turnToolCalls]
|
|
382
378
|
if (r) r({
|
|
383
379
|
...o,
|
|
@@ -390,7 +386,8 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
390
386
|
didResultMessage: turnDidResultMessage,
|
|
391
387
|
didMcpTaskRead: turnDidMcpTaskRead,
|
|
392
388
|
didMcpTaskUpdate: turnDidMcpTaskUpdate,
|
|
393
|
-
outputText:
|
|
389
|
+
outputText: finalText,
|
|
390
|
+
workRequest: turnWorkRequest,
|
|
394
391
|
})
|
|
395
392
|
}
|
|
396
393
|
|
|
@@ -415,18 +412,33 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
415
412
|
// The charter + creds ride in the system prompt (cacheable → not re-billed each
|
|
416
413
|
// cycle), leaving only the small per-cycle instruction in the user message.
|
|
417
414
|
const fallbackModels = claudeFallbackModels(sessionModel)
|
|
418
|
-
|
|
419
|
-
|
|
415
|
+
let sessionMcpConfig = mcpConfig
|
|
416
|
+
if (mcpUrl && mcpHeaders?.['x-agent-api-key'] && mcpHeaders?.['x-agent-identifier']) {
|
|
417
|
+
if (!privateMcpDir) privateMcpDir = mkdtempSync(join(tmpdir(), 'openvisio-claude-mcp-'))
|
|
418
|
+
sessionMcpConfig = join(privateMcpDir, 'mcp.json')
|
|
419
|
+
writeJson(sessionMcpConfig, { mcpServers: { 'openvisio-team': {
|
|
420
|
+
command: process.execPath, args: [fileURLToPath(new URL('./codex-mcp-proxy.mjs', import.meta.url))],
|
|
421
|
+
env: {
|
|
422
|
+
OPENVISIO_CODEX_MCP_URL: mcpUrl,
|
|
423
|
+
OPENVISIO_CODEX_API_KEY: mcpHeaders['x-agent-api-key'],
|
|
424
|
+
OPENVISIO_CODEX_IDENTIFIER: mcpHeaders['x-agent-identifier'],
|
|
425
|
+
OPENVISIO_CAN_CODE: String(canCode),
|
|
426
|
+
OPENVISIO_WORKSPACE_AVAILABLE: String(workspaceAvailable),
|
|
427
|
+
},
|
|
428
|
+
} } }, true)
|
|
429
|
+
}
|
|
430
|
+
const base = ['-p', '--input-format', 'stream-json', '--output-format', 'stream-json', '--verbose', '--mcp-config', sessionMcpConfig, ...(sessionModel ? ['--model', sessionModel, ...(fallbackModels.length ? ['--fallback-model', fallbackModels.join(',')] : [])] : []), ...(systemPrompt ? ['--append-system-prompt', systemPrompt] : [])]
|
|
431
|
+
const args = canCode ? [...base, '--allowedTools', ...CODE_TOOLS, '--disallowedTools', ...DENY_TOOLS] : [...base, '--allowedTools', ...CONTEXT_TOOLS, 'mcp__openvisio-team__*', '--disallowedTools', 'Edit', 'Write', 'MultiEdit', 'Bash']
|
|
420
432
|
const c = spawn(claude, args, { ...modelProcessOptions, cwd: workdir || undefined, stdio: ['pipe', 'pipe', 'inherit'] })
|
|
421
433
|
child = c
|
|
422
434
|
turnRuntimePid = c.pid || null
|
|
423
435
|
childCycleIds.set(c, turnCycleId)
|
|
424
436
|
emit('process.started', { status: 'starting' })
|
|
425
|
-
turnsThisSession = 0
|
|
426
437
|
sessionStartedAt = Date.now()
|
|
427
438
|
let localBuf = ''
|
|
428
439
|
c.stdout.on('data', (d) => {
|
|
429
440
|
if (c !== child) return
|
|
441
|
+
cycleTimer?.refresh()
|
|
430
442
|
localBuf += d
|
|
431
443
|
let i
|
|
432
444
|
while ((i = localBuf.indexOf('\n')) >= 0) {
|
|
@@ -448,6 +460,7 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
448
460
|
if (o.type === 'user' && Array.isArray(o.message?.content)) {
|
|
449
461
|
for (const block of o.message.content) if (block.type === 'tool_result') {
|
|
450
462
|
const use = turnToolUses.get(block.tool_use_id)
|
|
463
|
+
if (!block.is_error && use?.name?.endsWith('__' + WORK_SESSION_TOOL)) turnWorkRequest = workSessionRequest(block.content) || turnWorkRequest
|
|
451
464
|
const title = use?.name === 'Bash' && typeof use.input?.command === 'string' ? use.input.command : use?.name || 'tool'
|
|
452
465
|
const filePath = ['Read', 'Write', 'Edit', 'MultiEdit', 'Grep', 'Glob'].includes(use?.name) ? use.input?.file_path || use.input?.path : ''
|
|
453
466
|
emit('tool.finished', { toolCallId: safeText(block.tool_use_id, 200), name: safeText(use?.name || 'tool', 300), title: safeText(title), status: block.is_error ? 'failed' : 'completed', locations: typeof filePath === 'string' && filePath ? [{ path: safeText(filePath, 1000) }] : [] })
|
|
@@ -477,13 +490,7 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
477
490
|
if (o.type === 'result') {
|
|
478
491
|
log('cycle done (' + (o.subtype || 'ok') + (o.is_error ? ' · ERROR' : '') + ')')
|
|
479
492
|
clearCycleTimer()
|
|
480
|
-
|
|
481
|
-
// full Claude runtime resident until the next event; release its CPU,
|
|
482
|
-
// memory and file watchers as soon as the result has been received.
|
|
483
|
-
if (MAX_TURNS === 1 && c === child) {
|
|
484
|
-
child = null
|
|
485
|
-
void stopModelProcess(c).then(() => settleTurn(o))
|
|
486
|
-
} else settleTurn(o)
|
|
493
|
+
settleTurn(o)
|
|
487
494
|
return
|
|
488
495
|
}
|
|
489
496
|
}
|
|
@@ -493,7 +500,7 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
493
500
|
c.on('close', (code, signal) => emit('process.stopped', { cycleId: childCycleIds.get(c) ?? null, runtimePid: c.pid || null, status: 'exited', exitCode: code, signal }))
|
|
494
501
|
log('warm session started' + (sessionModel ? ' [model ' + sessionModel + ']' : '') + (canCode
|
|
495
502
|
? ' [CODE mode — workspace ' + workdir + ' — finds/clones the org\'s repos here, branches, pushes, opens PRs]'
|
|
496
|
-
: ' [
|
|
503
|
+
: ' [CONTEXT session — advertised tools, reading, search, and planning]'))
|
|
497
504
|
}
|
|
498
505
|
|
|
499
506
|
function runCycle(prompt, cycleModel, cycleOptions = {}) {
|
|
@@ -507,14 +514,13 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
507
514
|
if (resolvedCycleModel !== cycleModel) log('model ' + cycleModel + ' resolved to Claude family alias ' + resolvedCycleModel)
|
|
508
515
|
sessionModel = resolvedCycleModel
|
|
509
516
|
}
|
|
510
|
-
if (child && (
|
|
511
|
-
log('recycling session
|
|
517
|
+
if (child && (Date.now() - sessionStartedAt > SESSION_IDLE_MS)) {
|
|
518
|
+
log('recycling idle session')
|
|
512
519
|
try { child.kill() } catch { /* already gone */ }
|
|
513
520
|
child = null
|
|
514
521
|
}
|
|
515
522
|
ensureSession()
|
|
516
523
|
if (child) childCycleIds.set(child, turnCycleId)
|
|
517
|
-
turnsThisSession++
|
|
518
524
|
turnToolCalls = new Set()
|
|
519
525
|
turnToolUses = new Map()
|
|
520
526
|
turnMcpErrors = new Set()
|
|
@@ -525,6 +531,7 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
525
531
|
turnDidResultMessage = false
|
|
526
532
|
turnDidMcpTaskRead = false
|
|
527
533
|
turnDidMcpTaskUpdate = false
|
|
534
|
+
turnWorkRequest = null
|
|
528
535
|
turnOutputText = ''
|
|
529
536
|
resolveTurn = resolve
|
|
530
537
|
// Backstop: abandon a cycle that never returns a result so `busy` is released
|
|
@@ -548,7 +555,10 @@ export function createCycleRunner({ claude, agent, mcpUrl, mcpHeaders, cfgKey, m
|
|
|
548
555
|
child = null
|
|
549
556
|
return stopModelProcess(active).then(() => settleTurn({ type: 'result', subtype: 'canceled' }))
|
|
550
557
|
}
|
|
551
|
-
return { runCycle, canCode, cancelCurrent, close: () => {
|
|
558
|
+
return { runCycle, canCode, cancelCurrent, close: async () => {
|
|
559
|
+
await cancelCurrent()
|
|
560
|
+
if (privateMcpDir) { rmSync(privateMcpDir, { recursive: true, force: true }); privateMcpDir = '' }
|
|
561
|
+
} }
|
|
552
562
|
}
|
|
553
563
|
|
|
554
564
|
// ── the backend WS loop ──────────────────────────────────────────────────────
|
|
@@ -595,16 +605,14 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
595
605
|
const canCode = !!workdir
|
|
596
606
|
// The Mastra bridge authenticates per-CALL: every openvisio-team tool needs
|
|
597
607
|
// agent_identifier + agent_api_key as arguments. Hand them over up front.
|
|
598
|
-
const authRule = agent
|
|
599
|
-
|
|
600
|
-
: `AUTH: the openvisio-team tools REQUIRE two arguments on EVERY call — agent_identifier: "${identifier}" and agent_api_key: "${apiKey}". Include BOTH on every openvisio-team tool call. The credentials are given here; do NOT hunt for them.`
|
|
601
|
-
const credNote = `${authRule} Codex may defer MCP actions instead of placing them in the initial tool list. If a native tool_search is available and an expected openvisio-team action is not initially visible, use tool_search to find that exact action, then call it; an initial-list miss is NOT evidence that the server is disconnected. Do not ask a teammate to reconnect or provide a slug until tool_search and the applicable live lookup have actually failed. On backend MCP, discover and update work with list_agents, list_projects, list_tasks, list_task_types, get_ticket, update_ticket, list_channels, list_message_thread, and list_activity as applicable. Ticket comments are optional: discover an advertised ticket-comment action and follow its input schema; never invent a tool name or call an unadvertised action. get_marching_orders, poll_inbox, get_resource, list_mcp_resources, and list_mcp_resource_templates are NOT team-action tools here; never call them. Tools may be namespaced; use advertised actions on the authenticated session server only. Bash/git/gh ARE for code work; this rule only forbids searching for keys.`
|
|
608
|
+
const authRule = 'AUTH: the local OpenVisio MCP bridge injects authentication outside the model. Use openvisio-team-watcher for Codex/OpenCode and openvisio-team for Claude; these are the authenticated servers for this session. Never add, request, print, or search for agent credentials in tool arguments.'
|
|
609
|
+
const credNote = `${authRule} Codex may defer MCP actions instead of placing them in the initial tool list. If a native tool_search is available and an expected openvisio-team action is not initially visible, use tool_search to find that exact action, then call it; an initial-list miss is NOT evidence that the server is disconnected. Do not ask a teammate to reconnect or provide a slug until tool_search and the applicable live lookup have actually failed. On backend MCP, discover and update work with list_agents, list_projects, list_tasks, list_task_types, get_ticket, update_ticket, list_channels, list_message_thread, and list_activity as applicable. Ticket comments are optional: discover an advertised ticket-comment action and follow its input schema; never invent a tool name or call an unadvertised action. Use tool and resource discovery when helpful, and call only advertised capabilities. Tools may be namespaced; use advertised actions on the authenticated session server only. Bash/git/gh ARE for code work; this rule only forbids searching for keys.`
|
|
602
610
|
// Keep the static charter stable so provider prompt caching can reuse it.
|
|
603
611
|
// Actual cache hits and billing depend on the runtime and model provider.
|
|
604
612
|
const systemPrompt = (canCode ? CODE_CHARTER : CHAT_CHARTER) + '\n\n' + credNote
|
|
605
613
|
const runnerOptions = {
|
|
606
614
|
claude, agent, mcpUrl, mcpHeaders: { 'x-agent-api-key': apiKey, 'x-agent-identifier': identifier },
|
|
607
|
-
cfgKey: identifier, mcpConfig, workdir, log, debug, model, systemPrompt, onEvent: emit,
|
|
615
|
+
cfgKey: identifier, mcpConfig, workdir, workspaceAvailable: canCode, log, debug, model, systemPrompt, onEvent: emit,
|
|
608
616
|
}
|
|
609
617
|
// One watcher and one WS subscription, with a bounded pool of isolated coding
|
|
610
618
|
// runtimes. Replies serialize within a thread while independent threads run
|
|
@@ -632,12 +640,12 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
632
640
|
const codexPushGuide = agent === 'codex' && canCode
|
|
633
641
|
? '\n\nCODEX PR DELIVERY: when the repository exists in the local workspace, use that clone for branch creation, edits, tests, and commits; do not inspect or mutate it through linked-codebase MCP tools. To publish the local agent/* branch, run `openvisio-agent push-pr-branch` from the repository, then open the PR with `gh pr create`. The helper can only push HEAD to the matching agent/* branch on the exact authorized origin. If it reports OPENVISIO_PR_PUSH_AUTH_REQUIRED, do not retry or route around it. PR publishing is enabled during connection setup for the coding workspace and its worktrees. If authorization is missing outside that workspace, report the exact repository configuration issue once; never tell the user to restart the watcher. Use list_codebases/create_codebase_branch/create_codebase_commit/create_pull_request only as a fallback when the repository cannot be obtained locally.'
|
|
634
642
|
: ''
|
|
635
|
-
const backendToolRule = '
|
|
643
|
+
const backendToolRule = 'TOOL DISCOVERY: use the tools and resources actually advertised by your connected runtime. Native tool_search, MCP resources, history, search, planning, skills, and context compaction are available when the runtime supports them. Discover an absent action before deciding it is unavailable; never invent a tool or its schema. The supplied event identifies the request, so further discovery is your choice when it helps the task.'
|
|
636
644
|
const studioGuide = `\n\nAGENT STUDIO: When a teammate asks to inspect agent activity or change model settings, offer [Open Agent Studio](http://127.0.0.1:4317/#agent=${encodeURIComponent(identifier)}&settings=1). The app renders this link as a button. Studio manages agents on the teammate’s own computer; it does not connect to another teammate’s machine. Prefer this UI over asking people to run model-setting CLI commands.`
|
|
637
645
|
const fullPrompt = (canCode ? CODE_FULL + codexPushGuide : 'Handle the supplied verified backend ticket with the available OpenVisio tools. Update or comment on the ticket as requested, do not claim repository work in chat-only mode, and stop after the verified action.') + '\n\n' + backendToolRule + studioGuide
|
|
638
646
|
const fastPrompt = (canCode ? CODE_FAST : CYCLE_FAST) + '\n\n' + backendToolRule + studioGuide
|
|
639
647
|
const coordinatePrompt = COORDINATE + '\n\n' + backendToolRule + studioGuide
|
|
640
|
-
const guardedReplyPrompt = `WATCHER-DELIVERED REPLY: the watcher has already verified that the current source message is addressed to you. Your current OpenVisio agent identifier is "${identifier}"; do not call list_agents merely to rediscover yourself.
|
|
648
|
+
const guardedReplyPrompt = `WATCHER-DELIVERED REPLY: the watcher has already verified that the current source message is addressed to you. Your current OpenVisio agent identifier is "${identifier}"; do not call list_agents merely to rediscover yourself. Return the final reply for watcher delivery instead of calling post_message for the same result. Discover tools and retrieve additional context as needed. OpenVisio team-state tools are allowed: when the answer depends on live projects, assignments, tickets, or status, use list_projects/list_tasks/get_ticket as needed and never ask the teammate for a slug that those tools can resolve. A failed read-only discovery call is not a completed action and must not be described as an intervention-level blocker; continue with available live data or state the narrow fact you could not verify. Return one natural, context-specific final response with enough detail to address the request. Do not echo the request, announce a plan, or add a generic acknowledgement. If the supplied context says the work was completed, lead with the verified result; if it is blocked, name only the real blocker and next action.` + '\n\n' + backendToolRule + studioGuide
|
|
641
649
|
// Live model state — changeable at runtime by the in-chat `/model` command.
|
|
642
650
|
// codeModel drives full/sweep cycles; chatModel (if set) the lighter fast/intro
|
|
643
651
|
// ones, so routine chatter can run cheaper than real code work.
|
|
@@ -717,12 +725,14 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
717
725
|
// pending and delivered keys so a reconnect can finish a missed notification
|
|
718
726
|
// without re-running the model or posting the same result twice.
|
|
719
727
|
const pendingCompletionReports = new Set(Array.isArray(replayState.pendingCompletionReports) ? replayState.pendingCompletionReports : [])
|
|
728
|
+
const pendingAgentResults = new Map(Array.isArray(replayState.pendingAgentResults) ? replayState.pendingAgentResults : [])
|
|
729
|
+
const finishedTaskVersions = new Map(Array.isArray(replayState.finishedTaskVersions) ? replayState.finishedTaskVersions : [])
|
|
720
730
|
const reportedCompletions = new Set(Array.isArray(replayState.reportedCompletions) ? replayState.reportedCompletions : [])
|
|
721
731
|
const reportedTaskComments = new Set(Array.isArray(replayState.reportedTaskComments) ? replayState.reportedTaskComments : [])
|
|
722
|
-
//
|
|
732
|
+
// Transport/runtime failures are held at the ticket revision that produced them.
|
|
723
733
|
// This is distinct from a policy block: any later human ticket change resumes
|
|
724
734
|
// the work, but reconnects and the watcher's own blocker update do not.
|
|
725
|
-
const failedTaskVersions = new Map(Array.isArray(replayState.failedTaskVersions) ? replayState.failedTaskVersions : [])
|
|
735
|
+
const failedTaskVersions = new Map(replayState.completionPolicy === 'agent' && Array.isArray(replayState.failedTaskVersions) ? replayState.failedTaskVersions : [])
|
|
726
736
|
// A policy-blocked task stays paused across reconnects. Helper blocks are
|
|
727
737
|
// released by verified local configuration, or cleared when completed/unassigned. This prevents a 30-minute reconciliation retry from repeatedly
|
|
728
738
|
// attempting the same rejected egress action.
|
|
@@ -749,6 +759,9 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
749
759
|
blockedTasks: [...blockedTasks],
|
|
750
760
|
blockedTaskRepos: [...blockedTaskRepos],
|
|
751
761
|
pendingCompletionReports: [...pendingCompletionReports],
|
|
762
|
+
pendingAgentResults: [...pendingAgentResults],
|
|
763
|
+
finishedTaskVersions: [...finishedTaskVersions],
|
|
764
|
+
completionPolicy: 'agent',
|
|
752
765
|
reportedCompletions: [...reportedCompletions],
|
|
753
766
|
reportedTaskComments: [...reportedTaskComments],
|
|
754
767
|
}, true)
|
|
@@ -817,18 +830,18 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
817
830
|
// Context lines from the events themselves (the WS payload already carries the
|
|
818
831
|
// channel + message / task), so the agent acts on THEM directly instead of
|
|
819
832
|
// hoping poll_inbox re-surfaces the same item. Each queue entry retains that
|
|
820
|
-
// source independently through work,
|
|
833
|
+
// source independently through work, continuation, and delivery.
|
|
821
834
|
let backlogProbeBusy = false
|
|
822
835
|
let selfAgentId = null
|
|
823
836
|
let selfOrganizationId = null
|
|
824
|
-
let
|
|
837
|
+
let identityContext = memory.get?.(`identity:${identifier}`)?.meta?.context || agentProfileContext({}, identifier)
|
|
825
838
|
const selfAliases = new Set([slug, identifier].map((value) => String(value || '').toLowerCase()).filter(Boolean))
|
|
826
839
|
const rememberSelfAgent = (self) => {
|
|
827
840
|
if (!self || typeof self !== 'object' || String(self.identifier || self.slug || '') !== identifier) return
|
|
828
841
|
if (validBackendId(self.id)) selfAgentId = Number(self.id)
|
|
829
842
|
for (const alias of [self.name, self.identifier, self.slug]) if (alias) selfAliases.add(String(alias).toLowerCase())
|
|
830
|
-
|
|
831
|
-
|
|
843
|
+
identityContext = agentProfileContext(self, identifier)
|
|
844
|
+
memory.remember({ key: `identity:${identifier}`, kind: 'identity', state: 'configured', summary: self.name || identifier, meta: { context: identityContext } })
|
|
832
845
|
const organizationId = self.organization_id ?? self.organizationId
|
|
833
846
|
if (validBackendId(organizationId)) {
|
|
834
847
|
selfOrganizationId = Number(organizationId)
|
|
@@ -1156,21 +1169,34 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1156
1169
|
return true
|
|
1157
1170
|
}
|
|
1158
1171
|
|
|
1159
|
-
const announceTaskCompletion = async (taskRef, result = {}) => {
|
|
1172
|
+
const announceTaskCompletion = async (taskRef, result = {}, isCancelled = () => false) => {
|
|
1160
1173
|
const projectId = Number(taskRef?.projectId)
|
|
1161
1174
|
const ticketId = Number(taskRef?.ticketId)
|
|
1162
1175
|
if (!Number.isFinite(projectId) || !Number.isFinite(ticketId)) return false
|
|
1163
1176
|
const taskKey = `${projectId}:${ticketId}`
|
|
1177
|
+
if (String(result.outputText || '').trim()) {
|
|
1178
|
+
pendingAgentResults.set(taskKey, { outputText: result.outputText, didChannelMessage: !!result.didChannelMessage })
|
|
1179
|
+
pendingCompletionReports.add(taskKey)
|
|
1180
|
+
trimMap(pendingAgentResults); trimSeen(pendingCompletionReports); persistReplay()
|
|
1181
|
+
}
|
|
1182
|
+
result = pendingAgentResults.get(taskKey)
|
|
1183
|
+
if (!result) return false
|
|
1164
1184
|
const current = toolData(await callMcpTool('get_ticket', { project_id: projectId, ticket_id: ticketId }))
|
|
1165
1185
|
const ticket = current.ticket ?? current.task ?? current
|
|
1166
|
-
|
|
1167
|
-
|
|
1186
|
+
if (String(ticket.id) !== String(ticketId) || (ticket.project_id != null && String(ticket.project_id) !== String(projectId)) || !taskBelongsToAgent(ticket, { id: selfAgentId, identifier })) {
|
|
1187
|
+
pendingAgentResults.delete(taskKey); pendingCompletionReports.delete(taskKey); persistReplay()
|
|
1188
|
+
return false
|
|
1189
|
+
}
|
|
1190
|
+
if (isCancelled()) return false
|
|
1191
|
+
const report = result.report || buildTaskCompletionReport(ticket, { projectId, fallbackText: result.outputText, agentFinal: true })
|
|
1192
|
+
if (report && !result.report) { result.report = report; persistReplay() }
|
|
1193
|
+
finishedTaskVersions.set(taskKey, taskRevision(ticket)); trimMap(finishedTaskVersions); persistReplay()
|
|
1168
1194
|
if (!report) return false
|
|
1169
1195
|
const memoryKey = `ticket:${projectId}:${ticketId}`
|
|
1170
1196
|
memory.remember({
|
|
1171
1197
|
key: memoryKey,
|
|
1172
1198
|
kind: 'ticket',
|
|
1173
|
-
state: '
|
|
1199
|
+
state: 'responded',
|
|
1174
1200
|
summary: report.content,
|
|
1175
1201
|
refs: { projectId, ticketId },
|
|
1176
1202
|
meta: { reportKey: report.key, prUrl: report.prUrl },
|
|
@@ -1189,7 +1215,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1189
1215
|
reportedTaskComments.add(report.key); trimSeen(reportedTaskComments); persistReplay()
|
|
1190
1216
|
}
|
|
1191
1217
|
if (reportedCompletions.has(report.key)) {
|
|
1192
|
-
pendingCompletionReports.delete(taskKey)
|
|
1218
|
+
pendingCompletionReports.delete(taskKey); pendingAgentResults.delete(taskKey)
|
|
1193
1219
|
persistReplay()
|
|
1194
1220
|
return true
|
|
1195
1221
|
}
|
|
@@ -1198,15 +1224,16 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1198
1224
|
// second top-level copy.
|
|
1199
1225
|
if (result.didChannelMessage) {
|
|
1200
1226
|
reportedCompletions.add(report.key); trimSeen(reportedCompletions)
|
|
1201
|
-
pendingCompletionReports.delete(taskKey); persistReplay()
|
|
1227
|
+
pendingCompletionReports.delete(taskKey); pendingAgentResults.delete(taskKey); persistReplay()
|
|
1202
1228
|
log('completion for ticket #' + ticketId + ' was already posted by the work cycle')
|
|
1203
1229
|
return true
|
|
1204
1230
|
}
|
|
1205
1231
|
const channelId = await projectStatusChannel(projectId)
|
|
1206
1232
|
if (channelId == null || !Number.isFinite(channelId)) return false
|
|
1233
|
+
if (isCancelled()) return false
|
|
1207
1234
|
await postMessageOnce({ key: `completion:${report.key}`, projectId, channelId, content: report.content, sourceKey: memoryKey })
|
|
1208
1235
|
reportedCompletions.add(report.key); trimSeen(reportedCompletions)
|
|
1209
|
-
pendingCompletionReports.delete(taskKey); persistReplay()
|
|
1236
|
+
pendingCompletionReports.delete(taskKey); pendingAgentResults.delete(taskKey); persistReplay()
|
|
1210
1237
|
memory.remember({ key: memoryKey, kind: 'ticket', state: 'reported', summary: report.content, refs: { projectId, ticketId, channelId }, meta: { reportKey: report.key, prUrl: report.prUrl } })
|
|
1211
1238
|
log('posted verified completion for ticket #' + ticketId + ' in channel ' + channelId)
|
|
1212
1239
|
return true
|
|
@@ -1311,6 +1338,10 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1311
1338
|
for (const task of Array.isArray(tasksData.tasks) ? tasksData.tasks : []) {
|
|
1312
1339
|
if (!await resolveTaskOwner(task)) continue
|
|
1313
1340
|
const taskKey = `${project.id}:${task.id}`
|
|
1341
|
+
if (pendingAgentResults.has(taskKey)) {
|
|
1342
|
+
try { await announceTaskCompletion({ projectId: project.id, ticketId: task.id }) }
|
|
1343
|
+
catch (error) { log('agent result delivery pending: ' + (error?.message || error)) }
|
|
1344
|
+
}
|
|
1314
1345
|
if (taskIsCompleted(task, doneIds) || taskIsAwaitingReview(task, reviewIds)) {
|
|
1315
1346
|
memory.remember({ key: `ticket:${project.id}:${task.id}`, kind: 'ticket', state: 'handoff', summary: task.title, refs: { projectId: project.id, ticketId: task.id } })
|
|
1316
1347
|
if (pendingCompletionReports.has(taskKey)) {
|
|
@@ -1418,9 +1449,9 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1418
1449
|
const baseFor = (kind, delivery) => delivery?.watcherOwned
|
|
1419
1450
|
? (kind === 'full' ? fullPrompt + '\n\n' + guardedReplyPrompt : guardedReplyPrompt)
|
|
1420
1451
|
: kind === 'intro' ? INTRO : kind === 'full' ? fullPrompt : (kind === 'coord' || kind === 'sweep') ? coordinatePrompt : fastPrompt
|
|
1421
|
-
//
|
|
1422
|
-
//
|
|
1423
|
-
const cycleSucceeded = (result) => !!result && !result.is_error && [
|
|
1452
|
+
// A native final turn ends a cycle. Ticket completion is a separate board
|
|
1453
|
+
// action chosen by the agent; tool counts never determine either decision.
|
|
1454
|
+
const cycleSucceeded = (result) => !!result && !result.is_error && ['ok', 'success'].includes(result.subtype)
|
|
1424
1455
|
const releaseTaskForRetry = (taskRef, prompt) => {
|
|
1425
1456
|
const directProject = Number(taskRef?.projectId)
|
|
1426
1457
|
const directTicket = Number(taskRef?.ticketId)
|
|
@@ -1445,7 +1476,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1445
1476
|
emit('cycle.queued', { ...cycleData, status: 'queued' })
|
|
1446
1477
|
return queues[laneName].enqueue({ kind, context, targetChannels, taskRef, delivery, workdir: itemWorkdir, control }, key).then((result) => {
|
|
1447
1478
|
const status = control.cancelled || result?.status === 'canceled' ? 'canceled' : result?.status === 'failed' ? 'error' : control.outcome
|
|
1448
|
-
emit(status === 'canceled' ? 'cycle.cancelled' : 'cycle.finished', { ...cycleData, status, durationMs: Math.round(performance.now() - (control.startedAt ?? control.enqueuedAt)) })
|
|
1479
|
+
emit(status === 'canceled' ? 'cycle.cancelled' : 'cycle.finished', { ...cycleData, status, finishedBy: control.finishedBy || 'runtime', durationMs: Math.round(performance.now() - (control.startedAt ?? control.enqueuedAt)) })
|
|
1449
1480
|
return result
|
|
1450
1481
|
})
|
|
1451
1482
|
}
|
|
@@ -1461,6 +1492,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1461
1492
|
log(`cycle timing queue=${Math.round(cycleStartedAt - (cycleControl.enqueuedAt ?? cycleStartedAt))}ms kind=${kind}`)
|
|
1462
1493
|
const ctx = context ? [context] : []
|
|
1463
1494
|
const activeTaskRef = taskRef
|
|
1495
|
+
let verifiedTaskRevision = ''
|
|
1464
1496
|
const ticketWorktree = preparedWorkdir || (kind === 'full' && activeTaskRef ? findTicketWorktree(workdir, activeTaskRef.ticketId) : '')
|
|
1465
1497
|
const runnerOptions = {
|
|
1466
1498
|
cycleId: cycleControl.cycleId, attempt: 1,
|
|
@@ -1478,8 +1510,13 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1478
1510
|
const memoryRefs = delivery
|
|
1479
1511
|
? { channelId: delivery.channelId, threadId: delivery.parentId }
|
|
1480
1512
|
: activeTaskRef ? { projectId: activeTaskRef.projectId, ticketId: activeTaskRef.ticketId } : {}
|
|
1481
|
-
|
|
1482
|
-
|
|
1513
|
+
let recalled = ''
|
|
1514
|
+
try { recalled = await memory.context(memoryRefs) }
|
|
1515
|
+
catch (error) { log('Optional history unavailable; agent can retrieve context with its tools: ' + (error?.message || error)) }
|
|
1516
|
+
const capabilityContext = kind !== 'full' && canCode
|
|
1517
|
+
? 'YOUR CODING WORKSPACE IS AVAILABLE. If this request needs local execution or edits, call openvisio_request_work_session with the findings and context to carry forward, then end this turn. The same agent continues the same request in its coding workspace. Do not claim to be a chat-only agent or ask anyone to reassign the ticket.'
|
|
1518
|
+
: canCode ? 'This session has your configured coding workspace. Choose the tools and context appropriate to the request.' : 'This connection has no configured local coding workspace. Use your available tools for the request; do not claim local changes you cannot perform.'
|
|
1519
|
+
const prompt = identityContext + '\n\n' + capabilityContext + '\n\n' + (ctx.length ? ctx.join('\n') + '\n\n' : '') + (recalled ? recalled + '\n\n' : '') + baseFor(kind, delivery)
|
|
1483
1520
|
// Chat-shaped cycles (mentions/intro) may run on the cheaper chat model; code
|
|
1484
1521
|
// work (full/sweep) uses the main model.
|
|
1485
1522
|
refreshModelSettings()
|
|
@@ -1494,6 +1531,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1494
1531
|
if (activeTaskRef) {
|
|
1495
1532
|
const data = toolData(await callMcpTool('get_ticket', { project_id: activeTaskRef.projectId, ticket_id: activeTaskRef.ticketId }))
|
|
1496
1533
|
const ticket = data.ticket ?? data.task ?? data
|
|
1534
|
+
verifiedTaskRevision = taskRevision(ticket)
|
|
1497
1535
|
const typeSets = await taskTypeSets(activeTaskRef.projectId)
|
|
1498
1536
|
if (blockedTasks.has(`${activeTaskRef.projectId}:${activeTaskRef.ticketId}`) ||
|
|
1499
1537
|
!taskBelongsToAgent(ticket, { id: selfAgentId, identifier }) ||
|
|
@@ -1507,7 +1545,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1507
1545
|
cycleControl.outcome = 'running'
|
|
1508
1546
|
log(`cycle timing preflight=${Math.round(performance.now() - cycleStartedAt)}ms kind=${kind}`)
|
|
1509
1547
|
const result = await runner.runCycle(prompt, useModel, runnerOptions)
|
|
1510
|
-
cycleControl.outcome = result?.subtype || '
|
|
1548
|
+
cycleControl.outcome = result?.is_error ? 'error' : result?.subtype || 'error'
|
|
1511
1549
|
if (result?.timings) log(`cycle timing runtime=${JSON.stringify(result.timings)} kind=${kind}`)
|
|
1512
1550
|
refreshModelSettings()
|
|
1513
1551
|
if (cycleModelRevision === modelSettingsRevision && result?.model && result.model !== useModel) {
|
|
@@ -1518,7 +1556,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1518
1556
|
if (liteModel === useModel) { liteModel = result.model; changed = true }
|
|
1519
1557
|
if (changed) persistModel()
|
|
1520
1558
|
}
|
|
1521
|
-
|
|
1559
|
+
const completionResult = result
|
|
1522
1560
|
if (cycleControl.cancelled || result?.subtype === 'canceled') {
|
|
1523
1561
|
log(laneName + ' cycle cancelled; no blocker or reply will be published')
|
|
1524
1562
|
return
|
|
@@ -1539,56 +1577,36 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1539
1577
|
finally { if (activeTaskRef) await finalizeFailedTaskPause(activeTaskRef) }
|
|
1540
1578
|
return
|
|
1541
1579
|
}
|
|
1542
|
-
|
|
1543
|
-
|
|
1544
|
-
|
|
1545
|
-
|
|
1546
|
-
|
|
1547
|
-
|
|
1548
|
-
|
|
1580
|
+
if (result?.workRequest && kind !== 'full' && canCode) {
|
|
1581
|
+
// An agent-selected continuation, not a heuristic retry or a new task.
|
|
1582
|
+
// Preserve the authoritative recipient and cancellation key; the tool
|
|
1583
|
+
// cannot select another task, channel, identity, or permission scope.
|
|
1584
|
+
cycleControl.outcome = 'continued'
|
|
1585
|
+
cycleControl.finishedBy = 'agent'
|
|
1586
|
+
const continuation = String(result.workRequest.context || '').slice(0, 12000)
|
|
1587
|
+
const handoffKey = `continuation:${cycleControl.cycleId}`
|
|
1588
|
+
memory.remember({ key: handoffKey, kind: 'continuation', state: 'requested', summary: continuation, refs: memoryRefs, meta: { context: continuation, requestedBy: 'agent' } })
|
|
1589
|
+
const sourceKey = delivery?.sourceKey || (activeTaskRef ? `ticket:${activeTaskRef.projectId}:${activeTaskRef.ticketId}` : '')
|
|
1590
|
+
if (sourceKey) memory.connect(sourceKey, handoffKey, 'continued_with')
|
|
1591
|
+
emit('cycle.continued', { cycleId: cycleControl.cycleId, status: 'continued', reason: 'agent requested coding workspace' })
|
|
1592
|
+
void drain('full', `${context || ''}\n\nYOUR CONTINUATION CONTEXT:\n${continuation}\nContinue the original request using your configured workspace. Preserve the same role, voice, recipient, and authorization.`, targetChannels, activeTaskRef, delivery)
|
|
1549
1593
|
return
|
|
1550
1594
|
}
|
|
1551
|
-
|
|
1552
|
-
|
|
1553
|
-
|
|
1554
|
-
|
|
1555
|
-
|
|
1556
|
-
|
|
1557
|
-
|
|
1558
|
-
|
|
1559
|
-
|
|
1560
|
-
cycleControl.outcome = 'recovering'
|
|
1561
|
-
emit('cycle.recovery', { cycleId: cycleControl.cycleId, kind, status: 'recovering', attempt: 2, missing })
|
|
1562
|
-
log(agent + ' coding cycle incomplete; recovery requires: ' + missing.join(', '))
|
|
1563
|
-
const recoveryPrompt = `CONTINUE THE SAME OPENVISIO REQUEST. Your earlier output did not complete it. Missing runtime evidence: ${missing.join('; ')}. An intent or progress message is not completion. Continue the actual work now, verify it, and then provide one distinct final result or real blocker using the original delivery rule; a final result after an earlier progress message is explicitly allowed and required. Do not repeat the progress message. ${codexPushGuide}\n\nORIGINAL REQUEST AND ROUTING CONTEXT:\n${prompt}`
|
|
1564
|
-
const recovery = await runner.runCycle(recoveryPrompt, codeModel, { ...runnerOptions, attempt: 2 })
|
|
1565
|
-
cycleControl.outcome = recovery?.subtype || 'ok'
|
|
1566
|
-
if (cycleControl.cancelled || recovery?.subtype === 'canceled') return
|
|
1567
|
-
const recoveredResult = combineRuntimeWorkEvidence(result, recovery)
|
|
1568
|
-
const recoveryMissing = missingRuntimeWorkEvidence(recoveredResult, { ticketCycle, resultMessageRequired })
|
|
1569
|
-
if (!cycleSucceeded(recovery) || recoveryMissing.length) {
|
|
1570
|
-
cycleControl.outcome = 'blocked'
|
|
1571
|
-
if (recovery?.subtype === 'blocked' && recovery?.policyBlock) {
|
|
1572
|
-
try { await reportPolicyBlock(prompt, activeTaskRef, recovery.policyBlock, delivery) }
|
|
1573
|
-
catch (e) { log('failed to publish recovery policy blocker: ' + (e?.message || e)) }
|
|
1574
|
-
} else {
|
|
1575
|
-
const unresolved = recoveryMissing.length ? recoveryMissing : [`the recovery cycle ended with ${recovery?.subtype || 'an unknown error'}`]
|
|
1576
|
-
const notice = `I'm blocked after one recovery attempt. Missing required evidence: ${unresolved.join('; ')}. I've paused this revision until the ticket changes, and I'm not claiming completion.`
|
|
1577
|
-
if (activeTaskRef) pauseFailedTask(activeTaskRef)
|
|
1578
|
-
try { await publishBlocker({ prompt, taskRef: activeTaskRef, delivery, notice }) }
|
|
1579
|
-
catch (e) { log('failed to publish recovery blocker: ' + (e?.message || e)) }
|
|
1580
|
-
finally { if (activeTaskRef) await finalizeFailedTaskPause(activeTaskRef) }
|
|
1581
|
-
}
|
|
1582
|
-
log('WORK_CYCLE_FAILED evidence gate still incomplete after one recovery; ticket paused until its revision changes')
|
|
1583
|
-
return
|
|
1584
|
-
}
|
|
1585
|
-
completionResult = recoveredResult
|
|
1595
|
+
// The native runtime's successful final turn is the agent's decision to
|
|
1596
|
+
// yield. Tool activity is telemetry, not a universal completion checklist.
|
|
1597
|
+
// Optional failures and alternative workflows remain the agent's concern.
|
|
1598
|
+
cycleControl.outcome = 'ok'
|
|
1599
|
+
cycleControl.finishedBy = 'agent'
|
|
1600
|
+
if (result?.mcpErrors?.length) log('agent ended its turn with tool diagnostics: ' + result.mcpErrors.join(', '))
|
|
1601
|
+
if (activeTaskRef && !String(completionResult?.outputText || '').trim()) {
|
|
1602
|
+
finishedTaskVersions.set(`${activeTaskRef.projectId}:${activeTaskRef.ticketId}`, verifiedTaskRevision)
|
|
1603
|
+
trimMap(finishedTaskVersions); persistReplay()
|
|
1586
1604
|
}
|
|
1587
|
-
if (
|
|
1605
|
+
if (activeTaskRef) {
|
|
1588
1606
|
try {
|
|
1589
|
-
const delivered = await announceTaskCompletion(activeTaskRef, completionResult)
|
|
1607
|
+
const delivered = await announceTaskCompletion(activeTaskRef, completionResult, () => cycleControl.cancelled)
|
|
1590
1608
|
if (!delivered) {
|
|
1591
|
-
log('completion report deferred for ticket #' + activeTaskRef.ticketId + '; waiting for
|
|
1609
|
+
log('completion report deferred for ticket #' + activeTaskRef.ticketId + '; waiting for result delivery without rerunning the agent')
|
|
1592
1610
|
}
|
|
1593
1611
|
} catch (e) {
|
|
1594
1612
|
log('completion report failed for ticket #' + activeTaskRef.ticketId + ': ' + (e?.message || e) + '; retained for delivery retry without rerunning repository work')
|
|
@@ -1664,6 +1682,7 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1664
1682
|
const belongsToSelf = await resolveTaskOwner(ticket)
|
|
1665
1683
|
const key = `${projectId}:${ticketId}`
|
|
1666
1684
|
if (!belongsToSelf) {
|
|
1685
|
+
finishedTaskVersions.delete(key); pendingAgentResults.delete(key)
|
|
1667
1686
|
for (const [name, queue] of Object.entries(queues)) {
|
|
1668
1687
|
queue.cancel((item) => String(item.taskRef?.projectId) === String(projectId) && String(item.taskRef?.ticketId) === String(ticketId), (item) => {
|
|
1669
1688
|
item.control.cancelled = true
|
|
@@ -1673,6 +1692,13 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1673
1692
|
memory.remember({ key: `ticket:${projectId}:${ticketId}`, kind: 'ticket', state: 'unassigned', summary: ticket.title, refs: { projectId, ticketId } })
|
|
1674
1693
|
blockedTasks.delete(key); blockedTaskRepos.delete(key); pendingCompletionReports.delete(key); failedTaskVersions.delete(key); persistReplay(); seenTasks.delete(key); log(kind + ' ticket #' + ticketId + ' is not assigned to this agent — ignored'); return
|
|
1675
1694
|
}
|
|
1695
|
+
if (finishedTaskVersions.has(key)) {
|
|
1696
|
+
if (finishedTaskVersions.get(key) === taskRevision(ticket)) {
|
|
1697
|
+
if (pendingAgentResults.has(key)) await announceTaskCompletion({ projectId, ticketId })
|
|
1698
|
+
return
|
|
1699
|
+
}
|
|
1700
|
+
finishedTaskVersions.delete(key); seenTasks.delete(key); persistReplay()
|
|
1701
|
+
}
|
|
1676
1702
|
if (taskIsCompleted(ticket, typeSets.done) || taskIsAwaitingReview(ticket, typeSets.review)) {
|
|
1677
1703
|
memory.remember({ key: `ticket:${projectId}:${ticketId}`, kind: 'ticket', state: 'handoff', summary: ticket.title, refs: { projectId, ticketId } })
|
|
1678
1704
|
if (pendingCompletionReports.has(key)) {
|
|
@@ -1704,10 +1730,9 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1704
1730
|
log(kind + ' verified ticket #' + ticketId + ' “' + title + '” -> ' + cycleKind + ' lane')
|
|
1705
1731
|
const activityChannel = await projectStatusChannel(projectId)
|
|
1706
1732
|
if (activityChannel != null) sendStatus(activityChannel, 'thinking')
|
|
1707
|
-
if (cycleKind === 'full') { pendingCompletionReports.add(key); trimSeen(pendingCompletionReports); persistReplay() }
|
|
1708
1733
|
const humanTicketRef = ticketSlug ? `ticket ${ticketSlug}` : `the ticket “${title}”`
|
|
1709
1734
|
const workspaceDirective = preparedWorktree ? ` A prepared local git worktree for this ticket exists at ${JSON.stringify(preparedWorktree)}. Start repository inspection and edits there. Do not call list_codebases, codebase_tree, or get_codebase while this local worktree is available.` : ''
|
|
1710
|
-
void drain(cycleKind, `Authoritative get_ticket verification confirms ${humanTicketRef} is open and assigned to YOU. Internal tool identity: project_id ${projectId}, ticket_id ${ticketId}. For every get_ticket call pass exactly { project_id: ${projectId}, ticket_id: ${ticketId} }; for list_task_types pass exactly { project_id: ${projectId} }. Numeric ids are MCP arguments only and must never appear in human-facing text; use ${ticketSlug || 'the ticket title'} instead. Ticket details: ${JSON.stringify({ slug: ticketSlug, title, description: ticket.description, priority: ticket.priority, typeId: ticket.type_id ?? ticket.typeId })}.${workspaceDirective} This assignment has no source thread: do not call post_message yourself.
|
|
1735
|
+
void drain(cycleKind, `Authoritative get_ticket verification confirms ${humanTicketRef} is open and assigned to YOU. Internal tool identity: project_id ${projectId}, ticket_id ${ticketId}. For every get_ticket call pass exactly { project_id: ${projectId}, ticket_id: ${ticketId} }; for list_task_types pass exactly { project_id: ${projectId} }. Numeric ids are MCP arguments only and must never appear in human-facing text; use ${ticketSlug || 'the ticket title'} instead. Ticket details: ${JSON.stringify({ slug: ticketSlug, title, description: ticket.description, priority: ticket.priority, typeId: ticket.type_id ?? ticket.typeId })}.${workspaceDirective} This assignment has no source thread: do not call post_message yourself. Choose the tools, context, validation, and ticket state appropriate to this request. Return your final response when you decide this turn is finished; the watcher will publish it once in the dedicated agent channel without changing ticket status.`, activityChannel == null ? [] : [activityChannel], { projectId, ticketId, channelId: activityChannel })
|
|
1711
1736
|
} catch (e) {
|
|
1712
1737
|
log(kind + ' ticket verification failed for #' + ticketId + ': ' + (e?.message || e))
|
|
1713
1738
|
}
|
|
@@ -1891,8 +1916,8 @@ export function createBackendWatcher({ backend, wsUrl, apiKey, identifier, slug,
|
|
|
1891
1916
|
const replyDelivery = conversationDelivery(codingMention ? 'result' : 'reply', !codingMention)
|
|
1892
1917
|
let ctx = cid != null
|
|
1893
1918
|
? replyDelivery?.watcherOwned
|
|
1894
|
-
? `The watcher verified this source message is addressed to you in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". ${codingMention ? 'Complete the concrete repository work and verification first.' : 'Answer the request directly.'} Do NOT call post_message; it is intentionally unavailable. Return only the final reply as your final answer. The watcher will re-check the live thread and render it at most once.${who ? ` To mention the requester, use their exact full name "@${who}".` : ''}
|
|
1895
|
-
: `The watcher verified this source message is addressed to you in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". ${codingMention ? `This is concrete repository work. Start the coding flow now. You may send at most one concrete progress update after work begins, but do not stop there: continue the work and then send one distinct final result with evidence or a real blocker. Use post_message for the final result even if you already sent a progress message` : 'Send EXACTLY ONE reply with post_message'}: arguments: channel_id ${cid}${threadRoot != null ? `, parent_id ${threadRoot} (reply IN THAT THREAD, do not start a new top-level message)` : ''},
|
|
1919
|
+
? `The watcher verified this source message is addressed to you in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". ${codingMention ? 'Complete the concrete repository work and verification first.' : 'Answer the request directly.'} Do NOT call post_message; it is intentionally unavailable. Return only the final reply as your final answer. The watcher will re-check the live thread and render it at most once.${who ? ` To mention the requester, use their exact full name "@${who}".` : ''} Use additional discovery, resources, and history when they help answer this request.`
|
|
1920
|
+
: `The watcher verified this source message is addressed to you in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". ${codingMention ? `This is concrete repository work. Start the coding flow now. You may send at most one concrete progress update after work begins, but do not stop there: continue the work and then send one distinct final result with evidence or a real blocker. Use post_message for the final result even if you already sent a progress message` : 'Send EXACTLY ONE reply with post_message'}: arguments: channel_id ${cid}${threadRoot != null ? `, parent_id ${threadRoot} (reply IN THAT THREAD, do not start a new top-level message)` : ''}, using the authenticated session bridge. Never repeat the same message.${who ? ` To @mention them back, write their EXACT full name "@${who}". A mention only links when the name matches exactly.` : ''} Use additional discovery, resources, and history when they help answer this request.${codingMention ? ' Stop only after the work and final result/blocker.' : ' After your single reply, STOP.'}`
|
|
1896
1921
|
: undefined
|
|
1897
1922
|
if (ctx && creatingTicket) ctx += ' This is a ticket-creation request, not repository implementation. Discover create_ticket on the authenticated watcher server, resolve the project and valid type using list_projects and list_task_types, then create the requested ticket once. Follow its actual schema. If a required detail is ambiguous, ask for that detail rather than inventing it. Report the returned ticket reference. Never replay a creation after a timeout or uncertain response.'
|
|
1898
1923
|
if (ctx && raw._threadRootContent) ctx += ` Verified thread root authored by you (context, not a new request): ${JSON.stringify(raw._threadRootContent)}. For requested repairs, inspect the referenced PR and its branch, run the failing verification, and fix that existing work. A review/testing handoff does not prevent an explicit human repair request.`
|